#ifdef HAVE_QUOTA_SUPPORT
#ifdef __KERNEL__
-/* When quotaon, build a lqs for every uid/gid who has been set limitation
- * for quota. After quota_search_lqs, it will hold one ref for the lqs.
- * It will be released when qctxt_cleanup() is executed b=18574 */
-void build_lqs(struct obd_device *obd)
-{
- struct lustre_quota_ctxt *qctxt = &obd->u.obt.obt_qctxt;
- struct list_head id_list;
- int i, rc;
-
- INIT_LIST_HEAD(&id_list);
- for (i = 0; i < MAXQUOTAS; i++) {
- struct dquot_id *dqid, *tmp;
-
-#ifndef KERNEL_SUPPORTS_QUOTA_READ
- rc = fsfilt_qids(obd, sb_dqopt(qctxt->lqc_sb)->files[i], NULL,
- i, &id_list);
-#else
- rc = fsfilt_qids(obd, NULL, sb_dqopt(qctxt->lqc_sb)->files[i],
- i, &id_list);
-#endif
- if (rc) {
- CDEBUG(D_ERROR, "fail to get %s qids!\n",
- i ? "group" : "user");
- continue;
- }
-
- list_for_each_entry_safe(dqid, tmp, &id_list,
- di_link) {
- struct lustre_qunit_size *lqs;
-
- list_del_init(&dqid->di_link);
- lqs = quota_search_lqs(LQS_KEY(i, dqid->di_id),
- qctxt, 1);
- if (lqs && !IS_ERR(lqs)) {
- lqs->lqs_flags |= dqid->di_flag;
- lqs_putref(lqs);
- } else {
- CDEBUG(D_ERROR, "fail to create a lqs"
- "(%s id: %u)!\n", i ? "group" : "user",
- dqid->di_id);
- }
-
- OBD_FREE_PTR(dqid);
- }
- }
-}
-
int mds_quota_ctl(struct obd_device *obd, struct obd_export *unused,
struct obd_quotactl *oqctl)
{
int rc = 0;
ENTRY;
- do_gettimeofday(&work_start);
+ cfs_gettimeofday(&work_start);
switch (oqctl->qc_cmd) {
case Q_QUOTAON:
oqctl->qc_id = obt->obt_qfmt; /* override qfmt version */
rc = mds_quota_on(obd, oqctl);
- /* when quotaon, create lqs for every quota uid/gid b=18574 */
- build_lqs(obd);
break;
case Q_QUOTAOFF:
oqctl->qc_id = obt->obt_qfmt; /* override qfmt version */
CDEBUG(D_INFO, "mds_quotactl admin quota command %d, id %u, "
"type %d, failed: rc = %d\n",
oqctl->qc_cmd, oqctl->qc_id, oqctl->qc_type, rc);
- do_gettimeofday(&work_end);
+ cfs_gettimeofday(&work_end);
timediff = cfs_timeval_sub(&work_end, &work_start, NULL);
lprocfs_counter_add(qctxt->lqc_stats, LQUOTA_QUOTA_CTL, timediff);
struct obd_device *obd = exp->exp_obd;
struct obd_device_target *obt = &obd->u.obt;
struct lvfs_run_ctxt saved;
- struct lustre_quota_ctxt *qctxt = &obd->u.obt.obt_qctxt;
+ struct lustre_quota_ctxt *qctxt = &obt->obt_qctxt;
struct lustre_qunit_size *lqs;
void *handle = NULL;
struct timeval work_start;
int rc = 0;
ENTRY;
- do_gettimeofday(&work_start);
+ cfs_gettimeofday(&work_start);
switch (oqctl->qc_cmd) {
case Q_FINVALIDATE:
case Q_QUOTAON:
case Q_QUOTAOFF:
- if (!atomic_dec_and_test(&obt->obt_quotachecking)) {
- CDEBUG(D_INFO, "other people are doing quotacheck\n");
- atomic_inc(&obt->obt_quotachecking);
- rc = -EBUSY;
- break;
- }
+ cfs_down(&obt->obt_quotachecking);
if (oqctl->qc_cmd == Q_FINVALIDATE &&
(obt->obt_qctxt.lqc_flags & UGQUOTA2LQC(oqctl->qc_type))) {
- atomic_inc(&obt->obt_quotachecking);
+ CWARN("quota[%u] is on yet\n", oqctl->qc_type);
+ cfs_up(&obt->obt_quotachecking);
rc = -EBUSY;
break;
}
if (oqctl->qc_cmd == Q_QUOTAON || oqctl->qc_cmd == Q_QUOTAOFF ||
oqctl->qc_cmd == Q_FINVALIDATE) {
- if (!rc && oqctl->qc_cmd == Q_QUOTAON)
- obt->obt_qctxt.lqc_flags |= UGQUOTA2LQC(oqctl->qc_type);
- if (!rc && oqctl->qc_cmd == Q_QUOTAOFF)
- obt->obt_qctxt.lqc_flags &= ~UGQUOTA2LQC(oqctl->qc_type);
- atomic_inc(&obt->obt_quotachecking);
+ if (oqctl->qc_cmd == Q_QUOTAON) {
+ if (!rc) {
+ obt->obt_qctxt.lqc_flags |=
+ UGQUOTA2LQC(oqctl->qc_type);
+ /* when quotaon, create lqs for every
+ * quota uid/gid b=18574 */
+ build_lqs(obd);
+ } else if (rc == -EBUSY &&
+ quota_is_on(qctxt, oqctl)) {
+ rc = -EALREADY;
+ }
+ } else if (oqctl->qc_cmd == Q_QUOTAOFF) {
+ if (!rc)
+ obt->obt_qctxt.lqc_flags &=
+ ~UGQUOTA2LQC(oqctl->qc_type);
+ else if (quota_is_off(qctxt, oqctl))
+ rc = -EALREADY;
+ }
+ cfs_up(&obt->obt_quotachecking);
}
- /* when quotaon, create lqs for every quota uid/gid b=18574 */
- if (oqctl->qc_cmd == Q_QUOTAON)
- build_lqs(obd);
break;
case Q_SETQUOTA:
/* currently, it is only used for nullifying the quota */
lqs = quota_search_lqs(LQS_KEY(oqctl->qc_type, oqctl->qc_id),
qctxt, 0);
if (lqs == NULL || IS_ERR(lqs)){
- CDEBUG(D_ERROR, "fail to create lqs when setquota\n");
+ CERROR("fail to create lqs during setquota operation "
+ "for %sid %u\n", oqctl->qc_type ? "g" : "u",
+ oqctl->qc_id);
} else {
lqs->lqs_flags &= ~QB_SET;
lqs_putref(lqs);
lqs = quota_search_lqs(LQS_KEY(oqctl->qc_type, oqctl->qc_id),
qctxt, 1);
if (lqs == NULL || IS_ERR(lqs)){
- CDEBUG(D_ERROR, "fail to create lqs when setquota\n");
+ CERROR("fail to create lqs during setquota operation "
+ "for %sid %u\n", oqctl->qc_type ? "g" : "u",
+ oqctl->qc_id);
break;
} else {
lqs->lqs_flags |= QB_SET;
obd->obd_name, oqctl->qc_cmd);
RETURN(-EFAULT);
}
- do_gettimeofday(&work_end);
+ cfs_gettimeofday(&work_end);
timediff = cfs_timeval_sub(&work_end, &work_start, NULL);
lprocfs_counter_add(qctxt->lqc_stats, LQUOTA_QUOTA_CTL, timediff);
struct ptlrpc_request *req;
struct obd_quotactl *oqc;
const struct req_format *rf;
- int ver, opc, rc;
+ int ver, opc, rc, resends = 0;
ENTRY;
if (!strcmp(exp->exp_obd->obd_type->typ_name, LUSTRE_MDC_NAME)) {
RETURN(-EINVAL);
}
+restart_request:
+
req = ptlrpc_request_alloc_pack(class_exp2cliimp(exp), rf, ver, opc);
if (req == NULL)
RETURN(-ENOMEM);
*oqc = *oqctl;
ptlrpc_request_set_replen(req);
+ ptlrpc_at_set_req_timeout(req);
+ req->rq_no_resend = 1;
rc = ptlrpc_queue_wait(req);
if (rc) {
EXIT;
out:
ptlrpc_req_finished(req);
+
+ if (client_quota_recoverable_error(rc)) {
+ resends++;
+ if (!client_quota_should_resend(resends, &exp->exp_obd->u.cli)) {
+ CERROR("too many resend retries, returning error\n");
+ RETURN(-EIO);
+ }
+
+ goto restart_request;
+ }
+
return rc;
}