Whamcloud - gitweb
LU-12616 obclass: fix MDS start/stop race
[fs/lustre-release.git] / lustre / quota / qsd_writeback.c
index 7e82e77..3c4f0fd 100644 (file)
@@ -21,7 +21,7 @@
  * GPL HEADER END
  */
 /*
- * Copyright (c) 2012, 2014, Intel Corporation.
+ * Copyright (c) 2012, 2017, Intel Corporation.
  * Use is subject to license terms.
  *
  * Author: Johann Lombardi <johann.lombardi@intel.com>
@@ -121,9 +121,14 @@ static void qsd_add_deferred(struct qsd_instance *qsd, struct list_head *list,
                 * updates. We should just delete the legacy record in such
                 * case. */
                if (upd->qur_ver == tmp->qur_ver) {
-                       LASSERT(tmp->qur_lqe);
-                       LQUOTA_ERROR(tmp->qur_lqe, "Found a conflict record "
-                                    "with ver:"LPU64"", tmp->qur_ver);
+                       if (tmp->qur_lqe)
+                               LQUOTA_WARN(tmp->qur_lqe, "Found a conflict "
+                                           "record with ver:%llu",
+                                           tmp->qur_ver);
+                       else
+                               CWARN("%s: Found a conflict record with ver: "
+                                     "%llu\n", qsd->qsd_svname, tmp->qur_ver);
+
                        list_del_init(&tmp->qur_link);
                        qsd_upd_free(tmp);
                } else if (upd->qur_ver < tmp->qur_ver) {
@@ -151,7 +156,7 @@ static void qsd_kickoff_deferred(struct qsd_qtype_info *qqi,
                        /* drop this update */
                        list_del_init(&upd->qur_link);
                        CDEBUG(D_QUOTA, "%s: skipping deferred update ver:"
-                              LPU64"/"LPU64", global:%d, qid:"LPU64"\n",
+                              "%llu/%llu, global:%d, qid:%llu\n",
                               qqi->qqi_qsd->qsd_svname, upd->qur_ver, ver,
                               upd->qur_global, upd->qur_qid.qid_uid);
                        qsd_upd_free(upd);
@@ -165,11 +170,11 @@ static void qsd_kickoff_deferred(struct qsd_qtype_info *qqi,
                RETURN_EXIT;
 
        CDEBUG(D_QUOTA, "%s: found deferred update record. "
-              "version:"LPU64"/"LPU64", global:%d, qid:"LPU64"\n",
+              "version:%llu/%llu, global:%d, qid:%llu\n",
               qqi->qqi_qsd->qsd_svname, upd->qur_ver, ver,
               upd->qur_global, upd->qur_qid.qid_uid);
 
-       LASSERTF(upd->qur_ver > ver, "lur_ver:"LPU64", cur_ver:"LPU64"\n",
+       LASSERTF(upd->qur_ver > ver, "lur_ver:%llu, cur_ver:%llu\n",
                 upd->qur_ver, ver);
 
        /* Kick off the deferred udpate */
@@ -223,7 +228,7 @@ void qsd_upd_schedule(struct qsd_qtype_info *qqi, struct lquota_entry *lqe,
        __u64                    cur_ver;
        ENTRY;
 
-       CDEBUG(D_QUOTA, "%s: schedule update. global:%s, version:"LPU64"\n",
+       CDEBUG(D_QUOTA, "%s: schedule update. global:%s, version:%llu\n",
               qsd->qsd_svname, global ? "true" : "false", ver);
 
        upd = qsd_upd_alloc(qqi, lqe, qid, rec, ver, global);
@@ -248,11 +253,11 @@ void qsd_upd_schedule(struct qsd_qtype_info *qqi, struct lquota_entry *lqe,
                        /* legitimate race between glimpse AST and
                         * reintegration */
                        CDEBUG(D_QUOTA, "%s: discarding glb update from glimpse"
-                              " ver:"LPU64" local ver:"LPU64"\n",
+                              " ver:%llu local ver:%llu\n",
                               qsd->qsd_svname, ver, cur_ver);
                else
-                       CERROR("%s: discard slv update, ver:"LPU64" local ver:"
-                              LPU64"\n", qsd->qsd_svname, ver, cur_ver);
+                       CERROR("%s: discard slv update, ver:%llu local ver:"
+                              "%llu\n", qsd->qsd_svname, ver, cur_ver);
                qsd_upd_free(upd);
        } else if ((ver == cur_ver + 1) && qqi->qqi_glb_uptodate &&
                   qqi->qqi_slv_uptodate) {
@@ -293,6 +298,11 @@ static int qsd_process_upd(const struct lu_env *env, struct qsd_upd_rec *upd)
                        GOTO(out, rc);
                /* refresh usage */
                qsd_refresh_usage(env, lqe);
+
+               spin_lock(&qqi->qqi_qsd->qsd_adjust_lock);
+               lqe->lqe_adjust_time = 0;
+               spin_unlock(&qqi->qqi_qsd->qsd_adjust_lock);
+
                /* Report usage asynchronously */
                rc = qsd_adjust(env, lqe);
                if (rc)
@@ -302,6 +312,21 @@ static int qsd_process_upd(const struct lu_env *env, struct qsd_upd_rec *upd)
        rc = qsd_update_index(env, qqi, &upd->qur_qid, upd->qur_global,
                              upd->qur_ver, &upd->qur_rec);
 out:
+       if (upd->qur_global && rc == 0 &&
+           upd->qur_rec.lqr_glb_rec.qbr_softlimit == 0 &&
+           upd->qur_rec.lqr_glb_rec.qbr_hardlimit == 0 &&
+           (LQUOTA_FLAG(upd->qur_rec.lqr_glb_rec.qbr_time) &
+                                                       LQUOTA_FLAG_DEFAULT)) {
+               lqe->lqe_is_default = true;
+               if (qqi->qqi_default_softlimit == 0 &&
+                   qqi->qqi_default_hardlimit == 0)
+                       lqe->lqe_enforced = false;
+               else
+                       lqe->lqe_enforced = true;
+
+               LQUOTA_DEBUG(lqe, "update to use default quota");
+       }
+
        if (lqe && !IS_ERR(lqe)) {
                lqe_putref(lqe);
                upd->qur_lqe = NULL;
@@ -333,12 +358,14 @@ void qsd_adjust_schedule(struct lquota_entry *lqe, bool defer, bool cancel)
        }
 
        if (list_empty(&lqe->lqe_link)) {
-               if (cancel)
+               if (!cancel) {
+                       lqe->lqe_adjust_time = ktime_get_seconds();
+                       if (defer)
+                               lqe->lqe_adjust_time += QSD_WB_INTERVAL;
+               } else {
                        lqe->lqe_adjust_time = 0;
-               else
-                       lqe->lqe_adjust_time = defer ?
-                               cfs_time_shift_64(QSD_WB_INTERVAL) :
-                               cfs_time_current_64();
+               }
+
                /* lqe reference transferred to list */
                if (defer)
                        list_add_tail(&lqe->lqe_link,
@@ -371,8 +398,7 @@ static bool qsd_job_pending(struct qsd_instance *qsd, struct list_head *upd,
                struct lquota_entry *lqe;
                lqe = list_entry(qsd->qsd_adjust_list.next,
                                     struct lquota_entry, lqe_link);
-               if (cfs_time_beforeq_64(lqe->lqe_adjust_time,
-                                       cfs_time_current_64()))
+               if (ktime_get_seconds() >= lqe->lqe_adjust_time)
                        job_pending = true;
        }
        spin_unlock(&qsd->qsd_adjust_lock);
@@ -383,15 +409,13 @@ static bool qsd_job_pending(struct qsd_instance *qsd, struct list_head *upd,
                job_pending = true;
        }
 
-       if (qsd->qsd_acct_failed) {
+       for (qtype = USRQUOTA; qtype < LL_MAXQUOTAS; qtype++) {
+               struct qsd_qtype_info *qqi = qsd->qsd_type_array[qtype];
+
                /* don't bother kicking off reintegration if space accounting
                 * failed to be enabled */
-               write_unlock(&qsd->qsd_lock);
-               return job_pending;
-       }
-
-       for (qtype = USRQUOTA; qtype < MAXQUOTAS; qtype++) {
-               struct qsd_qtype_info *qqi = qsd->qsd_type_array[qtype];
+               if (qqi->qqi_acct_failed)
+                       continue;
 
                if (!qsd_type_enabled(qsd, qtype))
                        continue;
@@ -418,7 +442,7 @@ static int qsd_upd_thread(void *arg)
        int                      qtype, rc = 0;
        bool                     uptodate;
        struct lquota_entry     *lqe;
-       __u64                    cur_time;
+       time64_t cur_time;
        ENTRY;
 
        OBD_ALLOC_PTR(env);
@@ -449,13 +473,12 @@ static int qsd_upd_thread(void *arg)
                }
 
                spin_lock(&qsd->qsd_adjust_lock);
-               cur_time = cfs_time_current_64();
+               cur_time = ktime_get_seconds();
                while (!list_empty(&qsd->qsd_adjust_list)) {
                        lqe = list_entry(qsd->qsd_adjust_list.next,
                                         struct lquota_entry, lqe_link);
                        /* deferred items are sorted by time */
-                       if (!cfs_time_beforeq_64(lqe->lqe_adjust_time,
-                                                cur_time))
+                       if (lqe->lqe_adjust_time > cur_time)
                                break;
 
                        list_del_init(&lqe->lqe_link);
@@ -480,7 +503,7 @@ static int qsd_upd_thread(void *arg)
                if (uptodate)
                        continue;
 
-               for (qtype = USRQUOTA; qtype < MAXQUOTAS; qtype++)
+               for (qtype = USRQUOTA; qtype < LL_MAXQUOTAS; qtype++)
                        qsd_start_reint_thread(qsd->qsd_type_array[qtype]);
        }
        lu_env_fini(env);
@@ -516,7 +539,7 @@ static void qsd_cleanup_deferred(struct qsd_instance *qsd)
 {
        int     qtype;
 
-       for (qtype = USRQUOTA; qtype < MAXQUOTAS; qtype++) {
+       for (qtype = USRQUOTA; qtype < LL_MAXQUOTAS; qtype++) {
                struct qsd_upd_rec      *upd, *tmp;
                struct qsd_qtype_info   *qqi = qsd->qsd_type_array[qtype];
 
@@ -526,8 +549,8 @@ static void qsd_cleanup_deferred(struct qsd_instance *qsd)
                write_lock(&qsd->qsd_lock);
                list_for_each_entry_safe(upd, tmp, &qqi->qqi_deferred_glb,
                                         qur_link) {
-                       CWARN("%s: Free global deferred upd: ID:"LPU64", "
-                             "ver:"LPU64"/"LPU64"\n", qsd->qsd_svname,
+                       CWARN("%s: Free global deferred upd: ID:%llu, "
+                             "ver:%llu/%llu\n", qsd->qsd_svname,
                              upd->qur_qid.qid_uid, upd->qur_ver,
                              qqi->qqi_glb_ver);
                        list_del_init(&upd->qur_link);
@@ -535,8 +558,8 @@ static void qsd_cleanup_deferred(struct qsd_instance *qsd)
                }
                list_for_each_entry_safe(upd, tmp, &qqi->qqi_deferred_slv,
                                         qur_link) {
-                       CWARN("%s: Free slave deferred upd: ID:"LPU64", "
-                             "ver:"LPU64"/"LPU64"\n", qsd->qsd_svname,
+                       CWARN("%s: Free slave deferred upd: ID:%llu, "
+                             "ver:%llu/%llu\n", qsd->qsd_svname,
                              upd->qur_qid.qid_uid, upd->qur_ver,
                              qqi->qqi_slv_ver);
                        list_del_init(&upd->qur_link);