#include "qsd_internal.h"
typedef int (enqi_bl_cb_t)(struct ldlm_lock *lock,
- struct ldlm_lock_desc *desc, void *data,
- int flag);
+ struct ldlm_lock_desc *desc, void *data,
+ int flag);
static enqi_bl_cb_t qsd_glb_blocking_ast, qsd_id_blocking_ast;
typedef int (enqi_gl_cb_t)(struct ldlm_lock *lock, void *data);
* \param reset - whether lock->l_ast_data should be cleared
*/
static struct qsd_qtype_info *qsd_glb_ast_data_get(struct ldlm_lock *lock,
- bool reset) {
+ bool reset)
+{
struct qsd_qtype_info *qqi;
+
ENTRY;
lock_res_and_lock(lock);
qqi = lock->l_ast_data;
- if (qqi != NULL) {
+ if (qqi) {
qqi_getref(qqi);
if (reset)
lock->l_ast_data = NULL;
}
unlock_res_and_lock(lock);
- if (qqi != NULL)
+ if (qqi)
/* it is not safe to call lu_ref_add() under spinlock */
lu_ref_add(&qqi->qqi_reference, "ast_data_get", lock);
- if (reset && qqi != NULL) {
+ if (reset && qqi) {
/* release qqi reference hold for the lock */
lu_ref_del(&qqi->qqi_reference, "glb_lock", lock);
qqi_putref(qqi);
* \param reset - whether lock->l_ast_data should be cleared
*/
static struct lquota_entry *qsd_id_ast_data_get(struct ldlm_lock *lock,
- bool reset) {
+ bool reset)
+{
struct lquota_entry *lqe;
+
ENTRY;
lock_res_and_lock(lock);
lqe = lock->l_ast_data;
- if (lqe != NULL) {
+ if (lqe) {
lqe_getref(lqe);
if (reset)
lock->l_ast_data = NULL;
}
unlock_res_and_lock(lock);
- if (reset && lqe != NULL)
+ if (reset && lqe)
/* release lqe reference hold for the lock */
lqe_putref(lqe);
RETURN(lqe);
struct ldlm_gl_lquota_desc **desc, void **lvb)
{
int rc;
+
ENTRY;
LASSERT(lustre_msg_get_opc(req->rq_reqmsg) == LDLM_GL_CALLBACK);
/* extract glimpse descriptor */
*desc = req_capsule_client_get(&req->rq_pill, &RMF_DLM_GL_DESC);
- if (*desc == NULL)
+ if (!*desc)
RETURN(-EFAULT);
if (ptlrpc_req_need_swab(req))
int flag)
{
int rc = 0;
+
ENTRY;
- switch(flag) {
+ switch (flag) {
case LDLM_CB_BLOCKING: {
struct lustre_handle lockh;
LDLM_DEBUG(lock, "canceling global quota lock");
qqi = qsd_glb_ast_data_get(lock, true);
- if (qqi == NULL)
+ if (!qqi)
break;
- /* we are losing the global index lock, so let's mark the
- * global & slave indexes as not up-to-date any more */
+ /*
+ * we are losing the global index lock, so let's mark the
+ * global & slave indexes as not up-to-date any more
+ */
write_lock(&qqi->qqi_qsd->qsd_lock);
qqi->qqi_glb_uptodate = false;
qqi->qqi_slv_uptodate = false;
CDEBUG(D_QUOTA, "%s: losing global index lock for %s type\n",
qqi->qqi_qsd->qsd_svname, qtype_name((qqi->qqi_qtype)));
- /* kick off reintegration thread if not running already, if
+ /*
+ * kick off reintegration thread if not running already, if
* it's just local cancel (for stack clean up or eviction),
- * don't re-trigger the reintegration. */
+ * don't re-trigger the reintegration.
+ */
if (!ldlm_is_local_only(lock))
qsd_start_reint_thread(qqi);
static int qsd_entry_def_iter_cb(struct cfs_hash *hs, struct cfs_hash_bd *bd,
struct hlist_node *hnode, void *data)
{
- struct qsd_qtype_info *qqi = (struct qsd_qtype_info *)data;
- struct lquota_entry *lqe;
+ struct qsd_qtype_info *qqi = (struct qsd_qtype_info *)data;
+ struct lquota_entry *lqe;
lqe = hlist_entry(hnode, struct lquota_entry, lqe_hash);
LASSERT(atomic_read(&lqe->lqe_ref) > 0);
*/
static int qsd_glb_glimpse_ast(struct ldlm_lock *lock, void *data)
{
- struct ptlrpc_request *req = data;
- struct qsd_qtype_info *qqi;
- struct ldlm_gl_lquota_desc *desc;
- struct lquota_lvb *lvb;
- struct lquota_glb_rec rec;
- int rc;
+ struct ptlrpc_request *req = data;
+ struct qsd_qtype_info *qqi;
+ struct ldlm_gl_lquota_desc *desc;
+ struct lquota_lvb *lvb;
+ struct lquota_glb_rec rec;
+ int rc;
+
ENTRY;
rc = qsd_common_glimpse_ast(req, &desc, (void **)&lvb);
GOTO(out, rc);
qqi = qsd_glb_ast_data_get(lock, false);
- if (qqi == NULL)
+ if (!qqi)
/* valid race */
GOTO(out, rc = -ELDLM_NO_LOCK_DATA);
- CDEBUG(D_QUOTA, "%s: glimpse on glb quota locks, id:%llu ver:%llu"
- " hard:" "%llu soft:%llu\n", qqi->qqi_qsd->qsd_svname,
+ CDEBUG(D_QUOTA,
+ "%s: glimpse on glb quota locks, id:%llu ver:%llu hard:%llu soft:%llu\n",
+ qqi->qqi_qsd->qsd_svname,
desc->gl_id.qid_uid, desc->gl_ver, desc->gl_hardlimit,
desc->gl_softlimit);
qsd_update_default_quota(qqi, desc->gl_hardlimit,
desc->gl_softlimit, desc->gl_time);
- /* We can't afford disk io in the context of glimpse callback handling
- * thread, so the on-disk global limits update has to be deferred. */
+ /*
+ * We can't afford disk io in the context of glimpse callback handling
+ * thread, so the on-disk global limits update has to be deferred.
+ */
qsd_upd_schedule(qqi, NULL, &desc->gl_id, (union lquota_rec *)&rec,
desc->gl_ver, true);
EXIT;
* \param flag - LDLM_CB_BLOCKING or LDLM_CB_CANCELING. Used to distinguish
* cancellation and blocking ast's.
*/
-static int qsd_id_blocking_ast(struct ldlm_lock *lock, struct ldlm_lock_desc *desc,
+static int qsd_id_blocking_ast(struct ldlm_lock *lock,
+ struct ldlm_lock_desc *desc,
void *data, int flag)
{
- struct lustre_handle lockh;
- int rc = 0;
+ struct lustre_handle lockh;
+ int rc = 0;
+
ENTRY;
- switch(flag) {
+ switch (flag) {
case LDLM_CB_BLOCKING: {
LDLM_DEBUG(lock, "blocking AST on ID quota lock");
break;
}
case LDLM_CB_CANCELING: {
- struct lu_env *env;
- struct lquota_entry *lqe;
+ struct lu_env *env;
+ struct lquota_entry *lqe;
LDLM_DEBUG(lock, "canceling ID quota lock");
lqe = qsd_id_ast_data_get(lock, true);
- if (lqe == NULL)
+ if (!lqe)
break;
LQUOTA_DEBUG(lqe, "losing ID lock");
}
lqe_write_unlock(lqe);
- /* If there is dqacq inflight, the release will be skipped
+ /*
+ * If there is dqacq inflight, the release will be skipped
* at this time, and triggered on dqacq completion later,
* which means there could be a short window that slave is
- * holding spare grant wihtout per-ID lock. */
+ * holding spare grant wihtout per-ID lock.
+ */
- /* don't release quota space for local cancel (stack clean
- * up or eviction) */
+ /*
+ * don't release quota space for local cancel (stack clean
+ * up or eviction)
+ */
if (!ldlm_is_local_only(lock)) {
/* allocate environment */
OBD_ALLOC_PTR(env);
- if (env == NULL) {
+ if (!env) {
lqe_putref(lqe);
rc = -ENOMEM;
break;
*/
static int qsd_id_glimpse_ast(struct ldlm_lock *lock, void *data)
{
- struct ptlrpc_request *req = data;
- struct lquota_entry *lqe;
- struct ldlm_gl_lquota_desc *desc;
- struct lquota_lvb *lvb;
- int rc;
- bool wakeup = false;
+ struct ptlrpc_request *req = data;
+ struct lquota_entry *lqe;
+ struct ldlm_gl_lquota_desc *desc;
+ struct lquota_lvb *lvb;
+ int rc;
+ bool wakeup = false;
+
ENTRY;
rc = qsd_common_glimpse_ast(req, &desc, (void **)&lvb);
GOTO(out, rc);
lqe = qsd_id_ast_data_get(lock, false);
- if (lqe == NULL)
+ if (!lqe)
/* valid race */
GOTO(out, rc = -ELDLM_NO_LOCK_DATA);
if (space > 0) {
if (lqe->lqe_pending_req > 0) {
- LQUOTA_DEBUG(lqe, "request in flight, postpone "
- "release of %lld", space);
+ LQUOTA_DEBUG(lqe,
+ "request in flight, postpone release of %lld",
+ space);
lvb->lvb_id_may_rel = space;
} else {
lqe->lqe_pending_req++;
lqe_write_unlock(lqe);
/* change the lqe_granted */
- qsd_upd_schedule(lqe2qqi(lqe), lqe, &lqe->lqe_id,
- (union lquota_rec *)&lqe->lqe_granted,
- 0, false);
+ qsd_upd_schedule(lqe2qqi(lqe), lqe,
+ &lqe->lqe_id,
+ (union lquota_rec *)
+ &lqe->lqe_granted, 0, false);
lqe_write_lock(lqe);
lqe->lqe_pending_req--;
*/
int qsd_id_lock_match(struct lustre_handle *lockh, struct lustre_handle *rlockh)
{
- struct ldlm_lock *lock;
- int rc;
+ struct ldlm_lock *lock;
+ int rc;
+
ENTRY;
LASSERT(lockh);
LASSERT(lustre_handle_is_used(lockh));
ldlm_lock_dump_handle(D_QUOTA, lockh);
- if (rlockh == NULL)
+ if (!rlockh)
/* caller not interested in remote handle */
RETURN(0);
- /* look up lock associated with local handle and extract remote handle
- * to be packed in quota request */
+ /*
+ * look up lock associated with local handle and extract remote handle
+ * to be packed in quota request
+ */
lock = ldlm_handle2lock(lockh);
LASSERT(lock != NULL);
lustre_handle_copy(rlockh, &lock->l_remote_handle);
int qsd_id_lock_cancel(const struct lu_env *env, struct lquota_entry *lqe)
{
- struct qsd_thread_info *qti = qsd_info(env);
- int rc;
+ struct qsd_thread_info *qti = qsd_info(env);
+ int rc;
+
ENTRY;
lqe_write_lock(lqe);
git://git.whamcloud.com / fs / lustre-release.git / blobdiff