LU-16430 ptlrpc: racy rq_obsolete bit modification

[fs/lustre-release.git] / lustre / ptlrpc / service.c

diff --git a/lustre/ptlrpc/service.c b/lustre/ptlrpc/service.c
index 6c88753..7e3268f 100644 (file)
--- a/lustre/ptlrpc/service.c
+++ b/lustre/ptlrpc/service.c
@@ -1688,7 +1688,9 @@ found:
 #ifdef HAVE_SERVER_SUPPORT
 static void ptlrpc_server_mark_obsolete(struct ptlrpc_request *req)
 {
+       spin_lock(&req->rq_lock);
        req->rq_obsolete = 1;
+       spin_unlock(&req->rq_lock);
 }
 
 static void
@@ -1875,7 +1877,9 @@ static int ptlrpc_server_request_add(struct ptlrpc_service_part *svcpt,
                        ptlrpc_nrs_req_finalize(req);
 
                        /* don't mark slot unused for resend in progress */
+                       spin_lock(&req->rq_lock);
                        req->rq_obsolete = 1;
+                       spin_unlock(&req->rq_lock);
 
                        RETURN(-EBUSY);
                }