Whamcloud - gitweb
LU-12590 ptlrpc: check lm_bufcount and lm_buflen
[fs/lustre-release.git] / lustre / ptlrpc / pack_generic.c
index 21163e6..f59e47b 100644 (file)
@@ -60,13 +60,15 @@ static inline __u32 lustre_msg_hdr_size_v2(__u32 count)
 
 __u32 lustre_msg_hdr_size(__u32 magic, __u32 count)
 {
-        switch (magic) {
-        case LUSTRE_MSG_MAGIC_V2:
-                return lustre_msg_hdr_size_v2(count);
-        default:
-                LASSERTF(0, "incorrect message magic: %08x\n", magic);
+       LASSERT(count > 0);
+
+       switch (magic) {
+       case LUSTRE_MSG_MAGIC_V2:
+               return lustre_msg_hdr_size_v2(count);
+       default:
+               LASSERTF(0, "incorrect message magic: %08x\n", magic);
                return 0;
-        }
+       }
 }
 
 void ptlrpc_buf_set_swabbed(struct ptlrpc_request *req, const int inout,
@@ -116,32 +118,23 @@ int lustre_msg_check_version(struct lustre_msg *msg,
 /* early reply size */
 __u32 lustre_msg_early_size()
 {
-       static __u32 size;
-       if (!size) {
-               /* Always reply old ptlrpc_body_v2 to keep interoprability
-                * with the old client (< 2.3) which doesn't have pb_jobid
-                * in the ptlrpc_body.
-                *
-                * XXX Remove this whenever we dorp interoprability with such
-                *     client.
-                */
-               __u32 pblen = sizeof(struct ptlrpc_body_v2);
-               size = lustre_msg_size(LUSTRE_MSG_MAGIC_V2, 1, &pblen);
-       }
-       return size;
+       __u32 pblen = sizeof(struct ptlrpc_body);
+
+       return lustre_msg_size(LUSTRE_MSG_MAGIC_V2, 1, &pblen);
 }
 EXPORT_SYMBOL(lustre_msg_early_size);
 
 __u32 lustre_msg_size_v2(int count, __u32 *lengths)
 {
        __u32 size;
-        int i;
+       int i;
 
-        size = lustre_msg_hdr_size_v2(count);
-        for (i = 0; i < count; i++)
-                size += cfs_size_round(lengths[i]);
+       LASSERT(count > 0);
+       size = lustre_msg_hdr_size_v2(count);
+       for (i = 0; i < count; i++)
+               size += cfs_size_round(lengths[i]);
 
-        return size;
+       return size;
 }
 EXPORT_SYMBOL(lustre_msg_size_v2);
 
@@ -187,20 +180,22 @@ __u32 lustre_packed_msg_size(struct lustre_msg *msg)
 EXPORT_SYMBOL(lustre_packed_msg_size);
 
 void lustre_init_msg_v2(struct lustre_msg_v2 *msg, int count, __u32 *lens,
-                        char **bufs)
+                       char **bufs)
 {
-        char *ptr;
-        int i;
+       char *ptr;
+       int i;
 
-        msg->lm_bufcount = count;
-        /* XXX: lm_secflvr uninitialized here */
-        msg->lm_magic = LUSTRE_MSG_MAGIC_V2;
+       LASSERT(count > 0);
 
-        for (i = 0; i < count; i++)
-                msg->lm_buflens[i] = lens[i];
+       msg->lm_bufcount = count;
+       /* XXX: lm_secflvr uninitialized here */
+       msg->lm_magic = LUSTRE_MSG_MAGIC_V2;
 
-        if (bufs == NULL)
-                return;
+       for (i = 0; i < count; i++)
+               msg->lm_buflens[i] = lens[i];
+
+       if (bufs == NULL)
+               return;
 
        ptr = (char *)msg + lustre_msg_hdr_size_v2(count);
        for (i = 0; i < count; i++) {
@@ -327,24 +322,25 @@ void lustre_put_emerg_rs(struct ptlrpc_reply_state *rs)
 }
 
 int lustre_pack_reply_v2(struct ptlrpc_request *req, int count,
-                         __u32 *lens, char **bufs, int flags)
+                        __u32 *lens, char **bufs, int flags)
 {
-        struct ptlrpc_reply_state *rs;
-        int                        msg_len, rc;
-        ENTRY;
+       struct ptlrpc_reply_state *rs;
+       int                        msg_len, rc;
+       ENTRY;
 
-        LASSERT(req->rq_reply_state == NULL);
+       LASSERT(req->rq_reply_state == NULL);
+       LASSERT(count > 0);
 
-        if ((flags & LPRFL_EARLY_REPLY) == 0) {
+       if ((flags & LPRFL_EARLY_REPLY) == 0) {
                spin_lock(&req->rq_lock);
                req->rq_packed_final = 1;
                spin_unlock(&req->rq_lock);
-        }
+       }
 
-        msg_len = lustre_msg_size_v2(count, lens);
-        rc = sptlrpc_svc_alloc_rs(req, msg_len);
-        if (rc)
-                RETURN(rc);
+       msg_len = lustre_msg_size_v2(count, lens);
+       rc = sptlrpc_svc_alloc_rs(req, msg_len);
+       if (rc)
+               RETURN(rc);
 
        rs = req->rq_reply_state;
        atomic_set(&rs->rs_refcount, 1);        /* 1 ref for rq_reply_state */
@@ -356,16 +352,16 @@ int lustre_pack_reply_v2(struct ptlrpc_request *req, int count,
        INIT_LIST_HEAD(&rs->rs_list);
        spin_lock_init(&rs->rs_lock);
 
-        req->rq_replen = msg_len;
-        req->rq_reply_state = rs;
-        req->rq_repmsg = rs->rs_msg;
+       req->rq_replen = msg_len;
+       req->rq_reply_state = rs;
+       req->rq_repmsg = rs->rs_msg;
 
-        lustre_init_msg_v2(rs->rs_msg, count, lens, bufs);
-        lustre_msg_add_version(rs->rs_msg, PTLRPC_MSG_VERSION);
+       lustre_init_msg_v2(rs->rs_msg, count, lens, bufs);
+       lustre_msg_add_version(rs->rs_msg, PTLRPC_MSG_VERSION);
 
-        PTLRPC_RS_DEBUG_LRU_ADD(rs);
+       PTLRPC_RS_DEBUG_LRU_ADD(rs);
 
-        RETURN(0);
+       RETURN(0);
 }
 EXPORT_SYMBOL(lustre_pack_reply_v2);
 
@@ -409,28 +405,29 @@ void *lustre_msg_buf_v2(struct lustre_msg_v2 *m, __u32 n, __u32 min_size)
 {
        __u32 i, offset, buflen, bufcount;
 
-        LASSERT(m != NULL);
+       LASSERT(m != NULL);
+       LASSERT(m->lm_bufcount > 0);
 
-        bufcount = m->lm_bufcount;
-        if (unlikely(n >= bufcount)) {
-                CDEBUG(D_INFO, "msg %p buffer[%d] not present (count %d)\n",
-                       m, n, bufcount);
-                return NULL;
-        }
+       bufcount = m->lm_bufcount;
+       if (unlikely(n >= bufcount)) {
+               CDEBUG(D_INFO, "msg %p buffer[%d] not present (count %d)\n",
+                      m, n, bufcount);
+               return NULL;
+       }
 
-        buflen = m->lm_buflens[n];
-        if (unlikely(buflen < min_size)) {
-                CERROR("msg %p buffer[%d] size %d too small "
-                       "(required %d, opc=%d)\n", m, n, buflen, min_size,
-                       n == MSG_PTLRPC_BODY_OFF ? -1 : lustre_msg_get_opc(m));
-                return NULL;
-        }
+       buflen = m->lm_buflens[n];
+       if (unlikely(buflen < min_size)) {
+               CERROR("msg %p buffer[%d] size %d too small "
+                      "(required %d, opc=%d)\n", m, n, buflen, min_size,
+                      n == MSG_PTLRPC_BODY_OFF ? -1 : lustre_msg_get_opc(m));
+               return NULL;
+       }
 
-        offset = lustre_msg_hdr_size_v2(bufcount);
-        for (i = 0; i < n; i++)
-                offset += cfs_size_round(m->lm_buflens[i]);
+       offset = lustre_msg_hdr_size_v2(bufcount);
+       for (i = 0; i < n; i++)
+               offset += cfs_size_round(m->lm_buflens[i]);
 
-        return (char *)m + offset;
+       return (char *)m + offset;
 }
 
 void *lustre_msg_buf(struct lustre_msg *m, __u32 n, __u32 min_size)
@@ -523,52 +520,60 @@ void lustre_free_reply_state(struct ptlrpc_reply_state *rs)
 
 static int lustre_unpack_msg_v2(struct lustre_msg_v2 *m, int len)
 {
-        int swabbed, required_len, i;
+       int swabbed, required_len, i, buflen;
 
-        /* Now we know the sender speaks my language. */
-        required_len = lustre_msg_hdr_size_v2(0);
-        if (len < required_len) {
-                /* can't even look inside the message */
-                CERROR("message length %d too small for lustre_msg\n", len);
-                return -EINVAL;
-        }
+       /* Now we know the sender speaks my language. */
+       required_len = lustre_msg_hdr_size_v2(0);
+       if (len < required_len) {
+               /* can't even look inside the message */
+               CERROR("message length %d too small for lustre_msg\n", len);
+               return -EINVAL;
+       }
 
-        swabbed = (m->lm_magic == LUSTRE_MSG_MAGIC_V2_SWABBED);
-
-        if (swabbed) {
-                __swab32s(&m->lm_magic);
-                __swab32s(&m->lm_bufcount);
-                __swab32s(&m->lm_secflvr);
-                __swab32s(&m->lm_repsize);
-                __swab32s(&m->lm_cksum);
-                __swab32s(&m->lm_flags);
-                CLASSERT(offsetof(typeof(*m), lm_padding_2) != 0);
-                CLASSERT(offsetof(typeof(*m), lm_padding_3) != 0);
-        }
+       swabbed = (m->lm_magic == LUSTRE_MSG_MAGIC_V2_SWABBED);
 
-        required_len = lustre_msg_hdr_size_v2(m->lm_bufcount);
-        if (len < required_len) {
-                /* didn't receive all the buffer lengths */
-                CERROR ("message length %d too small for %d buflens\n",
-                        len, m->lm_bufcount);
-                return -EINVAL;
-        }
+       if (swabbed) {
+               __swab32s(&m->lm_magic);
+               __swab32s(&m->lm_bufcount);
+               __swab32s(&m->lm_secflvr);
+               __swab32s(&m->lm_repsize);
+               __swab32s(&m->lm_cksum);
+               __swab32s(&m->lm_flags);
+               CLASSERT(offsetof(typeof(*m), lm_padding_2) != 0);
+               CLASSERT(offsetof(typeof(*m), lm_padding_3) != 0);
+       }
 
-        for (i = 0; i < m->lm_bufcount; i++) {
-                if (swabbed)
-                        __swab32s(&m->lm_buflens[i]);
-                required_len += cfs_size_round(m->lm_buflens[i]);
-        }
+       if (m->lm_bufcount == 0 || m->lm_bufcount > PTLRPC_MAX_BUFCOUNT) {
+               CERROR("message bufcount %d is not valid\n", m->lm_bufcount);
+               return -EINVAL;
+       }
+       required_len = lustre_msg_hdr_size_v2(m->lm_bufcount);
+       if (len < required_len) {
+               /* didn't receive all the buffer lengths */
+               CERROR("message length %d too small for %d buflens\n",
+                      len, m->lm_bufcount);
+               return -EINVAL;
+       }
 
-        if (len < required_len) {
-                CERROR("len: %d, required_len %d\n", len, required_len);
-                CERROR("bufcount: %d\n", m->lm_bufcount);
-                for (i = 0; i < m->lm_bufcount; i++)
-                        CERROR("buffer %d length %d\n", i, m->lm_buflens[i]);
-                return -EINVAL;
-        }
+       for (i = 0; i < m->lm_bufcount; i++) {
+               if (swabbed)
+                       __swab32s(&m->lm_buflens[i]);
+               buflen = cfs_size_round(m->lm_buflens[i]);
+               if (buflen < 0 || buflen > PTLRPC_MAX_BUFLEN) {
+                       CERROR("buffer %d length %d is not valid\n", i, buflen);
+                       return -EINVAL;
+               }
+               required_len += buflen;
+       }
+       if (len < required_len || required_len > PTLRPC_MAX_BUFLEN) {
+               CERROR("len: %d, required_len %d, bufcount: %d\n",
+                      len, required_len, m->lm_bufcount);
+               for (i = 0; i < m->lm_bufcount; i++)
+                       CERROR("buffer %d length %d\n", i, m->lm_buflens[i]);
+               return -EINVAL;
+       }
 
-        return swabbed;
+       return swabbed;
 }
 
 int __lustre_unpack_msg(struct lustre_msg *m, int len)
@@ -836,7 +841,7 @@ __u32 lustre_msg_get_flags(struct lustre_msg *msg)
 
                CERROR("invalid msg %p: no ptlrpc body!\n", msg);
        }
-       /* no break */
+       /* fallthrough */
        default:
                /* flags might be printed in debug code while message
                 * uninitialized */
@@ -900,7 +905,7 @@ __u32 lustre_msg_get_op_flags(struct lustre_msg *msg)
 
                CERROR("invalid msg %p: no ptlrpc body!\n", msg);
        }
-       /* no break */
+       /* fallthrough */
        default:
                return 0;
        }
@@ -1105,7 +1110,7 @@ int lustre_msg_get_status(struct lustre_msg *msg)
                        return pb->pb_status;
                CERROR("invalid msg %p: no ptlrpc body!\n", msg);
        }
-       /* no break */
+       /* fallthrough */
        default:
                /* status might be printed in debug code while message
                * uninitialized */
@@ -1253,8 +1258,14 @@ char *lustre_msg_get_jobid(struct lustre_msg *msg)
 {
        switch (msg->lm_magic) {
        case LUSTRE_MSG_MAGIC_V2: {
-               struct ptlrpc_body *pb =
-                       lustre_msg_buf_v2(msg, MSG_PTLRPC_BODY_OFF,
+               struct ptlrpc_body *pb;
+
+               /* the old pltrpc_body_v2 is smaller; doesn't include jobid */
+               if (msg->lm_buflens[MSG_PTLRPC_BODY_OFF] <
+                   sizeof(struct ptlrpc_body))
+                       return NULL;
+
+               pb = lustre_msg_buf_v2(msg, MSG_PTLRPC_BODY_OFF,
                                          sizeof(struct ptlrpc_body));
                if (!pb)
                        return NULL;
@@ -1758,7 +1769,7 @@ void lustre_swab_obd_statfs (struct obd_statfs *os)
        __swab64s(&os->os_maxbytes);
        __swab32s(&os->os_state);
        __swab32s(&os->os_fprecreated);
-       CLASSERT(offsetof(typeof(*os), os_spare2) != 0);
+       __swab32s(&os->os_granted);
        CLASSERT(offsetof(typeof(*os), os_spare3) != 0);
        CLASSERT(offsetof(typeof(*os), os_spare4) != 0);
        CLASSERT(offsetof(typeof(*os), os_spare5) != 0);
@@ -1899,7 +1910,7 @@ void lustre_swab_mdt_body (struct mdt_body *b)
 
 void lustre_swab_mdt_ioepoch(struct mdt_ioepoch *b)
 {
-       /* mio_handle is opaque */
+       /* mio_open_handle is opaque */
        CLASSERT(offsetof(typeof(*b), mio_unused1) != 0);
        CLASSERT(offsetof(typeof(*b), mio_unused2) != 0);
        CLASSERT(offsetof(typeof(*b), mio_padding) != 0);
@@ -2068,6 +2079,7 @@ void lustre_swab_mdt_rec_reint (struct mdt_rec_reint *rr)
        __swab32s(&rr->rr_flags);
        __swab32s(&rr->rr_flags_h);
        __swab32s(&rr->rr_umask);
+       __swab16s(&rr->rr_mirror_id);
 
        CLASSERT(offsetof(typeof(*rr), rr_padding_4) != 0);
 };
@@ -2135,8 +2147,17 @@ EXPORT_SYMBOL(lustre_swab_lmv_user_md_objects);
 
 void lustre_swab_lmv_user_md(struct lmv_user_md *lum)
 {
-       __u32 count = lum->lum_stripe_count;
+       __u32 count;
+
+       if (lum->lum_magic == LMV_MAGIC_FOREIGN) {
+               __swab32s(&lum->lum_magic);
+               __swab32s(&((struct lmv_foreign_md *)lum)->lfm_length);
+               __swab32s(&((struct lmv_foreign_md *)lum)->lfm_type);
+               __swab32s(&((struct lmv_foreign_md *)lum)->lfm_flags);
+               return;
+       }
 
+       count = lum->lum_stripe_count;
        __swab32s(&lum->lum_magic);
        __swab32s(&lum->lum_stripe_count);
        __swab32s(&lum->lum_stripe_offset);
@@ -2146,6 +2167,7 @@ void lustre_swab_lmv_user_md(struct lmv_user_md *lum)
        switch (lum->lum_magic) {
        case LMV_USER_MAGIC_SPECIFIC:
                count = lum->lum_stripe_count;
+               /* fallthrough */
        case __swab32(LMV_USER_MAGIC_SPECIFIC):
                lustre_swab_lmv_user_md_objects(lum->lum_objects, count);
                break;
@@ -2220,6 +2242,9 @@ void lustre_print_user_md(unsigned int lvl, struct lov_user_md *lum,
                CDEBUG(lvl, "\tentry %d:\n", i);
                CDEBUG(lvl, "\tlcme_id: %#x\n", ent->lcme_id);
                CDEBUG(lvl, "\tlcme_flags: %#x\n", ent->lcme_flags);
+               if (ent->lcme_flags & LCME_FL_NOSYNC)
+                       CDEBUG(lvl, "\tlcme_timestamp: %llu\n",
+                                       ent->lcme_timestamp);
                CDEBUG(lvl, "\tlcme_extent.e_start: %llu\n",
                       ent->lcme_extent.e_start);
                CDEBUG(lvl, "\tlcme_extent.e_end: %llu\n",
@@ -2308,13 +2333,13 @@ void lustre_swab_lov_comp_md_v1(struct lov_comp_md_v1 *lum)
                }
                __swab32s(&ent->lcme_id);
                __swab32s(&ent->lcme_flags);
+               __swab64s(&ent->lcme_timestamp);
                __swab64s(&ent->lcme_extent.e_start);
                __swab64s(&ent->lcme_extent.e_end);
                __swab32s(&ent->lcme_offset);
                __swab32s(&ent->lcme_size);
                __swab32s(&ent->lcme_layout_gen);
                CLASSERT(offsetof(typeof(*ent), lcme_padding_1) != 0);
-               CLASSERT(offsetof(typeof(*ent), lcme_padding_2) != 0);
 
                v1 = (struct lov_user_md_v1 *)((char *)lum + off);
                stripe_count = v1->lmm_stripe_count;
@@ -2343,20 +2368,6 @@ void lustre_swab_lov_comp_md_v1(struct lov_comp_md_v1 *lum)
 }
 EXPORT_SYMBOL(lustre_swab_lov_comp_md_v1);
 
-void lustre_swab_lov_mds_md(struct lov_mds_md *lmm)
-{
-       ENTRY;
-       CDEBUG(D_IOCTL, "swabbing lov_mds_md\n");
-       __swab32s(&lmm->lmm_magic);
-       __swab32s(&lmm->lmm_pattern);
-       lustre_swab_lmm_oi(&lmm->lmm_oi);
-       __swab32s(&lmm->lmm_stripe_size);
-       __swab16s(&lmm->lmm_stripe_count);
-       __swab16s(&lmm->lmm_layout_gen);
-       EXIT;
-}
-EXPORT_SYMBOL(lustre_swab_lov_mds_md);
-
 void lustre_swab_lov_user_md_objects(struct lov_user_ost_data *lod,
                                      int stripe_count)
 {
@@ -2371,6 +2382,94 @@ void lustre_swab_lov_user_md_objects(struct lov_user_ost_data *lod,
 }
 EXPORT_SYMBOL(lustre_swab_lov_user_md_objects);
 
+void lustre_swab_lov_user_md(struct lov_user_md *lum, size_t size)
+{
+       struct lov_user_md_v1 *v1;
+       struct lov_user_md_v3 *v3;
+       struct lov_foreign_md *lfm;
+       __u16 stripe_count;
+       ENTRY;
+
+       CDEBUG(D_IOCTL, "swabbing lov_user_md\n");
+       switch (lum->lmm_magic) {
+       case __swab32(LOV_MAGIC_V1):
+       case LOV_USER_MAGIC_V1:
+       {
+               v1 = (struct lov_user_md_v1 *)lum;
+               stripe_count = v1->lmm_stripe_count;
+
+               if (lum->lmm_magic != LOV_USER_MAGIC_V1)
+                       __swab16s(&stripe_count);
+
+               lustre_swab_lov_user_md_v1(v1);
+               if (size > sizeof(*v1))
+                       lustre_swab_lov_user_md_objects(v1->lmm_objects,
+                                                       stripe_count);
+
+               break;
+       }
+       case __swab32(LOV_MAGIC_V3):
+       case LOV_USER_MAGIC_V3:
+       {
+               v3 = (struct lov_user_md_v3 *)lum;
+               stripe_count = v3->lmm_stripe_count;
+
+               if (lum->lmm_magic != LOV_USER_MAGIC_V3)
+                       __swab16s(&stripe_count);
+
+               lustre_swab_lov_user_md_v3(v3);
+               if (size > sizeof(*v3))
+                       lustre_swab_lov_user_md_objects(v3->lmm_objects,
+                                                       stripe_count);
+               break;
+       }
+       case __swab32(LOV_USER_MAGIC_SPECIFIC):
+       case LOV_USER_MAGIC_SPECIFIC:
+       {
+               v3 = (struct lov_user_md_v3 *)lum;
+               stripe_count = v3->lmm_stripe_count;
+
+               if (lum->lmm_magic != LOV_USER_MAGIC_SPECIFIC)
+                       __swab16s(&stripe_count);
+
+               lustre_swab_lov_user_md_v3(v3);
+               lustre_swab_lov_user_md_objects(v3->lmm_objects, stripe_count);
+               break;
+       }
+       case __swab32(LOV_MAGIC_COMP_V1):
+       case LOV_USER_MAGIC_COMP_V1:
+               lustre_swab_lov_comp_md_v1((struct lov_comp_md_v1 *)lum);
+               break;
+       case __swab32(LOV_MAGIC_FOREIGN):
+       case LOV_USER_MAGIC_FOREIGN:
+       {
+               lfm = (struct lov_foreign_md *)lum;
+               __swab32s(&lfm->lfm_magic);
+               __swab32s(&lfm->lfm_length);
+               __swab32s(&lfm->lfm_type);
+               __swab32s(&lfm->lfm_flags);
+               break;
+       }
+       default:
+               CDEBUG(D_IOCTL, "Invalid LOV magic %08x\n", lum->lmm_magic);
+       }
+}
+EXPORT_SYMBOL(lustre_swab_lov_user_md);
+
+void lustre_swab_lov_mds_md(struct lov_mds_md *lmm)
+{
+       ENTRY;
+       CDEBUG(D_IOCTL, "swabbing lov_mds_md\n");
+       __swab32s(&lmm->lmm_magic);
+       __swab32s(&lmm->lmm_pattern);
+       lustre_swab_lmm_oi(&lmm->lmm_oi);
+       __swab32s(&lmm->lmm_stripe_size);
+       __swab16s(&lmm->lmm_stripe_count);
+       __swab16s(&lmm->lmm_layout_gen);
+       EXIT;
+}
+EXPORT_SYMBOL(lustre_swab_lov_mds_md);
+
 void lustre_swab_ldlm_res_id (struct ldlm_res_id *id)
 {
         int  i;
@@ -2464,54 +2563,51 @@ void dump_obdo(struct obdo *oa)
        if (valid & OBD_MD_FLFID)
                CDEBUG(D_RPCTRACE, "obdo: o_parent_seq = %#llx\n",
                       oa->o_parent_seq);
-        if (valid & OBD_MD_FLSIZE)
+       if (valid & OBD_MD_FLSIZE)
                CDEBUG(D_RPCTRACE, "obdo: o_size = %lld\n", oa->o_size);
-        if (valid & OBD_MD_FLMTIME)
+       if (valid & OBD_MD_FLMTIME)
                CDEBUG(D_RPCTRACE, "obdo: o_mtime = %lld\n", oa->o_mtime);
-        if (valid & OBD_MD_FLATIME)
+       if (valid & OBD_MD_FLATIME)
                CDEBUG(D_RPCTRACE, "obdo: o_atime = %lld\n", oa->o_atime);
-        if (valid & OBD_MD_FLCTIME)
+       if (valid & OBD_MD_FLCTIME)
                CDEBUG(D_RPCTRACE, "obdo: o_ctime = %lld\n", oa->o_ctime);
-        if (valid & OBD_MD_FLBLOCKS)   /* allocation of space */
+       if (valid & OBD_MD_FLBLOCKS)   /* allocation of space */
                CDEBUG(D_RPCTRACE, "obdo: o_blocks = %lld\n", oa->o_blocks);
-        if (valid & OBD_MD_FLGRANT)
+       if (valid & OBD_MD_FLGRANT)
                CDEBUG(D_RPCTRACE, "obdo: o_grant = %lld\n", oa->o_grant);
-        if (valid & OBD_MD_FLBLKSZ)
-                CDEBUG(D_RPCTRACE, "obdo: o_blksize = %d\n", oa->o_blksize);
-        if (valid & (OBD_MD_FLTYPE | OBD_MD_FLMODE))
-                CDEBUG(D_RPCTRACE, "obdo: o_mode = %o\n",
-                       oa->o_mode & ((valid & OBD_MD_FLTYPE ?  S_IFMT : 0) |
-                                     (valid & OBD_MD_FLMODE ? ~S_IFMT : 0)));
-        if (valid & OBD_MD_FLUID)
-                CDEBUG(D_RPCTRACE, "obdo: o_uid = %u\n", oa->o_uid);
-        if (valid & OBD_MD_FLUID)
-                CDEBUG(D_RPCTRACE, "obdo: o_uid_h = %u\n", oa->o_uid_h);
-        if (valid & OBD_MD_FLGID)
-                CDEBUG(D_RPCTRACE, "obdo: o_gid = %u\n", oa->o_gid);
-        if (valid & OBD_MD_FLGID)
-                CDEBUG(D_RPCTRACE, "obdo: o_gid_h = %u\n", oa->o_gid_h);
-        if (valid & OBD_MD_FLFLAGS)
-                CDEBUG(D_RPCTRACE, "obdo: o_flags = %x\n", oa->o_flags);
-        if (valid & OBD_MD_FLNLINK)
-                CDEBUG(D_RPCTRACE, "obdo: o_nlink = %u\n", oa->o_nlink);
-        else if (valid & OBD_MD_FLCKSUM)
-                CDEBUG(D_RPCTRACE, "obdo: o_checksum (o_nlink) = %u\n",
-                       oa->o_nlink);
-        if (valid & OBD_MD_FLGENER)
-                CDEBUG(D_RPCTRACE, "obdo: o_parent_oid = %x\n",
-                       oa->o_parent_oid);
-        if (valid & OBD_MD_FLEPOCH)
-               CDEBUG(D_RPCTRACE, "obdo: o_ioepoch = %lld\n",
-                       oa->o_ioepoch);
-        if (valid & OBD_MD_FLFID) {
-                CDEBUG(D_RPCTRACE, "obdo: o_stripe_idx = %u\n",
-                       oa->o_stripe_idx);
-                CDEBUG(D_RPCTRACE, "obdo: o_parent_ver = %x\n",
-                       oa->o_parent_ver);
-        }
-        if (valid & OBD_MD_FLHANDLE)
+       if (valid & OBD_MD_FLBLKSZ)
+               CDEBUG(D_RPCTRACE, "obdo: o_blksize = %d\n", oa->o_blksize);
+       if (valid & (OBD_MD_FLTYPE | OBD_MD_FLMODE))
+               CDEBUG(D_RPCTRACE, "obdo: o_mode = %o\n",
+                      oa->o_mode & ((valid & OBD_MD_FLTYPE ?  S_IFMT : 0) |
+                                    (valid & OBD_MD_FLMODE ? ~S_IFMT : 0)));
+       if (valid & OBD_MD_FLUID)
+               CDEBUG(D_RPCTRACE, "obdo: o_uid = %u\n", oa->o_uid);
+       if (valid & OBD_MD_FLUID)
+               CDEBUG(D_RPCTRACE, "obdo: o_uid_h = %u\n", oa->o_uid_h);
+       if (valid & OBD_MD_FLGID)
+               CDEBUG(D_RPCTRACE, "obdo: o_gid = %u\n", oa->o_gid);
+       if (valid & OBD_MD_FLGID)
+               CDEBUG(D_RPCTRACE, "obdo: o_gid_h = %u\n", oa->o_gid_h);
+       if (valid & OBD_MD_FLFLAGS)
+               CDEBUG(D_RPCTRACE, "obdo: o_flags = %x\n", oa->o_flags);
+       if (valid & OBD_MD_FLNLINK)
+               CDEBUG(D_RPCTRACE, "obdo: o_nlink = %u\n", oa->o_nlink);
+       else if (valid & OBD_MD_FLCKSUM)
+               CDEBUG(D_RPCTRACE, "obdo: o_checksum (o_nlink) = %u\n",
+                      oa->o_nlink);
+       if (valid & OBD_MD_FLPARENT)
+               CDEBUG(D_RPCTRACE, "obdo: o_parent_oid = %x\n",
+                      oa->o_parent_oid);
+       if (valid & OBD_MD_FLFID) {
+               CDEBUG(D_RPCTRACE, "obdo: o_stripe_idx = %u\n",
+                      oa->o_stripe_idx);
+               CDEBUG(D_RPCTRACE, "obdo: o_parent_ver = %x\n",
+                      oa->o_parent_ver);
+       }
+       if (valid & OBD_MD_FLHANDLE)
                CDEBUG(D_RPCTRACE, "obdo: o_handle = %lld\n",
-                       oa->o_handle.cookie);
+                      oa->o_handle.cookie);
 }
 
 void dump_ost_body(struct ost_body *ob)
@@ -2558,6 +2654,7 @@ void _debug_req(struct ptlrpc_request *req,
        bool req_ok = req->rq_reqmsg != NULL;
        bool rep_ok = false;
        lnet_nid_t nid = LNET_NID_ANY;
+       struct va_format vaf;
        va_list args;
        int rep_flags = -1;
        int rep_status = -1;
@@ -2583,25 +2680,30 @@ void _debug_req(struct ptlrpc_request *req,
                nid = req->rq_export->exp_connection->c_peer.nid;
 
        va_start(args, fmt);
-       libcfs_debug_vmsg2(msgdata, fmt, args,
-                          " req@%p x%llu/t%lld(%lld) o%d->%s@%s:%d/%d lens %d/%d e %d to %lld dl %lld ref %d fl " REQ_FLAGS_FMT "/%x/%x rc %d/%d\n",
-                          req, req->rq_xid, req->rq_transno,
-                          req_ok ? lustre_msg_get_transno(req->rq_reqmsg) : 0,
-                          req_ok ? lustre_msg_get_opc(req->rq_reqmsg) : -1,
-                          req->rq_import ?
-                               req->rq_import->imp_obd->obd_name :
-                               req->rq_export ?
-                                       req->rq_export->exp_client_uuid.uuid :
-                                       "<?>",
-                          libcfs_nid2str(nid),
-                          req->rq_request_portal, req->rq_reply_portal,
-                          req->rq_reqlen, req->rq_replen,
-                          req->rq_early_count, (s64)req->rq_timedout,
-                          (s64)req->rq_deadline,
-                          atomic_read(&req->rq_refcount),
-                          DEBUG_REQ_FLAGS(req),
-                          req_ok ? lustre_msg_get_flags(req->rq_reqmsg) : -1,
-                          rep_flags, req->rq_status, rep_status);
+       vaf.fmt = fmt;
+       vaf.va = &args;
+       libcfs_debug_msg(msgdata,
+                        "%pV req@%p x%llu/t%lld(%lld) o%d->%s@%s:%d/%d lens %d/%d e %d to %lld dl %lld ref %d fl " REQ_FLAGS_FMT "/%x/%x rc %d/%d job:'%s'\n",
+                        &vaf,
+                        req, req->rq_xid, req->rq_transno,
+                        req_ok ? lustre_msg_get_transno(req->rq_reqmsg) : 0,
+                        req_ok ? lustre_msg_get_opc(req->rq_reqmsg) : -1,
+                        req->rq_import ?
+                        req->rq_import->imp_obd->obd_name :
+                        req->rq_export ?
+                        req->rq_export->exp_client_uuid.uuid :
+                        "<?>",
+                        libcfs_nid2str(nid),
+                        req->rq_request_portal, req->rq_reply_portal,
+                        req->rq_reqlen, req->rq_replen,
+                        req->rq_early_count, (s64)req->rq_timedout,
+                        (s64)req->rq_deadline,
+                        atomic_read(&req->rq_refcount),
+                        DEBUG_REQ_FLAGS(req),
+                        req_ok ? lustre_msg_get_flags(req->rq_reqmsg) : -1,
+                        rep_flags, req->rq_status, rep_status,
+                        req_ok ? lustre_msg_get_jobid(req->rq_reqmsg) ?: ""
+                               : "");
        va_end(args);
 }
 EXPORT_SYMBOL(_debug_req);