LU-14724 nrs: TBF rule list broken when change rule rank

[fs/lustre-release.git] / lustre / ptlrpc / nrs_tbf.c

diff --git a/lustre/ptlrpc/nrs_tbf.c b/lustre/ptlrpc/nrs_tbf.c
index 32adf79..653b55e 100644 (file)
--- a/lustre/ptlrpc/nrs_tbf.c
+++ b/lustre/ptlrpc/nrs_tbf.c
@@ -390,7 +390,8 @@ nrs_tbf_rule_change_rank(struct ptlrpc_nrs_policy *policy,
        if (!next_rule)
                GOTO(out_put, rc = -ENOENT);
 
-       list_move(&rule->tr_linkage, next_rule->tr_linkage.prev);
+       /* rules may be adjacent in same list, so list_move() isn't safe here */
+       list_move_tail(&rule->tr_linkage, &next_rule->tr_linkage);
        nrs_tbf_rule_put(next_rule);
 out_put:
        nrs_tbf_rule_put(rule);