Whamcloud - gitweb
LU-13004 ptlrpc: Allow BULK_BUF_KIOV to accept a kvec
[fs/lustre-release.git] / lustre / ptlrpc / import.c
index 2e7ac0e..ab38eb5 100644 (file)
@@ -37,6 +37,7 @@
 #define DEBUG_SUBSYSTEM S_RPC
 
 #include <linux/kthread.h>
+#include <linux/delay.h>
 #include <obd_support.h>
 #include <lustre_ha.h>
 #include <lustre_net.h>
@@ -55,10 +56,10 @@ struct ptlrpc_connect_async_args {
 
 /**
  * Updates import \a imp current state to provided \a state value
- * Helper function. Must be called under imp_lock.
+ * Helper function.
  */
-static void __import_set_state(struct obd_import *imp,
-                               enum lustre_imp_state state)
+static void import_set_state_nolock(struct obd_import *imp,
+                                   enum lustre_imp_state state)
 {
        switch (state) {
        case LUSTRE_IMP_CLOSED:
@@ -71,7 +72,20 @@ static void __import_set_state(struct obd_import *imp,
                break;
        default:
                imp->imp_replay_state = LUSTRE_IMP_REPLAY;
+               break;
        }
+
+       /* A CLOSED import should remain so. */
+       if (state == LUSTRE_IMP_CLOSED)
+               return;
+
+       if (imp->imp_state != LUSTRE_IMP_NEW) {
+               CDEBUG(D_HA, "%p %s: changing import state from %s to %s\n",
+                      imp, obd2cli_tgt(imp->imp_obd),
+                      ptlrpc_import_state_name(imp->imp_state),
+                      ptlrpc_import_state_name(state));
+       }
+
         imp->imp_state = state;
         imp->imp_state_hist[imp->imp_state_hist_idx].ish_state = state;
         imp->imp_state_hist[imp->imp_state_hist_idx].ish_time =
@@ -80,35 +94,24 @@ static void __import_set_state(struct obd_import *imp,
                 IMP_STATE_HIST_LEN;
 }
 
-/* A CLOSED import should remain so. */
-#define IMPORT_SET_STATE_NOLOCK(imp, state)                                    \
-do {                                                                           \
-        if (imp->imp_state != LUSTRE_IMP_CLOSED) {                             \
-               CDEBUG(D_HA, "%p %s: changing import state from %s to %s\n",    \
-                      imp, obd2cli_tgt(imp->imp_obd),                          \
-                      ptlrpc_import_state_name(imp->imp_state),                \
-                      ptlrpc_import_state_name(state));                        \
-               __import_set_state(imp, state);                                 \
-        }                                                                      \
-} while(0)
-
-#define IMPORT_SET_STATE(imp, state)                                   \
-do {                                                                   \
-       spin_lock(&imp->imp_lock);                                      \
-       IMPORT_SET_STATE_NOLOCK(imp, state);                            \
-       spin_unlock(&imp->imp_lock);                                    \
-} while(0)
+static void import_set_state(struct obd_import *imp,
+                            enum lustre_imp_state new_state)
+{
+       spin_lock(&imp->imp_lock);
+       import_set_state_nolock(imp, new_state);
+       spin_unlock(&imp->imp_lock);
+}
 
 void ptlrpc_import_enter_resend(struct obd_import *imp)
 {
-       IMPORT_SET_STATE(imp, LUSTRE_IMP_RECOVER);
+       import_set_state(imp, LUSTRE_IMP_RECOVER);
 }
 EXPORT_SYMBOL(ptlrpc_import_enter_resend);
 
 
 static int ptlrpc_connect_interpret(const struct lu_env *env,
-                                    struct ptlrpc_request *request,
-                                    void * data, int rc);
+                                   struct ptlrpc_request *request,
+                                   void *args, int rc);
 int ptlrpc_import_recovery_state_machine(struct obd_import *imp);
 
 /* Only this function is allowed to change the import state when it is
@@ -145,6 +148,21 @@ void deuuidify(char *uuid, const char *prefix, char **uuid_start, int *uuid_len)
                 *uuid_len -= strlen(UUID_STR);
 }
 
+/* Must be called with imp_lock held! */
+static void ptlrpc_deactivate_import_nolock(struct obd_import *imp)
+{
+       ENTRY;
+
+       assert_spin_locked(&imp->imp_lock);
+       CDEBUG(D_HA, "setting import %s INVALID\n", obd2cli_tgt(imp->imp_obd));
+       imp->imp_invalid = 1;
+       imp->imp_generation++;
+
+       ptlrpc_abort_inflight(imp);
+
+       EXIT;
+}
+
 /**
  * Returns true if import was FULL, false if import was already not
  * connected.
@@ -155,8 +173,10 @@ void deuuidify(char *uuid, const char *prefix, char **uuid_start, int *uuid_len)
  *             bulk requests) and if one has already caused a reconnection
  *             (increasing the import->conn_cnt) the older failure should
  *             not also cause a reconnection.  If zero it forces a reconnect.
+ * @invalid - set import invalid flag
  */
-int ptlrpc_set_import_discon(struct obd_import *imp, __u32 conn_cnt)
+int ptlrpc_set_import_discon(struct obd_import *imp,
+                            __u32 conn_cnt, bool invalid)
 {
        int rc = 0;
 
@@ -166,10 +186,12 @@ int ptlrpc_set_import_discon(struct obd_import *imp, __u32 conn_cnt)
             (conn_cnt == 0 || conn_cnt == imp->imp_conn_cnt)) {
                 char *target_start;
                 int   target_len;
+               bool  inact = false;
 
                 deuuidify(obd2cli_tgt(imp->imp_obd), NULL,
                           &target_start, &target_len);
 
+               import_set_state_nolock(imp, LUSTRE_IMP_DISCON);
                 if (imp->imp_replayable) {
                         LCONSOLE_WARN("%s: Connection to %.*s (at %s) was "
                                "lost; in progress operations using this "
@@ -182,14 +204,25 @@ int ptlrpc_set_import_discon(struct obd_import *imp, __u32 conn_cnt)
                               "operations using this service will fail\n",
                               imp->imp_obd->obd_name, target_len, target_start,
                               obd_import_nid2str(imp));
+                       if (invalid) {
+                               CDEBUG(D_HA, "import %s@%s for %s not "
+                                      "replayable, auto-deactivating\n",
+                                      obd2cli_tgt(imp->imp_obd),
+                                      imp->imp_connection->c_remote_uuid.uuid,
+                                      imp->imp_obd->obd_name);
+                               ptlrpc_deactivate_import_nolock(imp);
+                               inact = true;
+                       }
                }
-               IMPORT_SET_STATE_NOLOCK(imp, LUSTRE_IMP_DISCON);
                spin_unlock(&imp->imp_lock);
 
                if (obd_dump_on_timeout)
                        libcfs_debug_dumplog();
 
                obd_import_event(imp->imp_obd, imp, IMP_EVENT_DISCON);
+
+               if (inact)
+                       obd_import_event(imp->imp_obd, imp, IMP_EVENT_INACTIVE);
                rc = 1;
        } else {
                spin_unlock(&imp->imp_lock);
@@ -204,23 +237,6 @@ int ptlrpc_set_import_discon(struct obd_import *imp, __u32 conn_cnt)
         return rc;
 }
 
-/* Must be called with imp_lock held! */
-static void ptlrpc_deactivate_and_unlock_import(struct obd_import *imp)
-{
-       ENTRY;
-       assert_spin_locked(&imp->imp_lock);
-
-       CDEBUG(D_HA, "setting import %s INVALID\n", obd2cli_tgt(imp->imp_obd));
-       imp->imp_invalid = 1;
-       imp->imp_generation++;
-       spin_unlock(&imp->imp_lock);
-
-       ptlrpc_abort_inflight(imp);
-       obd_import_event(imp->imp_obd, imp, IMP_EVENT_INACTIVE);
-
-       EXIT;
-}
-
 /*
  * This acts as a barrier; all existing requests are rejected, and
  * no new requests will be accepted until the import is valid again.
@@ -228,7 +244,10 @@ static void ptlrpc_deactivate_and_unlock_import(struct obd_import *imp)
 void ptlrpc_deactivate_import(struct obd_import *imp)
 {
        spin_lock(&imp->imp_lock);
-       ptlrpc_deactivate_and_unlock_import(imp);
+       ptlrpc_deactivate_import_nolock(imp);
+       spin_unlock(&imp->imp_lock);
+
+       obd_import_event(imp->imp_obd, imp, IMP_EVENT_INACTIVE);
 }
 EXPORT_SYMBOL(ptlrpc_deactivate_import);
 
@@ -256,7 +275,7 @@ static time64_t ptlrpc_inflight_deadline(struct ptlrpc_request *req,
         return dl - now;
 }
 
-static unsigned int ptlrpc_inflight_timeout(struct obd_import *imp)
+static time64_t ptlrpc_inflight_timeout(struct obd_import *imp)
 {
        time64_t now = ktime_get_real_seconds();
        struct list_head *tmp, *n;
@@ -291,30 +310,35 @@ void ptlrpc_invalidate_import(struct obd_import *imp)
        if (!imp->imp_invalid || imp->imp_obd->obd_no_recov)
                ptlrpc_deactivate_import(imp);
 
+       if (OBD_FAIL_PRECHECK(OBD_FAIL_PTLRPC_CONNECT_RACE)) {
+               OBD_RACE(OBD_FAIL_PTLRPC_CONNECT_RACE);
+               msleep(10 * MSEC_PER_SEC);
+       }
        CFS_FAIL_TIMEOUT(OBD_FAIL_MGS_CONNECT_NET, 3 * cfs_fail_val / 2);
        LASSERT(imp->imp_invalid);
 
-        /* Wait forever until inflight == 0. We really can't do it another
-         * way because in some cases we need to wait for very long reply
-         * unlink. We can't do anything before that because there is really
-         * no guarantee that some rdma transfer is not in progress right now. */
-        do {
+       /* Wait forever until inflight == 0. We really can't do it another
+        * way because in some cases we need to wait for very long reply
+        * unlink. We can't do anything before that because there is really
+        * no guarantee that some rdma transfer is not in progress right now.
+        */
+       do {
                long timeout_jiffies;
 
-                /* Calculate max timeout for waiting on rpcs to error
-                 * out. Use obd_timeout if calculated value is smaller
+               /* Calculate max timeout for waiting on rpcs to error
+                * out. Use obd_timeout if calculated value is smaller
                 * than it.
                 */
-                if (!OBD_FAIL_CHECK(OBD_FAIL_PTLRPC_LONG_REPL_UNLINK)) {
-                        timeout = ptlrpc_inflight_timeout(imp);
-                        timeout += timeout / 3;
-
-                        if (timeout == 0)
-                                timeout = obd_timeout;
-                } else {
-                        /* decrease the interval to increase race condition */
-                        timeout = 1;
-                }
+               if (!OBD_FAIL_CHECK(OBD_FAIL_PTLRPC_LONG_REPL_UNLINK)) {
+                       timeout = ptlrpc_inflight_timeout(imp);
+                       timeout += div_u64(timeout, 3);
+
+                       if (timeout == 0)
+                               timeout = obd_timeout;
+               } else {
+                       /* decrease the interval to increase race condition */
+                       timeout = 1;
+               }
 
                CDEBUG(D_RPCTRACE, "Sleeping %llds for inflight to error out\n",
                       timeout);
@@ -326,8 +350,8 @@ void ptlrpc_invalidate_import(struct obd_import *imp)
                timeout_jiffies = max_t(long, cfs_time_seconds(timeout), 1);
                lwi = LWI_TIMEOUT_INTERVAL(timeout_jiffies,
                                           (timeout > 1) ? cfs_time_seconds(1) :
-                                                          cfs_time_seconds(1) / 2,
-                                                          NULL, NULL);
+                                          cfs_time_seconds(1) / 2,
+                                          NULL, NULL);
                rc = l_wait_event(imp->imp_recovery_waitq,
                                  (atomic_read(&imp->imp_inflight) == 0),
                                  &lwi);
@@ -373,7 +397,7 @@ void ptlrpc_invalidate_import(struct obd_import *imp)
                                }
 
                                CERROR("%s: Unregistering RPCs found (%d). "
-                                      "Network is sluggish? Waiting them "
+                                      "Network is sluggish? Waiting for them "
                                       "to error out.\n", cli_tgt,
                                       atomic_read(&imp->imp_unregistering));
                        }
@@ -395,17 +419,23 @@ void ptlrpc_invalidate_import(struct obd_import *imp)
 EXPORT_SYMBOL(ptlrpc_invalidate_import);
 
 /* unset imp_invalid */
-void ptlrpc_activate_import(struct obd_import *imp)
+void ptlrpc_activate_import(struct obd_import *imp, bool set_state_full)
 {
        struct obd_device *obd = imp->imp_obd;
 
        spin_lock(&imp->imp_lock);
        if (imp->imp_deactive != 0) {
+               LASSERT(imp->imp_state != LUSTRE_IMP_FULL);
+               if (imp->imp_state != LUSTRE_IMP_DISCON)
+                       import_set_state_nolock(imp, LUSTRE_IMP_DISCON);
                spin_unlock(&imp->imp_lock);
                return;
        }
+       if (set_state_full)
+               import_set_state_nolock(imp, LUSTRE_IMP_FULL);
 
        imp->imp_invalid = 0;
+
        spin_unlock(&imp->imp_lock);
        obd_import_event(obd, imp, IMP_EVENT_ACTIVE);
 }
@@ -427,22 +457,13 @@ EXPORT_SYMBOL(ptlrpc_pinger_force);
 
 void ptlrpc_fail_import(struct obd_import *imp, __u32 conn_cnt)
 {
-        ENTRY;
-
-        LASSERT(!imp->imp_dlm_fake);
+       ENTRY;
 
-        if (ptlrpc_set_import_discon(imp, conn_cnt)) {
-                if (!imp->imp_replayable) {
-                        CDEBUG(D_HA, "import %s@%s for %s not replayable, "
-                               "auto-deactivating\n",
-                               obd2cli_tgt(imp->imp_obd),
-                               imp->imp_connection->c_remote_uuid.uuid,
-                               imp->imp_obd->obd_name);
-                        ptlrpc_deactivate_import(imp);
-                }
+       LASSERT(!imp->imp_dlm_fake);
 
+       if (ptlrpc_set_import_discon(imp, conn_cnt, true))
                ptlrpc_pinger_force(imp);
-       }
+
        EXIT;
 }
 
@@ -450,7 +471,6 @@ int ptlrpc_reconnect_import(struct obd_import *imp)
 {
 #ifdef ENABLE_PINGER
        long timeout_jiffies = cfs_time_seconds(obd_timeout);
-       struct l_wait_info lwi;
        int rc;
 
        ptlrpc_pinger_force(imp);
@@ -458,14 +478,18 @@ int ptlrpc_reconnect_import(struct obd_import *imp)
        CDEBUG(D_HA, "%s: recovery started, waiting %u seconds\n",
               obd2cli_tgt(imp->imp_obd), obd_timeout);
 
-       lwi = LWI_TIMEOUT(timeout_jiffies, NULL, NULL);
-       rc = l_wait_event(imp->imp_recovery_waitq,
-                         !ptlrpc_import_in_recovery(imp), &lwi);
+       rc = wait_event_idle_timeout(imp->imp_recovery_waitq,
+                                    !ptlrpc_import_in_recovery(imp),
+                                    timeout_jiffies);
+       if (rc == 0)
+               rc = -ETIMEDOUT;
+       else
+               rc = 0;
        CDEBUG(D_HA, "%s: recovery finished s:%s\n", obd2cli_tgt(imp->imp_obd),
               ptlrpc_import_state_name(imp->imp_state));
        return rc;
 #else
-       ptlrpc_set_import_discon(imp, 0);
+       ptlrpc_set_import_discon(imp, 0, false);
        /* Force a new connect attempt */
        ptlrpc_invalidate_import(imp);
        /* Do a fresh connect next time by zeroing the handle */
@@ -486,7 +510,7 @@ int ptlrpc_reconnect_import(struct obd_import *imp)
        /* Allow reconnect attempts */
        imp->imp_obd->obd_no_recov = 0;
        /* Remove 'invalid' flag */
-       ptlrpc_activate_import(imp);
+       ptlrpc_activate_import(imp, false);
        /* Attempt a new connect */
        ptlrpc_recover_import(imp, NULL, 0);
        return 0;
@@ -594,6 +618,7 @@ static int import_select_connection(struct obd_import *imp)
                 imp->imp_conn_current = imp_conn;
         }
 
+       /* The below message is checked in conf-sanity.sh test_35[ab] */
         CDEBUG(D_HA, "%s: import %p using connection %s/%s\n",
                imp->imp_obd->obd_name, imp, imp_conn->oic_uuid.uuid,
                libcfs_nid2str(imp_conn->oic_conn->c_peer.nid));
@@ -618,7 +643,8 @@ static int ptlrpc_first_transno(struct obd_import *imp, __u64 *transno)
                req = list_entry(tmp, struct ptlrpc_request, rq_replay_list);
                *transno = req->rq_transno;
                if (req->rq_transno == 0) {
-                       DEBUG_REQ(D_ERROR, req, "zero transno in committed_list");
+                       DEBUG_REQ(D_ERROR, req,
+                                 "zero transno in committed_list");
                        LBUG();
                }
                return 1;
@@ -636,29 +662,41 @@ static int ptlrpc_first_transno(struct obd_import *imp, __u64 *transno)
        return 0;
 }
 
+int ptlrpc_connect_import(struct obd_import *imp)
+{
+       spin_lock(&imp->imp_lock);
+       return ptlrpc_connect_import_locked(imp);
+}
+
 /**
  * Attempt to (re)connect import \a imp. This includes all preparations,
  * initializing CONNECT RPC request and passing it to ptlrpcd for
  * actual sending.
+ *
+ * Assumes imp->imp_lock is held, and releases it.
+ *
  * Returns 0 on success or error code.
  */
-int ptlrpc_connect_import(struct obd_import *imp)
+int ptlrpc_connect_import_locked(struct obd_import *imp)
 {
        struct obd_device *obd = imp->imp_obd;
        int initial_connect = 0;
        int set_transno = 0;
        __u64 committed_before_reconnect = 0;
        struct ptlrpc_request *request;
+       struct obd_connect_data ocd;
        char *bufs[] = { NULL,
                         obd2cli_tgt(imp->imp_obd),
                         obd->obd_uuid.uuid,
                         (char *)&imp->imp_dlm_handle,
-                        (char *)&imp->imp_connect_data };
+                        (char *)&ocd,
+                        NULL };
        struct ptlrpc_connect_async_args *aa;
        int rc;
        ENTRY;
 
-       spin_lock(&imp->imp_lock);
+       assert_spin_locked(&imp->imp_lock);
+
        if (imp->imp_state == LUSTRE_IMP_CLOSED) {
                spin_unlock(&imp->imp_lock);
                CERROR("can't connect to a closed import\n");
@@ -668,13 +706,14 @@ int ptlrpc_connect_import(struct obd_import *imp)
                CERROR("already connected\n");
                RETURN(0);
        } else if (imp->imp_state == LUSTRE_IMP_CONNECTING ||
+                  imp->imp_state == LUSTRE_IMP_EVICTED ||
                   imp->imp_connected) {
                spin_unlock(&imp->imp_lock);
                CERROR("already connecting\n");
                RETURN(-EALREADY);
        }
 
-       IMPORT_SET_STATE_NOLOCK(imp, LUSTRE_IMP_CONNECTING);
+       import_set_state_nolock(imp, LUSTRE_IMP_CONNECTING);
 
        imp->imp_conn_cnt++;
        imp->imp_resend_replay = 0;
@@ -698,15 +737,16 @@ int ptlrpc_connect_import(struct obd_import *imp)
 
        /* Reset connect flags to the originally requested flags, in case
         * the server is updated on-the-fly we will get the new features. */
-       imp->imp_connect_data.ocd_connect_flags = imp->imp_connect_flags_orig;
-       imp->imp_connect_data.ocd_connect_flags2 = imp->imp_connect_flags2_orig;
+       ocd = imp->imp_connect_data;
+       ocd.ocd_connect_flags = imp->imp_connect_flags_orig;
+       ocd.ocd_connect_flags2 = imp->imp_connect_flags2_orig;
        /* Reset ocd_version each time so the server knows the exact versions */
-       imp->imp_connect_data.ocd_version = LUSTRE_VERSION_CODE;
+       ocd.ocd_version = LUSTRE_VERSION_CODE;
        imp->imp_msghdr_flags &= ~MSGHDR_AT_SUPPORT;
        imp->imp_msghdr_flags &= ~MSGHDR_CKSUM_INCOMPAT18;
 
        rc = obd_reconnect(NULL, imp->imp_obd->obd_self_export, obd,
-                          &obd->obd_uuid, &imp->imp_connect_data, NULL);
+                          &obd->obd_uuid, &ocd, NULL);
        if (rc)
                GOTO(out, rc);
 
@@ -714,6 +754,19 @@ int ptlrpc_connect_import(struct obd_import *imp)
        if (request == NULL)
                GOTO(out, rc = -ENOMEM);
 
+       /* get SELinux policy info if any */
+       rc = sptlrpc_get_sepol(request);
+       if (rc < 0) {
+               ptlrpc_request_free(request);
+               GOTO(out, rc);
+       }
+
+       bufs[5] = request->rq_sepol;
+
+       req_capsule_set_size(&request->rq_pill, &RMF_SELINUX_POL, RCL_CLIENT,
+                            strlen(request->rq_sepol) ?
+                            strlen(request->rq_sepol) + 1 : 0);
+
        rc = ptlrpc_request_bufs_pack(request, LUSTRE_OBD_VERSION,
                                      imp->imp_connect_op, bufs, NULL);
        if (rc) {
@@ -742,8 +795,7 @@ int ptlrpc_connect_import(struct obd_import *imp)
        ptlrpc_request_set_replen(request);
        request->rq_interpret_reply = ptlrpc_connect_interpret;
 
-       CLASSERT(sizeof(*aa) <= sizeof(request->rq_async_args));
-       aa = ptlrpc_req_async_args(request);
+       aa = ptlrpc_req_async_args(aa, request);
        memset(aa, 0, sizeof *aa);
 
        aa->pcaa_peer_committed = committed_before_reconnect;
@@ -767,7 +819,7 @@ int ptlrpc_connect_import(struct obd_import *imp)
        rc = 0;
 out:
        if (rc != 0)
-               IMPORT_SET_STATE(imp, LUSTRE_IMP_DISCON);
+               import_set_state(imp, LUSTRE_IMP_DISCON);
 
        RETURN(rc);
 }
@@ -791,17 +843,16 @@ static int ptlrpc_busy_reconnect(int rc)
 }
 
 static int ptlrpc_connect_set_flags(struct obd_import *imp,
-                                    struct obd_connect_data *ocd,
-                                    __u64 old_connect_flags,
-                                    struct obd_export *exp, int init_connect)
+                                   struct obd_connect_data *ocd,
+                                   __u64 old_connect_flags,
+                                   struct obd_export *exp, int init_connect)
 {
        static bool warned;
        struct client_obd *cli = &imp->imp_obd->u.cli;
 
        spin_lock(&imp->imp_lock);
-       list_del(&imp->imp_conn_current->oic_item);
-       list_add(&imp->imp_conn_current->oic_item,
-                &imp->imp_conn_list);
+       list_move(&imp->imp_conn_current->oic_item,
+                 &imp->imp_conn_list);
        imp->imp_last_success_conn =
                imp->imp_conn_current->oic_last_attempt;
 
@@ -836,13 +887,13 @@ static int ptlrpc_connect_set_flags(struct obd_import *imp,
                 * for algorithms we understand. The server masked off
                 * the checksum types it doesn't support */
                if ((ocd->ocd_cksum_types &
-                    cksum_types_supported_client()) == 0) {
+                    obd_cksum_types_supported_client()) == 0) {
                        LCONSOLE_ERROR("The negotiation of the checksum "
                                       "alogrithm to use with server %s "
                                       "failed (%x/%x)\n",
                                       obd2cli_tgt(imp->imp_obd),
                                       ocd->ocd_cksum_types,
-                                      cksum_types_supported_client());
+                                      obd_cksum_types_supported_client());
                        return -EPROTO;
                } else {
                        cli->cl_supp_cksum_types = ocd->ocd_cksum_types;
@@ -852,7 +903,9 @@ static int ptlrpc_connect_set_flags(struct obd_import *imp,
                 * Enforce ADLER for backward compatibility*/
                cli->cl_supp_cksum_types = OBD_CKSUM_ADLER;
        }
-       cli->cl_cksum_type = cksum_type_select(cli->cl_supp_cksum_types);
+       cli->cl_cksum_type = obd_cksum_type_select(imp->imp_obd->obd_name,
+                                                 cli->cl_supp_cksum_types,
+                                                 cli->cl_preferred_cksum_type);
 
        if (ocd->ocd_connect_flags & OBD_CONNECT_BRW_SIZE)
                cli->cl_max_pages_per_rpc =
@@ -881,13 +934,17 @@ static int ptlrpc_connect_set_flags(struct obd_import *imp,
         * this leads to losing user settings done before such as
         * disable lru_resize, etc. */
        if (old_connect_flags != exp_connect_flags(exp) || init_connect) {
+               struct ldlm_namespace *ns = imp->imp_obd->obd_namespace;
+               __u64 changed_flags;
+
+               changed_flags =
+                       ns->ns_connect_flags ^ ns->ns_orig_connect_flags;
                CDEBUG(D_HA, "%s: Resetting ns_connect_flags to server "
                             "flags: %#llx\n", imp->imp_obd->obd_name,
                             ocd->ocd_connect_flags);
-               imp->imp_obd->obd_namespace->ns_connect_flags =
-                       ocd->ocd_connect_flags;
-               imp->imp_obd->obd_namespace->ns_orig_connect_flags =
-                       ocd->ocd_connect_flags;
+               ns->ns_connect_flags = (ns->ns_connect_flags & changed_flags) |
+                                     (ocd->ocd_connect_flags & ~changed_flags);
+               ns->ns_orig_connect_flags = ocd->ocd_connect_flags;
        }
 
        if (ocd->ocd_connect_flags & OBD_CONNECT_AT)
@@ -946,14 +1003,14 @@ static void ptlrpc_prepare_replay(struct obd_import *imp)
  * full state for normal operations of disconnect it due to an error.
  */
 static int ptlrpc_connect_interpret(const struct lu_env *env,
-                                    struct ptlrpc_request *request,
-                                    void *data, int rc)
+                                   struct ptlrpc_request *request,
+                                   void *data, int rc)
 {
-        struct ptlrpc_connect_async_args *aa = data;
-        struct obd_import *imp = request->rq_import;
-        struct lustre_handle old_hdl;
-        __u64 old_connect_flags;
-        int msg_flags;
+       struct ptlrpc_connect_async_args *aa = data;
+       struct obd_import *imp = request->rq_import;
+       struct lustre_handle old_hdl;
+       __u64 old_connect_flags;
+       int msg_flags;
        struct obd_connect_data *ocd;
        struct obd_export *exp = NULL;
        int ret;
@@ -966,7 +1023,23 @@ static int ptlrpc_connect_interpret(const struct lu_env *env,
                RETURN(0);
        }
 
+       imp->imp_connect_error = rc;
        if (rc) {
+               struct ptlrpc_request *free_req;
+               struct ptlrpc_request *tmp;
+
+               /* abort all delayed requests initiated connection */
+               list_for_each_entry_safe(free_req, tmp, &imp->imp_delayed_list,
+                                        rq_list) {
+                       spin_lock(&free_req->rq_lock);
+                       if (free_req->rq_no_resend) {
+                               free_req->rq_err = 1;
+                               free_req->rq_status = -EIO;
+                               ptlrpc_client_wake_req(free_req);
+                       }
+                       spin_unlock(&free_req->rq_lock);
+               }
+
                /* if this reconnect to busy export - not need select new target
                 * for connecting*/
                imp->imp_force_reconnect = ptlrpc_busy_reconnect(rc);
@@ -1000,10 +1073,10 @@ static int ptlrpc_connect_interpret(const struct lu_env *env,
 
        spin_lock(&imp->imp_lock);
 
-        /* All imports are pingable */
-        imp->imp_pingable = 1;
-        imp->imp_force_reconnect = 0;
-        imp->imp_force_verify = 0;
+       /* All imports are pingable */
+       imp->imp_pingable = 1;
+       imp->imp_force_reconnect = 0;
+       imp->imp_force_verify = 0;
 
        imp->imp_connect_data = *ocd;
 
@@ -1074,7 +1147,8 @@ static int ptlrpc_connect_interpret(const struct lu_env *env,
         * because may reflect other routing, etc. */
        at_reinit(&imp->imp_at.iat_net_latency, 0, 0);
        ptlrpc_at_adj_net_latency(request,
-                       lustre_msg_get_service_time(request->rq_repmsg));
+                                 lustre_msg_get_service_time(
+                                         request->rq_repmsg));
 
        /* Import flags should be updated before waking import at FULL state */
        rc = ptlrpc_connect_set_flags(imp, ocd, old_connect_flags, exp,
@@ -1091,144 +1165,158 @@ static int ptlrpc_connect_interpret(const struct lu_env *env,
                spin_lock(&imp->imp_lock);
                if (msg_flags & MSG_CONNECT_REPLAYABLE) {
                        imp->imp_replayable = 1;
-                       spin_unlock(&imp->imp_lock);
                        CDEBUG(D_HA, "connected to replayable target: %s\n",
                               obd2cli_tgt(imp->imp_obd));
                } else {
                        imp->imp_replayable = 0;
-                       spin_unlock(&imp->imp_lock);
                }
 
-                /* if applies, adjust the imp->imp_msg_magic here
-                 * according to reply flags */
-
-                imp->imp_remote_handle =
-                                *lustre_msg_get_handle(request->rq_repmsg);
-
-                /* Initial connects are allowed for clients with non-random
-                 * uuids when servers are in recovery.  Simply signal the
-                 * servers replay is complete and wait in REPLAY_WAIT. */
-                if (msg_flags & MSG_CONNECT_RECOVERING) {
-                        CDEBUG(D_HA, "connect to %s during recovery\n",
-                               obd2cli_tgt(imp->imp_obd));
-                        IMPORT_SET_STATE(imp, LUSTRE_IMP_REPLAY_LOCKS);
-                } else {
-                       IMPORT_SET_STATE(imp, LUSTRE_IMP_FULL);
-                       ptlrpc_activate_import(imp);
-                }
+               /* if applies, adjust the imp->imp_msg_magic here
+                * according to reply flags
+                */
 
-                GOTO(finish, rc = 0);
-        }
+               imp->imp_remote_handle =
+                       *lustre_msg_get_handle(request->rq_repmsg);
 
-        /* Determine what recovery state to move the import to. */
-        if (MSG_CONNECT_RECONNECT & msg_flags) {
-                memset(&old_hdl, 0, sizeof(old_hdl));
-                if (!memcmp(&old_hdl, lustre_msg_get_handle(request->rq_repmsg),
-                            sizeof (old_hdl))) {
-                        LCONSOLE_WARN("Reconnect to %s (at @%s) failed due "
+               /* Initial connects are allowed for clients with non-random
+                * uuids when servers are in recovery.  Simply signal the
+                * servers replay is complete and wait in REPLAY_WAIT.
+                */
+               if (msg_flags & MSG_CONNECT_RECOVERING) {
+                       CDEBUG(D_HA, "connect to %s during recovery\n",
+                              obd2cli_tgt(imp->imp_obd));
+                       import_set_state_nolock(imp, LUSTRE_IMP_REPLAY_LOCKS);
+                       spin_unlock(&imp->imp_lock);
+               } else {
+                       spin_unlock(&imp->imp_lock);
+                       ptlrpc_activate_import(imp, true);
+               }
+
+               GOTO(finish, rc = 0);
+       }
+
+       /* Determine what recovery state to move the import to. */
+       if (MSG_CONNECT_RECONNECT & msg_flags) {
+               memset(&old_hdl, 0, sizeof(old_hdl));
+               if (!memcmp(&old_hdl, lustre_msg_get_handle(request->rq_repmsg),
+                           sizeof(old_hdl))) {
+                       LCONSOLE_WARN("Reconnect to %s (at @%s) failed due "
                                      "bad handle %#llx\n",
-                                      obd2cli_tgt(imp->imp_obd),
-                                      imp->imp_connection->c_remote_uuid.uuid,
-                                      imp->imp_dlm_handle.cookie);
-                        GOTO(out, rc = -ENOTCONN);
-                }
+                                     obd2cli_tgt(imp->imp_obd),
+                                     imp->imp_connection->c_remote_uuid.uuid,
+                                     imp->imp_dlm_handle.cookie);
+                       GOTO(out, rc = -ENOTCONN);
+               }
 
-                if (memcmp(&imp->imp_remote_handle,
-                           lustre_msg_get_handle(request->rq_repmsg),
-                           sizeof(imp->imp_remote_handle))) {
-                        int level = msg_flags & MSG_CONNECT_RECOVERING ?
-                                D_HA : D_WARNING;
-
-                        /* Bug 16611/14775: if server handle have changed,
-                         * that means some sort of disconnection happened.
-                         * If the server is not in recovery, that also means it
-                         * already erased all of our state because of previous
-                         * eviction. If it is in recovery - we are safe to
-                         * participate since we can reestablish all of our state
-                         * with server again */
-                        if ((MSG_CONNECT_RECOVERING & msg_flags)) {
-                                CDEBUG(level,"%s@%s changed server handle from "
+               if (memcmp(&imp->imp_remote_handle,
+                          lustre_msg_get_handle(request->rq_repmsg),
+                          sizeof(imp->imp_remote_handle))) {
+                       int level = msg_flags & MSG_CONNECT_RECOVERING ?
+                               D_HA : D_WARNING;
+
+                       /* Bug 16611/14775: if server handle have changed,
+                        * that means some sort of disconnection happened.
+                        * If the server is not in recovery, that also means it
+                        * already erased all of our state because of previous
+                        * eviction. If it is in recovery - we are safe to
+                        * participate since we can reestablish all of our state
+                        * with server again
+                        */
+                       if ((MSG_CONNECT_RECOVERING & msg_flags)) {
+                               CDEBUG(level,
+                                      "%s@%s changed server handle from "
                                       "%#llx to %#llx"
-                                       " but is still in recovery\n",
-                                       obd2cli_tgt(imp->imp_obd),
-                                       imp->imp_connection->c_remote_uuid.uuid,
-                                       imp->imp_remote_handle.cookie,
-                                       lustre_msg_get_handle(
-                                       request->rq_repmsg)->cookie);
-                        } else {
-                                LCONSOLE_WARN("Evicted from %s (at %s) "
-                                              "after server handle changed from "
+                                      " but is still in recovery\n",
+                                      obd2cli_tgt(imp->imp_obd),
+                                      imp->imp_connection->c_remote_uuid.uuid,
+                                      imp->imp_remote_handle.cookie,
+                                      lustre_msg_get_handle(
+                                              request->rq_repmsg)->cookie);
+                       } else {
+                               LCONSOLE_WARN("Evicted from %s (at %s) "
+                                             "after server handle changed from "
                                              "%#llx to %#llx\n",
-                                              obd2cli_tgt(imp->imp_obd),
-                                              imp->imp_connection-> \
-                                              c_remote_uuid.uuid,
-                                              imp->imp_remote_handle.cookie,
-                                              lustre_msg_get_handle(
-                                              request->rq_repmsg)->cookie);
-                        }
-
-
-                        imp->imp_remote_handle =
-                                     *lustre_msg_get_handle(request->rq_repmsg);
+                                             obd2cli_tgt(imp->imp_obd),
+                                             imp->imp_connection->
+                                             c_remote_uuid.uuid,
+                                             imp->imp_remote_handle.cookie,
+                                             lustre_msg_get_handle(
+                                                     request->rq_repmsg)->cookie);
+                       }
 
-                        if (!(MSG_CONNECT_RECOVERING & msg_flags)) {
-                                IMPORT_SET_STATE(imp, LUSTRE_IMP_EVICTED);
-                                GOTO(finish, rc = 0);
-                        }
+                       imp->imp_remote_handle =
+                               *lustre_msg_get_handle(request->rq_repmsg);
 
-                } else {
-                        CDEBUG(D_HA, "reconnected to %s@%s after partition\n",
-                               obd2cli_tgt(imp->imp_obd),
-                               imp->imp_connection->c_remote_uuid.uuid);
-                }
+                       if (!(MSG_CONNECT_RECOVERING & msg_flags)) {
+                               import_set_state(imp, LUSTRE_IMP_EVICTED);
+                               GOTO(finish, rc = 0);
+                       }
+               } else {
+                       CDEBUG(D_HA, "reconnected to %s@%s after partition\n",
+                              obd2cli_tgt(imp->imp_obd),
+                              imp->imp_connection->c_remote_uuid.uuid);
+               }
 
-                if (imp->imp_invalid) {
-                        CDEBUG(D_HA, "%s: reconnected but import is invalid; "
-                               "marking evicted\n", imp->imp_obd->obd_name);
-                        IMPORT_SET_STATE(imp, LUSTRE_IMP_EVICTED);
-                } else if (MSG_CONNECT_RECOVERING & msg_flags) {
-                        CDEBUG(D_HA, "%s: reconnected to %s during replay\n",
-                               imp->imp_obd->obd_name,
-                               obd2cli_tgt(imp->imp_obd));
+               if (imp->imp_invalid) {
+                       CDEBUG(D_HA, "%s: reconnected but import is invalid; "
+                              "marking evicted\n", imp->imp_obd->obd_name);
+                       import_set_state(imp, LUSTRE_IMP_EVICTED);
+               } else if (MSG_CONNECT_RECOVERING & msg_flags) {
+                       CDEBUG(D_HA, "%s: reconnected to %s during replay\n",
+                              imp->imp_obd->obd_name,
+                              obd2cli_tgt(imp->imp_obd));
 
                        spin_lock(&imp->imp_lock);
                        imp->imp_resend_replay = 1;
                        spin_unlock(&imp->imp_lock);
 
-                       IMPORT_SET_STATE(imp, imp->imp_replay_state);
-                } else {
-                        IMPORT_SET_STATE(imp, LUSTRE_IMP_RECOVER);
-                }
-        } else if ((MSG_CONNECT_RECOVERING & msg_flags) && !imp->imp_invalid) {
-                LASSERT(imp->imp_replayable);
-                imp->imp_remote_handle =
-                                *lustre_msg_get_handle(request->rq_repmsg);
-                imp->imp_last_replay_transno = 0;
+                       import_set_state(imp, imp->imp_replay_state);
+               } else {
+                       import_set_state(imp, LUSTRE_IMP_RECOVER);
+               }
+       } else if ((MSG_CONNECT_RECOVERING & msg_flags) && !imp->imp_invalid) {
+               LASSERT(imp->imp_replayable);
+               imp->imp_remote_handle =
+                       *lustre_msg_get_handle(request->rq_repmsg);
+               imp->imp_last_replay_transno = 0;
                imp->imp_replay_cursor = &imp->imp_committed_list;
-                IMPORT_SET_STATE(imp, LUSTRE_IMP_REPLAY);
-        } else {
-                DEBUG_REQ(D_HA, request, "%s: evicting (reconnect/recover flags"
-                          " not set: %x)", imp->imp_obd->obd_name, msg_flags);
-                imp->imp_remote_handle =
-                                *lustre_msg_get_handle(request->rq_repmsg);
-                IMPORT_SET_STATE(imp, LUSTRE_IMP_EVICTED);
-        }
+               import_set_state(imp, LUSTRE_IMP_REPLAY);
+       } else if ((ocd->ocd_connect_flags & OBD_CONNECT_LIGHTWEIGHT) != 0 &&
+                  !imp->imp_invalid) {
+
+               obd_import_event(imp->imp_obd, imp, IMP_EVENT_INVALIDATE);
+               /* The below message is checked in recovery-small.sh test_106 */
+               DEBUG_REQ(D_HA, request, "%s: lwp recover",
+                         imp->imp_obd->obd_name);
+               imp->imp_remote_handle =
+                       *lustre_msg_get_handle(request->rq_repmsg);
+               import_set_state(imp, LUSTRE_IMP_RECOVER);
+       } else {
+               DEBUG_REQ(D_HA, request,
+                         "%s: evicting (reconnect/recover flags not set: %x)",
+                         imp->imp_obd->obd_name, msg_flags);
+               imp->imp_remote_handle =
+                       *lustre_msg_get_handle(request->rq_repmsg);
+               import_set_state(imp, LUSTRE_IMP_EVICTED);
+       }
 
-        /* Sanity checks for a reconnected import. */
-        if (!(imp->imp_replayable) != !(msg_flags & MSG_CONNECT_REPLAYABLE)) {
-                CERROR("imp_replayable flag does not match server "
-                       "after reconnect. We should LBUG right here.\n");
-        }
+       /* Sanity checks for a reconnected import. */
+       if (!(imp->imp_replayable) != !(msg_flags & MSG_CONNECT_REPLAYABLE))
+               CERROR("imp_replayable flag does not match server after reconnect. We should LBUG right here.\n");
 
-        if (lustre_msg_get_last_committed(request->rq_repmsg) > 0 &&
-            lustre_msg_get_last_committed(request->rq_repmsg) <
-            aa->pcaa_peer_committed) {
-               CERROR("%s went back in time (transno %lld"
-                      " was previously committed, server now claims %lld"
-                       ")!  See https://bugzilla.lustre.org/show_bug.cgi?"
-                       "id=9646\n",
-                       obd2cli_tgt(imp->imp_obd), aa->pcaa_peer_committed,
+       if (lustre_msg_get_last_committed(request->rq_repmsg) > 0 &&
+           lustre_msg_get_last_committed(request->rq_repmsg) <
+           aa->pcaa_peer_committed) {
+               static bool printed;
+
+               /* The below message is checked in recovery-small.sh test_54 */
+               CERROR("%s: went back in time (transno %lld was previously committed, server now claims %lld)!\n",
+                      obd2cli_tgt(imp->imp_obd), aa->pcaa_peer_committed,
                        lustre_msg_get_last_committed(request->rq_repmsg));
+               if (!printed) {
+                       CERROR("For further information, see http://doc.lustre.org/lustre_manual.xhtml#went_back_in_time\n");
+                       printed = true;
+               }
         }
 
 finish:
@@ -1248,31 +1336,33 @@ finish:
        }
 
 out:
-       spin_lock(&imp->imp_lock);
-       imp->imp_connected = 0;
-       imp->imp_connect_tried = 1;
-       spin_unlock(&imp->imp_lock);
-
        if (exp != NULL)
                class_export_put(exp);
 
-        if (rc != 0) {
-                IMPORT_SET_STATE(imp, LUSTRE_IMP_DISCON);
-                if (rc == -EACCES) {
-                        /*
-                         * Give up trying to reconnect
-                         * EACCES means client has no permission for connection
-                         */
-                        imp->imp_obd->obd_no_recov = 1;
-                        ptlrpc_deactivate_import(imp);
-                }
-
-                if (rc == -EPROTO) {
-                        struct obd_connect_data *ocd;
+       spin_lock(&imp->imp_lock);
+       imp->imp_connected = 0;
+       imp->imp_connect_tried = 1;
 
-                        /* reply message might not be ready */
-                        if (request->rq_repmsg == NULL)
-                                RETURN(-EPROTO);
+       if (rc != 0) {
+               bool inact = false;
+
+               import_set_state_nolock(imp, LUSTRE_IMP_DISCON);
+               if (rc == -EACCES) {
+                       /*
+                        * Give up trying to reconnect
+                        * EACCES means client has no permission for connection
+                        */
+                       imp->imp_obd->obd_no_recov = 1;
+                       ptlrpc_deactivate_import_nolock(imp);
+                       inact = true;
+               } else if (rc == -EPROTO) {
+                       struct obd_connect_data *ocd;
+
+                       /* reply message might not be ready */
+                       if (request->rq_repmsg == NULL) {
+                               spin_unlock(&imp->imp_lock);
+                               RETURN(-EPROTO);
+                       }
 
                        ocd = req_capsule_server_get(&request->rq_pill,
                                                     &RMF_CONNECT_DATA);
@@ -1283,28 +1373,37 @@ out:
                        if (ocd &&
                            (ocd->ocd_connect_flags & OBD_CONNECT_VERSION) &&
                            (ocd->ocd_version != LUSTRE_VERSION_CODE)) {
-                                LCONSOLE_ERROR_MSG(0x16a, "Server %s version "
-                                        "(%d.%d.%d.%d)"
-                                        " refused connection from this client "
-                                        "with an incompatible version (%s).  "
-                                        "Client must be recompiled\n",
-                                        obd2cli_tgt(imp->imp_obd),
-                                        OBD_OCD_VERSION_MAJOR(ocd->ocd_version),
-                                        OBD_OCD_VERSION_MINOR(ocd->ocd_version),
-                                        OBD_OCD_VERSION_PATCH(ocd->ocd_version),
-                                        OBD_OCD_VERSION_FIX(ocd->ocd_version),
-                                        LUSTRE_VERSION_STRING);
-                                ptlrpc_deactivate_import(imp);
-                                IMPORT_SET_STATE(imp, LUSTRE_IMP_CLOSED);
-                        }
-                        RETURN(-EPROTO);
-                }
+                               LCONSOLE_ERROR_MSG(0x16a, "Server %s version "
+                                                  "(%d.%d.%d.%d)"
+                                                  " refused connection from this client "
+                                                  "with an incompatible version (%s).  "
+                                                  "Client must be recompiled\n",
+                                                  obd2cli_tgt(imp->imp_obd),
+                                                  OBD_OCD_VERSION_MAJOR(ocd->ocd_version),
+                                                  OBD_OCD_VERSION_MINOR(ocd->ocd_version),
+                                                  OBD_OCD_VERSION_PATCH(ocd->ocd_version),
+                                                  OBD_OCD_VERSION_FIX(ocd->ocd_version),
+                                                  LUSTRE_VERSION_STRING);
+                               ptlrpc_deactivate_import_nolock(imp);
+                               import_set_state_nolock(imp, LUSTRE_IMP_CLOSED);
+                               inact = true;
+                       }
+               }
+               spin_unlock(&imp->imp_lock);
+
+               if (inact)
+                       obd_import_event(imp->imp_obd, imp, IMP_EVENT_INACTIVE);
+
+               if (rc == -EPROTO)
+                       RETURN(rc);
 
                ptlrpc_maybe_ping_import_soon(imp);
 
                CDEBUG(D_HA, "recovery of %s on %s failed (%d)\n",
                       obd2cli_tgt(imp->imp_obd),
                       (char *)imp->imp_connection->c_remote_uuid.uuid, rc);
+       } else {
+               spin_unlock(&imp->imp_lock);
        }
 
        wake_up_all(&imp->imp_recovery_waitq);
@@ -1316,13 +1415,12 @@ out:
  * \see signal_completed_replay
  */
 static int completed_replay_interpret(const struct lu_env *env,
-                                      struct ptlrpc_request *req,
-                                      void * data, int rc)
+                                     struct ptlrpc_request *req,
+                                     void *args, int rc)
 {
        ENTRY;
        atomic_dec(&req->rq_import->imp_replay_inflight);
-       if (req->rq_status == 0 &&
-           !req->rq_import->imp_vbr_failed) {
+       if (req->rq_status == 0 && !req->rq_import->imp_vbr_failed) {
                ptlrpc_import_recovery_state_machine(req->rq_import);
        } else {
                if (req->rq_import->imp_vbr_failed) {
@@ -1399,7 +1497,7 @@ static int ptlrpc_invalidate_import_thread(void *data)
                 libcfs_debug_dumplog();
         }
 
-        IMPORT_SET_STATE(imp, LUSTRE_IMP_RECOVER);
+       import_set_state(imp, LUSTRE_IMP_RECOVER);
         ptlrpc_import_recovery_state_machine(imp);
 
         class_import_put(imp);
@@ -1445,6 +1543,7 @@ int ptlrpc_import_recovery_state_machine(struct obd_import *imp)
                                           "using this service will fail.\n",
                                           imp->imp_obd->obd_name, target_len,
                                           target_start);
+                       LASSERTF(!obd_lbug_on_eviction, "LBUG upon eviction");
                 }
                 CDEBUG(D_HA, "evicted from %s@%s; invalidating\n",
                        obd2cli_tgt(imp->imp_obd),
@@ -1480,7 +1579,7 @@ int ptlrpc_import_recovery_state_machine(struct obd_import *imp)
                rc = ptlrpc_replay_next(imp, &inflight);
                if (inflight == 0 &&
                    atomic_read(&imp->imp_replay_inflight) == 0) {
-                       IMPORT_SET_STATE(imp, LUSTRE_IMP_REPLAY_LOCKS);
+                       import_set_state(imp, LUSTRE_IMP_REPLAY_LOCKS);
                        rc = ldlm_replay_locks(imp);
                        if (rc)
                                GOTO(out, rc);
@@ -1490,7 +1589,7 @@ int ptlrpc_import_recovery_state_machine(struct obd_import *imp)
 
        if (imp->imp_state == LUSTRE_IMP_REPLAY_LOCKS) {
                if (atomic_read(&imp->imp_replay_inflight) == 0) {
-                       IMPORT_SET_STATE(imp, LUSTRE_IMP_REPLAY_WAIT);
+                       import_set_state(imp, LUSTRE_IMP_REPLAY_WAIT);
                        rc = signal_completed_replay(imp);
                        if (rc)
                                GOTO(out, rc);
@@ -1499,24 +1598,23 @@ int ptlrpc_import_recovery_state_machine(struct obd_import *imp)
 
        if (imp->imp_state == LUSTRE_IMP_REPLAY_WAIT) {
                if (atomic_read(&imp->imp_replay_inflight) == 0) {
-                       IMPORT_SET_STATE(imp, LUSTRE_IMP_RECOVER);
+                       import_set_state(imp, LUSTRE_IMP_RECOVER);
                }
        }
 
-        if (imp->imp_state == LUSTRE_IMP_RECOVER) {
+       if (imp->imp_state == LUSTRE_IMP_RECOVER) {
                struct ptlrpc_connection *conn = imp->imp_connection;
 
-                rc = ptlrpc_resend(imp);
-                if (rc)
-                        GOTO(out, rc);
-                IMPORT_SET_STATE(imp, LUSTRE_IMP_FULL);
-                ptlrpc_activate_import(imp);
+               rc = ptlrpc_resend(imp);
+               if (rc)
+                       GOTO(out, rc);
+               ptlrpc_activate_import(imp, true);
 
                LCONSOLE_INFO("%s: Connection restored to %s (at %s)\n",
                              imp->imp_obd->obd_name,
                              obd_uuid2str(&conn->c_remote_uuid),
                              obd_import_nid2str(imp));
-        }
+       }
 
        if (imp->imp_state == LUSTRE_IMP_FULL) {
                wake_up_all(&imp->imp_recovery_waitq);
@@ -1527,15 +1625,12 @@ out:
        RETURN(rc);
 }
 
-int ptlrpc_disconnect_import(struct obd_import *imp, int noclose)
+static struct ptlrpc_request *ptlrpc_disconnect_prep_req(struct obd_import *imp)
 {
        struct ptlrpc_request *req;
        int rq_opc, rc = 0;
        ENTRY;
 
-       if (imp->imp_obd->obd_force)
-               GOTO(set_state, rc);
-
        switch (imp->imp_connect_op) {
        case OST_CONNECT:
                rq_opc = OST_DISCONNECT;
@@ -1552,9 +1647,46 @@ int ptlrpc_disconnect_import(struct obd_import *imp, int noclose)
                       "(connect_op %d): rc = %d\n",
                       imp->imp_obd->obd_name, obd2cli_tgt(imp->imp_obd),
                       imp->imp_connect_op, rc);
-               RETURN(rc);
+               RETURN(ERR_PTR(rc));
        }
 
+       req = ptlrpc_request_alloc_pack(imp, &RQF_MDS_DISCONNECT,
+                                       LUSTRE_OBD_VERSION, rq_opc);
+       if (req == NULL)
+               RETURN(ERR_PTR(-ENOMEM));
+
+       /* We are disconnecting, do not retry a failed DISCONNECT rpc if
+        * it fails.  We can get through the above with a down server
+        * if the client doesn't know the server is gone yet. */
+       req->rq_no_resend = 1;
+
+       /* We want client umounts to happen quickly, no matter the
+          server state... */
+       req->rq_timeout = min_t(int, req->rq_timeout,
+                               INITIAL_CONNECT_TIMEOUT);
+
+       import_set_state(imp, LUSTRE_IMP_CONNECTING);
+       req->rq_send_state =  LUSTRE_IMP_CONNECTING;
+       ptlrpc_request_set_replen(req);
+
+       RETURN(req);
+}
+
+int ptlrpc_disconnect_import(struct obd_import *imp, int noclose)
+{
+       struct ptlrpc_request *req;
+       int rc = 0;
+       ENTRY;
+
+       if (imp->imp_obd->obd_force)
+               GOTO(set_state, rc);
+
+       /* probably the import has been disconnected already being idle */
+       spin_lock(&imp->imp_lock);
+       if (imp->imp_state == LUSTRE_IMP_IDLE)
+               GOTO(out, rc);
+       spin_unlock(&imp->imp_lock);
+
        if (ptlrpc_import_in_recovery(imp)) {
                struct l_wait_info lwi;
                long timeout_jiffies;
@@ -1587,33 +1719,19 @@ int ptlrpc_disconnect_import(struct obd_import *imp, int noclose)
                GOTO(out, rc);
        spin_unlock(&imp->imp_lock);
 
-        req = ptlrpc_request_alloc_pack(imp, &RQF_MDS_DISCONNECT,
-                                        LUSTRE_OBD_VERSION, rq_opc);
-        if (req) {
-                /* We are disconnecting, do not retry a failed DISCONNECT rpc if
-                 * it fails.  We can get through the above with a down server
-                 * if the client doesn't know the server is gone yet. */
-                req->rq_no_resend = 1;
-
-                /* We want client umounts to happen quickly, no matter the
-                   server state... */
-                req->rq_timeout = min_t(int, req->rq_timeout,
-                                        INITIAL_CONNECT_TIMEOUT);
-
-                IMPORT_SET_STATE(imp, LUSTRE_IMP_CONNECTING);
-                req->rq_send_state =  LUSTRE_IMP_CONNECTING;
-                ptlrpc_request_set_replen(req);
-                rc = ptlrpc_queue_wait(req);
-                ptlrpc_req_finished(req);
-        }
+       req = ptlrpc_disconnect_prep_req(imp);
+       if (IS_ERR(req))
+               GOTO(set_state, rc = PTR_ERR(req));
+       rc = ptlrpc_queue_wait(req);
+       ptlrpc_req_finished(req);
 
 set_state:
        spin_lock(&imp->imp_lock);
 out:
        if (noclose)
-               IMPORT_SET_STATE_NOLOCK(imp, LUSTRE_IMP_DISCON);
+               import_set_state_nolock(imp, LUSTRE_IMP_DISCON);
        else
-               IMPORT_SET_STATE_NOLOCK(imp, LUSTRE_IMP_CLOSED);
+               import_set_state_nolock(imp, LUSTRE_IMP_CLOSED);
        memset(&imp->imp_remote_handle, 0, sizeof(imp->imp_remote_handle));
        spin_unlock(&imp->imp_lock);
 
@@ -1623,21 +1741,113 @@ out:
 }
 EXPORT_SYMBOL(ptlrpc_disconnect_import);
 
+static void ptlrpc_reset_reqs_generation(struct obd_import *imp)
+{
+       struct ptlrpc_request *old, *tmp;
+
+       /* tag all resendable requests generated before disconnection
+        * notice this code is part of disconnect-at-idle path only */
+       list_for_each_entry_safe(old, tmp, &imp->imp_delayed_list,
+                       rq_list) {
+               spin_lock(&old->rq_lock);
+               if (old->rq_import_generation == imp->imp_generation - 1 &&
+                   ((imp->imp_initiated_at == imp->imp_generation) ||
+                    !old->rq_no_resend))
+                       old->rq_import_generation = imp->imp_generation;
+               spin_unlock(&old->rq_lock);
+       }
+}
+
+static int ptlrpc_disconnect_idle_interpret(const struct lu_env *env,
+                                           struct ptlrpc_request *req,
+                                           void *args, int rc)
+{
+       struct obd_import *imp = req->rq_import;
+       int connect = 0;
+
+       DEBUG_REQ(D_HA, req, "inflight=%d, refcount=%d: rc = %d",
+                 atomic_read(&imp->imp_inflight),
+                 atomic_read(&imp->imp_refcount), rc);
+
+       spin_lock(&imp->imp_lock);
+       /* DISCONNECT reply can be late and another connection can just
+        * be initiated. so we have to abort disconnection. */
+       if (req->rq_import_generation == imp->imp_generation &&
+           imp->imp_state != LUSTRE_IMP_CLOSED) {
+               LASSERTF(imp->imp_state == LUSTRE_IMP_CONNECTING,
+                        "%s\n", ptlrpc_import_state_name(imp->imp_state));
+               imp->imp_state = LUSTRE_IMP_IDLE;
+               memset(&imp->imp_remote_handle, 0,
+                      sizeof(imp->imp_remote_handle));
+               /* take our DISCONNECT into account */
+               if (atomic_read(&imp->imp_inflight) > 1) {
+                       imp->imp_generation++;
+                       imp->imp_initiated_at = imp->imp_generation;
+                       import_set_state_nolock(imp, LUSTRE_IMP_NEW);
+                       ptlrpc_reset_reqs_generation(imp);
+                       connect = 1;
+               }
+       }
+
+       if (connect) {
+               rc = ptlrpc_connect_import_locked(imp);
+               if (rc >= 0)
+                       ptlrpc_pinger_add_import(imp);
+       } else {
+               spin_unlock(&imp->imp_lock);
+       }
+
+       return 0;
+}
+
+int ptlrpc_disconnect_and_idle_import(struct obd_import *imp)
+{
+       struct ptlrpc_request *req;
+       ENTRY;
+
+       if (imp->imp_obd->obd_force)
+               RETURN(0);
+
+       if (ptlrpc_import_in_recovery(imp))
+               RETURN(0);
+
+       spin_lock(&imp->imp_lock);
+       if (imp->imp_state != LUSTRE_IMP_FULL) {
+               spin_unlock(&imp->imp_lock);
+               RETURN(0);
+       }
+       spin_unlock(&imp->imp_lock);
+
+       req = ptlrpc_disconnect_prep_req(imp);
+       if (IS_ERR(req))
+               RETURN(PTR_ERR(req));
+
+       CDEBUG_LIMIT(imp->imp_idle_debug, "%s: disconnect after %llus idle\n",
+                    imp->imp_obd->obd_name,
+                    ktime_get_real_seconds() - imp->imp_last_reply_time);
+       req->rq_interpret_reply = ptlrpc_disconnect_idle_interpret;
+       ptlrpcd_add_req(req);
+
+       RETURN(0);
+}
+EXPORT_SYMBOL(ptlrpc_disconnect_and_idle_import);
+
 void ptlrpc_cleanup_imp(struct obd_import *imp)
 {
        ENTRY;
 
        spin_lock(&imp->imp_lock);
-       IMPORT_SET_STATE_NOLOCK(imp, LUSTRE_IMP_CLOSED);
+
+       import_set_state_nolock(imp, LUSTRE_IMP_CLOSED);
        imp->imp_generation++;
-       spin_unlock(&imp->imp_lock);
        ptlrpc_abort_inflight(imp);
 
+       spin_unlock(&imp->imp_lock);
+
        EXIT;
 }
 
 /* Adaptive Timeout utils */
-extern unsigned int at_min, at_max, at_history;
 
 /* Update at_current with the specified value (bounded by at_min and at_max),
  * as well as the AT history "bins".