Whamcloud - gitweb
LU-8602 gss: Properly port gss to newer crypto api.
[fs/lustre-release.git] / lustre / ptlrpc / gss / gss_keyring.c
index 6913e68..8d8ab4b 100644 (file)
@@ -1,6 +1,4 @@
-/* -*- mode: c; c-basic-offset: 8; indent-tabs-mode: nil; -*-
- * vim:expandtab:shiftwidth=8:tabstop=8:
- *
+/*
  * GPL HEADER START
  *
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * You should have received a copy of the GNU General Public License
  * version 2 along with this program; If not, see
- * http://www.sun.com/software/products/lustre/docs/GPLv2.pdf
- *
- * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
- * CA 95054 USA or visit www.sun.com if you need additional information or
- * have any questions.
+ * http://www.gnu.org/licenses/gpl-2.0.html
  *
  * GPL HEADER END
  */
 /*
- * Copyright  2008 Sun Microsystems, Inc. All rights reserved
+ * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
+ *
+ * Copyright (c) 2012, 2014, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
  * Author: Eric Mei <ericm@clusterfs.com>
  */
 
-#ifndef EXPORT_SYMTAB
-# define EXPORT_SYMTAB
-#endif
 #define DEBUG_SUBSYSTEM S_SEC
-#ifdef __KERNEL__
 #include <linux/init.h>
 #include <linux/module.h>
 #include <linux/slab.h>
 #include <linux/dcache.h>
 #include <linux/fs.h>
-#include <linux/random.h>
 #include <linux/crypto.h>
 #include <linux/key.h>
 #include <linux/keyctl.h>
+#include <linux/key-type.h>
 #include <linux/mutex.h>
 #include <asm/atomic.h>
-#else
-#include <liblustre.h>
-#endif
 
+#include <libcfs/linux/linux-list.h>
 #include <obd.h>
 #include <obd_class.h>
 #include <obd_support.h>
-#include <lustre/lustre_idl.h>
+#include <uapi/linux/lustre/lustre_idl.h>
 #include <lustre_sec.h>
 #include <lustre_net.h>
 #include <lustre_import.h>
@@ -80,7 +70,7 @@ static int sec_install_rctx_kr(struct ptlrpc_sec *sec,
 /*
  * the timeout is only for the case that upcall child process die abnormally.
  * in any other cases it should finally update kernel key.
- * 
+ *
  * FIXME we'd better to incorporate the client & server side upcall timeouts
  * into the framework of Adaptive Timeouts, but we need to figure out how to
  * make sure that kernel knows the upcall processes is in-progress or died
@@ -92,50 +82,56 @@ static int sec_install_rctx_kr(struct ptlrpc_sec *sec,
  * internal helpers                     *
  ****************************************/
 
-#define DUMP_PROCESS_KEYRINGS(tsk)                                      \
-{                                                                       \
-        CWARN("DUMP PK: %s[%u,%u/%u](<-%s[%u,%u/%u]): "                 \
-              "a %d, t %d, p %d, s %d, u %d, us %d, df %d\n",           \
-              tsk->comm, tsk->pid, tsk->uid, tsk->fsuid,                \
-              tsk->parent->comm, tsk->parent->pid,                      \
-              tsk->parent->uid, tsk->parent->fsuid,                     \
-              tsk->request_key_auth ?                                   \
-              tsk->request_key_auth->serial : 0,                        \
-              tsk->thread_keyring ?                                     \
-              tsk->thread_keyring->serial : 0,                          \
-              tsk->signal->process_keyring ?                            \
-              tsk->signal->process_keyring->serial : 0,                 \
-              tsk->signal->session_keyring ?                            \
-              tsk->signal->session_keyring->serial : 0,                 \
-              tsk->user->uid_keyring ?                                  \
-              tsk->user->uid_keyring->serial : 0,                       \
-              tsk->user->session_keyring ?                              \
-              tsk->user->session_keyring->serial : 0,                   \
-              tsk->jit_keyring                                          \
-             );                                                         \
+#define DUMP_PROCESS_KEYRINGS(tsk)                                     \
+{                                                                      \
+       CWARN("DUMP PK: %s[%u,%u/%u](<-%s[%u,%u/%u]): "                 \
+             "a %d, t %d, p %d, s %d, u %d, us %d, df %d\n",           \
+             tsk->comm, tsk->pid, tsk->uid, tsk->fsuid,                \
+             tsk->parent->comm, tsk->parent->pid,                      \
+             tsk->parent->uid, tsk->parent->fsuid,                     \
+             tsk->request_key_auth ?                                   \
+             tsk->request_key_auth->serial : 0,                        \
+             key_cred(tsk)->thread_keyring ?                           \
+             key_cred(tsk)->thread_keyring->serial : 0,                \
+             key_tgcred(tsk)->process_keyring ?                        \
+             key_tgcred(tsk)->process_keyring->serial : 0,             \
+             key_tgcred(tsk)->session_keyring ?                        \
+             key_tgcred(tsk)->session_keyring->serial : 0,             \
+             key_cred(tsk)->user->uid_keyring ?                        \
+             key_cred(tsk)->user->uid_keyring->serial : 0,             \
+             key_cred(tsk)->user->session_keyring ?                    \
+             key_cred(tsk)->user->session_keyring->serial : 0,         \
+             key_cred(tsk)->jit_keyring                                \
+            );                                                         \
 }
 
 #define DUMP_KEY(key)                                                   \
 {                                                                       \
-        CWARN("DUMP KEY: %p(%d) ref %d u%u/g%u desc %s\n",              \
-              key, key->serial, atomic_read(&key->usage),               \
-              key->uid, key->gid,                                       \
-              key->description ? key->description : "n/a"               \
-             );                                                         \
+       CWARN("DUMP KEY: %p(%d) ref %d u%u/g%u desc %s\n",              \
+             key, key->serial, ll_read_key_usage(key),                 \
+             key->uid, key->gid,                                       \
+             key->description ? key->description : "n/a"               \
+            );                                                         \
 }
 
+#define key_cred(tsk)   ((tsk)->cred)
+#ifdef HAVE_CRED_TGCRED
+#define key_tgcred(tsk) ((tsk)->cred->tgcred)
+#else
+#define key_tgcred(tsk) key_cred(tsk)
+#endif
 
 static inline void keyring_upcall_lock(struct gss_sec_keyring *gsec_kr)
 {
 #ifdef HAVE_KEYRING_UPCALL_SERIALIZED
-        mutex_lock(&gsec_kr->gsk_uc_lock);
+       mutex_lock(&gsec_kr->gsk_uc_lock);
 #endif
 }
 
 static inline void keyring_upcall_unlock(struct gss_sec_keyring *gsec_kr)
 {
 #ifdef HAVE_KEYRING_UPCALL_SERIALIZED
-        mutex_unlock(&gsec_kr->gsk_uc_lock);
+       mutex_unlock(&gsec_kr->gsk_uc_lock);
 #endif
 }
 
@@ -144,10 +140,12 @@ static inline void key_revoke_locked(struct key *key)
         set_bit(KEY_FLAG_REVOKED, &key->flags);
 }
 
-static void ctx_upcall_timeout_kr(unsigned long data)
+static void ctx_upcall_timeout_kr(cfs_timer_cb_arg_t data)
 {
-        struct ptlrpc_cli_ctx *ctx = (struct ptlrpc_cli_ctx *) data;
-        struct key            *key = ctx2gctx_keyring(ctx)->gck_key;
+       struct gss_cli_ctx_keyring *gctx_kr = cfs_from_timer(gctx_kr,
+                                                            &data, gck_timer);
+       struct ptlrpc_cli_ctx *ctx = &(gctx_kr->gck_base.gc_base);
+       struct key *key = gctx_kr->gck_key;
 
         CWARN("ctx %p, key %p\n", ctx, key);
 
@@ -155,26 +153,21 @@ static void ctx_upcall_timeout_kr(unsigned long data)
 
         cli_ctx_expire(ctx);
         key_revoke_locked(key);
-        sptlrpc_cli_ctx_wakeup(ctx);
 }
 
-static
-void ctx_start_timer_kr(struct ptlrpc_cli_ctx *ctx, long timeout)
+static void ctx_start_timer_kr(struct ptlrpc_cli_ctx *ctx, time64_t timeout)
 {
-        struct gss_cli_ctx_keyring *gctx_kr = ctx2gctx_keyring(ctx);
-        struct timer_list          *timer = gctx_kr->gck_timer;
-
-        LASSERT(timer);
+       struct gss_cli_ctx_keyring *gctx_kr = ctx2gctx_keyring(ctx);
+       struct timer_list *timer = gctx_kr->gck_timer;
 
-        CDEBUG(D_SEC, "ctx %p: start timer %lds\n", ctx, timeout);
-        timeout = timeout * HZ + cfs_time_current();
+       LASSERT(timer);
 
-        init_timer(timer);
-        timer->expires = timeout;
-        timer->data = (unsigned long ) ctx;
-        timer->function = ctx_upcall_timeout_kr;
+       CDEBUG(D_SEC, "ctx %p: start timer %llds\n", ctx, timeout);
 
-        add_timer(timer);
+       cfs_timer_setup(timer, ctx_upcall_timeout_kr,
+                       (unsigned long)gctx_kr, 0);
+       timer->expires = cfs_time_seconds(timeout) + jiffies;
+       add_timer(timer);
 }
 
 /*
@@ -202,77 +195,77 @@ static
 struct ptlrpc_cli_ctx *ctx_create_kr(struct ptlrpc_sec *sec,
                                      struct vfs_cred *vcred)
 {
-        struct ptlrpc_cli_ctx      *ctx;
-        struct gss_cli_ctx_keyring *gctx_kr;
+       struct ptlrpc_cli_ctx      *ctx;
+       struct gss_cli_ctx_keyring *gctx_kr;
 
-        OBD_ALLOC_PTR(gctx_kr);
-        if (gctx_kr == NULL)
-                return NULL;
+       OBD_ALLOC_PTR(gctx_kr);
+       if (gctx_kr == NULL)
+               return NULL;
 
-        OBD_ALLOC_PTR(gctx_kr->gck_timer);
-        if (gctx_kr->gck_timer == NULL) {
-                OBD_FREE_PTR(gctx_kr);
-                return NULL;
-        }
-        init_timer(gctx_kr->gck_timer);
+       OBD_ALLOC_PTR(gctx_kr->gck_timer);
+       if (gctx_kr->gck_timer == NULL) {
+               OBD_FREE_PTR(gctx_kr);
+               return NULL;
+       }
+       cfs_timer_setup(gctx_kr->gck_timer, NULL, 0, 0);
 
-        ctx = &gctx_kr->gck_base.gc_base;
+       ctx = &gctx_kr->gck_base.gc_base;
 
-        if (gss_cli_ctx_init_common(sec, ctx, &gss_keyring_ctxops, vcred)) {
-                OBD_FREE_PTR(gctx_kr->gck_timer);
-                OBD_FREE_PTR(gctx_kr);
-                return NULL;
-        }
+       if (gss_cli_ctx_init_common(sec, ctx, &gss_keyring_ctxops, vcred)) {
+               OBD_FREE_PTR(gctx_kr->gck_timer);
+               OBD_FREE_PTR(gctx_kr);
+               return NULL;
+       }
 
-        ctx->cc_expire = cfs_time_current_sec() + KEYRING_UPCALL_TIMEOUT;
-        clear_bit(PTLRPC_CTX_NEW_BIT, &ctx->cc_flags);
-        atomic_inc(&ctx->cc_refcount); /* for the caller */
+       ctx->cc_expire = ktime_get_real_seconds() + KEYRING_UPCALL_TIMEOUT;
+       clear_bit(PTLRPC_CTX_NEW_BIT, &ctx->cc_flags);
+       atomic_inc(&ctx->cc_refcount); /* for the caller */
 
-        return ctx;
+       return ctx;
 }
 
 static void ctx_destroy_kr(struct ptlrpc_cli_ctx *ctx)
 {
-        struct ptlrpc_sec          *sec = ctx->cc_sec;
-        struct gss_cli_ctx_keyring *gctx_kr = ctx2gctx_keyring(ctx);
+       struct ptlrpc_sec               *sec = ctx->cc_sec;
+       struct gss_cli_ctx_keyring      *gctx_kr = ctx2gctx_keyring(ctx);
 
-        CDEBUG(D_SEC, "destroying ctx %p\n", ctx);
+       CDEBUG(D_SEC, "destroying ctx %p\n", ctx);
 
         /* at this time the association with key has been broken. */
         LASSERT(sec);
-        LASSERT(atomic_read(&sec->ps_refcount) > 0);
-        LASSERT(atomic_read(&sec->ps_nctx) > 0);
-        LASSERT(test_bit(PTLRPC_CTX_CACHED_BIT, &ctx->cc_flags) == 0);
+       LASSERT(atomic_read(&sec->ps_refcount) > 0);
+       LASSERT(atomic_read(&sec->ps_nctx) > 0);
+       LASSERT(test_bit(PTLRPC_CTX_CACHED_BIT, &ctx->cc_flags) == 0);
         LASSERT(gctx_kr->gck_key == NULL);
 
-        ctx_clear_timer_kr(ctx);
-        LASSERT(gctx_kr->gck_timer == NULL);
+       ctx_clear_timer_kr(ctx);
+       LASSERT(gctx_kr->gck_timer == NULL);
 
-        if (gss_cli_ctx_fini_common(sec, ctx))
-                return;
+       if (gss_cli_ctx_fini_common(sec, ctx))
+               return;
 
-        OBD_FREE_PTR(gctx_kr);
+       OBD_FREE_PTR(gctx_kr);
 
-        atomic_dec(&sec->ps_nctx);
-        sptlrpc_sec_put(sec);
+       atomic_dec(&sec->ps_nctx);
+       sptlrpc_sec_put(sec);
 }
 
 static void ctx_release_kr(struct ptlrpc_cli_ctx *ctx, int sync)
 {
-        if (sync) {
-                ctx_destroy_kr(ctx);
-        } else {
-                atomic_inc(&ctx->cc_refcount);
-                sptlrpc_gc_add_ctx(ctx);
-        }
+       if (sync) {
+               ctx_destroy_kr(ctx);
+       } else {
+               atomic_inc(&ctx->cc_refcount);
+               sptlrpc_gc_add_ctx(ctx);
+       }
 }
 
 static void ctx_put_kr(struct ptlrpc_cli_ctx *ctx, int sync)
 {
-        LASSERT(atomic_read(&ctx->cc_refcount) > 0);
+       LASSERT(atomic_read(&ctx->cc_refcount) > 0);
 
-        if (atomic_dec_and_test(&ctx->cc_refcount))
-                ctx_release_kr(ctx, sync);
+       if (atomic_dec_and_test(&ctx->cc_refcount))
+               ctx_release_kr(ctx, sync);
 }
 
 /*
@@ -291,33 +284,33 @@ static void ctx_put_kr(struct ptlrpc_cli_ctx *ctx, int sync)
 
 static inline void spin_lock_if(spinlock_t *lock, int condition)
 {
-        if (condition)
-                spin_lock(lock);
+       if (condition)
+               spin_lock(lock);
 }
 
 static inline void spin_unlock_if(spinlock_t *lock, int condition)
 {
-        if (condition)
-                spin_unlock(lock);
+       if (condition)
+               spin_unlock(lock);
 }
 
 static void ctx_enlist_kr(struct ptlrpc_cli_ctx *ctx, int is_root, int locked)
 {
-        struct ptlrpc_sec      *sec = ctx->cc_sec;
-        struct gss_sec_keyring *gsec_kr = sec2gsec_keyring(sec);
+       struct ptlrpc_sec       *sec = ctx->cc_sec;
+       struct gss_sec_keyring  *gsec_kr = sec2gsec_keyring(sec);
 
-        LASSERT(!test_bit(PTLRPC_CTX_CACHED_BIT, &ctx->cc_flags));
-        LASSERT(atomic_read(&ctx->cc_refcount) > 0);
+       LASSERT(!test_bit(PTLRPC_CTX_CACHED_BIT, &ctx->cc_flags));
+       LASSERT(atomic_read(&ctx->cc_refcount) > 0);
 
-        spin_lock_if(&sec->ps_lock, !locked);
+       spin_lock_if(&sec->ps_lock, !locked);
 
-        atomic_inc(&ctx->cc_refcount);
-        set_bit(PTLRPC_CTX_CACHED_BIT, &ctx->cc_flags);
-        hlist_add_head(&ctx->cc_cache, &gsec_kr->gsk_clist);
-        if (is_root)
-                gsec_kr->gsk_root_ctx = ctx;
+       atomic_inc(&ctx->cc_refcount);
+       set_bit(PTLRPC_CTX_CACHED_BIT, &ctx->cc_flags);
+       hlist_add_head(&ctx->cc_cache, &gsec_kr->gsk_clist);
+       if (is_root)
+               gsec_kr->gsk_root_ctx = ctx;
 
-        spin_unlock_if(&sec->ps_lock, !locked);
+       spin_unlock_if(&sec->ps_lock, !locked);
 }
 
 /*
@@ -329,24 +322,61 @@ static void ctx_enlist_kr(struct ptlrpc_cli_ctx *ctx, int is_root, int locked)
  */
 static int ctx_unlist_kr(struct ptlrpc_cli_ctx *ctx, int locked)
 {
-        struct ptlrpc_sec       *sec = ctx->cc_sec;
-        struct gss_sec_keyring  *gsec_kr = sec2gsec_keyring(sec);
+       struct ptlrpc_sec       *sec = ctx->cc_sec;
+       struct gss_sec_keyring  *gsec_kr = sec2gsec_keyring(sec);
 
-        /* if hashed bit has gone, leave the job to somebody who is doing it */
-        if (test_and_clear_bit(PTLRPC_CTX_CACHED_BIT, &ctx->cc_flags) == 0)
-                return 0;
+       /* if hashed bit has gone, leave the job to somebody who is doing it */
+       if (test_and_clear_bit(PTLRPC_CTX_CACHED_BIT, &ctx->cc_flags) == 0)
+               return 0;
+
+       /* drop ref inside spin lock to prevent race with other operations */
+       spin_lock_if(&sec->ps_lock, !locked);
 
-        /* drop ref inside spin lock to prevent race with other operations */
-        spin_lock_if(&sec->ps_lock, !locked);
+       if (gsec_kr->gsk_root_ctx == ctx)
+               gsec_kr->gsk_root_ctx = NULL;
+       hlist_del_init(&ctx->cc_cache);
+       atomic_dec(&ctx->cc_refcount);
 
-        if (gsec_kr->gsk_root_ctx == ctx)
-                gsec_kr->gsk_root_ctx = NULL;
-        hlist_del_init(&ctx->cc_cache);
-        atomic_dec(&ctx->cc_refcount);
+       spin_unlock_if(&sec->ps_lock, !locked);
+
+       return 1;
+}
 
-        spin_unlock_if(&sec->ps_lock, !locked);
+/*
+ * Get specific payload. Newer kernels support 4 slots.
+ */
+static void *
+key_get_payload(struct key *key, unsigned int index)
+{
+       void *key_ptr = NULL;
+
+#ifdef HAVE_KEY_PAYLOAD_DATA_ARRAY
+       key_ptr = key->payload.data[index];
+#else
+       if (!index)
+               key_ptr = key->payload.data;
+#endif
+       return key_ptr;
+}
+
+/*
+ * Set specific payload. Newer kernels support 4 slots.
+ */
+static int key_set_payload(struct key *key, unsigned int index,
+                          struct ptlrpc_cli_ctx *ctx)
+{
+       int rc = -EINVAL;
 
-        return 1;
+#ifdef HAVE_KEY_PAYLOAD_DATA_ARRAY
+       if (index < 4) {
+               key->payload.data[index] = ctx;
+#else
+       if (!index) {
+               key->payload.data = ctx;
+#endif
+               rc = 0;
+       }
+       return rc;
 }
 
 /*
@@ -355,16 +385,16 @@ static int ctx_unlist_kr(struct ptlrpc_cli_ctx *ctx, int locked)
  */
 static void bind_key_ctx(struct key *key, struct ptlrpc_cli_ctx *ctx)
 {
-        LASSERT(atomic_read(&ctx->cc_refcount) > 0);
-        LASSERT(atomic_read(&key->usage) > 0);
-        LASSERT(ctx2gctx_keyring(ctx)->gck_key == NULL);
-        LASSERT(key->payload.data == NULL);
-
-        /* at this time context may or may not in list. */
-        key_get(key);
-        atomic_inc(&ctx->cc_refcount);
-        ctx2gctx_keyring(ctx)->gck_key = key;
-        key->payload.data = ctx;
+       LASSERT(atomic_read(&ctx->cc_refcount) > 0);
+       LASSERT(ll_read_key_usage(key) > 0);
+       LASSERT(ctx2gctx_keyring(ctx)->gck_key == NULL);
+       LASSERT(!key_get_payload(key, 0));
+
+       /* at this time context may or may not in list. */
+       key_get(key);
+       atomic_inc(&ctx->cc_refcount);
+       ctx2gctx_keyring(ctx)->gck_key = key;
+       LASSERT(!key_set_payload(key, 0, ctx));
 }
 
 /*
@@ -373,13 +403,13 @@ static void bind_key_ctx(struct key *key, struct ptlrpc_cli_ctx *ctx)
  */
 static void unbind_key_ctx(struct key *key, struct ptlrpc_cli_ctx *ctx)
 {
-        LASSERT(key->payload.data == ctx);
-        LASSERT(test_bit(PTLRPC_CTX_CACHED_BIT, &ctx->cc_flags) == 0);
+       LASSERT(key_get_payload(key, 0) == ctx);
+       LASSERT(test_bit(PTLRPC_CTX_CACHED_BIT, &ctx->cc_flags) == 0);
 
         /* must revoke the key, or others may treat it as newly created */
         key_revoke_locked(key);
 
-        key->payload.data = NULL;
+       key_set_payload(key, 0, NULL);
         ctx2gctx_keyring(ctx)->gck_key = NULL;
 
         /* once ctx get split from key, the timer is meaningless */
@@ -399,7 +429,7 @@ static void unbind_ctx_kr(struct ptlrpc_cli_ctx *ctx)
         struct key      *key = ctx2gctx_keyring(ctx)->gck_key;
 
         if (key) {
-                LASSERT(key->payload.data == ctx);
+               LASSERT(key_get_payload(key, 0) == ctx);
 
                 key_get(key);
                 down_write(&key->sem);
@@ -415,7 +445,7 @@ static void unbind_ctx_kr(struct ptlrpc_cli_ctx *ctx)
  */
 static void unbind_key_locked(struct key *key)
 {
-        struct ptlrpc_cli_ctx   *ctx = key->payload.data;
+       struct ptlrpc_cli_ctx *ctx = key_get_payload(key, 0);
 
         if (ctx)
                 unbind_key_ctx(key, ctx);
@@ -436,7 +466,7 @@ static void kill_ctx_kr(struct ptlrpc_cli_ctx *ctx)
  */
 static void kill_key_locked(struct key *key)
 {
-        struct ptlrpc_cli_ctx *ctx = key->payload.data;
+       struct ptlrpc_cli_ctx *ctx = key_get_payload(key, 0);
 
         if (ctx && ctx_unlist_kr(ctx, 0))
                 unbind_key_locked(key);
@@ -447,36 +477,36 @@ static void kill_key_locked(struct key *key)
  */
 static void dispose_ctx_list_kr(struct hlist_head *freelist)
 {
-        struct hlist_node      *pos, *next;
-        struct ptlrpc_cli_ctx  *ctx;
-        struct gss_cli_ctx     *gctx;
-
-        hlist_for_each_entry_safe(ctx, pos, next, freelist, cc_cache) {
-                hlist_del_init(&ctx->cc_cache);
-
-                /* reverse ctx: update current seq to buddy svcctx if exist.
-                 * ideally this should be done at gss_cli_ctx_finalize(), but
-                 * the ctx destroy could be delayed by:
-                 *  1) ctx still has reference;
-                 *  2) ctx destroy is asynchronous;
-                 * and reverse import call inval_all_ctx() require this be done
-                 *_immediately_ otherwise newly created reverse ctx might copy
-                 * the very old sequence number from svcctx. */
-                gctx = ctx2gctx(ctx);
-                if (!rawobj_empty(&gctx->gc_svc_handle) &&
-                    sec_is_reverse(gctx->gc_base.cc_sec)) {
-                        gss_svc_upcall_update_sequence(&gctx->gc_svc_handle,
-                                        (__u32) atomic_read(&gctx->gc_seq));
-                }
-
-                /* we need to wakeup waiting reqs here. the context might
-                 * be forced released before upcall finished, then the
-                 * late-arrived downcall can't find the ctx even. */
-                sptlrpc_cli_ctx_wakeup(ctx);
-
-                unbind_ctx_kr(ctx);
-                ctx_put_kr(ctx, 0);
-        }
+       struct hlist_node       __maybe_unused *pos, *next;
+       struct ptlrpc_cli_ctx   *ctx;
+       struct gss_cli_ctx      *gctx;
+
+       cfs_hlist_for_each_entry_safe(ctx, pos, next, freelist, cc_cache) {
+               hlist_del_init(&ctx->cc_cache);
+
+               /* reverse ctx: update current seq to buddy svcctx if exist.
+                * ideally this should be done at gss_cli_ctx_finalize(), but
+                * the ctx destroy could be delayed by:
+                *  1) ctx still has reference;
+                *  2) ctx destroy is asynchronous;
+                * and reverse import call inval_all_ctx() require this be done
+                _immediately_ otherwise newly created reverse ctx might copy
+                * the very old sequence number from svcctx. */
+               gctx = ctx2gctx(ctx);
+               if (!rawobj_empty(&gctx->gc_svc_handle) &&
+                   sec_is_reverse(gctx->gc_base.cc_sec)) {
+                       gss_svc_upcall_update_sequence(&gctx->gc_svc_handle,
+                                       (__u32) atomic_read(&gctx->gc_seq));
+               }
+
+               /* we need to wakeup waiting reqs here. the context might
+                * be forced released before upcall finished, then the
+                * late-arrived downcall can't find the ctx even. */
+               sptlrpc_cli_ctx_wakeup(ctx);
+
+               unbind_ctx_kr(ctx);
+               ctx_put_kr(ctx, 0);
+       }
 }
 
 /*
@@ -486,21 +516,22 @@ static void dispose_ctx_list_kr(struct hlist_head *freelist)
 static
 struct ptlrpc_cli_ctx * sec_lookup_root_ctx_kr(struct ptlrpc_sec *sec)
 {
-        struct gss_sec_keyring  *gsec_kr = sec2gsec_keyring(sec);
-        struct ptlrpc_cli_ctx   *ctx = NULL;
+       struct gss_sec_keyring  *gsec_kr = sec2gsec_keyring(sec);
+       struct ptlrpc_cli_ctx   *ctx = NULL;
 
-        spin_lock(&sec->ps_lock);
+       spin_lock(&sec->ps_lock);
 
         ctx = gsec_kr->gsk_root_ctx;
 
         if (ctx == NULL && unlikely(sec_is_reverse(sec))) {
-                struct hlist_node      *node;
-                struct ptlrpc_cli_ctx  *tmp;
+               struct hlist_node       __maybe_unused *node;
+               struct ptlrpc_cli_ctx   *tmp;
 
                 /* reverse ctx, search root ctx in list, choose the one
                  * with shortest expire time, which is most possibly have
                  * an established peer ctx at client side. */
-                hlist_for_each_entry(tmp, node, &gsec_kr->gsk_clist, cc_cache) {
+                cfs_hlist_for_each_entry(tmp, node, &gsec_kr->gsk_clist,
+                                         cc_cache) {
                         if (ctx == NULL || ctx->cc_expire == 0 ||
                             ctx->cc_expire > tmp->cc_expire) {
                                 ctx = tmp;
@@ -510,15 +541,15 @@ struct ptlrpc_cli_ctx * sec_lookup_root_ctx_kr(struct ptlrpc_sec *sec)
                 }
         }
 
-        if (ctx) {
-                LASSERT(atomic_read(&ctx->cc_refcount) > 0);
-                LASSERT(!hlist_empty(&gsec_kr->gsk_clist));
-                atomic_inc(&ctx->cc_refcount);
-        }
+       if (ctx) {
+               LASSERT(atomic_read(&ctx->cc_refcount) > 0);
+               LASSERT(!hlist_empty(&gsec_kr->gsk_clist));
+               atomic_inc(&ctx->cc_refcount);
+       }
 
-        spin_unlock(&sec->ps_lock);
+       spin_unlock(&sec->ps_lock);
 
-        return ctx;
+       return ctx;
 }
 
 #define RVS_CTX_EXPIRE_NICE    (10)
@@ -528,20 +559,20 @@ void rvs_sec_install_root_ctx_kr(struct ptlrpc_sec *sec,
                                  struct ptlrpc_cli_ctx *new_ctx,
                                  struct key *key)
 {
-        struct gss_sec_keyring *gsec_kr = sec2gsec_keyring(sec);
-        struct hlist_node      *hnode;
-        struct ptlrpc_cli_ctx  *ctx;
-        cfs_time_t              now;
-        ENTRY;
+       struct gss_sec_keyring *gsec_kr = sec2gsec_keyring(sec);
+       struct hlist_node __maybe_unused *hnode;
+       struct ptlrpc_cli_ctx *ctx;
+       time64_t now;
 
-        LASSERT(sec_is_reverse(sec));
+       ENTRY;
+       LASSERT(sec_is_reverse(sec));
 
-        spin_lock(&sec->ps_lock);
+       spin_lock(&sec->ps_lock);
 
-        now = cfs_time_current_sec();
+       now = ktime_get_real_seconds();
 
         /* set all existing ctxs short expiry */
-        hlist_for_each_entry(ctx, hnode, &gsec_kr->gsk_clist, cc_cache) {
+        cfs_hlist_for_each_entry(ctx, hnode, &gsec_kr->gsk_clist, cc_cache) {
                 if (ctx->cc_expire > now + RVS_CTX_EXPIRE_NICE) {
                         ctx->cc_early_expire = 1;
                         ctx->cc_expire = now + RVS_CTX_EXPIRE_NICE;
@@ -557,7 +588,7 @@ void rvs_sec_install_root_ctx_kr(struct ptlrpc_sec *sec,
         if (key)
                 bind_key_ctx(key, new_ctx);
 
-        spin_unlock(&sec->ps_lock);
+       spin_unlock(&sec->ps_lock);
 }
 
 static void construct_key_desc(void *buf, int bufsize,
@@ -583,11 +614,11 @@ struct ptlrpc_sec * gss_sec_create_kr(struct obd_import *imp,
         if (gsec_kr == NULL)
                 RETURN(NULL);
 
-        CFS_INIT_HLIST_HEAD(&gsec_kr->gsk_clist);
+       INIT_HLIST_HEAD(&gsec_kr->gsk_clist);
         gsec_kr->gsk_root_ctx = NULL;
-        mutex_init(&gsec_kr->gsk_root_uc_lock);
+       mutex_init(&gsec_kr->gsk_root_uc_lock);
 #ifdef HAVE_KEYRING_UPCALL_SERIALIZED
-        mutex_init(&gsec_kr->gsk_uc_lock);
+       mutex_init(&gsec_kr->gsk_uc_lock);
 #endif
 
         if (gss_sec_create_common(&gsec_kr->gsk_base, &gss_policy_keyring,
@@ -615,7 +646,7 @@ void gss_sec_destroy_kr(struct ptlrpc_sec *sec)
 
         CDEBUG(D_SEC, "destroy %s@%p\n", sec->ps_policy->sp_name, sec);
 
-        LASSERT(hlist_empty(&gsec_kr->gsk_clist));
+       LASSERT(hlist_empty(&gsec_kr->gsk_clist));
         LASSERT(gsec_kr->gsk_root_ctx == NULL);
 
         gss_sec_destroy_common(gsec);
@@ -641,39 +672,40 @@ static inline int user_is_root(struct ptlrpc_sec *sec, struct vfs_cred *vcred)
  */
 static void request_key_unlink(struct key *key)
 {
-        struct task_struct *tsk = current;
-        struct key *ring;
-
-        switch (tsk->jit_keyring) {
-        case KEY_REQKEY_DEFL_DEFAULT:
-        case KEY_REQKEY_DEFL_THREAD_KEYRING:
-                ring = key_get(tsk->thread_keyring);
-                if (ring)
-                        break;
-        case KEY_REQKEY_DEFL_PROCESS_KEYRING:
-                ring = key_get(tsk->signal->process_keyring);
-                if (ring)
-                        break;
-        case KEY_REQKEY_DEFL_SESSION_KEYRING:
-                rcu_read_lock();
-                ring = key_get(rcu_dereference(tsk->signal->session_keyring));
-                rcu_read_unlock();
-                if (ring)
-                        break;
-        case KEY_REQKEY_DEFL_USER_SESSION_KEYRING:
-                ring = key_get(tsk->user->session_keyring);
-                break;
-        case KEY_REQKEY_DEFL_USER_KEYRING:
-                ring = key_get(tsk->user->uid_keyring);
-                break;
-        case KEY_REQKEY_DEFL_GROUP_KEYRING:
-        default:
-                LBUG();
-        }
-
-        LASSERT(ring);
-        key_unlink(ring, key);
-        key_put(ring);
+       struct task_struct *tsk = current;
+       struct key *ring;
+
+       switch (key_cred(tsk)->jit_keyring) {
+       case KEY_REQKEY_DEFL_DEFAULT:
+       case KEY_REQKEY_DEFL_THREAD_KEYRING:
+               ring = key_get(key_cred(tsk)->thread_keyring);
+               if (ring)
+                       break;
+       case KEY_REQKEY_DEFL_PROCESS_KEYRING:
+               ring = key_get(key_tgcred(tsk)->process_keyring);
+               if (ring)
+                       break;
+       case KEY_REQKEY_DEFL_SESSION_KEYRING:
+               rcu_read_lock();
+               ring = key_get(rcu_dereference(key_tgcred(tsk)
+                                              ->session_keyring));
+               rcu_read_unlock();
+               if (ring)
+                       break;
+       case KEY_REQKEY_DEFL_USER_SESSION_KEYRING:
+               ring = key_get(key_cred(tsk)->user->session_keyring);
+               break;
+       case KEY_REQKEY_DEFL_USER_KEYRING:
+               ring = key_get(key_cred(tsk)->user->uid_keyring);
+               break;
+       case KEY_REQKEY_DEFL_GROUP_KEYRING:
+       default:
+               LBUG();
+       }
+
+       LASSERT(ring);
+       key_unlink(ring, key);
+       key_put(ring);
 }
 
 static
@@ -689,7 +721,8 @@ struct ptlrpc_cli_ctx * gss_sec_lookup_ctx_kr(struct ptlrpc_sec *sec,
         char                     desc[24];
         char                    *coinfo;
         int                      coinfo_size;
-        char                    *co_flags = "";
+       const char              *sec_part_flags = "";
+       char                     svc_flag = '-';
         ENTRY;
 
         LASSERT(imp != NULL);
@@ -713,7 +746,7 @@ struct ptlrpc_cli_ctx * gss_sec_lookup_ctx_kr(struct ptlrpc_sec *sec,
          * the root upcall lock, make sure nobody else populated new root
          * context after last check. */
         if (is_root) {
-                mutex_lock(&gsec_kr->gsk_root_uc_lock);
+               mutex_lock(&gsec_kr->gsk_root_uc_lock);
 
                 ctx = sec_lookup_root_ctx_kr(sec);
                 if (ctx)
@@ -722,34 +755,87 @@ struct ptlrpc_cli_ctx * gss_sec_lookup_ctx_kr(struct ptlrpc_sec *sec,
                 /* update reverse handle for root user */
                 sec2gsec(sec)->gs_rvs_hdl = gss_get_next_ctx_index();
 
-                co_flags = "r";
-        }
-
-        /* in case of setuid, key will be constructed as owner of fsuid/fsgid,
-         * but we do authentication based on real uid/gid. the key permission
-         * bits will be exactly as POS_ALL, so only processes who subscribed
-         * this key could have the access, although the quota might be counted
-         * on others (fsuid/fsgid).
-         *
-         * keyring will use fsuid/fsgid as upcall parameters, so we have to
-         * encode real uid/gid into callout info.
-         */
-
-        construct_key_desc(desc, sizeof(desc), sec, vcred->vc_uid);
-
-        /* callout info format:
-         * secid:mech:uid:gid:flags:svc_type:peer_nid:target_uuid
-         */
-        coinfo_size = sizeof(struct obd_uuid) + MAX_OBD_NAME + 64;
-        OBD_ALLOC(coinfo, coinfo_size);
-        if (coinfo == NULL)
-                goto out;
+               switch (sec->ps_part) {
+               case LUSTRE_SP_MDT:
+                       sec_part_flags = "m";
+                       break;
+               case LUSTRE_SP_OST:
+                       sec_part_flags = "o";
+                       break;
+               case LUSTRE_SP_MGC:
+                       sec_part_flags = "rmo";
+                       break;
+               case LUSTRE_SP_CLI:
+                       sec_part_flags = "r";
+                       break;
+               case LUSTRE_SP_MGS:
+               default:
+                       LBUG();
+                }
 
-        snprintf(coinfo, coinfo_size, "%d:%s:%u:%u:%s:%d:"LPX64":%s",
-                 sec->ps_id, sec2gsec(sec)->gs_mech->gm_name,
-                 vcred->vc_uid, vcred->vc_gid,
-                 co_flags, import_to_gss_svc(imp),
-                 imp->imp_connection->c_peer.nid, imp->imp_obd->obd_name);
+               switch (SPTLRPC_FLVR_SVC(sec->ps_flvr.sf_rpc)) {
+               case SPTLRPC_SVC_NULL:
+                       svc_flag = 'n';
+                       break;
+               case SPTLRPC_SVC_AUTH:
+                       svc_flag = 'a';
+                       break;
+               case SPTLRPC_SVC_INTG:
+                       svc_flag = 'i';
+                       break;
+               case SPTLRPC_SVC_PRIV:
+                       svc_flag = 'p';
+                       break;
+               default:
+                       LBUG();
+               }
+       }
+
+       /* in case of setuid, key will be constructed as owner of fsuid/fsgid,
+        * but we do authentication based on real uid/gid. the key permission
+        * bits will be exactly as POS_ALL, so only processes who subscribed
+        * this key could have the access, although the quota might be counted
+        * on others (fsuid/fsgid).
+        *
+        * keyring will use fsuid/fsgid as upcall parameters, so we have to
+        * encode real uid/gid into callout info.
+        */
+
+       /* But first we need to make sure the obd type is supported */
+       if (strcmp(imp->imp_obd->obd_type->typ_name, LUSTRE_MDC_NAME) &&
+           strcmp(imp->imp_obd->obd_type->typ_name, LUSTRE_OSC_NAME) &&
+           strcmp(imp->imp_obd->obd_type->typ_name, LUSTRE_MGC_NAME) &&
+           strcmp(imp->imp_obd->obd_type->typ_name, LUSTRE_LWP_NAME) &&
+           strcmp(imp->imp_obd->obd_type->typ_name, LUSTRE_OSP_NAME)) {
+               CERROR("obd %s is not a supported device\n",
+                      imp->imp_obd->obd_name);
+               GOTO(out, ctx = NULL);
+       }
+
+       construct_key_desc(desc, sizeof(desc), sec, vcred->vc_uid);
+
+       /* callout info format:
+        * secid:mech:uid:gid:sec_flags:svc_flag:svc_type:peer_nid:target_uuid:
+        * self_nid:pid
+        */
+       coinfo_size = sizeof(struct obd_uuid) + MAX_OBD_NAME + 64;
+       OBD_ALLOC(coinfo, coinfo_size);
+       if (coinfo == NULL)
+               goto out;
+
+       /* Last callout parameter is pid of process whose namespace will be used
+        * for credentials' retrieval.
+        * For user's credentials (in which case sec_part_flags is empty), use
+        * current PID instead of import's reference PID to get reference
+        * namespace. */
+       snprintf(coinfo, coinfo_size, "%d:%s:%u:%u:%s:%c:%d:%#llx:%s:%#llx:%d",
+                sec->ps_id, sec2gsec(sec)->gs_mech->gm_name,
+                vcred->vc_uid, vcred->vc_gid,
+                sec_part_flags, svc_flag, import_to_gss_svc(imp),
+                imp->imp_connection->c_peer.nid, imp->imp_obd->obd_name,
+                imp->imp_connection->c_self,
+                sec_part_flags[0] == '\0' ?
+                      current_pid() : imp->imp_sec_refpid);
 
         CDEBUG(D_SEC, "requesting key for %s\n", desc);
 
@@ -771,37 +857,36 @@ struct ptlrpc_cli_ctx * gss_sec_lookup_ctx_kr(struct ptlrpc_sec *sec,
          * need wirtelock of key->sem to serialize them. */
         down_write(&key->sem);
 
-        if (likely(key->payload.data != NULL)) {
-                ctx = key->payload.data;
-
-                LASSERT(atomic_read(&ctx->cc_refcount) >= 1);
-                LASSERT(ctx2gctx_keyring(ctx)->gck_key == key);
-                LASSERT(atomic_read(&key->usage) >= 2);
-
-                /* simply take a ref and return. it's upper layer's
-                 * responsibility to detect & replace dead ctx. */
-                atomic_inc(&ctx->cc_refcount);
-        } else {
-                /* pre initialization with a cli_ctx. this can't be done in
-                 * key_instantiate() because we'v no enough information
-                 * there. */
-                ctx = ctx_create_kr(sec, vcred);
-                if (ctx != NULL) {
-                        ctx_enlist_kr(ctx, is_root, 0);
-                        bind_key_ctx(key, ctx);
-
-                        ctx_start_timer_kr(ctx, KEYRING_UPCALL_TIMEOUT);
-
-                        CDEBUG(D_SEC, "installed key %p <-> ctx %p (sec %p)\n",
-                               key, ctx, sec);
-                } else {
-                        /* we'd prefer to call key_revoke(), but we more like
-                         * to revoke it within this key->sem locked period. */
-                        key_revoke_locked(key);
-                }
-
-                create_new = 1;
-        }
+       ctx = key_get_payload(key, 0);
+       if (likely(ctx)) {
+               LASSERT(atomic_read(&ctx->cc_refcount) >= 1);
+               LASSERT(ctx2gctx_keyring(ctx)->gck_key == key);
+               LASSERT(ll_read_key_usage(key) >= 2);
+
+               /* simply take a ref and return. it's upper layer's
+                * responsibility to detect & replace dead ctx. */
+               atomic_inc(&ctx->cc_refcount);
+       } else {
+               /* pre initialization with a cli_ctx. this can't be done in
+                * key_instantiate() because we'v no enough information
+                * there. */
+               ctx = ctx_create_kr(sec, vcred);
+               if (ctx != NULL) {
+                       ctx_enlist_kr(ctx, is_root, 0);
+                       bind_key_ctx(key, ctx);
+
+                       ctx_start_timer_kr(ctx, KEYRING_UPCALL_TIMEOUT);
+
+                       CDEBUG(D_SEC, "installed key %p <-> ctx %p (sec %p)\n",
+                              key, ctx, sec);
+               } else {
+                       /* we'd prefer to call key_revoke(), but we more like
+                        * to revoke it within this key->sem locked period. */
+                       key_revoke_locked(key);
+               }
+
+               create_new = 1;
+       }
 
         up_write(&key->sem);
 
@@ -811,7 +896,7 @@ struct ptlrpc_cli_ctx * gss_sec_lookup_ctx_kr(struct ptlrpc_sec *sec,
         key_put(key);
 out:
         if (is_root)
-                mutex_unlock(&gsec_kr->gsk_root_uc_lock);
+               mutex_unlock(&gsec_kr->gsk_root_uc_lock);
         RETURN(ctx);
 }
 
@@ -820,8 +905,8 @@ void gss_sec_release_ctx_kr(struct ptlrpc_sec *sec,
                             struct ptlrpc_cli_ctx *ctx,
                             int sync)
 {
-        LASSERT(atomic_read(&sec->ps_refcount) > 0);
-        LASSERT(atomic_read(&ctx->cc_refcount) == 0);
+       LASSERT(atomic_read(&sec->ps_refcount) > 0);
+       LASSERT(atomic_read(&ctx->cc_refcount) == 0);
         ctx_release_kr(ctx, sync);
 }
 
@@ -846,149 +931,150 @@ void flush_user_ctx_cache_kr(struct ptlrpc_sec *sec,
 
         construct_key_desc(desc, sizeof(desc), sec, uid);
 
-        /* there should be only one valid key, but we put it in the
-         * loop in case of any weird cases */
-        for (;;) {
-                key = request_key(&gss_key_type, desc, NULL);
-                if (IS_ERR(key)) {
-                        CDEBUG(D_SEC, "No more key found for current user\n");
-                        break;
-                }
+       /* there should be only one valid key, but we put it in the
+        * loop in case of any weird cases */
+       for (;;) {
+               key = request_key(&gss_key_type, desc, NULL);
+               if (IS_ERR(key)) {
+                       CDEBUG(D_SEC, "No more key found for current user\n");
+                       break;
+               }
 
-                down_write(&key->sem);
+               down_write(&key->sem);
 
-                kill_key_locked(key);
+               kill_key_locked(key);
 
-                /* kill_key_locked() should usually revoke the key, but we
-                 * revoke it again to make sure, e.g. some case the key may
-                 * not well coupled with a context. */
-                key_revoke_locked(key);
+               /* kill_key_locked() should usually revoke the key, but we
+                * revoke it again to make sure, e.g. some case the key may
+                * not well coupled with a context. */
+               key_revoke_locked(key);
 
-                up_write(&key->sem);
+               up_write(&key->sem);
 
-                key_put(key);
-        }
+               request_key_unlink(key);
+
+               key_put(key);
+       }
 }
 
 /*
  * flush context of root or all, we iterate through the list.
  */
 static
-void flush_spec_ctx_cache_kr(struct ptlrpc_sec *sec,
-                             uid_t uid,
-                             int grace, int force)
+void flush_spec_ctx_cache_kr(struct ptlrpc_sec *sec, uid_t uid, int grace,
+                            int force)
 {
-        struct gss_sec_keyring *gsec_kr;
-        struct hlist_head       freelist = CFS_HLIST_HEAD_INIT;
-        struct hlist_node      *pos, *next;
-        struct ptlrpc_cli_ctx  *ctx;
-        ENTRY;
+       struct gss_sec_keyring  *gsec_kr;
+       struct hlist_head        freelist = HLIST_HEAD_INIT;
+       struct hlist_node       __maybe_unused *pos, *next;
+       struct ptlrpc_cli_ctx   *ctx;
+       ENTRY;
 
         gsec_kr = sec2gsec_keyring(sec);
 
-        spin_lock(&sec->ps_lock);
-        hlist_for_each_entry_safe(ctx, pos, next,
-                                  &gsec_kr->gsk_clist, cc_cache) {
-                LASSERT(atomic_read(&ctx->cc_refcount) > 0);
-
-                if (uid != -1 && uid != ctx->cc_vcred.vc_uid)
-                        continue;
-
-                /* at this moment there's at least 2 base reference:
-                 * key association and in-list. */
-                if (atomic_read(&ctx->cc_refcount) > 2) {
-                        if (!force)
-                                continue;
-                        CWARN("flush busy ctx %p(%u->%s, extra ref %d)\n",
-                              ctx, ctx->cc_vcred.vc_uid,
-                              sec2target_str(ctx->cc_sec),
-                              atomic_read(&ctx->cc_refcount) - 2);
-                }
-
-                set_bit(PTLRPC_CTX_DEAD_BIT, &ctx->cc_flags);
-                if (!grace)
-                        clear_bit(PTLRPC_CTX_UPTODATE_BIT, &ctx->cc_flags);
-
-                atomic_inc(&ctx->cc_refcount);
-
-                if (ctx_unlist_kr(ctx, 1)) {
-                        hlist_add_head(&ctx->cc_cache, &freelist);
-                } else {
-                        LASSERT(atomic_read(&ctx->cc_refcount) >= 2);
-                        atomic_dec(&ctx->cc_refcount);
-                }
-        }
-        spin_unlock(&sec->ps_lock);
-
-        dispose_ctx_list_kr(&freelist);
-        EXIT;
+       spin_lock(&sec->ps_lock);
+       cfs_hlist_for_each_entry_safe(ctx, pos, next,
+                                     &gsec_kr->gsk_clist, cc_cache) {
+               LASSERT(atomic_read(&ctx->cc_refcount) > 0);
+
+               if (uid != -1 && uid != ctx->cc_vcred.vc_uid)
+                       continue;
+
+               /* at this moment there's at least 2 base reference:
+                * key association and in-list. */
+               if (atomic_read(&ctx->cc_refcount) > 2) {
+                       if (!force)
+                               continue;
+                       CWARN("flush busy ctx %p(%u->%s, extra ref %d)\n",
+                             ctx, ctx->cc_vcred.vc_uid,
+                             sec2target_str(ctx->cc_sec),
+                             atomic_read(&ctx->cc_refcount) - 2);
+               }
+
+               set_bit(PTLRPC_CTX_DEAD_BIT, &ctx->cc_flags);
+               if (!grace)
+                       clear_bit(PTLRPC_CTX_UPTODATE_BIT, &ctx->cc_flags);
+
+               atomic_inc(&ctx->cc_refcount);
+
+               if (ctx_unlist_kr(ctx, 1)) {
+                       hlist_add_head(&ctx->cc_cache, &freelist);
+               } else {
+                       LASSERT(atomic_read(&ctx->cc_refcount) >= 2);
+                       atomic_dec(&ctx->cc_refcount);
+               }
+       }
+       spin_unlock(&sec->ps_lock);
+
+       dispose_ctx_list_kr(&freelist);
+       EXIT;
 }
 
 static
 int gss_sec_flush_ctx_cache_kr(struct ptlrpc_sec *sec,
-                               uid_t uid,
-                               int grace, int force)
+                               uid_t uid, int grace, int force)
 {
-        ENTRY;
+       ENTRY;
 
-        CDEBUG(D_SEC, "sec %p(%d, nctx %d), uid %d, grace %d, force %d\n",
-               sec, atomic_read(&sec->ps_refcount), atomic_read(&sec->ps_nctx),
-               uid, grace, force);
+       CDEBUG(D_SEC, "sec %p(%d, nctx %d), uid %d, grace %d, force %d\n",
+              sec, atomic_read(&sec->ps_refcount),
+              atomic_read(&sec->ps_nctx),
+              uid, grace, force);
 
-        if (uid != -1 && uid != 0)
-                flush_user_ctx_cache_kr(sec, uid, grace, force);
-        else
-                flush_spec_ctx_cache_kr(sec, uid, grace, force);
+       if (uid != -1 && uid != 0)
+               flush_user_ctx_cache_kr(sec, uid, grace, force);
+       else
+               flush_spec_ctx_cache_kr(sec, uid, grace, force);
 
-        RETURN(0);
+       RETURN(0);
 }
 
 static
 void gss_sec_gc_ctx_kr(struct ptlrpc_sec *sec)
 {
-        struct gss_sec_keyring *gsec_kr = sec2gsec_keyring(sec);
-        struct hlist_head       freelist = CFS_HLIST_HEAD_INIT;
-        struct hlist_node      *pos, *next;
-        struct ptlrpc_cli_ctx  *ctx;
-        ENTRY;
-
-        CWARN("running gc\n");
-
-        spin_lock(&sec->ps_lock);
-        hlist_for_each_entry_safe(ctx, pos, next,
-                                  &gsec_kr->gsk_clist, cc_cache) {
-                LASSERT(atomic_read(&ctx->cc_refcount) > 0);
-
-                atomic_inc(&ctx->cc_refcount);
-
-                if (cli_ctx_check_death(ctx) && ctx_unlist_kr(ctx, 1)) {
-                        hlist_add_head(&ctx->cc_cache, &freelist);
-                        CWARN("unhashed ctx %p\n", ctx);
-                } else {
-                        LASSERT(atomic_read(&ctx->cc_refcount) >= 2);
-                        atomic_dec(&ctx->cc_refcount);
-                }
-        }
-        spin_unlock(&sec->ps_lock);
-
-        dispose_ctx_list_kr(&freelist);
-        EXIT;
-        return;
+       struct gss_sec_keyring  *gsec_kr = sec2gsec_keyring(sec);
+       struct hlist_head       freelist = HLIST_HEAD_INIT;
+       struct hlist_node       __maybe_unused *pos, *next;
+       struct ptlrpc_cli_ctx   *ctx;
+       ENTRY;
+
+       CWARN("running gc\n");
+
+       spin_lock(&sec->ps_lock);
+       cfs_hlist_for_each_entry_safe(ctx, pos, next,
+                                     &gsec_kr->gsk_clist, cc_cache) {
+               LASSERT(atomic_read(&ctx->cc_refcount) > 0);
+
+               atomic_inc(&ctx->cc_refcount);
+
+               if (cli_ctx_check_death(ctx) && ctx_unlist_kr(ctx, 1)) {
+                       hlist_add_head(&ctx->cc_cache, &freelist);
+                       CWARN("unhashed ctx %p\n", ctx);
+               } else {
+                       LASSERT(atomic_read(&ctx->cc_refcount) >= 2);
+                       atomic_dec(&ctx->cc_refcount);
+               }
+       }
+       spin_unlock(&sec->ps_lock);
+
+       dispose_ctx_list_kr(&freelist);
+       EXIT;
+       return;
 }
 
 static
 int gss_sec_display_kr(struct ptlrpc_sec *sec, struct seq_file *seq)
 {
-        struct gss_sec_keyring *gsec_kr = sec2gsec_keyring(sec);
-        struct hlist_node      *pos, *next;
-        struct ptlrpc_cli_ctx  *ctx;
-        struct gss_cli_ctx     *gctx;
-        time_t                  now = cfs_time_current_sec();
-        ENTRY;
-
-        spin_lock(&sec->ps_lock);
-        hlist_for_each_entry_safe(ctx, pos, next,
-                                  &gsec_kr->gsk_clist, cc_cache) {
+       struct gss_sec_keyring *gsec_kr = sec2gsec_keyring(sec);
+       struct hlist_node __maybe_unused *pos, *next;
+       struct ptlrpc_cli_ctx *ctx;
+       struct gss_cli_ctx *gctx;
+       time64_t now = ktime_get_real_seconds();
+
+       ENTRY;
+       spin_lock(&sec->ps_lock);
+        cfs_hlist_for_each_entry_safe(ctx, pos, next,
+                                     &gsec_kr->gsk_clist, cc_cache) {
                 struct key             *key;
                 char                    flags_str[40];
                 char                    mech[40];
@@ -1005,25 +1091,24 @@ int gss_sec_display_kr(struct ptlrpc_sec *sec, struct seq_file *seq)
                         snprintf(mech, sizeof(mech), "N/A");
                 mech[sizeof(mech) - 1] = '\0';
 
-                seq_printf(seq, "%p: uid %u, ref %d, expire %ld(%+ld), fl %s, "
-                           "seq %d, win %u, key %08x(ref %d), "
-                           "hdl "LPX64":"LPX64", mech: %s\n",
-                           ctx, ctx->cc_vcred.vc_uid,
-                           atomic_read(&ctx->cc_refcount),
-                           ctx->cc_expire,
-                           ctx->cc_expire ?  ctx->cc_expire - now : 0,
-                           flags_str,
-                           atomic_read(&gctx->gc_seq),
-                           gctx->gc_win,
-                           key ? key->serial : 0,
-                           key ? atomic_read(&key->usage) : 0,
-                           gss_handle_to_u64(&gctx->gc_handle),
-                           gss_handle_to_u64(&gctx->gc_svc_handle),
-                           mech);
-        }
-        spin_unlock(&sec->ps_lock);
-
-        RETURN(0);
+               seq_printf(seq,
+                          "%p: uid %u, ref %d, expire %lld(%+lld), fl %s, seq %d, win %u, key %08x(ref %d), hdl %#llx:%#llx, mech: %s\n",
+                          ctx, ctx->cc_vcred.vc_uid,
+                          atomic_read(&ctx->cc_refcount),
+                          ctx->cc_expire,
+                          ctx->cc_expire ?  ctx->cc_expire - now : 0,
+                          flags_str,
+                          atomic_read(&gctx->gc_seq),
+                          gctx->gc_win,
+                          key ? key->serial : 0,
+                          key ? ll_read_key_usage(key) : 0,
+                          gss_handle_to_u64(&gctx->gc_handle),
+                          gss_handle_to_u64(&gctx->gc_svc_handle),
+                          mech);
+       }
+       spin_unlock(&sec->ps_lock);
+
+       RETURN(0);
 }
 
 /****************************************
@@ -1040,27 +1125,27 @@ int gss_cli_ctx_refresh_kr(struct ptlrpc_cli_ctx *ctx)
 static
 int gss_cli_ctx_validate_kr(struct ptlrpc_cli_ctx *ctx)
 {
-        LASSERT(atomic_read(&ctx->cc_refcount) > 0);
-        LASSERT(ctx->cc_sec);
+       LASSERT(atomic_read(&ctx->cc_refcount) > 0);
+       LASSERT(ctx->cc_sec);
 
-        if (cli_ctx_check_death(ctx)) {
-                kill_ctx_kr(ctx);
-                return 1;
-        }
+       if (cli_ctx_check_death(ctx)) {
+               kill_ctx_kr(ctx);
+               return 1;
+       }
 
-        if (cli_ctx_is_ready(ctx))
-                return 0;
-        return 1;
+       if (cli_ctx_is_ready(ctx))
+               return 0;
+       return 1;
 }
 
 static
 void gss_cli_ctx_die_kr(struct ptlrpc_cli_ctx *ctx, int grace)
 {
-        LASSERT(atomic_read(&ctx->cc_refcount) > 0);
-        LASSERT(ctx->cc_sec);
+       LASSERT(atomic_read(&ctx->cc_refcount) > 0);
+       LASSERT(ctx->cc_sec);
 
-        cli_ctx_expire(ctx);
-        kill_ctx_kr(ctx);
+       cli_ctx_expire(ctx);
+       kill_ctx_kr(ctx);
 }
 
 /****************************************
@@ -1077,11 +1162,11 @@ void gss_cli_ctx_die_kr(struct ptlrpc_cli_ctx *ctx, int grace)
 
 static
 int sec_install_rctx_kr(struct ptlrpc_sec *sec,
-                        struct ptlrpc_svc_ctx *svc_ctx)
+                       struct ptlrpc_svc_ctx *svc_ctx)
 {
-        struct ptlrpc_cli_ctx   *cli_ctx;
-        struct vfs_cred          vcred = { 0, 0 };
-        int                      rc;
+       struct ptlrpc_cli_ctx *cli_ctx;
+       struct vfs_cred vcred = { .vc_uid = 0 };
+       int rc;
 
         LASSERT(sec);
         LASSERT(svc_ctx);
@@ -1109,13 +1194,13 @@ int sec_install_rctx_kr(struct ptlrpc_sec *sec,
 
 static
 int sec_install_rctx_kr(struct ptlrpc_sec *sec,
-                        struct ptlrpc_svc_ctx *svc_ctx)
+                       struct ptlrpc_svc_ctx *svc_ctx)
 {
-        struct ptlrpc_cli_ctx   *cli_ctx = NULL;
-        struct key              *key;
-        struct vfs_cred          vcred = { 0, 0 };
-        char                     desc[64];
-        int                      rc;
+       struct ptlrpc_cli_ctx *cli_ctx = NULL;
+       struct key *key;
+       struct vfs_cred vcred = { .vc_uid = 0 };
+       char desc[64];
+       int rc;
 
         LASSERT(sec);
         LASSERT(svc_ctx);
@@ -1138,7 +1223,7 @@ int sec_install_rctx_kr(struct ptlrpc_sec *sec,
 
         down_write(&key->sem);
 
-        LASSERT(key->payload.data == NULL);
+       LASSERT(!key_get_payload(key, 0));
 
         cli_ctx = ctx_create_kr(sec, &vcred);
         if (cli_ctx == NULL) {
@@ -1205,17 +1290,24 @@ int gss_svc_install_rctx_kr(struct obd_import *imp,
  ****************************************/
 
 static
+#ifdef HAVE_KEY_TYPE_INSTANTIATE_2ARGS
+int gss_kt_instantiate(struct key *key, struct key_preparsed_payload *prep)
+{
+       const void     *data = prep->data;
+       size_t          datalen = prep->datalen;
+#else
 int gss_kt_instantiate(struct key *key, const void *data, size_t datalen)
 {
+#endif
         int             rc;
         ENTRY;
 
         if (data != NULL || datalen != 0) {
-                CERROR("invalid: data %p, len "LPSZ"\n", data, datalen);
+                CERROR("invalid: data %p, len %lu\n", data, (long)datalen);
                 RETURN(-EINVAL);
         }
 
-        if (key->payload.data != 0) {
+       if (key_get_payload(key, 0)) {
                 CERROR("key already have payload\n");
                 RETURN(-EINVAL);
         }
@@ -1230,20 +1322,21 @@ int gss_kt_instantiate(struct key *key, const void *data, size_t datalen)
          * the session keyring is created upon upcall, and don't change all
          * the way until upcall finished, so rcu lock is not needed here.
          */
-        LASSERT(cfs_current()->signal->session_keyring);
-
-        lockdep_off();
-        rc = key_link(cfs_current()->signal->session_keyring, key);
-        lockdep_on();
-        if (unlikely(rc)) {
-                CERROR("failed to link key %08x to keyring %08x: %d\n",
-                       key->serial,
-                       cfs_current()->signal->session_keyring->serial, rc);
-                RETURN(rc);
-        }
-
-        CDEBUG(D_SEC, "key %p instantiated, ctx %p\n", key, key->payload.data);
-        RETURN(0);
+       LASSERT(key_tgcred(current)->session_keyring);
+
+       lockdep_off();
+       rc = key_link(key_tgcred(current)->session_keyring, key);
+       lockdep_on();
+       if (unlikely(rc)) {
+               CERROR("failed to link key %08x to keyring %08x: %d\n",
+                      key->serial,
+                      key_tgcred(current)->session_keyring->serial, rc);
+               RETURN(rc);
+       }
+
+       CDEBUG(D_SEC, "key %p instantiated, ctx %p\n", key,
+              key_get_payload(key, 0));
+       RETURN(0);
 }
 
 /*
@@ -1251,19 +1344,26 @@ int gss_kt_instantiate(struct key *key, const void *data, size_t datalen)
  * on the context without fear of loosing refcount.
  */
 static
+#ifdef HAVE_KEY_TYPE_INSTANTIATE_2ARGS
+int gss_kt_update(struct key *key, struct key_preparsed_payload *prep)
+{
+       const void              *data = prep->data;
+       __u32                    datalen32 = (__u32) prep->datalen;
+#else
 int gss_kt_update(struct key *key, const void *data, size_t datalen)
 {
-        struct ptlrpc_cli_ctx   *ctx = key->payload.data;
+       __u32                    datalen32 = (__u32) datalen;
+#endif
+       struct ptlrpc_cli_ctx *ctx = key_get_payload(key, 0);
         struct gss_cli_ctx      *gctx;
         rawobj_t                 tmpobj = RAWOBJ_EMPTY;
-        __u32                    datalen32 = (__u32) datalen;
         int                      rc;
         ENTRY;
 
-        if (data == NULL || datalen == 0) {
-                CWARN("invalid: data %p, len "LPSZ"\n", data, datalen);
-                RETURN(-EINVAL);
-        }
+       if (data == NULL || datalen32 == 0) {
+               CWARN("invalid: data %p, len %lu\n", data, (long)datalen32);
+               RETURN(-EINVAL);
+       }
 
         /* if upcall finished negotiation too fast (mostly likely because
          * of local error happened) and call kt_update(), the ctx
@@ -1281,15 +1381,14 @@ int gss_kt_update(struct key *key, const void *data, size_t datalen)
                         RETURN(rc);
         }
 
-        LASSERT(atomic_read(&ctx->cc_refcount) > 0);
-        LASSERT(ctx->cc_sec);
+       LASSERT(atomic_read(&ctx->cc_refcount) > 0);
+       LASSERT(ctx->cc_sec);
 
-        ctx_clear_timer_kr(ctx);
+       ctx_clear_timer_kr(ctx);
 
         /* don't proceed if already refreshed */
         if (cli_ctx_is_refreshed(ctx)) {
                 CWARN("ctx already done refresh\n");
-                sptlrpc_cli_ctx_wakeup(ctx);
                 RETURN(0);
         }
 
@@ -1303,49 +1402,50 @@ int gss_kt_update(struct key *key, const void *data, size_t datalen)
                 goto out;
         }
 
-        if (gctx->gc_win == 0) {
-                __u32   nego_rpc_err, nego_gss_err;
-
-                rc = buffer_extract_bytes(&data, &datalen32, &nego_rpc_err,
-                                          sizeof(nego_rpc_err));
-                if (rc) {
-                        CERROR("failed to extrace rpc rc\n");
-                        goto out;
-                }
-
-                rc = buffer_extract_bytes(&data, &datalen32, &nego_gss_err,
-                                          sizeof(nego_gss_err));
-                if (rc) {
-                        CERROR("failed to extrace gss rc\n");
-                        goto out;
-                }
-
-                CERROR("negotiation: rpc err %d, gss err %x\n",
-                       nego_rpc_err, nego_gss_err);
-
-                rc = nego_rpc_err ? nego_rpc_err : -EACCES;
-        } else {
-                rc = rawobj_extract_local_alloc(&gctx->gc_handle,
-                                                (__u32 **) &data, &datalen32);
-                if (rc) {
-                        CERROR("failed extract handle\n");
-                        goto out;
-                }
-
-                rc = rawobj_extract_local(&tmpobj, (__u32 **) &data,&datalen32);
-                if (rc) {
-                        CERROR("failed extract mech\n");
-                        goto out;
-                }
-
-                rc = lgss_import_sec_context(&tmpobj,
-                                             sec2gsec(ctx->cc_sec)->gs_mech,
-                                             &gctx->gc_mechctx);
-                if (rc != GSS_S_COMPLETE)
-                        CERROR("failed import context\n");
-                else
-                        rc = 0;
-        }
+       if (gctx->gc_win == 0) {
+               __u32   nego_rpc_err, nego_gss_err;
+
+               rc = buffer_extract_bytes(&data, &datalen32, &nego_rpc_err,
+                                         sizeof(nego_rpc_err));
+               if (rc) {
+                       CERROR("cannot extract RPC: rc = %d\n", rc);
+                       goto out;
+               }
+
+               rc = buffer_extract_bytes(&data, &datalen32, &nego_gss_err,
+                                         sizeof(nego_gss_err));
+               if (rc) {
+                       CERROR("failed to extract gss rc = %d\n", rc);
+                       goto out;
+               }
+
+               CERROR("negotiation: rpc err %d, gss err %x\n",
+                      nego_rpc_err, nego_gss_err);
+
+               rc = nego_rpc_err ? nego_rpc_err : -EACCES;
+       } else {
+               rc = rawobj_extract_local_alloc(&gctx->gc_handle,
+                                               (__u32 **) &data, &datalen32);
+               if (rc) {
+                       CERROR("failed extract handle\n");
+                       goto out;
+               }
+
+               rc = rawobj_extract_local(&tmpobj,
+                                         (__u32 **) &data, &datalen32);
+               if (rc) {
+                       CERROR("failed extract mech\n");
+                       goto out;
+               }
+
+               rc = lgss_import_sec_context(&tmpobj,
+                                            sec2gsec(ctx->cc_sec)->gs_mech,
+                                            &gctx->gc_mechctx);
+               if (rc != GSS_S_COMPLETE)
+                       CERROR("failed import context\n");
+               else
+                       rc = 0;
+       }
 out:
         /* we don't care what current status of this ctx, even someone else
          * is operating on the ctx at the same time. we just add up our own
@@ -1360,27 +1460,47 @@ out:
                 cli_ctx_expire(ctx);
 
                 if (rc != -ERESTART)
-                        set_bit(PTLRPC_CTX_ERROR_BIT, &ctx->cc_flags);
+                       set_bit(PTLRPC_CTX_ERROR_BIT, &ctx->cc_flags);
         }
 
-        sptlrpc_cli_ctx_wakeup(ctx);
-
         /* let user space think it's a success */
         sptlrpc_cli_ctx_put(ctx, 1);
         RETURN(0);
 }
 
-static
-int gss_kt_match(const struct key *key, const void *desc)
+#ifndef HAVE_KEY_MATCH_DATA
+static int
+gss_kt_match(const struct key *key, const void *desc)
 {
-        return (strcmp(key->description, (const char *) desc) == 0);
+       return strcmp(key->description, (const char *) desc) == 0 &&
+               !test_bit(KEY_FLAG_REVOKED, &key->flags);
 }
+#else /* ! HAVE_KEY_MATCH_DATA */
+static bool
+gss_kt_match(const struct key *key, const struct key_match_data *match_data)
+{
+       const char *desc = match_data->raw_data;
+
+       return strcmp(key->description, desc) == 0 &&
+               !test_bit(KEY_FLAG_REVOKED, &key->flags);
+}
+
+/*
+ * Preparse the match criterion.
+ */
+static int gss_kt_match_preparse(struct key_match_data *match_data)
+{
+       match_data->lookup_type = KEYRING_SEARCH_LOOKUP_DIRECT;
+       match_data->cmp = gss_kt_match;
+       return 0;
+}
+#endif /* HAVE_KEY_MATCH_DATA */
 
 static
 void gss_kt_destroy(struct key *key)
 {
         ENTRY;
-        LASSERT(key->payload.data == NULL);
+       LASSERT(!key_get_payload(key, 0));
         CDEBUG(D_SEC, "destroy key %p\n", key);
         EXIT;
 }
@@ -1396,13 +1516,17 @@ void gss_kt_describe(const struct key *key, struct seq_file *s)
 
 static struct key_type gss_key_type =
 {
-        .name           = "lgssc",
-        .def_datalen    = 0,
-        .instantiate    = gss_kt_instantiate,
-        .update         = gss_kt_update,
-        .match          = gss_kt_match,
-        .destroy        = gss_kt_destroy,
-        .describe       = gss_kt_describe,
+       .name           = "lgssc",
+       .def_datalen    = 0,
+       .instantiate    = gss_kt_instantiate,
+       .update         = gss_kt_update,
+#ifdef HAVE_KEY_MATCH_DATA
+       .match_preparse = gss_kt_match_preparse,
+#else
+       .match          = gss_kt_match,
+#endif
+       .destroy        = gss_kt_destroy,
+       .describe       = gss_kt_describe,
 };
 
 /****************************************