Whamcloud - gitweb
LU-8130 ptlrpc: convert conn_hash to rhashtable
[fs/lustre-release.git] / lustre / ptlrpc / connection.c
index 2b9fa8d..62db6aa 100644 (file)
@@ -1,6 +1,4 @@
-/* -*- mode: c; c-basic-offset: 8; indent-tabs-mode: nil; -*-
- * vim:expandtab:shiftwidth=8:tabstop=8:
- *
+/*
  * GPL HEADER START
  *
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * You should have received a copy of the GNU General Public License
  * version 2 along with this program; If not, see
- * http://www.sun.com/software/products/lustre/docs/GPLv2.pdf
- *
- * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
- * CA 95054 USA or visit www.sun.com if you need additional information or
- * have any questions.
+ * http://www.gnu.org/licenses/gpl-2.0.html
  *
  * GPL HEADER END
  */
 /*
- * Copyright  2008 Sun Microsystems, Inc. All rights reserved
+ * Copyright (c) 2002, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
+ *
+ * Copyright (c) 2011, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
  */
 
 #define DEBUG_SUBSYSTEM S_RPC
-#ifdef __KERNEL__
+
+#include <linux/delay.h>
+#include <libcfs/linux/linux-hash.h>
 #include <obd_support.h>
 #include <obd_class.h>
 #include <lustre_net.h>
-#else
-#include <liblustre.h>
-#endif
 
 #include "ptlrpc_internal.h"
-#include <class_hash.h>
 
-static spinlock_t conn_lock;
-static struct list_head conn_list;
-static struct lustre_class_hash_body *conn_hash_body;
-static struct lustre_class_hash_body *conn_unused_hash_body;
+static struct rhashtable conn_hash;
 
-extern struct lustre_hash_operations conn_hash_operations;
+/*
+ * struct lnet_process_id may contain unassigned bytes which might not
+ * be zero, so we cannot just hash and compare bytes.
+ */
 
-void ptlrpc_dump_connection(void *obj, void *data)
+static u32 lnet_process_id_hash(const void *data, u32 len, u32 seed)
 {
-        struct ptlrpc_connection *c = obj;
+       const struct lnet_process_id *lpi = data;
 
-        CERROR("Connection %p/%s has refcount %d (nid=%s->%s)\n",
-                c, c->c_remote_uuid.uuid, atomic_read(&c->c_refcount),
-                libcfs_nid2str(c->c_self),
-                libcfs_nid2str(c->c_peer.nid));
+       seed = cfs_hash_32(seed ^ lpi->pid, 32);
+       seed ^= cfs_hash_64(lpi->nid, 32);
+       return seed;
 }
 
-void ptlrpc_dump_connections(void)
+static int lnet_process_id_cmp(struct rhashtable_compare_arg *arg,
+                              const void *obj)
 {
-        ENTRY;
-
-        lustre_hash_iterate_all(conn_hash_body, ptlrpc_dump_connection, NULL);
+       const struct lnet_process_id *lpi = arg->key;
+       const struct ptlrpc_connection *con = obj;
 
-        EXIT;
+       if (lpi->nid == con->c_peer.nid &&
+           lpi->pid == con->c_peer.pid)
+               return 0;
+       return -ESRCH;
 }
 
-struct ptlrpc_connection*
-ptlrpc_lookup_conn_locked (lnet_process_id_t peer)
+static const struct rhashtable_params conn_hash_params = {
+       .key_len        = 1,    /* actually variable-length */
+       .key_offset     = offsetof(struct ptlrpc_connection, c_peer),
+       .head_offset    = offsetof(struct ptlrpc_connection, c_hash),
+       .hashfn         = lnet_process_id_hash,
+       .obj_cmpfn      = lnet_process_id_cmp,
+};
+
+struct ptlrpc_connection *
+ptlrpc_connection_get(struct lnet_process_id peer, lnet_nid_t self,
+                     struct obd_uuid *uuid)
 {
-        struct ptlrpc_connection *c = NULL;
-        int rc;
-
-        c = lustre_hash_get_object_by_key(conn_hash_body, &peer);
-        if (c != NULL)
-                return c;
-
-        c = lustre_hash_get_object_by_key(conn_unused_hash_body, &peer);
-        if (c != NULL) {
-                lustre_hash_delitem(conn_unused_hash_body, &peer, &c->c_hash);
-                rc = lustre_hash_additem_unique(conn_hash_body, &peer,
-                                                &c->c_hash);
-                if (rc) {
-                        /* can't add - try with new item */
-                        OBD_FREE_PTR(c);
-                        list_del(&c->c_link);
-                        c = NULL;
-                }
-        }
-
-        return c;
+       struct ptlrpc_connection *conn, *conn2;
+       ENTRY;
+
+       peer.nid = LNetPrimaryNID(peer.nid);
+       conn = rhashtable_lookup_fast(&conn_hash, &peer, conn_hash_params);
+       if (conn) {
+               ptlrpc_connection_addref(conn);
+               GOTO(out, conn);
+       }
+
+       OBD_ALLOC_PTR(conn);
+       if (!conn)
+               RETURN(NULL);
+
+       conn->c_peer = peer;
+       conn->c_self = self;
+       atomic_set(&conn->c_refcount, 1);
+       if (uuid)
+               obd_str2uuid(&conn->c_remote_uuid, uuid->uuid);
+
+       /*
+        * Add the newly created conn to the hash, on key collision we
+        * lost a racing addition and must destroy our newly allocated
+        * connection.  The object which exists in the hash will be
+        * returned,otherwise NULL is returned on success.
+        */
+try_again:
+       conn2 = rhashtable_lookup_get_insert_fast(&conn_hash, &conn->c_hash,
+                                                 conn_hash_params);
+       if (conn2) {
+               /* insertion failed */
+               OBD_FREE_PTR(conn);
+               if (IS_ERR(conn2)) {
+                       /* hash table could be resizing. */
+                       if (PTR_ERR(conn2) == -ENOMEM ||
+                           PTR_ERR(conn2) == -EBUSY) {
+                               msleep(5);
+                               goto try_again;
+                       }
+                       return NULL;
+               }
+               conn = conn2;
+               ptlrpc_connection_addref(conn);
+       }
+       EXIT;
+out:
+       CDEBUG(D_INFO, "conn=%p refcount %d to %s\n",
+              conn, atomic_read(&conn->c_refcount),
+              libcfs_nid2str(conn->c_peer.nid));
+       return conn;
 }
 
-
-struct ptlrpc_connection *ptlrpc_get_connection(lnet_process_id_t peer,
-                                                lnet_nid_t self, struct obd_uuid *uuid)
+int ptlrpc_connection_put(struct ptlrpc_connection *conn)
 {
-        struct ptlrpc_connection *c;
-        struct ptlrpc_connection *c2;
-        int rc = 0;
-        ENTRY;
-
-        CDEBUG(D_INFO, "self %s peer %s\n", 
-               libcfs_nid2str(self), libcfs_id2str(peer));
-
-        spin_lock(&conn_lock);
-        c = ptlrpc_lookup_conn_locked(peer);
-        spin_unlock(&conn_lock);
-
-        if (c != NULL)
-                RETURN (c);
-
-        OBD_ALLOC_PTR(c);
-        if (c == NULL)
-                RETURN (NULL);
-
-        atomic_set(&c->c_refcount, 1);
-        c->c_peer = peer;
-        c->c_self = self;
-        INIT_HLIST_NODE(&c->c_hash);
-        CFS_INIT_LIST_HEAD(&c->c_link);
-        if (uuid != NULL)
-                obd_str2uuid(&c->c_remote_uuid, uuid->uuid);
-
-        spin_lock(&conn_lock);
-
-        c2 = ptlrpc_lookup_conn_locked(peer);
-        if (c2 == NULL) {
-                rc = lustre_hash_additem_unique(conn_hash_body, &peer, 
-                                                &c->c_hash);
-                if (rc != 0) {
-                        CERROR("Cannot add connection to conn_hash_body\n");
-                        goto out_conn;
-                }
-                list_add(&c->c_link, &conn_list);
-        }
-
-out_conn:
-        spin_unlock(&conn_lock);
-
-        if (c2 == NULL && rc == 0)
-                RETURN (c);
-
-        if (c != NULL) 
-                OBD_FREE(c, sizeof(*c));
-        RETURN (c2);
+       int rc = 0;
+       ENTRY;
+
+       if (!conn)
+               RETURN(rc);
+
+       LASSERT(atomic_read(&conn->c_refcount) > 0);
+
+       /*
+        * We do not remove connection from hashtable and
+        * do not free it even if last caller released ref,
+        * as we want to have it cached for the case it is
+        * needed again.
+        *
+        * Deallocating it and later creating new connection
+        * again would be wastful. This way we also avoid
+        * expensive locking to protect things from get/put
+        * race when found cached connection is freed by
+        * ptlrpc_connection_put().
+        *
+        * It will be freed later in module unload time,
+        * when ptlrpc_connection_fini()->lh_exit->conn_exit()
+        * path is called.
+        */
+       if (atomic_dec_return(&conn->c_refcount) == 0)
+               rc = 1;
+
+       CDEBUG(D_INFO, "PUT conn=%p refcount %d to %s\n",
+              conn, atomic_read(&conn->c_refcount),
+              libcfs_nid2str(conn->c_peer.nid));
+
+       RETURN(rc);
 }
 
-int ptlrpc_put_connection(struct ptlrpc_connection *c)
+struct ptlrpc_connection *
+ptlrpc_connection_addref(struct ptlrpc_connection *conn)
 {
-        int rc = 0;
-        ENTRY;
-
-        if (c == NULL) {
-                CERROR("NULL connection\n");
-                RETURN(0);
-        }
-
-        CDEBUG (D_INFO, "connection=%p refcount %d to %s\n",
-                c, atomic_read(&c->c_refcount) - 1, 
-                libcfs_nid2str(c->c_peer.nid));
-
-        spin_lock(&conn_lock);
-        LASSERT(!hlist_unhashed(&c->c_hash));
-        spin_unlock(&conn_lock);
-
-        if (atomic_dec_return(&c->c_refcount) == 1) {
-
-                spin_lock(&conn_lock);
-                lustre_hash_delitem(conn_hash_body, &c->c_peer, &c->c_hash);
-                rc = lustre_hash_additem_unique(conn_unused_hash_body, &c->c_peer, 
-                                                &c->c_hash);
-                spin_unlock(&conn_lock);
-                if (rc != 0) {
-                        CERROR("Cannot hash connection to conn_hash_body\n");
-                        GOTO(ret, rc);
-                }
-
-                rc = 1;
-        } 
-
-        if (atomic_read(&c->c_refcount) < 0)
-                CERROR("connection %p refcount %d!\n",
-                       c, atomic_read(&c->c_refcount));
-ret :
-
-        RETURN(rc);
+       ENTRY;
+
+       atomic_inc(&conn->c_refcount);
+       CDEBUG(D_INFO, "conn=%p refcount %d to %s\n",
+              conn, atomic_read(&conn->c_refcount),
+              libcfs_nid2str(conn->c_peer.nid));
+
+       RETURN(conn);
 }
 
-struct ptlrpc_connection *ptlrpc_connection_addref(struct ptlrpc_connection *c)
+static void
+conn_exit(void *vconn, void *data)
 {
-        ENTRY;
-        atomic_inc(&c->c_refcount);
-        CDEBUG (D_INFO, "connection=%p refcount %d to %s\n",
-                c, atomic_read(&c->c_refcount),
-                libcfs_nid2str(c->c_peer.nid));
-        RETURN(c);
+       struct ptlrpc_connection *conn = vconn;
+
+       /*
+        * Nothing should be left. Connection user put it and
+        * connection also was deleted from table by this time
+        * so we should have 0 refs.
+        */
+       LASSERTF(atomic_read(&conn->c_refcount) == 0,
+                "Busy connection with %d refs\n",
+                atomic_read(&conn->c_refcount));
+       OBD_FREE_PTR(conn);
 }
 
-int ptlrpc_init_connection(void)
+int ptlrpc_connection_init(void)
 {
-        int rc = 0;
-        CFS_INIT_LIST_HEAD(&conn_list);
-        rc = lustre_hash_init(&conn_hash_body, "CONN_HASH", 
-                              128, &conn_hash_operations);
-        if (rc)
-                GOTO(ret, rc);
-
-        rc = lustre_hash_init(&conn_unused_hash_body, "CONN_UNUSED_HASH", 
-                              128, &conn_hash_operations);
-        if (rc)
-                GOTO(ret, rc);
-
-        spin_lock_init(&conn_lock);
-ret:
-        if (rc) {
-                lustre_hash_exit(&conn_hash_body);
-                lustre_hash_exit(&conn_unused_hash_body);
-        }
-        RETURN(rc);
+       return rhashtable_init(&conn_hash, &conn_hash_params);
 }
 
-void ptlrpc_cleanup_connection(void)
+void ptlrpc_connection_fini(void)
 {
-        struct list_head *tmp, *pos;
-        struct ptlrpc_connection *c;
-
-        spin_lock(&conn_lock);
-
-        lustre_hash_exit(&conn_unused_hash_body);
-        lustre_hash_exit(&conn_hash_body);
-
-        list_for_each_safe(tmp, pos, &conn_list) {
-                c = list_entry(tmp, struct ptlrpc_connection, c_link);
-                if (atomic_read(&c->c_refcount))
-                        CERROR("Connection %p/%s has refcount %d (nid=%s)\n",
-                               c, c->c_remote_uuid.uuid,
-                               atomic_read(&c->c_refcount),
-                               libcfs_nid2str(c->c_peer.nid));
-                list_del(&c->c_link);
-                OBD_FREE(c, sizeof(*c));
-        }
-        spin_unlock(&conn_lock);
+       rhashtable_free_and_destroy(&conn_hash, conn_exit, NULL);
 }