Whamcloud - gitweb
LU-3469 osp: osp_sync() to flush pending changes synchronously
[fs/lustre-release.git] / lustre / osp / osp_dev.c
index d27146d..45aff9f 100644 (file)
@@ -45,6 +45,7 @@
 #define DEBUG_SUBSYSTEM S_MDS
 
 #include <obd_class.h>
+#include <lustre_ioctl.h>
 #include <lustre_param.h>
 #include <lustre_log.h>
 #include <lustre_mdc.h>
@@ -140,7 +141,7 @@ static int osp_write_local_file(const struct lu_env *env,
        if (IS_ERR(th))
                RETURN(PTR_ERR(th));
 
-       rc = dt_declare_record_write(env, dt_obj, buf->lb_len, offset, th);
+       rc = dt_declare_record_write(env, dt_obj, buf, offset, th);
        if (rc)
                GOTO(out, rc);
        rc = dt_trans_start_local(env, osp->opd_storage, th);
@@ -366,7 +367,7 @@ static int osp_process_config(const struct lu_env *env,
                              struct lu_device *dev, struct lustre_cfg *lcfg)
 {
        struct osp_device               *d = lu2osp_dev(dev);
-       struct lprocfs_static_vars       lvars = { 0 };
+       struct obd_device               *obd = d->opd_obd;
        int                              rc;
 
        ENTRY;
@@ -380,11 +381,9 @@ static int osp_process_config(const struct lu_env *env,
                rc = osp_shutdown(env, d);
                break;
        case LCFG_PARAM:
-               lprocfs_osp_init_vars(&lvars);
-
-               LASSERT(d->opd_obd);
-               rc = class_process_proc_param(PARAM_OSC, lvars.obd_vars,
-                                             lcfg, d->opd_obd);
+               LASSERT(obd);
+               rc = class_process_proc_seq_param(PARAM_OSC, obd->obd_vars,
+                                                 lcfg, obd);
                if (rc > 0)
                        rc = 0;
                if (rc == -ENOSYS) {
@@ -472,15 +471,95 @@ static int osp_statfs(const struct lu_env *env, struct dt_device *dev,
        RETURN(0);
 }
 
+static int osp_sync_timeout(void *data)
+{
+       return 1;
+}
+
 static int osp_sync(const struct lu_env *env, struct dt_device *dev)
 {
+       struct osp_device *d = dt2osp_dev(dev);
+       cfs_time_t         expire;
+       struct l_wait_info lwi = { 0 };
+       unsigned long      id, old;
+       int                rc = 0;
+       unsigned long      start = cfs_time_current();
        ENTRY;
 
-       /*
-        * XXX: wake up sync thread, command it to start flushing asap?
-        */
+       if (unlikely(d->opd_imp_active == 0))
+               RETURN(-ENOTCONN);
 
-       RETURN(0);
+       id = d->opd_syn_last_used_id;
+
+       CDEBUG(D_OTHER, "%s: id: used %lu, processed %lu\n",
+              d->opd_obd->obd_name, id, d->opd_syn_last_processed_id);
+
+       /* wait till all-in-line are processed */
+       while (d->opd_syn_last_processed_id < id) {
+
+               old = d->opd_syn_last_processed_id;
+
+               /* make sure the connection is fine */
+               expire = cfs_time_shift(obd_timeout);
+               lwi = LWI_TIMEOUT(expire - cfs_time_current(),
+                                 osp_sync_timeout, d);
+               l_wait_event(d->opd_syn_barrier_waitq,
+                            d->opd_syn_last_processed_id >= id,
+                            &lwi);
+
+               if (d->opd_syn_last_processed_id >= id)
+                       break;
+
+               if (d->opd_syn_last_processed_id != old) {
+                       /* some progress have been made,
+                        * keep trying... */
+                       continue;
+               }
+
+               /* no changes and expired, something is wrong */
+               GOTO(out, rc = -ETIMEDOUT);
+       }
+
+       /* block new processing (barrier>0 - few callers are possible */
+       atomic_inc(&d->opd_syn_barrier);
+
+       CDEBUG(D_OTHER, "%s: %u in flight\n", d->opd_obd->obd_name,
+              d->opd_syn_rpc_in_flight);
+
+       /* wait till all-in-flight are replied, so executed by the target */
+       /* XXX: this is used by LFSCK at the moment, which doesn't require
+        *      all the changes to be committed, but in general it'd be
+        *      better to wait till commit */
+       while (d->opd_syn_rpc_in_flight > 0) {
+
+               old = d->opd_syn_rpc_in_flight;
+
+               expire = cfs_time_shift(obd_timeout);
+               lwi = LWI_TIMEOUT(expire - cfs_time_current(),
+                                 osp_sync_timeout, d);
+               l_wait_event(d->opd_syn_barrier_waitq,
+                               d->opd_syn_rpc_in_flight == 0, &lwi);
+
+               if (d->opd_syn_rpc_in_flight == 0)
+                       break;
+
+               if (d->opd_syn_rpc_in_flight != old) {
+                       /* some progress have been made */
+                       continue;
+               }
+
+               /* no changes and expired, something is wrong */
+               GOTO(out, rc = -ETIMEDOUT);
+       }
+
+       CDEBUG(D_OTHER, "%s: done in %lu\n", d->opd_obd->obd_name,
+              cfs_time_current() - start);
+out:
+       /* resume normal processing (barrier=0) */
+       atomic_dec(&d->opd_syn_barrier);
+       __osp_sync_check_for_work(d);
+
+       RETURN(rc);
 }
 
 const struct dt_device_operations osp_dt_ops = {
@@ -531,8 +610,6 @@ out:
        RETURN(rc);
 }
 
-#define OSP_MAX_AUIF_MAX       512
-
 static int osp_init0(const struct lu_env *env, struct osp_device *m,
                     struct lu_device_type *ldt, struct lustre_cfg *cfg)
 {
@@ -546,8 +623,6 @@ static int osp_init0(const struct lu_env *env, struct osp_device *m,
        ENTRY;
 
        mutex_init(&m->opd_async_requests_mutex);
-       /* We allow OSP_MAX_AUIF_MAX async updates in flight at most. */
-       sema_init(&m->opd_async_fc_sem, OSP_MAX_AUIF_MAX);
 
        obd = class_name2obd(lustre_cfg_string(cfg, 0));
        if (obd == NULL) {
@@ -779,7 +854,7 @@ static struct lu_device *osp_device_free(const struct lu_env *env,
 
        ENTRY;
 
-       if (cfs_atomic_read(&lu->ld_ref) && lu->ld_site) {
+       if (atomic_read(&lu->ld_ref) && lu->ld_site) {
                LIBCFS_DEBUG_MSG_DATA_DECL(msgdata, D_ERROR, NULL);
                lu_site_print(env, lu->ld_site, &msgdata, lu_cdebug_printer);
        }
@@ -1161,14 +1236,20 @@ static int osp_obd_get_info(const struct lu_env *env, struct obd_export *exp,
        RETURN(rc);
 }
 
-int osp_fid_alloc(struct obd_export *exp, struct lu_fid *fid,
-                 struct md_op_data *op_data)
+int osp_fid_alloc(const struct lu_env *env, struct obd_export *exp,
+                 struct lu_fid *fid, struct md_op_data *op_data)
 {
-       struct client_obd *cli = &exp->exp_obd->u.cli;
-       struct lu_client_seq *seq = cli->cl_seq;
-
+       struct client_obd       *cli = &exp->exp_obd->u.cli;
+       struct osp_device       *osp = lu2osp_dev(exp->exp_obd->obd_lu_dev);
+       struct lu_client_seq    *seq = cli->cl_seq;
        ENTRY;
-       RETURN(seq_client_alloc_fid(NULL, seq, fid));
+
+       LASSERT(osp->opd_obd->u.cli.cl_seq != NULL);
+       /* Sigh, fid client is not ready yet */
+       if (osp->opd_obd->u.cli.cl_seq->lcs_exp == NULL)
+               RETURN(-ENOTCONN);
+
+       RETURN(seq_client_alloc_fid(env, seq, fid));
 }
 
 /* context key constructor/destructor: mdt_key_init, mdt_key_fini */
@@ -1238,35 +1319,29 @@ struct llog_operations osp_mds_ost_orig_logops;
 
 static int __init osp_mod_init(void)
 {
-       struct lprocfs_static_vars       lvars;
-       cfs_proc_dir_entry_t            *osc_proc_dir;
-       int                              rc;
+       struct obd_type *type;
+       int rc;
 
        rc = lu_kmem_init(osp_caches);
        if (rc)
                return rc;
 
-       lprocfs_osp_init_vars(&lvars);
 
-       rc = class_register_type(&osp_obd_device_ops, NULL, NULL,
+       rc = class_register_type(&osp_obd_device_ops, NULL, true, NULL,
 #ifndef HAVE_ONLY_PROCFS_SEQ
-                               lvars.module_vars,
+                                NULL,
 #endif
-                               LUSTRE_OSP_NAME, &osp_device_type);
-
-       /* create "osc" entry in procfs for compatibility purposes */
+                                LUSTRE_OSP_NAME, &osp_device_type);
        if (rc != 0) {
                lu_kmem_fini(osp_caches);
                return rc;
        }
 
-       lprocfs_lwp_init_vars(&lvars);
-
-       rc = class_register_type(&lwp_obd_device_ops, NULL, NULL,
+       rc = class_register_type(&lwp_obd_device_ops, NULL, true, NULL,
 #ifndef HAVE_ONLY_PROCFS_SEQ
-                               lvars.module_vars,
+                                NULL,
 #endif
-                               LUSTRE_LWP_NAME, &lwp_device_type);
+                                LUSTRE_LWP_NAME, &lwp_device_type);
        if (rc != 0) {
                class_unregister_type(LUSTRE_OSP_NAME);
                lu_kmem_fini(osp_caches);
@@ -1278,21 +1353,24 @@ static int __init osp_mod_init(void)
        osp_mds_ost_orig_logops.lop_add = llog_cat_add_rec;
        osp_mds_ost_orig_logops.lop_declare_add = llog_cat_declare_add_rec;
 
-       osc_proc_dir = lprocfs_srch(proc_lustre_root, "osc");
-       if (osc_proc_dir == NULL) {
-               osc_proc_dir = lprocfs_register("osc", proc_lustre_root, NULL,
-                                               NULL);
-               if (IS_ERR(osc_proc_dir))
-                       CERROR("osp: can't create compat entry \"osc\": %d\n",
-                              (int) PTR_ERR(osc_proc_dir));
+       /* create "osc" entry in procfs for compatibility purposes */
+       type = class_search_type(LUSTRE_OSC_NAME);
+       if (type != NULL && type->typ_procroot != NULL)
+               return rc;
+
+       type = class_search_type(LUSTRE_OSP_NAME);
+       type->typ_procsym = lprocfs_seq_register("osc", proc_lustre_root,
+                                                NULL, NULL);
+       if (IS_ERR(type->typ_procsym)) {
+               CERROR("osp: can't create compat entry \"osc\": %d\n",
+                      (int) PTR_ERR(type->typ_procsym));
+               type->typ_procsym = NULL;
        }
        return rc;
 }
 
 static void __exit osp_mod_exit(void)
 {
-       lprocfs_try_remove_proc_entry("osc", proc_lustre_root);
-
        class_unregister_type(LUSTRE_LWP_NAME);
        class_unregister_type(LUSTRE_OSP_NAME);
        lu_kmem_fini(osp_caches);