static void
osd_object_sa_dirty_add(struct osd_object *obj, struct osd_thandle *oh)
{
- if (!cfs_list_empty(&obj->oo_sa_linkage))
+ if (!list_empty(&obj->oo_sa_linkage))
return;
down(&oh->ot_sa_lock);
write_lock(&obj->oo_attr_lock);
- if (likely(cfs_list_empty(&obj->oo_sa_linkage)))
- cfs_list_add(&obj->oo_sa_linkage, &oh->ot_sa_list);
+ if (likely(list_empty(&obj->oo_sa_linkage)))
+ list_add(&obj->oo_sa_linkage, &oh->ot_sa_list);
write_unlock(&obj->oo_attr_lock);
up(&oh->ot_sa_lock);
}
struct osd_object *obj;
down(&oh->ot_sa_lock);
- while (!cfs_list_empty(&oh->ot_sa_list)) {
- obj = cfs_list_entry(oh->ot_sa_list.next,
+ while (!list_empty(&oh->ot_sa_list)) {
+ obj = list_entry(oh->ot_sa_list.next,
struct osd_object, oo_sa_linkage);
sa_spill_rele(obj->oo_sa_hdl);
write_lock(&obj->oo_attr_lock);
- cfs_list_del_init(&obj->oo_sa_linkage);
+ list_del_init(&obj->oo_sa_linkage);
write_unlock(&obj->oo_attr_lock);
}
up(&oh->ot_sa_lock);
dt_object_init(&mo->oo_dt, NULL, d);
mo->oo_dt.do_ops = &osd_obj_ops;
l->lo_ops = &osd_lu_obj_ops;
- CFS_INIT_LIST_HEAD(&mo->oo_sa_linkage);
+ INIT_LIST_HEAD(&mo->oo_sa_linkage);
init_rwsem(&mo->oo_sem);
sema_init(&mo->oo_guard, 1);
rwlock_init(&mo->oo_attr_lock);
GOTO(out, rc);
}
- /* do object accounting */
- osd_zfs_acct_uid(env, osd, obj->oo_attr.la_uid, -1, oh);
- osd_zfs_acct_gid(env, osd, obj->oo_attr.la_gid, -1, oh);
+ /* Remove object from inode accounting. It is not fatal for the destroy
+ * operation if something goes wrong while updating accounting, but we
+ * still log an error message to notify the administrator */
+ rc = -zap_increment_int(osd->od_objset.os, osd->od_iusr_oid,
+ obj->oo_attr.la_uid, -1, oh->ot_tx);
+ if (rc)
+ CERROR("%s: failed to remove "DFID" from accounting ZAP for usr"
+ " %d: rc = %d\n", osd->od_svname, PFID(fid),
+ obj->oo_attr.la_uid, rc);
+ rc = -zap_increment_int(osd->od_objset.os, osd->od_igrp_oid,
+ obj->oo_attr.la_gid, -1, oh->ot_tx);
+ if (rc)
+ CERROR("%s: failed to remove "DFID" from accounting ZAP for grp"
+ " %d: rc = %d\n", osd->od_svname, PFID(fid),
+ obj->oo_attr.la_gid, rc);
/* kill object */
rc = __osd_object_destroy(env, obj, oh->ot_tx, osd_obj_tag);
obj->oo_sa_xattr = NULL;
}
sa_buf_rele(obj->oo_db, osd_obj_tag);
- cfs_list_del(&obj->oo_sa_linkage);
+ list_del(&obj->oo_sa_linkage);
obj->oo_db = NULL;
}
}
struct osd_thandle *oh;
struct osa_attr *osa = &osd_oti_get(env)->oti_osa;
sa_bulk_attr_t *bulk;
+ __u64 valid = la->la_valid;
int cnt;
int rc = 0;
transaction group. */
LASSERT(oh->ot_tx->tx_txg != 0);
- if (la->la_valid == 0)
+ /* Only allow set size for regular file */
+ if (!S_ISREG(dt->do_lu.lo_header->loh_attr))
+ valid &= ~(LA_SIZE | LA_BLOCKS);
+
+ if (valid == 0)
RETURN(0);
OBD_ALLOC(bulk, sizeof(sa_bulk_attr_t) * 10);
RETURN(-ENOMEM);
/* do both accounting updates outside oo_attr_lock below */
- if ((la->la_valid & LA_UID) && (la->la_uid != obj->oo_attr.la_uid)) {
- /* do object accounting */
- osd_zfs_acct_uid(env, osd, la->la_uid, 1, oh);
- osd_zfs_acct_uid(env, osd, obj->oo_attr.la_uid, -1, oh);
+ if ((valid & LA_UID) && (la->la_uid != obj->oo_attr.la_uid)) {
+ /* Update user accounting. Failure isn't fatal, but we still
+ * log an error message */
+ rc = -zap_increment_int(osd->od_objset.os, osd->od_iusr_oid,
+ la->la_uid, 1, oh->ot_tx);
+ if (rc)
+ CERROR("%s: failed to update accounting ZAP for user "
+ "%d (%d)\n", osd->od_svname, la->la_uid, rc);
+ rc = -zap_increment_int(osd->od_objset.os, osd->od_iusr_oid,
+ obj->oo_attr.la_uid, -1, oh->ot_tx);
+ if (rc)
+ CERROR("%s: failed to update accounting ZAP for user "
+ "%d (%d)\n", osd->od_svname,
+ obj->oo_attr.la_uid, rc);
}
- if ((la->la_valid & LA_GID) && (la->la_gid != obj->oo_attr.la_gid)) {
- /* do object accounting */
- osd_zfs_acct_gid(env, osd, la->la_gid, 1, oh);
- osd_zfs_acct_gid(env, osd, obj->oo_attr.la_gid, -1, oh);
+ if ((valid & LA_GID) && (la->la_gid != obj->oo_attr.la_gid)) {
+ /* Update group accounting. Failure isn't fatal, but we still
+ * log an error message */
+ rc = -zap_increment_int(osd->od_objset.os, osd->od_igrp_oid,
+ la->la_gid, 1, oh->ot_tx);
+ if (rc)
+ CERROR("%s: failed to update accounting ZAP for user "
+ "%d (%d)\n", osd->od_svname, la->la_gid, rc);
+ rc = -zap_increment_int(osd->od_objset.os, osd->od_igrp_oid,
+ obj->oo_attr.la_gid, -1, oh->ot_tx);
+ if (rc)
+ CERROR("%s: failed to update accounting ZAP for user "
+ "%d (%d)\n", osd->od_svname,
+ obj->oo_attr.la_gid, rc);
}
write_lock(&obj->oo_attr_lock);
cnt = 0;
- if (la->la_valid & LA_ATIME) {
+ if (valid & LA_ATIME) {
osa->atime[0] = obj->oo_attr.la_atime = la->la_atime;
SA_ADD_BULK_ATTR(bulk, cnt, SA_ZPL_ATIME(uos), NULL,
osa->atime, 16);
}
- if (la->la_valid & LA_MTIME) {
+ if (valid & LA_MTIME) {
osa->mtime[0] = obj->oo_attr.la_mtime = la->la_mtime;
SA_ADD_BULK_ATTR(bulk, cnt, SA_ZPL_MTIME(uos), NULL,
osa->mtime, 16);
}
- if (la->la_valid & LA_CTIME) {
+ if (valid & LA_CTIME) {
osa->ctime[0] = obj->oo_attr.la_ctime = la->la_ctime;
SA_ADD_BULK_ATTR(bulk, cnt, SA_ZPL_CTIME(uos), NULL,
osa->ctime, 16);
}
- if (la->la_valid & LA_MODE) {
+ if (valid & LA_MODE) {
/* mode is stored along with type, so read it first */
obj->oo_attr.la_mode = (obj->oo_attr.la_mode & S_IFMT) |
(la->la_mode & ~S_IFMT);
SA_ADD_BULK_ATTR(bulk, cnt, SA_ZPL_MODE(uos), NULL,
&osa->mode, 8);
}
- if (la->la_valid & LA_SIZE) {
+ if (valid & LA_SIZE) {
osa->size = obj->oo_attr.la_size = la->la_size;
SA_ADD_BULK_ATTR(bulk, cnt, SA_ZPL_SIZE(uos), NULL,
&osa->size, 8);
}
- if (la->la_valid & LA_NLINK) {
+ if (valid & LA_NLINK) {
osa->nlink = obj->oo_attr.la_nlink = la->la_nlink;
SA_ADD_BULK_ATTR(bulk, cnt, SA_ZPL_LINKS(uos), NULL,
&osa->nlink, 8);
}
- if (la->la_valid & LA_RDEV) {
+ if (valid & LA_RDEV) {
osa->rdev = obj->oo_attr.la_rdev = la->la_rdev;
SA_ADD_BULK_ATTR(bulk, cnt, SA_ZPL_RDEV(uos), NULL,
&osa->rdev, 8);
}
- if (la->la_valid & LA_FLAGS) {
+ if (valid & LA_FLAGS) {
osa->flags = attrs_fs2zfs(la->la_flags);
/* many flags are not supported by zfs, so ensure a good cached
* copy */
SA_ADD_BULK_ATTR(bulk, cnt, SA_ZPL_FLAGS(uos), NULL,
&osa->flags, 8);
}
- if (la->la_valid & LA_UID) {
+ if (valid & LA_UID) {
osa->uid = obj->oo_attr.la_uid = la->la_uid;
SA_ADD_BULK_ATTR(bulk, cnt, SA_ZPL_UID(uos), NULL,
&osa->uid, 8);
}
- if (la->la_valid & LA_GID) {
+ if (valid & LA_GID) {
osa->gid = obj->oo_attr.la_gid = la->la_gid;
SA_ADD_BULK_ATTR(bulk, cnt, SA_ZPL_GID(uos), NULL,
&osa->gid, 8);
}
- obj->oo_attr.la_valid |= la->la_valid;
+ obj->oo_attr.la_valid |= valid;
write_unlock(&obj->oo_attr_lock);
rc = osd_object_sa_bulk_update(obj, bulk, cnt, oh);
int rc;
LASSERT(tag);
- spin_lock(&uos->lock);
- uos->objects++;
- spin_unlock(&uos->lock);
-
/* Assert that the transaction has been assigned to a
transaction group. */
LASSERT(tx->tx_txg != 0);
oid = dmu_object_alloc(uos->os, DMU_OT_PLAIN_FILE_CONTENTS, 0,
DMU_OT_SA, DN_MAX_BONUSLEN, tx);
rc = -sa_buf_hold(uos->os, oid, tag, dbp);
- if (rc)
- return rc;
+ LASSERTF(rc == 0, "sa_buf_hold "LPU64" failed: %d\n", oid, rc);
LASSERT(la->la_valid & LA_MODE);
la->la_size = 0;
la->la_nlink = 1;
- return __osd_attr_init(env, uos, oid, tx, la, parent);
+ rc = __osd_attr_init(env, uos, oid, tx, la, parent);
+ if (rc != 0) {
+ sa_buf_rele(*dbp, tag);
+ *dbp = NULL;
+ dmu_object_free(uos->os, oid, tx);
+ return rc;
+ }
+
+ spin_lock(&uos->lock);
+ uos->objects++;
+ spin_unlock(&uos->lock);
+ return 0;
}
/*
/* Add new object to inode accounting.
* Errors are not considered as fatal */
- /* XXX: UID/GID must be defined otherwise we can break accounting */
- osd_zfs_acct_uid(env, osd, attr->la_uid, 1, oh);
- osd_zfs_acct_gid(env, osd, attr->la_gid, 1, oh);
+ rc = -zap_increment_int(osd->od_objset.os, osd->od_iusr_oid,
+ (attr->la_valid & LA_UID) ? attr->la_uid : 0, 1,
+ oh->ot_tx);
+ if (rc)
+ CERROR("%s: failed to add "DFID" to accounting ZAP for usr %d "
+ "(%d)\n", osd->od_svname, PFID(fid), attr->la_uid, rc);
+ rc = -zap_increment_int(osd->od_objset.os, osd->od_igrp_oid,
+ (attr->la_valid & LA_GID) ? attr->la_gid : 0, 1,
+ oh->ot_tx);
+ if (rc)
+ CERROR("%s: failed to add "DFID" to accounting ZAP for grp %d "
+ "(%d)\n", osd->od_svname, PFID(fid), attr->la_gid, rc);
/* configure new osd object */
obj->oo_db = db;
git://git.whamcloud.com / fs / lustre-release.git / blobdiff