Whamcloud - gitweb
LU-4927 scrub: rebuild stale OST OI mapping
[fs/lustre-release.git] / lustre / osd-ldiskfs / osd_scrub.c
index 6be982c..d830e22 100644 (file)
 #include <lustre/lustre_idl.h>
 #include <lustre_disk.h>
 #include <dt_object.h>
+#include <linux/xattr.h>
 
 #include "osd_internal.h"
 #include "osd_oi.h"
 #include "osd_scrub.h"
 
-#define HALF_SEC       (CFS_HZ >> 1)
+#define HALF_SEC       (HZ >> 1)
 
 #define OSD_OTABLE_MAX_HASH            0x00000000ffffffffULL
 
@@ -90,29 +91,29 @@ static int osd_scrub_refresh_mapping(struct osd_thread_info *info,
                                     struct osd_device *dev,
                                     const struct lu_fid *fid,
                                     const struct osd_inode_id *id,
-                                    int ops, enum oi_check_flags flags)
+                                    int ops, bool force,
+                                    enum oi_check_flags flags)
 {
-       const struct lu_env *env = info->oti_env;
-       struct thandle      *th;
-       struct osd_thandle  *oh;
-       int                  rc;
+       handle_t *th;
+       int       rc;
        ENTRY;
 
-       th = dt_trans_create(env, &dev->od_dt_dev);
-       if (IS_ERR(th))
-               RETURN(PTR_ERR(th));
+       if (dev->od_scrub.os_file.sf_param & SP_DRYRUN && !force)
+               RETURN(0);
 
-       oh = container_of0(th, struct osd_thandle, ot_super);
-       LASSERT(oh->ot_handle == NULL);
+       /* DTO_INDEX_INSERT is enough for other two ops:
+        * delete/update, but save stack. */
+       th = ldiskfs_journal_start_sb(osd_sb(dev),
+                               osd_dto_credits_noquota[DTO_INDEX_INSERT]);
+       if (IS_ERR(th)) {
+               rc = PTR_ERR(th);
+               CERROR("%s: fail to start trans for scrub %d: rc = %d\n",
+                      osd_name(dev), ops, rc);
+               RETURN(rc);
+       }
 
        switch (ops) {
        case DTO_INDEX_UPDATE:
-               osd_trans_declare_op(env, oh, OSD_OT_UPDATE,
-                                    osd_dto_credits_noquota[DTO_INDEX_UPDATE]);
-               rc = dt_trans_start_local(env, &dev->od_dt_dev, th);
-               if (rc != 0)
-                       GOTO(stop, rc);
-
                rc = osd_oi_update(info, dev, fid, id, th, flags);
                if (unlikely(rc == -ENOENT)) {
                        /* Some unlink thread may removed the OI mapping. */
@@ -120,12 +121,6 @@ static int osd_scrub_refresh_mapping(struct osd_thread_info *info,
                }
                break;
        case DTO_INDEX_INSERT:
-               osd_trans_declare_op(env, oh, OSD_OT_INSERT,
-                                    osd_dto_credits_noquota[DTO_INDEX_INSERT]);
-               rc = dt_trans_start_local(env, &dev->od_dt_dev, th);
-               if (rc != 0)
-                       GOTO(stop, rc);
-
                rc = osd_oi_insert(info, dev, fid, id, th, flags);
                if (unlikely(rc == -EEXIST)) {
                        rc = 1;
@@ -163,12 +158,6 @@ static int osd_scrub_refresh_mapping(struct osd_thread_info *info,
                }
                break;
        case DTO_INDEX_DELETE:
-               osd_trans_declare_op(env, oh, OSD_OT_DELETE,
-                                    osd_dto_credits_noquota[DTO_INDEX_DELETE]);
-               rc = dt_trans_start_local(env, &dev->od_dt_dev, th);
-               if (rc != 0)
-                       GOTO(stop, rc);
-
                rc = osd_oi_delete(info, dev, fid, th, flags);
                if (rc == -ENOENT) {
                        /* It is normal that the unlink thread has removed the
@@ -181,10 +170,7 @@ static int osd_scrub_refresh_mapping(struct osd_thread_info *info,
                break;
        }
 
-       GOTO(stop, rc);
-
-stop:
-       dt_trans_stop(env, &dev->od_dt_dev, th);
+       ldiskfs_journal_stop(th);
        return rc;
 }
 
@@ -221,6 +207,7 @@ static void osd_scrub_file_to_cpu(struct scrub_file *des,
        des->sf_run_time        = le32_to_cpu(src->sf_run_time);
        des->sf_success_count   = le32_to_cpu(src->sf_success_count);
        des->sf_oi_count        = le16_to_cpu(src->sf_oi_count);
+       des->sf_internal_flags  = le16_to_cpu(src->sf_internal_flags);
        memcpy(des->sf_oi_bitmap, src->sf_oi_bitmap, SCRUB_OI_BITMAP_SIZE);
 }
 
@@ -255,6 +242,7 @@ static void osd_scrub_file_to_le(struct scrub_file *des,
        des->sf_run_time        = cpu_to_le32(src->sf_run_time);
        des->sf_success_count   = cpu_to_le32(src->sf_success_count);
        des->sf_oi_count        = cpu_to_le16(src->sf_oi_count);
+       des->sf_internal_flags  = cpu_to_le16(src->sf_internal_flags);
        memcpy(des->sf_oi_bitmap, src->sf_oi_bitmap, SCRUB_OI_BITMAP_SIZE);
 }
 
@@ -276,7 +264,6 @@ void osd_scrub_file_reset(struct osd_scrub *scrub, __u8 *uuid, __u64 flags)
        memcpy(sf->sf_uuid, uuid, 16);
        sf->sf_status = SS_INIT;
        sf->sf_flags |= flags;
-       sf->sf_param = 0;
        sf->sf_run_time = 0;
        sf->sf_time_latest_start = 0;
        sf->sf_time_last_checkpoint = 0;
@@ -336,7 +323,7 @@ int osd_scrub_file_store(struct osd_scrub *scrub)
        dev = container_of0(scrub, struct osd_device, od_scrub);
        credits = osd_dto_credits_noquota[DTO_WRITE_BASE] +
                  osd_dto_credits_noquota[DTO_WRITE_BLOCK];
-       jh = ldiskfs_journal_start_sb(osd_sb(dev), credits);
+       jh = osd_journal_start_sb(osd_sb(dev), LDISKFS_HT_MISC, credits);
        if (IS_ERR(jh)) {
                rc = PTR_ERR(jh);
                CERROR("%.16s: fail to start trans for scrub store, rc = %d\n",
@@ -359,61 +346,81 @@ int osd_scrub_file_store(struct osd_scrub *scrub)
        return rc;
 }
 
-/* OI scrub APIs */
-
-static int osd_scrub_prep(struct osd_device *dev)
+static int
+osd_scrub_convert_ff(struct osd_thread_info *info, struct osd_device *dev,
+                    struct inode *inode, const struct lu_fid *fid)
 {
-       struct osd_scrub     *scrub  = &dev->od_scrub;
-       struct ptlrpc_thread *thread = &scrub->os_thread;
-       struct scrub_file    *sf     = &scrub->os_file;
-       __u32                 flags  = scrub->os_start_flags;
-       int                   rc;
+       struct filter_fid_old   *ff      = &info->oti_ff;
+       struct dentry           *dentry  = &info->oti_obj_dentry;
+       handle_t                *jh;
+       int                      size    = 0;
+       int                      rc;
+       bool                     removed = false;
+       bool                     reset   = true;
        ENTRY;
 
-       down_write(&scrub->os_rwsem);
-       if (flags & SS_SET_FAILOUT)
-               sf->sf_param |= SP_FAILOUT;
+       if (dev->od_scrub.os_file.sf_param & SP_DRYRUN)
+               RETURN(0);
 
-       if (flags & SS_CLEAR_FAILOUT)
-               sf->sf_param &= ~SP_FAILOUT;
+       /* We want the LMA to fit into the 256-byte OST inode, so operate
+        * as following:
+        * 1) read old XATTR_NAME_FID and save the parent FID;
+        * 2) delete the old XATTR_NAME_FID;
+        * 3) make new LMA and add it;
+        * 4) generate new XATTR_NAME_FID with the saved parent FID and add it.
+        *
+        * Making the LMA to fit into the 256-byte OST inode can save time for
+        * normal osd_check_lma() and for other OI scrub scanning in future.
+        * So it is worth to make some slow conversion here. */
+       jh = osd_journal_start_sb(osd_sb(dev), LDISKFS_HT_MISC,
+                               osd_dto_credits_noquota[DTO_XATTR_SET] * 3);
+       if (IS_ERR(jh)) {
+               rc = PTR_ERR(jh);
+               CERROR("%s: fail to start trans for convert ff: "DFID
+                      ": rc = %d\n",
+                      osd_name(dev), PFID(fid), rc);
+               RETURN(rc);
+       }
 
-       if (flags & SS_RESET)
-               osd_scrub_file_reset(scrub,
-                       LDISKFS_SB(osd_sb(dev))->s_es->s_uuid, 0);
+       /* 1) read old XATTR_NAME_FID and save the parent FID */
+       rc = __osd_xattr_get(inode, dentry, XATTR_NAME_FID, ff, sizeof(*ff));
+       if (rc == sizeof(*ff)) {
+               /* 2) delete the old XATTR_NAME_FID */
+               ll_vfs_dq_init(inode);
+               rc = inode->i_op->removexattr(dentry, XATTR_NAME_FID);
+               if (rc != 0)
+                       GOTO(stop, rc);
 
-       if (flags & SS_AUTO) {
-               scrub->os_full_speed = 1;
-               sf->sf_flags |= SF_AUTO;
-       } else {
-               scrub->os_full_speed = 0;
+               removed = true;
+       } else if (unlikely(rc == -ENODATA)) {
+               reset = false;
+       } else if (rc != sizeof(struct filter_fid)) {
+               GOTO(stop, rc = -EINVAL);
        }
 
-       if (sf->sf_flags & (SF_RECREATED | SF_INCONSISTENT | SF_UPGRADE))
-               scrub->os_full_speed = 1;
+       /* 3) make new LMA and add it */
+       rc = osd_ea_fid_set(info, inode, fid, LMAC_FID_ON_OST, 0);
+       if (rc == 0 && reset)
+               size = sizeof(struct filter_fid);
+       else if (rc != 0 && removed)
+               /* If failed, we should try to add the old back. */
+               size = sizeof(struct filter_fid_old);
 
-       scrub->os_in_prior = 0;
-       scrub->os_waiting = 0;
-       scrub->os_paused = 0;
-       scrub->os_new_checked = 0;
-       if (sf->sf_pos_last_checkpoint != 0)
-               sf->sf_pos_latest_start = sf->sf_pos_last_checkpoint + 1;
-       else
-               sf->sf_pos_latest_start = LDISKFS_FIRST_INO(osd_sb(dev)) + 1;
+       /* 4) generate new XATTR_NAME_FID with the saved parent FID and add it*/
+       if (size > 0) {
+               int rc1;
 
-       scrub->os_pos_current = sf->sf_pos_latest_start;
-       sf->sf_status = SS_SCANNING;
-       sf->sf_time_latest_start = cfs_time_current_sec();
-       sf->sf_time_last_checkpoint = sf->sf_time_latest_start;
-       rc = osd_scrub_file_store(scrub);
-       if (rc == 0) {
-               spin_lock(&scrub->os_lock);
-               thread_set_flags(thread, SVC_RUNNING);
-               spin_unlock(&scrub->os_lock);
-               cfs_waitq_broadcast(&thread->t_ctl_waitq);
+               rc1 = __osd_xattr_set(info, inode, XATTR_NAME_FID, ff, size,
+                                     XATTR_CREATE);
+               if (rc1 != 0 && rc == 0)
+                       rc = rc1;
        }
-       up_write(&scrub->os_rwsem);
 
-       RETURN(rc);
+       GOTO(stop, rc);
+
+stop:
+       ldiskfs_journal_stop(jh);
+       return rc;
 }
 
 static int
@@ -430,6 +437,7 @@ osd_scrub_check_update(struct osd_thread_info *info, struct osd_device *dev,
        int                           ops    = DTO_INDEX_UPDATE;
        int                           idx;
        int                           rc;
+       bool                          converted = false;
        ENTRY;
 
        down_write(&scrub->os_rwsem);
@@ -458,14 +466,17 @@ osd_scrub_check_update(struct osd_thread_info *info, struct osd_device *dev,
                }
 
                sf->sf_flags |= SF_UPGRADE;
-               rc = osd_ea_fid_set(info, inode, fid,
-                                   LMAC_FID_ON_OST, 0);
+               sf->sf_internal_flags &= ~SIF_NO_HANDLE_OLD_FID;
+               dev->od_check_ff = 1;
+               rc = osd_scrub_convert_ff(info, dev, inode, fid);
                if (rc != 0)
                        GOTO(out, rc);
+
+               converted = true;
        }
 
        if ((val == SCRUB_NEXT_NOLMA) &&
-           (!dev->od_handle_nolma || OBD_FAIL_CHECK(OBD_FAIL_FID_NOLMA)))
+           (!scrub->os_convert_igif || OBD_FAIL_CHECK(OBD_FAIL_FID_NOLMA)))
                GOTO(out, rc = 0);
 
        if ((oii != NULL && oii->oii_insert) || (val == SCRUB_NEXT_NOLMA))
@@ -475,7 +486,7 @@ osd_scrub_check_update(struct osd_thread_info *info, struct osd_device *dev,
                (val == SCRUB_NEXT_OSTOBJ ||
                 val == SCRUB_NEXT_OSTOBJ_OLD) ? OI_KNOWN_ON_OST : 0);
        if (rc != 0) {
-               if (rc != -ENOENT)
+               if (rc != -ENOENT && rc != -ESTALE)
                        GOTO(out, rc);
 
 iget:
@@ -496,9 +507,11 @@ iget:
                switch (val) {
                case SCRUB_NEXT_NOLMA:
                        sf->sf_flags |= SF_UPGRADE;
-                       rc = osd_ea_fid_set(info, inode, fid, 0, 0);
-                       if (rc != 0)
-                               GOTO(out, rc);
+                       if (!(sf->sf_param & SP_DRYRUN)) {
+                               rc = osd_ea_fid_set(info, inode, fid, 0, 0);
+                               if (rc != 0)
+                                       GOTO(out, rc);
+                       }
 
                        if (!(sf->sf_flags & SF_INCONSISTENT))
                                dev->od_igif_inoi = 0;
@@ -514,6 +527,9 @@ iget:
                        break;
                }
        } else if (osd_id_eq(lid, lid2)) {
+               if (converted)
+                       sf->sf_items_updated++;
+
                GOTO(out, rc = 0);
        } else {
                scrub->os_full_speed = 1;
@@ -534,7 +550,7 @@ iget:
                dev->od_igif_inoi = 1;
        }
 
-       rc = osd_scrub_refresh_mapping(info, dev, fid, lid, ops,
+       rc = osd_scrub_refresh_mapping(info, dev, fid, lid, ops, false,
                        (val == SCRUB_NEXT_OSTOBJ ||
                         val == SCRUB_NEXT_OSTOBJ_OLD) ? OI_KNOWN_ON_OST : 0);
        if (rc == 0) {
@@ -564,7 +580,7 @@ out:
        if (ops == DTO_INDEX_INSERT && inode != NULL && !IS_ERR(inode) &&
            unlikely(inode->i_nlink == 0))
                osd_scrub_refresh_mapping(info, dev, fid, lid,
-                               DTO_INDEX_DELETE,
+                               DTO_INDEX_DELETE, false,
                                (val == SCRUB_NEXT_OSTOBJ ||
                                 val == SCRUB_NEXT_OSTOBJ_OLD) ?
                                OI_KNOWN_ON_OST : 0);
@@ -584,6 +600,78 @@ out:
        RETURN(sf->sf_param & SP_FAILOUT ? rc : 0);
 }
 
+/* OI scrub APIs */
+
+static int osd_scrub_prep(struct osd_device *dev)
+{
+       struct osd_scrub     *scrub  = &dev->od_scrub;
+       struct ptlrpc_thread *thread = &scrub->os_thread;
+       struct scrub_file    *sf     = &scrub->os_file;
+       __u32                 flags  = scrub->os_start_flags;
+       int                   rc;
+       bool                  drop_dryrun = false;
+       ENTRY;
+
+       down_write(&scrub->os_rwsem);
+       if (flags & SS_SET_FAILOUT)
+               sf->sf_param |= SP_FAILOUT;
+
+       if (flags & SS_CLEAR_FAILOUT)
+               sf->sf_param &= ~SP_FAILOUT;
+
+       if (flags & SS_SET_DRYRUN)
+               sf->sf_param |= SP_DRYRUN;
+
+       if (flags & SS_CLEAR_DRYRUN && sf->sf_param & SP_DRYRUN) {
+               sf->sf_param &= ~SP_DRYRUN;
+               drop_dryrun = true;
+       }
+
+       if (flags & SS_RESET)
+               osd_scrub_file_reset(scrub,
+                       LDISKFS_SB(osd_sb(dev))->s_es->s_uuid, 0);
+
+       if (flags & SS_AUTO) {
+               scrub->os_full_speed = 1;
+               sf->sf_flags |= SF_AUTO;
+               /* For the case of OI scrub auto triggered, NOT dryrun. */
+               sf->sf_param &= ~SP_FAILOUT;
+       } else {
+               scrub->os_full_speed = 0;
+       }
+
+       if (sf->sf_flags & (SF_RECREATED | SF_INCONSISTENT | SF_UPGRADE))
+               scrub->os_full_speed = 1;
+
+       scrub->os_in_prior = 0;
+       spin_lock(&scrub->os_lock);
+       scrub->os_waiting = 0;
+       scrub->os_paused = 0;
+       spin_unlock(&scrub->os_lock);
+       scrub->os_new_checked = 0;
+       if (drop_dryrun && sf->sf_pos_first_inconsistent != 0)
+               sf->sf_pos_latest_start = sf->sf_pos_first_inconsistent;
+       else if (sf->sf_pos_last_checkpoint != 0)
+               sf->sf_pos_latest_start = sf->sf_pos_last_checkpoint + 1;
+       else
+               sf->sf_pos_latest_start = LDISKFS_FIRST_INO(osd_sb(dev)) + 1;
+
+       scrub->os_pos_current = sf->sf_pos_latest_start;
+       sf->sf_status = SS_SCANNING;
+       sf->sf_time_latest_start = cfs_time_current_sec();
+       sf->sf_time_last_checkpoint = sf->sf_time_latest_start;
+       rc = osd_scrub_file_store(scrub);
+       if (rc == 0) {
+               spin_lock(&scrub->os_lock);
+               thread_set_flags(thread, SVC_RUNNING);
+               spin_unlock(&scrub->os_lock);
+               wake_up_all(&thread->t_ctl_waitq);
+       }
+       up_write(&scrub->os_rwsem);
+
+       RETURN(rc);
+}
+
 static int osd_scrub_checkpoint(struct osd_scrub *scrub)
 {
        struct scrub_file *sf = &scrub->os_file;
@@ -627,10 +715,13 @@ static void osd_scrub_post(struct osd_scrub *scrub, int result)
                        container_of0(scrub, struct osd_device, od_scrub);
 
                dev->od_igif_inoi = 1;
+               dev->od_check_ff = 0;
                sf->sf_status = SS_COMPLETED;
-               memset(sf->sf_oi_bitmap, 0, SCRUB_OI_BITMAP_SIZE);
-               sf->sf_flags &= ~(SF_RECREATED | SF_INCONSISTENT |
-                                 SF_UPGRADE | SF_AUTO);
+               if (!(sf->sf_param & SP_DRYRUN)) {
+                       memset(sf->sf_oi_bitmap, 0, SCRUB_OI_BITMAP_SIZE);
+                       sf->sf_flags &= ~(SF_RECREATED | SF_INCONSISTENT |
+                                         SF_UPGRADE | SF_AUTO);
+               }
                sf->sf_time_last_complete = sf->sf_time_last_checkpoint;
                sf->sf_success_count++;
        } else if (result == 0) {
@@ -700,7 +791,10 @@ static int osd_scrub_check_local_fldb(struct osd_thread_info *info,
         *      a small local FLDB according to the <seq>. If the given FID
         *      is in the local FLDB, then it is FID-on-OST; otherwise it's
         *      quite possible for FID-on-MDT. */
-       return 0;
+       if (dev->od_is_ost)
+               return SCRUB_NEXT_OSTOBJ_OLD;
+       else
+               return 0;
 }
 
 static int osd_scrub_get_fid(struct osd_thread_info *info,
@@ -714,36 +808,31 @@ static int osd_scrub_get_fid(struct osd_thread_info *info,
        rc = osd_get_lma(info, inode, &info->oti_obj_dentry, lma);
        if (rc == 0) {
                has_lma = true;
-               if (lma->lma_compat & LMAC_NOT_IN_OI) {
-                       ldiskfs_set_inode_state(inode,
-                                               LDISKFS_STATE_LUSTRE_NO_OI);
+               if (lma->lma_compat & LMAC_NOT_IN_OI ||
+                   lma->lma_incompat & LMAI_AGENT)
                        return SCRUB_NEXT_CONTINUE;
-               }
 
                *fid = lma->lma_self_fid;
-               if (fid_is_internal(&lma->lma_self_fid)) {
-                       if (!scrub)
-                               rc = SCRUB_NEXT_CONTINUE;
-                       return rc;
-               }
-
                if (!scrub)
                        return 0;
 
-               if (fid_is_namespace_visible(fid) && !fid_is_norm(fid))
-                       return 0;
-
                if (lma->lma_compat & LMAC_FID_ON_OST)
                        return SCRUB_NEXT_OSTOBJ;
 
-               if (fid_is_idif(fid) || fid_is_last_id(fid))
+               if (fid_is_idif(fid))
                        return SCRUB_NEXT_OSTOBJ_OLD;
 
-               if (lma->lma_incompat & LMAI_AGENT)
-                       return SCRUB_NEXT_CONTINUE;
+               /* For local object. */
+               if (fid_is_internal(fid))
+                       return 0;
+
+               /* For external visible MDT-object with non-normal FID. */
+               if (fid_is_namespace_visible(fid) && !fid_is_norm(fid))
+                       return 0;
 
-               /* Here, it may be MDT-object, or may be 2.4 OST-object.
-                * Fall through. */
+               /* For the object with normal FID, it may be MDT-object,
+                * or may be 2.4 OST-object, need further distinguish.
+                * Fall through to next section. */
        }
 
        if (rc == -ENODATA || rc == 0) {
@@ -770,7 +859,7 @@ static int osd_scrub_get_fid(struct osd_thread_info *info,
                        return rc;
 
                if (!has_lma) {
-                       if (dev->od_handle_nolma) {
+                       if (dev->od_scrub.os_convert_igif) {
                                lu_igif_build(fid, inode->i_ino,
                                              inode->i_generation);
                                if (scrub)
@@ -817,11 +906,6 @@ static int osd_iit_iget(struct osd_thread_info *info, struct osd_device *dev,
                RETURN(rc);
        }
 
-       /* If the inode has no OI mapping, then it is special locally used,
-        * should be invisible to OI scrub or up layer LFSCK. */
-       if (ldiskfs_test_inode_state(inode, LDISKFS_STATE_LUSTRE_NO_OI))
-               GOTO(put, rc = SCRUB_NEXT_CONTINUE);
-
        if (scrub &&
            ldiskfs_test_inode_state(inode, LDISKFS_STATE_LUSTRE_NOSCRUB)) {
                /* Only skip it for the first OI scrub accessing. */
@@ -985,11 +1069,11 @@ next:
        scrub->os_pos_current = param->gbase + ++(param->offset);
 
 wait:
-       if (it != NULL && it->ooi_waiting &&
+       if (it != NULL && it->ooi_waiting && ooc != NULL &&
            ooc->ooc_pos_preload < scrub->os_pos_current) {
                spin_lock(&scrub->os_lock);
                it->ooi_waiting = 0;
-               cfs_waitq_broadcast(&thread->t_ctl_waitq);
+               wake_up_all(&thread->t_ctl_waitq);
                spin_unlock(&scrub->os_lock);
        }
 
@@ -1127,8 +1211,10 @@ static int osd_otable_it_preload(const struct lu_env *env,
               ooc->ooc_pos_preload, rc);
 
        if (scrub->os_waiting && osd_scrub_has_window(scrub, ooc)) {
+               spin_lock(&scrub->os_lock);
                scrub->os_waiting = 0;
-               cfs_waitq_broadcast(&scrub->os_thread.t_ctl_waitq);
+               wake_up_all(&scrub->os_thread.t_ctl_waitq);
+               spin_unlock(&scrub->os_lock);
        }
 
        RETURN(rc < 0 ? rc : ooc->ooc_cached_items);
@@ -1199,7 +1285,7 @@ out:
 noenv:
        spin_lock(&scrub->os_lock);
        thread_set_flags(thread, SVC_STOPPED);
-       cfs_waitq_broadcast(&thread->t_ctl_waitq);
+       wake_up_all(&thread->t_ctl_waitq);
        spin_unlock(&scrub->os_lock);
        return rc;
 }
@@ -1213,6 +1299,8 @@ static int osd_ios_varfid_fill(void *buf, const char *name, int namelen,
                               loff_t offset, __u64 ino, unsigned d_type);
 static int osd_ios_lf_fill(void *buf, const char *name, int namelen,
                           loff_t offset, __u64 ino, unsigned d_type);
+static int osd_ios_dl_fill(void *buf, const char *name, int namelen,
+                          loff_t offset, __u64 ino, unsigned d_type);
 
 static int
 osd_ios_general_scan(struct osd_thread_info *info, struct osd_device *dev,
@@ -1323,6 +1411,10 @@ static const struct osd_lf_map osd_lf_maps[] = {
        { "LAST_GROUP", { FID_SEQ_LOCAL_FILE, OFD_LAST_GROUP_OID, 0 },
                OLF_SHOW_NAME, NULL, NULL },
 
+       /* SLAVE_LOG, llog for destroy slave stripes of striped dir */
+       { "SLAVE_LOG", { FID_SEQ_LOCAL_FILE, SLAVE_LLOG_CATALOGS_OID, 0 },
+              OLF_SHOW_NAME, NULL, NULL },
+
        /* lost+found */
        { "lost+found", { 0, 0, 0 }, OLF_SCAN_SUBITEMS | OLF_NO_OI,
                osd_ios_general_scan, osd_ios_lf_fill },
@@ -1330,6 +1422,19 @@ static const struct osd_lf_map osd_lf_maps[] = {
        { NULL, { 0, 0, 0 }, 0, NULL, NULL }
 };
 
+/* Add the new introduced files under .lustre/ in the list in the future. */
+static const struct osd_lf_map osd_dl_maps[] = {
+       /* .lustre/fid */
+       { "fid", { FID_SEQ_DOT_LUSTRE, FID_OID_DOT_LUSTRE_OBF, 0 }, 0,
+               NULL, NULL },
+
+       /* .lustre/lost+found */
+       { "lost+found", { FID_SEQ_DOT_LUSTRE, FID_OID_DOT_LUSTRE_LPF, 0 }, 0,
+               NULL, NULL },
+
+       { NULL, { 0, 0, 0 }, 0, NULL, NULL }
+};
+
 struct osd_ios_item {
        cfs_list_t       oii_list;
        struct dentry   *oii_dentry;
@@ -1338,6 +1443,10 @@ struct osd_ios_item {
 };
 
 struct osd_ios_filldir_buf {
+#ifdef HAVE_DIR_CONTEXT
+       /* please keep it as first member */
+       struct dir_context       ctx;
+#endif
        struct osd_thread_info  *oifb_info;
        struct osd_device       *oifb_dev;
        struct dentry           *oifb_dentry;
@@ -1348,6 +1457,9 @@ osd_ios_lookup_one_len(const char *name, struct dentry *parent, int namelen)
 {
        struct dentry *dentry;
 
+       CDEBUG(D_LFSCK, "init lookup one: parent = %.*s, name = %.*s\n",
+              parent->d_name.len, parent->d_name.name, namelen, name);
+
        dentry = ll_lookup_one_len(name, parent, namelen);
        if (!IS_ERR(dentry) && dentry->d_inode == NULL) {
                dput(dentry);
@@ -1357,48 +1469,24 @@ osd_ios_lookup_one_len(const char *name, struct dentry *parent, int namelen)
        return dentry;
 }
 
-static inline void
-osd_ios_llogname2fid(struct lu_fid *fid, const char *name, int namelen)
-{
-       obd_id id = 0;
-       int    i  = 0;
-
-       fid->f_seq = FID_SEQ_LLOG;
-       while (i < namelen)
-               id = id * 10 + name[i++] - '0';
-
-       fid->f_oid = id & 0x00000000ffffffffULL;
-       fid->f_ver = id >> 32;
-}
-
-static inline void
-osd_ios_Oname2fid(struct lu_fid *fid, const char *name, int namelen)
-{
-       __u64 seq = 0;
-       int   i   = 0;
-
-       while (i < namelen)
-               seq = seq * 10 + name[i++] - '0';
-
-       lu_last_id_fid(fid, seq);
-}
-
 static int
 osd_ios_new_item(struct osd_device *dev, struct dentry *dentry,
                 scandir_t scandir, filldir_t filldir)
 {
        struct osd_ios_item *item;
+       ENTRY;
 
        OBD_ALLOC_PTR(item);
        if (item == NULL)
-               return -ENOMEM;
+               RETURN(-ENOMEM);
 
        CFS_INIT_LIST_HEAD(&item->oii_list);
        item->oii_dentry = dget(dentry);
        item->oii_scandir = scandir;
        item->oii_filldir = filldir;
        cfs_list_add_tail(&item->oii_list, &dev->od_ios_list);
-       return 0;
+
+       RETURN(0);
 }
 
 /**
@@ -1421,6 +1509,8 @@ osd_ios_scan_one(struct osd_thread_info *info, struct osd_device *dev,
        int                      rc;
        ENTRY;
 
+       CDEBUG(D_LFSCK, "init scan one: ino = %ld\n", inode->i_ino);
+
        rc = osd_get_lma(info, inode, &info->oti_obj_dentry, lma);
        if (rc != 0 && rc != -ENODATA)
                RETURN(rc);
@@ -1447,7 +1537,7 @@ osd_ios_scan_one(struct osd_thread_info *info, struct osd_device *dev,
                        RETURN(rc);
 
                rc = osd_scrub_refresh_mapping(info, dev, &tfid, id,
-                                              DTO_INDEX_INSERT, 0);
+                                              DTO_INDEX_INSERT, true, 0);
                if (rc > 0)
                        rc = 0;
 
@@ -1467,7 +1557,7 @@ osd_ios_scan_one(struct osd_thread_info *info, struct osd_device *dev,
        }
 
        rc = osd_scrub_refresh_mapping(info, dev, &tfid, id,
-                                      DTO_INDEX_UPDATE, 0);
+                                      DTO_INDEX_UPDATE, true, 0);
        if (rc > 0)
                rc = 0;
 
@@ -1572,6 +1662,42 @@ static int osd_ios_varfid_fill(void *buf, const char *name, int namelen,
        RETURN(rc);
 }
 
+static int osd_ios_dl_fill(void *buf, const char *name, int namelen,
+                          loff_t offset, __u64 ino, unsigned d_type)
+{
+       struct osd_ios_filldir_buf *fill_buf = buf;
+       struct osd_device          *dev      = fill_buf->oifb_dev;
+       const struct osd_lf_map    *map;
+       struct dentry              *child;
+       int                         rc       = 0;
+       ENTRY;
+
+       /* skip any '.' started names */
+       if (name[0] == '.')
+               RETURN(0);
+
+       for (map = osd_dl_maps; map->olm_name != NULL; map++) {
+               if (strlen(map->olm_name) != namelen)
+                       continue;
+
+               if (strncmp(map->olm_name, name, namelen) == 0)
+                       break;
+       }
+
+       if (map->olm_name == NULL)
+               RETURN(0);
+
+       child = osd_ios_lookup_one_len(name, fill_buf->oifb_dentry, namelen);
+       if (IS_ERR(child))
+               RETURN(PTR_ERR(child));
+
+       rc = osd_ios_scan_one(fill_buf->oifb_info, dev, child->d_inode,
+                             &map->olm_fid, map->olm_flags);
+       dput(child);
+
+       RETURN(rc);
+}
+
 static int osd_ios_root_fill(void *buf, const char *name, int namelen,
                             loff_t offset, __u64 ino, unsigned d_type)
 {
@@ -1616,7 +1742,13 @@ static int
 osd_ios_general_scan(struct osd_thread_info *info, struct osd_device *dev,
                     struct dentry *dentry, filldir_t filldir)
 {
-       struct osd_ios_filldir_buf    buf   = { info, dev, dentry };
+       struct osd_ios_filldir_buf    buf   = {
+#ifdef HAVE_DIR_CONTEXT
+                                               .ctx.actor = filldir,
+#endif
+                                               .oifb_info = info,
+                                               .oifb_dev = dev,
+                                               .oifb_dentry = dentry };
        struct file                  *filp  = &info->oti_it_ea.oie_file;
        struct inode                 *inode = dentry->d_inode;
        const struct file_operations *fops  = inode->i_fop;
@@ -1631,8 +1763,15 @@ osd_ios_general_scan(struct osd_thread_info *info, struct osd_device *dev,
        filp->f_mapping = inode->i_mapping;
        filp->f_op = fops;
        filp->private_data = NULL;
+       set_file_inode(filp, inode);
 
+#ifdef HAVE_DIR_CONTEXT
+       buf.ctx.pos = filp->f_pos;
+       rc = fops->iterate(filp, &buf.ctx);
+       filp->f_pos = buf.ctx.pos;
+#else
        rc = fops->readdir(filp, &buf, filldir);
+#endif
        fops->release(inode, filp);
 
        RETURN(rc);
@@ -1661,7 +1800,7 @@ osd_ios_ROOT_scan(struct osd_thread_info *info, struct osd_device *dev,
         *      and try to re-generate the LMA from the OI mapping. But if the
         *      OI mapping crashed or lost also, then we have to give up under
         *      double failure cases. */
-       dev->od_handle_nolma = 1;
+       scrub->os_convert_igif = 1;
        child = osd_ios_lookup_one_len(dot_lustre_name, dentry,
                                       strlen(dot_lustre_name));
        if (IS_ERR(child)) {
@@ -1672,6 +1811,7 @@ osd_ios_ROOT_scan(struct osd_thread_info *info, struct osd_device *dev,
                                osd_scrub_file_reset(scrub,
                                        LDISKFS_SB(osd_sb(dev))->s_es->s_uuid,
                                        SF_UPGRADE);
+                               sf->sf_internal_flags &= ~SIF_NO_HANDLE_OLD_FID;
                                rc = osd_scrub_file_store(scrub);
                        } else {
                                rc = 0;
@@ -1703,6 +1843,9 @@ osd_ios_ROOT_scan(struct osd_thread_info *info, struct osd_device *dev,
                 * to the solution 2). */
                rc = osd_ios_scan_one(info, dev, child->d_inode,
                                      &LU_DOT_LUSTRE_FID, 0);
+               if (rc == 0)
+                       rc = osd_ios_new_item(dev, child, osd_ios_general_scan,
+                                             osd_ios_dl_fill);
                dput(child);
        }
 
@@ -1713,10 +1856,19 @@ static int
 osd_ios_OBJECTS_scan(struct osd_thread_info *info, struct osd_device *dev,
                     struct dentry *dentry, filldir_t filldir)
 {
-       struct dentry *child;
-       int            rc;
+       struct osd_scrub  *scrub  = &dev->od_scrub;
+       struct scrub_file *sf     = &scrub->os_file;
+       struct dentry     *child;
+       int                rc;
        ENTRY;
 
+       if (unlikely(sf->sf_internal_flags & SIF_NO_HANDLE_OLD_FID)) {
+               sf->sf_internal_flags &= ~SIF_NO_HANDLE_OLD_FID;
+               rc = osd_scrub_file_store(scrub);
+               if (rc != 0)
+                       RETURN(rc);
+       }
+
        child = osd_ios_lookup_one_len(ADMIN_USR, dentry, strlen(ADMIN_USR));
        if (!IS_ERR(child)) {
                rc = osd_ios_scan_one(info, dev, child->d_inode, NULL, 0);
@@ -1753,6 +1905,9 @@ static int osd_initial_OI_scrub(struct osd_thread_info *info,
        int                      rc;
        ENTRY;
 
+       /* Lookup IGIF in OI by force for initial OI scrub. */
+       dev->od_igif_inoi = 1;
+
        while (1) {
                rc = scandir(info, dev, dentry, filldir);
                if (item != NULL) {
@@ -1805,7 +1960,8 @@ static int osd_initial_OI_scrub(struct osd_thread_info *info,
                        dput(child);
                else if (PTR_ERR(child) == -ENOENT)
                        osd_scrub_refresh_mapping(info, dev, &map->olm_fid,
-                                                 NULL, DTO_INDEX_DELETE, 0);
+                                                 NULL, DTO_INDEX_DELETE,
+                                                 true, 0);
                map++;
        }
 
@@ -1838,6 +1994,7 @@ static int do_osd_scrub_start(struct osd_device *dev, __u32 flags)
        struct osd_scrub     *scrub  = &dev->od_scrub;
        struct ptlrpc_thread *thread = &scrub->os_thread;
        struct l_wait_info    lwi    = { 0 };
+       struct task_struct   *task;
        int                   rc;
        ENTRY;
 
@@ -1861,9 +2018,10 @@ again:
 
        scrub->os_start_flags = flags;
        thread_set_flags(thread, 0);
-       rc = PTR_ERR(kthread_run(osd_scrub_main, dev, "OI_scrub"));
-       if (IS_ERR_VALUE(rc)) {
-               CERROR("%.16s: cannot start iteration thread, rc = %d\n",
+       task = kthread_run(osd_scrub_main, dev, "OI_scrub");
+       if (IS_ERR(task)) {
+               rc = PTR_ERR(task);
+               CERROR("%.16s: cannot start iteration thread: rc = %d\n",
                       LDISKFS_SB(osd_sb(dev))->s_es->s_volume_name, rc);
                RETURN(rc);
        }
@@ -1898,7 +2056,7 @@ static void do_osd_scrub_stop(struct osd_scrub *scrub)
        if (!thread_is_init(thread) && !thread_is_stopped(thread)) {
                thread_set_flags(thread, SVC_STOPPING);
                spin_unlock(&scrub->os_lock);
-               cfs_waitq_broadcast(&thread->t_ctl_waitq);
+               wake_up_all(&thread->t_ctl_waitq);
                l_wait_event(thread->t_ctl_waitq,
                             thread_is_stopped(thread),
                             &lwi);
@@ -1944,37 +2102,50 @@ int osd_scrub_setup(const struct lu_env *env, struct osd_device *dev)
        ctxt->pwd = dev->od_mnt->mnt_root;
        ctxt->fs = get_ds();
 
-       cfs_waitq_init(&scrub->os_thread.t_ctl_waitq);
+       init_waitqueue_head(&scrub->os_thread.t_ctl_waitq);
        init_rwsem(&scrub->os_rwsem);
        spin_lock_init(&scrub->os_lock);
        CFS_INIT_LIST_HEAD(&scrub->os_inconsistent_items);
 
-       push_ctxt(&saved, ctxt, NULL);
+       push_ctxt(&saved, ctxt);
        filp = filp_open(osd_scrub_name, O_RDWR | O_CREAT, 0644);
        if (IS_ERR(filp)) {
-               pop_ctxt(&saved, ctxt, NULL);
+               pop_ctxt(&saved, ctxt);
                RETURN(PTR_ERR(filp));
        }
 
        inode = filp->f_dentry->d_inode;
-       ldiskfs_set_inode_state(inode, LDISKFS_STATE_LUSTRE_NO_OI);
        /* 'What the @fid is' is not imporatant, because the object
         * has no OI mapping, and only is visible inside the OSD.*/
        lu_igif_build(fid, inode->i_ino, inode->i_generation);
        rc = osd_ea_fid_set(info, inode, fid, LMAC_NOT_IN_OI, 0);
        if (rc != 0) {
                filp_close(filp, 0);
-               pop_ctxt(&saved, ctxt, NULL);
+               pop_ctxt(&saved, ctxt);
                RETURN(rc);
        }
 
        scrub->os_inode = igrab(inode);
        filp_close(filp, 0);
-       pop_ctxt(&saved, ctxt, NULL);
+       pop_ctxt(&saved, ctxt);
 
        rc = osd_scrub_file_load(scrub);
        if (rc == -ENOENT) {
                osd_scrub_file_init(scrub, es->s_uuid);
+               /* If the "/O" dir does not exist when mount (indicated by
+                * osd_device::od_maybe_new), neither for the "/OI_scrub",
+                * then it is quite probably that the device is a new one,
+                * under such case, mark it as SIF_NO_HANDLE_OLD_FID.
+                *
+                * For the rare case that "/O" and "OI_scrub" both lost on
+                * an old device, it can be found and cleared later.
+                *
+                * For the system with "SIF_NO_HANDLE_OLD_FID", we do not
+                * need to check "filter_fid_old" and to convert it to
+                * "filter_fid" for each object, and all the IGIF should
+                * have their FID mapping in OI files already. */
+               if (dev->od_maybe_new)
+                       sf->sf_internal_flags = SIF_NO_HANDLE_OLD_FID;
                dirty = 1;
        } else if (rc != 0) {
                RETURN(rc);
@@ -2006,12 +2177,17 @@ int osd_scrub_setup(const struct lu_env *env, struct osd_device *dev)
 
        rc = osd_initial_OI_scrub(info, dev);
        if (rc == 0) {
-               if ((sf->sf_flags & SF_UPGRADE) &&
-                  !(sf->sf_flags & SF_INCONSISTENT))
-                       /* The 'od_igif_inoi' will be set after the
-                        * upgrading completed, needs NOT remount. */
+               if (sf->sf_flags & SF_UPGRADE ||
+                   !(sf->sf_internal_flags & SIF_NO_HANDLE_OLD_FID ||
+                     sf->sf_success_count > 0)) {
                        dev->od_igif_inoi = 0;
-               else
+                       dev->od_check_ff = dev->od_is_ost;
+               } else {
+                       dev->od_igif_inoi = 1;
+                       dev->od_check_ff = 0;
+               }
+
+               if (sf->sf_flags & SF_INCONSISTENT)
                        /* The 'od_igif_inoi' will be set under the
                         * following cases:
                         * 1) new created system, or
@@ -2098,6 +2274,13 @@ static struct dt_it *osd_otable_it_init(const struct lu_env *env,
                        start |= SS_CLEAR_FAILOUT;
        }
 
+       if (valid & DOIV_DRYRUN) {
+               if (flags & DOIF_DRYRUN)
+                       start |= SS_SET_DRYRUN;
+               else
+                       start |= SS_CLEAR_DRYRUN;
+       }
+
        rc = do_osd_scrub_start(dev, start);
        if (rc < 0 && rc != -EALREADY) {
                dev->od_otable_it = NULL;
@@ -2188,7 +2371,7 @@ again:
        if (scrub->os_waiting && osd_scrub_has_window(scrub, ooc)) {
                spin_lock(&scrub->os_lock);
                scrub->os_waiting = 0;
-               cfs_waitq_broadcast(&scrub->os_thread.t_ctl_waitq);
+               wake_up_all(&scrub->os_thread.t_ctl_waitq);
                spin_unlock(&scrub->os_lock);
        }
 
@@ -2276,7 +2459,7 @@ static int osd_otable_it_load(const struct lu_env *env,
 
        it->ooi_user_ready = 1;
        if (!scrub->os_full_speed)
-               cfs_waitq_broadcast(&scrub->os_thread.t_ctl_waitq);
+               wake_up_all(&scrub->os_thread.t_ctl_waitq);
 
        /* Unplug OSD layer iteration by the first next() call. */
        rc = osd_otable_it_next(env, (struct dt_it *)it);
@@ -2338,7 +2521,7 @@ int osd_oii_insert(struct osd_device *dev, struct osd_idmap_cache *oic,
        spin_unlock(&scrub->os_lock);
 
        if (wakeup != 0)
-               cfs_waitq_broadcast(&thread->t_ctl_waitq);
+               wake_up_all(&thread->t_ctl_waitq);
 
        RETURN(0);
 }
@@ -2386,137 +2569,116 @@ static const char *scrub_flags_names[] = {
 
 static const char *scrub_param_names[] = {
        "failout",
+       "dryrun",
        NULL
 };
 
-static int scrub_bits_dump(char **buf, int *len, int bits, const char *names[],
+static int scrub_bits_dump(struct seq_file *m, int bits, const char *names[],
                           const char *prefix)
 {
-       int save = *len;
        int flag;
        int rc;
        int i;
 
-       rc = snprintf(*buf, *len, "%s:%c", prefix, bits != 0 ? ' ' : '\n');
-       if (rc <= 0)
-               return -ENOSPC;
+       rc = seq_printf(m, "%s:%c", prefix, bits != 0 ? ' ' : '\n');
+       if (rc < 0)
+               return rc;
 
-       *buf += rc;
-       *len -= rc;
        for (i = 0, flag = 1; bits != 0; i++, flag = 1 << i) {
                if (flag & bits) {
                        bits &= ~flag;
-                       rc = snprintf(*buf, *len, "%s%c", names[i],
-                                     bits != 0 ? ',' : '\n');
-                       if (rc <= 0)
-                               return -ENOSPC;
-
-                       *buf += rc;
-                       *len -= rc;
+                       rc = seq_printf(m, "%s%c", names[i],
+                                       bits != 0 ? ',' : '\n');
+                       if (rc < 0)
+                               return rc;
                }
        }
-       return save - *len;
+       return 0;
 }
 
-static int scrub_time_dump(char **buf, int *len, __u64 time, const char *prefix)
+static int scrub_time_dump(struct seq_file *m, __u64 time, const char *prefix)
 {
        int rc;
 
        if (time != 0)
-               rc = snprintf(*buf, *len, "%s: "LPU64" seconds\n", prefix,
+               rc = seq_printf(m, "%s: "LPU64" seconds\n", prefix,
                              cfs_time_current_sec() - time);
        else
-               rc = snprintf(*buf, *len, "%s: N/A\n", prefix);
-       if (rc <= 0)
-               return -ENOSPC;
-
-       *buf += rc;
-       *len -= rc;
+               rc = seq_printf(m, "%s: N/A\n", prefix);
        return rc;
 }
 
-static int scrub_pos_dump(char **buf, int *len, __u64 pos, const char *prefix)
+static int scrub_pos_dump(struct seq_file *m, __u64 pos, const char *prefix)
 {
        int rc;
 
        if (pos != 0)
-               rc = snprintf(*buf, *len, "%s: "LPU64"\n", prefix, pos);
+               rc = seq_printf(m, "%s: "LPU64"\n", prefix, pos);
        else
-               rc = snprintf(*buf, *len, "%s: N/A\n", prefix);
-       if (rc <= 0)
-               return -ENOSPC;
-
-       *buf += rc;
-       *len -= rc;
+               rc = seq_printf(m, "%s: N/A\n", prefix);
        return rc;
 }
 
-int osd_scrub_dump(struct osd_device *dev, char *buf, int len)
+int osd_scrub_dump(struct seq_file *m, struct osd_device *dev)
 {
        struct osd_scrub  *scrub   = &dev->od_scrub;
        struct scrub_file *sf      = &scrub->os_file;
        __u64              checked;
        __u64              speed;
-       int                save    = len;
-       int                ret     = -ENOSPC;
        int                rc;
 
        down_read(&scrub->os_rwsem);
-       rc = snprintf(buf, len,
-                     "name: OI_scrub\n"
-                     "magic: 0x%x\n"
-                     "oi_files: %d\n"
-                     "status: %s\n",
-                     sf->sf_magic, (int)sf->sf_oi_count,
-                     scrub_status_names[sf->sf_status]);
-       if (rc <= 0)
+       rc = seq_printf(m, "name: OI_scrub\n"
+                       "magic: 0x%x\n"
+                       "oi_files: %d\n"
+                       "status: %s\n",
+                       sf->sf_magic, (int)sf->sf_oi_count,
+                       scrub_status_names[sf->sf_status]);
+       if (rc < 0)
                goto out;
 
-       buf += rc;
-       len -= rc;
-       rc = scrub_bits_dump(&buf, &len, sf->sf_flags, scrub_flags_names,
+       rc = scrub_bits_dump(m, sf->sf_flags, scrub_flags_names,
                             "flags");
        if (rc < 0)
                goto out;
 
-       rc = scrub_bits_dump(&buf, &len, sf->sf_param, scrub_param_names,
+       rc = scrub_bits_dump(m, sf->sf_param, scrub_param_names,
                             "param");
        if (rc < 0)
                goto out;
 
-       rc = scrub_time_dump(&buf, &len, sf->sf_time_last_complete,
+       rc = scrub_time_dump(m, sf->sf_time_last_complete,
                             "time_since_last_completed");
        if (rc < 0)
                goto out;
 
-       rc = scrub_time_dump(&buf, &len, sf->sf_time_latest_start,
+       rc = scrub_time_dump(m, sf->sf_time_latest_start,
                             "time_since_latest_start");
        if (rc < 0)
                goto out;
 
-       rc = scrub_time_dump(&buf, &len, sf->sf_time_last_checkpoint,
+       rc = scrub_time_dump(m, sf->sf_time_last_checkpoint,
                             "time_since_last_checkpoint");
        if (rc < 0)
                goto out;
 
-       rc = scrub_pos_dump(&buf, &len, sf->sf_pos_latest_start,
+       rc = scrub_pos_dump(m, sf->sf_pos_latest_start,
                            "latest_start_position");
        if (rc < 0)
                goto out;
 
-       rc = scrub_pos_dump(&buf, &len, sf->sf_pos_last_checkpoint,
+       rc = scrub_pos_dump(m, sf->sf_pos_last_checkpoint,
                            "last_checkpoint_position");
        if (rc < 0)
                goto out;
 
-       rc = scrub_pos_dump(&buf, &len, sf->sf_pos_first_inconsistent,
+       rc = scrub_pos_dump(m, sf->sf_pos_first_inconsistent,
                            "first_failure_position");
        if (rc < 0)
                goto out;
 
        checked = sf->sf_items_checked + scrub->os_new_checked;
-       rc = snprintf(buf, len,
-                     "checked: "LPU64"\n"
+       rc = seq_printf(m, "checked: "LPU64"\n"
                      "updated: "LPU64"\n"
                      "failed: "LPU64"\n"
                      "prior_updated: "LPU64"\n"
@@ -2526,16 +2688,14 @@ int osd_scrub_dump(struct osd_device *dev, char *buf, int len)
                      checked, sf->sf_items_updated, sf->sf_items_failed,
                      sf->sf_items_updated_prior, sf->sf_items_noscrub,
                      sf->sf_items_igif, sf->sf_success_count);
-       if (rc <= 0)
+       if (rc < 0)
                goto out;
 
-       buf += rc;
-       len -= rc;
        speed = checked;
        if (thread_is_running(&scrub->os_thread)) {
                cfs_duration_t duration = cfs_time_current() -
                                          scrub->os_time_last_checkpoint;
-               __u64 new_checked = scrub->os_new_checked * CFS_HZ;
+               __u64 new_checked = scrub->os_new_checked * HZ;
                __u32 rtime = sf->sf_run_time +
                              cfs_duration_sec(duration + HALF_SEC);
 
@@ -2543,8 +2703,7 @@ int osd_scrub_dump(struct osd_device *dev, char *buf, int len)
                        do_div(new_checked, duration);
                if (rtime != 0)
                        do_div(speed, rtime);
-               rc = snprintf(buf, len,
-                             "run_time: %u seconds\n"
+               rc = seq_printf(m, "run_time: %u seconds\n"
                              "average_speed: "LPU64" objects/sec\n"
                              "real-time_speed: "LPU64" objects/sec\n"
                              "current_position: %u\n"
@@ -2557,8 +2716,7 @@ int osd_scrub_dump(struct osd_device *dev, char *buf, int len)
        } else {
                if (sf->sf_run_time != 0)
                        do_div(speed, sf->sf_run_time);
-               rc = snprintf(buf, len,
-                             "run_time: %u seconds\n"
+               rc = seq_printf(m, "run_time: %u seconds\n"
                              "average_speed: "LPU64" objects/sec\n"
                              "real-time_speed: N/A\n"
                              "current_position: N/A\n"
@@ -2568,14 +2726,8 @@ int osd_scrub_dump(struct osd_device *dev, char *buf, int len)
                              sf->sf_run_time, speed, scrub->os_lf_scanned,
                              scrub->os_lf_repaired, scrub->os_lf_failed);
        }
-       if (rc <= 0)
-               goto out;
-
-       buf += rc;
-       len -= rc;
-       ret = save - len;
 
 out:
        up_read(&scrub->os_rwsem);
-       return ret;
+       return (rc < 0 ? -ENOSPC : 0);
 }