Whamcloud - gitweb
LU-9728 osd: use GFP_HIGHUSER for non-local IO
[fs/lustre-release.git] / lustre / osd-ldiskfs / osd_io.c
index 7a802d3..56e5231 100644 (file)
@@ -421,16 +421,18 @@ static int osd_map_remote_to_local(loff_t offset, ssize_t len, int *nrpages,
         RETURN(0);
 }
 
-static struct page *osd_get_page(struct dt_object *dt, loff_t offset, int rw)
+static struct page *osd_get_page(struct dt_object *dt, loff_t offset,
+                                gfp_t gfp_mask)
 {
-        struct inode      *inode = osd_dt_obj(dt)->oo_inode;
-        struct osd_device *d = osd_obj2dev(osd_dt_obj(dt));
-        struct page       *page;
+       struct inode *inode = osd_dt_obj(dt)->oo_inode;
+       struct osd_device *d = osd_obj2dev(osd_dt_obj(dt));
+       struct page *page;
 
         LASSERT(inode);
 
        page = find_or_create_page(inode->i_mapping, offset >> PAGE_SHIFT,
-                                   GFP_NOFS | __GFP_HIGHMEM);
+                                  gfp_mask);
+
         if (unlikely(page == NULL))
                 lprocfs_counter_add(d->od_stats, LPROC_OSD_NO_PAGE, 1);
 
@@ -504,7 +506,7 @@ static int osd_bufs_put(const struct lu_env *env, struct dt_object *dt,
  * \param pos          byte offset of IO start
  * \param len          number of bytes of IO
  * \param lnb          array of extents undergoing IO
- * \param rw           read or write operation?
+ * \param rw           read or write operation, and other flags
  * \param capa         capabilities
  *
  * \retval pages       (zero or more) loaded successfully
@@ -512,17 +514,22 @@ static int osd_bufs_put(const struct lu_env *env, struct dt_object *dt,
  */
 static int osd_bufs_get(const struct lu_env *env, struct dt_object *dt,
                        loff_t pos, ssize_t len, struct niobuf_local *lnb,
-                       int rw)
+                       enum dt_bufs_type rw)
 {
-       struct osd_object   *obj    = osd_dt_obj(dt);
+       struct osd_object *obj = osd_dt_obj(dt);
        int npages, i, rc = 0;
+       gfp_t gfp_mask;
 
        LASSERT(obj->oo_inode);
 
        osd_map_remote_to_local(pos, len, &npages, lnb);
 
+       /* this could also try less hard for DT_BUFS_TYPE_READAHEAD pages */
+       gfp_mask = rw & DT_BUFS_TYPE_LOCAL ? (GFP_NOFS | __GFP_HIGHMEM) :
+                                            GFP_HIGHUSER;
        for (i = 0; i < npages; i++, lnb++) {
-               lnb->lnb_page = osd_get_page(dt, lnb->lnb_file_offset, rw);
+               lnb->lnb_page = osd_get_page(dt, lnb->lnb_file_offset,
+                                            gfp_mask);
                if (lnb->lnb_page == NULL)
                        GOTO(cleanup, rc = -ENOMEM);
 
@@ -1107,19 +1114,19 @@ static int osd_declare_write_commit(const struct lu_env *env,
                                     struct niobuf_local *lnb, int npages,
                                     struct thandle *handle)
 {
-        const struct osd_device *osd = osd_obj2dev(osd_dt_obj(dt));
-        struct inode            *inode = osd_dt_obj(dt)->oo_inode;
-        struct osd_thandle      *oh;
-        int                      extents = 1;
-        int                      depth;
-        int                      i;
-        int                      newblocks;
-       int                      rc = 0;
-       int                      flags = 0;
-       int                      credits = 0;
-       bool                     ignore_quota = false;
-       long long                quota_space = 0;
-       struct osd_fextent       extent = { 0 };
+       const struct osd_device *osd = osd_obj2dev(osd_dt_obj(dt));
+       struct inode            *inode = osd_dt_obj(dt)->oo_inode;
+       struct osd_thandle      *oh;
+       int                     extents = 1;
+       int                     depth;
+       int                     i;
+       int                     newblocks;
+       int                     rc = 0;
+       int                     flags = 0;
+       int                     credits = 0;
+       long long               quota_space = 0;
+       struct osd_fextent      extent = { 0 };
+       enum osd_qid_declare_flags declare_flags = OSD_QID_BLK;
        ENTRY;
 
         LASSERT(handle != NULL);
@@ -1149,7 +1156,7 @@ static int osd_declare_write_commit(const struct lu_env *env,
                if ((lnb[i].lnb_flags & OBD_BRW_NOQUOTA) ||
                    (lnb[i].lnb_flags & (OBD_BRW_FROM_GRANT | OBD_BRW_SYNC)) ==
                    OBD_BRW_FROM_GRANT)
-                       ignore_quota = true;
+                       declare_flags |= OSD_QID_FORCE;
        }
 
         /*
@@ -1201,7 +1208,7 @@ static int osd_declare_write_commit(const struct lu_env *env,
 
        rc = osd_declare_inode_qid(env, i_uid_read(inode), i_gid_read(inode),
                                   i_projid_read(inode), quota_space, oh,
-                                  osd_dt_obj(dt), true, &flags, ignore_quota);
+                                  osd_dt_obj(dt), &flags, declare_flags);
 
        /* we need only to store the overquota flags in the first lnb for
         * now, once we support multiple objects BRW, this code needs be
@@ -1454,8 +1461,8 @@ int osd_ldiskfs_read(struct inode *inode, void *buf, int size, loff_t *offs)
                 csize = min(blocksize - boffs, size);
                bh = __ldiskfs_bread(NULL, inode, block, 0);
                if (IS_ERR(bh)) {
-                       CERROR("%s: can't read %u@%llu on ino %lu: rc = %ld\n",
-                              LDISKFS_SB(inode->i_sb)->s_es->s_volume_name,
+                       CERROR("%s: can't read %u@%llu on ino %lu: "
+                              "rc = %ld\n", osd_ino2name(inode),
                               csize, *offs, inode->i_ino,
                               PTR_ERR(bh));
                        return PTR_ERR(bh);
@@ -1616,7 +1623,7 @@ static ssize_t osd_declare_write(const struct lu_env *env, struct dt_object *dt,
                credits = depth;
                /* if not append, then split may need to modify
                 * existing blocks moving entries into the new ones */
-               if (_pos == -1)
+               if (_pos != -1)
                        credits += depth;
                /* blocks to store data: bitmap,gd,itself */
                credits += blocks * 3;
@@ -1639,7 +1646,7 @@ out:
                rc = osd_declare_inode_qid(env, i_uid_read(inode),
                                           i_gid_read(inode),
                                           i_projid_read(inode), 0,
-                                          oh, obj, true, NULL, false);
+                                          oh, obj, NULL, OSD_QID_BLK);
        RETURN(rc);
 }
 
@@ -1680,9 +1687,12 @@ int osd_ldiskfs_write_record(struct inode *inode, void *buf, int bufsize,
                ((char *)buf)[bufsize] = '\0';
                ++bufsize;
        }
-        while (bufsize > 0) {
-                if (bh != NULL)
-                        brelse(bh);
+
+       while (bufsize > 0) {
+               int credits = handle->h_buffer_credits;
+
+               if (bh)
+                       brelse(bh);
 
                block = offset >> inode->i_blkbits;
                boffs = offset & (blocksize - 1);
@@ -1695,9 +1705,11 @@ int osd_ldiskfs_write_record(struct inode *inode, void *buf, int bufsize,
                                err = PTR_ERR(bh);
                                bh = NULL;
                        }
-                        CERROR("%s: error reading offset %llu (block %lu): "
-                               "rc = %d\n",
-                               inode->i_sb->s_id, offset, block, err);
+
+                       CERROR("%s: error reading offset %llu (block %lu, "
+                              "size %d, offs %llu), credits %d/%d: rc = %d\n",
+                              inode->i_sb->s_id, offset, block, bufsize, *offs,
+                              credits, handle->h_buffer_credits, err);
                         break;
                 }
 
@@ -1814,7 +1826,7 @@ static int osd_declare_punch(const struct lu_env *env, struct dt_object *dt,
 
        rc = osd_declare_inode_qid(env, i_uid_read(inode), i_gid_read(inode),
                                   i_projid_read(inode), 0, oh, osd_dt_obj(dt),
-                                  true, NULL, false);
+                                  NULL, OSD_QID_BLK);
        RETURN(rc);
 }