Whamcloud - gitweb
LU-9679 osc: use overlapped() consistently.
[fs/lustre-release.git] / lustre / osc / osc_cache.c
index 67e60b0..38a64d1 100644 (file)
@@ -94,11 +94,6 @@ static inline char *ext_flags(struct osc_extent *ext, char *flags)
        return flags;
 }
 
-static inline char list_empty_marker(struct list_head *list)
-{
-       return list_empty(list) ? '-' : '+';
-}
-
 #define EXTSTR       "[%lu -> %lu/%lu]"
 #define EXTPARA(ext) (ext)->oe_start, (ext)->oe_end, (ext)->oe_max_end
 static const char *oes_strings[] = {
@@ -189,8 +184,7 @@ static int osc_extent_sanity_check0(struct osc_extent *ext,
        size_t page_count;
        int rc = 0;
 
-       if (!osc_object_is_locked(obj))
-               GOTO(out, rc = 9);
+       assert_osc_object_is_locked(obj);
 
        if (ext->oe_state >= OES_STATE_MAX)
                GOTO(out, rc = 10);
@@ -286,6 +280,11 @@ out:
        __res;                                                                 \
 })
 
+static inline bool
+overlapped(const struct osc_extent *ex1, const struct osc_extent *ex2)
+{
+       return !(ex1->oe_end < ex2->oe_start || ex2->oe_end < ex1->oe_start);
+}
 
 /**
  * sanity check - to make sure there is no overlapped extent in the tree.
@@ -295,7 +294,7 @@ static int osc_extent_is_overlapped(struct osc_object *obj,
 {
        struct osc_extent *tmp;
 
-       LASSERT(osc_object_is_locked(obj));
+       assert_osc_object_is_locked(obj);
 
        if (!extent_debug)
                return 0;
@@ -303,8 +302,7 @@ static int osc_extent_is_overlapped(struct osc_object *obj,
        for (tmp = first_extent(obj); tmp != NULL; tmp = next_extent(tmp)) {
                if (tmp == ext)
                        continue;
-               if (tmp->oe_end >= ext->oe_start &&
-                   tmp->oe_start <= ext->oe_end)
+               if (overlapped(tmp, ext))
                        return 1;
        }
        return 0;
@@ -312,7 +310,7 @@ static int osc_extent_is_overlapped(struct osc_object *obj,
 
 static void osc_extent_state_set(struct osc_extent *ext, int state)
 {
-       LASSERT(osc_object_is_locked(ext->oe_obj));
+       assert_osc_object_is_locked(ext->oe_obj);
        LASSERT(state >= OES_INV && state < OES_STATE_MAX);
 
        /* Never try to sanity check a state changing extent :-) */
@@ -385,7 +383,7 @@ static void osc_extent_put(const struct lu_env *env, struct osc_extent *ext)
 static void osc_extent_put_trust(struct osc_extent *ext)
 {
        LASSERT(atomic_read(&ext->oe_refc) > 1);
-       LASSERT(osc_object_is_locked(ext->oe_obj));
+       assert_osc_object_is_locked(ext->oe_obj);
        atomic_dec(&ext->oe_refc);
 }
 
@@ -399,7 +397,7 @@ static struct osc_extent *osc_extent_search(struct osc_object *obj,
        struct rb_node    *n = obj->oo_root.rb_node;
        struct osc_extent *tmp, *p = NULL;
 
-       LASSERT(osc_object_is_locked(obj));
+       assert_osc_object_is_locked(obj);
        while (n != NULL) {
                tmp = rb_extent(n);
                if (index < tmp->oe_start) {
@@ -438,7 +436,7 @@ static void osc_extent_insert(struct osc_object *obj, struct osc_extent *ext)
 
        LASSERT(ext->oe_intree == 0);
        LASSERT(ext->oe_obj == obj);
-       LASSERT(osc_object_is_locked(obj));
+       assert_osc_object_is_locked(obj);
        while (*n != NULL) {
                tmp = rb_extent(*n);
                parent = *n;
@@ -460,7 +458,7 @@ static void osc_extent_insert(struct osc_object *obj, struct osc_extent *ext)
 static void osc_extent_erase(struct osc_extent *ext)
 {
        struct osc_object *obj = ext->oe_obj;
-       LASSERT(osc_object_is_locked(obj));
+       assert_osc_object_is_locked(obj);
        if (ext->oe_intree) {
                rb_erase(&ext->oe_node, &obj->oo_root);
                ext->oe_intree = 0;
@@ -473,7 +471,7 @@ static struct osc_extent *osc_extent_hold(struct osc_extent *ext)
 {
        struct osc_object *obj = ext->oe_obj;
 
-       LASSERT(osc_object_is_locked(obj));
+       assert_osc_object_is_locked(obj);
        LASSERT(ext->oe_state == OES_ACTIVE || ext->oe_state == OES_CACHE);
        if (ext->oe_state == OES_CACHE) {
                osc_extent_state_set(ext, OES_ACTIVE);
@@ -486,7 +484,7 @@ static struct osc_extent *osc_extent_hold(struct osc_extent *ext)
 
 static void __osc_extent_remove(struct osc_extent *ext)
 {
-       LASSERT(osc_object_is_locked(ext->oe_obj));
+       assert_osc_object_is_locked(ext->oe_obj);
        LASSERT(list_empty(&ext->oe_pages));
        osc_extent_erase(ext);
        list_del_init(&ext->oe_link);
@@ -517,7 +515,7 @@ static int osc_extent_merge(const struct lu_env *env, struct osc_extent *cur,
        int                      ppc_bits;
 
        LASSERT(cur->oe_state == OES_CACHE);
-       LASSERT(osc_object_is_locked(obj));
+       assert_osc_object_is_locked(obj);
        if (victim == NULL)
                return -EINVAL;
 
@@ -617,11 +615,6 @@ int osc_extent_release(const struct lu_env *env, struct osc_extent *ext)
        RETURN(rc);
 }
 
-static inline int overlapped(struct osc_extent *ex1, struct osc_extent *ex2)
-{
-       return !(ex1->oe_end < ex2->oe_start || ex2->oe_end < ex1->oe_start);
-}
-
 /**
  * Find or create an extent which includes @index, core function to manage
  * extent tree.
@@ -1885,7 +1878,6 @@ static void osc_ap_completion(const struct lu_env *env, struct client_obd *cli,
        spin_lock(&oap->oap_lock);
        oap->oap_async_flags = 0;
        spin_unlock(&oap->oap_lock);
-       oap->oap_interrupted = 0;
 
        if (oap->oap_cmd & OBD_BRW_WRITE && xid > 0) {
                spin_lock(&cli->cl_loi_list_lock);
@@ -1918,6 +1910,31 @@ static inline unsigned osc_extent_chunks(const struct osc_extent *ext)
        return (ext->oe_end >> ppc_bits) - (ext->oe_start >> ppc_bits) + 1;
 }
 
+static inline bool
+can_merge(const struct osc_extent *ext, const struct osc_extent *in_rpc)
+{
+       if (ext->oe_no_merge || in_rpc->oe_no_merge)
+               return false;
+
+       if (ext->oe_srvlock != in_rpc->oe_srvlock)
+               return false;
+
+       if (ext->oe_ndelay != in_rpc->oe_ndelay)
+               return false;
+
+       if (!ext->oe_grants != !in_rpc->oe_grants)
+               return false;
+
+       if (ext->oe_dio != in_rpc->oe_dio)
+               return false;
+
+       /* It's possible to have overlap on DIO */
+       if (in_rpc->oe_dio && overlapped(ext, in_rpc))
+               return false;
+
+       return true;
+}
+
 /**
  * Try to add extent to one RPC. We need to think about the following things:
  * - # of pages must not be over max_pages_per_rpc
@@ -1929,9 +1946,6 @@ static int try_to_add_extent_for_io(struct client_obd *cli,
 {
        struct osc_extent *tmp;
        unsigned int chunk_count;
-       struct osc_async_page *oap = list_first_entry(&ext->oe_pages,
-                                                     struct osc_async_page,
-                                                     oap_pending_item);
        ENTRY;
 
        EASSERT((ext->oe_state == OES_CACHE || ext->oe_state == OES_LOCK_DONE),
@@ -1960,30 +1974,10 @@ static int try_to_add_extent_for_io(struct client_obd *cli,
                RETURN(0);
 
        list_for_each_entry(tmp, data->erd_rpc_list, oe_link) {
-               struct osc_async_page *oap2;
-               oap2 = list_first_entry(&tmp->oe_pages, struct osc_async_page,
-                                       oap_pending_item);
                EASSERT(tmp->oe_owner == current, tmp);
-#if 0
-               if (overlapped(tmp, ext)) {
-                       OSC_EXTENT_DUMP(D_ERROR, tmp, "overlapped %p.\n", ext);
-                       EASSERT(0, ext);
-               }
-#endif
-               if (oap2cl_page(oap)->cp_type != oap2cl_page(oap2)->cp_type) {
-                       CDEBUG(D_CACHE, "Do not permit different types of IO "
-                              "in one RPC\n");
-                       RETURN(0);
-               }
 
-               if (tmp->oe_srvlock != ext->oe_srvlock ||
-                   !tmp->oe_grants != !ext->oe_grants ||
-                   tmp->oe_ndelay != ext->oe_ndelay ||
-                   tmp->oe_no_merge || ext->oe_no_merge)
+               if (!can_merge(ext, tmp))
                        RETURN(0);
-
-               /* remove break for strict check */
-               break;
        }
 
        data->erd_max_extents--;
@@ -2020,7 +2014,7 @@ static unsigned int get_write_extents(struct osc_object *obj,
                .erd_max_extents = 256,
        };
 
-       LASSERT(osc_object_is_locked(obj));
+       assert_osc_object_is_locked(obj);
        while (!list_empty(&obj->oo_hp_exts)) {
                ext = list_entry(obj->oo_hp_exts.next, struct osc_extent,
                                 oe_link);
@@ -2086,7 +2080,7 @@ __must_hold(osc)
        int rc = 0;
        ENTRY;
 
-       LASSERT(osc_object_is_locked(osc));
+       assert_osc_object_is_locked(osc);
 
        page_count = get_write_extents(osc, &rpclist);
        LASSERT(equi(page_count == 0, list_empty(&rpclist)));
@@ -2164,7 +2158,7 @@ __must_hold(osc)
        int rc = 0;
        ENTRY;
 
-       LASSERT(osc_object_is_locked(osc));
+       assert_osc_object_is_locked(osc);
        list_for_each_entry_safe(ext, next, &osc->oo_reading_exts, oe_link) {
                EASSERT(ext->oe_state == OES_LOCK_DONE, ext);
                if (!try_to_add_extent_for_io(cli, ext, &data))
@@ -2376,7 +2370,7 @@ int osc_queue_async_io(const struct lu_env *env, struct cl_io *io,
 
        /* Set the OBD_BRW_SRVLOCK before the page is queued. */
        brw_flags |= ops->ops_srvlock ? OBD_BRW_SRVLOCK : 0;
-       if (oio->oi_cap_sys_resource) {
+       if (oio->oi_cap_sys_resource || io->ci_noquota) {
                brw_flags |= OBD_BRW_NOQUOTA;
                cmd |= OBD_BRW_NOQUOTA;
        }
@@ -2397,7 +2391,7 @@ int osc_queue_async_io(const struct lu_env *env, struct cl_io *io,
                qid[USRQUOTA] = attr->cat_uid;
                qid[GRPQUOTA] = attr->cat_gid;
                qid[PRJQUOTA] = attr->cat_projid;
-               if (rc == 0 && osc_quota_chkdq(cli, qid) == NO_QUOTA)
+               if (rc == 0 && osc_quota_chkdq(cli, qid) == -EDQUOT)
                        rc = -EDQUOT;
                if (rc)
                        RETURN(rc);
@@ -2641,71 +2635,6 @@ out:
        return rc;
 }
 
-/**
- * this is called when a sync waiter receives an interruption.  Its job is to
- * get the caller woken as soon as possible.  If its page hasn't been put in an
- * rpc yet it can dequeue immediately.  Otherwise it has to mark the rpc as
- * desiring interruption which will forcefully complete the rpc once the rpc
- * has timed out.
- */
-int osc_cancel_async_page(const struct lu_env *env, struct osc_page *ops)
-{
-       struct osc_async_page *oap = &ops->ops_oap;
-       struct osc_object     *obj = oap->oap_obj;
-       struct client_obd     *cli = osc_cli(obj);
-       struct osc_extent     *ext;
-       struct osc_extent     *found = NULL;
-       struct list_head            *plist;
-       pgoff_t index = osc_index(ops);
-       int     rc = -EBUSY;
-       int     cmd;
-       ENTRY;
-
-       LASSERT(!oap->oap_interrupted);
-       oap->oap_interrupted = 1;
-
-       /* Find out the caching extent */
-       osc_object_lock(obj);
-       if (oap->oap_cmd & OBD_BRW_WRITE) {
-               plist = &obj->oo_urgent_exts;
-               cmd   = OBD_BRW_WRITE;
-       } else {
-               plist = &obj->oo_reading_exts;
-               cmd   = OBD_BRW_READ;
-       }
-       list_for_each_entry(ext, plist, oe_link) {
-               if (ext->oe_start <= index && ext->oe_end >= index) {
-                       LASSERT(ext->oe_state == OES_LOCK_DONE);
-                       /* For OES_LOCK_DONE state extent, it has already held
-                        * a refcount for RPC. */
-                       found = osc_extent_get(ext);
-                       break;
-               }
-       }
-       if (found != NULL) {
-               list_del_init(&found->oe_link);
-               osc_update_pending(obj, cmd, -found->oe_nr_pages);
-               osc_object_unlock(obj);
-
-               osc_extent_finish(env, found, 0, -EINTR);
-               osc_extent_put(env, found);
-               rc = 0;
-       } else {
-               osc_object_unlock(obj);
-               /* ok, it's been put in an rpc. only one oap gets a request
-                * reference */
-               if (oap->oap_request != NULL) {
-                       ptlrpc_mark_interrupted(oap->oap_request);
-                       ptlrpcd_wake(oap->oap_request);
-                       ptlrpc_req_finished(oap->oap_request);
-                       oap->oap_request = NULL;
-               }
-       }
-
-       osc_list_maint(cli, obj);
-       RETURN(rc);
-}
-
 int osc_queue_sync_pages(const struct lu_env *env, const struct cl_io *io,
                         struct osc_object *obj, struct list_head *list,
                         int brw_flags)
@@ -2755,6 +2684,7 @@ int osc_queue_sync_pages(const struct lu_env *env, const struct cl_io *io,
        ext->oe_obj = obj;
        ext->oe_srvlock = !!(brw_flags & OBD_BRW_SRVLOCK);
        ext->oe_ndelay = !!(brw_flags & OBD_BRW_NDELAY);
+       ext->oe_dio = !!(brw_flags & OBD_BRW_NOCACHE);
        ext->oe_nr_pages = page_count;
        ext->oe_mppr = mppr;
        list_splice_init(list, &ext->oe_pages);