Whamcloud - gitweb
LU-17744 ldiskfs: mballoc stats fixes
[fs/lustre-release.git] / lustre / osc / lproc_osc.c
index 2d15ebb..0bce55b 100644 (file)
@@ -27,7 +27,6 @@
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
- * Lustre is a trademark of Sun Microsystems, Inc.
  */
 #define DEBUG_SUBSYSTEM S_CLASS
 
 static ssize_t active_show(struct kobject *kobj, struct attribute *attr,
                           char *buf)
 {
-       struct obd_device *dev = container_of(kobj, struct obd_device,
+       struct obd_device *obd = container_of(kobj, struct obd_device,
                                              obd_kset.kobj);
+       struct obd_import *imp;
        int rc;
 
-       LPROCFS_CLIMP_CHECK(dev);
-       rc = sprintf(buf, "%d\n", !dev->u.cli.cl_import->imp_deactive);
-       LPROCFS_CLIMP_EXIT(dev);
+       with_imp_locked(obd, imp, rc)
+               rc = sprintf(buf, "%d\n", !imp->imp_deactive);
+
        return rc;
 }
 
 static ssize_t active_store(struct kobject *kobj, struct attribute *attr,
                            const char *buffer, size_t count)
 {
-       struct obd_device *dev = container_of(kobj, struct obd_device,
+       struct obd_device *obd = container_of(kobj, struct obd_device,
                                              obd_kset.kobj);
+       struct obd_import *imp, *imp0;
        bool val;
        int rc;
 
@@ -66,14 +67,19 @@ static ssize_t active_store(struct kobject *kobj, struct attribute *attr,
        if (rc)
                return rc;
 
+       with_imp_locked(obd, imp0, rc)
+               imp = class_import_get(imp0);
+       if (rc)
+               return rc;
        /* opposite senses */
-       if (dev->u.cli.cl_import->imp_deactive == val)
-               rc = ptlrpc_set_import_active(dev->u.cli.cl_import, val);
+       if (imp->imp_deactive == val)
+               rc = ptlrpc_set_import_active(imp, val);
        else
                CDEBUG(D_CONFIG, "activate %u: ignoring repeat request\n",
                       (unsigned int)val);
+       class_import_put(imp);
 
-       return count;
+       return rc ?: count;
 }
 LUSTRE_RW_ATTR(active);
 
@@ -81,15 +87,11 @@ static ssize_t max_rpcs_in_flight_show(struct kobject *kobj,
                                       struct attribute *attr,
                                       char *buf)
 {
-       struct obd_device *dev = container_of(kobj, struct obd_device,
+       struct obd_device *obd = container_of(kobj, struct obd_device,
                                              obd_kset.kobj);
-       struct client_obd *cli = &dev->u.cli;
-       ssize_t len;
+       struct client_obd *cli = &obd->u.cli;
 
-       spin_lock(&cli->cl_loi_list_lock);
-       len = sprintf(buf, "%u\n", cli->cl_max_rpcs_in_flight);
-       spin_unlock(&cli->cl_loi_list_lock);
-       return len;
+       return  scnprintf(buf, PAGE_SIZE, "%u\n", cli->cl_max_rpcs_in_flight);
 }
 
 static ssize_t max_rpcs_in_flight_store(struct kobject *kobj,
@@ -97,9 +99,9 @@ static ssize_t max_rpcs_in_flight_store(struct kobject *kobj,
                                        const char *buffer,
                                        size_t count)
 {
-       struct obd_device *dev = container_of(kobj, struct obd_device,
+       struct obd_device *obd = container_of(kobj, struct obd_device,
                                              obd_kset.kobj);
-       struct client_obd *cli = &dev->u.cli;
+       struct client_obd *cli = &obd->u.cli;
        int adding, added, req_count;
        unsigned int val;
        int rc;
@@ -111,8 +113,6 @@ static ssize_t max_rpcs_in_flight_store(struct kobject *kobj,
        if (val == 0 || val > OSC_MAX_RIF_MAX)
                return -ERANGE;
 
-       LPROCFS_CLIMP_CHECK(dev);
-
        adding = (int)val - cli->cl_max_rpcs_in_flight;
        req_count = atomic_read(&osc_pool_req_count);
        if (adding > 0 && req_count < osc_reqpool_maxreqcount) {
@@ -132,7 +132,6 @@ static ssize_t max_rpcs_in_flight_store(struct kobject *kobj,
        client_adjust_max_dirty(cli);
        spin_unlock(&cli->cl_loi_list_lock);
 
-       LPROCFS_CLIMP_EXIT(dev);
        return count;
 }
 LUSTRE_RW_ATTR(max_rpcs_in_flight);
@@ -141,16 +140,12 @@ static ssize_t max_dirty_mb_show(struct kobject *kobj,
                                 struct attribute *attr,
                                 char *buf)
 {
-       struct obd_device *dev = container_of(kobj, struct obd_device,
+       struct obd_device *obd = container_of(kobj, struct obd_device,
                                              obd_kset.kobj);
-       struct client_obd *cli = &dev->u.cli;
-       unsigned long val;
-
-       spin_lock(&cli->cl_loi_list_lock);
-       val = PAGES_TO_MiB(cli->cl_dirty_max_pages);
-       spin_unlock(&cli->cl_loi_list_lock);
+       struct client_obd *cli = &obd->u.cli;
 
-       return sprintf(buf, "%lu\n", val);
+       return scnprintf(buf, PAGE_SIZE, "%lu\n",
+                        PAGES_TO_MiB(cli->cl_dirty_max_pages));
 }
 
 static ssize_t max_dirty_mb_store(struct kobject *kobj,
@@ -158,9 +153,9 @@ static ssize_t max_dirty_mb_store(struct kobject *kobj,
                                  const char *buffer,
                                  size_t count)
 {
-       struct obd_device *dev = container_of(kobj, struct obd_device,
+       struct obd_device *obd = container_of(kobj, struct obd_device,
                                              obd_kset.kobj);
-       struct client_obd *cli = &dev->u.cli;
+       struct client_obd *cli = &obd->u.cli;
        unsigned long pages_number, max_dirty_mb;
        int rc;
 
@@ -190,8 +185,8 @@ LUSTRE_RW_ATTR(ping);
 
 static int osc_cached_mb_seq_show(struct seq_file *m, void *v)
 {
-       struct obd_device *dev = m->private;
-       struct client_obd *cli = &dev->u.cli;
+       struct obd_device *obd = m->private;
+       struct client_obd *cli = &obd->u.cli;
        int shift = 20 - PAGE_SHIFT;
 
        seq_printf(m, "used_mb: %ld\n"
@@ -210,9 +205,11 @@ static ssize_t osc_cached_mb_seq_write(struct file *file,
                                       const char __user *buffer,
                                       size_t count, loff_t *off)
 {
-       struct obd_device *dev = ((struct seq_file *)file->private_data)->private;
-       struct client_obd *cli = &dev->u.cli;
-       __s64 pages_number;
+       struct seq_file *m = file->private_data;
+       struct obd_device *obd = m->private;
+       struct client_obd *cli = &obd->u.cli;
+       u64 pages_number;
+       const char *tmp;
        long rc;
        char kernbuf[128];
 
@@ -223,17 +220,13 @@ static ssize_t osc_cached_mb_seq_write(struct file *file,
                return -EFAULT;
        kernbuf[count] = 0;
 
-       buffer += lprocfs_find_named_value(kernbuf, "used_mb:", &count) -
-                 kernbuf;
-       rc = lprocfs_str_with_units_to_s64(buffer, count, &pages_number, 'M');
-       if (rc)
+       tmp = lprocfs_find_named_value(kernbuf, "used_mb:", &count);
+       rc = sysfs_memparse(tmp, count, &pages_number, "MiB");
+       if (rc < 0)
                return rc;
 
        pages_number >>= PAGE_SHIFT;
 
-       if (pages_number < 0)
-               return -ERANGE;
-
        rc = atomic_long_read(&cli->cl_lru_in_list) - pages_number;
        if (rc > 0) {
                struct lu_env *env;
@@ -255,27 +248,21 @@ static ssize_t cur_dirty_bytes_show(struct kobject *kobj,
                                    struct attribute *attr,
                                    char *buf)
 {
-       struct obd_device *dev = container_of(kobj, struct obd_device,
+       struct obd_device *obd = container_of(kobj, struct obd_device,
                                              obd_kset.kobj);
-       struct client_obd *cli = &dev->u.cli;
-       ssize_t len;
-
-       spin_lock(&cli->cl_loi_list_lock);
-       len = sprintf(buf, "%lu\n", cli->cl_dirty_pages << PAGE_SHIFT);
-       spin_unlock(&cli->cl_loi_list_lock);
+       struct client_obd *cli = &obd->u.cli;
 
-       return len;
+       return scnprintf(buf, PAGE_SIZE, "%lu\n",
+                        cli->cl_dirty_pages << PAGE_SHIFT);
 }
 LUSTRE_RO_ATTR(cur_dirty_bytes);
 
 static int osc_cur_grant_bytes_seq_show(struct seq_file *m, void *v)
 {
-       struct obd_device *dev = m->private;
-       struct client_obd *cli = &dev->u.cli;
+       struct obd_device *obd = m->private;
+       struct client_obd *cli = &obd->u.cli;
 
-       spin_lock(&cli->cl_loi_list_lock);
        seq_printf(m, "%lu\n", cli->cl_avail_grant);
-       spin_unlock(&cli->cl_loi_list_lock);
        return 0;
 }
 
@@ -283,33 +270,35 @@ static ssize_t osc_cur_grant_bytes_seq_write(struct file *file,
                                             const char __user *buffer,
                                             size_t count, loff_t *off)
 {
-       struct obd_device *obd = ((struct seq_file *)file->private_data)->private;
+       struct seq_file *m = file->private_data;
+       struct obd_device *obd = m->private;
        struct client_obd *cli = &obd->u.cli;
-       s64 val;
+       struct obd_import *imp;
+       char kernbuf[22] = "";
+       u64 val;
        int rc;
 
        if (obd == NULL)
                return 0;
 
-       rc = lprocfs_str_with_units_to_s64(buffer, count, &val, '1');
-       if (rc)
+       if (count >= sizeof(kernbuf))
+               return -EINVAL;
+
+       if (copy_from_user(kernbuf, buffer, count))
+               return -EFAULT;
+       kernbuf[count] = 0;
+
+       rc = sysfs_memparse(kernbuf, count, &val, "MiB");
+       if (rc < 0)
                return rc;
-       if (val < 0)
-               return val;
 
        /* this is only for shrinking grant */
-       spin_lock(&cli->cl_loi_list_lock);
-       if (val >= cli->cl_avail_grant) {
-               spin_unlock(&cli->cl_loi_list_lock);
+       if (val >= cli->cl_avail_grant)
                return 0;
-       }
 
-       spin_unlock(&cli->cl_loi_list_lock);
-
-       LPROCFS_CLIMP_CHECK(obd);
-       if (cli->cl_import->imp_state == LUSTRE_IMP_FULL)
-               rc = osc_shrink_grant_to_target(cli, val);
-       LPROCFS_CLIMP_EXIT(obd);
+       with_imp_locked(obd, imp, rc)
+               if (imp->imp_state == LUSTRE_IMP_FULL)
+                       rc = osc_shrink_grant_to_target(cli, val);
 
        return rc ? rc : count;
 }
@@ -319,18 +308,26 @@ static ssize_t cur_lost_grant_bytes_show(struct kobject *kobj,
                                         struct attribute *attr,
                                         char *buf)
 {
-       struct obd_device *dev = container_of(kobj, struct obd_device,
+       struct obd_device *obd = container_of(kobj, struct obd_device,
                                              obd_kset.kobj);
-       struct client_obd *cli = &dev->u.cli;
-       ssize_t len;
+       struct client_obd *cli = &obd->u.cli;
 
-       spin_lock(&cli->cl_loi_list_lock);
-       len = sprintf(buf, "%lu\n", cli->cl_lost_grant);
-       spin_unlock(&cli->cl_loi_list_lock);
-       return len;
+       return scnprintf(buf, PAGE_SIZE, "%lu\n", cli->cl_lost_grant);
 }
 LUSTRE_RO_ATTR(cur_lost_grant_bytes);
 
+static ssize_t cur_dirty_grant_bytes_show(struct kobject *kobj,
+                                         struct attribute *attr,
+                                         char *buf)
+{
+       struct obd_device *obd = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+       struct client_obd *cli = &obd->u.cli;
+
+       return scnprintf(buf, PAGE_SIZE, "%lu\n", cli->cl_dirty_grant);
+}
+LUSTRE_RO_ATTR(cur_dirty_grant_bytes);
+
 static ssize_t grant_shrink_interval_show(struct kobject *kobj,
                                          struct attribute *attr,
                                          char *buf)
@@ -366,6 +363,30 @@ static ssize_t grant_shrink_interval_store(struct kobject *kobj,
 }
 LUSTRE_RW_ATTR(grant_shrink_interval);
 
+static ssize_t enable_page_cache_shrink_show(struct kobject *kobj,
+                                            struct attribute *attr,
+                                            char *buf)
+{
+       return scnprintf(buf, PAGE_SIZE, "%d\n", osc_page_cache_shrink_enabled);
+}
+
+static ssize_t enable_page_cache_shrink_store(struct kobject *kobj,
+                                             struct attribute *attr,
+                                             const char *buffer,
+                                             size_t count)
+{
+       bool val;
+       int rc;
+
+       rc = kstrtobool(buffer, &val);
+       if (rc)
+               return rc;
+
+       osc_page_cache_shrink_enabled = val;
+       return count;
+}
+LUSTRE_RW_ATTR(enable_page_cache_shrink);
+
 static ssize_t checksums_show(struct kobject *kobj,
                              struct attribute *attr,
                              char *buf)
@@ -373,7 +394,7 @@ static ssize_t checksums_show(struct kobject *kobj,
        struct obd_device *obd = container_of(kobj, struct obd_device,
                                              obd_kset.kobj);
 
-       return sprintf(buf, "%d\n", obd->u.cli.cl_checksum ? 1 : 0);
+       return scnprintf(buf, PAGE_SIZE, "%d\n", !!obd->u.cli.cl_checksum);
 }
 
 static ssize_t checksums_store(struct kobject *kobj,
@@ -396,24 +417,26 @@ static ssize_t checksums_store(struct kobject *kobj,
 }
 LUSTRE_RW_ATTR(checksums);
 
+DECLARE_CKSUM_NAME;
+
 static int osc_checksum_type_seq_show(struct seq_file *m, void *v)
 {
        struct obd_device *obd = m->private;
        int i;
-       DECLARE_CKSUM_NAME;
 
-        if (obd == NULL)
-                return 0;
+       if (obd == NULL)
+               return 0;
 
        for (i = 0; i < ARRAY_SIZE(cksum_name); i++) {
-               if (((1 << i) & obd->u.cli.cl_supp_cksum_types) == 0)
+               if ((BIT(i) & obd->u.cli.cl_supp_cksum_types) == 0)
                        continue;
-               if (obd->u.cli.cl_cksum_type == (1 << i))
+               if (obd->u.cli.cl_cksum_type == BIT(i))
                        seq_printf(m, "[%s] ", cksum_name[i]);
                else
                        seq_printf(m, "%s ", cksum_name[i]);
        }
-       seq_printf(m, "\n");
+       seq_puts(m, "\n");
+
        return 0;
 }
 
@@ -421,11 +444,11 @@ static ssize_t osc_checksum_type_seq_write(struct file *file,
                                           const char __user *buffer,
                                           size_t count, loff_t *off)
 {
-       struct obd_device *obd = ((struct seq_file *)file->private_data)->private;
-       int i;
-       DECLARE_CKSUM_NAME;
+       struct seq_file *m = file->private_data;
+       struct obd_device *obd = m->private;
        char kernbuf[10];
        int rc = -EINVAL;
+       int i;
 
        if (obd == NULL)
                return 0;
@@ -441,13 +464,13 @@ static ssize_t osc_checksum_type_seq_write(struct file *file,
                kernbuf[count] = '\0';
 
        for (i = 0; i < ARRAY_SIZE(cksum_name); i++) {
-               if (strcmp(kernbuf, cksum_name[i]) == 0) {
+               if (strcasecmp(kernbuf, cksum_name[i]) == 0) {
                        obd->u.cli.cl_preferred_cksum_type = BIT(i);
                        if (obd->u.cli.cl_supp_cksum_types & BIT(i)) {
                                obd->u.cli.cl_cksum_type = BIT(i);
                                rc = count;
                        } else {
-                               rc = -ENOTSUPP;
+                               rc = -EOPNOTSUPP;
                        }
                        break;
                }
@@ -493,7 +516,7 @@ static ssize_t checksum_dump_show(struct kobject *kobj,
        struct obd_device *obd = container_of(kobj, struct obd_device,
                                              obd_kset.kobj);
 
-       return sprintf(buf, "%d\n", obd->u.cli.cl_checksum_dump ? 1 : 0);
+       return scnprintf(buf, PAGE_SIZE, "%d\n", !!obd->u.cli.cl_checksum_dump);
 }
 
 static ssize_t checksum_dump_store(struct kobject *kobj,
@@ -516,70 +539,6 @@ static ssize_t checksum_dump_store(struct kobject *kobj,
 }
 LUSTRE_RW_ATTR(checksum_dump);
 
-static ssize_t contention_seconds_show(struct kobject *kobj,
-                                      struct attribute *attr,
-                                      char *buf)
-{
-       struct obd_device *obd = container_of(kobj, struct obd_device,
-                                             obd_kset.kobj);
-       struct osc_device *od = obd2osc_dev(obd);
-
-       return sprintf(buf, "%lld\n", od->od_contention_time);
-}
-
-static ssize_t contention_seconds_store(struct kobject *kobj,
-                                       struct attribute *attr,
-                                       const char *buffer,
-                                       size_t count)
-{
-       struct obd_device *obd = container_of(kobj, struct obd_device,
-                                             obd_kset.kobj);
-       struct osc_device *od = obd2osc_dev(obd);
-       unsigned int val;
-       int rc;
-
-       rc = kstrtouint(buffer, 0, &val);
-       if (rc)
-               return rc;
-
-       od->od_contention_time = val;
-
-       return count;
-}
-LUSTRE_RW_ATTR(contention_seconds);
-
-static ssize_t lockless_truncate_show(struct kobject *kobj,
-                                     struct attribute *attr,
-                                     char *buf)
-{
-       struct obd_device *obd = container_of(kobj, struct obd_device,
-                                             obd_kset.kobj);
-       struct osc_device *od = obd2osc_dev(obd);
-
-       return sprintf(buf, "%u\n", od->od_lockless_truncate);
-}
-
-static ssize_t lockless_truncate_store(struct kobject *kobj,
-                                      struct attribute *attr,
-                                      const char *buffer,
-                                      size_t count)
-{
-       struct obd_device *obd = container_of(kobj, struct obd_device,
-                                             obd_kset.kobj);
-       struct osc_device *od = obd2osc_dev(obd);
-       bool val;
-       int rc;
-
-       rc = kstrtobool(buffer, &val);
-       if (rc)
-               return rc;
-
-       od->od_lockless_truncate = val;
-
-       return count;
-}
-LUSTRE_RW_ATTR(lockless_truncate);
-
 static ssize_t destroys_in_flight_show(struct kobject *kobj,
                                       struct attribute *attr,
                                       char *buf)
@@ -599,8 +558,8 @@ LUSTRE_RW_ATTR(short_io_bytes);
 #ifdef CONFIG_PROC_FS
 static int osc_unstable_stats_seq_show(struct seq_file *m, void *v)
 {
-       struct obd_device *dev = m->private;
-       struct client_obd *cli = &dev->u.cli;
+       struct obd_device *obd = m->private;
+       struct client_obd *cli = &obd->u.cli;
        long pages;
        int mb;
 
@@ -619,12 +578,11 @@ static ssize_t idle_timeout_show(struct kobject *kobj, struct attribute *attr,
 {
        struct obd_device *obd = container_of(kobj, struct obd_device,
                                              obd_kset.kobj);
-       struct client_obd *cli = &obd->u.cli;
+       struct obd_import *imp;
        int ret;
 
-       LPROCFS_CLIMP_CHECK(obd);
-       ret = sprintf(buf, "%u\n", cli->cl_import->imp_idle_timeout);
-       LPROCFS_CLIMP_EXIT(obd);
+       with_imp_locked(obd, imp, ret)
+               ret = sprintf(buf, "%u\n", imp->imp_idle_timeout);
 
        return ret;
 }
@@ -632,9 +590,9 @@ static ssize_t idle_timeout_show(struct kobject *kobj, struct attribute *attr,
 static ssize_t idle_timeout_store(struct kobject *kobj, struct attribute *attr,
                                  const char *buffer, size_t count)
 {
-       struct obd_device *dev = container_of(kobj, struct obd_device,
+       struct obd_device *obd = container_of(kobj, struct obd_device,
                                              obd_kset.kobj);
-       struct client_obd *cli = &dev->u.cli;
+       struct obd_import *imp;
        struct ptlrpc_request *req;
        unsigned int idle_debug = 0;
        unsigned int val;
@@ -653,20 +611,20 @@ static ssize_t idle_timeout_store(struct kobject *kobj, struct attribute *attr,
                        return -ERANGE;
        }
 
-       LPROCFS_CLIMP_CHECK(dev);
-       if (idle_debug) {
-               cli->cl_import->imp_idle_debug = idle_debug;
-       } else {
-               if (!val) {
-                       /* initiate the connection if it's in IDLE state */
-                       req = ptlrpc_request_alloc(cli->cl_import,
-                                                  &RQF_OST_STATFS);
-                       if (req != NULL)
-                               ptlrpc_req_finished(req);
+       with_imp_locked(obd, imp, rc) {
+               if (idle_debug) {
+                       imp->imp_idle_debug = idle_debug;
+               } else {
+                       if (!val) {
+                               /* initiate the connection if it's in IDLE state */
+                               req = ptlrpc_request_alloc(imp,
+                                                          &RQF_OST_STATFS);
+                               if (req != NULL)
+                                       ptlrpc_req_finished(req);
+                       }
+                       imp->imp_idle_timeout = val;
                }
-               cli->cl_import->imp_idle_timeout = val;
        }
-       LPROCFS_CLIMP_EXIT(dev);
 
        return count;
 }
@@ -675,20 +633,21 @@ LUSTRE_RW_ATTR(idle_timeout);
 static ssize_t idle_connect_store(struct kobject *kobj, struct attribute *attr,
                                  const char *buffer, size_t count)
 {
-       struct obd_device *dev = container_of(kobj, struct obd_device,
+       struct obd_device *obd = container_of(kobj, struct obd_device,
                                              obd_kset.kobj);
-       struct client_obd *cli = &dev->u.cli;
+       struct obd_import *imp;
        struct ptlrpc_request *req;
+       int rc;
 
-       LPROCFS_CLIMP_CHECK(dev);
-       /* to initiate the connection if it's in IDLE state */
-       req = ptlrpc_request_alloc(cli->cl_import, &RQF_OST_STATFS);
-       if (req)
-               ptlrpc_req_finished(req);
-       ptlrpc_pinger_force(cli->cl_import);
-       LPROCFS_CLIMP_EXIT(dev);
+       with_imp_locked(obd, imp, rc) {
+               /* to initiate the connection if it's in IDLE state */
+               req = ptlrpc_request_alloc(imp, &RQF_OST_STATFS);
+               if (req)
+                       ptlrpc_req_finished(req);
+               ptlrpc_pinger_force(imp);
+       }
 
-       return count;
+       return rc ?: count;
 }
 LUSTRE_WO_ATTR(idle_connect);
 
@@ -700,12 +659,11 @@ static ssize_t grant_shrink_show(struct kobject *kobj, struct attribute *attr,
        struct obd_import *imp;
        ssize_t len;
 
-       LPROCFS_CLIMP_CHECK(obd);
-       imp = obd->u.cli.cl_import;
-       len = snprintf(buf, PAGE_SIZE, "%d\n",
-                      !imp->imp_grant_shrink_disabled &&
-                      OCD_HAS_FLAG(&imp->imp_connect_data, GRANT_SHRINK));
-       LPROCFS_CLIMP_EXIT(obd);
+       with_imp_locked(obd, imp, len)
+               len = scnprintf(buf, PAGE_SIZE, "%d\n",
+                               !imp->imp_grant_shrink_disabled &&
+                               OCD_HAS_FLAG(&imp->imp_connect_data,
+                                            GRANT_SHRINK));
 
        return len;
 }
@@ -713,29 +671,26 @@ static ssize_t grant_shrink_show(struct kobject *kobj, struct attribute *attr,
 static ssize_t grant_shrink_store(struct kobject *kobj, struct attribute *attr,
                                  const char *buffer, size_t count)
 {
-       struct obd_device *dev = container_of(kobj, struct obd_device,
+       struct obd_device *obd = container_of(kobj, struct obd_device,
                                              obd_kset.kobj);
        struct obd_import *imp;
        bool val;
        int rc;
 
-       if (dev == NULL)
+       if (obd == NULL)
                return 0;
 
        rc = kstrtobool(buffer, &val);
        if (rc)
                return rc;
 
-       LPROCFS_CLIMP_CHECK(dev);
-
-       imp = dev->u.cli.cl_import;
-       spin_lock(&imp->imp_lock);
-       imp->imp_grant_shrink_disabled = !val;
-       spin_unlock(&imp->imp_lock);
-
-       LPROCFS_CLIMP_EXIT(dev);
+       with_imp_locked(obd, imp, rc) {
+               spin_lock(&imp->imp_lock);
+               imp->imp_grant_shrink_disabled = !val;
+               spin_unlock(&imp->imp_lock);
+       }
 
-       return count;
+       return rc ?: count;
 }
 LUSTRE_RW_ATTR(grant_shrink);
 
@@ -775,18 +730,15 @@ struct lprocfs_vars lprocfs_osc_obd_vars[] = {
 
 static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
 {
-       struct timespec64 now;
-       struct obd_device *dev = seq->private;
-       struct client_obd *cli = &dev->u.cli;
+       struct obd_device *obd = seq->private;
+       struct client_obd *cli = &obd->u.cli;
        unsigned long read_tot = 0, write_tot = 0, read_cum, write_cum;
        int i;
 
-       ktime_get_real_ts64(&now);
-
        spin_lock(&cli->cl_loi_list_lock);
 
-       seq_printf(seq, "snapshot_time:         %lld.%09lu (secs.nsecs)\n",
-                  (s64)now.tv_sec, now.tv_nsec);
+       lprocfs_stats_header(seq, ktime_get_real(), cli->cl_stats_init, 25,
+                            ":", true, "");
        seq_printf(seq, "read RPCs in flight:  %d\n",
                   cli->cl_r_in_flight);
        seq_printf(seq, "write RPCs in flight: %d\n",
@@ -829,7 +781,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
 
         read_cum = 0;
         write_cum = 0;
-        for (i = 0; i < OBD_HIST_MAX; i++) {
+        for (i = 1; i < OBD_HIST_MAX; i++) {
                 unsigned long r = cli->cl_read_rpc_hist.oh_buckets[i];
                 unsigned long w = cli->cl_write_rpc_hist.oh_buckets[i];
                 read_cum += r;
@@ -872,39 +824,35 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
 
 static ssize_t osc_rpc_stats_seq_write(struct file *file,
                                       const char __user *buf,
-                                       size_t len, loff_t *off)
+                                      size_t len, loff_t *off)
 {
-        struct seq_file *seq = file->private_data;
-        struct obd_device *dev = seq->private;
-        struct client_obd *cli = &dev->u.cli;
+       struct seq_file *seq = file->private_data;
+       struct obd_device *obd = seq->private;
+       struct client_obd *cli = &obd->u.cli;
 
-        lprocfs_oh_clear(&cli->cl_read_rpc_hist);
-        lprocfs_oh_clear(&cli->cl_write_rpc_hist);
-        lprocfs_oh_clear(&cli->cl_read_page_hist);
-        lprocfs_oh_clear(&cli->cl_write_page_hist);
-        lprocfs_oh_clear(&cli->cl_read_offset_hist);
-        lprocfs_oh_clear(&cli->cl_write_offset_hist);
+       lprocfs_oh_clear(&cli->cl_read_rpc_hist);
+       lprocfs_oh_clear(&cli->cl_write_rpc_hist);
+       lprocfs_oh_clear(&cli->cl_read_page_hist);
+       lprocfs_oh_clear(&cli->cl_write_page_hist);
+       lprocfs_oh_clear(&cli->cl_read_offset_hist);
+       lprocfs_oh_clear(&cli->cl_write_offset_hist);
+       cli->cl_stats_init = ktime_get_real();
 
-        return len;
+       return len;
 }
 LPROC_SEQ_FOPS(osc_rpc_stats);
 
 static int osc_stats_seq_show(struct seq_file *seq, void *v)
 {
-       struct timespec64 now;
-       struct obd_device *dev = seq->private;
-       struct osc_stats *stats = &obd2osc_dev(dev)->od_stats;
+       struct obd_device *obd = seq->private;
+       struct osc_stats *stats = &obd2osc_dev(obd)->osc_stats;
 
-       ktime_get_real_ts64(&now);
-
-       seq_printf(seq, "snapshot_time:         %lld.%09lu (secs.nsecs)\n",
-                  (s64)now.tv_sec, now.tv_nsec);
+       lprocfs_stats_header(seq, ktime_get_real(), stats->os_init, 25, ":",
+                            true, "");
        seq_printf(seq, "lockless_write_bytes\t\t%llu\n",
                   stats->os_lockless_writes);
        seq_printf(seq, "lockless_read_bytes\t\t%llu\n",
                   stats->os_lockless_reads);
-       seq_printf(seq, "lockless_truncate\t\t%llu\n",
-                  stats->os_lockless_truncates);
        return 0;
 }
 
@@ -912,40 +860,47 @@ static ssize_t osc_stats_seq_write(struct file *file,
                                   const char __user *buf,
                                    size_t len, loff_t *off)
 {
-        struct seq_file *seq = file->private_data;
-        struct obd_device *dev = seq->private;
-        struct osc_stats *stats = &obd2osc_dev(dev)->od_stats;
+       struct seq_file *seq = file->private_data;
+       struct obd_device *obd = seq->private;
+       struct osc_stats *stats = &obd2osc_dev(obd)->osc_stats;
+
+       memset(stats, 0, sizeof(*stats));
+       stats->os_init = ktime_get_real();
 
-        memset(stats, 0, sizeof(*stats));
-        return len;
+       return len;
 }
 
 LPROC_SEQ_FOPS(osc_stats);
 
-int lprocfs_osc_attach_seqstat(struct obd_device *dev)
+static int lprocfs_osc_attach_seqstat(struct obd_device *obd)
 {
        int rc;
 
-       rc = lprocfs_seq_create(dev->obd_proc_entry, "osc_stats", 0644,
-                               &osc_stats_fops, dev);
+       rc = lprocfs_seq_create(obd->obd_proc_entry, "osc_stats", 0644,
+                               &osc_stats_fops, obd);
        if (rc == 0)
-               rc = lprocfs_obd_seq_create(dev, "rpc_stats", 0644,
-                                           &osc_rpc_stats_fops, dev);
+               rc = lprocfs_obd_seq_create(obd, "rpc_stats", 0644,
+                                           &osc_rpc_stats_fops, obd);
 
        return rc;
 }
 #endif /* CONFIG_PROC_FS */
 
+LUSTRE_OBD_UINT_PARAM_ATTR(at_min);
+LUSTRE_OBD_UINT_PARAM_ATTR(at_max);
+LUSTRE_OBD_UINT_PARAM_ATTR(at_history);
+LUSTRE_OBD_UINT_PARAM_ATTR(ldlm_enqueue_min);
+
 static struct attribute *osc_attrs[] = {
        &lustre_attr_active.attr,
+       &lustre_attr_enable_page_cache_shrink.attr,
        &lustre_attr_checksums.attr,
        &lustre_attr_checksum_dump.attr,
-       &lustre_attr_contention_seconds.attr,
        &lustre_attr_cur_dirty_bytes.attr,
        &lustre_attr_cur_lost_grant_bytes.attr,
+       &lustre_attr_cur_dirty_grant_bytes.attr,
        &lustre_attr_destroys_in_flight.attr,
        &lustre_attr_grant_shrink_interval.attr,
-       &lustre_attr_lockless_truncate.attr,
        &lustre_attr_max_dirty_mb.attr,
        &lustre_attr_max_rpcs_in_flight.attr,
        &lustre_attr_short_io_bytes.attr,
@@ -956,15 +911,21 @@ static struct attribute *osc_attrs[] = {
        &lustre_attr_idle_timeout.attr,
        &lustre_attr_idle_connect.attr,
        &lustre_attr_grant_shrink.attr,
+       &lustre_attr_at_max.attr,
+       &lustre_attr_at_min.attr,
+       &lustre_attr_at_history.attr,
+       &lustre_attr_ldlm_enqueue_min.attr,
        NULL,
 };
 
+KOBJ_ATTRIBUTE_GROUPS(osc); /* creates osc_groups */
+
 int osc_tunables_init(struct obd_device *obd)
 {
        int rc;
 
        obd->obd_vars = lprocfs_osc_obd_vars;
-       obd->obd_ktype.default_attrs = osc_attrs;
+       obd->obd_ktype.default_groups = KOBJ_ATTR_GROUPS(osc);
        rc = lprocfs_obd_setup(obd, false);
        if (rc)
                return rc;