Whamcloud - gitweb
LU-3569 ofd: packing ost_idx in IDIF
[fs/lustre-release.git] / lustre / ofd / ofd_obd.c
index ba5ff4d..599d9f5 100644 (file)
@@ -27,7 +27,7 @@
  * Copyright (c) 2009, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
  *
- * Copyright (c) 2012, Intel Corporation.
+ * Copyright (c) 2012, 2013, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
@@ -46,6 +46,7 @@
 #include "ofd_internal.h"
 #include <obd_cksum.h>
 #include <lustre_quota.h>
+#include <lustre_lfsck.h>
 
 static int ofd_export_stats_init(struct ofd_device *ofd,
                                 struct obd_export *exp, void *client_nid)
@@ -57,6 +58,8 @@ static int ofd_export_stats_init(struct ofd_device *ofd,
 
        ENTRY;
 
+       LASSERT(obd->obd_uses_nid_stats);
+
        if (obd_uuid_equals(&exp->exp_client_uuid, &obd->obd_uuid))
                /* Self-export gets no proc entry */
                RETURN(0);
@@ -76,20 +79,15 @@ static int ofd_export_stats_init(struct ofd_device *ofd,
        stats = exp->exp_nid_stats;
        LASSERT(stats != NULL);
 
-       num_stats = (sizeof(*obd->obd_type->typ_dt_ops) / sizeof(void *)) +
-                    LPROC_OFD_LAST - 1;
+       num_stats = NUM_OBD_STATS + LPROC_OFD_STATS_LAST;
 
        stats->nid_stats = lprocfs_alloc_stats(num_stats,
                                               LPROCFS_STATS_FLAG_NOPERCPU);
        if (stats->nid_stats == NULL)
                return -ENOMEM;
 
-       lprocfs_init_ops_stats(LPROC_OFD_LAST, stats->nid_stats);
-       lprocfs_counter_init(stats->nid_stats, LPROC_OFD_READ_BYTES,
-                            LPROCFS_CNTR_AVGMINMAX, "read_bytes", "bytes");
-       lprocfs_counter_init(stats->nid_stats, LPROC_OFD_WRITE_BYTES,
-                            LPROCFS_CNTR_AVGMINMAX, "write_bytes", "bytes");
-
+       lprocfs_init_ops_stats(LPROC_OFD_STATS_LAST, stats->nid_stats);
+       ofd_stats_counter_init(stats->nid_stats);
        rc = lprocfs_register_stats(stats->nid_proc, "stats",
                                    stats->nid_stats);
        if (rc)
@@ -108,7 +106,8 @@ clean:
 
 static int ofd_parse_connect_data(const struct lu_env *env,
                                  struct obd_export *exp,
-                                 struct obd_connect_data *data)
+                                 struct obd_connect_data *data,
+                                 bool new_connection)
 {
        struct ofd_device                *ofd = ofd_exp(exp);
        struct filter_export_data        *fed = &exp->exp_filter_data;
@@ -135,7 +134,6 @@ static int ofd_parse_connect_data(const struct lu_env *env,
        fed->fed_group = data->ocd_group;
 
        data->ocd_connect_flags &= OST_CONNECT_SUPPORTED;
-       exp->exp_connect_data = *data;
        data->ocd_version = LUSTRE_VERSION_CODE;
 
        /* Kindly make sure the SKIP_ORPHAN flag is from MDS. */
@@ -154,8 +152,9 @@ static int ofd_parse_connect_data(const struct lu_env *env,
                data->ocd_grant_extent = ofd->ofd_dt_conf.ddp_grant_frag >> 10;
        }
 
-       if (exp_connect_flags(exp) & OBD_CONNECT_GRANT)
-               data->ocd_grant = ofd_grant_connect(env, exp, data->ocd_grant);
+       if (data->ocd_connect_flags & OBD_CONNECT_GRANT)
+               data->ocd_grant = ofd_grant_connect(env, exp, data->ocd_grant,
+                                                   new_connection);
 
        if (data->ocd_connect_flags & OBD_CONNECT_INDEX) {
                struct lr_server_data *lsd = &ofd->ofd_lut.lut_lsd;
@@ -253,14 +252,7 @@ static int ofd_obd_reconnect(const struct lu_env *env, struct obd_export *exp,
 
        ofd = ofd_dev(obd->obd_lu_dev);
 
-       rc = lu_env_refill((struct lu_env *)env);
-       if (rc != 0) {
-               CERROR("Failure to refill session: '%d'\n", rc);
-               RETURN(rc);
-       }
-
-       ofd_info_init(env, exp);
-       rc = ofd_parse_connect_data(env, exp, data);
+       rc = ofd_parse_connect_data(env, exp, data, false);
        if (rc == 0)
                ofd_export_stats_init(ofd, exp, localdata);
 
@@ -289,15 +281,7 @@ static int ofd_obd_connect(const struct lu_env *env, struct obd_export **_exp,
        exp = class_conn2export(&conn);
        LASSERT(exp != NULL);
 
-       rc = lu_env_refill((struct lu_env *)env);
-       if (rc != 0) {
-               CERROR("Failure to refill session: '%d'\n", rc);
-               GOTO(out, rc);
-       }
-
-       ofd_info_init(env, exp);
-
-       rc = ofd_parse_connect_data(env, exp, data);
+       rc = ofd_parse_connect_data(env, exp, data, true);
        if (rc)
                GOTO(out, rc);
 
@@ -313,7 +297,7 @@ static int ofd_obd_connect(const struct lu_env *env, struct obd_export **_exp,
        }
 
        CDEBUG(D_HA, "%s: get connection from MDS %d\n", obd->obd_name,
-              data->ocd_group);
+              data ? data->ocd_group : -1);
 
 out:
        if (rc != 0) {
@@ -343,16 +327,17 @@ static int ofd_obd_disconnect(struct obd_export *exp)
 
        ofd_grant_discard(exp);
 
-       rc = lu_env_init(&env, LCT_DT_THREAD);
-       if (rc)
-               RETURN(rc);
-
        /* Do not erase record for recoverable client. */
        if (exp->exp_obd->obd_replayable &&
-           (!exp->exp_obd->obd_fail || exp->exp_failed))
-               tgt_client_del(&env, exp);
-       lu_env_fini(&env);
+           (!exp->exp_obd->obd_fail || exp->exp_failed)) {
+               rc = lu_env_init(&env, LCT_DT_THREAD);
+               if (rc)
+                       GOTO(out, rc);
 
+               tgt_client_del(&env, exp);
+               lu_env_fini(&env);
+       }
+out:
        class_export_put(exp);
        RETURN(rc);
 }
@@ -363,6 +348,7 @@ static int ofd_init_export(struct obd_export *exp)
 
        spin_lock_init(&exp->exp_filter_data.fed_lock);
        CFS_INIT_LIST_HEAD(&exp->exp_filter_data.fed_mod_list);
+       atomic_set(&exp->exp_filter_data.fed_soft_sync_count, 0);
        spin_lock(&exp->exp_lock);
        exp->exp_connecting = 1;
        spin_unlock(&exp->exp_lock);
@@ -528,7 +514,7 @@ static int ofd_get_info(const struct lu_env *env, struct obd_export *exp,
                        struct lov_stripe_md *lsm)
 {
        struct ofd_device       *ofd;
-       int                      rc = 0;
+       int                     rc = 0;
 
        ENTRY;
 
@@ -537,13 +523,21 @@ static int ofd_get_info(const struct lu_env *env, struct obd_export *exp,
                RETURN(-EINVAL);
        }
 
+       /* Because ofd_get_info might be called from
+        * handle_request_in as well(see LU-3239), where env might
+        * not be initilaized correctly, and le_ses might be in
+        * an un-initialized state, so only refill le_ctx here */
+       rc = lu_env_refill((struct lu_env *)env);
+       if (rc != 0)
+               RETURN(rc);
+
        ofd = ofd_exp(exp);
 
        if (KEY_IS(KEY_BLOCKSIZE)) {
                __u32 *blocksize = val;
                if (blocksize) {
                        if (*vallen < sizeof(*blocksize))
-                               RETURN(-EOVERFLOW);
+                               GOTO(out, rc = -EOVERFLOW);
                        *blocksize = 1 << ofd->ofd_dt_conf.ddp_block_shift;
                }
                *vallen = sizeof(*blocksize);
@@ -551,7 +545,7 @@ static int ofd_get_info(const struct lu_env *env, struct obd_export *exp,
                __u32 *blocksize_bits = val;
                if (blocksize_bits) {
                        if (*vallen < sizeof(*blocksize_bits))
-                               RETURN(-EOVERFLOW);
+                               GOTO(out, rc = -EOVERFLOW);
                        *blocksize_bits = ofd->ofd_dt_conf.ddp_block_shift;
                }
                *vallen = sizeof(*blocksize_bits);
@@ -561,7 +555,7 @@ static int ofd_get_info(const struct lu_env *env, struct obd_export *exp,
 
                if (val == NULL) {
                        *vallen = sizeof(obd_id);
-                       RETURN(0);
+                       GOTO(out, rc = 0);
                }
                ofd_info_init(env, exp);
                oseq = ofd_seq_load(env, ofd,
@@ -570,35 +564,35 @@ static int ofd_get_info(const struct lu_env *env, struct obd_export *exp,
                if (last_id) {
                        if (*vallen < sizeof(*last_id)) {
                                ofd_seq_put(env, oseq);
-                               RETURN(-EOVERFLOW);
+                               GOTO(out, rc = -EOVERFLOW);
                        }
                        *last_id = ofd_seq_last_oid(oseq);
                }
                ofd_seq_put(env, oseq);
                *vallen = sizeof(*last_id);
        } else if (KEY_IS(KEY_FIEMAP)) {
-               struct ofd_thread_info          *info;
                struct ofd_device               *ofd = ofd_exp(exp);
                struct ofd_object               *fo;
                struct ll_fiemap_info_key       *fm_key = key;
+               struct lu_fid                    fid;
 
                if (val == NULL) {
                        *vallen = fiemap_count_to_size(
                                               fm_key->fiemap.fm_extent_count);
-                       RETURN(0);
+                       GOTO(out, rc = 0);
                }
 
-               info = ofd_info_init(env, exp);
-               rc = ostid_to_fid(&info->fti_fid, &fm_key->oa.o_oi, 0);
+               rc = ostid_to_fid(&fid, &fm_key->oa.o_oi,
+                                 ofd->ofd_lut.lut_lsd.lsd_osd_index);
                if (rc != 0)
-                       RETURN(rc);
+                       GOTO(out, rc);
                CDEBUG(D_INODE, "get FIEMAP of object "DFID"\n",
-                      PFID(&info->fti_fid));
+                      PFID(&fid));
 
-               fo = ofd_object_find(env, ofd, &info->fti_fid);
+               fo = ofd_object_find(env, ofd, &fid);
                if (IS_ERR(fo)) {
                        CERROR("%s: error finding object "DFID"\n",
-                              exp->exp_obd->obd_name, PFID(&info->fti_fid));
+                              exp->exp_obd->obd_name, PFID(&fid));
                        rc = PTR_ERR(fo);
                } else {
                        struct ll_user_fiemap *fiemap = val;
@@ -615,11 +609,7 @@ static int ofd_get_info(const struct lu_env *env, struct obd_export *exp,
                        ofd_read_unlock(env, fo);
                        ofd_object_put(env, fo);
                }
-       } else if (KEY_IS(KEY_SYNC_LOCK_CANCEL)) {
-               *((__u32 *) val) = ofd->ofd_sync_lock_cancel;
-               *vallen = sizeof(__u32);
        } else if (KEY_IS(KEY_LAST_FID)) {
-               struct lu_env           env;
                struct ofd_device       *ofd = ofd_exp(exp);
                struct ofd_seq          *oseq;
                struct lu_fid           *fid = val;
@@ -627,25 +617,23 @@ static int ofd_get_info(const struct lu_env *env, struct obd_export *exp,
 
                if (fid == NULL) {
                        *vallen = sizeof(struct lu_fid);
-                       RETURN(0);
+                       GOTO(out, rc = 0);
                }
 
                if (*vallen < sizeof(*fid))
-                       RETURN(-EOVERFLOW);
+                       GOTO(out, rc = -EOVERFLOW);
 
-               rc = lu_env_init(&env, LCT_DT_THREAD);
-               if (rc != 0)
-                       RETURN(rc);
-               ofd_info_init(&env, exp);
+               ofd_info_init(env, exp);
 
                fid_le_to_cpu(fid, fid);
 
-               oseq = ofd_seq_load(&env, ofd, ostid_seq((struct ost_id *)fid));
+               oseq = ofd_seq_load(env, ofd,
+                                   ostid_seq((struct ost_id *)fid));
                if (IS_ERR(oseq))
-                       GOTO(out_fini, rc = PTR_ERR(oseq));
+                       GOTO(out, rc = PTR_ERR(oseq));
 
                rc = ostid_to_fid(fid, &oseq->os_oi,
-                            ofd->ofd_lut.lut_lsd.lsd_osd_index);
+                                 ofd->ofd_lut.lut_lsd.lsd_osd_index);
                if (rc != 0)
                        GOTO(out_put, rc);
 
@@ -653,14 +641,12 @@ static int ofd_get_info(const struct lu_env *env, struct obd_export *exp,
                       PFID(fid));
                *vallen = sizeof(*fid);
 out_put:
-               ofd_seq_put(&env, oseq);
-out_fini:
-               lu_env_fini(&env);
+               ofd_seq_put(env, oseq);
        } else {
                CERROR("Not supported key %s\n", (char*)key);
                rc = -EOPNOTSUPP;
        }
-
+out:
        RETURN(rc);
 }
 
@@ -745,8 +731,8 @@ int ofd_statfs_internal(const struct lu_env *env, struct ofd_device *ofd,
        return 0;
 }
 
-static int ofd_statfs(const struct lu_env *env,  struct obd_export *exp,
-                     struct obd_statfs *osfs, __u64 max_age, __u32 flags)
+int ofd_statfs(const struct lu_env *env,  struct obd_export *exp,
+              struct obd_statfs *osfs, __u64 max_age, __u32 flags)
 {
         struct obd_device      *obd = class_exp2obd(exp);
        struct ofd_device       *ofd = ofd_dev(exp->exp_obd->obd_lu_dev);
@@ -834,10 +820,7 @@ int ofd_setattr(const struct lu_env *env, struct obd_export *exp,
        info = ofd_info_init(env, exp);
        ofd_oti2info(info, oti);
 
-       rc = ostid_to_fid(&info->fti_fid, &oinfo->oi_oa->o_oi, 0);
-       if (rc != 0)
-               RETURN(rc);
-
+       info->fti_fid = oinfo->oi_oa->o_oi.oi_fid;
        ost_fid_build_resid(&info->fti_fid, &info->fti_resid);
        rc = ofd_auth_capa(exp, &info->fti_fid, ostid_seq(&oa->o_oi),
                           oinfo_capa(oinfo), CAPA_OPC_META_WRITE);
@@ -883,18 +866,6 @@ int ofd_setattr(const struct lu_env *env, struct obd_export *exp,
        if (rc)
                GOTO(out_unlock, rc);
 
-       res = ldlm_resource_get(ns, NULL, &info->fti_resid, LDLM_EXTENT, 0);
-       if (res != NULL) {
-               ldlm_res_lvbo_update(res, NULL, 0);
-               ldlm_resource_putref(res);
-       }
-
-       oinfo->oi_oa->o_valid = OBD_MD_FLID;
-
-       /* Quota release needs uid/gid info */
-       rc = ofd_attr_get(env, fo, &info->fti_attr);
-       obdo_from_la(oinfo->oi_oa, &info->fti_attr,
-                    OFD_VALID_FLAGS | LA_UID | LA_GID);
        ofd_info2oti(info, oti);
 
        ofd_counter_incr(exp, LPROC_OFD_STATS_SETATTR, oti->oti_jobid, 1);
@@ -902,6 +873,19 @@ int ofd_setattr(const struct lu_env *env, struct obd_export *exp,
 out_unlock:
        ofd_object_put(env, fo);
 out:
+       if (rc == 0) {
+               /* we do not call this before to avoid lu_object_find() in
+                *  ->lvbo_update() holding another reference on the object.
+                * otherwise concurrent destroy can make the object unavailable
+                * for 2nd lu_object_find() waiting for the first reference
+                * to go... deadlock! */
+               res = ldlm_resource_get(ns, NULL, &info->fti_resid, LDLM_EXTENT, 0);
+               if (res != NULL) {
+                       ldlm_res_lvbo_update(res, NULL, 0);
+                       ldlm_resource_putref(res);
+               }
+       }
+
        return rc;
 }
 
@@ -922,9 +906,7 @@ static int ofd_punch(const struct lu_env *env, struct obd_export *exp,
        info = ofd_info_init(env, exp);
        ofd_oti2info(info, oti);
 
-       rc = ostid_to_fid(&info->fti_fid, &oinfo->oi_oa->o_oi, 0);
-       if (rc != 0)
-               RETURN(rc);
+       info->fti_fid = oinfo->oi_oa->o_oi.oi_fid;
        ost_fid_build_resid(&info->fti_fid, &info->fti_resid);
 
        CDEBUG(D_INODE, "calling punch for object "DFID", valid = "LPX64
@@ -991,13 +973,13 @@ out_env:
        return rc;
 }
 
-static int ofd_destroy_by_fid(const struct lu_env *env,
-                             struct ofd_device *ofd,
-                             const struct lu_fid *fid, int orphan)
+int ofd_destroy_by_fid(const struct lu_env *env, struct ofd_device *ofd,
+                      const struct lu_fid *fid, int orphan)
 {
        struct ofd_thread_info  *info = ofd_info(env);
        struct lustre_handle     lockh;
-       __u64                    flags = LDLM_AST_DISCARD_DATA, rc = 0;
+       __u64                    flags = LDLM_FL_AST_DISCARD_DATA;
+       __u64                    rc = 0;
        ldlm_policy_data_t       policy = {
                                        .l_extent = { 0, OBD_OBJECT_EOF }
                                 };
@@ -1008,6 +990,8 @@ static int ofd_destroy_by_fid(const struct lu_env *env,
        fo = ofd_object_find(env, ofd, fid);
        if (IS_ERR(fo))
                RETURN(PTR_ERR(fo));
+       if (!ofd_object_exists(fo))
+               GOTO(out, rc = -ENOENT);
 
        /* Tell the clients that the object is gone now and that they should
         * throw away any cached pages. */
@@ -1024,7 +1008,8 @@ static int ofd_destroy_by_fid(const struct lu_env *env,
        LASSERT(fo != NULL);
 
        rc = ofd_object_destroy(env, fo, orphan);
-
+       EXIT;
+out:
        ofd_object_put(env, fo);
        RETURN(rc);
 }
@@ -1036,6 +1021,8 @@ int ofd_destroy(const struct lu_env *env, struct obd_export *exp,
 {
        struct ofd_device       *ofd = ofd_exp(exp);
        struct ofd_thread_info  *info;
+       struct lu_fid           *fid;
+       obd_id                   oid;
        obd_count                count;
        int                      rc = 0;
 
@@ -1043,134 +1030,126 @@ int ofd_destroy(const struct lu_env *env, struct obd_export *exp,
 
        info = ofd_info_init(env, exp);
        ofd_oti2info(info, oti);
+       fid = &info->fti_fid;
 
        if (!(oa->o_valid & OBD_MD_FLGROUP))
                ostid_set_seq_mdt0(&oa->o_oi);
 
+       *fid = oa->o_oi.oi_fid;
+       oid = ostid_id(&oa->o_oi);
+       LASSERT(oid != 0);
+
        /* check that o_misc makes sense */
        if (oa->o_valid & OBD_MD_FLOBJCOUNT)
                count = oa->o_misc;
        else
                count = 1; /* default case - single destroy */
 
-       /**
-        * There can be sequence of objects to destroy. Therefore this request
-        * may have multiple transaction involved in. It is OK, we need only
-        * the highest used transno to be reported back in reply but not for
-        * replays, they must report their transno
-        */
-       if (info->fti_transno == 0) /* not replay */
-               info->fti_mult_trans = 1;
-
-       CDEBUG(D_HA, "%s: Destroy object "DOSTID" count %d\n", ofd_name(ofd),
+       CDEBUG(D_INODE, "%s: Destroy object "DOSTID" count %d\n", ofd_name(ofd),
               POSTID(&oa->o_oi), count);
+
        while (count > 0) {
                int lrc;
 
-               lrc = ostid_to_fid(&info->fti_fid, &oa->o_oi, 0);
-               if (lrc != 0) {
-                       if (rc == 0)
-                               rc = lrc;
-                       GOTO(out, rc);
-               }
-               lrc = ofd_destroy_by_fid(env, ofd, &info->fti_fid, 0);
+               lrc = ofd_destroy_by_fid(env, ofd, fid, 0);
                if (lrc == -ENOENT) {
                        CDEBUG(D_INODE,
                               "%s: destroying non-existent object "DFID"\n",
-                              ofd_obd(ofd)->obd_name, PFID(&info->fti_fid));
+                              ofd_obd(ofd)->obd_name, PFID(fid));
                        /* rewrite rc with -ENOENT only if it is 0 */
                        if (rc == 0)
                                rc = lrc;
                } else if (lrc != 0) {
                        CERROR("%s: error destroying object "DFID": %d\n",
-                              ofd_obd(ofd)->obd_name, PFID(&info->fti_fid),
+                              ofd_obd(ofd)->obd_name, PFID(fid),
                               rc);
                        rc = lrc;
                }
+
                count--;
-               ostid_inc_id(&oa->o_oi);
+               oid++;
+               lrc = fid_set_id(fid, oid);
+               if (unlikely(lrc != 0 && count > 0))
+                       GOTO(out, rc = lrc);
        }
 
-       /* if we have transaction then there were some deletions, we don't
-        * need to return ENOENT in that case because it will not wait
-        * for commit of these deletions. The ENOENT must be returned only
-        * if there were no transations.
-        */
-       if (rc == -ENOENT) {
-               if (info->fti_transno != 0)
-                       rc = 0;
-       } else if (rc != 0) {
-               /*
-                * If we have at least one transaction then llog record
-                * on server will be removed upon commit, so for rc != 0
-                * we return no transno and llog record will be reprocessed.
-                */
-               info->fti_transno = 0;
-       }
-       ofd_info2oti(info, oti);
+       GOTO(out, rc);
+
 out:
-       RETURN(rc);
+       ofd_info2oti(info, oti);
+       fid_to_ostid(fid, &oa->o_oi);
+       return rc;
 }
 
-static int ofd_orphans_destroy(const struct lu_env *env,
-                              struct obd_export *exp, struct ofd_device *ofd,
-                              struct obdo *oa)
+int ofd_orphans_destroy(const struct lu_env *env, struct obd_export *exp,
+                       struct ofd_device *ofd, struct obdo *oa)
 {
-       struct ofd_thread_info  *info = ofd_info(env);
+       struct ofd_thread_info  *info   = ofd_info(env);
+       struct lu_fid           *fid    = &info->fti_fid;
+       struct ost_id           *oi     = &oa->o_oi;
+       struct ofd_seq          *oseq;
+       obd_seq                  seq    = ostid_seq(oi);
+       obd_id                   end_id = ostid_id(oi);
        obd_id                   last;
+       obd_id                   oid;
        int                      skip_orphan;
-       int                      rc = 0;
-       struct ost_id            oi = oa->o_oi;
-       __u64                    end_id = ostid_id(&oa->o_oi);
-       struct ofd_seq          *oseq;
-
+       int                      rc     = 0;
        ENTRY;
 
-       oseq = ofd_seq_get(ofd, ostid_seq(&oa->o_oi));
+       oseq = ofd_seq_get(ofd, seq);
        if (oseq == NULL) {
                CERROR("%s: Can not find seq for "DOSTID"\n",
-                      ofd_name(ofd), POSTID(&oa->o_oi));
+                      ofd_name(ofd), POSTID(oi));
                RETURN(-EINVAL);
        }
 
+       *fid = oi->oi_fid;
+       last = ofd_seq_last_oid(oseq);
+       oid = last;
+
        LASSERT(exp != NULL);
        skip_orphan = !!(exp_connect_flags(exp) & OBD_CONNECT_SKIP_ORPHAN);
 
-       last = ofd_seq_last_oid(oseq);
-       LCONSOLE_INFO("%s: deleting orphan objects from "LPX64":"LPU64
-                     " to "LPU64"\n", ofd_name(ofd), ostid_seq(&oa->o_oi),
-                     end_id + 1, last);
+       LCONSOLE(D_INFO, "%s: deleting orphan objects from "DOSTID
+                " to "DOSTID"\n", ofd_name(ofd), seq, end_id + 1, seq, last);
 
-       for (ostid_set_id(&oi, last); ostid_id(&oi) > end_id;
-                         ostid_dec_id(&oi)) {
-               rc = ostid_to_fid(&info->fti_fid, &oi, 0);
-               if (rc != 0)
+       while (oid > end_id) {
+               rc = fid_set_id(fid, oid);
+               if (unlikely(rc != 0))
                        GOTO(out_put, rc);
-               rc = ofd_destroy_by_fid(env, ofd, &info->fti_fid, 1);
-               if (rc && rc != -ENOENT) /* this is pretty fatal... */
-                       CEMERG("error destroying precreated id "DOSTID": %d\n",
-                              POSTID(&oi), rc);
+
+               rc = ofd_destroy_by_fid(env, ofd, fid, 1);
+               if (rc != 0 && rc != -ENOENT) /* this is pretty fatal... */
+                       CEMERG("%s: error destroying precreated id "DFID
+                              ": rc = %d\n", ofd_name(ofd), PFID(fid), rc);
+
+               oid--;
                if (!skip_orphan) {
-                       ofd_seq_last_oid_set(oseq, ostid_id(&oi) - 1);
+                       ofd_seq_last_oid_set(oseq, oid);
                        /* update last_id on disk periodically so that if we
                         * restart * we don't need to re-scan all of the just
                         * deleted objects. */
-                       if ((ostid_id(&oi) & 511) == 0)
+                       if ((oid & 511) == 0)
                                ofd_seq_last_oid_write(env, ofd, oseq);
                }
        }
-       CDEBUG(D_HA, "%s: after destroy: set last_objids"DOSTID"\n",
-              ofd_obd(ofd)->obd_name, POSTID(&oa->o_oi));
+
+       CDEBUG(D_HA, "%s: after destroy: set last_id to "DOSTID"\n",
+              ofd_obd(ofd)->obd_name, seq, oid);
+
        if (!skip_orphan) {
                rc = ofd_seq_last_oid_write(env, ofd, oseq);
        } else {
                /* don't reuse orphan object, return last used objid */
-               ostid_set_id(&oa->o_oi, last);
+               ostid_set_id(oi, last);
                rc = 0;
        }
+
+       GOTO(out_put, rc);
+
 out_put:
        ofd_seq_put(env, oseq);
-       RETURN(rc);
+       return rc;
 }
 
 int ofd_create(const struct lu_env *env, struct obd_export *exp,
@@ -1228,6 +1207,7 @@ int ofd_create(const struct lu_env *env, struct obd_export *exp,
                        CERROR("%s:["LPU64"] destroys_in_progress already"
                               " cleared\n", exp->exp_obd->obd_name,
                               ostid_seq(&oa->o_oi));
+                       ostid_set_id(&oa->o_oi, ofd_seq_last_oid(oseq));
                        GOTO(out, rc = 0);
                }
                diff = ostid_id(&oa->o_oi) - ofd_seq_last_oid(oseq);
@@ -1295,6 +1275,22 @@ int ofd_create(const struct lu_env *env, struct obd_export *exp,
                        }
                }
 
+               /* This can happen if a new OST is formatted and installed
+                * in place of an old one at the same index.  Instead of
+                * precreating potentially millions of deleted old objects
+                * (possibly filling the OST), only precreate the last batch.
+                * LFSCK will eventually clean up any orphans. LU-14 */
+               if (diff > 5 * OST_MAX_PRECREATE) {
+                       diff = OST_MAX_PRECREATE / 2;
+                       LCONSOLE_WARN("%s: precreate FID "DOSTID" is over %u "
+                                     "larger than the LAST_ID "DOSTID", only "
+                                     "precreating the last %u objects.\n",
+                                     ofd_name(ofd), POSTID(&oa->o_oi),
+                                     5 * OST_MAX_PRECREATE,
+                                     POSTID(&oseq->os_oi), diff);
+                       ofd_seq_last_oid_set(oseq, ostid_id(&oa->o_oi) - diff);
+               }
+
                while (diff > 0) {
                        next_id = ofd_seq_last_oid(oseq) + 1;
                        count = ofd_precreate_batch(ofd, diff);
@@ -1357,16 +1353,13 @@ int ofd_getattr(const struct lu_env *env, struct obd_export *exp,
        struct ofd_device       *ofd = ofd_exp(exp);
        struct ofd_thread_info  *info;
        struct ofd_object       *fo;
-       __u64                    curr_version;
        int                      rc = 0;
 
        ENTRY;
 
        info = ofd_info_init(env, exp);
 
-       rc = ostid_to_fid(&info->fti_fid, &oinfo->oi_oa->o_oi, 0);
-       if (rc != 0)
-               GOTO(out, rc);
+       info->fti_fid = oinfo->oi_oa->o_oi.oi_fid;
        rc = ofd_auth_capa(exp, &info->fti_fid, ostid_seq(&oinfo->oi_oa->o_oi),
                           oinfo_capa(oinfo), CAPA_OPC_META_READ);
        if (rc)
@@ -1375,19 +1368,27 @@ int ofd_getattr(const struct lu_env *env, struct obd_export *exp,
        fo = ofd_object_find(env, ofd, &info->fti_fid);
        if (IS_ERR(fo))
                GOTO(out, rc = PTR_ERR(fo));
+       if (!ofd_object_exists(fo))
+               GOTO(out_put, rc = -ENOENT);
+
        LASSERT(fo != NULL);
        rc = ofd_attr_get(env, fo, &info->fti_attr);
        oinfo->oi_oa->o_valid = OBD_MD_FLID;
-       if (rc == 0)
+       if (rc == 0) {
+               __u64 curr_version;
+
                obdo_from_la(oinfo->oi_oa, &info->fti_attr,
                             OFD_VALID_FLAGS | LA_UID | LA_GID);
 
-       /* Store object version in reply */
-       curr_version = dt_version_get(env, ofd_object_child(fo));
-       if ((__s64)curr_version != -EOPNOTSUPP) {
-               oinfo->oi_oa->o_valid |= OBD_MD_FLDATAVERSION;
-               oinfo->oi_oa->o_data_version = curr_version;
+               /* Store object version in reply */
+               curr_version = dt_version_get(env, ofd_object_child(fo));
+               if ((__s64)curr_version != -EOPNOTSUPP) {
+                       oinfo->oi_oa->o_valid |= OBD_MD_FLDATAVERSION;
+                       oinfo->oi_oa->o_data_version = curr_version;
+               }
        }
+
+out_put:
        ofd_object_put(env, fo);
 out:
        RETURN(rc);
@@ -1411,10 +1412,7 @@ static int ofd_sync(const struct lu_env *env, struct obd_export *exp,
        }
 
        info = ofd_info_init(env, exp);
-       rc = ostid_to_fid(&info->fti_fid, &oinfo->oi_oa->o_oi, 0);
-       if (rc != 0)
-               GOTO(out, rc);
-
+       info->fti_fid = oinfo->oi_oa->o_oi.oi_fid;
        rc = ofd_auth_capa(exp, &info->fti_fid, ostid_seq(&oinfo->oi_oa->o_oi),
                           oinfo_capa(oinfo), CAPA_OPC_OSS_TRUNC);
        if (rc)
@@ -1474,7 +1472,8 @@ static int ofd_ioc_get_obj_version(const struct lu_env *env,
 
                ostid_set_seq(&ostid, *(__u64 *)data->ioc_inlbuf4);
                ostid_set_id(&ostid, *(__u64 *)data->ioc_inlbuf3);
-               rc = ostid_to_fid(&fid, &ostid, 0);
+               rc = ostid_to_fid(&fid, &ostid,
+                                 ofd->ofd_lut.lut_lsd.lsd_osd_index);
                if (rc != 0)
                        GOTO(out, rc);
        } else {
@@ -1536,6 +1535,24 @@ int ofd_iocontrol(unsigned int cmd, struct obd_export *exp, int len,
                if (rc == 0)
                        rc = dt_ro(&env, ofd->ofd_osd);
                break;
+       case OBD_IOC_START_LFSCK: {
+               struct obd_ioctl_data *data = karg;
+               struct lfsck_start_param lsp;
+
+               if (unlikely(data == NULL)) {
+                       rc = -EINVAL;
+                       break;
+               }
+
+               lsp.lsp_start = (struct lfsck_start *)(data->ioc_inlbuf1);
+               lsp.lsp_namespace = ofd->ofd_namespace;
+               rc = lfsck_start(&env, ofd->ofd_osd, &lsp);
+               break;
+       }
+       case OBD_IOC_STOP_LFSCK: {
+               rc = lfsck_stop(&env, ofd->ofd_osd, false);
+               break;
+       }
        case OBD_IOC_GET_OBJ_VERSION:
                rc = ofd_ioc_get_obj_version(&env, ofd, karg);
                break;
@@ -1594,11 +1611,11 @@ static int ofd_health_check(const struct lu_env *nul, struct obd_device *obd)
                GOTO(out, rc = -EROFS);
 
 #ifdef USE_HEALTH_CHECK_WRITE
-       OBD_ALLOC(info->fti_buf.lb_buf, CFS_PAGE_SIZE);
+       OBD_ALLOC(info->fti_buf.lb_buf, PAGE_CACHE_SIZE);
        if (info->fti_buf.lb_buf == NULL)
                GOTO(out, rc = -ENOMEM);
 
-       info->fti_buf.lb_len = CFS_PAGE_SIZE;
+       info->fti_buf.lb_len = PAGE_CACHE_SIZE;
        info->fti_off = 0;
 
        th = dt_trans_create(&env, ofd->ofd_osd);
@@ -1617,7 +1634,7 @@ static int ofd_health_check(const struct lu_env *nul, struct obd_device *obd)
        }
        dt_trans_stop(&env, ofd->ofd_osd, th);
 
-       OBD_FREE(info->fti_buf.lb_buf, CFS_PAGE_SIZE);
+       OBD_FREE(info->fti_buf.lb_buf, PAGE_CACHE_SIZE);
 
        CDEBUG(D_INFO, "write 1 page synchronously for checking io rc %d\n",rc);
 #endif