Whamcloud - gitweb
LU-9859 libcfs: replace cfs_get_random_bytes calls with get_random_byte()
[fs/lustre-release.git] / lustre / obdclass / lustre_handles.c
index 8327a6c..6122f34 100644 (file)
  *
  * You should have received a copy of the GNU General Public License
  * version 2 along with this program; If not, see
- * http://www.sun.com/software/products/lustre/docs/GPLv2.pdf
- *
- * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
- * CA 95054 USA or visit www.sun.com if you need additional information or
- * have any questions.
+ * http://www.gnu.org/licenses/gpl-2.0.html
  *
  * GPL HEADER END
  */
@@ -27,7 +23,7 @@
  * Copyright (c) 2003, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
  *
- * Copyright (c) 2011, 2013, Intel Corporation.
+ * Copyright (c) 2011, 2017, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
@@ -40,6 +36,8 @@
 
 #define DEBUG_SUBSYSTEM S_CLASS
 
+#include <linux/random.h>
+
 #include <obd_support.h>
 #include <lustre_handles.h>
 #include <lustre_lib.h>
 
 static __u64 handle_base;
 #define HANDLE_INCR 7
-static spinlock_t handle_base_lock;
+static DEFINE_SPINLOCK(handle_base_lock);
 
 static struct handle_bucket {
-       spinlock_t       lock;
+       spinlock_t lock;
        struct list_head head;
 } *handle_hash;
 
@@ -64,16 +62,17 @@ static struct handle_bucket {
 void class_handle_hash(struct portals_handle *h,
                       struct portals_handle_ops *ops)
 {
-        struct handle_bucket *bucket;
-        ENTRY;
+       struct handle_bucket *bucket;
+
+       ENTRY;
 
-        LASSERT(h != NULL);
+       LASSERT(h != NULL);
        LASSERT(list_empty(&h->h_link));
 
-        /*
-         * This is fast, but simplistic cookie generation algorithm, it will
-         * need a re-do at some point in the future for security.
-         */
+       /*
+        * This is fast, but simplistic cookie generation algorithm, it will
+        * need a re-do at some point in the future for security.
+        */
        spin_lock(&handle_base_lock);
        handle_base += HANDLE_INCR;
 
@@ -98,7 +97,7 @@ void class_handle_hash(struct portals_handle *h,
        h->h_in = 1;
        spin_unlock(&bucket->lock);
 
-       CDEBUG(D_INFO, "added object %p with handle "LPX64" to hash\n",
+       CDEBUG(D_INFO, "added object %p with handle %#llx to hash\n",
               h, h->h_cookie);
        EXIT;
 }
@@ -107,13 +106,13 @@ EXPORT_SYMBOL(class_handle_hash);
 static void class_handle_unhash_nolock(struct portals_handle *h)
 {
        if (list_empty(&h->h_link)) {
-                CERROR("removing an already-removed handle ("LPX64")\n",
-                       h->h_cookie);
-                return;
-        }
+               CERROR("removing an already-removed handle (%#llx)\n",
+                      h->h_cookie);
+               return;
+       }
 
-        CDEBUG(D_INFO, "removing object %p with handle "LPX64" from hash\n",
-               h, h->h_cookie);
+       CDEBUG(D_INFO, "removing object %p with handle %#llx from hash\n",
+              h, h->h_cookie);
 
        spin_lock(&h->h_lock);
        if (h->h_in == 0) {
@@ -154,21 +153,24 @@ EXPORT_SYMBOL(class_handle_hash_back);
 
 void *class_handle2object(__u64 cookie, const void *owner)
 {
-        struct handle_bucket *bucket;
-        struct portals_handle *h;
-        void *retval = NULL;
-        ENTRY;
+       struct handle_bucket *bucket;
+       struct portals_handle *h;
+       void *retval = NULL;
+
+       ENTRY;
 
-        LASSERT(handle_hash != NULL);
+       LASSERT(handle_hash != NULL);
 
-       /* Be careful when you want to change this code. See the
-        * rcu_read_lock() definition on top this file. - jxiong */
-        bucket = handle_hash + (cookie & HANDLE_HASH_MASK);
+       /*
+        * Be careful when you want to change this code. See the
+        * rcu_read_lock() definition on top this file. - jxiong
+        */
+       bucket = handle_hash + (cookie & HANDLE_HASH_MASK);
 
-        rcu_read_lock();
-        list_for_each_entry_rcu(h, &bucket->head, h_link) {
+       rcu_read_lock();
+       list_for_each_entry_rcu(h, &bucket->head, h_link) {
                if (h->h_cookie != cookie || h->h_owner != owner)
-                        continue;
+                       continue;
 
                spin_lock(&h->h_lock);
                if (likely(h->h_in != 0)) {
@@ -201,32 +203,24 @@ EXPORT_SYMBOL(class_handle_free_cb);
 
 int class_handle_init(void)
 {
-        struct handle_bucket *bucket;
-        struct timeval tv;
-        int seed[2];
+       struct handle_bucket *bucket;
 
-        LASSERT(handle_hash == NULL);
+       LASSERT(handle_hash == NULL);
 
-        OBD_ALLOC_LARGE(handle_hash, sizeof(*bucket) * HANDLE_HASH_SIZE);
-        if (handle_hash == NULL)
-                return -ENOMEM;
+       OBD_ALLOC_LARGE(handle_hash, sizeof(*bucket) * HANDLE_HASH_SIZE);
+       if (handle_hash == NULL)
+               return -ENOMEM;
 
-       spin_lock_init(&handle_base_lock);
        for (bucket = handle_hash + HANDLE_HASH_SIZE - 1; bucket >= handle_hash;
             bucket--) {
                INIT_LIST_HEAD(&bucket->head);
                spin_lock_init(&bucket->lock);
        }
 
-       /** bug 21430: add randomness to the initial base */
-       cfs_get_random_bytes(seed, sizeof(seed));
-       do_gettimeofday(&tv);
-       cfs_srand(tv.tv_sec ^ seed[0], tv.tv_usec ^ seed[1]);
-
-        cfs_get_random_bytes(&handle_base, sizeof(handle_base));
-        LASSERT(handle_base != 0ULL);
+       get_random_bytes(&handle_base, sizeof(handle_base));
+       LASSERT(handle_base != 0ULL);
 
-        return 0;
+       return 0;
 }
 
 static int cleanup_all_handles(void)
@@ -239,7 +233,7 @@ static int cleanup_all_handles(void)
 
                spin_lock(&handle_hash[i].lock);
                list_for_each_entry_rcu(h, &(handle_hash[i].head), h_link) {
-                       CERROR("force clean handle "LPX64" addr %p ops %p\n",
+                       CERROR("force clean handle %#llx addr %p ops %p\n",
                               h->h_cookie, h, h->h_ops);
 
                        class_handle_unhash_nolock(h);
@@ -253,14 +247,15 @@ static int cleanup_all_handles(void)
 
 void class_handle_cleanup(void)
 {
-        int count;
-        LASSERT(handle_hash != NULL);
+       int count;
+
+       LASSERT(handle_hash != NULL);
 
-        count = cleanup_all_handles();
+       count = cleanup_all_handles();
 
-        OBD_FREE_LARGE(handle_hash, sizeof(*handle_hash) * HANDLE_HASH_SIZE);
-        handle_hash = NULL;
+       OBD_FREE_LARGE(handle_hash, sizeof(*handle_hash) * HANDLE_HASH_SIZE);
+       handle_hash = NULL;
 
-        if (count != 0)
-                CERROR("handle_count at cleanup: %d\n", count);
+       if (count != 0)
+               CERROR("handle_count at cleanup: %d\n", count);
 }