Whamcloud - gitweb
LU-1644 mgc: remove obsolete IR swabbing workaround
[fs/lustre-release.git] / lustre / obdclass / lprocfs_status.c
index c8ce66c..0c434f2 100644 (file)
  *
  * You should have received a copy of the GNU General Public License
  * version 2 along with this program; If not, see
- * http://www.sun.com/software/products/lustre/docs/GPLv2.pdf
- *
- * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
- * CA 95054 USA or visit www.sun.com if you need additional information or
- * have any questions.
+ * http://www.gnu.org/licenses/gpl-2.0.html
  *
  * GPL HEADER END
  */
@@ -27,7 +23,7 @@
  * Copyright (c) 2002, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
  *
- * Copyright (c) 2011, 2014, Intel Corporation.
+ * Copyright (c) 2011, 2017, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
 
 #include <obd_class.h>
 #include <lprocfs_status.h>
-#include <lustre/lustre_idl.h>
 
 #ifdef CONFIG_PROC_FS
 
 static int lprocfs_no_percpu_stats = 0;
-CFS_MODULE_PARM(lprocfs_no_percpu_stats, "i", int, 0644,
-                "Do not alloc percpu data for lprocfs stats");
+module_param(lprocfs_no_percpu_stats, int, 0644);
+MODULE_PARM_DESC(lprocfs_no_percpu_stats, "Do not alloc percpu data for lprocfs stats");
 
 #define MAX_STRING_SIZE 128
 
@@ -64,6 +59,29 @@ int lprocfs_seq_release(struct inode *inode, struct file *file)
 }
 EXPORT_SYMBOL(lprocfs_seq_release);
 
+struct dentry *ldebugfs_add_simple(struct dentry *root,
+                                  char *name, void *data,
+                                  const struct file_operations *fops)
+{
+       struct dentry *entry;
+       umode_t mode = 0;
+
+       if (!root || !name || !fops)
+               return ERR_PTR(-EINVAL);
+
+       if (fops->read)
+               mode = 0444;
+       if (fops->write)
+               mode |= 0200;
+       entry = debugfs_create_file(name, mode, root, data, fops);
+       if (IS_ERR_OR_NULL(entry)) {
+               CERROR("LprocFS: No memory to create <debugfs> entry %s", name);
+               return entry ?: ERR_PTR(-ENOMEM);
+       }
+       return entry;
+}
+EXPORT_SYMBOL(ldebugfs_add_simple);
+
 struct proc_dir_entry *
 lprocfs_add_simple(struct proc_dir_entry *root, char *name,
                   void *data, const struct file_operations *fops)
@@ -118,6 +136,35 @@ EXPORT_SYMBOL(lprocfs_add_symlink);
 
 static const struct file_operations lprocfs_generic_fops = { };
 
+int ldebugfs_add_vars(struct dentry *parent, struct lprocfs_vars *list,
+                     void *data)
+{
+       if (IS_ERR_OR_NULL(parent) || IS_ERR_OR_NULL(list))
+               return -EINVAL;
+
+       while (list->name) {
+               struct dentry *entry;
+               umode_t mode = 0;
+
+               if (list->proc_mode != 0000) {
+                       mode = list->proc_mode;
+               } else if (list->fops) {
+                       if (list->fops->read)
+                               mode = 0444;
+                       if (list->fops->write)
+                               mode |= 0200;
+               }
+               entry = debugfs_create_file(list->name, mode, parent,
+                                           list->data ? : data,
+                                           list->fops ? : &lprocfs_generic_fops);
+               if (IS_ERR_OR_NULL(entry))
+                       return entry ? PTR_ERR(entry) : -ENOMEM;
+               list++;
+       }
+       return 0;
+}
+EXPORT_SYMBOL_GPL(ldebugfs_add_vars);
+
 /**
  * Add /proc entries.
  *
@@ -159,6 +206,13 @@ lprocfs_add_vars(struct proc_dir_entry *root, struct lprocfs_vars *list,
 }
 EXPORT_SYMBOL(lprocfs_add_vars);
 
+void ldebugfs_remove(struct dentry **entryp)
+{
+       debugfs_remove_recursive(*entryp);
+       *entryp = NULL;
+}
+EXPORT_SYMBOL_GPL(ldebugfs_remove);
+
 #ifndef HAVE_REMOVE_PROC_SUBTREE
 /* for b=10866, global variable */
 DECLARE_RWSEM(_lprocfs_lock);
@@ -268,6 +322,31 @@ void lprocfs_remove_proc_entry(const char *name, struct proc_dir_entry *parent)
 }
 EXPORT_SYMBOL(lprocfs_remove_proc_entry);
 
+struct dentry *ldebugfs_register(const char *name, struct dentry *parent,
+                                struct lprocfs_vars *list, void *data)
+{
+       struct dentry *entry;
+
+       entry = debugfs_create_dir(name, parent);
+       if (IS_ERR_OR_NULL(entry)) {
+               entry = entry ?: ERR_PTR(-ENOMEM);
+               goto out;
+       }
+
+       if (!IS_ERR_OR_NULL(list)) {
+               int rc;
+
+               rc = ldebugfs_add_vars(entry, list, data);
+               if (rc) {
+                       debugfs_remove(entry);
+                       entry = ERR_PTR(rc);
+               }
+       }
+out:
+       return entry;
+}
+EXPORT_SYMBOL_GPL(ldebugfs_register);
+
 struct proc_dir_entry *
 lprocfs_register(const char *name, struct proc_dir_entry *parent,
                 struct lprocfs_vars *list, void *data)
@@ -290,197 +369,183 @@ lprocfs_register(const char *name, struct proc_dir_entry *parent,
 EXPORT_SYMBOL(lprocfs_register);
 
 /* Generic callbacks */
-int lprocfs_uint_seq_show(struct seq_file *m, void *data)
-{
-       return seq_printf(m, "%u\n", *(unsigned int *)data);
-}
-EXPORT_SYMBOL(lprocfs_uint_seq_show);
-
-int lprocfs_wr_uint(struct file *file, const char __user *buffer,
-                    unsigned long count, void *data)
-{
-        unsigned *p = data;
-        char dummy[MAX_STRING_SIZE + 1], *end;
-        unsigned long tmp;
-
-        dummy[MAX_STRING_SIZE] = '\0';
-       if (copy_from_user(dummy, buffer, MAX_STRING_SIZE))
-                return -EFAULT;
-
-        tmp = simple_strtoul(dummy, &end, 0);
-        if (dummy == end)
-                return -EINVAL;
-
-        *p = (unsigned int)tmp;
-        return count;
-}
-EXPORT_SYMBOL(lprocfs_wr_uint);
-
-ssize_t lprocfs_uint_seq_write(struct file *file, const char __user *buffer,
-                              size_t count, loff_t *off)
-{
-       int *data = ((struct seq_file *)file->private_data)->private;
-       int val = 0, rc;
-
-       rc = lprocfs_write_helper(buffer, count, &val);
-       if (rc < 0)
-               return rc;
-
-       return lprocfs_wr_uint(file, buffer, count, data);
-}
-EXPORT_SYMBOL(lprocfs_uint_seq_write);
-
-int lprocfs_u64_seq_show(struct seq_file *m, void *data)
-{
-       LASSERT(data != NULL);
-       return seq_printf(m, LPU64"\n", *(__u64 *)data);
-}
-EXPORT_SYMBOL(lprocfs_u64_seq_show);
-
-int lprocfs_atomic_seq_show(struct seq_file *m, void *data)
-{
-       atomic_t *atom = data;
-       LASSERT(atom != NULL);
-       return seq_printf(m, "%d\n", atomic_read(atom));
-}
-EXPORT_SYMBOL(lprocfs_atomic_seq_show);
-
-ssize_t
-lprocfs_atomic_seq_write(struct file *file, const char __user *buffer,
-                       size_t count, loff_t *off)
-{
-       atomic_t *atm = ((struct seq_file *)file->private_data)->private;
-       int val = 0;
-       int rc;
-
-       rc = lprocfs_write_helper(buffer, count, &val);
-       if (rc < 0)
-               return rc;
-
-       if (val <= 0)
-               return -ERANGE;
-
-       atomic_set(atm, val);
-       return count;
-}
-EXPORT_SYMBOL(lprocfs_atomic_seq_write);
-
 int lprocfs_uuid_seq_show(struct seq_file *m, void *data)
 {
        struct obd_device *obd = data;
 
        LASSERT(obd != NULL);
-       return seq_printf(m, "%s\n", obd->obd_uuid.uuid);
+       seq_printf(m, "%s\n", obd->obd_uuid.uuid);
+       return 0;
 }
 EXPORT_SYMBOL(lprocfs_uuid_seq_show);
 
+static ssize_t uuid_show(struct kobject *kobj, struct attribute *attr,
+                        char *buf)
+{
+       struct obd_device *obd = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+
+       return sprintf(buf, "%s\n", obd->obd_uuid.uuid);
+}
+LUSTRE_RO_ATTR(uuid);
+
 int lprocfs_name_seq_show(struct seq_file *m, void *data)
 {
        struct obd_device *dev = data;
 
        LASSERT(dev != NULL);
-       return seq_printf(m, "%s\n", dev->obd_name);
+       seq_printf(m, "%s\n", dev->obd_name);
+       return 0;
 }
 EXPORT_SYMBOL(lprocfs_name_seq_show);
 
-int lprocfs_blksize_seq_show(struct seq_file *m, void *data)
+static ssize_t blocksize_show(struct kobject *kobj, struct attribute *attr,
+                             char *buf)
 {
-       struct obd_device *obd = data;
-       struct obd_statfs  osfs;
-       int rc = obd_statfs(NULL, obd->obd_self_export, &osfs,
-                           cfs_time_shift_64(-OBD_STATFS_CACHE_SECONDS),
-                           OBD_STATFS_NODELAY);
+       struct obd_device *obd = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+       struct obd_statfs osfs;
+       int rc;
+
+       rc = obd_statfs(NULL, obd->obd_self_export, &osfs,
+                       ktime_get_seconds() - OBD_STATFS_CACHE_SECONDS,
+                       OBD_STATFS_NODELAY);
        if (!rc)
-               rc = seq_printf(m, "%u\n", osfs.os_bsize);
+               return sprintf(buf, "%u\n", osfs.os_bsize);
+
        return rc;
 }
-EXPORT_SYMBOL(lprocfs_blksize_seq_show);
+LUSTRE_RO_ATTR(blocksize);
 
-int lprocfs_kbytestotal_seq_show(struct seq_file *m, void *data)
+static ssize_t kbytestotal_show(struct kobject *kobj, struct attribute *attr,
+                               char *buf)
 {
-       struct obd_device *obd = data;
-       struct obd_statfs  osfs;
-       int rc = obd_statfs(NULL, obd->obd_self_export, &osfs,
-                           cfs_time_shift_64(-OBD_STATFS_CACHE_SECONDS),
-                           OBD_STATFS_NODELAY);
+       struct obd_device *obd = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+       struct obd_statfs osfs;
+       int rc;
+
+       rc = obd_statfs(NULL, obd->obd_self_export, &osfs,
+                       ktime_get_seconds() - OBD_STATFS_CACHE_SECONDS,
+                       OBD_STATFS_NODELAY);
        if (!rc) {
-               __u32 blk_size = osfs.os_bsize >> 10;
-               __u64 result = osfs.os_blocks;
+               u32 blk_size = osfs.os_bsize >> 10;
+               u64 result = osfs.os_blocks;
 
                while (blk_size >>= 1)
                        result <<= 1;
 
-               rc = seq_printf(m, LPU64"\n", result);
+               return sprintf(buf, "%llu\n", result);
        }
+
        return rc;
 }
-EXPORT_SYMBOL(lprocfs_kbytestotal_seq_show);
+LUSTRE_RO_ATTR(kbytestotal);
 
-int lprocfs_kbytesfree_seq_show(struct seq_file *m, void *data)
+static ssize_t kbytesfree_show(struct kobject *kobj, struct attribute *attr,
+                              char *buf)
 {
-       struct obd_device *obd = data;
-       struct obd_statfs  osfs;
-       int rc = obd_statfs(NULL, obd->obd_self_export, &osfs,
-                           cfs_time_shift_64(-OBD_STATFS_CACHE_SECONDS),
-                           OBD_STATFS_NODELAY);
+       struct obd_device *obd = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+       struct obd_statfs osfs;
+       int rc;
+
+       rc = obd_statfs(NULL, obd->obd_self_export, &osfs,
+                       ktime_get_seconds() - OBD_STATFS_CACHE_SECONDS,
+                       OBD_STATFS_NODELAY);
        if (!rc) {
-               __u32 blk_size = osfs.os_bsize >> 10;
-               __u64 result = osfs.os_bfree;
+               u32 blk_size = osfs.os_bsize >> 10;
+               u64 result = osfs.os_bfree;
 
                while (blk_size >>= 1)
                        result <<= 1;
 
-               rc = seq_printf(m, LPU64"\n", result);
+               return sprintf(buf, "%llu\n", result);
        }
+
        return rc;
 }
-EXPORT_SYMBOL(lprocfs_kbytesfree_seq_show);
+LUSTRE_RO_ATTR(kbytesfree);
 
-int lprocfs_kbytesavail_seq_show(struct seq_file *m, void *data)
+static ssize_t kbytesavail_show(struct kobject *kobj, struct attribute *attr,
+                               char *buf)
 {
-       struct obd_device *obd = data;
-       struct obd_statfs  osfs;
-       int rc = obd_statfs(NULL, obd->obd_self_export, &osfs,
-                           cfs_time_shift_64(-OBD_STATFS_CACHE_SECONDS),
-                           OBD_STATFS_NODELAY);
+       struct obd_device *obd = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+       struct obd_statfs osfs;
+       int rc;
+
+       rc = obd_statfs(NULL, obd->obd_self_export, &osfs,
+                       ktime_get_seconds() - OBD_STATFS_CACHE_SECONDS,
+                       OBD_STATFS_NODELAY);
        if (!rc) {
-               __u32 blk_size = osfs.os_bsize >> 10;
-               __u64 result = osfs.os_bavail;
+               u32 blk_size = osfs.os_bsize >> 10;
+               u64 result = osfs.os_bavail;
 
                while (blk_size >>= 1)
                        result <<= 1;
 
-               rc = seq_printf(m, LPU64"\n", result);
+               return sprintf(buf, "%llu\n", result);
        }
+
        return rc;
 }
-EXPORT_SYMBOL(lprocfs_kbytesavail_seq_show);
+LUSTRE_RO_ATTR(kbytesavail);
 
-int lprocfs_filestotal_seq_show(struct seq_file *m, void *data)
+static ssize_t filestotal_show(struct kobject *kobj, struct attribute *attr,
+                              char *buf)
 {
-       struct obd_device *obd = data;
-       struct obd_statfs  osfs;
-       int rc = obd_statfs(NULL, obd->obd_self_export, &osfs,
-                           cfs_time_shift_64(-OBD_STATFS_CACHE_SECONDS),
-                           OBD_STATFS_NODELAY);
+       struct obd_device *obd = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+       struct obd_statfs osfs;
+       int rc;
+
+       rc = obd_statfs(NULL, obd->obd_self_export, &osfs,
+                       ktime_get_seconds() - OBD_STATFS_CACHE_SECONDS,
+                       OBD_STATFS_NODELAY);
        if (!rc)
-               rc = seq_printf(m, LPU64"\n", osfs.os_files);
+               return sprintf(buf, "%llu\n", osfs.os_files);
+
        return rc;
 }
-EXPORT_SYMBOL(lprocfs_filestotal_seq_show);
+LUSTRE_RO_ATTR(filestotal);
 
-int lprocfs_filesfree_seq_show(struct seq_file *m, void *data)
+static ssize_t filesfree_show(struct kobject *kobj, struct attribute *attr,
+                             char *buf)
 {
-       struct obd_device *obd = data;
-       struct obd_statfs  osfs;
-       int rc = obd_statfs(NULL, obd->obd_self_export, &osfs,
-                           cfs_time_shift_64(-OBD_STATFS_CACHE_SECONDS),
-                           OBD_STATFS_NODELAY);
+       struct obd_device *obd = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+       struct obd_statfs osfs;
+       int rc;
+
+       rc = obd_statfs(NULL, obd->obd_self_export, &osfs,
+                       ktime_get_seconds() - OBD_STATFS_CACHE_SECONDS,
+                       OBD_STATFS_NODELAY);
        if (!rc)
-               rc = seq_printf(m, LPU64"\n", osfs.os_ffree);
+               return sprintf(buf, "%llu\n", osfs.os_ffree);
+
        return rc;
 }
-EXPORT_SYMBOL(lprocfs_filesfree_seq_show);
+LUSTRE_RO_ATTR(filesfree);
+
+ssize_t conn_uuid_show(struct kobject *kobj, struct attribute *attr, char *buf)
+{
+       struct obd_device *obd = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+       struct ptlrpc_connection *conn;
+       ssize_t count;
+
+       LPROCFS_CLIMP_CHECK(obd);
+       conn = obd->u.cli.cl_import->imp_connection;
+       if (conn && obd->u.cli.cl_import)
+               count = sprintf(buf, "%s\n", conn->c_remote_uuid.uuid);
+       else
+               count = sprintf(buf, "%s\n", "<none>");
+
+       LPROCFS_CLIMP_EXIT(obd);
+       return count;
+}
+EXPORT_SYMBOL(conn_uuid_show);
 
 int lprocfs_server_uuid_seq_show(struct seq_file *m, void *data)
 {
@@ -493,8 +558,8 @@ int lprocfs_server_uuid_seq_show(struct seq_file *m, void *data)
        LPROCFS_CLIMP_CHECK(obd);
        imp = obd->u.cli.cl_import;
        imp_state_name = ptlrpc_import_state_name(imp->imp_state);
-       rc = seq_printf(m, "%s\t%s%s\n", obd2cli_tgt(obd), imp_state_name,
-                       imp->imp_deactive ? "\tDEACTIVATED" : "");
+       seq_printf(m, "%s\t%s%s\n", obd2cli_tgt(obd), imp_state_name,
+                  imp->imp_deactive ? "\tDEACTIVATED" : "");
 
        LPROCFS_CLIMP_EXIT(obd);
        return rc;
@@ -512,9 +577,9 @@ int lprocfs_conn_uuid_seq_show(struct seq_file *m, void *data)
        LPROCFS_CLIMP_CHECK(obd);
        conn = obd->u.cli.cl_import->imp_connection;
        if (conn && obd->u.cli.cl_import)
-               rc = seq_printf(m, "%s\n", conn->c_remote_uuid.uuid);
+               seq_printf(m, "%s\n", conn->c_remote_uuid.uuid);
        else
-               rc = seq_printf(m, "%s\n", "<none>");
+               seq_printf(m, "%s\n", "<none>");
 
        LPROCFS_CLIMP_EXIT(obd);
        return rc;
@@ -522,6 +587,95 @@ int lprocfs_conn_uuid_seq_show(struct seq_file *m, void *data)
 EXPORT_SYMBOL(lprocfs_conn_uuid_seq_show);
 
 /** add up per-cpu counters */
+
+/**
+ * Lock statistics structure for access, possibly only on this CPU.
+ *
+ * The statistics struct may be allocated with per-CPU structures for
+ * efficient concurrent update (usually only on server-wide stats), or
+ * as a single global struct (e.g. for per-client or per-job statistics),
+ * so the required locking depends on the type of structure allocated.
+ *
+ * For per-CPU statistics, pin the thread to the current cpuid so that
+ * will only access the statistics for that CPU.  If the stats structure
+ * for the current CPU has not been allocated (or previously freed),
+ * allocate it now.  The per-CPU statistics do not need locking since
+ * the thread is pinned to the CPU during update.
+ *
+ * For global statistics, lock the stats structure to prevent concurrent update.
+ *
+ * \param[in] stats    statistics structure to lock
+ * \param[in] opc      type of operation:
+ *                     LPROCFS_GET_SMP_ID: "lock" and return current CPU index
+ *                             for incrementing statistics for that CPU
+ *                     LPROCFS_GET_NUM_CPU: "lock" and return number of used
+ *                             CPU indices to iterate over all indices
+ * \param[out] flags   CPU interrupt saved state for IRQ-safe locking
+ *
+ * \retval cpuid of current thread or number of allocated structs
+ * \retval negative on error (only for opc LPROCFS_GET_SMP_ID + per-CPU stats)
+ */
+int lprocfs_stats_lock(struct lprocfs_stats *stats,
+                      enum lprocfs_stats_lock_ops opc,
+                      unsigned long *flags)
+{
+       if (stats->ls_flags & LPROCFS_STATS_FLAG_NOPERCPU) {
+               if (stats->ls_flags & LPROCFS_STATS_FLAG_IRQ_SAFE)
+                       spin_lock_irqsave(&stats->ls_lock, *flags);
+               else
+                       spin_lock(&stats->ls_lock);
+               return opc == LPROCFS_GET_NUM_CPU ? 1 : 0;
+       }
+
+       switch (opc) {
+       case LPROCFS_GET_SMP_ID: {
+               unsigned int cpuid = get_cpu();
+
+               if (unlikely(!stats->ls_percpu[cpuid])) {
+                       int rc = lprocfs_stats_alloc_one(stats, cpuid);
+
+                       if (rc < 0) {
+                               put_cpu();
+                               return rc;
+                       }
+               }
+               return cpuid;
+       }
+       case LPROCFS_GET_NUM_CPU:
+               return stats->ls_biggest_alloc_num;
+       default:
+               LBUG();
+       }
+}
+
+/**
+ * Unlock statistics structure after access.
+ *
+ * Unlock the lock acquired via lprocfs_stats_lock() for global statistics,
+ * or unpin this thread from the current cpuid for per-CPU statistics.
+ *
+ * This function must be called using the same arguments as used when calling
+ * lprocfs_stats_lock() so that the correct operation can be performed.
+ *
+ * \param[in] stats    statistics structure to unlock
+ * \param[in] opc      type of operation (current cpuid or number of structs)
+ * \param[in] flags    CPU interrupt saved state for IRQ-safe locking
+ */
+void lprocfs_stats_unlock(struct lprocfs_stats *stats,
+                         enum lprocfs_stats_lock_ops opc,
+                         unsigned long *flags)
+{
+       if (stats->ls_flags & LPROCFS_STATS_FLAG_NOPERCPU) {
+               if (stats->ls_flags & LPROCFS_STATS_FLAG_IRQ_SAFE)
+                       spin_unlock_irqrestore(&stats->ls_lock, *flags);
+               else
+                       spin_unlock(&stats->ls_lock);
+       } else if (opc == LPROCFS_GET_SMP_ID) {
+               put_cpu();
+       }
+}
+
+/** add up per-cpu counters */
 void lprocfs_stats_collect(struct lprocfs_stats *stats, int idx,
                           struct lprocfs_counter *cnt)
 {
@@ -559,16 +713,6 @@ void lprocfs_stats_collect(struct lprocfs_stats *stats, int idx,
        lprocfs_stats_unlock(stats, LPROCFS_GET_NUM_CPU, &flags);
 }
 
-/**
- * Append a space separated list of current set flags to str.
- */
-#define flag2str(flag)                                         \
-       do {                                                            \
-               if (imp->imp_##flag) {                                  \
-                       seq_printf(m, "%s" #flag, first ? "" : ", ");   \
-                       first = false;                                  \
-               }                                                       \
-       } while (0)
 static void obd_import_flags2str(struct obd_import *imp, struct seq_file *m)
 {
        bool first = true;
@@ -578,21 +722,19 @@ static void obd_import_flags2str(struct obd_import *imp, struct seq_file *m)
                first = false;
        }
 
-       flag2str(invalid);
-       flag2str(deactive);
-       flag2str(replayable);
-       flag2str(delayed_recovery);
-       flag2str(no_lock_replay);
-       flag2str(vbr_failed);
-       flag2str(pingable);
-       flag2str(resend_replay);
-       flag2str(no_pinger_recover);
-       flag2str(need_mne_swab);
-       flag2str(connect_tried);
+       flag2str(imp, invalid);
+       flag2str(imp, deactive);
+       flag2str(imp, replayable);
+       flag2str(imp, delayed_recovery);
+       flag2str(imp, vbr_failed);
+       flag2str(imp, pingable);
+       flag2str(imp, resend_replay);
+       flag2str(imp, no_pinger_recover);
+       flag2str(imp, connect_tried);
 }
-#undef flag2str
 
 static const char *obd_connect_names[] = {
+       /* flags names  */
        "read_only",
        "lov_index",
        "connect_from_mds",
@@ -606,7 +748,7 @@ static const char *obd_connect_names[] = {
        "truncate_lock",
        "initial_transno",
        "inode_bit_locks",
-       "join_file(obsolete)",
+       "barrier",
        "getattr_by_fid",
        "no_oh_for_devices",
        "remote_client",
@@ -652,48 +794,94 @@ static const char *obd_connect_names[] = {
        "unlink_close",
        "multi_mod_rpcs",
        "dir_stripe",
-       "unknown",
+       "subtree",
+       "lockahead",
+       "bulk_mbits",
+       "compact_obdo",
+       "second_flags",
+       /* flags2 names */
+       "file_secctx",
+       "lockaheadv2",
        NULL
 };
 
-static void obd_connect_seq_flags2str(struct seq_file *m, __u64 flags, char *sep)
+void obd_connect_seq_flags2str(struct seq_file *m, __u64 flags, __u64 flags2,
+                              const char *sep)
 {
        bool first = true;
-       __u64 mask = 1;
+       __u64 mask;
        int i;
 
-       for (i = 0; obd_connect_names[i] != NULL; i++, mask <<= 1) {
+       for (i = 0, mask = 1; i < 64; i++, mask <<= 1) {
                if (flags & mask) {
                        seq_printf(m, "%s%s",
                                   first ? "" : sep, obd_connect_names[i]);
                        first = false;
                }
        }
-       if (flags & ~(mask - 1))
-               seq_printf(m, "%sunknown_"LPX64,
+
+       if (flags & ~(mask - 1)) {
+               seq_printf(m, "%sunknown_%#llx",
                           first ? "" : sep, flags & ~(mask - 1));
+               first = false;
+       }
+
+       if (!(flags & OBD_CONNECT_FLAGS2) || flags2 == 0)
+               return;
+
+       for (i = 64, mask = 1; obd_connect_names[i] != NULL; i++, mask <<= 1) {
+               if (flags2 & mask) {
+                       seq_printf(m, "%s%s",
+                                  first ? "" : sep, obd_connect_names[i]);
+                       first = false;
+               }
+       }
+
+       if (flags2 & ~(mask - 1)) {
+               seq_printf(m, "%sunknown2_%#llx",
+                          first ? "" : sep, flags2 & ~(mask - 1));
+               first = false;
+       }
 }
+EXPORT_SYMBOL(obd_connect_seq_flags2str);
 
-int obd_connect_flags2str(char *page, int count, __u64 flags, char *sep)
+int obd_connect_flags2str(char *page, int count, __u64 flags, __u64 flags2,
+                         const char *sep)
 {
-       __u64 mask = 1;
+       __u64 mask;
        int i, ret = 0;
 
-       for (i = 0; obd_connect_names[i] != NULL; i++, mask <<= 1) {
+       for (i = 0, mask = 1; i < 64; i++, mask <<= 1) {
                if (flags & mask)
                        ret += snprintf(page + ret, count - ret, "%s%s",
                                        ret ? sep : "", obd_connect_names[i]);
        }
+
        if (flags & ~(mask - 1))
                ret += snprintf(page + ret, count - ret,
-                               "%sunknown_"LPX64,
+                               "%sunknown_%#llx",
                                ret ? sep : "", flags & ~(mask - 1));
+
+       if (!(flags & OBD_CONNECT_FLAGS2) || flags2 == 0)
+               return ret;
+
+       for (i = 64, mask = 1; obd_connect_names[i] != NULL; i++, mask <<= 1) {
+               if (flags2 & mask)
+                       ret += snprintf(page + ret, count - ret, "%s%s",
+                                       ret ? sep : "", obd_connect_names[i]);
+       }
+
+       if (flags2 & ~(mask - 1))
+               ret += snprintf(page + ret, count - ret,
+                               "%sunknown2_%#llx",
+                               ret ? sep : "", flags2 & ~(mask - 1));
+
        return ret;
 }
 EXPORT_SYMBOL(obd_connect_flags2str);
 
-static void obd_connect_data_seqprint(struct seq_file *m,
-                                     struct obd_connect_data *ocd)
+void
+obd_connect_data_seqprint(struct seq_file *m, struct obd_connect_data *ocd)
 {
        __u64 flags;
 
@@ -701,16 +889,16 @@ static void obd_connect_data_seqprint(struct seq_file *m,
        flags = ocd->ocd_connect_flags;
 
        seq_printf(m, "    connect_data:\n"
-                     "       flags: "LPX64"\n"
-                     "       instance: %u\n",
-                     ocd->ocd_connect_flags,
-                     ocd->ocd_instance);
+                  "       flags: %#llx\n"
+                  "       instance: %u\n",
+                  ocd->ocd_connect_flags,
+                  ocd->ocd_instance);
        if (flags & OBD_CONNECT_VERSION)
                seq_printf(m, "       target_version: %u.%u.%u.%u\n",
-                             OBD_OCD_VERSION_MAJOR(ocd->ocd_version),
-                             OBD_OCD_VERSION_MINOR(ocd->ocd_version),
-                             OBD_OCD_VERSION_PATCH(ocd->ocd_version),
-                             OBD_OCD_VERSION_FIX(ocd->ocd_version));
+                          OBD_OCD_VERSION_MAJOR(ocd->ocd_version),
+                          OBD_OCD_VERSION_MINOR(ocd->ocd_version),
+                          OBD_OCD_VERSION_PATCH(ocd->ocd_version),
+                          OBD_OCD_VERSION_FIX(ocd->ocd_version));
        if (flags & OBD_CONNECT_MDS)
                seq_printf(m, "       mdt_index: %d\n", ocd->ocd_group);
        if (flags & OBD_CONNECT_GRANT)
@@ -720,29 +908,31 @@ static void obd_connect_data_seqprint(struct seq_file *m,
        if (flags & OBD_CONNECT_BRW_SIZE)
                seq_printf(m, "       max_brw_size: %d\n", ocd->ocd_brw_size);
        if (flags & OBD_CONNECT_IBITS)
-               seq_printf(m, "       ibits_known: "LPX64"\n",
-                               ocd->ocd_ibits_known);
+               seq_printf(m, "       ibits_known: %#llx\n",
+                          ocd->ocd_ibits_known);
        if (flags & OBD_CONNECT_GRANT_PARAM)
                seq_printf(m, "       grant_block_size: %d\n"
-                             "       grant_inode_size: %d\n"
-                             "       grant_extent_overhead: %d\n",
-                             ocd->ocd_blocksize,
-                             ocd->ocd_inodespace,
-                             ocd->ocd_grant_extent);
+                          "       grant_inode_size: %d\n"
+                          "       grant_max_extent_size: %d\n"
+                          "       grant_extent_tax: %d\n",
+                          1 << ocd->ocd_grant_blkbits,
+                          1 << ocd->ocd_grant_inobits,
+                          ocd->ocd_grant_max_blks << ocd->ocd_grant_blkbits,
+                          ocd->ocd_grant_tax_kb << 10);
        if (flags & OBD_CONNECT_TRANSNO)
-               seq_printf(m, "       first_transno: "LPX64"\n",
-                               ocd->ocd_transno);
+               seq_printf(m, "       first_transno: %#llx\n",
+                          ocd->ocd_transno);
        if (flags & OBD_CONNECT_CKSUM)
                seq_printf(m, "       cksum_types: %#x\n",
-                             ocd->ocd_cksum_types);
+                          ocd->ocd_cksum_types);
        if (flags & OBD_CONNECT_MAX_EASIZE)
                seq_printf(m, "       max_easize: %d\n", ocd->ocd_max_easize);
        if (flags & OBD_CONNECT_MAXBYTES)
-               seq_printf(m, "       max_object_bytes: "LPU64"\n",
-                             ocd->ocd_maxbytes);
+               seq_printf(m, "       max_object_bytes: %llu\n",
+                          ocd->ocd_maxbytes);
        if (flags & OBD_CONNECT_MULTIMODRPCS)
                seq_printf(m, "       max_mod_rpcs: %hu\n",
-                             ocd->ocd_maxmodrpcs);
+                          ocd->ocd_maxmodrpcs);
 }
 
 int lprocfs_import_seq_show(struct seq_file *m, void *data)
@@ -764,23 +954,24 @@ int lprocfs_import_seq_show(struct seq_file *m, void *data)
        ocd = &imp->imp_connect_data;
 
        seq_printf(m, "import:\n"
-                     "    name: %s\n"
-                     "    target: %s\n"
-                     "    state: %s\n"
-                     "    connect_flags: [ ",
-                     obd->obd_name,
-                     obd2cli_tgt(obd),
-                     ptlrpc_import_state_name(imp->imp_state));
+                  "    name: %s\n"
+                  "    target: %s\n"
+                  "    state: %s\n"
+                  "    connect_flags: [ ",
+                  obd->obd_name,
+                  obd2cli_tgt(obd),
+                  ptlrpc_import_state_name(imp->imp_state));
        obd_connect_seq_flags2str(m, imp->imp_connect_data.ocd_connect_flags,
-                                       ", ");
+                                 imp->imp_connect_data.ocd_connect_flags2,
+                                 ", ");
        seq_printf(m, " ]\n");
        obd_connect_data_seqprint(m, ocd);
        seq_printf(m, "    import_flags: [ ");
        obd_import_flags2str(imp, m);
 
        seq_printf(m, " ]\n"
-                     "    connection:\n"
-                     "       failover_nids: [ ");
+                  "    connection:\n"
+                  "       failover_nids: [ ");
        spin_lock(&imp->imp_lock);
        j = 0;
        list_for_each_entry(conn, &imp->imp_conn_list, oic_item) {
@@ -795,14 +986,14 @@ int lprocfs_import_seq_show(struct seq_file *m, void *data)
        else
                strncpy(nidstr, "<none>", sizeof(nidstr));
        seq_printf(m, " ]\n"
-                     "       current_connection: %s\n"
-                     "       connection_attempts: %u\n"
-                     "       generation: %u\n"
-                     "       in-progress_invalidations: %u\n",
-                     nidstr,
-                     imp->imp_conn_cnt,
-                     imp->imp_generation,
-                     atomic_read(&imp->imp_inval_count));
+                  "       current_connection: %s\n"
+                  "       connection_attempts: %u\n"
+                  "       generation: %u\n"
+                  "       in-progress_invalidations: %u\n",
+                  nidstr,
+                  imp->imp_conn_cnt,
+                  imp->imp_generation,
+                  atomic_read(&imp->imp_inval_count));
        spin_unlock(&imp->imp_lock);
 
        if (obd->obd_svc_stats == NULL)
@@ -818,14 +1009,14 @@ int lprocfs_import_seq_show(struct seq_file *m, void *data)
        } else
                ret.lc_sum = 0;
        seq_printf(m, "    rpcs:\n"
-                     "       inflight: %u\n"
-                     "       unregistering: %u\n"
-                     "       timeouts: %u\n"
-                     "       avg_waittime: "LPU64" %s\n",
-                     atomic_read(&imp->imp_inflight),
-                     atomic_read(&imp->imp_unregistering),
-                     atomic_read(&imp->imp_timeouts),
-                     ret.lc_sum, header->lc_units);
+                  "       inflight: %u\n"
+                  "       unregistering: %u\n"
+                  "       timeouts: %u\n"
+                  "       avg_waittime: %llu %s\n",
+                  atomic_read(&imp->imp_inflight),
+                  atomic_read(&imp->imp_unregistering),
+                  atomic_read(&imp->imp_timeouts),
+                  ret.lc_sum, header->lc_units);
 
        k = 0;
        for(j = 0; j < IMP_AT_MAX_PORTALS; j++) {
@@ -835,18 +1026,18 @@ int lprocfs_import_seq_show(struct seq_file *m, void *data)
                          at_get(&imp->imp_at.iat_service_estimate[j]));
        }
        seq_printf(m, "    service_estimates:\n"
-                     "       services: %u sec\n"
-                     "       network: %u sec\n",
-                     k,
-                     at_get(&imp->imp_at.iat_net_latency));
+                  "       services: %u sec\n"
+                  "       network: %u sec\n",
+                  k,
+                  at_get(&imp->imp_at.iat_net_latency));
 
        seq_printf(m, "    transactions:\n"
-                     "       last_replay: "LPU64"\n"
-                     "       peer_committed: "LPU64"\n"
-                     "       last_checked: "LPU64"\n",
-                     imp->imp_last_replay_transno,
-                     imp->imp_peer_committed_transno,
-                     imp->imp_last_transno_checked);
+                  "       last_replay: %llu\n"
+                  "       peer_committed: %llu\n"
+                  "       last_checked: %llu\n",
+                  imp->imp_last_replay_transno,
+                  imp->imp_peer_committed_transno,
+                  imp->imp_last_transno_checked);
 
        /* avg data rates */
        for (rw = 0; rw <= 1; rw++) {
@@ -859,9 +1050,9 @@ int lprocfs_import_seq_show(struct seq_file *m, void *data)
                        do_div(sum, ret.lc_count);
                        ret.lc_sum = sum;
                        seq_printf(m, "    %s_data_averages:\n"
-                                     "       bytes_per_rpc: "LPU64"\n",
-                                     rw ? "write" : "read",
-                                     ret.lc_sum);
+                                  "       bytes_per_rpc: %llu\n",
+                                  rw ? "write" : "read",
+                                  ret.lc_sum);
                }
                k = (int)ret.lc_sum;
                j = opcode_offset(OST_READ + rw) + EXTRA_MAX_OPCODES;
@@ -872,12 +1063,12 @@ int lprocfs_import_seq_show(struct seq_file *m, void *data)
                        __u64 sum = ret.lc_sum;
                        do_div(sum, ret.lc_count);
                        ret.lc_sum = sum;
-                       seq_printf(m, "       %s_per_rpc: "LPU64"\n",
-                                       header->lc_units, ret.lc_sum);
+                       seq_printf(m, "       %s_per_rpc: %llu\n",
+                                  header->lc_units, ret.lc_sum);
                        j = (int)ret.lc_sum;
                        if (j > 0)
                                seq_printf(m, "       MB_per_sec: %u.%.02u\n",
-                                               k / j, (100 * k / j) % 100);
+                                          k / j, (100 * k / j) % 100);
                }
        }
 
@@ -906,9 +1097,8 @@ int lprocfs_state_seq_show(struct seq_file *m, void *data)
                        &imp->imp_state_hist[(k + j) % IMP_STATE_HIST_LEN];
                if (ish->ish_state == 0)
                        continue;
-               seq_printf(m, " - [ "CFS_TIME_T", %s ]\n",
-                          ish->ish_time,
-               ptlrpc_import_state_name(ish->ish_state));
+               seq_printf(m, " - [ %lld, %s ]\n", (s64)ish->ish_time,
+                          ptlrpc_import_state_name(ish->ish_state));
        }
 
        LPROCFS_CLIMP_EXIT(obd);
@@ -932,27 +1122,25 @@ int lprocfs_timeouts_seq_show(struct seq_file *m, void *data)
        struct obd_device *obd = (struct obd_device *)data;
        struct obd_import *imp;
        unsigned int cur, worst;
-       time_t now, worstt;
-       struct dhms ts;
+       time64_t now, worstt;
        int i;
 
        LASSERT(obd != NULL);
        LPROCFS_CLIMP_CHECK(obd);
        imp = obd->u.cli.cl_import;
 
-       now = cfs_time_current_sec();
+       now = ktime_get_real_seconds();
 
        /* Some network health info for kicks */
-       s2dhms(&ts, now - imp->imp_last_reply_time);
-       seq_printf(m, "%-10s : %ld, "DHMS_FMT" ago\n",
-                  "last reply", imp->imp_last_reply_time, DHMS_VARS(&ts));
+       seq_printf(m, "%-10s : %lld, %llds ago\n",
+                  "last reply", (s64)imp->imp_last_reply_time,
+                  (s64)(now - imp->imp_last_reply_time));
 
        cur = at_get(&imp->imp_at.iat_net_latency);
        worst = imp->imp_at.iat_net_latency.at_worst_ever;
        worstt = imp->imp_at.iat_net_latency.at_worst_time;
-       s2dhms(&ts, now - worstt);
-       seq_printf(m, "%-10s : cur %3u  worst %3u (at %ld, "DHMS_FMT" ago) ",
-                  "network", cur, worst, worstt, DHMS_VARS(&ts));
+       seq_printf(m, "%-10s : cur %3u  worst %3u (at %lld, %llds ago) ",
+                  "network", cur, worst, (s64)worstt, (s64)(now - worstt));
        lprocfs_at_hist_helper(m, &imp->imp_at.iat_net_latency);
 
        for(i = 0; i < IMP_AT_MAX_PORTALS; i++) {
@@ -961,10 +1149,9 @@ int lprocfs_timeouts_seq_show(struct seq_file *m, void *data)
                cur = at_get(&imp->imp_at.iat_service_estimate[i]);
                worst = imp->imp_at.iat_service_estimate[i].at_worst_ever;
                worstt = imp->imp_at.iat_service_estimate[i].at_worst_time;
-               s2dhms(&ts, now - worstt);
-               seq_printf(m, "portal %-2d  : cur %3u  worst %3u (at %ld, "
-                          DHMS_FMT" ago) ", imp->imp_at.iat_portal[i],
-                          cur, worst, worstt, DHMS_VARS(&ts));
+               seq_printf(m, "portal %-2d  : cur %3u  worst %3u (at %lld, %llds ago) ",
+                          imp->imp_at.iat_portal[i], cur, worst, (s64)worstt,
+                          (s64)(now - worstt));
                lprocfs_at_hist_helper(m, &imp->imp_at.iat_service_estimate[i]);
        }
 
@@ -977,25 +1164,96 @@ int lprocfs_connect_flags_seq_show(struct seq_file *m, void *data)
 {
        struct obd_device *obd = data;
        __u64 flags;
+       __u64 flags2;
 
        LPROCFS_CLIMP_CHECK(obd);
        flags = obd->u.cli.cl_import->imp_connect_data.ocd_connect_flags;
-       seq_printf(m, "flags="LPX64"\n", flags);
-       obd_connect_seq_flags2str(m, flags, "\n");
+       flags2 = obd->u.cli.cl_import->imp_connect_data.ocd_connect_flags2;
+       seq_printf(m, "flags=%#llx\n", flags);
+       seq_printf(m, "flags2=%#llx\n", flags2);
+       obd_connect_seq_flags2str(m, flags, flags2, "\n");
        seq_printf(m, "\n");
        LPROCFS_CLIMP_EXIT(obd);
        return 0;
 }
 EXPORT_SYMBOL(lprocfs_connect_flags_seq_show);
 
-int
-lprocfs_obd_setup(struct obd_device *obd)
+static struct attribute *obd_def_uuid_attrs[] = {
+       &lustre_attr_uuid.attr,
+       NULL,
+};
+
+static struct attribute *obd_def_attrs[] = {
+       &lustre_attr_blocksize.attr,
+       &lustre_attr_kbytestotal.attr,
+       &lustre_attr_kbytesfree.attr,
+       &lustre_attr_kbytesavail.attr,
+       &lustre_attr_filestotal.attr,
+       &lustre_attr_filesfree.attr,
+       &lustre_attr_uuid.attr,
+       NULL,
+};
+
+static void obd_sysfs_release(struct kobject *kobj)
 {
-       int rc = 0;
+       struct obd_device *obd = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
 
-       LASSERT(obd != NULL);
-       LASSERT(obd->obd_magic == OBD_DEVICE_MAGIC);
-       LASSERT(obd->obd_type->typ_procroot != NULL);
+       complete(&obd->obd_kobj_unregister);
+}
+
+int lprocfs_obd_setup(struct obd_device *obd, bool uuid_only)
+{
+       struct lprocfs_vars *debugfs_vars = NULL;
+       int rc;
+
+       if (!obd || obd->obd_magic != OBD_DEVICE_MAGIC)
+               return -ENODEV;
+
+       rc = kobject_set_name(&obd->obd_kset.kobj, "%s", obd->obd_name);
+       if (rc)
+               return rc;
+
+       obd->obd_ktype.sysfs_ops = &lustre_sysfs_ops;
+       obd->obd_ktype.release = obd_sysfs_release;
+       if (obd->obd_attrs)
+               obd->obd_ktype.default_attrs = obd->obd_attrs;
+
+       obd->obd_kset.kobj.parent = obd->obd_type->typ_kobj;
+       obd->obd_kset.kobj.ktype = &obd->obd_ktype;
+       init_completion(&obd->obd_kobj_unregister);
+       rc = kset_register(&obd->obd_kset);
+       if (rc)
+               return rc;
+
+       if (uuid_only)
+               obd->obd_attrs_group.attrs = obd_def_uuid_attrs;
+       else
+               obd->obd_attrs_group.attrs = obd_def_attrs;
+
+       rc = sysfs_create_group(&obd->obd_kset.kobj, &obd->obd_attrs_group);
+       if (rc) {
+               kset_unregister(&obd->obd_kset);
+               return rc;
+       }
+
+       if (!obd->obd_type->typ_procroot)
+               debugfs_vars = obd->obd_vars;
+       obd->obd_debugfs_entry = ldebugfs_register(obd->obd_name,
+                                                  obd->obd_type->typ_debugfs_entry,
+                                                  debugfs_vars, obd);
+       if (IS_ERR_OR_NULL(obd->obd_debugfs_entry)) {
+               rc = obd->obd_debugfs_entry ? PTR_ERR(obd->obd_debugfs_entry)
+                                           : -ENOMEM;
+               CERROR("error %d setting up debugfs for %s\n",
+                      rc, obd->obd_name);
+               obd->obd_debugfs_entry = NULL;
+               lprocfs_obd_cleanup(obd);
+               return rc;
+       }
+
+       if (obd->obd_proc_entry || !obd->obd_type->typ_procroot)
+               GOTO(already_registered, rc);
 
        obd->obd_proc_entry = lprocfs_register(obd->obd_name,
                                               obd->obd_type->typ_procroot,
@@ -1004,25 +1262,37 @@ lprocfs_obd_setup(struct obd_device *obd)
                rc = PTR_ERR(obd->obd_proc_entry);
                CERROR("error %d setting up lprocfs for %s\n",rc,obd->obd_name);
                obd->obd_proc_entry = NULL;
+               lprocfs_obd_cleanup(obd);
        }
+already_registered:
        return rc;
 }
 EXPORT_SYMBOL(lprocfs_obd_setup);
 
 int lprocfs_obd_cleanup(struct obd_device *obd)
 {
-        if (!obd)
-                return -EINVAL;
-        if (obd->obd_proc_exports_entry) {
-                /* Should be no exports left */
-                lprocfs_remove(&obd->obd_proc_exports_entry);
-                obd->obd_proc_exports_entry = NULL;
-        }
-        if (obd->obd_proc_entry) {
-                lprocfs_remove(&obd->obd_proc_entry);
-                obd->obd_proc_entry = NULL;
-        }
-        return 0;
+       if (!obd)
+               return -EINVAL;
+
+       if (obd->obd_proc_exports_entry) {
+               /* Should be no exports left */
+               lprocfs_remove(&obd->obd_proc_exports_entry);
+               obd->obd_proc_exports_entry = NULL;
+       }
+
+       if (obd->obd_proc_entry) {
+               lprocfs_remove(&obd->obd_proc_entry);
+               obd->obd_proc_entry = NULL;
+       }
+
+       if (!IS_ERR_OR_NULL(obd->obd_debugfs_entry))
+               ldebugfs_remove(&obd->obd_debugfs_entry);
+
+       sysfs_remove_group(&obd->obd_kset.kobj, &obd->obd_attrs_group);
+       kset_unregister(&obd->obd_kset);
+       wait_for_completion(&obd->obd_kobj_unregister);
+
+       return 0;
 }
 EXPORT_SYMBOL(lprocfs_obd_cleanup);
 
@@ -1146,6 +1416,32 @@ void lprocfs_free_stats(struct lprocfs_stats **statsh)
 }
 EXPORT_SYMBOL(lprocfs_free_stats);
 
+u64 lprocfs_stats_collector(struct lprocfs_stats *stats, int idx,
+                           enum lprocfs_fields_flags field)
+{
+       unsigned long flags = 0;
+       unsigned int num_cpu;
+       unsigned int i;
+       u64 ret = 0;
+
+       LASSERT(stats);
+
+       num_cpu = lprocfs_stats_lock(stats, LPROCFS_GET_NUM_CPU, &flags);
+       for (i = 0; i < num_cpu; i++) {
+               struct lprocfs_counter *cntr;
+
+               if (!stats->ls_percpu[i])
+                       continue;
+
+               cntr = lprocfs_stats_counter_get(stats, i, idx);
+               ret += lprocfs_read_helper(cntr, &stats->ls_cnt_header[idx],
+                                          stats->ls_flags, field);
+       }
+       lprocfs_stats_unlock(stats, LPROCFS_GET_NUM_CPU, &flags);
+       return ret;
+}
+EXPORT_SYMBOL(lprocfs_stats_collector);
+
 void lprocfs_clear_stats(struct lprocfs_stats *stats)
 {
        struct lprocfs_counter          *percpu_cntr;
@@ -1212,42 +1508,32 @@ static int lprocfs_stats_seq_show(struct seq_file *p, void *v)
        struct lprocfs_counter_header   *hdr;
        struct lprocfs_counter           ctr;
        int                              idx    = *(loff_t *)v;
-       int                              rc     = 0;
 
        if (idx == 0) {
-               struct timeval now;
+               struct timespec64 now;
 
-               do_gettimeofday(&now);
-               rc = seq_printf(p, "%-25s %lu.%lu secs.usecs\n",
-                               "snapshot_time", now.tv_sec, now.tv_usec);
-               if (rc < 0)
-                       return rc;
+               ktime_get_real_ts64(&now);
+               seq_printf(p, "%-25s %llu.%09lu secs.nsecs\n",
+                          "snapshot_time", (s64)now.tv_sec, now.tv_nsec);
        }
 
        hdr = &stats->ls_cnt_header[idx];
        lprocfs_stats_collect(stats, idx, &ctr);
 
        if (ctr.lc_count == 0)
-               goto out;
+               return 0;
 
-       rc = seq_printf(p, "%-25s "LPD64" samples [%s]", hdr->lc_name,
-                       ctr.lc_count, hdr->lc_units);
-       if (rc < 0)
-               goto out;
+       seq_printf(p, "%-25s %lld samples [%s]", hdr->lc_name,
+                  ctr.lc_count, hdr->lc_units);
 
        if ((hdr->lc_config & LPROCFS_CNTR_AVGMINMAX) && ctr.lc_count > 0) {
-               rc = seq_printf(p, " "LPD64" "LPD64" "LPD64,
-                               ctr.lc_min, ctr.lc_max, ctr.lc_sum);
-               if (rc < 0)
-                       goto out;
+               seq_printf(p, " %lld %lld %lld",
+                          ctr.lc_min, ctr.lc_max, ctr.lc_sum);
                if (hdr->lc_config & LPROCFS_CNTR_STDDEV)
-                       rc = seq_printf(p, " "LPD64, ctr.lc_sumsquare);
-               if (rc < 0)
-                       goto out;
+                       seq_printf(p, " %llu", ctr.lc_sumsquare);
        }
-       rc = seq_printf(p, "\n");
-out:
-       return (rc < 0) ? rc : 0;
+       seq_putc(p, '\n');
+       return 0;
 }
 
 static const struct seq_operations lprocfs_stats_seq_sops = {
@@ -1270,7 +1556,7 @@ static int lprocfs_stats_seq_open(struct inode *inode, struct file *file)
        if (rc)
                return rc;
        seq = file->private_data;
-       seq->private = PDE_DATA(inode);
+       seq->private = inode->i_private ? inode->i_private : PDE_DATA(inode);
        return 0;
 }
 
@@ -1283,6 +1569,22 @@ static const struct file_operations lprocfs_stats_seq_fops = {
         .release = lprocfs_seq_release,
 };
 
+int ldebugfs_register_stats(struct dentry *parent, const char *name,
+                           struct lprocfs_stats *stats)
+{
+       struct dentry *entry;
+
+       LASSERT(!IS_ERR_OR_NULL(parent));
+
+       entry = debugfs_create_file(name, 0644, parent, stats,
+                                   &lprocfs_stats_seq_fops);
+       if (IS_ERR_OR_NULL(entry))
+               return entry ? PTR_ERR(entry) : -ENOMEM;
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(ldebugfs_register_stats);
+
 int lprocfs_register_stats(struct proc_dir_entry *root, const char *name,
                            struct lprocfs_stats *stats)
 {
@@ -1348,9 +1650,8 @@ EXPORT_SYMBOL(lprocfs_counter_init);
 
 void lprocfs_init_mps_stats(int num_private_stats, struct lprocfs_stats *stats)
 {
-        LPROCFS_MD_OP_INIT(num_private_stats, stats, getstatus);
+       LPROCFS_MD_OP_INIT(num_private_stats, stats, get_root);
         LPROCFS_MD_OP_INIT(num_private_stats, stats, null_inode);
-        LPROCFS_MD_OP_INIT(num_private_stats, stats, find_cbdata);
         LPROCFS_MD_OP_INIT(num_private_stats, stats, close);
         LPROCFS_MD_OP_INIT(num_private_stats, stats, create);
         LPROCFS_MD_OP_INIT(num_private_stats, stats, enqueue);
@@ -1374,9 +1675,6 @@ void lprocfs_init_mps_stats(int num_private_stats, struct lprocfs_stats *stats)
         LPROCFS_MD_OP_INIT(num_private_stats, stats, set_lock_data);
         LPROCFS_MD_OP_INIT(num_private_stats, stats, lock_match);
         LPROCFS_MD_OP_INIT(num_private_stats, stats, cancel_unused);
-        LPROCFS_MD_OP_INIT(num_private_stats, stats, renew_capa);
-        LPROCFS_MD_OP_INIT(num_private_stats, stats, unpack_capa);
-        LPROCFS_MD_OP_INIT(num_private_stats, stats, get_remote_perm);
         LPROCFS_MD_OP_INIT(num_private_stats, stats, intent_getattr_async);
         LPROCFS_MD_OP_INIT(num_private_stats, stats, revalidate_lock);
 }
@@ -1508,56 +1806,6 @@ __s64 lprocfs_read_helper(struct lprocfs_counter *lc,
 }
 EXPORT_SYMBOL(lprocfs_read_helper);
 
-int lprocfs_write_helper(const char __user *buffer, unsigned long count,
-                         int *val)
-{
-        return lprocfs_write_frac_helper(buffer, count, val, 1);
-}
-EXPORT_SYMBOL(lprocfs_write_helper);
-
-int lprocfs_write_frac_helper(const char __user *buffer, unsigned long count,
-                              int *val, int mult)
-{
-        char kernbuf[20], *end, *pbuf;
-
-        if (count > (sizeof(kernbuf) - 1))
-                return -EINVAL;
-
-       if (copy_from_user(kernbuf, buffer, count))
-                return -EFAULT;
-
-        kernbuf[count] = '\0';
-        pbuf = kernbuf;
-        if (*pbuf == '-') {
-                mult = -mult;
-                pbuf++;
-        }
-
-        *val = (int)simple_strtoul(pbuf, &end, 10) * mult;
-        if (pbuf == end)
-                return -EINVAL;
-
-        if (end != NULL && *end == '.') {
-                int temp_val, pow = 1;
-                int i;
-
-                pbuf = end + 1;
-                if (strlen(pbuf) > 5)
-                        pbuf[5] = '\0'; /*only allow 5bits fractional*/
-
-                temp_val = (int)simple_strtoul(pbuf, &end, 10) * mult;
-
-                if (pbuf < end) {
-                        for (i = 0; i < (end - pbuf); i++)
-                                pow *= 10;
-
-                        *val += temp_val / pow;
-                }
-        }
-        return 0;
-}
-EXPORT_SYMBOL(lprocfs_write_frac_helper);
-
 int lprocfs_read_frac_helper(char *buffer, unsigned long count, long val,
                              int mult)
 {
@@ -1611,6 +1859,7 @@ int lprocfs_read_frac_helper(char *buffer, unsigned long count, long val,
         buffer[prtn++] ='\n';
         return prtn;
 }
+EXPORT_SYMBOL(lprocfs_read_frac_helper);
 
 int lprocfs_seq_read_frac_helper(struct seq_file *m, long val, int mult)
 {
@@ -1637,79 +1886,293 @@ int lprocfs_seq_read_frac_helper(struct seq_file *m, long val, int mult)
 }
 EXPORT_SYMBOL(lprocfs_seq_read_frac_helper);
 
-int lprocfs_write_u64_helper(const char __user *buffer, unsigned long count,
-                            __u64 *val)
+/* Obtains the conversion factor for the unit specified */
+static int get_mult(char unit, __u64 *mult)
+{
+       __u64 units = 1;
+
+       switch (unit) {
+       /* peta, tera, giga, mega, and kilo */
+       case 'p':
+       case 'P':
+               units <<= 10;
+       case 't':
+       case 'T':
+               units <<= 10;
+       case 'g':
+       case 'G':
+               units <<= 10;
+       case 'm':
+       case 'M':
+               units <<= 10;
+       case 'k':
+       case 'K':
+               units <<= 10;
+               break;
+       /* some tests expect % to be accepted */
+       case '%':
+               units = 1;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       *mult = units;
+
+       return 0;
+}
+
+/*
+ * Ensures the numeric string is valid. The function provides the final
+ * multiplier in the case a unit exists at the end of the string. It also
+ * locates the start of the whole and fractional parts (if any). This
+ * function modifies the string so kstrtoull can be used to parse both
+ * the whole and fraction portions. This function also figures out
+ * the base of the number.
+ */
+static int preprocess_numeric_str(char *buffer, __u64 *mult, __u64 def_mult,
+                                 bool allow_units, char **whole, char **frac,
+                                 unsigned int *base)
 {
-        return lprocfs_write_frac_u64_helper(buffer, count, val, 1);
+       bool hit_decimal = false;
+       bool hit_unit = false;
+       int rc = 0;
+       char *start;
+       *mult = def_mult;
+       *whole = NULL;
+       *frac = NULL;
+       *base = 10;
+
+       /* a hex string if it starts with "0x" */
+       if (buffer[0] == '0' && tolower(buffer[1]) == 'x') {
+               *base = 16;
+               buffer += 2;
+       }
+
+       start = buffer;
+
+       while (*buffer) {
+               /* allow for a single new line before the null terminator */
+               if (*buffer == '\n') {
+                       *buffer = '\0';
+                       buffer++;
+
+                       if (*buffer)
+                               return -EINVAL;
+
+                       break;
+               }
+
+               /* any chars after our unit indicates a malformed string */
+               if (hit_unit)
+                       return -EINVAL;
+
+               /* ensure we only hit one decimal */
+               if (*buffer == '.') {
+                       if (hit_decimal)
+                               return -EINVAL;
+
+                       /* if past start, there's a whole part */
+                       if (start != buffer)
+                               *whole = start;
+
+                       *buffer = '\0';
+                       start = buffer + 1;
+                       hit_decimal = true;
+               } else if (!isdigit(*buffer) &&
+                          !(*base == 16 && isxdigit(*buffer))) {
+                       if (allow_units) {
+                               /* if we allow units, attempt to get mult */
+                               hit_unit = true;
+                               rc = get_mult(*buffer, mult);
+                               if (rc)
+                                       return rc;
+
+                               /* string stops here, but keep processing */
+                               *buffer = '\0';
+                       } else {
+                               /* bad string */
+                               return -EINVAL;
+                       }
+               }
+
+               buffer++;
+       }
+
+       if (hit_decimal) {
+               /* hit a decimal, make sure there's a fractional part */
+               if (!*start)
+                       return -EINVAL;
+
+               *frac = start;
+       } else {
+               /* didn't hit a decimal, but may have a whole part */
+               if (start != buffer && *start)
+                       *whole = start;
+       }
+
+       /* malformed string if we didn't get anything */
+       if (!*frac && !*whole)
+               return -EINVAL;
+
+       return 0;
 }
-EXPORT_SYMBOL(lprocfs_write_u64_helper);
 
-int lprocfs_write_frac_u64_helper(const char __user *buffer,
-                                 unsigned long count,
-                                 __u64 *val, int mult)
+/*
+ * Parses a numeric string which can contain a whole and fraction portion
+ * into a __u64. Accepts a multiplier to apply to the value parsed. Also
+ * allows the string to have a unit at the end. The function handles
+ * wrapping of the final unsigned value.
+ */
+static int str_to_u64_parse(char *buffer, unsigned long count,
+                           __u64 *val, __u64 def_mult, bool allow_units)
 {
-        char kernbuf[22], *end, *pbuf;
-        __u64 whole, frac = 0, units;
-        unsigned frac_d = 1;
+       __u64 whole = 0;
+       __u64 frac = 0;
+       unsigned int frac_d = 1;
+       __u64 wrap_indicator = ULLONG_MAX;
+       int rc = 0;
+       __u64 mult;
+       char *strwhole;
+       char *strfrac;
+       unsigned int base = 10;
 
-        if (count > (sizeof(kernbuf) - 1))
-                return -EINVAL;
+       rc = preprocess_numeric_str(buffer, &mult, def_mult, allow_units,
+                                   &strwhole, &strfrac, &base);
 
-       if (copy_from_user(kernbuf, buffer, count))
-                return -EFAULT;
+       if (rc)
+               return rc;
 
-        kernbuf[count] = '\0';
-        pbuf = kernbuf;
-        if (*pbuf == '-') {
-                mult = -mult;
-                pbuf++;
-        }
+       if (mult == 0) {
+               *val = 0;
+               return 0;
+       }
 
-        whole = simple_strtoull(pbuf, &end, 10);
-        if (pbuf == end)
-                return -EINVAL;
+       /* the multiplier limits how large the value can be */
+       wrap_indicator /=  mult;
 
-        if (end != NULL && *end == '.') {
-                int i;
-                pbuf = end + 1;
+       if (strwhole) {
+               rc = kstrtoull(strwhole, base, &whole);
+               if (rc)
+                       return rc;
 
-                /* need to limit frac_d to a __u32 */
-                if (strlen(pbuf) > 10)
-                        pbuf[10] = '\0';
+               if (whole > wrap_indicator)
+                       return -ERANGE;
 
-                frac = simple_strtoull(pbuf, &end, 10);
-                /* count decimal places */
-                for (i = 0; i < (end - pbuf); i++)
-                        frac_d *= 10;
-        }
+               whole *= mult;
+       }
+
+       if (strfrac) {
+               if (strlen(strfrac) > 10)
+                       strfrac[10] = '\0';
 
-        units = 1;
-       if (end != NULL) {
-               switch (*end) {
-               case 'p': case 'P':
-                       units <<= 10;
-               case 't': case 'T':
-                       units <<= 10;
-               case 'g': case 'G':
-                       units <<= 10;
-               case 'm': case 'M':
-                       units <<= 10;
-               case 'k': case 'K':
-                       units <<= 10;
+               rc = kstrtoull(strfrac, base, &frac);
+               if (rc)
+                       return rc;
+
+               /* determine power of fractional portion */
+               while (*strfrac) {
+                       frac_d *= base;
+                       strfrac++;
                }
+
+               /* fractional portion is too large to perform calculation */
+               if (frac > wrap_indicator)
+                       return -ERANGE;
+
+               frac *= mult;
+               do_div(frac, frac_d);
+       }
+
+       /* check that the sum of whole and fraction fits in u64 */
+       if (whole > (ULLONG_MAX - frac))
+               return -ERANGE;
+
+       *val = whole + frac;
+
+       return 0;
+}
+
+/*
+ * This function parses numeric/hex strings into __s64. It accepts a multiplier
+ * which will apply to the value parsed. It also can allow the string to
+ * have a unit as the last character. The function handles overflow/underflow
+ * of the signed integer.
+ */
+static int str_to_s64_internal(const char __user *buffer, unsigned long count,
+                              __s64 *val, __u64 def_mult, bool allow_units)
+{
+       char kernbuf[22];
+       __u64 tmp;
+       unsigned int offset = 0;
+       int signed sign = 1;
+       __u64 max = LLONG_MAX;
+       int rc = 0;
+
+       if (count > (sizeof(kernbuf) - 1))
+               return -EINVAL;
+
+       if (copy_from_user(kernbuf, buffer, count))
+               return -EFAULT;
+
+       kernbuf[count] = '\0';
+
+       /* keep track of our sign */
+       if (*kernbuf == '-') {
+               sign = -1;
+               offset++;
+               /* equivalent to max = -LLONG_MIN, avoids overflow */
+               max++;
        }
-        /* Specified units override the multiplier */
-       if (units > 1)
-                mult = mult < 0 ? -units : units;
 
-        frac *= mult;
-        do_div(frac, frac_d);
-        *val = whole * mult + frac;
-        return 0;
+       rc = str_to_u64_parse(kernbuf + offset, count - offset,
+                             &tmp, def_mult, allow_units);
+       if (rc)
+               return rc;
+
+       /* check for overflow/underflow */
+       if (max < tmp)
+               return -ERANGE;
+
+       *val = (__s64)tmp * sign;
+
+       return 0;
+}
+
+/**
+ * Convert a user string into a signed 64 bit number. This function produces
+ * an error when the value parsed from the string times multiplier underflows or
+ * overflows. This function only accepts strings that contains digits, an
+ * optional decimal, and a char representing a unit at the end. If a unit is
+ * specified in the string, the multiplier provided by the caller is ignored.
+ * This function can also accept hexadecimal strings which are prefixed with
+ * "0x".
+ *
+ * \param[in] buffer   string consisting of numbers, a decimal, and a unit
+ * \param[in] count    buffer length
+ * \param[in] val      if successful, the value represented by the string
+ * \param[in] defunit  default unit if string doesn't contain one
+ *
+ * \retval             0 on success
+ * \retval             negative number on error
+ */
+int lprocfs_str_with_units_to_s64(const char __user *buffer,
+                                 unsigned long count, __s64 *val, char defunit)
+{
+       __u64 mult = 1;
+       int rc;
+
+       if (defunit != '1') {
+               rc = get_mult(defunit, &mult);
+               if (rc)
+                       return rc;
+       }
+
+       return str_to_s64_internal(buffer, count, val, mult, true);
 }
-EXPORT_SYMBOL(lprocfs_write_frac_u64_helper);
+EXPORT_SYMBOL(lprocfs_str_with_units_to_s64);
 
-static char *lprocfs_strnstr(const char *s1, const char *s2, size_t len)
+char *lprocfs_strnstr(const char *s1, const char *s2, size_t len)
 {
        size_t l2;
 
@@ -1724,6 +2187,7 @@ static char *lprocfs_strnstr(const char *s1, const char *s2, size_t len)
        }
        return NULL;
 }
+EXPORT_SYMBOL(lprocfs_strnstr);
 
 /**
  * Find the string \a name in the input \a buffer, and return a pointer to the
@@ -1755,6 +2219,22 @@ char *lprocfs_find_named_value(const char *buffer, const char *name,
 }
 EXPORT_SYMBOL(lprocfs_find_named_value);
 
+int ldebugfs_seq_create(struct dentry *parent, const char *name, umode_t mode,
+                       const struct file_operations *seq_fops, void *data)
+{
+       struct dentry *entry;
+
+       /* Disallow secretly (un)writable entries. */
+       LASSERT((!seq_fops->write) == (!(mode & 0222)));
+
+       entry = debugfs_create_file(name, mode, parent, data, seq_fops);
+       if (IS_ERR_OR_NULL(entry))
+               return entry ? PTR_ERR(entry) : -ENOMEM;
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(ldebugfs_seq_create);
+
 int lprocfs_seq_create(struct proc_dir_entry *parent,
                       const char *name,
                       mode_t mode,
@@ -1828,32 +2308,133 @@ void lprocfs_oh_clear(struct obd_histogram *oh)
 }
 EXPORT_SYMBOL(lprocfs_oh_clear);
 
-int lprocfs_obd_rd_max_pages_per_rpc(char *page, char **start, off_t off,
-                                    int count, int *eof, void *data)
+ssize_t lustre_attr_show(struct kobject *kobj,
+                        struct attribute *attr, char *buf)
+{
+       struct lustre_attr *a = container_of(attr, struct lustre_attr, attr);
+
+       return a->show ? a->show(kobj, attr, buf) : 0;
+}
+EXPORT_SYMBOL_GPL(lustre_attr_show);
+
+ssize_t lustre_attr_store(struct kobject *kobj, struct attribute *attr,
+                         const char *buf, size_t len)
+{
+       struct lustre_attr *a = container_of(attr, struct lustre_attr, attr);
+
+       return a->store ? a->store(kobj, attr, buf, len) : len;
+}
+EXPORT_SYMBOL_GPL(lustre_attr_store);
+
+const struct sysfs_ops lustre_sysfs_ops = {
+       .show  = lustre_attr_show,
+       .store = lustre_attr_store,
+};
+EXPORT_SYMBOL_GPL(lustre_sysfs_ops);
+
+int lprocfs_obd_max_pages_per_rpc_seq_show(struct seq_file *m, void *data)
 {
        struct obd_device *dev = data;
        struct client_obd *cli = &dev->u.cli;
-       int rc;
 
        spin_lock(&cli->cl_loi_list_lock);
-       rc = snprintf(page, count, "%d\n", cli->cl_max_pages_per_rpc);
+       seq_printf(m, "%d\n", cli->cl_max_pages_per_rpc);
        spin_unlock(&cli->cl_loi_list_lock);
+       return 0;
+}
+EXPORT_SYMBOL(lprocfs_obd_max_pages_per_rpc_seq_show);
 
+ssize_t lprocfs_obd_max_pages_per_rpc_seq_write(struct file *file,
+                                               const char __user *buffer,
+                                               size_t count, loff_t *off)
+{
+       struct obd_device *dev =
+               ((struct seq_file *)file->private_data)->private;
+       struct client_obd *cli = &dev->u.cli;
+       struct obd_connect_data *ocd = &cli->cl_import->imp_connect_data;
+       int chunk_mask, rc;
+       s64 val;
+
+       rc = lprocfs_str_with_units_to_s64(buffer, count, &val, '1');
+       if (rc)
+               return rc;
+       if (val < 0)
+               return -ERANGE;
+
+       /* if the max_pages is specified in bytes, convert to pages */
+       if (val >= ONE_MB_BRW_SIZE)
+               val >>= PAGE_SHIFT;
+
+       LPROCFS_CLIMP_CHECK(dev);
+
+       chunk_mask = ~((1 << (cli->cl_chunkbits - PAGE_SHIFT)) - 1);
+       /* max_pages_per_rpc must be chunk aligned */
+       val = (val + ~chunk_mask) & chunk_mask;
+       if (val == 0 || (ocd->ocd_brw_size != 0 &&
+                        val > ocd->ocd_brw_size >> PAGE_SHIFT)) {
+               LPROCFS_CLIMP_EXIT(dev);
+               return -ERANGE;
+       }
+       spin_lock(&cli->cl_loi_list_lock);
+       cli->cl_max_pages_per_rpc = val;
+       client_adjust_max_dirty(cli);
+       spin_unlock(&cli->cl_loi_list_lock);
+
+       LPROCFS_CLIMP_EXIT(dev);
+       return count;
+}
+EXPORT_SYMBOL(lprocfs_obd_max_pages_per_rpc_seq_write);
+
+ssize_t short_io_bytes_show(struct kobject *kobj, struct attribute *attr,
+                           char *buf)
+{
+       struct obd_device *dev = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+       struct client_obd *cli = &dev->u.cli;
+       int rc;
+
+       spin_lock(&cli->cl_loi_list_lock);
+       rc = sprintf(buf, "%d\n", cli->cl_short_io_bytes);
+       spin_unlock(&cli->cl_loi_list_lock);
        return rc;
 }
+EXPORT_SYMBOL(short_io_bytes_show);
 
-int lprocfs_obd_max_pages_per_rpc_seq_show(struct seq_file *m, void *data)
+/* Used to catch people who think they're specifying pages. */
+#define MIN_SHORT_IO_BYTES 64
+
+ssize_t short_io_bytes_store(struct kobject *kobj, struct attribute *attr,
+                            const char *buffer, size_t count)
 {
-       struct obd_device *dev = data;
+       struct obd_device *dev = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
        struct client_obd *cli = &dev->u.cli;
+       u32 val;
        int rc;
 
+       LPROCFS_CLIMP_CHECK(dev);
+
+       rc = kstrtouint(buffer, 0, &val);
+       if (rc)
+               GOTO(out, rc);
+
+       if (val < MIN_SHORT_IO_BYTES || val > OBD_MAX_SHORT_IO_BYTES)
+               GOTO(out, rc = -ERANGE);
+
+       rc = count;
+
        spin_lock(&cli->cl_loi_list_lock);
-       rc = seq_printf(m, "%d\n", cli->cl_max_pages_per_rpc);
+       if (val > (cli->cl_max_pages_per_rpc << PAGE_SHIFT))
+               rc = -ERANGE;
+       else
+               cli->cl_short_io_bytes = val;
        spin_unlock(&cli->cl_loi_list_lock);
+
+out:
+       LPROCFS_CLIMP_EXIT(dev);
        return rc;
 }
-EXPORT_SYMBOL(lprocfs_obd_max_pages_per_rpc_seq_show);
+EXPORT_SYMBOL(short_io_bytes_store);
 
 int lprocfs_wr_root_squash(const char __user *buffer, unsigned long count,
                           struct root_squash_info *squash, char *name)
@@ -1924,6 +2505,7 @@ int lprocfs_wr_nosquash_nids(const char __user *buffer, unsigned long count,
        char *kernbuf = NULL;
        char *errmsg;
        struct list_head tmp;
+       int len = count;
        ENTRY;
 
        if (count > 4096) {
@@ -1943,9 +2525,10 @@ int lprocfs_wr_nosquash_nids(const char __user *buffer, unsigned long count,
        kernbuf[count] = '\0';
 
        if (count > 0 && kernbuf[count - 1] == '\n')
-               kernbuf[count - 1] = '\0';
+               len = count - 1;
 
-       if (strcmp(kernbuf, "NONE") == 0 || strcmp(kernbuf, "clear") == 0) {
+       if ((len == 4 && strncmp(kernbuf, "NONE", len) == 0) ||
+           (len == 5 && strncmp(kernbuf, "clear", len) == 0)) {
                /* empty string is special case */
                down_write(&squash->rsi_sem);
                if (!list_empty(&squash->rsi_nosquash_nids))