LU-6142 lustre: no need to check debugfs return values

[fs/lustre-release.git] / lustre / obdclass / local_storage.c

diff --git a/lustre/obdclass/local_storage.c b/lustre/obdclass/local_storage.c
index 453bedc..c5d8935 100644 (file)
--- a/lustre/obdclass/local_storage.c
+++ b/lustre/obdclass/local_storage.c
@@ -20,7 +20,7 @@
  * GPL HEADER END
  */
 /*
- * Copyright (c) 2012, 2015, Intel Corporation.
+ * Copyright (c) 2012, 2017, Intel Corporation.
  */
 /*
  * lustre/obdclass/local_storage.c
@@ -65,7 +65,8 @@ static void ls_object_free(const struct lu_env *env, struct lu_object *o)
 
        dt_object_fini(&obj->ls_obj);
        lu_object_header_fini(h);
-       OBD_FREE_PTR(obj);
+       OBD_FREE_PRE(obj, sizeof(*obj), "kfreed");
+       kfree_rcu(obj, ls_header.loh_rcu);
 }
 
 static struct lu_object_operations ls_lu_obj_ops = {
@@ -371,7 +372,7 @@ static struct dt_object *__local_file_create(const struct lu_env *env,
        if (rc)
                GOTO(trans_stop, rc);
 
-       dt_write_lock(env, dto, LOS_CHILD);
+       dt_write_lock(env, dto, DT_SRC_CHILD);
        if (dt_object_exists(dto))
                GOTO(unlock, rc = 0);
 
@@ -388,23 +389,23 @@ static struct dt_object *__local_file_create(const struct lu_env *env,
                rec->rec_fid = fid;
                /* Add "." and ".." for newly created dir */
                rc = dt_insert(env, dto, (const struct dt_rec *)rec,
-                              (const struct dt_key *)".", th, 1);
+                              (const struct dt_key *)".", th);
                if (rc != 0)
                        GOTO(destroy, rc);
 
                dt_ref_add(env, dto, th);
                rec->rec_fid = lu_object_fid(&parent->do_lu);
                rc = dt_insert(env, dto, (const struct dt_rec *)rec,
-                              (const struct dt_key *)"..", th, 1);
+                              (const struct dt_key *)"..", th);
                if (rc != 0)
                        GOTO(destroy, rc);
        }
 
        rec->rec_fid = fid;
        rec->rec_type = dto->do_lu.lo_header->loh_attr;
-       dt_write_lock(env, parent, LOS_PARENT);
+       dt_write_lock(env, parent, DT_SRC_PARENT);
        rc = dt_insert(env, parent, (const struct dt_rec *)rec,
-                      (const struct dt_key *)name, th, 1);
+                      (const struct dt_key *)name, th);
        if (dti->dti_dof.dof_type == DFT_DIR)
                dt_ref_add(env, parent, th);
        dt_write_unlock(env, parent);
@@ -419,7 +420,7 @@ trans_stop:
        dt_trans_stop(env, ls->ls_osd, th);
 out:
        if (rc) {
-               lu_object_put_nocache(env, &dto->do_lu);
+               dt_object_put_nocache(env, dto);
                dto = ERR_PTR(rc);
        }
        RETURN(dto);
@@ -515,7 +516,7 @@ struct dt_object *local_file_find_or_create_with_fid(const struct lu_env *env,
                         * have to open the object in other device stack */
                        if (!IS_ERR(dto)) {
                                dti->dti_fid = dto->do_lu.lo_header->loh_fid;
-                               lu_object_put_nocache(env, &dto->do_lu);
+                               dt_object_put_nocache(env, dto);
                                dto = dt_locate(env, dt, &dti->dti_fid);
                        }
                        ls_device_put(env, ls);
@@ -611,7 +612,7 @@ local_index_find_or_create_with_fid(const struct lu_env *env,
                         * have to open the object in other device stack */
                        if (!IS_ERR(dto)) {
                                dti->dti_fid = dto->do_lu.lo_header->loh_fid;
-                               lu_object_put_nocache(env, &dto->do_lu);
+                               dt_object_put_nocache(env, dto);
                                dto = dt_locate(env, dt, &dti->dti_fid);
                        }
                        ls_device_put(env, ls);
@@ -684,7 +685,7 @@ int local_object_unlink(const struct lu_env *env, struct dt_device *dt,
                rec->rec_fid = &dti->dti_fid;
                rec->rec_type = dto->do_lu.lo_header->loh_attr;
                rc = dt_insert(env, parent, (const struct dt_rec *)rec,
-                              (const struct dt_key *)name, th, 1);
+                              (const struct dt_key *)name, th);
                GOTO(unlock, rc);
        }
 
@@ -694,7 +695,7 @@ unlock:
 stop:
        dt_trans_stop(env, dt, th);
 out:
-       lu_object_put_nocache(env, &dto->do_lu);
+       dt_object_put_nocache(env, dto);
        return rc;
 }
 EXPORT_SYMBOL(local_object_unlink);
@@ -719,7 +720,6 @@ void dt_los_put(struct local_oid_storage *los)
                /* should never happen, only local_oid_storage_fini should
                 * drop refcount to zero */
                LBUG();
-       return;
 }
 
 /* after Lustre 2.3 release there may be old file to store last generated FID
@@ -747,7 +747,7 @@ static int lastid_compat_check(const struct lu_env *env, struct dt_device *dev,
        snprintf(dti->dti_buf, sizeof(dti->dti_buf), "seq-%#llx-lastid",
                 lastid_seq);
        rc = dt_lookup_dir(env, root, dti->dti_buf, &dti->dti_fid);
-       lu_object_put_nocache(env, &root->do_lu);
+       dt_object_put_nocache(env, root);
        if (rc == -ENOENT) {
                /* old llog lastid accessed by FID only */
                if (lastid_seq != FID_SEQ_LLOG)
@@ -760,7 +760,7 @@ static int lastid_compat_check(const struct lu_env *env, struct dt_device *dev,
                        return PTR_ERR(o);
 
                if (!dt_object_exists(o)) {
-                       lu_object_put_nocache(env, &o->do_lu);
+                       dt_object_put_nocache(env, o);
                        return 0;
                }
                CDEBUG(D_INFO, "Found old llog lastid file\n");
@@ -790,7 +790,7 @@ static int lastid_compat_check(const struct lu_env *env, struct dt_device *dev,
                CERROR("%s: failed to read seq-%#llx-lastid: rc = %d\n",
                       o->do_lu.lo_dev->ld_obd->obd_name, lastid_seq, rc);
        }
-       lu_object_put_nocache(env, &o->do_lu);
+       dt_object_put_nocache(env, o);
        if (rc == 0)
                *first_oid = le32_to_cpu(losd.lso_next_oid);
        return rc;
@@ -927,7 +927,7 @@ out_los:
                OBD_FREE_PTR(*los);
                *los = NULL;
                if (o != NULL && !IS_ERR(o))
-                       lu_object_put_nocache(env, &o->do_lu);
+                       dt_object_put_nocache(env, o);
        } else {
                (*los)->los_seq = fid_seq(first_fid);
                (*los)->los_last_oid = le64_to_cpu(lastid);
@@ -964,7 +964,7 @@ void local_oid_storage_fini(const struct lu_env *env,
        }
 
        if (los->los_obj)
-               lu_object_put_nocache(env, &los->los_obj->do_lu);
+               dt_object_put_nocache(env, los->los_obj);
        list_del(&los->los_list);
        OBD_FREE_PTR(los);
        mutex_unlock(&ls->ls_los_mutex);