Whamcloud - gitweb
LU-9153 llog: consolidate common error checking
[fs/lustre-release.git] / lustre / obdclass / llog_cat.c
index 86a2047..950445a 100644 (file)
@@ -23,7 +23,7 @@
  * Copyright (c) 2003, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
  *
- * Copyright (c) 2012, 2015, Intel Corporation.
+ * Copyright (c) 2012, 2016, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
@@ -165,10 +165,9 @@ static int llog_cat_new_log(const struct lu_env *env,
        if (rc < 0)
                GOTO(out_destroy, rc);
 
-       CDEBUG(D_OTHER, "new plain log "DOSTID":%x for index %u of catalog"
-              DOSTID"\n", POSTID(&loghandle->lgh_id.lgl_oi),
-              loghandle->lgh_id.lgl_ogen, rec->lid_hdr.lrh_index,
-              POSTID(&cathandle->lgh_id.lgl_oi));
+       CDEBUG(D_OTHER, "new plain log "DFID".%u of catalog "DFID"\n",
+              PFID(&loghandle->lgh_id.lgl_oi.oi_fid), rec->lid_hdr.lrh_index,
+              PFID(&cathandle->lgh_id.lgl_oi.oi_fid));
 
        loghandle->lgh_hdr->llh_cat_idx = rec->lid_hdr.lrh_index;
 
@@ -239,10 +238,10 @@ int llog_cat_id2handle(const struct lu_env *env, struct llog_handle *cathandle,
                if (ostid_id(&cgl->lgl_oi) == ostid_id(&logid->lgl_oi) &&
                    ostid_seq(&cgl->lgl_oi) == ostid_seq(&logid->lgl_oi)) {
                        if (cgl->lgl_ogen != logid->lgl_ogen) {
-                               CERROR("%s: log "DOSTID" generation %x != %x\n",
-                                      loghandle->lgh_ctxt->loc_obd->obd_name,
-                                      POSTID(&logid->lgl_oi), cgl->lgl_ogen,
-                                      logid->lgl_ogen);
+                               CWARN("%s: log "DFID" generation %x != %x\n",
+                                     loghandle->lgh_ctxt->loc_obd->obd_name,
+                                     PFID(&logid->lgl_oi.oi_fid),
+                                     cgl->lgl_ogen, logid->lgl_ogen);
                                continue;
                        }
                        loghandle->u.phd.phd_cat_handle = cathandle;
@@ -255,9 +254,9 @@ int llog_cat_id2handle(const struct lu_env *env, struct llog_handle *cathandle,
        rc = llog_open(env, cathandle->lgh_ctxt, &loghandle, logid, NULL,
                       LLOG_OPEN_EXISTS);
        if (rc < 0) {
-               CERROR("%s: error opening log id "DOSTID":%x: rc = %d\n",
+               CERROR("%s: error opening log id "DFID":%x: rc = %d\n",
                       cathandle->lgh_ctxt->loc_obd->obd_name,
-                      POSTID(&logid->lgl_oi), logid->lgl_ogen, rc);
+                      PFID(&logid->lgl_oi.oi_fid), logid->lgl_ogen, rc);
                RETURN(rc);
        }
 
@@ -731,15 +730,16 @@ int llog_cat_cancel_records(const struct lu_env *env,
        ENTRY;
 
        for (i = 0; i < count; i++, cookies++) {
-               struct llog_handle      *loghandle;
-               struct llog_logid       *lgl = &cookies->lgc_lgl;
-               int                      lrc;
+               struct llog_handle *loghandle;
+               struct llog_logid *lgl = &cookies->lgc_lgl;
+               int  lrc;
 
                rc = llog_cat_id2handle(env, cathandle, &loghandle, lgl);
                if (rc) {
-                       CERROR("%s: cannot find handle for llog "DOSTID": %d\n",
+                       CDEBUG(D_HA, "%s: cannot find llog for handle "DFID":%x"
+                              ": rc = %d\n",
                               cathandle->lgh_ctxt->loc_obd->obd_name,
-                              POSTID(&lgl->lgl_oi), rc);
+                              PFID(&lgl->lgl_oi.oi_fid), lgl->lgl_ogen, rc);
                        failed++;
                        continue;
                }
@@ -747,8 +747,7 @@ int llog_cat_cancel_records(const struct lu_env *env,
                lrc = llog_cancel_rec(env, loghandle, cookies->lgc_index);
                if (lrc == LLOG_DEL_PLAIN) { /* log has been destroyed */
                        index = loghandle->u.phd.phd_cookie.lgc_index;
-                       rc = llog_cat_cleanup(env, cathandle, loghandle,
-                                             index);
+                       rc = llog_cat_cleanup(env, cathandle, loghandle, index);
                } else if (lrc == -ENOENT) {
                        if (rc == 0) /* ENOENT shouldn't rewrite any error */
                                rc = lrc;
@@ -767,57 +766,77 @@ int llog_cat_cancel_records(const struct lu_env *env,
 }
 EXPORT_SYMBOL(llog_cat_cancel_records);
 
-static int llog_cat_process_cb(const struct lu_env *env,
-                              struct llog_handle *cat_llh,
-                              struct llog_rec_hdr *rec, void *data)
+static int llog_cat_process_common(const struct lu_env *env,
+                                  struct llog_handle *cat_llh,
+                                  struct llog_rec_hdr *rec,
+                                  struct llog_handle **llhp)
 {
-        struct llog_process_data *d = data;
-        struct llog_logid_rec *lir = (struct llog_logid_rec *)rec;
-        struct llog_handle *llh;
+       struct llog_logid_rec *lir = container_of(rec, typeof(*lir), lid_hdr);
        struct llog_log_hdr *hdr;
-        int rc;
+       int rc;
 
-        ENTRY;
-        if (rec->lrh_type != LLOG_LOGID_MAGIC) {
-                CERROR("invalid record in catalog\n");
-                RETURN(-EINVAL);
-        }
-       CDEBUG(D_HA, "processing log "DOSTID":%x at index %u of catalog "
-              DOSTID"\n", POSTID(&lir->lid_id.lgl_oi), lir->lid_id.lgl_ogen,
-              rec->lrh_index, POSTID(&cat_llh->lgh_id.lgl_oi));
+       ENTRY;
+       if (rec->lrh_type != le32_to_cpu(LLOG_LOGID_MAGIC)) {
+               rc = -EINVAL;
+               CWARN("%s: invalid record in catalog "DFID":%x: rc = %d\n",
+                     cat_llh->lgh_ctxt->loc_obd->obd_name,
+                     PFID(&cat_llh->lgh_id.lgl_oi.oi_fid),
+                     cat_llh->lgh_id.lgl_ogen, rc);
+               RETURN(rc);
+       }
+       CDEBUG(D_HA, "processing log "DFID":%x at index %u of catalog "DFID"\n",
+              PFID(&lir->lid_id.lgl_oi.oi_fid), lir->lid_id.lgl_ogen,
+              le32_to_cpu(rec->lrh_index),
+              PFID(&cat_llh->lgh_id.lgl_oi.oi_fid));
 
-       rc = llog_cat_id2handle(env, cat_llh, &llh, &lir->lid_id);
+       rc = llog_cat_id2handle(env, cat_llh, llhp, &lir->lid_id);
        if (rc) {
-               CERROR("%s: cannot find handle for llog "DOSTID": %d\n",
-                      cat_llh->lgh_ctxt->loc_obd->obd_name,
-                      POSTID(&lir->lid_id.lgl_oi), rc);
-               if (rc == -ENOENT || rc == -ESTALE) {
-                       /* After a server crash, a stub of index
-                        * record in catlog could be kept, because
-                        * plain log destroy + catlog index record
-                        * deletion are not atomic. So we end up with
-                        * an index but no actual record. Destroy the
-                        * index and move on. */
+               /* After a server crash, a stub of index record in catlog could
+                * be kept, because plain log destroy + catlog index record
+                * deletion are not atomic. So we end up with an index but no
+                * actual record. Destroy the index and move on. */
+               if (rc == -ENOENT || rc == -ESTALE)
                        rc = llog_cat_cleanup(env, cat_llh, NULL,
                                              rec->lrh_index);
-               }
+               if (rc)
+                       CWARN("%s: can't find llog handle "DFID":%x: rc = %d\n",
+                             cat_llh->lgh_ctxt->loc_obd->obd_name,
+                             PFID(&lir->lid_id.lgl_oi.oi_fid),
+                             lir->lid_id.lgl_ogen, rc);
 
                RETURN(rc);
        }
 
        /* clean old empty llogs, do not consider current llog in use */
-       /* ignore remote (lgh_obj=NULL) llogs */
-       hdr = llh->lgh_hdr;
+       /* ignore remote (lgh_obj == NULL) llogs */
+       hdr = (*llhp)->lgh_hdr;
        if ((hdr->llh_flags & LLOG_F_ZAP_WHEN_EMPTY) &&
            hdr->llh_count == 1 && cat_llh->lgh_obj != NULL &&
-           llh != cat_llh->u.chd.chd_current_log) {
-               rc = llog_destroy(env, llh);
+           *llhp != cat_llh->u.chd.chd_current_log) {
+               rc = llog_destroy(env, *llhp);
                if (rc)
-                       CERROR("%s: fail to destroy empty log: rc = %d\n",
-                              llh->lgh_ctxt->loc_obd->obd_name, rc);
-               GOTO(out, rc = LLOG_DEL_PLAIN);
+                       CWARN("%s: can't destroy empty log "DFID": rc = %d\n",
+                             (*llhp)->lgh_ctxt->loc_obd->obd_name,
+                             PFID(&lir->lid_id.lgl_oi.oi_fid), rc);
+               rc = LLOG_DEL_PLAIN;
        }
 
+       RETURN(rc);
+}
+
+static int llog_cat_process_cb(const struct lu_env *env,
+                              struct llog_handle *cat_llh,
+                              struct llog_rec_hdr *rec, void *data)
+{
+       struct llog_process_data *d = data;
+       struct llog_handle *llh = NULL;
+       int rc;
+
+       ENTRY;
+       rc = llog_cat_process_common(env, cat_llh, rec, &llh);
+       if (rc)
+               GOTO(out, rc);
+
        if (rec->lrh_index < d->lpd_startcat) {
                /* Skip processing of the logs until startcat */
                rc = 0;
@@ -840,7 +859,8 @@ out:
        if (rc == LLOG_DEL_PLAIN)
                rc = llog_cat_cleanup(env, cat_llh, llh,
                                      llh->u.phd.phd_cookie.lgc_index);
-       llog_handle_put(llh);
+       if (llh)
+               llog_handle_put(llh);
 
        RETURN(rc);
 }
@@ -863,13 +883,14 @@ int llog_cat_process_or_fork(const struct lu_env *env,
 
        if (llh->llh_cat_idx >= cat_llh->lgh_last_idx &&
            llh->llh_count > 1) {
-                struct llog_process_cat_data cd;
+               struct llog_process_cat_data cd;
 
-                CWARN("catlog "DOSTID" crosses index zero\n",
-                      POSTID(&cat_llh->lgh_id.lgl_oi));
+               CWARN("%s: catlog "DFID" crosses index zero\n",
+                     cat_llh->lgh_ctxt->loc_obd->obd_name,
+                     PFID(&cat_llh->lgh_id.lgl_oi.oi_fid));
 
-                cd.lpcd_first_idx = llh->llh_cat_idx;
-                cd.lpcd_last_idx = 0;
+               cd.lpcd_first_idx = llh->llh_cat_idx;
+               cd.lpcd_last_idx = 0;
                rc = llog_process_or_fork(env, cat_llh, cat_cb,
                                          &d, &cd, fork);
                if (rc != 0)
@@ -900,39 +921,31 @@ static int llog_cat_size_cb(const struct lu_env *env,
                             struct llog_rec_hdr *rec, void *data)
 {
        struct llog_process_data *d = data;
-       struct llog_logid_rec *lir = (struct llog_logid_rec *)rec;
-       struct llog_handle *llh;
-       int rc;
+       struct llog_handle *llh = NULL;
        __u64 *cum_size = d->lpd_data;
        __u64 size;
+       int rc;
 
        ENTRY;
-       if (rec->lrh_type != LLOG_LOGID_MAGIC) {
-               CERROR("%s: invalid record in catalog, rc = %d\n",
-                      cat_llh->lgh_ctxt->loc_obd->obd_name, -EINVAL);
-               RETURN(-EINVAL);
-       }
-       CDEBUG(D_HA, "processing log "DOSTID":%x at index %u of catalog "
-              DOSTID"\n", POSTID(&lir->lid_id.lgl_oi), lir->lid_id.lgl_ogen,
-              rec->lrh_index, POSTID(&cat_llh->lgh_id.lgl_oi));
-
-       rc = llog_cat_id2handle(env, cat_llh, &llh, &lir->lid_id);
-       if (rc) {
-               CWARN("%s: cannot find handle for llog "DOSTID": rc = %d\n",
-                     cat_llh->lgh_ctxt->loc_obd->obd_name,
-                     POSTID(&lir->lid_id.lgl_oi), rc);
+       rc = llog_cat_process_common(env, cat_llh, rec, &llh);
+       if (llh == NULL)
                RETURN(0);
-       }
-       size = llog_size(env, llh);
-       *cum_size += size;
 
-       CDEBUG(D_INFO, "Add llog entry "DOSTID" size %llu\n",
-              POSTID(&llh->lgh_id.lgl_oi), size);
+       if (rc == LLOG_DEL_PLAIN) {
+               /* empty log was deleted, don't count it */
+               rc = llog_cat_cleanup(env, cat_llh, llh,
+                                     llh->u.phd.phd_cookie.lgc_index);
+       } else {
+               size = llog_size(env, llh);
+               *cum_size += size;
+
+               CDEBUG(D_INFO, "Add llog entry "DFID" size=%llu, tot=%llu\n",
+                      PFID(&llh->lgh_id.lgl_oi.oi_fid), size, *cum_size);
+       }
 
        llog_handle_put(llh);
 
        RETURN(0);
-
 }
 
 __u64 llog_cat_size(const struct lu_env *env, struct llog_handle *cat_llh)
@@ -951,53 +964,16 @@ static int llog_cat_reverse_process_cb(const struct lu_env *env,
                                       struct llog_rec_hdr *rec, void *data)
 {
        struct llog_process_data *d = data;
-       struct llog_logid_rec *lir = (struct llog_logid_rec *)rec;
        struct llog_handle *llh;
-       struct llog_log_hdr *hdr;
        int rc;
 
-       if (le32_to_cpu(rec->lrh_type) != LLOG_LOGID_MAGIC) {
-               CERROR("invalid record in catalog\n");
-               RETURN(-EINVAL);
-       }
-       CDEBUG(D_HA, "processing log "DOSTID":%x at index %u of catalog "
-              DOSTID"\n", POSTID(&lir->lid_id.lgl_oi), lir->lid_id.lgl_ogen,
-              le32_to_cpu(rec->lrh_index), POSTID(&cat_llh->lgh_id.lgl_oi));
-
-       rc = llog_cat_id2handle(env, cat_llh, &llh, &lir->lid_id);
-       if (rc) {
-               CERROR("%s: cannot find handle for llog "DOSTID": %d\n",
-                      cat_llh->lgh_ctxt->loc_obd->obd_name,
-                      POSTID(&lir->lid_id.lgl_oi), rc);
-               if (rc == -ENOENT || rc == -ESTALE) {
-                       /* After a server crash, a stub of index
-                        * record in catlog could be kept, because
-                        * plain log destroy + catlog index record
-                        * deletion are not atomic. So we end up with
-                        * an index but no actual record. Destroy the
-                        * index and move on. */
-                       rc = llog_cat_cleanup(env, cat_llh, NULL,
-                                             rec->lrh_index);
-               }
-
+       ENTRY;
+       rc = llog_cat_process_common(env, cat_llh, rec, &llh);
+       if (rc)
                RETURN(rc);
-       }
-
-       /* clean old empty llogs, do not consider current llog in use */
-       hdr = llh->lgh_hdr;
-       if ((hdr->llh_flags & LLOG_F_ZAP_WHEN_EMPTY) &&
-           hdr->llh_count == 1 &&
-           llh != cat_llh->u.chd.chd_current_log) {
-               rc = llog_destroy(env, llh);
-               if (rc)
-                       CERROR("%s: fail to destroy empty log: rc = %d\n",
-                              llh->lgh_ctxt->loc_obd->obd_name, rc);
-               GOTO(out, rc = LLOG_DEL_PLAIN);
-       }
 
        rc = llog_reverse_process(env, llh, d->lpd_cb, d->lpd_data, NULL);
 
-out:
        /* The empty plain was destroyed while processing */
        if (rc == LLOG_DEL_PLAIN)
                rc = llog_cat_cleanup(env, cat_llh, llh,
@@ -1023,11 +999,12 @@ int llog_cat_reverse_process(const struct lu_env *env,
 
        if (llh->llh_cat_idx >= cat_llh->lgh_last_idx &&
            llh->llh_count > 1) {
-               CWARN("catalog "DOSTID" crosses index zero\n",
-                     POSTID(&cat_llh->lgh_id.lgl_oi));
+               CWARN("%s: catalog "DFID" crosses index zero\n",
+                     cat_llh->lgh_ctxt->loc_obd->obd_name,
+                     PFID(&cat_llh->lgh_id.lgl_oi.oi_fid));
 
-                cd.lpcd_first_idx = 0;
-                cd.lpcd_last_idx = cat_llh->lgh_last_idx;
+               cd.lpcd_first_idx = 0;
+               cd.lpcd_last_idx = cat_llh->lgh_last_idx;
                rc = llog_reverse_process(env, cat_llh,
                                          llog_cat_reverse_process_cb,
                                          &d, &cd);
@@ -1081,8 +1058,8 @@ static int llog_cat_set_first_idx(struct llog_handle *cathandle, int idx)
                        }
                }
 
-               CDEBUG(D_RPCTRACE, "Set catlog "DOSTID" first idx %u,"
-                      " (last_idx %u)\n", POSTID(&cathandle->lgh_id.lgl_oi),
+               CDEBUG(D_RPCTRACE, "catlog "DFID" first idx %u, last_idx %u\n",
+                      PFID(&cathandle->lgh_id.lgl_oi.oi_fid),
                       llh->llh_cat_idx, cathandle->lgh_last_idx);
        }
 
@@ -1117,8 +1094,7 @@ int llog_cat_cleanup(const struct lu_env *env, struct llog_handle *cathandle,
        llog_cat_set_first_idx(cathandle, index);
        rc = llog_cancel_rec(env, cathandle, index);
        if (rc == 0)
-               CDEBUG(D_HA, "cancel plain log at index"
-                      " %u of catalog "DOSTID"\n",
-                      index, POSTID(&cathandle->lgh_id.lgl_oi));
+               CDEBUG(D_HA, "cancel plain log at index %u of catalog "DFID"\n",
+                      index, PFID(&cathandle->lgh_id.lgl_oi.oi_fid));
        return rc;
 }