Whamcloud - gitweb
LU-3963 obdclass: convert to linux list api
[fs/lustre-release.git] / lustre / obdclass / dt_object.c
index b1eba33..088c1cb 100644 (file)
@@ -67,13 +67,13 @@ EXPORT_SYMBOL(dt_key);
  */
 void dt_txn_callback_add(struct dt_device *dev, struct dt_txn_callback *cb)
 {
-        cfs_list_add(&cb->dtc_linkage, &dev->dd_txn_callbacks);
+       list_add(&cb->dtc_linkage, &dev->dd_txn_callbacks);
 }
 EXPORT_SYMBOL(dt_txn_callback_add);
 
 void dt_txn_callback_del(struct dt_device *dev, struct dt_txn_callback *cb)
 {
-        cfs_list_del_init(&cb->dtc_linkage);
+       list_del_init(&cb->dtc_linkage);
 }
 EXPORT_SYMBOL(dt_txn_callback_del);
 
@@ -86,7 +86,7 @@ int dt_txn_hook_start(const struct lu_env *env,
         if (th->th_local)
                 return 0;
 
-        cfs_list_for_each_entry(cb, &dev->dd_txn_callbacks, dtc_linkage) {
+       list_for_each_entry(cb, &dev->dd_txn_callbacks, dtc_linkage) {
                 if (cb->dtc_txn_start == NULL ||
                     !(cb->dtc_tag & env->le_ctx.lc_tags))
                         continue;
@@ -107,7 +107,7 @@ int dt_txn_hook_stop(const struct lu_env *env, struct thandle *txn)
         if (txn->th_local)
                 return 0;
 
-        cfs_list_for_each_entry(cb, &dev->dd_txn_callbacks, dtc_linkage) {
+       list_for_each_entry(cb, &dev->dd_txn_callbacks, dtc_linkage) {
                 if (cb->dtc_txn_stop == NULL ||
                     !(cb->dtc_tag & env->le_ctx.lc_tags))
                         continue;
@@ -121,24 +121,23 @@ EXPORT_SYMBOL(dt_txn_hook_stop);
 
 void dt_txn_hook_commit(struct thandle *txn)
 {
-        struct dt_txn_callback *cb;
+       struct dt_txn_callback *cb;
 
-        if (txn->th_local)
-                return;
+       if (txn->th_local)
+               return;
 
-        cfs_list_for_each_entry(cb, &txn->th_dev->dd_txn_callbacks,
-                                dtc_linkage) {
-                if (cb->dtc_txn_commit)
-                        cb->dtc_txn_commit(txn, cb->dtc_cookie);
-        }
+       list_for_each_entry(cb, &txn->th_dev->dd_txn_callbacks,
+                           dtc_linkage) {
+               if (cb->dtc_txn_commit)
+                       cb->dtc_txn_commit(txn, cb->dtc_cookie);
+       }
 }
 EXPORT_SYMBOL(dt_txn_hook_commit);
 
 int dt_device_init(struct dt_device *dev, struct lu_device_type *t)
 {
-
-        CFS_INIT_LIST_HEAD(&dev->dd_txn_callbacks);
-        return lu_device_init(&dev->dd_lu_dev, t);
+       INIT_LIST_HEAD(&dev->dd_txn_callbacks);
+       return lu_device_init(&dev->dd_lu_dev, t);
 }
 EXPORT_SYMBOL(dt_device_init);
 
@@ -296,22 +295,21 @@ dt_store_resolve(const struct lu_env *env, struct dt_device *dt,
        struct dt_thread_info *info = dt_info(env);
        struct dt_find_hint   *dfh = &info->dti_dfh;
        struct dt_object      *obj;
-       char                  *local = info->dti_buf;
        int                    result;
 
 
         dfh->dfh_dt = dt;
         dfh->dfh_fid = fid;
 
-        strncpy(local, path, DT_MAX_PATH);
-        local[DT_MAX_PATH - 1] = '\0';
+       strlcpy(info->dti_buf, path, sizeof(info->dti_buf));
 
         result = dt->dd_ops->dt_root_get(env, dt, fid);
         if (result == 0) {
                 obj = dt_locate(env, dt, fid);
                 if (!IS_ERR(obj)) {
                         dfh->dfh_o = obj;
-                        result = dt_path_parser(env, local, dt_find_entry, dfh);
+                       result = dt_path_parser(env, info->dti_buf,
+                                               dt_find_entry, dfh);
                         if (result != 0)
                                 obj = ERR_PTR(result);
                         else
@@ -677,10 +675,6 @@ static int dt_index_page_build(const struct lu_env *env, union lu_page *lp,
        int                      rc, size;
        ENTRY;
 
-       /* no support for variable key & record size for now */
-       LASSERT((ii->ii_flags & II_FL_VARKEY) == 0);
-       LASSERT((ii->ii_flags & II_FL_VARREC) == 0);
-
        /* initialize the header of the new container */
        memset(lip, 0, LIP_HDR_SIZE);
        lip->lip_magic = LIP_MAGIC;
@@ -696,7 +690,9 @@ static int dt_index_page_build(const struct lu_env *env, union lu_page *lp,
        do {
                char            *tmp_entry = entry;
                struct dt_key   *key;
-               __u64            hash;
+               __u64           hash;
+               __u16           keysize;
+               __u16           recsize;
 
                /* fetch 64-bit hash value */
                hash = iops->store(env, it);
@@ -713,18 +709,24 @@ static int dt_index_page_build(const struct lu_env *env, union lu_page *lp,
                        GOTO(out, rc = 0);
                }
 
-               if ((ii->ii_flags & II_FL_NOHASH) == 0) {
+               if (!(ii->ii_flags & II_FL_NOHASH)) {
                        /* client wants to the 64-bit hash value associated with
                         * each record */
                        memcpy(tmp_entry, &hash, sizeof(hash));
                        tmp_entry += sizeof(hash);
                }
 
-               /* then the key value */
-               LASSERT(iops->key_size(env, it) == ii->ii_keysize);
-               key = iops->key(env, it);
-               memcpy(tmp_entry, key, ii->ii_keysize);
-               tmp_entry += ii->ii_keysize;
+               if (ii->ii_flags & II_FL_VARKEY)
+                       keysize = iops->key_size(env, it);
+               else
+                       keysize = ii->ii_keysize;
+
+               if (!(ii->ii_flags & II_FL_NOKEY)) {
+                       /* then the key value */
+                       key = iops->key(env, it);
+                       memcpy(tmp_entry, key, keysize);
+                       tmp_entry += keysize;
+               }
 
                /* and finally the record */
                rc = iops->rec(env, it, (struct dt_rec *)tmp_entry, attr);
@@ -736,7 +738,13 @@ static int dt_index_page_build(const struct lu_env *env, union lu_page *lp,
                        lip->lip_nr++;
                        if (unlikely(lip->lip_nr == 1 && ii->ii_count == 0))
                                ii->ii_hash_start = hash;
-                       entry = tmp_entry + ii->ii_recsize;
+
+                       if (ii->ii_flags & II_FL_VARREC)
+                               recsize = iops->rec_size(env, it, attr);
+                       else
+                               recsize = ii->ii_recsize;
+
+                       entry = tmp_entry + recsize;
                        nob -= size;
                }
 
@@ -758,6 +766,7 @@ out:
        return rc;
 }
 
+
 /*
  * Walk index and fill lu_page containers with key/record pairs
  *
@@ -810,6 +819,10 @@ int dt_index_walk(const struct lu_env *env, struct dt_object *obj,
                rc = iops->next(env, it);
        } else if (rc > 0) {
                rc = 0;
+       } else {
+               if (rc == -ENODATA)
+                       rc = 0;
+               GOTO(out, rc);
        }
 
        /* Fill containers one after the other. There might be multiple
@@ -841,6 +854,7 @@ int dt_index_walk(const struct lu_env *env, struct dt_object *obj,
                kunmap(rdpg->rp_pages[i]);
        }
 
+out:
        iops->put(env, it);
        iops->fini(env, it);
 
@@ -878,16 +892,10 @@ int dt_index_read(const struct lu_env *env, struct dt_device *dev,
        if (rdpg->rp_count <= 0 && (rdpg->rp_count & (LU_PAGE_SIZE - 1)) != 0)
                RETURN(-EFAULT);
 
-       if (fid_seq(&ii->ii_fid) >= FID_SEQ_NORMAL)
-               /* we don't support directory transfer via OBD_IDX_READ for the
-                * time being */
+       if (!fid_is_quota(&ii->ii_fid) && !fid_is_layout_rbtree(&ii->ii_fid) &&
+           !fid_is_norm(&ii->ii_fid))
                RETURN(-EOPNOTSUPP);
 
-       if (!fid_is_quota(&ii->ii_fid) && !fid_is_layout_rbtree(&ii->ii_fid))
-               /* Block access to all local files except quota files and
-                * layout brtree. */
-               RETURN(-EPERM);
-
        /* lookup index object subject to the transfer */
        obj = dt_locate(env, dev, &ii->ii_fid);
        if (IS_ERR(obj))
@@ -909,25 +917,16 @@ int dt_index_read(const struct lu_env *env, struct dt_device *dev,
        }
 
        /* fill ii_flags with supported index features */
-       ii->ii_flags &= II_FL_NOHASH;
-
-       ii->ii_keysize = feat->dif_keysize_max;
-       if ((feat->dif_flags & DT_IND_VARKEY) != 0) {
-               /* key size is variable */
-               ii->ii_flags |= II_FL_VARKEY;
-               /* we don't support variable key size for the time being */
-               GOTO(out, rc = -EOPNOTSUPP);
-       }
+       ii->ii_flags &= (II_FL_NOHASH | II_FL_NOKEY | II_FL_VARKEY |
+                        II_FL_VARREC);
 
-       ii->ii_recsize = feat->dif_recsize_max;
-       if ((feat->dif_flags & DT_IND_VARREC) != 0) {
-               /* record size is variable */
-               ii->ii_flags |= II_FL_VARREC;
-               /* we don't support variable record size for the time being */
-               GOTO(out, rc = -EOPNOTSUPP);
-       }
+       if (!(feat->dif_flags & DT_IND_VARKEY))
+               ii->ii_keysize = feat->dif_keysize_max;
+
+       if (!(feat->dif_flags & DT_IND_VARREC))
+               ii->ii_recsize = feat->dif_recsize_max;
 
-       if ((feat->dif_flags & DT_IND_NONUNQ) != 0)
+       if (!(feat->dif_flags & DT_IND_NONUNQ))
                /* key isn't necessarily unique */
                ii->ii_flags |= II_FL_NONUNQ;
 
@@ -938,7 +937,7 @@ int dt_index_read(const struct lu_env *env, struct dt_device *dev,
        }
 
        /* walk the index and fill lu_idxpages with key/record pairs */
-       rc = dt_index_walk(env, obj, rdpg, dt_index_page_build ,ii);
+       rc = dt_index_walk(env, obj, rdpg, dt_index_page_buildii);
        if (!fid_is_layout_rbtree(&ii->ii_fid))
                dt_read_unlock(env, obj);