Whamcloud - gitweb
Fixed packing in obdcontrol
[fs/lustre-release.git] / lustre / obdclass / class_obd.c
index bddc87c..3208e8c 100644 (file)
@@ -154,9 +154,12 @@ static int getdata(int len, void **data)
 static int obd_class_ioctl (struct inode * inode, struct file * filp, 
                            unsigned int cmd, unsigned long arg)
 {
-       int err, i_ino, dev;
        struct obd_device *obddev;
+       /* NOTE this must be larger than any of the ioctl data structs */
+       char buff[1024];
+       void *karg = buff;
        struct obd_conn conn;
+       int err, dev;
        long int cli_id; /* connect, disconnect */
 
        if (!inode)
@@ -173,18 +176,20 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
                return -EINVAL;
        case OBD_IOC_ATTACH: {
                struct obd_type *type;
-               struct oic_generic input;
+               struct oic_generic *input = karg;
 
                ENTRY;
                /* have we attached a type to this device */
-               if ( obddev->obd_type || (obddev->obd_flags & OBD_ATTACHED) ){
+               if ( obddev->obd_type || 
+                    (obddev->obd_flags & OBD_ATTACHED) ){
                        CDEBUG(D_IOCTL,
                               "OBD Device %d already attached to type %s.\n",
                               dev, obddev->obd_type->typ_name);
                        EXIT;
-                       return -EINVAL;
+                       return -EBUSY;
                }
 
+               ENTRY;
                /* get data structures */
                err = copy_from_user(&input, (void *)arg, sizeof(input));
                if ( err ) {
@@ -192,15 +197,17 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
                        return err;
                }
 
-               err = getdata(input.att_typelen + 1, &input.att_type);
+               ENTRY;
+               err = getdata(input->att_typelen + 1, &input->att_type);
                if ( err ) {
                        EXIT;
                        return err;
                }
 
+               ENTRY;
                /* find the type */
-               type = obd_nm_to_type(input.att_type);
-               OBD_FREE(input.att_type, input.att_typelen + 1);
+               type = obd_nm_to_type(input->att_type);
+               OBD_FREE(input->att_type, input->att_typelen + 1);
                if ( !type ) {
                        printk("Unknown obd type dev %d\n", dev);
                        EXIT;
@@ -209,7 +216,7 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
                obddev->obd_type = type;
                
                /* get the attach data */
-               err = getdata(input.att_datalen, &input.att_data);
+               err = getdata(input->att_datalen, &input->att_data);
                if ( err ) {
                        EXIT;
                        return err;
@@ -219,8 +226,9 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
                obddev->obd_multi_count = 0;
 
                CDEBUG(D_IOCTL, "Attach %d, datalen %d, type %s\n", 
-                      dev, input.att_datalen, obddev->obd_type->typ_name);
-               if (!obddev->obd_type->typ_ops || !OBP(obddev,attach)) {
+                      dev, input->att_datalen, obddev->obd_type->typ_name);
+               /* maybe we are done */
+               if ( !OBT(obddev) || !OBP(obddev, attach) ) {
                        obddev->obd_flags |=  OBD_ATTACHED;
                        type->typ_refcnt++;
                        CDEBUG(D_IOCTL, "Dev %d refcount now %d\n", dev,
@@ -231,9 +239,9 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
                }
 
                /* do the attach */
-               err = OBP(obddev,attach)(obddev,  
-                                        input.att_datalen, input.att_data);
-               OBD_FREE(input.att_data, input.att_datalen);
+               err = OBP(obddev, attach)(obddev, input->att_datalen,
+                                         input->att_data);
+               OBD_FREE(input->att_data, input->att_datalen);
 
                if ( err ) {
                        obddev->obd_flags &= ~OBD_ATTACHED;
@@ -255,15 +263,17 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
                ENTRY;
                if (obddev->obd_flags & OBD_SET_UP) {
                        EXIT;
-                       return -EINVAL;
+                       return -EBUSY;
                }
                if (! (obddev->obd_flags & OBD_ATTACHED) ) {
+                       CDEBUG(D_IOCTL, "Device not attached\n");
                        EXIT;
-                       return -EINVAL;
+                       return -ENODEV;
                }
                if ( !list_empty(&obddev->obd_gen_clients) ) {
+                       CDEBUG(D_IOCTL, "Device has connected clients\n");
                        EXIT;
-                       return -EINVAL;
+                       return -EBUSY;
                }
 
                CDEBUG(D_IOCTL, "Detach %d, type %s\n", dev,
@@ -278,191 +288,19 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
                return 0;
        }
 
-       case OBD_IOC_FORMAT: {
-               struct ioc_format {
-                       int format_datalen;
-                       void *format_data;
-               } input;
-
-               /* have we attached a type to this device */
-               if ( !obddev->obd_type ) {
-                       CDEBUG(D_IOCTL, "OBD Device %d has no type.\n", dev);
-                       return -EINVAL;
-               }
-
-               /* get main structure */
-               err = copy_from_user(&input, (void *) arg, sizeof(input));
-               if (err) 
-                       return err;
-
-               err = getdata(input.format_datalen, &input.format_data);
-               if (err) 
-                       return err;
-
-               if (!obddev->obd_type->typ_ops || 
-                   !obddev->obd_type->typ_ops->o_format )
-                       return -EOPNOTSUPP;
-
-               /* do the format */
-               CDEBUG(D_IOCTL, "Format %d, type %s\n", dev, 
-                      obddev->obd_type->typ_name);
-               err = obddev->obd_type->typ_ops->o_format(obddev,
-                                                         input.format_datalen,
-                                                         input.format_data);
-
-               OBD_FREE(input.format_data, input.format_datalen);
-               return err;
-       }
-       case OBD_IOC_PARTITION: {
-               struct ioc_part {
-                       int part_datalen;
-                       void *part_data;
-               } input;
-
-               /* have we attached a type to this device */
-               if ( !obddev->obd_type ) {
-                       CDEBUG(D_IOCTL, "OBD Device %d has no type.\n", dev);
-                       return -EINVAL;
-               }
-
-               /* get main structure */
-               err = copy_from_user(&input, (void *) arg, sizeof(input));
-               if (err) 
-                       return err;
-
-               err = getdata(input.part_datalen, &input.part_data);
-               if (err) 
-                       return err;
-
-               if (!obddev->obd_type->typ_ops || 
-                   !obddev->obd_type->typ_ops->o_partition )
-                       return -EOPNOTSUPP;
-
-               /* do the partition */
-               CDEBUG(D_IOCTL, "Partition %d, type %s\n", dev, 
-                      obddev->obd_type->typ_name);
-               err = obddev->obd_type->typ_ops->o_partition(obddev,
-                                                            input.part_datalen,
-                                                            input.part_data);
-
-               OBD_FREE(input.part_data, input.part_datalen);
-               return err;
-       }
-
-       case OBD_IOC_COPY: {
-               struct ioc_mv_s mvdata;
-               struct ioc_part {
-                       int part_datalen;
-                       void *part_data;
-               } input;
-               obdattr *srcoa, *tgtoa;
-
-               if ( (!(obddev->obd_flags & OBD_SET_UP)) ||
-                    (!(obddev->obd_flags & OBD_ATTACHED))) {
-                       CDEBUG(D_IOCTL, "Device not attached or set up\n");
-                       return -EINVAL;
-               }
-
-               /* get main structure */
-               err = copy_from_user(&input, (void *) arg, sizeof(input));
-               if (err) 
-                       return err;
-
-
-               err = copy_from_user(&mvdata, input.part_data, sizeof(mvdata));
-               if (err) 
-                       return err;
-
-               if (!obddev->obd_type->typ_ops || 
-                   !obddev->obd_type->typ_ops->o_copy )
-                       return -EOPNOTSUPP;
-
-               /* do the partition */
-               CDEBUG(D_IOCTL, "Copy %d, type %s src %ld tgt %ld\n", dev, 
-                      obddev->obd_type->typ_name, mvdata.src, mvdata.tgt);
-
-               conn.oc_id = mvdata.conn_id;
-               srcoa = obd_oa_fromid(&conn, mvdata.src);
-               if ( !srcoa ) 
-                       return -ENOENT;
-               tgtoa = obd_oa_fromid(&conn, mvdata.tgt);
-               if ( ! tgtoa ) {
-                       obd_free_oa(srcoa);
-                       return -ENOMEM;
-               }
-
-               err = obddev->obd_type->typ_ops->o_copy(&conn,srcoa, tgtoa);
-
-               obd_free_oa(srcoa);
-               obd_free_oa(tgtoa);
-               return err;
-       }
-       case OBD_IOC_MIGR: {
-               struct ioc_mv_s mvdata;
-               struct ioc_part {
-                       int part_datalen;
-                       void *part_data;
-               } input;
-               obdattr *srcoa, *tgtoa;
-
-               if ( (!(obddev->obd_flags & OBD_SET_UP)) ||
-                    (!(obddev->obd_flags & OBD_ATTACHED))) {
-                       CDEBUG(D_IOCTL, "Device not attached or set up\n");
-                       return -EINVAL;
-               }
-
-               /* get main structure */
-               err = copy_from_user(&input, (void *) arg, sizeof(input));
-               if (err) 
-                       return err;
-
-
-               CDEBUG(D_IOCTL, "Migrate copying %d\n", sizeof(mvdata));
-               err = copy_from_user(&mvdata, input.part_data, sizeof(mvdata));
-               if (err) 
-                       return err;
-
-               if (!obddev->obd_type->typ_ops || 
-                   !obddev->obd_type->typ_ops->o_copy )
-                       return -EOPNOTSUPP;
-
-               /* do the partition */
-               CDEBUG(D_IOCTL, "Migrate %d, type %s conn %d src %ld tgt %ld\n",
-                      dev, obddev->obd_type->typ_name, mvdata.conn_id,
-                      mvdata.src, mvdata.tgt);
-
-
-               if ( ! (srcoa = obd_empty_oa()) ) 
-                       return -ENOMEM;
-               if ( ! (tgtoa = obd_empty_oa()) ) {
-                       obd_free_oa(srcoa);
-                       return -ENOMEM;
-               }
-
-               srcoa->i_ino = mvdata.src;
-               tgtoa->i_ino = mvdata.tgt;
-
-               conn.oc_id = mvdata.conn_id;
-
-               err = obddev->obd_type->typ_ops->o_migrate(&conn, tgtoa, srcoa);
-
-               obd_free_oa(srcoa);
-               obd_free_oa(tgtoa);
-               return err;
-       }
-
        case OBD_IOC_SETUP: {
                struct ioc_setup {
                        int setup_datalen;
                        void *setup_data;
-               } input;
+               } *input;
+               input = karg;
 
                ENTRY;
                /* have we attached a type to this device */
                if (!(obddev->obd_flags & OBD_ATTACHED)) {
-                       CDEBUG(D_IOCTL, "OBD Device %d has no type.\n", dev);
+                       CDEBUG(D_IOCTL, "Device not attached\n");
                        EXIT;
-                       return -EINVAL;
+                       return -ENODEV;
                }
 
                /* has this been done already? */
@@ -470,7 +308,7 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
                        CDEBUG(D_IOCTL, "Device %d already setup (type %s)\n",
                               dev, obddev->obd_type->typ_name);
                        EXIT;
-                       return -EINVAL;
+                       return -EBUSY;
                }
 
                /* get main structure */
@@ -480,7 +318,7 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
                        return err;
                }
 
-               err = getdata(input.setup_datalen, &input.setup_data);
+               err = getdata(input->setup_datalen, &input->setup_data);
                if (err) {
                        EXIT;
                        return err;
@@ -489,8 +327,7 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
                /* do the setup */
                CDEBUG(D_IOCTL, "Setup %d, type %s\n", dev, 
                       obddev->obd_type->typ_name);
-               if ( !obddev->obd_type->typ_ops || 
-                    !obddev->obd_type->typ_ops->o_setup ) {
+               if ( !OBT(obddev) || !OBP(obddev, setup) ) {
                        obddev->obd_type->typ_refcnt++;
                        CDEBUG(D_IOCTL, "Dev %d refcount now %d\n",
                               dev, obddev->obd_type->typ_refcnt);
@@ -499,9 +336,8 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
                        return 0;
                }
 
-               err = obddev->obd_type->typ_ops->o_setup(obddev,
-                                                        input.setup_datalen,
-                                                        input.setup_data);
+               err = OBP(obddev, setup)(obddev, input->setup_datalen,
+                                        input->setup_data);
 
                if ( err )  {
                        obddev->obd_flags &= ~OBD_SET_UP;
@@ -519,20 +355,26 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
                ENTRY;
                /* has this minor been registered? */
                if (!obddev->obd_type) {
+                       CDEBUG(D_IOCTL, "OBD Device %d has no type.\n", dev);
                        EXIT;
                        return -ENODEV;
                }
 
-               if ( !obddev->obd_type->typ_refcnt )
-                       printk("OBD_CLEANUP: Dev %d refcount wrap (%d)!\n",
+               if ( !obddev->obd_type->typ_refcnt ) {
+                       printk("OBD_CLEANUP: Dev %d has refcount (%d)!\n",
                               dev, obddev->obd_type->typ_refcnt);
+                       EXIT;
+                       return -EBUSY;
+               }
 
-               if ( !obddev->obd_flags & OBD_SET_UP ) {
+               if ( (!(obddev->obd_flags & OBD_SET_UP)) ||
+                    (!(obddev->obd_flags & OBD_ATTACHED))) {
+                       CDEBUG(D_IOCTL, "Device not attached or set up\n");
                        EXIT;
-                       return -EINVAL;
+                       return -ENODEV;
                }
 
-               if ( !obddev->obd_type->typ_ops->o_cleanup )
+               if ( !OBT(obddev) || !OBP(obddev, cleanup) )
                        goto cleanup_out;
 
                /* cleanup has no argument */
@@ -555,15 +397,18 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
                if ( (!(obddev->obd_flags & OBD_SET_UP)) ||
                     (!(obddev->obd_flags & OBD_ATTACHED))) {
                        CDEBUG(D_IOCTL, "Device not attached or set up\n");
-                       return -EINVAL;
+                       return -ENODEV;
                }
 
+               if ( !OBT(obddev) || !OBP(obddev, connect) )
+                       return -EOPNOTSUPP;
                
-               if (obddev->obd_type->typ_ops->o_connect(&conn))
-                       return -EINVAL;
+               err = OBP(obddev, connect)(&conn);
+               if ( err )
+                       return err;
 
                return copy_to_user((int *)arg, &conn.oc_id,
-                                   sizeof(int));
+                                   sizeof(uint32_t));
        }
        case OBD_IOC_DISCONNECT:
                /* frees data structures */
@@ -574,83 +419,82 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
                get_user(cli_id, (int *) arg);
                conn.oc_id = cli_id;
 
+               if ( !OBT(obddev) || !OBP(obddev, disconnect))
+                       return -EOPNOTSUPP;
+               
                OBP(obddev, disconnect)(&conn);
                return 0;
 
+               /* XXX sync needs to be done */
        case OBD_IOC_SYNC: {
-               /* sync doesn't need a connection ID, because it knows
-                * what device it was called on, and can thus get the
-                * superblock that it needs. */
-               /* has this minor been registered? */
+               struct oic_range_s *foo = karg;
+
                if (!obddev->obd_type)
                        return -ENODEV;
 
-               if (!obddev->u.ext2.ext2_sb || !obddev->u.ext2.ext2_sb->s_dev) {
-                       CDEBUG(D_IOCTL, "fatal: device not initialized.\n");
-                       err = -EINVAL;
-               } else {
-                       err = fsync_dev(obddev->u.ext2.ext2_sb->s_dev);
-                       if ( err )
-                               CDEBUG(D_IOCTL, "sync: fsync_dev failure\n");
-                       else
-                               CDEBUG(D_IOCTL, "sync: success\n");
+               err = copy_from_user(&foo, (const void *)arg,  sizeof(foo));
+               if (err) {
+                       EXIT;
+                       return err;
                }
 
                return put_user(err, (int *) arg);
        }
        case OBD_IOC_CREATE: {
-               struct oic_create_s foo;
+               struct oic_attr_s *foo = karg;
 
-               if ( copy_from_user(&foo, (const void *)arg, sizeof(foo)) )
-                       return -EFAULT;
+               err = copy_from_user(&foo, (const void *)arg,  sizeof(foo));
+               if (err) {
+                       EXIT;
+                       return err;
+               }
 
                /* has this minor been registered? */
                if ( !(obddev->obd_flags & OBD_ATTACHED) ||
-                    !(obddev->obd_flags & OBD_SET_UP))
+                    !(obddev->obd_flags & OBD_SET_UP)) {
+                       CDEBUG(D_IOCTL, "Device not attached or set up\n");
                        return -ENODEV;
-               conn.oc_id = foo.conn_id;
+               }
+               conn.oc_id = foo->conn_id;
 
-               i_ino = OBP(obddev, create)(&conn, foo.prealloc, &err);
+               if ( !OBT(obddev) || !OBP(obddev, create) )
+                       return -EOPNOTSUPP;
+
+               err = OBP(obddev, create)(&conn, &foo->obdo);
                if (err) {
-                       CDEBUG(D_IOCTL, "create: obd_inode_new failure\n");
-                       /* 0 is the only error value */
-                       return put_user(0, (int *) arg);
+                       EXIT;
+                       return err;
                }
 
-               return put_user(i_ino, (int *) arg);
+               err = copy_to_user((int *)arg, &foo, sizeof(foo));
+               EXIT;
+               return err;
        }
+
        case OBD_IOC_DESTROY: {
-               struct destroy_s {
-                       unsigned int conn_id;
-                       unsigned int ino;
-               } destroy;
-               obdattr *oa;
+               struct oic_attr_s *foo = karg;
                
-               if ( ! (oa = obd_empty_oa()) ) 
-                       return -ENOMEM;
-
                /* has this minor been registered? */
                if (!obddev->obd_type)
                        return -ENODEV;
 
+               err = copy_from_user(&foo, (int *)arg, sizeof(*foo));
+               if ( err ) {
+                       EXIT;
+                       return err;
+               }
 
-               copy_from_user(&destroy, (int *)arg, sizeof(struct destroy_s));
-               if ( !obddev->obd_type ||
-                    !obddev->obd_type->typ_ops->o_destroy)
-                       return -EINVAL;
+               if ( !OBT(obddev) || !OBP(obddev, destroy) )
+                       return -EOPNOTSUPP;
 
-               oa->i_ino = destroy.ino;
-               conn.oc_id = destroy.conn_id;
-               err = obddev->obd_type->typ_ops->o_destroy(&conn, oa);
-               OBD_FREE(oa, sizeof(*oa));
+               conn.oc_id = foo->conn_id;
+               err = OBP(obddev, destroy)(&conn, &foo->obdo);
+               EXIT;
                return err;
        }
-       case OBD_IOC_SETATTR: {
-               struct oic_attr_s foo;
-               obdattr *oa;
 
-               if ( ! (oa = obd_empty_oa()) ) 
-                       return -ENOMEM;
+       case OBD_IOC_SETATTR: {
+               struct oic_attr_s *foo = karg;
 
                /* has this minor been registered? */
                if (!obddev->obd_type)
@@ -660,105 +504,93 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
                if (err)
                        return err;
 
-               if ( !obddev->obd_type ||
-                    !obddev->obd_type->typ_ops->o_setattr)
-                       return -EINVAL;
+               if ( !OBT(obddev) || !OBP(obddev, setattr) )
+                       return -EOPNOTSUPP;
                
-               oa->i_ino = foo.ino;
-               inode_setattr(oa, &foo.iattr);
-               conn.oc_id = foo.conn_id;
-               err = obddev->obd_type->typ_ops->o_setattr(&conn, oa);
-               OBD_FREE(oa, sizeof(*oa));
+               conn.oc_id = foo->conn_id;
+               err = OBP(obddev, setattr)(&conn, &foo->obdo);
+               EXIT;
                return err;
        }
 
        case OBD_IOC_GETATTR: {
-               struct oic_getattr {
-                       unsigned int conn_id;
-                       unsigned long ino;
-               } foo;
-               struct iattr iattr;
-               obdattr *oa;
+               struct oic_attr_s *foo = karg;
 
                err = copy_from_user(&foo, (int *)arg, sizeof(foo));
                if (err)
                        return err;
 
-               conn.oc_id = foo.conn_id;
-               oa = obd_oa_fromid(&conn, foo.ino);
-               if ( !oa ) 
-                       return -ENOENT;
+               conn.oc_id = foo->conn_id;
+               err = OBP(obddev, getattr)(&conn, &foo->obdo);
+               if ( err ) {
+                       EXIT;
+                       return err;
+               }
 
-               inode_to_iattr(oa, &iattr);
-               err = copy_to_user((int *)arg, &iattr, sizeof(iattr));
+               err = copy_to_user((int *)arg, &foo, sizeof(foo));
+               EXIT;
                return err;
        }
 
        case OBD_IOC_READ: {
-               obdattr *oa = NULL;
                int err;
-               struct oic_rw_s rw_s;  /* read, write ioctl str */
+               struct oic_rw_s *rw_s = karg;  /* read, write ioctl str */
 
                err = copy_from_user(&rw_s, (int *)arg, sizeof(rw_s));
-               if ( err ) 
-                       goto READ_OUT;
+               if ( err ) {
+                       EXIT;
+                       return err;
+               }
 
-               
-               conn.oc_id = rw_s.conn_id;
-               if ( ! (oa = obd_oa_fromid(&conn, rw_s.id)) ) 
-                       return -ENOENT;
-
-               err = -EINVAL;
-               if ( !obddev->obd_type->typ_ops || 
-                    !obddev->obd_type->typ_ops->o_read ) 
-                       goto READ_OUT;
-
-               err = obddev->obd_type->typ_ops->o_read(&conn, oa, rw_s.buf,
-                                                       &rw_s.count,
-                                                       rw_s.offset);
-               if ( err ) 
-                       goto READ_OUT;
-
-               err = copy_to_user((int*)arg, &rw_s.count, sizeof(rw_s.count));
-
-       READ_OUT:
-               if ( oa ) 
-                       OBD_FREE(oa, sizeof(*oa));
+               conn.oc_id = rw_s->conn_id;
+
+               if ( !OBT(obddev) || !OBP(obddev, read) ) {
+                       err = -EOPNOTSUPP;
+                       EXIT;
+                       return err;
+               }
+
+               err = OBP(obddev, read)(&conn, &rw_s->obdo, rw_s->buf, 
+                                       &rw_s->count, rw_s->offset);
+               if ( err ) {
+                       EXIT;
+                       return err;
+               }
+                       
+               err = copy_to_user((int*)arg, &rw_s->count, sizeof(rw_s->count));
+               EXIT;
                return err;
        }
 
        case OBD_IOC_WRITE: {
-               obdattr *oa = NULL;
-               struct oic_rw_s rw_s;  /* read, write ioctl str */
+               struct oic_rw_s *rw_s = karg;  /* read, write ioctl str */
 
                err = copy_from_user(&rw_s, (int *)arg, sizeof(rw_s));
-               if ( err ) 
-                       goto WRITE_OUT;
-
-               conn.oc_id = rw_s.conn_id;
-               oa = obd_oa_fromid(&conn, rw_s.id);
-               if ( !oa ) 
-                       return -ENOENT;
+               if ( err ) {
+                       EXIT;
+                       return err;
+               }
 
-               err = -EINVAL;
-               if ( !obddev->obd_type->typ_ops || 
-                    !obddev->obd_type->typ_ops->o_write ) 
-                       goto WRITE_OUT;
+               conn.oc_id = rw_s->conn_id;
 
-               err = obddev->obd_type->typ_ops->o_write(&conn, oa, rw_s.buf,
-                                                        &rw_s.count,
-                                                        rw_s.offset);
-               if ( err ) 
-                       goto WRITE_OUT;
+               if ( !OBT(obddev) || !OBP(obddev, write) ) {
+                       err = -EOPNOTSUPP;
+                       return err;
+               }
 
-               err = copy_to_user((int*)arg, &rw_s.count, sizeof(rw_s.count));
+               err = OBP(obddev, write)(&conn, &rw_s->obdo, rw_s->buf, 
+                                        &rw_s->count, rw_s->offset);
+               if ( err ) {
+                       EXIT;
+                       return err;
+               }
 
-       WRITE_OUT:
-               OBD_FREE(oa, sizeof(*oa));
+               err = copy_to_user((int*)arg, &rw_s->count, sizeof(rw_s->count));
+               EXIT;
                return err;
        }
        case OBD_IOC_PREALLOCATE: {
-               struct oic_prealloc_s prealloc;
+               struct oic_prealloc_s *prealloc = karg;
 
                /* has this minor been registered? */
                if (!obddev->obd_type)
@@ -766,25 +598,28 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
 
                err = copy_from_user(&prealloc, (int *)arg, sizeof(prealloc));
                if (err) 
-                       return -ENOMEM;
+                       return -EFAULT;
 
                if ( !(obddev->obd_flags & OBD_ATTACHED) ||
                     !(obddev->obd_flags & OBD_SET_UP)) {
-                       CDEBUG(D_IOCTL, "fatal: device not initialized.\n");
-                       return -EINVAL;
+                       CDEBUG(D_IOCTL, "Device not attached or set up\n");
+                       return -ENODEV;
                }
 
-               if (!obddev->obd_type || 
-                   !obddev->obd_type->typ_ops->o_preallocate)
+               if ( !OBT(obddev) || !OBP(obddev, preallocate) )
                        return -EOPNOTSUPP;
-               conn.oc_id = prealloc.cli_id;
-               err = obddev->obd_type->typ_ops->o_preallocate(&conn,
-                                                              &prealloc.alloc,
-                                                              prealloc.inodes);
-               if ( err ) 
+
+               conn.oc_id = prealloc->cli_id;
+               err = OBP(obddev, preallocate)(&conn, &prealloc->alloc,
+                                              prealloc->ids);
+               if ( err ) {
+                       EXIT;
                        return err;
+               }
 
-               return copy_to_user((int *)arg, &prealloc, sizeof(prealloc));
+               err =copy_to_user((int *)arg, &prealloc, sizeof(prealloc));
+               EXIT;
+               return err;
        }
        case OBD_IOC_STATFS: {
                struct statfs *tmp;
@@ -797,18 +632,85 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
 
                tmp = (void *)arg + sizeof(unsigned int);
                get_user(conn_id, (int *) arg);
-               if ( !obddev->obd_type ||
-                    !obddev->obd_type->typ_ops->o_statfs)
-                       return -EINVAL;
+
+               if ( !OBT(obddev) || !OBP(obddev, statfs) )
+                       return -EOPNOTSUPP;
 
                conn.oc_id = conn_id;
-               err = obddev->obd_type->typ_ops->o_statfs(&conn, &buf);
-               if ( err ) 
+               err = OBP(obddev, statfs)(&conn, &buf);
+               if ( err ) {
+                       EXIT;
                        return err;
+               }
                err = copy_to_user(tmp, &buf, sizeof(buf));
+               EXIT;
                return err;
                
        }
+       case OBD_IOC_COPY: {
+               struct ioc_mv_s *mvdata = karg;
+
+               if ( (!(obddev->obd_flags & OBD_SET_UP)) ||
+                    (!(obddev->obd_flags & OBD_ATTACHED))) {
+                       CDEBUG(D_IOCTL, "Device not attached or set up\n");
+                       return -ENODEV;
+               }
+
+               /* get main structure */
+               err = copy_from_user(&mvdata, (void *) arg, sizeof(*mvdata));
+               if (err) {
+                       EXIT;
+                       return err;
+               }
+
+               if ( !OBT(obddev) || !OBP(obddev, copy) )
+                       return -EOPNOTSUPP;
+
+               /* do the partition */
+               CDEBUG(D_IOCTL, "Copy %d, type %s dst %Ld src %Ld\n", dev, 
+                      obddev->obd_type->typ_name, mvdata->dst.o_id, 
+                      mvdata->src.o_id);
+
+               conn.oc_id = mvdata->src_conn_id;
+
+               err = OBP(obddev, copy)(&conn, &mvdata->dst, 
+                                       &conn, &mvdata->src, 
+                                       mvdata->src.o_size, 0);
+               return err;
+       }
+
+       case OBD_IOC_MIGR: {
+               struct ioc_mv_s *mvdata = karg;
+
+               if ( (!(obddev->obd_flags & OBD_SET_UP)) ||
+                    (!(obddev->obd_flags & OBD_ATTACHED))) {
+                       CDEBUG(D_IOCTL, "Device not attached or set up\n");
+                       return -ENODEV;
+               }
+
+               err = copy_from_user(&mvdata, (void *) arg, sizeof(*mvdata));
+               if (err) {
+                       EXIT;
+                       return err;
+               }
+
+               CDEBUG(D_IOCTL, "Migrate copying %d\n", sizeof(mvdata));
+
+               if ( !OBT(obddev) || !OBP(obddev, migrate) )
+                       return -EOPNOTSUPP;
+
+               /* do the partition */
+               CDEBUG(D_IOCTL, "Migrate %d, type %s conn %d src %Ld dst %Ld\n",
+                      dev, obddev->obd_type->typ_name, mvdata->src_conn_id,
+                      mvdata->src.o_id, mvdata->dst.o_id);
+
+               conn.oc_id = mvdata->src_conn_id;
+               err = OBP(obddev, migrate)(&conn, &mvdata->dst, &mvdata->src, 
+                                          mvdata->dst.o_size, 0);
+
+               return err;
+       }
+
        default: {
                struct obd_type *type;
                struct oic_generic input;
@@ -836,9 +738,9 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
                        return -EINVAL;
                }
                
-               if ( !type->typ_ops->o_iocontrol ) {
+               if ( !type->typ_ops || !type->typ_ops->o_iocontrol ) {
                        EXIT;
-                       return -EINVAL;
+                       return -EOPNOTSUPP;
                }
                conn.oc_id = input.att_connid;
                
@@ -847,7 +749,7 @@ static int obd_class_ioctl (struct inode * inode, struct file * filp,
 
                /* get the generic data */
                karg = input.att_data;
-               err = getdata(input.att_datalen, &karg);
+               err = getdata(input.att_datalen, karg);
                if ( err ) {
                        EXIT;
                        return err;
@@ -902,16 +804,17 @@ int obd_unregister_type(char *nm)
 
        if ( !type ) {
                MOD_DEC_USE_COUNT;
-               printk("OBD: NO TYPE\n");
+               printk("Unknown obd type\n");
                EXIT;
-               return -1;
+               return -EINVAL;
        }
 
        if ( type->typ_refcnt ) {
                MOD_DEC_USE_COUNT;
-               printk("OBD: refcount wrap (%d)\n", type->typ_refcnt);
+               printk("OBD: Type %s has refcount (%d)\n", nm,
+                      type->typ_refcnt);
                EXIT;
-               return -1;
+               return -EBUSY;
        }
 
        list_del(&type->typ_chain);
@@ -946,7 +849,7 @@ int init_obd(void)
 {
        int i;
 
-       printk(KERN_INFO "OBD class driver  v0.002, braam@stelias.com\n");
+       printk(KERN_INFO "OBD class driver  v0.01, braam@stelias.com\n");
        
        INIT_LIST_HEAD(&obd_types);
        
@@ -963,6 +866,7 @@ int init_obd(void)
                INIT_LIST_HEAD(&obd_dev[i].obd_gen_clients);
        }
 
+       obd_init_obdo_cache();
        obd_sysctl_init();
        obd_init_magic = 0x11223344;
        return 0;
@@ -980,6 +884,7 @@ EXPORT_SYMBOL(gen_client);
 EXPORT_SYMBOL(gen_cleanup);
 EXPORT_SYMBOL(gen_disconnect);
 EXPORT_SYMBOL(gen_copy_data); 
+EXPORT_SYMBOL(obdo_cachep);
 
 /* EXPORT_SYMBOL(gen_multi_attach); */
 EXPORT_SYMBOL(gen_multi_setup);
@@ -1002,7 +907,8 @@ void cleanup_module(void)
                struct obd_device *obddev = &obd_dev[i];
                if ( obddev->obd_type && 
                     (obddev->obd_flags & OBD_SET_UP) &&
-                    obddev->obd_type->typ_ops->o_detach ) {
+                    OBT(obddev) && OBP(obddev, detach) ) {
+                       /* XXX should this call generic detach otherwise? */
                        OBP(obddev, detach)(obddev);
                } 
        }