Whamcloud - gitweb
LU-13799 clio: Skip prep for transients
[fs/lustre-release.git] / lustre / obdclass / cl_page.c
index c86b97d..0dc44cf 100644 (file)
@@ -27,7 +27,6 @@
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
- * Lustre is a trademark of Sun Microsystems, Inc.
  *
  * Client Lustre Page.
  *
@@ -204,29 +203,22 @@ static void cl_page_free(const struct lu_env *env, struct cl_page *cl_page,
        cs_pagestate_dec(obj, cl_page->cp_state);
        lu_object_ref_del_at(&obj->co_lu, &cl_page->cp_obj_ref,
                             "cl_page", cl_page);
-       cl_object_put(env, obj);
+       if (cl_page->cp_type != CPT_TRANSIENT)
+               cl_object_put(env, obj);
        lu_ref_fini(&cl_page->cp_reference);
        __cl_page_free(cl_page, bufsize);
        EXIT;
 }
 
-/**
- * Helper function updating page state. This is the only place in the code
- * where cl_page::cp_state field is mutated.
- */
-static inline void cl_page_state_set_trust(struct cl_page *page,
-                                           enum cl_page_state state)
-{
-        /* bypass const. */
-        *(enum cl_page_state *)&page->cp_state = state;
-}
-
 static struct cl_page *__cl_page_alloc(struct cl_object *o)
 {
        int i = 0;
        struct cl_page *cl_page = NULL;
        unsigned short bufsize = cl_object_header(o)->coh_page_bufsize;
 
+       if (OBD_FAIL_CHECK(OBD_FAIL_LLITE_PAGE_ALLOC))
+               return NULL;
+
 check:
        /* the number of entries in cl_page_kmem_array is expected to
         * only be 2-3 entries, so the lookup overhead should be low.
@@ -274,38 +266,46 @@ check:
        return cl_page;
 }
 
-struct cl_page *cl_page_alloc(const struct lu_env *env,
-               struct cl_object *o, pgoff_t ind, struct page *vmpage,
-               enum cl_page_type type)
+struct cl_page *cl_page_alloc(const struct lu_env *env, struct cl_object *o,
+                             pgoff_t ind, struct page *vmpage,
+                             enum cl_page_type type)
 {
-       struct cl_page          *page;
-       struct lu_object_header *head;
+       struct cl_page *cl_page;
+       struct cl_object *head;
 
        ENTRY;
 
-       page = __cl_page_alloc(o);
-       if (page != NULL) {
+       cl_page = __cl_page_alloc(o);
+       if (cl_page != NULL) {
                int result = 0;
-               atomic_set(&page->cp_ref, 1);
-               page->cp_obj = o;
-               cl_object_get(o);
-               lu_object_ref_add_at(&o->co_lu, &page->cp_obj_ref, "cl_page",
-                                    page);
-               page->cp_vmpage = vmpage;
-               cl_page_state_set_trust(page, CPS_CACHED);
-               page->cp_type = type;
-               INIT_LIST_HEAD(&page->cp_batch);
-               lu_ref_init(&page->cp_reference);
-               head = o->co_lu.lo_header;
-               list_for_each_entry(o, &head->loh_layers,
-                                   co_lu.lo_linkage) {
+
+               /*
+                * Please fix cl_page:cp_state/type declaration if
+                * these assertions fail in the future.
+                */
+               BUILD_BUG_ON((1 << CP_STATE_BITS) < CPS_NR); /* cp_state */
+               BUILD_BUG_ON((1 << CP_TYPE_BITS) < CPT_NR); /* cp_type */
+               atomic_set(&cl_page->cp_ref, 1);
+               cl_page->cp_obj = o;
+               if (type != CPT_TRANSIENT)
+                       cl_object_get(o);
+               lu_object_ref_add_at(&o->co_lu, &cl_page->cp_obj_ref,
+                                    "cl_page", cl_page);
+               cl_page->cp_vmpage = vmpage;
+               cl_page->cp_state = CPS_CACHED;
+               cl_page->cp_type = type;
+               cl_page->cp_inode = NULL;
+               INIT_LIST_HEAD(&cl_page->cp_batch);
+               lu_ref_init(&cl_page->cp_reference);
+               head = o;
+               cl_object_for_each(o, head) {
                        if (o->co_ops->coo_page_init != NULL) {
-                               result = o->co_ops->coo_page_init(env, o, page,
-                                                                 ind);
+                               result = o->co_ops->coo_page_init(env, o,
+                                                       cl_page, ind);
                                if (result != 0) {
-                                       cl_page_delete0(env, page);
-                                       cl_page_free(env, page, NULL);
-                                       page = ERR_PTR(result);
+                                       cl_page_delete0(env, cl_page);
+                                       cl_page_free(env, cl_page, NULL);
+                                       cl_page = ERR_PTR(result);
                                        break;
                                }
                        }
@@ -316,9 +316,9 @@ struct cl_page *cl_page_alloc(const struct lu_env *env,
                        cs_pagestate_dec(o, CPS_CACHED);
                }
        } else {
-               page = ERR_PTR(-ENOMEM);
+               cl_page = ERR_PTR(-ENOMEM);
        }
-       RETURN(page);
+       RETURN(cl_page);
 }
 
 /**
@@ -354,7 +354,7 @@ struct cl_page *cl_page_find(const struct lu_env *env,
         if (type == CPT_CACHEABLE) {
                /* vmpage lock is used to protect the child/parent
                 * relationship */
-               KLASSERT(PageLocked(vmpage));
+               LASSERT(PageLocked(vmpage));
                 /*
                  * cl_vmpage_page() can be called here without any locks as
                  *
@@ -383,62 +383,64 @@ static inline int cl_page_invariant(const struct cl_page *pg)
 }
 
 static void cl_page_state_set0(const struct lu_env *env,
-                               struct cl_page *page, enum cl_page_state state)
+                              struct cl_page *cl_page,
+                              enum cl_page_state state)
 {
-        enum cl_page_state old;
+       enum cl_page_state old;
 
-        /*
-         * Matrix of allowed state transitions [old][new], for sanity
-         * checking.
-         */
-        static const int allowed_transitions[CPS_NR][CPS_NR] = {
-                [CPS_CACHED] = {
-                        [CPS_CACHED]  = 0,
-                        [CPS_OWNED]   = 1, /* io finds existing cached page */
-                        [CPS_PAGEIN]  = 0,
-                        [CPS_PAGEOUT] = 1, /* write-out from the cache */
-                        [CPS_FREEING] = 1, /* eviction on the memory pressure */
-                },
-                [CPS_OWNED] = {
-                        [CPS_CACHED]  = 1, /* release to the cache */
-                        [CPS_OWNED]   = 0,
-                        [CPS_PAGEIN]  = 1, /* start read immediately */
-                        [CPS_PAGEOUT] = 1, /* start write immediately */
-                        [CPS_FREEING] = 1, /* lock invalidation or truncate */
-                },
-                [CPS_PAGEIN] = {
-                        [CPS_CACHED]  = 1, /* io completion */
-                        [CPS_OWNED]   = 0,
-                        [CPS_PAGEIN]  = 0,
-                        [CPS_PAGEOUT] = 0,
-                        [CPS_FREEING] = 0,
-                },
-                [CPS_PAGEOUT] = {
-                        [CPS_CACHED]  = 1, /* io completion */
-                        [CPS_OWNED]   = 0,
-                        [CPS_PAGEIN]  = 0,
-                        [CPS_PAGEOUT] = 0,
-                        [CPS_FREEING] = 0,
-                },
-                [CPS_FREEING] = {
-                        [CPS_CACHED]  = 0,
-                        [CPS_OWNED]   = 0,
-                        [CPS_PAGEIN]  = 0,
-                        [CPS_PAGEOUT] = 0,
-                        [CPS_FREEING] = 0,
-                }
-        };
+       /*
+        * Matrix of allowed state transitions [old][new], for sanity
+        * checking.
+        */
+       static const int allowed_transitions[CPS_NR][CPS_NR] = {
+               [CPS_CACHED] = {
+                       [CPS_CACHED]  = 0,
+                       [CPS_OWNED]   = 1, /* io finds existing cached page */
+                       [CPS_PAGEIN]  = 0,
+                       [CPS_PAGEOUT] = 1, /* write-out from the cache */
+                       [CPS_FREEING] = 1, /* eviction on the memory pressure */
+               },
+               [CPS_OWNED] = {
+                       [CPS_CACHED]  = 1, /* release to the cache */
+                       [CPS_OWNED]   = 0,
+                       [CPS_PAGEIN]  = 1, /* start read immediately */
+                       [CPS_PAGEOUT] = 1, /* start write immediately */
+                       [CPS_FREEING] = 1, /* lock invalidation or truncate */
+               },
+               [CPS_PAGEIN] = {
+                       [CPS_CACHED]  = 1, /* io completion */
+                       [CPS_OWNED]   = 0,
+                       [CPS_PAGEIN]  = 0,
+                       [CPS_PAGEOUT] = 0,
+                       [CPS_FREEING] = 0,
+               },
+               [CPS_PAGEOUT] = {
+                       [CPS_CACHED]  = 1, /* io completion */
+                       [CPS_OWNED]   = 0,
+                       [CPS_PAGEIN]  = 0,
+                       [CPS_PAGEOUT] = 0,
+                       [CPS_FREEING] = 0,
+               },
+               [CPS_FREEING] = {
+                       [CPS_CACHED]  = 0,
+                       [CPS_OWNED]   = 0,
+                       [CPS_PAGEIN]  = 0,
+                       [CPS_PAGEOUT] = 0,
+                       [CPS_FREEING] = 0,
+               }
+       };
 
-        ENTRY;
-        old = page->cp_state;
-        PASSERT(env, page, allowed_transitions[old][state]);
-        CL_PAGE_HEADER(D_TRACE, env, page, "%d -> %d\n", old, state);
-       PASSERT(env, page, page->cp_state == old);
-       PASSERT(env, page, equi(state == CPS_OWNED, page->cp_owner != NULL));
-
-       cs_pagestate_dec(page->cp_obj, page->cp_state);
-       cs_pagestate_inc(page->cp_obj, state);
-       cl_page_state_set_trust(page, state);
+       ENTRY;
+       old = cl_page->cp_state;
+       PASSERT(env, cl_page, allowed_transitions[old][state]);
+       CL_PAGE_HEADER(D_TRACE, env, cl_page, "%d -> %d\n", old, state);
+       PASSERT(env, cl_page, cl_page->cp_state == old);
+       PASSERT(env, cl_page, equi(state == CPS_OWNED,
+                                  cl_page->cp_owner != NULL));
+
+       cs_pagestate_dec(cl_page->cp_obj, cl_page->cp_state);
+       cs_pagestate_inc(cl_page->cp_obj, state);
+       cl_page->cp_state = state;
        EXIT;
 }
 
@@ -517,7 +519,7 @@ struct cl_page *cl_vmpage_page(struct page *vmpage, struct cl_object *obj)
        struct cl_page *page;
 
        ENTRY;
-       KLASSERT(PageLocked(vmpage));
+       LASSERT(PageLocked(vmpage));
 
        /*
         * NOTE: absence of races and liveness of data are guaranteed by page
@@ -981,13 +983,16 @@ int cl_page_prep(const struct lu_env *env, struct cl_io *io,
        if (crt >= CRT_NR)
                return -EINVAL;
 
-       cl_page_slice_for_each(cl_page, slice, i) {
-               if (slice->cpl_ops->cpo_own)
-                       result = (*slice->cpl_ops->io[crt].cpo_prep)(env,
+       if (cl_page->cp_type != CPT_TRANSIENT) {
+               cl_page_slice_for_each(cl_page, slice, i) {
+                       if (slice->cpl_ops->cpo_own)
+                               result =
+                                (*slice->cpl_ops->io[crt].cpo_prep)(env,
                                                                     slice,
                                                                     io);
-               if (result != 0)
-                       break;
+                       if (result != 0)
+                               break;
+               }
        }
 
        if (result >= 0) {
@@ -1217,6 +1222,7 @@ void cl_page_slice_add(struct cl_page *cl_page, struct cl_page_slice *slice,
                        ((char *)cl_page + sizeof(*cl_page));
 
        ENTRY;
+       LASSERT(cl_page->cp_layer_count < CP_MAX_LAYER);
        LASSERT(offset < (1 << sizeof(cl_page->cp_layer_offset[0]) * 8));
        cl_page->cp_layer_offset[cl_page->cp_layer_count++] = offset;
        slice->cpl_obj  = obj;