Whamcloud - gitweb
LU-3963 obdclass: convert to linux list api
[fs/lustre-release.git] / lustre / obdclass / cl_lock.c
index ad244e4..6aaf676 100644 (file)
@@ -1,6 +1,4 @@
-/* -*- mode: c; c-basic-offset: 8; indent-tabs-mode: nil; -*-
- * vim:expandtab:shiftwidth=8:tabstop=8:
- *
+/*
  * GPL HEADER START
  *
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
@@ -28,6 +26,8 @@
 /*
  * Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
+ *
+ * Copyright (c) 2011, 2013, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
  * Client Extent Lock.
  *
  *   Author: Nikita Danilov <nikita.danilov@sun.com>
+ *   Author: Jinshan Xiong <jinshan.xiong@intel.com>
  */
 
 #define DEBUG_SUBSYSTEM S_CLASS
-#ifndef EXPORT_SYMTAB
-# define EXPORT_SYMTAB
-#endif
 
+#include <libcfs/libcfs.h>
 #include <obd_class.h>
 #include <obd_support.h>
 #include <lustre_fid.h>
 #include <libcfs/list.h>
-/* lu_time_global_{init,fini}() */
-#include <lu_time.h>
-
 #include <cl_object.h>
 #include "cl_internal.h"
 
 /** Lock class of cl_lock::cll_guard */
-static cfs_lock_class_key_t cl_lock_guard_class;
-static cfs_mem_cache_t *cl_lock_kmem;
+static struct lock_class_key cl_lock_guard_class;
+static struct kmem_cache *cl_lock_kmem;
 
 static struct lu_kmem_descr cl_lock_caches[] = {
         {
@@ -68,6 +64,22 @@ static struct lu_kmem_descr cl_lock_caches[] = {
         }
 };
 
+#ifdef CONFIG_DEBUG_PAGESTATE_TRACKING
+#define CS_LOCK_INC(o, item) \
+       atomic_inc(&cl_object_site(o)->cs_locks.cs_stats[CS_##item])
+#define CS_LOCK_DEC(o, item) \
+       atomic_dec(&cl_object_site(o)->cs_locks.cs_stats[CS_##item])
+#define CS_LOCKSTATE_INC(o, state) \
+       atomic_inc(&cl_object_site(o)->cs_locks_state[state])
+#define CS_LOCKSTATE_DEC(o, state) \
+       atomic_dec(&cl_object_site(o)->cs_locks_state[state])
+#else
+#define CS_LOCK_INC(o, item)
+#define CS_LOCK_DEC(o, item)
+#define CS_LOCKSTATE_INC(o, state)
+#define CS_LOCKSTATE_DEC(o, state)
+#endif
+
 /**
  * Basic lock invariant that is maintained at all times. Caller either has a
  * reference to \a lock, or somehow assures that \a lock cannot be freed.
@@ -77,10 +89,8 @@ static struct lu_kmem_descr cl_lock_caches[] = {
 static int cl_lock_invariant_trusted(const struct lu_env *env,
                                      const struct cl_lock *lock)
 {
-        return
-                cl_is_lock(lock) &&
-                ergo(lock->cll_state == CLS_FREEING, lock->cll_holds == 0) &&
-                cfs_atomic_read(&lock->cll_ref) >= lock->cll_holds &&
+        return  ergo(lock->cll_state == CLS_FREEING, lock->cll_holds == 0) &&
+               atomic_read(&lock->cll_ref) >= lock->cll_holds &&
                 lock->cll_holds >= lock->cll_users &&
                 lock->cll_holds >= 0 &&
                 lock->cll_users >= 0 &&
@@ -97,11 +107,11 @@ static int cl_lock_invariant(const struct lu_env *env,
 {
         int result;
 
-        result = cfs_atomic_read(&lock->cll_ref) > 0 &&
+       result = atomic_read(&lock->cll_ref) > 0 &&
                 cl_lock_invariant_trusted(env, lock);
-        if (!result && env != NULL)
-                CL_LOCK_DEBUG(D_ERROR, env, lock, "invariant broken");
-        return result;
+       if (!result && env != NULL)
+               CL_LOCK_DEBUG(D_ERROR, env, lock, "invariant broken\n");
+       return result;
 }
 
 /**
@@ -132,9 +142,9 @@ static void cl_lock_trace0(int level, const struct lu_env *env,
                            const char *func, const int line)
 {
         struct cl_object_header *h = cl_object_header(lock->cll_descr.cld_obj);
-        CDEBUG(level, "%s: %p@(%i %p %i %d %d %d %d %lx)"
-                      "(%p/%d/%i) at %s():%d\n",
-               prefix, lock, cfs_atomic_read(&lock->cll_ref),
+        CDEBUG(level, "%s: %p@(%d %p %d %d %d %d %d %lx)"
+                      "(%p/%d/%d) at %s():%d\n",
+              prefix, lock, atomic_read(&lock->cll_ref),
                lock->cll_guarder, lock->cll_depth,
                lock->cll_state, lock->cll_error, lock->cll_holds,
                lock->cll_users, lock->cll_flags,
@@ -147,7 +157,7 @@ static void cl_lock_trace0(int level, const struct lu_env *env,
 #define RETIP ((unsigned long)__builtin_return_address(0))
 
 #ifdef CONFIG_LOCKDEP
-static cfs_lock_class_key_t cl_lock_key;
+static struct lock_class_key cl_lock_key;
 
 static void cl_lock_lockdep_init(struct cl_lock *lock)
 {
@@ -158,20 +168,14 @@ static void cl_lock_lockdep_acquire(const struct lu_env *env,
                                     struct cl_lock *lock, __u32 enqflags)
 {
         cl_lock_counters(env, lock)->ctc_nr_locks_acquired++;
-#ifdef HAVE_LOCK_MAP_ACQUIRE
         lock_map_acquire(&lock->dep_map);
-#else  /* HAVE_LOCK_MAP_ACQUIRE */
-        lock_acquire(&lock->dep_map, !!(enqflags & CEF_ASYNC),
-                     /* try: */ 0, lock->cll_descr.cld_mode <= CLM_READ,
-                     /* check: */ 2, RETIP);
-#endif /* HAVE_LOCK_MAP_ACQUIRE */
 }
 
 static void cl_lock_lockdep_release(const struct lu_env *env,
                                     struct cl_lock *lock)
 {
         cl_lock_counters(env, lock)->ctc_nr_locks_acquired--;
-        lock_release(&lock->dep_map, 0, RETIP);
+       lock_map_release(&lock->dep_map);
 }
 
 #else /* !CONFIG_LOCKDEP */
@@ -200,12 +204,12 @@ void cl_lock_slice_add(struct cl_lock *lock, struct cl_lock_slice *slice,
                        struct cl_object *obj,
                        const struct cl_lock_operations *ops)
 {
-        ENTRY;
-        slice->cls_lock = lock;
-        cfs_list_add_tail(&slice->cls_linkage, &lock->cll_layers);
-        slice->cls_obj = obj;
-        slice->cls_ops = ops;
-        EXIT;
+       ENTRY;
+       slice->cls_lock = lock;
+       list_add_tail(&slice->cls_linkage, &lock->cll_layers);
+       slice->cls_obj = obj;
+       slice->cls_ops = ops;
+       EXIT;
 }
 EXPORT_SYMBOL(cl_lock_slice_add);
 
@@ -261,27 +265,25 @@ static void cl_lock_free(const struct lu_env *env, struct cl_lock *lock)
 {
         struct cl_object *obj = lock->cll_descr.cld_obj;
 
-        LASSERT(cl_is_lock(lock));
         LINVRNT(!cl_lock_is_mutexed(lock));
 
-        ENTRY;
-        cl_lock_trace(D_DLMTRACE, env, "free lock", lock);
-        cfs_might_sleep();
-        while (!cfs_list_empty(&lock->cll_layers)) {
-                struct cl_lock_slice *slice;
-
-                slice = cfs_list_entry(lock->cll_layers.next,
-                                       struct cl_lock_slice, cls_linkage);
-                cfs_list_del_init(lock->cll_layers.next);
-                slice->cls_ops->clo_fini(env, slice);
-        }
-        cfs_atomic_dec(&cl_object_site(obj)->cs_locks.cs_total);
-        cfs_atomic_dec(&cl_object_site(obj)->cs_locks_state[lock->cll_state]);
-        lu_object_ref_del_at(&obj->co_lu, lock->cll_obj_ref, "cl_lock", lock);
+       ENTRY;
+       cl_lock_trace(D_DLMTRACE, env, "free lock", lock);
+       while (!list_empty(&lock->cll_layers)) {
+               struct cl_lock_slice *slice;
+
+               slice = list_entry(lock->cll_layers.next,
+                                  struct cl_lock_slice, cls_linkage);
+               list_del_init(lock->cll_layers.next);
+               slice->cls_ops->clo_fini(env, slice);
+       }
+       CS_LOCK_DEC(obj, total);
+       CS_LOCKSTATE_DEC(obj, lock->cll_state);
+       lu_object_ref_del_at(&obj->co_lu, &lock->cll_obj_ref, "cl_lock", lock);
         cl_object_put(env, obj);
         lu_ref_fini(&lock->cll_reference);
         lu_ref_fini(&lock->cll_holders);
-        cfs_mutex_destroy(&lock->cll_guard);
+       mutex_destroy(&lock->cll_guard);
         OBD_SLAB_FREE_PTR(lock, cl_lock_kmem);
         EXIT;
 }
@@ -298,25 +300,21 @@ static void cl_lock_free(const struct lu_env *env, struct cl_lock *lock)
 void cl_lock_put(const struct lu_env *env, struct cl_lock *lock)
 {
         struct cl_object        *obj;
-        struct cl_object_header *head;
-        struct cl_site          *site;
 
         LINVRNT(cl_lock_invariant(env, lock));
         ENTRY;
         obj = lock->cll_descr.cld_obj;
         LINVRNT(obj != NULL);
-        head = cl_object_header(obj);
-        site = cl_object_site(obj);
 
         CDEBUG(D_TRACE, "releasing reference: %d %p %lu\n",
-               cfs_atomic_read(&lock->cll_ref), lock, RETIP);
+              atomic_read(&lock->cll_ref), lock, RETIP);
 
-        if (cfs_atomic_dec_and_test(&lock->cll_ref)) {
+       if (atomic_dec_and_test(&lock->cll_ref)) {
                 if (lock->cll_state == CLS_FREEING) {
-                        LASSERT(cfs_list_empty(&lock->cll_linkage));
+                       LASSERT(list_empty(&lock->cll_linkage));
                         cl_lock_free(env, lock);
                 }
-                cfs_atomic_dec(&site->cs_locks.cs_busy);
+               CS_LOCK_DEC(obj, busy);
         }
         EXIT;
 }
@@ -334,8 +332,8 @@ void cl_lock_get(struct cl_lock *lock)
 {
         LINVRNT(cl_lock_invariant(NULL, lock));
         CDEBUG(D_TRACE, "acquiring reference: %d %p %lu\n",
-               cfs_atomic_read(&lock->cll_ref), lock, RETIP);
-        cfs_atomic_inc(&lock->cll_ref);
+              atomic_read(&lock->cll_ref), lock, RETIP);
+       atomic_inc(&lock->cll_ref);
 }
 EXPORT_SYMBOL(cl_lock_get);
 
@@ -350,13 +348,10 @@ EXPORT_SYMBOL(cl_lock_get);
  */
 void cl_lock_get_trust(struct cl_lock *lock)
 {
-        struct cl_site *site = cl_object_site(lock->cll_descr.cld_obj);
-
-        LASSERT(cl_is_lock(lock));
         CDEBUG(D_TRACE, "acquiring trusted reference: %d %p %lu\n",
-               cfs_atomic_read(&lock->cll_ref), lock, RETIP);
-        if (cfs_atomic_inc_return(&lock->cll_ref) == 1)
-                cfs_atomic_inc(&site->cs_locks.cs_busy);
+              atomic_read(&lock->cll_ref), lock, RETIP);
+       if (atomic_inc_return(&lock->cll_ref) == 1)
+               CS_LOCK_INC(lock->cll_descr.cld_obj, busy);
 }
 EXPORT_SYMBOL(cl_lock_get_trust);
 
@@ -376,50 +371,48 @@ static void cl_lock_finish(const struct lu_env *env, struct cl_lock *lock)
 }
 
 static struct cl_lock *cl_lock_alloc(const struct lu_env *env,
-                                     struct cl_object *obj,
-                                     const struct cl_io *io,
-                                     const struct cl_lock_descr *descr)
-{
-        struct cl_lock          *lock;
-        struct lu_object_header *head;
-        struct cl_site          *site = cl_object_site(obj);
-
-        ENTRY;
-        OBD_SLAB_ALLOC_PTR_GFP(lock, cl_lock_kmem, CFS_ALLOC_IO);
-        if (lock != NULL) {
-                cfs_atomic_set(&lock->cll_ref, 1);
-                lock->cll_descr = *descr;
-                lock->cll_state = CLS_NEW;
-                cl_object_get(obj);
-                lock->cll_obj_ref = lu_object_ref_add(&obj->co_lu,
-                                                      "cl_lock", lock);
-                CFS_INIT_LIST_HEAD(&lock->cll_layers);
-                CFS_INIT_LIST_HEAD(&lock->cll_linkage);
-                CFS_INIT_LIST_HEAD(&lock->cll_inclosure);
-                lu_ref_init(&lock->cll_reference);
-                lu_ref_init(&lock->cll_holders);
-                cfs_mutex_init(&lock->cll_guard);
-                cfs_lockdep_set_class(&lock->cll_guard, &cl_lock_guard_class);
-                cfs_waitq_init(&lock->cll_wq);
-                head = obj->co_lu.lo_header;
-                cfs_atomic_inc(&site->cs_locks_state[CLS_NEW]);
-                cfs_atomic_inc(&site->cs_locks.cs_total);
-                cfs_atomic_inc(&site->cs_locks.cs_created);
-                cl_lock_lockdep_init(lock);
-                cfs_list_for_each_entry(obj, &head->loh_layers,
-                                        co_lu.lo_linkage) {
-                        int err;
-
-                        err = obj->co_ops->coo_lock_init(env, obj, lock, io);
-                        if (err != 0) {
-                                cl_lock_finish(env, lock);
-                                lock = ERR_PTR(err);
-                                break;
-                        }
-                }
-        } else
-                lock = ERR_PTR(-ENOMEM);
-        RETURN(lock);
+                                    struct cl_object *obj,
+                                    const struct cl_io *io,
+                                    const struct cl_lock_descr *descr)
+{
+       struct cl_lock          *lock;
+       struct lu_object_header *head;
+
+       ENTRY;
+       OBD_SLAB_ALLOC_PTR_GFP(lock, cl_lock_kmem, GFP_NOFS);
+       if (lock != NULL) {
+               atomic_set(&lock->cll_ref, 1);
+               lock->cll_descr = *descr;
+               lock->cll_state = CLS_NEW;
+               cl_object_get(obj);
+               lu_object_ref_add_at(&obj->co_lu, &lock->cll_obj_ref, "cl_lock",
+                                    lock);
+               INIT_LIST_HEAD(&lock->cll_layers);
+               INIT_LIST_HEAD(&lock->cll_linkage);
+               INIT_LIST_HEAD(&lock->cll_inclosure);
+               lu_ref_init(&lock->cll_reference);
+               lu_ref_init(&lock->cll_holders);
+               mutex_init(&lock->cll_guard);
+               lockdep_set_class(&lock->cll_guard, &cl_lock_guard_class);
+               init_waitqueue_head(&lock->cll_wq);
+               head = obj->co_lu.lo_header;
+               CS_LOCKSTATE_INC(obj, CLS_NEW);
+               CS_LOCK_INC(obj, total);
+               CS_LOCK_INC(obj, create);
+               cl_lock_lockdep_init(lock);
+               list_for_each_entry(obj, &head->loh_layers, co_lu.lo_linkage) {
+                       int err;
+
+                       err = obj->co_ops->coo_lock_init(env, obj, lock, io);
+                       if (err != 0) {
+                               cl_lock_finish(env, lock);
+                               lock = ERR_PTR(err);
+                               break;
+                       }
+               }
+       } else
+               lock = ERR_PTR(-ENOMEM);
+       RETURN(lock);
 }
 
 /**
@@ -430,19 +423,19 @@ static struct cl_lock *cl_lock_alloc(const struct lu_env *env,
  * \see CLS_INTRANSIT
  */
 enum cl_lock_state cl_lock_intransit(const struct lu_env *env,
-                                     struct cl_lock *lock)
+                                    struct cl_lock *lock)
 {
-        enum cl_lock_state state = lock->cll_state;
+       enum cl_lock_state state = lock->cll_state;
 
-        LASSERT(cl_lock_is_mutexed(lock));
-        LASSERT(state != CLS_INTRANSIT);
-        LASSERTF(state >= CLS_ENQUEUED && state <= CLS_CACHED,
-                 "Malformed lock state %d.\n", state);
+       LASSERT(cl_lock_is_mutexed(lock));
+       LASSERT(state != CLS_INTRANSIT);
+       LASSERTF(state >= CLS_ENQUEUED && state <= CLS_CACHED,
+                "Malformed lock state %d.\n", state);
 
-        cl_lock_state_set(env, lock, CLS_INTRANSIT);
-        lock->cll_intransit_owner = cfs_current();
-        cl_lock_hold_add(env, lock, "intransit", cfs_current());
-        return state;
+       cl_lock_state_set(env, lock, CLS_INTRANSIT);
+       lock->cll_intransit_owner = current;
+       cl_lock_hold_add(env, lock, "intransit", current);
+       return state;
 }
 EXPORT_SYMBOL(cl_lock_intransit);
 
@@ -450,16 +443,16 @@ EXPORT_SYMBOL(cl_lock_intransit);
  *  Exit the intransit state and restore the lock state to the original state
  */
 void cl_lock_extransit(const struct lu_env *env, struct cl_lock *lock,
-                       enum cl_lock_state state)
+                      enum cl_lock_state state)
 {
-        LASSERT(cl_lock_is_mutexed(lock));
-        LASSERT(lock->cll_state == CLS_INTRANSIT);
-        LASSERT(state != CLS_INTRANSIT);
-        LASSERT(lock->cll_intransit_owner == cfs_current());
+       LASSERT(cl_lock_is_mutexed(lock));
+       LASSERT(lock->cll_state == CLS_INTRANSIT);
+       LASSERT(state != CLS_INTRANSIT);
+       LASSERT(lock->cll_intransit_owner == current);
 
-        lock->cll_intransit_owner = NULL;
-        cl_lock_state_set(env, lock, state);
-        cl_lock_unhold(env, lock, "intransit", cfs_current());
+       lock->cll_intransit_owner = NULL;
+       cl_lock_state_set(env, lock, state);
+       cl_lock_unhold(env, lock, "intransit", current);
 }
 EXPORT_SYMBOL(cl_lock_extransit);
 
@@ -468,9 +461,9 @@ EXPORT_SYMBOL(cl_lock_extransit);
  */
 int cl_lock_is_intransit(struct cl_lock *lock)
 {
-        LASSERT(cl_lock_is_mutexed(lock));
-        return lock->cll_state == CLS_INTRANSIT &&
-               lock->cll_intransit_owner != cfs_current();
+       LASSERT(cl_lock_is_mutexed(lock));
+       return lock->cll_state == CLS_INTRANSIT &&
+              lock->cll_intransit_owner != current;
 }
 EXPORT_SYMBOL(cl_lock_is_intransit);
 /**
@@ -487,7 +480,7 @@ static int cl_lock_fits_into(const struct lu_env *env,
 
         LINVRNT(cl_lock_invariant_trusted(env, lock));
         ENTRY;
-        cfs_list_for_each_entry(slice, &lock->cll_layers, cls_linkage) {
+       list_for_each_entry(slice, &lock->cll_layers, cls_linkage) {
                 if (slice->cls_ops->clo_fits_into != NULL &&
                     !slice->cls_ops->clo_fits_into(env, slice, need, io))
                         RETURN(0);
@@ -502,29 +495,26 @@ static struct cl_lock *cl_lock_lookup(const struct lu_env *env,
 {
         struct cl_lock          *lock;
         struct cl_object_header *head;
-        struct cl_site          *site;
 
         ENTRY;
 
-        head = cl_object_header(obj);
-        site = cl_object_site(obj);
-        LINVRNT_SPIN_LOCKED(&head->coh_lock_guard);
-        cfs_atomic_inc(&site->cs_locks.cs_lookup);
-        cfs_list_for_each_entry(lock, &head->coh_locks, cll_linkage) {
-                int matched;
+       head = cl_object_header(obj);
+       assert_spin_locked(&head->coh_lock_guard);
+       CS_LOCK_INC(obj, lookup);
+       list_for_each_entry(lock, &head->coh_locks, cll_linkage) {
+               int matched;
 
-                LASSERT(cl_is_lock(lock));
                 matched = cl_lock_ext_match(&lock->cll_descr, need) &&
                           lock->cll_state < CLS_FREEING &&
                           lock->cll_error == 0 &&
                           !(lock->cll_flags & CLF_CANCELLED) &&
                           cl_lock_fits_into(env, lock, need, io);
-                CDEBUG(D_DLMTRACE, "has: "DDESCR"(%i) need: "DDESCR": %d\n",
+                CDEBUG(D_DLMTRACE, "has: "DDESCR"(%d) need: "DDESCR": %d\n",
                        PDESCR(&lock->cll_descr), lock->cll_state, PDESCR(need),
                        matched);
                 if (matched) {
                         cl_lock_get_trust(lock);
-                        cfs_atomic_inc(&cl_object_site(obj)->cs_locks.cs_hit);
+                       CS_LOCK_INC(obj, hit);
                         RETURN(lock);
                 }
         }
@@ -548,32 +538,31 @@ static struct cl_lock *cl_lock_find(const struct lu_env *env,
         struct cl_object_header *head;
         struct cl_object        *obj;
         struct cl_lock          *lock;
-        struct cl_site          *site;
 
         ENTRY;
 
         obj  = need->cld_obj;
         head = cl_object_header(obj);
-        site = cl_object_site(obj);
-
-        cfs_spin_lock(&head->coh_lock_guard);
-        lock = cl_lock_lookup(env, obj, io, need);
-        cfs_spin_unlock(&head->coh_lock_guard);
-
-        if (lock == NULL) {
-                lock = cl_lock_alloc(env, obj, io, need);
-                if (!IS_ERR(lock)) {
-                        struct cl_lock *ghost;
-
-                        cfs_spin_lock(&head->coh_lock_guard);
-                        ghost = cl_lock_lookup(env, obj, io, need);
-                        if (ghost == NULL) {
-                                cfs_list_add_tail(&lock->cll_linkage,
-                                                  &head->coh_locks);
-                                cfs_spin_unlock(&head->coh_lock_guard);
-                                cfs_atomic_inc(&site->cs_locks.cs_busy);
-                        } else {
-                                cfs_spin_unlock(&head->coh_lock_guard);
+
+       spin_lock(&head->coh_lock_guard);
+       lock = cl_lock_lookup(env, obj, io, need);
+       spin_unlock(&head->coh_lock_guard);
+
+       if (lock == NULL) {
+               lock = cl_lock_alloc(env, obj, io, need);
+               if (!IS_ERR(lock)) {
+                       struct cl_lock *ghost;
+
+                       spin_lock(&head->coh_lock_guard);
+                       ghost = cl_lock_lookup(env, obj, io, need);
+                       if (ghost == NULL) {
+                               cl_lock_get_trust(lock);
+                               list_add_tail(&lock->cll_linkage,
+                                             &head->coh_locks);
+                               spin_unlock(&head->coh_lock_guard);
+                               CS_LOCK_INC(obj, busy);
+                       } else {
+                               spin_unlock(&head->coh_lock_guard);
                                 /*
                                  * Other threads can acquire references to the
                                  * top-lock through its sub-locks. Hence, it
@@ -599,35 +588,40 @@ struct cl_lock *cl_lock_peek(const struct lu_env *env, const struct cl_io *io,
         struct cl_object_header *head;
         struct cl_object        *obj;
         struct cl_lock          *lock;
-        int ok;
 
         obj  = need->cld_obj;
         head = cl_object_header(obj);
 
-        cfs_spin_lock(&head->coh_lock_guard);
-        lock = cl_lock_lookup(env, obj, io, need);
-        cfs_spin_unlock(&head->coh_lock_guard);
-
-        if (lock == NULL)
-                return NULL;
-
-        cl_lock_mutex_get(env, lock);
-        if (lock->cll_state == CLS_INTRANSIT)
-                cl_lock_state_wait(env, lock); /* Don't care return value. */
-        if (lock->cll_state == CLS_CACHED) {
-                int result;
-                result = cl_use_try(env, lock, 1);
-                if (result < 0)
-                        cl_lock_error(env, lock, result);
-        }
-        ok = lock->cll_state == CLS_HELD;
-        if (ok) {
-                cl_lock_hold_add(env, lock, scope, source);
-                cl_lock_user_add(env, lock);
-                cl_lock_put(env, lock);
-        }
-        cl_lock_mutex_put(env, lock);
-        if (!ok) {
+       do {
+               spin_lock(&head->coh_lock_guard);
+               lock = cl_lock_lookup(env, obj, io, need);
+               spin_unlock(&head->coh_lock_guard);
+               if (lock == NULL)
+                       return NULL;
+
+               cl_lock_mutex_get(env, lock);
+               if (lock->cll_state == CLS_INTRANSIT)
+                       /* Don't care return value. */
+                       cl_lock_state_wait(env, lock);
+               if (lock->cll_state == CLS_FREEING) {
+                       cl_lock_mutex_put(env, lock);
+                       cl_lock_put(env, lock);
+                       lock = NULL;
+               }
+       } while (lock == NULL);
+
+       cl_lock_hold_add(env, lock, scope, source);
+       cl_lock_user_add(env, lock);
+       if (lock->cll_state == CLS_CACHED)
+               cl_use_try(env, lock, 1);
+       if (lock->cll_state == CLS_HELD) {
+               cl_lock_mutex_put(env, lock);
+               cl_lock_lockdep_acquire(env, lock, 0);
+               cl_lock_put(env, lock);
+       } else {
+               cl_unuse_try(env, lock);
+               cl_lock_unhold(env, lock, scope, source);
+                cl_lock_mutex_put(env, lock);
                 cl_lock_put(env, lock);
                 lock = NULL;
         }
@@ -650,7 +644,7 @@ const struct cl_lock_slice *cl_lock_at(const struct cl_lock *lock,
         LINVRNT(cl_lock_invariant_trusted(NULL, lock));
         ENTRY;
 
-        cfs_list_for_each_entry(slice, &lock->cll_layers, cls_linkage) {
+       list_for_each_entry(slice, &lock->cll_layers, cls_linkage) {
                 if (slice->cls_obj->co_lu.lo_dev->ld_type == dtype)
                         RETURN(slice);
         }
@@ -681,29 +675,29 @@ static void cl_lock_mutex_tail(const struct lu_env *env, struct cl_lock *lock)
  */
 void cl_lock_mutex_get(const struct lu_env *env, struct cl_lock *lock)
 {
-        LINVRNT(cl_lock_invariant(env, lock));
-
-        if (lock->cll_guarder == cfs_current()) {
-                LINVRNT(cl_lock_is_mutexed(lock));
-                LINVRNT(lock->cll_depth > 0);
-        } else {
-                struct cl_object_header *hdr;
-                struct cl_thread_info   *info;
-                int i;
-
-                LINVRNT(lock->cll_guarder != cfs_current());
-                hdr = cl_object_header(lock->cll_descr.cld_obj);
-                /*
-                 * Check that mutices are taken in the bottom-to-top order.
-                 */
-                info = cl_env_info(env);
-                for (i = 0; i < hdr->coh_nesting; ++i)
-                        LASSERT(info->clt_counters[i].ctc_nr_locks_locked == 0);
-                cfs_mutex_lock_nested(&lock->cll_guard, hdr->coh_nesting);
-                lock->cll_guarder = cfs_current();
-                LINVRNT(lock->cll_depth == 0);
-        }
-        cl_lock_mutex_tail(env, lock);
+       LINVRNT(cl_lock_invariant(env, lock));
+
+       if (lock->cll_guarder == current) {
+               LINVRNT(cl_lock_is_mutexed(lock));
+               LINVRNT(lock->cll_depth > 0);
+       } else {
+               struct cl_object_header *hdr;
+               struct cl_thread_info   *info;
+               int i;
+
+               LINVRNT(lock->cll_guarder != current);
+               hdr = cl_object_header(lock->cll_descr.cld_obj);
+               /*
+                * Check that mutices are taken in the bottom-to-top order.
+                */
+               info = cl_env_info(env);
+               for (i = 0; i < hdr->coh_nesting; ++i)
+                       LASSERT(info->clt_counters[i].ctc_nr_locks_locked == 0);
+               mutex_lock_nested(&lock->cll_guard, hdr->coh_nesting);
+               lock->cll_guarder = current;
+               LINVRNT(lock->cll_depth == 0);
+       }
+       cl_lock_mutex_tail(env, lock);
 }
 EXPORT_SYMBOL(cl_lock_mutex_get);
 
@@ -720,22 +714,22 @@ EXPORT_SYMBOL(cl_lock_mutex_get);
  */
 int cl_lock_mutex_try(const struct lu_env *env, struct cl_lock *lock)
 {
-        int result;
+       int result;
 
-        LINVRNT(cl_lock_invariant_trusted(env, lock));
-        ENTRY;
+       LINVRNT(cl_lock_invariant_trusted(env, lock));
+       ENTRY;
 
-        result = 0;
-        if (lock->cll_guarder == cfs_current()) {
-                LINVRNT(lock->cll_depth > 0);
-                cl_lock_mutex_tail(env, lock);
-        } else if (cfs_mutex_trylock(&lock->cll_guard)) {
-                LINVRNT(lock->cll_depth == 0);
-                lock->cll_guarder = cfs_current();
-                cl_lock_mutex_tail(env, lock);
-        } else
-                result = -EBUSY;
-        RETURN(result);
+       result = 0;
+       if (lock->cll_guarder == current) {
+               LINVRNT(lock->cll_depth > 0);
+               cl_lock_mutex_tail(env, lock);
+       } else if (mutex_trylock(&lock->cll_guard)) {
+               LINVRNT(lock->cll_depth == 0);
+               lock->cll_guarder = current;
+               cl_lock_mutex_tail(env, lock);
+       } else
+               result = -EBUSY;
+       RETURN(result);
 }
 EXPORT_SYMBOL(cl_lock_mutex_try);
 
@@ -748,23 +742,23 @@ EXPORT_SYMBOL(cl_lock_mutex_try);
  */
 void cl_lock_mutex_put(const struct lu_env *env, struct cl_lock *lock)
 {
-        struct cl_thread_counters *counters;
+       struct cl_thread_counters *counters;
 
-        LINVRNT(cl_lock_invariant(env, lock));
-        LINVRNT(cl_lock_is_mutexed(lock));
-        LINVRNT(lock->cll_guarder == cfs_current());
-        LINVRNT(lock->cll_depth > 0);
+       LINVRNT(cl_lock_invariant(env, lock));
+       LINVRNT(cl_lock_is_mutexed(lock));
+       LINVRNT(lock->cll_guarder == current);
+       LINVRNT(lock->cll_depth > 0);
 
-        counters = cl_lock_counters(env, lock);
-        LINVRNT(counters->ctc_nr_locks_locked > 0);
-
-        cl_lock_trace(D_TRACE, env, "put mutex", lock);
-        lu_ref_del(&counters->ctc_locks_locked, "cll_guard", lock);
-        counters->ctc_nr_locks_locked--;
-        if (--lock->cll_depth == 0) {
-                lock->cll_guarder = NULL;
-                cfs_mutex_unlock(&lock->cll_guard);
-        }
+       counters = cl_lock_counters(env, lock);
+       LINVRNT(counters->ctc_nr_locks_locked > 0);
+
+       cl_lock_trace(D_TRACE, env, "put mutex", lock);
+       lu_ref_del(&counters->ctc_locks_locked, "cll_guard", lock);
+       counters->ctc_nr_locks_locked--;
+       if (--lock->cll_depth == 0) {
+               lock->cll_guarder = NULL;
+               mutex_unlock(&lock->cll_guard);
+       }
 }
 EXPORT_SYMBOL(cl_lock_mutex_put);
 
@@ -773,7 +767,7 @@ EXPORT_SYMBOL(cl_lock_mutex_put);
  */
 int cl_lock_is_mutexed(struct cl_lock *lock)
 {
-        return lock->cll_guarder == cfs_current();
+       return lock->cll_guarder == current;
 }
 EXPORT_SYMBOL(cl_lock_is_mutexed);
 
@@ -807,8 +801,8 @@ static void cl_lock_cancel0(const struct lu_env *env, struct cl_lock *lock)
                 const struct cl_lock_slice *slice;
 
                 lock->cll_flags |= CLF_CANCELLED;
-                cfs_list_for_each_entry_reverse(slice, &lock->cll_layers,
-                                                cls_linkage) {
+               list_for_each_entry_reverse(slice, &lock->cll_layers,
+                                           cls_linkage) {
                         if (slice->cls_ops->clo_cancel != NULL)
                                 slice->cls_ops->clo_cancel(env, slice);
                 }
@@ -826,35 +820,42 @@ static void cl_lock_delete0(const struct lu_env *env, struct cl_lock *lock)
 
         ENTRY;
         if (lock->cll_state < CLS_FREEING) {
+               bool in_cache;
+
                 LASSERT(lock->cll_state != CLS_INTRANSIT);
                 cl_lock_state_set(env, lock, CLS_FREEING);
 
                 head = cl_object_header(lock->cll_descr.cld_obj);
 
-                cfs_spin_lock(&head->coh_lock_guard);
-                cfs_list_del_init(&lock->cll_linkage);
-
-                cfs_spin_unlock(&head->coh_lock_guard);
-                /*
-                 * From now on, no new references to this lock can be acquired
-                 * by cl_lock_lookup().
-                 */
-                cfs_list_for_each_entry_reverse(slice, &lock->cll_layers,
-                                                cls_linkage) {
-                        if (slice->cls_ops->clo_delete != NULL)
-                                slice->cls_ops->clo_delete(env, slice);
-                }
-                /*
-                 * From now on, no new references to this lock can be acquired
-                 * by layer-specific means (like a pointer from struct
-                 * ldlm_lock in osc, or a pointer from top-lock to sub-lock in
-                 * lov).
-                 *
-                 * Lock will be finally freed in cl_lock_put() when last of
-                 * existing references goes away.
-                 */
-        }
-        EXIT;
+               spin_lock(&head->coh_lock_guard);
+               in_cache = !list_empty(&lock->cll_linkage);
+               if (in_cache)
+                       list_del_init(&lock->cll_linkage);
+               spin_unlock(&head->coh_lock_guard);
+
+               if (in_cache) /* coh_locks cache holds a refcount. */
+                       cl_lock_put(env, lock);
+
+               /*
+                * From now on, no new references to this lock can be acquired
+                * by cl_lock_lookup().
+                */
+               list_for_each_entry_reverse(slice, &lock->cll_layers,
+                                           cls_linkage) {
+                       if (slice->cls_ops->clo_delete != NULL)
+                               slice->cls_ops->clo_delete(env, slice);
+               }
+               /*
+                * From now on, no new references to this lock can be acquired
+                * by layer-specific means (like a pointer from struct
+                * ldlm_lock in osc, or a pointer from top-lock to sub-lock in
+                * lov).
+                *
+                * Lock will be finally freed in cl_lock_put() when last of
+                * existing references goes away.
+                */
+       }
+       EXIT;
 }
 
 /**
@@ -897,8 +898,8 @@ static void cl_lock_used_mod(const struct lu_env *env, struct cl_lock *lock,
         }
 }
 
-static void cl_lock_hold_release(const struct lu_env *env, struct cl_lock *lock,
-                                 const char *scope, const void *source)
+void cl_lock_hold_release(const struct lu_env *env, struct cl_lock *lock,
+                         const char *scope, const void *source)
 {
         LINVRNT(cl_lock_is_mutexed(lock));
         LINVRNT(cl_lock_invariant(env, lock));
@@ -909,8 +910,10 @@ static void cl_lock_hold_release(const struct lu_env *env, struct cl_lock *lock,
         lu_ref_del(&lock->cll_holders, scope, source);
         cl_lock_hold_mod(env, lock, -1);
         if (lock->cll_holds == 0) {
-                if (lock->cll_descr.cld_mode == CLM_PHANTOM ||
-                    lock->cll_descr.cld_mode == CLM_GROUP)
+               CL_LOCK_ASSERT(lock->cll_state != CLS_HELD, env, lock);
+               if (lock->cll_descr.cld_mode == CLM_PHANTOM ||
+                   lock->cll_descr.cld_mode == CLM_GROUP ||
+                   lock->cll_state != CLS_CACHED)
                         /*
                          * If lock is still phantom or grouplock when user is
                          * done with it---destroy the lock.
@@ -928,7 +931,7 @@ static void cl_lock_hold_release(const struct lu_env *env, struct cl_lock *lock,
         }
         EXIT;
 }
-
+EXPORT_SYMBOL(cl_lock_hold_release);
 
 /**
  * Waits until lock state is changed.
@@ -951,49 +954,65 @@ static void cl_lock_hold_release(const struct lu_env *env, struct cl_lock *lock,
  */
 int cl_lock_state_wait(const struct lu_env *env, struct cl_lock *lock)
 {
-        cfs_waitlink_t waiter;
-        int result;
-
-        ENTRY;
-        LINVRNT(cl_lock_is_mutexed(lock));
-        LINVRNT(cl_lock_invariant(env, lock));
-        LASSERT(lock->cll_depth == 1);
-        LASSERT(lock->cll_state != CLS_FREEING); /* too late to wait */
-
-        cl_lock_trace(D_DLMTRACE, env, "state wait lock", lock);
-        result = lock->cll_error;
-        if (result == 0) {
-                cfs_waitlink_init(&waiter);
-                cfs_waitq_add(&lock->cll_wq, &waiter);
-                cfs_set_current_state(CFS_TASK_INTERRUPTIBLE);
-                cl_lock_mutex_put(env, lock);
-
-                LASSERT(cl_lock_nr_mutexed(env) == 0);
-                cfs_waitq_wait(&waiter, CFS_TASK_INTERRUPTIBLE);
-
-                cl_lock_mutex_get(env, lock);
-                cfs_set_current_state(CFS_TASK_RUNNING);
-                cfs_waitq_del(&lock->cll_wq, &waiter);
-                result = cfs_signal_pending() ? -EINTR : 0;
-        }
-        RETURN(result);
+       wait_queue_t waiter;
+       sigset_t blocked;
+       int result;
+
+       ENTRY;
+       LINVRNT(cl_lock_is_mutexed(lock));
+       LINVRNT(cl_lock_invariant(env, lock));
+       LASSERT(lock->cll_depth == 1);
+       LASSERT(lock->cll_state != CLS_FREEING); /* too late to wait */
+
+       cl_lock_trace(D_DLMTRACE, env, "state wait lock", lock);
+       result = lock->cll_error;
+       if (result == 0) {
+               /* To avoid being interrupted by the 'non-fatal' signals
+                * (SIGCHLD, for instance), we'd block them temporarily.
+                * LU-305 */
+               blocked = cfs_block_sigsinv(LUSTRE_FATAL_SIGS);
+
+               init_waitqueue_entry_current(&waiter);
+               add_wait_queue(&lock->cll_wq, &waiter);
+               set_current_state(TASK_INTERRUPTIBLE);
+               cl_lock_mutex_put(env, lock);
+
+               LASSERT(cl_lock_nr_mutexed(env) == 0);
+
+               /* Returning ERESTARTSYS instead of EINTR so syscalls
+                * can be restarted if signals are pending here */
+               result = -ERESTARTSYS;
+               if (likely(!OBD_FAIL_CHECK(OBD_FAIL_LOCK_STATE_WAIT_INTR))) {
+                       waitq_wait(&waiter, TASK_INTERRUPTIBLE);
+                       if (!cfs_signal_pending())
+                               result = 0;
+               }
+
+               cl_lock_mutex_get(env, lock);
+               set_current_state(TASK_RUNNING);
+               remove_wait_queue(&lock->cll_wq, &waiter);
+
+               /* Restore old blocked signals */
+               cfs_restore_sigs(blocked);
+       }
+       RETURN(result);
 }
 EXPORT_SYMBOL(cl_lock_state_wait);
 
 static void cl_lock_state_signal(const struct lu_env *env, struct cl_lock *lock,
-                                 enum cl_lock_state state)
+                                enum cl_lock_state state)
 {
-        const struct cl_lock_slice *slice;
+       const struct cl_lock_slice *slice;
 
-        ENTRY;
-        LINVRNT(cl_lock_is_mutexed(lock));
-        LINVRNT(cl_lock_invariant(env, lock));
+       ENTRY;
+       LINVRNT(cl_lock_is_mutexed(lock));
+       LINVRNT(cl_lock_invariant(env, lock));
 
-        cfs_list_for_each_entry(slice, &lock->cll_layers, cls_linkage)
-                if (slice->cls_ops->clo_state != NULL)
-                        slice->cls_ops->clo_state(env, slice, state);
-        cfs_waitq_broadcast(&lock->cll_wq);
-        EXIT;
+       list_for_each_entry(slice, &lock->cll_layers, cls_linkage)
+               if (slice->cls_ops->clo_state != NULL)
+                       slice->cls_ops->clo_state(env, slice, state);
+       wake_up_all(&lock->cll_wq);
+       EXIT;
 }
 
 /**
@@ -1025,8 +1044,6 @@ EXPORT_SYMBOL(cl_lock_signal);
 void cl_lock_state_set(const struct lu_env *env, struct cl_lock *lock,
                        enum cl_lock_state state)
 {
-        struct cl_site *site = cl_object_site(lock->cll_descr.cld_obj);
-
         ENTRY;
         LASSERT(lock->cll_state <= state ||
                 (lock->cll_state == CLS_CACHED &&
@@ -1037,8 +1054,8 @@ void cl_lock_state_set(const struct lu_env *env, struct cl_lock *lock,
                 lock->cll_state == CLS_INTRANSIT);
 
         if (lock->cll_state != state) {
-                cfs_atomic_dec(&site->cs_locks_state[lock->cll_state]);
-                cfs_atomic_inc(&site->cs_locks_state[state]);
+               CS_LOCKSTATE_DEC(lock->cll_descr.cld_obj, lock->cll_state);
+               CS_LOCKSTATE_INC(lock->cll_descr.cld_obj, state);
 
                 cl_lock_state_signal(env, lock, state);
                 lock->cll_state = state;
@@ -1049,29 +1066,29 @@ EXPORT_SYMBOL(cl_lock_state_set);
 
 static int cl_unuse_try_internal(const struct lu_env *env, struct cl_lock *lock)
 {
-        const struct cl_lock_slice *slice;
-        int result;
+       const struct cl_lock_slice *slice;
+       int result;
 
-        do {
-                result = 0;
+       do {
+               result = 0;
 
-                LINVRNT(cl_lock_is_mutexed(lock));
-                LINVRNT(cl_lock_invariant(env, lock));
-                LASSERT(lock->cll_state == CLS_INTRANSIT);
+               LINVRNT(cl_lock_is_mutexed(lock));
+               LINVRNT(cl_lock_invariant(env, lock));
+               LASSERT(lock->cll_state == CLS_INTRANSIT);
 
-                result = -ENOSYS;
-                cfs_list_for_each_entry_reverse(slice, &lock->cll_layers,
-                                                cls_linkage) {
-                        if (slice->cls_ops->clo_unuse != NULL) {
-                                result = slice->cls_ops->clo_unuse(env, slice);
-                                if (result != 0)
-                                        break;
-                        }
-                }
-                LASSERT(result != -ENOSYS);
-        } while (result == CLO_REPEAT);
+               result = -ENOSYS;
+               list_for_each_entry_reverse(slice, &lock->cll_layers,
+                                           cls_linkage) {
+                       if (slice->cls_ops->clo_unuse != NULL) {
+                               result = slice->cls_ops->clo_unuse(env, slice);
+                               if (result != 0)
+                                       break;
+                       }
+               }
+               LASSERT(result != -ENOSYS);
+       } while (result == CLO_REPEAT);
 
-        return result;
+       return result;
 }
 
 /**
@@ -1095,7 +1112,7 @@ int cl_use_try(const struct lu_env *env, struct cl_lock *lock, int atomic)
 
         result = -ENOSYS;
         state = cl_lock_intransit(env, lock);
-        cfs_list_for_each_entry(slice, &lock->cll_layers, cls_linkage) {
+       list_for_each_entry(slice, &lock->cll_layers, cls_linkage) {
                 if (slice->cls_ops->clo_use != NULL) {
                         result = slice->cls_ops->clo_use(env, slice);
                         if (result != 0)
@@ -1148,7 +1165,7 @@ static int cl_enqueue_kick(const struct lu_env *env,
 
         ENTRY;
         result = -ENOSYS;
-        cfs_list_for_each_entry(slice, &lock->cll_layers, cls_linkage) {
+       list_for_each_entry(slice, &lock->cll_layers, cls_linkage) {
                 if (slice->cls_ops->clo_enqueue != NULL) {
                         result = slice->cls_ops->clo_enqueue(env,
                                                              slice, io, flags);
@@ -1181,12 +1198,12 @@ int cl_enqueue_try(const struct lu_env *env, struct cl_lock *lock,
         ENTRY;
         cl_lock_trace(D_DLMTRACE, env, "enqueue lock", lock);
         do {
-                result = 0;
-
                 LINVRNT(cl_lock_is_mutexed(lock));
 
-                if (lock->cll_error != 0)
+               result = lock->cll_error;
+               if (result != 0)
                         break;
+
                 switch (lock->cll_state) {
                 case CLS_NEW:
                         cl_lock_state_set(env, lock, CLS_QUEUING);
@@ -1194,7 +1211,9 @@ int cl_enqueue_try(const struct lu_env *env, struct cl_lock *lock,
                 case CLS_QUEUING:
                         /* kick layers. */
                         result = cl_enqueue_kick(env, lock, io, flags);
-                        if (result == 0)
+                       /* For AGL case, the cl_lock::cll_state may
+                        * become CLS_HELD already. */
+                       if (result == 0 && lock->cll_state == CLS_QUEUING)
                                 cl_lock_state_set(env, lock, CLS_ENQUEUED);
                         break;
                 case CLS_INTRANSIT:
@@ -1219,12 +1238,56 @@ int cl_enqueue_try(const struct lu_env *env, struct cl_lock *lock,
                         LBUG();
                 }
         } while (result == CLO_REPEAT);
-        if (result < 0)
-                cl_lock_error(env, lock, result);
-        RETURN(result ?: lock->cll_error);
+       RETURN(result);
 }
 EXPORT_SYMBOL(cl_enqueue_try);
 
+/**
+ * Cancel the conflicting lock found during previous enqueue.
+ *
+ * \retval 0 conflicting lock has been canceled.
+ * \retval -ve error code.
+ */
+int cl_lock_enqueue_wait(const struct lu_env *env,
+                         struct cl_lock *lock,
+                         int keep_mutex)
+{
+        struct cl_lock  *conflict;
+        int              rc = 0;
+        ENTRY;
+
+        LASSERT(cl_lock_is_mutexed(lock));
+        LASSERT(lock->cll_state == CLS_QUEUING);
+        LASSERT(lock->cll_conflict != NULL);
+
+        conflict = lock->cll_conflict;
+        lock->cll_conflict = NULL;
+
+        cl_lock_mutex_put(env, lock);
+        LASSERT(cl_lock_nr_mutexed(env) == 0);
+
+        cl_lock_mutex_get(env, conflict);
+       cl_lock_trace(D_DLMTRACE, env, "enqueue wait", conflict);
+        cl_lock_cancel(env, conflict);
+        cl_lock_delete(env, conflict);
+
+        while (conflict->cll_state != CLS_FREEING) {
+                rc = cl_lock_state_wait(env, conflict);
+                if (rc != 0)
+                        break;
+        }
+        cl_lock_mutex_put(env, conflict);
+        lu_ref_del(&conflict->cll_reference, "cancel-wait", lock);
+        cl_lock_put(env, conflict);
+
+        if (keep_mutex)
+                cl_lock_mutex_get(env, lock);
+
+        LASSERT(rc <= 0);
+        RETURN(rc);
+}
+EXPORT_SYMBOL(cl_lock_enqueue_wait);
+
 static int cl_enqueue_locked(const struct lu_env *env, struct cl_lock *lock,
                              struct cl_io *io, __u32 enqflags)
 {
@@ -1240,17 +1303,19 @@ static int cl_enqueue_locked(const struct lu_env *env, struct cl_lock *lock,
         do {
                 result = cl_enqueue_try(env, lock, io, enqflags);
                 if (result == CLO_WAIT) {
-                        result = cl_lock_state_wait(env, lock);
+                        if (lock->cll_conflict != NULL)
+                                result = cl_lock_enqueue_wait(env, lock, 1);
+                        else
+                                result = cl_lock_state_wait(env, lock);
                         if (result == 0)
                                 continue;
                 }
                 break;
         } while (1);
-        if (result != 0) {
-                cl_lock_user_del(env, lock);
-                cl_lock_error(env, lock, result);
-        }
-        LASSERT(ergo(result == 0, lock->cll_state == CLS_ENQUEUED ||
+       if (result != 0)
+               cl_unuse_try(env, lock);
+        LASSERT(ergo(result == 0 && !(enqflags & CEF_AGL),
+                     lock->cll_state == CLS_ENQUEUED ||
                      lock->cll_state == CLS_HELD));
         RETURN(result);
 }
@@ -1286,13 +1351,11 @@ EXPORT_SYMBOL(cl_enqueue);
 /**
  * Tries to unlock a lock.
  *
- * This function is called repeatedly by cl_unuse() until either lock is
- * unlocked, or error occurs.
- * cl_unuse_try is a one-shot operation, so it must NOT return CLO_WAIT.
- *
- * \pre  lock->cll_state == CLS_HELD
+ * This function is called to release underlying resource:
+ * 1. for top lock, the resource is sublocks it held;
+ * 2. for sublock, the resource is the reference to dlmlock.
  *
- * \post ergo(result == 0, lock->cll_state == CLS_CACHED)
+ * cl_unuse_try is a one-shot operation, so it must NOT return CLO_WAIT.
  *
  * \see cl_unuse() cl_lock_operations::clo_unuse()
  * \see cl_lock_state::CLS_CACHED
@@ -1305,12 +1368,18 @@ int cl_unuse_try(const struct lu_env *env, struct cl_lock *lock)
         ENTRY;
         cl_lock_trace(D_DLMTRACE, env, "unuse lock", lock);
 
-        LASSERT(lock->cll_state == CLS_HELD || lock->cll_state == CLS_ENQUEUED);
         if (lock->cll_users > 1) {
                 cl_lock_user_del(env, lock);
                 RETURN(0);
         }
 
+       /* Only if the lock is in CLS_HELD or CLS_ENQUEUED state, it can hold
+        * underlying resources. */
+       if (!(lock->cll_state == CLS_HELD || lock->cll_state == CLS_ENQUEUED)) {
+               cl_lock_user_del(env, lock);
+               RETURN(0);
+       }
+
         /*
          * New lock users (->cll_users) are not protecting unlocking
          * from proceeding. From this point, lock eventually reaches
@@ -1351,13 +1420,10 @@ int cl_unuse_try(const struct lu_env *env, struct cl_lock *lock)
                 result = 0;
         } else {
                 CERROR("result = %d, this is unlikely!\n", result);
+               state = CLS_NEW;
                 cl_lock_extransit(env, lock, state);
         }
-
-        result = result ?: lock->cll_error;
-        if (result < 0)
-                cl_lock_error(env, lock, result);
-        RETURN(result);
+       RETURN(result ?: lock->cll_error);
 }
 EXPORT_SYMBOL(cl_unuse_try);
 
@@ -1407,14 +1473,16 @@ int cl_wait_try(const struct lu_env *env, struct cl_lock *lock)
         do {
                 LINVRNT(cl_lock_is_mutexed(lock));
                 LINVRNT(cl_lock_invariant(env, lock));
-                LASSERT(lock->cll_state == CLS_ENQUEUED ||
-                        lock->cll_state == CLS_HELD ||
-                        lock->cll_state == CLS_INTRANSIT);
+               LASSERTF(lock->cll_state == CLS_QUEUING ||
+                        lock->cll_state == CLS_ENQUEUED ||
+                        lock->cll_state == CLS_HELD ||
+                        lock->cll_state == CLS_INTRANSIT,
+                        "lock state: %d\n", lock->cll_state);
                 LASSERT(lock->cll_users > 0);
                 LASSERT(lock->cll_holds > 0);
 
-                result = 0;
-                if (lock->cll_error != 0)
+               result = lock->cll_error;
+               if (result != 0)
                         break;
 
                 if (cl_lock_is_intransit(lock)) {
@@ -1427,7 +1495,7 @@ int cl_wait_try(const struct lu_env *env, struct cl_lock *lock)
                         break;
 
                 result = -ENOSYS;
-                cfs_list_for_each_entry(slice, &lock->cll_layers, cls_linkage) {
+               list_for_each_entry(slice, &lock->cll_layers, cls_linkage) {
                         if (slice->cls_ops->clo_wait != NULL) {
                                 result = slice->cls_ops->clo_wait(env, slice);
                                 if (result != 0)
@@ -1440,7 +1508,7 @@ int cl_wait_try(const struct lu_env *env, struct cl_lock *lock)
                         cl_lock_state_set(env, lock, CLS_HELD);
                 }
         } while (result == CLO_REPEAT);
-        RETURN(result ?: lock->cll_error);
+       RETURN(result);
 }
 EXPORT_SYMBOL(cl_wait_try);
 
@@ -1464,7 +1532,6 @@ int cl_wait(const struct lu_env *env, struct cl_lock *lock)
         LASSERTF(lock->cll_state == CLS_ENQUEUED || lock->cll_state == CLS_HELD,
                  "Wrong state %d \n", lock->cll_state);
         LASSERT(lock->cll_holds > 0);
-        cl_lock_trace(D_DLMTRACE, env, "wait lock", lock);
 
         do {
                 result = cl_wait_try(env, lock);
@@ -1476,10 +1543,10 @@ int cl_wait(const struct lu_env *env, struct cl_lock *lock)
                 break;
         } while (1);
         if (result < 0) {
-                cl_lock_user_del(env, lock);
-                cl_lock_error(env, lock, result);
+               cl_unuse_try(env, lock);
                 cl_lock_lockdep_release(env, lock);
         }
+        cl_lock_trace(D_DLMTRACE, env, "wait lock", lock);
         cl_lock_mutex_put(env, lock);
         LASSERT(ergo(result == 0, lock->cll_state == CLS_HELD));
         RETURN(result);
@@ -1501,7 +1568,7 @@ unsigned long cl_lock_weigh(const struct lu_env *env, struct cl_lock *lock)
         LINVRNT(cl_lock_invariant(env, lock));
 
         pound = 0;
-        cfs_list_for_each_entry_reverse(slice, &lock->cll_layers, cls_linkage) {
+       list_for_each_entry_reverse(slice, &lock->cll_layers, cls_linkage) {
                 if (slice->cls_ops->clo_weigh != NULL) {
                         ounce = slice->cls_ops->clo_weigh(env, slice);
                         pound += ounce;
@@ -1538,7 +1605,7 @@ int cl_lock_modify(const struct lu_env *env, struct cl_lock *lock,
         LINVRNT(cl_lock_is_mutexed(lock));
         LINVRNT(cl_lock_invariant(env, lock));
 
-        cfs_list_for_each_entry_reverse(slice, &lock->cll_layers, cls_linkage) {
+       list_for_each_entry_reverse(slice, &lock->cll_layers, cls_linkage) {
                 if (slice->cls_ops->clo_modify != NULL) {
                         result = slice->cls_ops->clo_modify(env, slice, desc);
                         if (result != 0)
@@ -1552,10 +1619,10 @@ int cl_lock_modify(const struct lu_env *env, struct cl_lock *lock,
          * now. If locks were indexed according to their extent and/or mode,
          * that index would have to be updated here.
          */
-        cfs_spin_lock(&hdr->coh_lock_guard);
-        lock->cll_descr = *desc;
-        cfs_spin_unlock(&hdr->coh_lock_guard);
-        RETURN(0);
+       spin_lock(&hdr->coh_lock_guard);
+       lock->cll_descr = *desc;
+       spin_unlock(&hdr->coh_lock_guard);
+       RETURN(0);
 }
 EXPORT_SYMBOL(cl_lock_modify);
 
@@ -1571,7 +1638,7 @@ void cl_lock_closure_init(const struct lu_env *env,
         LINVRNT(cl_lock_is_mutexed(origin));
         LINVRNT(cl_lock_invariant(env, origin));
 
-        CFS_INIT_LIST_HEAD(&closure->clc_list);
+       INIT_LIST_HEAD(&closure->clc_list);
         closure->clc_origin = origin;
         closure->clc_wait   = wait;
         closure->clc_nr     = 0;
@@ -1600,7 +1667,7 @@ int cl_lock_closure_build(const struct lu_env *env, struct cl_lock *lock,
 
         result = cl_lock_enclosure(env, lock, closure);
         if (result == 0) {
-                cfs_list_for_each_entry(slice, &lock->cll_layers, cls_linkage) {
+               list_for_each_entry(slice, &lock->cll_layers, cls_linkage) {
                         if (slice->cls_ops->clo_closure != NULL) {
                                 result = slice->cls_ops->clo_closure(env, slice,
                                                                      closure);
@@ -1633,10 +1700,10 @@ int cl_lock_enclosure(const struct lu_env *env, struct cl_lock *lock,
                  * If lock->cll_inclosure is not empty, lock is already in
                  * this closure.
                  */
-                if (cfs_list_empty(&lock->cll_inclosure)) {
+               if (list_empty(&lock->cll_inclosure)) {
                         cl_lock_get_trust(lock);
                         lu_ref_add(&lock->cll_reference, "closure", closure);
-                        cfs_list_add(&lock->cll_inclosure, &closure->clc_list);
+                       list_add(&lock->cll_inclosure, &closure->clc_list);
                         closure->clc_nr++;
                 } else
                         cl_lock_mutex_put(env, lock);
@@ -1666,19 +1733,19 @@ EXPORT_SYMBOL(cl_lock_enclosure);
 void cl_lock_disclosure(const struct lu_env *env,
                         struct cl_lock_closure *closure)
 {
-        struct cl_lock *scan;
-        struct cl_lock *temp;
-
-        cl_lock_trace(D_DLMTRACE, env, "disclosure lock", closure->clc_origin);
-        cfs_list_for_each_entry_safe(scan, temp, &closure->clc_list,
-                                     cll_inclosure){
-                cfs_list_del_init(&scan->cll_inclosure);
-                cl_lock_mutex_put(env, scan);
-                lu_ref_del(&scan->cll_reference, "closure", closure);
-                cl_lock_put(env, scan);
-                closure->clc_nr--;
-        }
-        LASSERT(closure->clc_nr == 0);
+       struct cl_lock *scan;
+       struct cl_lock *temp;
+
+       cl_lock_trace(D_DLMTRACE, env, "disclosure lock", closure->clc_origin);
+       list_for_each_entry_safe(scan, temp, &closure->clc_list,
+                                cll_inclosure){
+               list_del_init(&scan->cll_inclosure);
+               cl_lock_mutex_put(env, scan);
+               lu_ref_del(&scan->cll_reference, "closure", closure);
+               cl_lock_put(env, scan);
+               closure->clc_nr--;
+       }
+       LASSERT(closure->clc_nr == 0);
 }
 EXPORT_SYMBOL(cl_lock_disclosure);
 
@@ -1686,7 +1753,7 @@ EXPORT_SYMBOL(cl_lock_disclosure);
 void cl_lock_closure_fini(struct cl_lock_closure *closure)
 {
         LASSERT(closure->clc_nr == 0);
-        LASSERT(cfs_list_empty(&closure->clc_list));
+       LASSERT(list_empty(&closure->clc_list));
 }
 EXPORT_SYMBOL(cl_lock_closure_fini);
 
@@ -1744,8 +1811,8 @@ void cl_lock_error(const struct lu_env *env, struct cl_lock *lock, int error)
         LINVRNT(cl_lock_invariant(env, lock));
 
         ENTRY;
-        cl_lock_trace(D_DLMTRACE, env, "set lock error", lock);
         if (lock->cll_error == 0 && error != 0) {
+               cl_lock_trace(D_DLMTRACE, env, "set lock error", lock);
                 lock->cll_error = error;
                 cl_lock_signal(env, lock);
                 cl_lock_cancel(env, lock);
@@ -1782,12 +1849,13 @@ void cl_lock_cancel(const struct lu_env *env, struct cl_lock *lock)
 EXPORT_SYMBOL(cl_lock_cancel);
 
 /**
- * Finds an existing lock covering given page and optionally different from a
+ * Finds an existing lock covering given index and optionally different from a
  * given \a except lock.
  */
-struct cl_lock *cl_lock_at_page(const struct lu_env *env, struct cl_object *obj,
-                                struct cl_page *page, struct cl_lock *except,
-                                int pending, int canceld)
+struct cl_lock *cl_lock_at_pgoff(const struct lu_env *env,
+                                struct cl_object *obj, pgoff_t index,
+                                struct cl_lock *except,
+                                int pending, int canceld)
 {
         struct cl_object_header *head;
         struct cl_lock          *scan;
@@ -1802,13 +1870,13 @@ struct cl_lock *cl_lock_at_page(const struct lu_env *env, struct cl_object *obj,
 
         need->cld_mode = CLM_READ; /* CLM_READ matches both READ & WRITE, but
                                     * not PHANTOM */
-        need->cld_start = need->cld_end = page->cp_index;
+       need->cld_start = need->cld_end = index;
         need->cld_enq_flags = 0;
 
-        cfs_spin_lock(&head->coh_lock_guard);
+       spin_lock(&head->coh_lock_guard);
         /* It is fine to match any group lock since there could be only one
          * with a uniq gid and it conflicts with all other lock modes too */
-        cfs_list_for_each_entry(scan, &head->coh_locks, cll_linkage) {
+       list_for_each_entry(scan, &head->coh_locks, cll_linkage) {
                 if (scan != except &&
                     (scan->cll_descr.cld_mode == CLM_GROUP ||
                     cl_lock_ext_match(&scan->cll_descr, need)) &&
@@ -1828,151 +1896,10 @@ struct cl_lock *cl_lock_at_page(const struct lu_env *env, struct cl_object *obj,
                         break;
                 }
         }
-        cfs_spin_unlock(&head->coh_lock_guard);
-        RETURN(lock);
-}
-EXPORT_SYMBOL(cl_lock_at_page);
-
-/**
- * Returns a list of pages protected (only) by a given lock.
- *
- * Scans an extent of page radix tree, corresponding to the \a lock and queues
- * all pages that are not protected by locks other than \a lock into \a queue.
- */
-void cl_lock_page_list_fixup(const struct lu_env *env,
-                             struct cl_io *io, struct cl_lock *lock,
-                             struct cl_page_list *queue)
-{
-        struct cl_page        *page;
-        struct cl_page        *temp;
-        struct cl_page_list   *plist = &cl_env_info(env)->clt_list;
-
-        LINVRNT(cl_lock_invariant(env, lock));
-        ENTRY;
-
-        /* Now, we have a list of cl_pages under the \a lock, we need
-         * to check if some of pages are covered by other ldlm lock.
-         * If this is the case, they aren't needed to be written out this time.
-         *
-         * For example, we have A:[0,200] & B:[100,300] PW locks on client, now
-         * the latter is to be canceled, this means other client is
-         * reading/writing [200,300] since A won't canceled. Actually
-         * we just need to write the pages covered by [200,300]. This is safe,
-         * since [100,200] is also protected lock A.
-         */
-
-        cl_page_list_init(plist);
-        cl_page_list_for_each_safe(page, temp, queue) {
-                pgoff_t                idx = page->cp_index;
-                struct cl_lock        *found;
-                struct cl_lock_descr  *descr;
-
-                /* The algorithm counts on the index-ascending page index. */
-                LASSERT(ergo(&temp->cp_batch != &queue->pl_pages,
-                        page->cp_index < temp->cp_index));
-
-                found = cl_lock_at_page(env, lock->cll_descr.cld_obj,
-                                        page, lock, 0, 0);
-                if (found == NULL)
-                        continue;
-
-                descr = &found->cll_descr;
-                cfs_list_for_each_entry_safe_from(page, temp, &queue->pl_pages,
-                                                  cp_batch) {
-                        idx = page->cp_index;
-                        if (descr->cld_start > idx || descr->cld_end < idx)
-                                break;
-                        cl_page_list_move(plist, queue, page);
-                }
-                cl_lock_put(env, found);
-        }
-
-        /* The pages in plist are covered by other locks, don't handle them
-         * this time.
-         */
-        if (io != NULL)
-                cl_page_list_disown(env, io, plist);
-        cl_page_list_fini(env, plist);
-        EXIT;
-}
-EXPORT_SYMBOL(cl_lock_page_list_fixup);
-
-/**
- * Invalidate pages protected by the given lock, sending them out to the
- * server first, if necessary.
- *
- * This function does the following:
- *
- *     - collects a list of pages to be invalidated,
- *
- *     - unmaps them from the user virtual memory,
- *
- *     - sends dirty pages to the server,
- *
- *     - waits for transfer completion,
- *
- *     - discards pages, and throws them out of memory.
- *
- * If \a discard is set, pages are discarded without sending them to the
- * server.
- *
- * If error happens on any step, the process continues anyway (the reasoning
- * behind this being that lock cancellation cannot be delayed indefinitely).
- */
-int cl_lock_page_out(const struct lu_env *env, struct cl_lock *lock,
-                     int discard)
-{
-        struct cl_thread_info *info  = cl_env_info(env);
-        struct cl_io          *io    = &info->clt_io;
-        struct cl_2queue      *queue = &info->clt_queue;
-        struct cl_lock_descr  *descr = &lock->cll_descr;
-        long page_count;
-        int nonblock = 1, resched;
-        int result;
-
-        LINVRNT(cl_lock_invariant(env, lock));
-        ENTRY;
-
-        io->ci_obj = cl_object_top(descr->cld_obj);
-        result = cl_io_init(env, io, CIT_MISC, io->ci_obj);
-        if (result != 0)
-                GOTO(out, result);
-
-        do {
-                cl_2queue_init(queue);
-                cl_page_gang_lookup(env, descr->cld_obj, io, descr->cld_start,
-                                    descr->cld_end, &queue->c2_qin, nonblock,
-                                    &resched);
-                page_count = queue->c2_qin.pl_nr;
-                if (page_count > 0) {
-                        result = cl_page_list_unmap(env, io, &queue->c2_qin);
-                        if (!discard) {
-                                long timeout = 600; /* 10 minutes. */
-                                /* for debug purpose, if this request can't be
-                                 * finished in 10 minutes, we hope it can
-                                 * notify us.
-                                 */
-                                result = cl_io_submit_sync(env, io, CRT_WRITE,
-                                                           queue, CRP_CANCEL,
-                                                           timeout);
-                                if (result)
-                                        CWARN("Writing %lu pages error: %d\n",
-                                              page_count, result);
-                        }
-                        cl_lock_page_list_fixup(env, io, lock, &queue->c2_qout);
-                        cl_2queue_discard(env, io, queue);
-                        cl_2queue_disown(env, io, queue);
-                }
-                cl_2queue_fini(env, queue);
-
-                if (resched)
-                        cfs_cond_resched();
-        } while (resched || nonblock--);
-out:
-        cl_io_fini(env, io);
-        RETURN(result);
+       spin_unlock(&head->coh_lock_guard);
+       RETURN(lock);
 }
-EXPORT_SYMBOL(cl_lock_page_out);
+EXPORT_SYMBOL(cl_lock_at_pgoff);
 
 /**
  * Eliminate all locks for a given object.
@@ -1984,57 +1911,48 @@ EXPORT_SYMBOL(cl_lock_page_out);
  */
 void cl_locks_prune(const struct lu_env *env, struct cl_object *obj, int cancel)
 {
-        struct cl_object_header *head;
-        struct cl_lock          *lock;
-
-        ENTRY;
-        head = cl_object_header(obj);
-        /*
-         * If locks are destroyed without cancellation, all pages must be
-         * already destroyed (as otherwise they will be left unprotected).
-         */
-        LASSERT(ergo(!cancel,
-                     head->coh_tree.rnode == NULL && head->coh_pages == 0));
-
-        cfs_spin_lock(&head->coh_lock_guard);
-        while (!cfs_list_empty(&head->coh_locks)) {
-                lock = container_of(head->coh_locks.next,
-                                    struct cl_lock, cll_linkage);
-                cl_lock_get_trust(lock);
-                cfs_spin_unlock(&head->coh_lock_guard);
-                lu_ref_add(&lock->cll_reference, "prune", cfs_current());
-                cl_lock_mutex_get(env, lock);
-                if (lock->cll_state < CLS_FREEING) {
-                        LASSERT(lock->cll_holds == 0);
-                        LASSERT(lock->cll_users == 0);
-                        if (cancel)
-                                cl_lock_cancel(env, lock);
-                        cl_lock_delete(env, lock);
-                }
-                cl_lock_mutex_put(env, lock);
-                lu_ref_del(&lock->cll_reference, "prune", cfs_current());
-                cl_lock_put(env, lock);
-                cfs_spin_lock(&head->coh_lock_guard);
-        }
-        cfs_spin_unlock(&head->coh_lock_guard);
-        EXIT;
+       struct cl_object_header *head;
+       struct cl_lock          *lock;
+
+       ENTRY;
+       head = cl_object_header(obj);
+
+       spin_lock(&head->coh_lock_guard);
+       while (!list_empty(&head->coh_locks)) {
+               lock = container_of(head->coh_locks.next,
+                                   struct cl_lock, cll_linkage);
+               cl_lock_get_trust(lock);
+               spin_unlock(&head->coh_lock_guard);
+               lu_ref_add(&lock->cll_reference, "prune", current);
+
+again:
+               cl_lock_mutex_get(env, lock);
+               if (lock->cll_state < CLS_FREEING) {
+                       LASSERT(lock->cll_users <= 1);
+                       if (unlikely(lock->cll_users == 1)) {
+                               struct l_wait_info lwi = { 0 };
+
+                               cl_lock_mutex_put(env, lock);
+                               l_wait_event(lock->cll_wq,
+                                            lock->cll_users == 0,
+                                            &lwi);
+                               goto again;
+                       }
+
+                       if (cancel)
+                               cl_lock_cancel(env, lock);
+                       cl_lock_delete(env, lock);
+               }
+               cl_lock_mutex_put(env, lock);
+               lu_ref_del(&lock->cll_reference, "prune", current);
+               cl_lock_put(env, lock);
+               spin_lock(&head->coh_lock_guard);
+       }
+       spin_unlock(&head->coh_lock_guard);
+       EXIT;
 }
 EXPORT_SYMBOL(cl_locks_prune);
 
-/**
- * Returns true if \a addr is an address of an allocated cl_lock. Used in
- * assertions. This check is optimistically imprecise, i.e., it occasionally
- * returns true for the incorrect addresses, but if it returns false, then the
- * address is guaranteed to be incorrect. (Should be named cl_lockp().)
- *
- * \see cl_is_page()
- */
-int cl_is_lock(const void *addr)
-{
-        return cfs_mem_is_in_cache(addr, cl_lock_kmem);
-}
-EXPORT_SYMBOL(cl_is_lock);
-
 static struct cl_lock *cl_lock_hold_mutex(const struct lu_env *env,
                                           const struct cl_io *io,
                                           const struct cl_lock_descr *need,
@@ -2099,25 +2017,34 @@ struct cl_lock *cl_lock_request(const struct lu_env *env, struct cl_io *io,
         ENTRY;
         do {
                 lock = cl_lock_hold_mutex(env, io, need, scope, source);
-                if (!IS_ERR(lock)) {
-                        rc = cl_enqueue_locked(env, lock, io, enqflags);
-                        if (rc == 0) {
-                                if (cl_lock_fits_into(env, lock, need, io)) {
+                if (IS_ERR(lock))
+                        break;
+
+                rc = cl_enqueue_locked(env, lock, io, enqflags);
+                if (rc == 0) {
+                        if (cl_lock_fits_into(env, lock, need, io)) {
+                                if (!(enqflags & CEF_AGL)) {
                                         cl_lock_mutex_put(env, lock);
-                                        cl_lock_lockdep_acquire(env,
-                                                                lock, enqflags);
+                                        cl_lock_lockdep_acquire(env, lock,
+                                                                enqflags);
                                         break;
                                 }
-                                cl_unuse_locked(env, lock);
+                                rc = 1;
                         }
-                        cl_lock_trace(D_DLMTRACE, env, "enqueue failed", lock);
-                        cl_lock_hold_release(env, lock, scope, source);
-                        cl_lock_mutex_put(env, lock);
-                        lu_ref_del(&lock->cll_reference, scope, source);
-                        cl_lock_put(env, lock);
+                        cl_unuse_locked(env, lock);
+                }
+                cl_lock_trace(D_DLMTRACE, env,
+                              rc <= 0 ? "enqueue failed" : "agl succeed", lock);
+                cl_lock_hold_release(env, lock, scope, source);
+                cl_lock_mutex_put(env, lock);
+                lu_ref_del(&lock->cll_reference, scope, source);
+                cl_lock_put(env, lock);
+                if (rc > 0) {
+                        LASSERT(enqflags & CEF_AGL);
+                        lock = NULL;
+                } else if (rc != 0) {
                         lock = ERR_PTR(rc);
-                } else
-                        rc = PTR_ERR(lock);
+                }
         } while (rc == 0);
         RETURN(lock);
 }
@@ -2134,8 +2061,8 @@ void cl_lock_hold_add(const struct lu_env *env, struct cl_lock *lock,
         LASSERT(lock->cll_state != CLS_FREEING);
 
         ENTRY;
-        cl_lock_hold_mod(env, lock, +1);
         cl_lock_get(lock);
+       cl_lock_hold_mod(env, lock, +1);
         lu_ref_add(&lock->cll_holders, scope, source);
         lu_ref_add(&lock->cll_reference, scope, source);
         EXIT;
@@ -2187,15 +2114,17 @@ void cl_lock_user_add(const struct lu_env *env, struct cl_lock *lock)
 }
 EXPORT_SYMBOL(cl_lock_user_add);
 
-int cl_lock_user_del(const struct lu_env *env, struct cl_lock *lock)
+void cl_lock_user_del(const struct lu_env *env, struct cl_lock *lock)
 {
-        LINVRNT(cl_lock_is_mutexed(lock));
-        LINVRNT(cl_lock_invariant(env, lock));
-        LASSERT(lock->cll_users > 0);
+       LINVRNT(cl_lock_is_mutexed(lock));
+       LINVRNT(cl_lock_invariant(env, lock));
+       LASSERT(lock->cll_users > 0);
 
-        ENTRY;
-        cl_lock_used_mod(env, lock, -1);
-        RETURN(lock->cll_users == 0);
+       ENTRY;
+       cl_lock_used_mod(env, lock, -1);
+       if (lock->cll_users == 0)
+               wake_up_all(&lock->cll_wq);
+       EXIT;
 }
 EXPORT_SYMBOL(cl_lock_user_del);
 
@@ -2207,10 +2136,8 @@ const char *cl_lock_mode_name(const enum cl_lock_mode mode)
                 [CLM_WRITE]   = "W",
                 [CLM_GROUP]   = "G"
         };
-        if (0 <= mode && mode < ARRAY_SIZE(names))
-                return names[mode];
-        else
-                return "U";
+       CLASSERT(CLM_MAX == ARRAY_SIZE(names));
+       return names[mode];
 }
 EXPORT_SYMBOL(cl_lock_mode_name);
 
@@ -2236,13 +2163,13 @@ void cl_lock_print(const struct lu_env *env, void *cookie,
 {
         const struct cl_lock_slice *slice;
         (*printer)(env, cookie, "lock@%p[%d %d %d %d %d %08lx] ",
-                   lock, cfs_atomic_read(&lock->cll_ref),
+                  lock, atomic_read(&lock->cll_ref),
                    lock->cll_state, lock->cll_error, lock->cll_holds,
                    lock->cll_users, lock->cll_flags);
         cl_lock_descr_print(env, cookie, printer, &lock->cll_descr);
         (*printer)(env, cookie, " {\n");
 
-        cfs_list_for_each_entry(slice, &lock->cll_layers, cls_linkage) {
+       list_for_each_entry(slice, &lock->cll_layers, cls_linkage) {
                 (*printer)(env, cookie, "    %s@%p: ",
                            slice->cls_obj->co_lu.lo_dev->ld_type->ldt_name,
                            slice);