Whamcloud - gitweb
LU-2901 ldlm: fix resource/fid check, use DLDLMRES
[fs/lustre-release.git] / lustre / mgc / mgc_request.c
index 83bd75e..cd77628 100644 (file)
@@ -480,12 +480,9 @@ static void do_requeue(struct config_llog_data *cld)
 
 static int mgc_requeue_thread(void *data)
 {
-        char name[] = "ll_cfg_requeue";
         int rc = 0;
         ENTRY;
 
-        cfs_daemonize(name);
-
         CDEBUG(D_MGC, "Starting requeue thread\n");
 
         /* Keep trying failed locks periodically */
@@ -776,20 +773,20 @@ static int mgc_setup(struct obd_device *obd, struct lustre_cfg *lcfg)
         sptlrpc_lprocfs_cliobd_attach(obd);
 
         if (cfs_atomic_inc_return(&mgc_count) == 1) {
-                rq_state = 0;
-                cfs_waitq_init(&rq_waitq);
-
-                /* start requeue thread */
-                rc = cfs_create_thread(mgc_requeue_thread, NULL,
-                                       CFS_DAEMON_FLAGS);
-                if (rc < 0) {
-                        CERROR("%s: Cannot start requeue thread (%d),"
-                               "no more log updates!\n",
-                               obd->obd_name, rc);
-                        GOTO(err_cleanup, rc);
-                }
-                /* rc is the pid of mgc_requeue_thread. */
-                rc = 0;
+               rq_state = 0;
+               cfs_waitq_init(&rq_waitq);
+
+               /* start requeue thread */
+               rc = PTR_ERR(kthread_run(mgc_requeue_thread, NULL,
+                                            "ll_cfg_requeue"));
+               if (IS_ERR_VALUE(rc)) {
+                       CERROR("%s: Cannot start requeue thread (%d),"
+                              "no more log updates!\n",
+                              obd->obd_name, rc);
+                       GOTO(err_cleanup, rc);
+               }
+               /* rc is the task_struct pointer of mgc_requeue_thread. */
+               rc = 0;
         }
 
         RETURN(rc);
@@ -816,14 +813,14 @@ static int mgc_blocking_ast(struct ldlm_lock *lock, struct ldlm_lock_desc *desc,
                 LDLM_DEBUG(lock, "MGC blocking CB");
                 ldlm_lock2handle(lock, &lockh);
                rc = ldlm_cli_cancel(&lockh, LCF_ASYNC);
-                break;
-        case LDLM_CB_CANCELING:
-                /* We've given up the lock, prepare ourselves to update. */
-                LDLM_DEBUG(lock, "MGC cancel CB");
+               break;
+       case LDLM_CB_CANCELING:
+               /* We've given up the lock, prepare ourselves to update. */
+               LDLM_DEBUG(lock, "MGC cancel CB");
 
-                CDEBUG(D_MGC, "Lock res "LPX64" (%.8s)\n",
-                       lock->l_resource->lr_name.name[0],
-                       (char *)&lock->l_resource->lr_name.name[0]);
+               CDEBUG(D_MGC, "Lock res "DLDLMRES" (%.8s)\n",
+                      PLDLMRES(lock->l_resource),
+                      (char *)&lock->l_resource->lr_name.name[0]);
 
                 if (!cld) {
                         CDEBUG(D_INFO, "missing data, won't requeue\n");
@@ -909,13 +906,17 @@ static int mgc_enqueue(struct obd_export *exp, struct lov_stripe_md *lsm,
                       void *data, __u32 lvb_len, void *lvb_swabber,
                       struct lustre_handle *lockh)
 {
-        struct config_llog_data *cld = (struct config_llog_data *)data;
-        struct ldlm_enqueue_info einfo = { type, mode, mgc_blocking_ast,
-                         ldlm_completion_ast, NULL, NULL, NULL };
-        struct ptlrpc_request *req;
-        int short_limit = cld_is_sptlrpc(cld);
-        int rc;
-        ENTRY;
+       struct config_llog_data *cld = (struct config_llog_data *)data;
+       struct ldlm_enqueue_info einfo = {
+               .ei_type        = type,
+               .ei_mode        = mode,
+               .ei_cb_bl       = mgc_blocking_ast,
+               .ei_cb_cp       = ldlm_completion_ast,
+       };
+       struct ptlrpc_request *req;
+       int short_limit = cld_is_sptlrpc(cld);
+       int rc;
+       ENTRY;
 
         CDEBUG(D_MGC, "Enqueue for %s (res "LPX64")\n", cld->cld_logname,
                cld->cld_resid.name[0]);
@@ -1233,7 +1234,7 @@ static int mgc_llog_finish(struct obd_device *obd, int count)
 }
 
 enum {
-        CONFIG_READ_NRPAGES_INIT = 1 << (20 - CFS_PAGE_SHIFT),
+       CONFIG_READ_NRPAGES_INIT = 1 << (20 - PAGE_CACHE_SHIFT),
         CONFIG_READ_NRPAGES      = 4
 };
 
@@ -1259,22 +1260,22 @@ static int mgc_apply_recover_logs(struct obd_device *mgc,
         LASSERT(cfg->cfg_instance != NULL);
         LASSERT(cfg->cfg_sb == cfg->cfg_instance);
 
-        OBD_ALLOC(inst, CFS_PAGE_SIZE);
-        if (inst == NULL)
-                RETURN(-ENOMEM);
+       OBD_ALLOC(inst, PAGE_CACHE_SIZE);
+       if (inst == NULL)
+               RETURN(-ENOMEM);
 
        if (!IS_SERVER(lsi)) {
-               pos = snprintf(inst, CFS_PAGE_SIZE, "%p", cfg->cfg_instance);
-               if (pos >= CFS_PAGE_SIZE) {
-                       OBD_FREE(inst, CFS_PAGE_SIZE);
+               pos = snprintf(inst, PAGE_CACHE_SIZE, "%p", cfg->cfg_instance);
+               if (pos >= PAGE_CACHE_SIZE) {
+                       OBD_FREE(inst, PAGE_CACHE_SIZE);
                        return -E2BIG;
                }
         } else {
                LASSERT(IS_MDT(lsi));
                rc = server_name2svname(lsi->lsi_svname, inst, NULL,
-                                       CFS_PAGE_SIZE);
+                                       PAGE_CACHE_SIZE);
                if (rc) {
-                       OBD_FREE(inst, CFS_PAGE_SIZE);
+                       OBD_FREE(inst, PAGE_CACHE_SIZE);
                        RETURN(-EINVAL);
                }
                pos = strlen(inst);
@@ -1282,7 +1283,7 @@ static int mgc_apply_recover_logs(struct obd_device *mgc,
 
         ++pos;
         buf   = inst + pos;
-        bufsz = CFS_PAGE_SIZE - pos;
+       bufsz = PAGE_CACHE_SIZE - pos;
 
         while (datalen > 0) {
                 int   entry_len = sizeof(*entry);
@@ -1314,7 +1315,7 @@ static int mgc_apply_recover_logs(struct obd_device *mgc,
                /* Keep this swab for normal mixed endian handling. LU-1644 */
                if (mne_swab)
                        lustre_swab_mgs_nidtbl_entry(entry);
-               if (entry->mne_length > CFS_PAGE_SIZE) {
+               if (entry->mne_length > PAGE_CACHE_SIZE) {
                        CERROR("MNE too large (%u)\n", entry->mne_length);
                        break;
                }
@@ -1432,7 +1433,7 @@ static int mgc_apply_recover_logs(struct obd_device *mgc,
                 /* continue, even one with error */
         }
 
-        OBD_FREE(inst, CFS_PAGE_SIZE);
+       OBD_FREE(inst, PAGE_CACHE_SIZE);
         RETURN(rc);
 }
 
@@ -1448,7 +1449,7 @@ static int mgc_process_recover_log(struct obd_device *obd,
         struct mgs_config_body *body;
         struct mgs_config_res  *res;
         struct ptlrpc_bulk_desc *desc;
-        cfs_page_t **pages;
+       struct page **pages;
         int nrpages;
         bool eof = true;
        bool mne_swab = false;
@@ -1472,7 +1473,7 @@ static int mgc_process_recover_log(struct obd_device *obd,
                 GOTO(out, rc = -ENOMEM);
 
         for (i = 0; i < nrpages; i++) {
-                pages[i] = cfs_alloc_page(CFS_ALLOC_STD);
+               pages[i] = alloc_page(GFP_IOFS);
                 if (pages[i] == NULL)
                         GOTO(out, rc = -ENOMEM);
         }
@@ -1498,7 +1499,7 @@ again:
                GOTO(out, rc = -E2BIG);
         body->mcb_offset = cfg->cfg_last_idx + 1;
         body->mcb_type   = cld->cld_type;
-        body->mcb_bits   = CFS_PAGE_SHIFT;
+       body->mcb_bits   = PAGE_CACHE_SHIFT;
         body->mcb_units  = nrpages;
 
        /* allocate bulk transfer descriptor */
@@ -1508,7 +1509,7 @@ again:
                GOTO(out, rc = -ENOMEM);
 
        for (i = 0; i < nrpages; i++)
-               ptlrpc_prep_bulk_page_pin(desc, pages[i], 0, CFS_PAGE_SIZE);
+               ptlrpc_prep_bulk_page_pin(desc, pages[i], 0, PAGE_CACHE_SIZE);
 
         ptlrpc_request_set_replen(req);
         rc = ptlrpc_queue_wait(req);
@@ -1531,7 +1532,7 @@ again:
         if (ealen < 0)
                 GOTO(out, rc = ealen);
 
-        if (ealen > nrpages << CFS_PAGE_SHIFT)
+       if (ealen > nrpages << PAGE_CACHE_SHIFT)
                 GOTO(out, rc = -EINVAL);
 
         if (ealen == 0) { /* no logs transferred */
@@ -1554,18 +1555,18 @@ again:
                 int rc2;
                 void *ptr;
 
-                ptr = cfs_kmap(pages[i]);
-                rc2 = mgc_apply_recover_logs(obd, cld, res->mcr_offset, ptr,
-                                            min_t(int, ealen, CFS_PAGE_SIZE),
+               ptr = kmap(pages[i]);
+               rc2 = mgc_apply_recover_logs(obd, cld, res->mcr_offset, ptr,
+                                            min_t(int, ealen, PAGE_CACHE_SIZE),
                                             mne_swab);
-                cfs_kunmap(pages[i]);
-                if (rc2 < 0) {
-                        CWARN("Process recover log %s error %d\n",
-                              cld->cld_logname, rc2);
-                        break;
+               kunmap(pages[i]);
+               if (rc2 < 0) {
+                       CWARN("Process recover log %s error %d\n",
+                             cld->cld_logname, rc2);
+                       break;
                 }
 
-                ealen -= CFS_PAGE_SIZE;
+               ealen -= PAGE_CACHE_SIZE;
         }
 
 out:
@@ -1575,15 +1576,15 @@ out:
         if (rc == 0 && !eof)
                 goto again;
 
-        if (pages) {
-                for (i = 0; i < nrpages; i++) {
-                        if (pages[i] == NULL)
-                                break;
-                        cfs_free_page(pages[i]);
-                }
-                OBD_FREE(pages, sizeof(*pages) * nrpages);
-        }
-        return rc;
+       if (pages) {
+               for (i = 0; i < nrpages; i++) {
+                       if (pages[i] == NULL)
+                               break;
+                       __free_page(pages[i]);
+               }
+               OBD_FREE(pages, sizeof(*pages) * nrpages);
+       }
+       return rc;
 }
 
 #ifdef HAVE_LDISKFS_OSD