* GPL HEADER END
*/
/*
- * Copyright 2008 Sun Microsystems, Inc. All rights reserved
+ * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved.
* Use is subject to license terms.
*/
/*
#endif
#define DEBUG_SUBSYSTEM S_MDS
-/* prerequisite for linux/xattr.h */
-#include <linux/types.h>
-/* prerequisite for linux/xattr.h */
-#include <linux/fs.h>
-/* XATTR_{REPLACE,CREATE} */
-#include <linux/xattr.h>
-
+#include <lustre_acl.h>
#include "mdt_internal.h"
static const char user_string[] = "user.";
int size, rc;
ENTRY;
-
+
if (OBD_FAIL_CHECK(OBD_FAIL_MDS_GETXATTR_PACK))
RETURN(-ENOMEM);
if (!(req->rq_export->exp_connect_flags & OBD_CONNECT_XATTR) &&
!strncmp(xattr_name, user_string, sizeof(user_string) - 1))
RETURN(-EOPNOTSUPP);
-
+
size = mo_xattr_get(info->mti_env,
mdt_object_child(info->mti_object),
&LU_BUF_NULL, xattr_name);
struct mdt_body *repbody = NULL;
struct md_object *next;
struct lu_buf *buf;
+ __u32 remote = exp_connect_rmtclient(info->mti_exp);
+ __u32 perm;
int easize, rc;
ENTRY;
next = mdt_object_child(info->mti_object);
if (info->mti_body->valid & OBD_MD_FLRMTRGETFACL) {
- __u32 perm = mdt_identity_get_perm(uc->mu_identity,
- med->med_rmtclient,
- req->rq_peer.nid);
+ if (unlikely(!remote))
+ GOTO(out, rc = err_serious(-EINVAL));
- LASSERT(med->med_rmtclient);
+ perm = mdt_identity_get_perm(uc->mu_identity, remote,
+ req->rq_peer.nid);
if (!(perm & CFS_RMTACL_PERM))
GOTO(out, rc = err_serious(-EPERM));
if (rc > 0 && flags != CFS_IC_NOTHING) {
int rc1;
- LASSERT(med->med_rmtclient);
+ if (unlikely(!remote))
+ GOTO(out, rc = -EINVAL);
+
rc1 = lustre_posix_acl_xattr_id2client(uc,
med->med_idmap,
(posix_acl_xattr_header *)(buf->lb_buf),
EXIT;
out:
if (rc >= 0) {
+ mdt_counter_incr(req->rq_export, LPROC_MDT_GETXATTR);
repbody->eadatasize = rc;
rc = 0;
}
rc = lustre_ext_acl_xattr_id2server(uc, med->med_idmap, header);
if (rc)
RETURN(rc);
-
+
rc = mo_xattr_get(info->mti_env, next, &LU_BUF_NULL, xattr_name);
if (rc == -ENODATA)
rc = 0;
buf->lb_len = rc;
if (buf->lb_len > 0) {
- OBD_ALLOC(buf->lb_buf, buf->lb_len);
+ OBD_ALLOC_LARGE(buf->lb_buf, buf->lb_len);
if (unlikely(buf->lb_buf == NULL))
RETURN(-ENOMEM);
_out:
if (rc <= 0 && buf->lb_buf != NULL)
- OBD_FREE(buf->lb_buf, buf->lb_len);
+ OBD_FREE_LARGE(buf->lb_buf, buf->lb_len);
return rc;
}
struct mdt_lock_handle *unused)
{
struct ptlrpc_request *req = mdt_info_req(info);
- struct mdt_export_data *med = mdt_req2med(req);
struct md_ucred *uc = mdt_ucred(info);
- const char user_string[] = "user.";
- const char trust_string[] = "trusted.";
struct mdt_lock_handle *lh;
struct req_capsule *pill = info->mti_pill;
const struct lu_env *env = info->mti_env;
struct mdt_reint_record *rr = &info->mti_rr;
struct md_attr *ma = &info->mti_attr;
struct lu_attr *attr = &info->mti_attr.ma_attr;
- struct mdt_object *obj;
+ struct mdt_object *obj;
struct md_object *child;
__u64 valid = attr->la_valid;
const char *xattr_name;
__u64 lockpart;
int rc;
posix_acl_xattr_header *new_xattr = NULL;
+ __u32 remote = exp_connect_rmtclient(info->mti_exp);
+ __u32 perm;
ENTRY;
CDEBUG(D_INODE, "setxattr for "DFID"\n", PFID(rr->rr_fid1));
RETURN(rc);
if (valid & OBD_MD_FLRMTRSETFACL) {
- __u32 perm = mdt_identity_get_perm(uc->mu_identity,
- med->med_rmtclient,
- req->rq_peer.nid);
+ if (unlikely(!remote))
+ GOTO(out, rc = err_serious(-EINVAL));
- LASSERT(med->med_rmtclient);
+ perm = mdt_identity_get_perm(uc->mu_identity, remote,
+ req->rq_peer.nid);
if (!(perm & CFS_RMTACL_PERM))
GOTO(out, rc = err_serious(-EPERM));
}
if (!xattr_name)
GOTO(out, rc = err_serious(-EFAULT));
- if (strncmp(xattr_name, trust_string, sizeof(trust_string) - 1) == 0) {
- if (strcmp(xattr_name + 8, XATTR_NAME_LOV) == 0)
+ if (strncmp(xattr_name, XATTR_USER_PREFIX,
+ sizeof(XATTR_USER_PREFIX) - 1) == 0) {
+ if (!(req->rq_export->exp_connect_flags & OBD_CONNECT_XATTR))
+ GOTO(out, rc = -EOPNOTSUPP);
+ if (strcmp(xattr_name, XATTR_NAME_LOV) == 0)
GOTO(out, rc = -EACCES);
- }
+ if (strcmp(xattr_name, XATTR_NAME_LMA) == 0)
+ GOTO(out, rc = 0);
+ if (strcmp(xattr_name, XATTR_NAME_LINK) == 0)
+ GOTO(out, rc = 0);
+ } else if ((valid & OBD_MD_FLXATTR) &&
+ (strncmp(xattr_name, XATTR_NAME_ACL_ACCESS,
+ sizeof(XATTR_NAME_ACL_ACCESS) - 1) == 0 ||
+ strncmp(xattr_name, XATTR_NAME_ACL_DEFAULT,
+ sizeof(XATTR_NAME_ACL_DEFAULT) - 1) == 0)) {
+ /* currently lustre limit acl access size */
+ xattr_len = req_capsule_get_size(pill, &RMF_EADATA, RCL_CLIENT);
- if (!(req->rq_export->exp_connect_flags & OBD_CONNECT_XATTR) &&
- (strncmp(xattr_name, user_string, sizeof(user_string) - 1) == 0)) {
- GOTO(out, rc = -EOPNOTSUPP);
+ if (xattr_len > LUSTRE_POSIX_ACL_MAX_SIZE)
+ GOTO(out, -ERANGE);
}
lockpart = MDS_INODELOCK_UPDATE;
+ /* Revoke all clients' lookup lock, since the access
+ * permissions for this inode is changed when ACL_ACCESS is
+ * set. This isn't needed for ACL_DEFAULT, since that does
+ * not change the access permissions of this inode, nor any
+ * other existing inodes. It is setting the ACLs inherited
+ * by new directories/files at create time. */
if (!strcmp(xattr_name, XATTR_NAME_ACL_ACCESS))
lockpart |= MDS_INODELOCK_LOOKUP;
lh = &info->mti_lh[MDT_LH_PARENT];
- mdt_lock_reg_init(lh, LCK_PW);
+ /* ACLs were sent to clients under LCK_CR locks, so taking LCK_EX
+ * to cancel them. */
+ mdt_lock_reg_init(lh, LCK_EX);
obj = mdt_object_find_lock(info, rr->rr_fid1, lh, lockpart);
if (IS_ERR(obj))
GOTO(out, rc = PTR_ERR(obj));
+ info->mti_mos = obj;
+ rc = mdt_version_get_check_save(info, obj, 0);
+ if (rc)
+ GOTO(out_unlock, rc);
+
if (unlikely(!(valid & OBD_MD_FLCTIME))) {
- CWARN("client miss to set OBD_MD_FLCTIME when "
- "setxattr: [object "DFID"] [valid %llu]\n",
+ /* This isn't strictly an error, but all current clients
+ * should set OBD_MD_FLCTIME when setting attributes. */
+ CWARN("%s: client miss to set OBD_MD_FLCTIME when "
+ "setxattr %s: [object "DFID"] [valid "LPU64"]\n",
+ info->mti_exp->exp_obd->obd_name, xattr_name,
PFID(rr->rr_fid1), valid);
attr->la_ctime = cfs_time_current_sec();
}
xattr = req_capsule_client_get(pill, &RMF_EADATA);
if (valid & OBD_MD_FLRMTLSETFACL) {
- LASSERT(med->med_rmtclient);
+ if (unlikely(!remote))
+ GOTO(out_unlock, rc = -EINVAL);
+
xattr_len = mdt_rmtlsetfacl(info, child,
xattr_name,
(ext_acl_xattr_header *)xattr,
CDEBUG(D_INFO, "valid bits: "LPX64"\n", valid);
rc = -EINVAL;
}
+ if (rc == 0)
+ mdt_counter_incr(req->rq_export, LPROC_MDT_SETXATTR);
+
EXIT;
out_unlock:
mdt_object_unlock_put(info, obj, lh, rc);
git://git.whamcloud.com / fs / lustre-release.git / blobdiff