#include "mdt_internal.h"
/* Called with res->lr_lvb_sem held */
-static int mdt_lvbo_init(const struct lu_env *env, struct ldlm_resource *res)
+static int mdt_lvbo_init(struct ldlm_resource *res)
{
if (IS_LQUOTA_RES(res)) {
struct mdt_device *mdt;
RETURN(rc);
}
-int mdt_dom_lvbo_update(const struct lu_env *env, struct ldlm_resource *res,
- struct ldlm_lock *lock, struct ptlrpc_request *req,
- bool increase_only)
+int mdt_dom_lvbo_update(struct ldlm_resource *res, struct ldlm_lock *lock,
+ struct ptlrpc_request *req, bool increase_only)
{
struct obd_export *exp = lock ? lock->l_export : NULL;
+ const struct lu_env *env = lu_env_find();
struct mdt_device *mdt;
struct mdt_object *mo;
struct mdt_thread_info *info;
ENTRY;
/* Before going further let's check that OBD and export are healthy.
+ * The condition matches one in ptlrpc_send_reply()
*/
- if (exp != NULL &&
- (exp->exp_disconnected || exp->exp_failed ||
- exp->exp_obd->obd_stopping)) {
- CDEBUG(D_INFO, "Skip LVB update, export is %s, obd is %s\n",
- exp->exp_failed ? "failed" : "disconnected",
- exp->exp_obd->obd_stopping ? "stopping" : "OK");
+ if (exp && exp->exp_obd && exp->exp_obd->obd_fail) {
+ CDEBUG(D_INFO, "Skip LVB update, obd is failing over\n");
RETURN(0);
}
if (!info)
GOTO(out_env, rc = -ENOMEM);
}
- if (!info->mti_exp)
- info->mti_exp = req ? req->rq_export : NULL;
- if (!info->mti_mdt)
- info->mti_mdt = mdt;
fid = &info->mti_tmp_fid2;
fid_extract_from_res_name(fid, &res->lr_name);
return rc;
}
-static int mdt_lvbo_update(const struct lu_env *env, struct ldlm_resource *res,
- struct ldlm_lock *lock, struct ptlrpc_request *req,
- int increase_only)
+static int mdt_lvbo_update(struct ldlm_resource *res, struct ldlm_lock *lock,
+ struct ptlrpc_request *req, int increase_only)
{
ENTRY;
* by MDT for DOM objects only.
*/
if (lock == NULL || ldlm_has_dom(lock))
- return mdt_dom_lvbo_update(env, res, lock, req,
- !!increase_only);
+ return mdt_dom_lvbo_update(res, lock, req, !!increase_only);
return 0;
}
/* resource on server side never changes. */
mdt = ldlm_res_to_ns(lock->l_resource)->ns_lvbp;
- LASSERT(mdt != NULL);
+ if (!mdt)
+ return 0;
if (IS_LQUOTA_RES(lock->l_resource)) {
if (mdt->mdt_qmt_dev == NULL)
return qmt_hdls.qmth_lvbo_size(mdt->mdt_qmt_dev, lock);
}
+ /* Always prefer DoM LVB data because layout is never returned in
+ * LVB when lock bits are combined with DoM, this is either GETATTR
+ * or OPEN enqueue. Meanwhile GL AST can be issued on such combined
+ * lock bits and it uses LVB for DoM data.
+ */
if (ldlm_has_dom(lock))
return sizeof(struct ost_lvb);
* and the needed lvb buffer size will be returned in
* @lvblen
*/
-static int mdt_lvbo_fill(const struct lu_env *env, struct ldlm_lock *lock,
+static int mdt_lvbo_fill(struct ldlm_lock *lock,
void *lvb, int *lvblen)
{
struct mdt_thread_info *info;
struct mdt_device *mdt;
+ struct lu_env *env;
struct lu_fid *fid;
struct mdt_object *obj = NULL;
struct md_object *child = NULL;
int rc;
ENTRY;
+ env = lu_env_find();
+ LASSERT(env);
+
mdt = ldlm_lock_to_ns(lock)->ns_lvbp;
+ if (!mdt)
+ RETURN(0);
+
if (IS_LQUOTA_RES(lock->l_resource)) {
if (mdt->mdt_qmt_dev == NULL)
- RETURN(0);
+ GOTO(out, rc = 0);
/* call lvbo fill function of quota master */
rc = qmt_hdls.qmth_lvbo_fill(mdt->mdt_qmt_dev, lock, lvb,
*lvblen);
- RETURN(rc);
+ GOTO(out, rc);
}
info = lu_context_key_get(&env->le_ctx, &mdt_thread_key);
if (!info) {
- rc = lu_env_refill_by_tags((struct lu_env *)env,
- LCT_MD_THREAD, 0);
+ rc = lu_env_refill_by_tags(env, LCT_MD_THREAD, 0);
if (rc)
GOTO(out, rc);
info = lu_context_key_get(&env->le_ctx, &mdt_thread_key);
if (!info)
GOTO(out, rc = -ENOMEM);
}
- if (!info->mti_env)
- info->mti_env = env;
- if (!info->mti_exp)
- info->mti_exp = lock->l_export;
- if (!info->mti_mdt)
- info->mti_mdt = mdt;
-
- /* LVB for DoM lock is needed only for glimpse,
- * don't fill DoM data if there is layout lock */
+
+ /* DOM LVB is used by glimpse and IO completion when
+ * DoM bits is always alone.
+ * If DoM bit is combined with any other bit then it is
+ * intent OPEN or GETATTR lock which is not filling
+ * LVB buffer in reply neither for DoM nor for LAYOUT.
+ */
if (ldlm_has_dom(lock)) {
struct ldlm_resource *res = lock->l_resource;
int lvb_len = sizeof(struct ost_lvb);
if (!mdt_dom_lvb_is_valid(res))
- mdt_dom_lvbo_update(env, lock->l_resource,
- lock, NULL, 0);
-
- if (lvb_len > *lvblen)
- lvb_len = *lvblen;
+ mdt_dom_lvbo_update(res, lock, NULL, 0);
+ LASSERT(*lvblen >= lvb_len);
lock_res(res);
memcpy(lvb, res->lr_lvb_data, lvb_len);
unlock_res(res);
-
GOTO(out, rc = lvb_len);
}
/* Only fill layout if layout lock is granted */
- if (!ldlm_has_layout(lock) || lock->l_granted_mode != lock->l_req_mode)
+ if (!ldlm_has_layout(lock) || !ldlm_is_granted(lock))
GOTO(out, rc = 0);
/* XXX get fid by resource id. why don't include fid in ldlm_resource */
fid = &info->mti_tmp_fid2;
fid_extract_from_res_name(fid, &lock->l_resource->lr_name);
- obj = mdt_object_find(env, info->mti_mdt, fid);
+ obj = mdt_object_find(env, mdt, fid);
if (IS_ERR(obj))
GOTO(out, rc = PTR_ERR(obj));
* and in that case mdt_max_mdsize is just updated
* but if EA size is less than mdt_max_mdsize then
* it is an error in lvblen value provided. */
- if (rc > info->mti_mdt->mdt_max_mdsize) {
- info->mti_mdt->mdt_max_mdsize = rc;
+ if (rc > mdt->mdt_max_mdsize) {
+ mdt->mdt_max_mdsize = rc;
level = D_INFO;
} else {
- level = D_ERROR;
+ /* The PFL layout EA could be enlarged when
+ * the corresponding layout of some IO range
+ * is started to be written, which can cause
+ * other thread to get incorrect layout size
+ * at mdt_intent_layout, see LU-13261. */
+ level = D_LAYOUT;
}
CDEBUG_LIMIT(level, "%s: small buffer size %d for EA "
"%d (max_mdsize %d): rc = %d\n",
mdt_obd_name(mdt), *lvblen, rc,
- info->mti_mdt->mdt_max_mdsize, -ERANGE);
+ mdt->mdt_max_mdsize, -ERANGE);
*lvblen = rc;
GOTO(out_put, rc = -ERANGE);
}
out:
if (rc < 0 && rc != -ERANGE)
rc = 0;
-
RETURN(rc);
}
static int mdt_lvbo_free(struct ldlm_resource *res)
{
if (IS_LQUOTA_RES(res)) {
- struct mdt_device *mdt;
+ struct mdt_device *mdt;
mdt = ldlm_res_to_ns(res)->ns_lvbp;
- if (mdt->mdt_qmt_dev == NULL)
+ if (!mdt || !mdt->mdt_qmt_dev)
return 0;
/* call lvbo free function of quota master */
git://git.whamcloud.com / fs / lustre-release.git / blobdiff