-/* -*- mode: c; c-basic-offset: 8; indent-tabs-mode: nil; -*-
- * vim:expandtab:shiftwidth=8:tabstop=8:
+/*
+ * GPL HEADER START
+ *
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 only,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * General Public License version 2 for more details (a copy is included
+ * in the LICENSE file that accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License
+ * version 2 along with this program; If not, see
+ * http://www.sun.com/software/products/lustre/docs/GPLv2.pdf
*
- * Copyright (C) 2004-2006 Cluster File Systems, Inc.
- * Author: Lai Siyao <lsy@clusterfs.com>
- * Author: Fan Yong <fanyong@clusterfs.com>
+ * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
+ * CA 95054 USA or visit www.sun.com if you need additional information or
+ * have any questions.
*
- * This file is part of Lustre, http://www.lustre.org.
+ * GPL HEADER END
+ */
+/*
+ * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved.
+ * Use is subject to license terms.
*
- * Lustre is free software; you can redistribute it and/or
- * modify it under the terms of version 2 of the GNU General Public
- * License as published by the Free Software Foundation.
+ * Copyright (c) 2011, Whamcloud, Inc.
+ */
+/*
+ * This file is part of Lustre, http://www.lustre.org/
+ * Lustre is a trademark of Sun Microsystems, Inc.
*
- * Lustre is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
+ * lustre/mdt/mdt_identity.c
*
- * You should have received a copy of the GNU General Public License
- * along with Lustre; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ * Author: Lai Siyao <lsy@clusterfs.com>
+ * Author: Fan Yong <fanyong@clusterfs.com>
*/
-#ifndef EXPORT_SYMTAB
-#define EXPORT_SYMTAB
-#endif
#define DEBUG_SUBSYSTEM S_MDS
-#ifndef AUTOCONF_INCLUDED
-#include <linux/config.h>
-#endif
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/mm.h>
#include <linux/errno.h>
#include <linux/version.h>
#include <linux/unistd.h>
-#include <asm/system.h>
#include <asm/uaccess.h>
#include <linux/fs.h>
#include <linux/stat.h>
#include <asm/uaccess.h>
#include <linux/slab.h>
-#include <asm/segment.h>
-#include <libcfs/kp30.h>
+#include <libcfs/libcfs.h>
+#include <libcfs/lucache.h>
#include <obd.h>
#include <obd_class.h>
#include <obd_support.h>
#include <lustre_import.h>
#include <lustre_dlm.h>
#include <lustre_lib.h>
-#include <lustre_ucache.h>
#include "mdt_internal.h"
struct md_identity *identity = &entry->u.identity;
if (identity->mi_ginfo) {
- groups_free(identity->mi_ginfo);
+ cfs_put_group_info(identity->mi_ginfo);
identity->mi_ginfo = NULL;
}
[1] = "PATH=/sbin:/usr/sbin",
[2] = NULL
};
+ struct timeval start, end;
int rc;
ENTRY;
- snprintf(keystr, sizeof(keystr), LPU64, entry->ue_key);
+ /* There is race condition:
+ * "uc_upcall" was changed just after "is_identity_get_disabled" check.
+ */
+ read_lock(&cache->uc_upcall_rwlock);
+ CDEBUG(D_INFO, "The upcall is: '%s'\n", cache->uc_upcall);
- LASSERTF(strcmp(cache->uc_upcall, "NONE"), "no upcall set!");
- CDEBUG(D_INFO, "The upcall is: %s \n", cache->uc_upcall);
+ if (unlikely(!strcmp(cache->uc_upcall, "NONE"))) {
+ CERROR("no upcall set\n");
+ GOTO(out, rc = -EREMCHG);
+ }
+
+ argv[0] = cache->uc_upcall;
+ snprintf(keystr, sizeof(keystr), LPU64, entry->ue_key);
+ cfs_gettimeofday(&start);
rc = USERMODEHELPER(argv[0], argv, envp);
+ cfs_gettimeofday(&end);
if (rc < 0) {
CERROR("%s: error invoking upcall %s %s %s: rc %d; "
- "check /proc/fs/lustre/mdt/%s/identity_upcall\n",
+ "check /proc/fs/lustre/mdt/%s/identity_upcall, "
+ "time %ldus\n",
cache->uc_name, argv[0], argv[1], argv[2], rc,
- cache->uc_name);
+ cache->uc_name, cfs_timeval_sub(&end, &start, NULL));
} else {
- CDEBUG(D_HA, "%s: invoked upcall %s %s %s\n", cache->uc_name,
- argv[0], argv[1], argv[2]);
+ CDEBUG(D_HA, "%s: invoked upcall %s %s %s, time %ldus\n",
+ cache->uc_name, argv[0], argv[1], argv[2],
+ cfs_timeval_sub(&end, &start, NULL));
rc = 0;
}
- RETURN(rc);
+ EXIT;
+out:
+ read_unlock(&cache->uc_upcall_rwlock);
+ return rc;
}
static int mdt_identity_parse_downcall(struct upcall_cache *cache,
{
struct md_identity *identity = &entry->u.identity;
struct identity_downcall_data *data = args;
- struct group_info *ginfo;
+ cfs_group_info_t *ginfo = NULL;
struct md_perm *perms = NULL;
int size, i;
ENTRY;
if (data->idd_ngroups > NGROUPS_MAX)
RETURN(-E2BIG);
- ginfo = groups_alloc(data->idd_ngroups);
- if (!ginfo) {
- CERROR("failed to alloc %d groups\n", data->idd_ngroups);
- RETURN(-ENOMEM);
- }
+ if (data->idd_ngroups > 0) {
+ ginfo = cfs_groups_alloc(data->idd_ngroups);
+ if (!ginfo) {
+ CERROR("failed to alloc %d groups\n", data->idd_ngroups);
+ RETURN(-ENOMEM);
+ }
- lustre_groups_from_list(ginfo, data->idd_groups);
- lustre_groups_sort(ginfo);
+ lustre_groups_from_list(ginfo, data->idd_groups);
+ lustre_groups_sort(ginfo);
+ }
if (data->idd_nperms) {
size = data->idd_nperms * sizeof(*perms);
if (!perms) {
CERROR("failed to alloc %d permissions\n",
data->idd_nperms);
- groups_free(ginfo);
+ if (ginfo != NULL)
+ cfs_put_group_info(ginfo);
RETURN(-ENOMEM);
}
CDEBUG(D_OTHER, "parse mdt identity@%p: %d:%d, ngroups %u, nperms %u\n",
identity, identity->mi_uid, identity->mi_gid,
- identity->mi_ginfo->ngroups, identity->mi_nperms);
+ data->idd_ngroups, data->idd_nperms);
RETURN(0);
}
struct upcall_cache_entry *entry;
if (!cache)
- return NULL;
+ return ERR_PTR(-ENOENT);
entry = upcall_cache_get_entry(cache, (__u64)uid, NULL);
- if (IS_ERR(entry)) {
- CERROR("upcall_cache_get_entry failed: %ld\n", PTR_ERR(entry));
- return NULL;
- }
-
- return &entry->u.identity;
+ if (IS_ERR(entry))
+ return ERR_PTR(PTR_ERR(entry));
+ else if (unlikely(!entry))
+ return ERR_PTR(-ENOENT);
+ else
+ return &entry->u.identity;
}
void mdt_identity_put(struct upcall_cache *cache, struct md_identity *identity)
* it must be perm[0].mp_nid, and act as default perm.
*/
__u32 mdt_identity_get_perm(struct md_identity *identity,
- __u32 is_rmtclient, lnet_nid_t nid)
+ __u32 is_rmtclient, lnet_nid_t nid)
{
struct md_perm *perm;
int i;
int mdt_pack_remote_perm(struct mdt_thread_info *info, struct mdt_object *o,
void *buf)
{
- struct ptlrpc_request *req = mdt_info_req(info);
- struct md_ucred *uc = mdt_ucred(info);
+ struct lu_ucred *uc = mdt_ucred_check(info);
struct md_object *next = mdt_object_child(o);
- struct mdt_export_data *med = mdt_req2med(req);
struct mdt_remote_perm *perm = buf;
ENTRY;
/* remote client request always pack ptlrpc_user_desc! */
LASSERT(perm);
- if (!med->med_rmtclient)
+ if (!exp_connect_rmtclient(info->mti_exp))
RETURN(-EBADE);
- if ((uc->mu_valid != UCRED_OLD) && (uc->mu_valid != UCRED_NEW))
- RETURN(-EINVAL);
+ if (uc == NULL)
+ RETURN(-EINVAL);
- perm->rp_uid = uc->mu_o_uid;
- perm->rp_gid = uc->mu_o_gid;
- perm->rp_fsuid = uc->mu_o_fsuid;
- perm->rp_fsgid = uc->mu_o_fsgid;
+ perm->rp_uid = uc->uc_o_uid;
+ perm->rp_gid = uc->uc_o_gid;
+ perm->rp_fsuid = uc->uc_o_fsuid;
+ perm->rp_fsgid = uc->uc_o_fsgid;
perm->rp_access_perm = 0;
if (mo_permission(info->mti_env, NULL, next, NULL, MAY_READ) == 0)
git://git.whamcloud.com / fs / lustre-release.git / blobdiff