Whamcloud - gitweb
LU-8030 hsm: prevent duplicated HSM requests
[fs/lustre-release.git] / lustre / mdt / mdt_hsm.c
index 3dc19b9..ab0e851 100644 (file)
  * GPL HEADER END
  */
 /*
- * Copyright (c) 2012, Intel Corporation.
- * Use is subject to license terms.
  * Copyright (c) 2011, 2012 Commissariat a l'energie atomique et aux energies
  *                          alternatives
+ * Use is subject to license terms.
+ *
+ * Copyright (c) 2012, 2015, Intel Corporation.
  */
 /*
  * lustre/mdt/mdt_hsm.c
  * Author: JC Lafoucriere <jacques-charles.lafoucriere@cea.fr>
  */
 
-#ifndef EXPORT_SYMTAB
-# define EXPORT_SYMTAB
-#endif
 #define DEBUG_SUBSYSTEM S_MDS
 
 #include "mdt_internal.h"
 
-/*
- * fake functions, will be replace by real one with HSM Coordinator patch
- */
-
-int mdt_hsm_copytool_send(struct obd_export *exp)
-{
-       return 0;
-}
-
-static int mdt_hsm_coordinator_update(struct mdt_thread_info *info,
-                                     struct hsm_progress_kernel *pgs)
-{
-       return 0;
-}
+/* Max allocation to satisfy single HSM RPC. */
+#define MDT_HSM_ALLOC_MAX (1 << 20)
 
-static int mdt_hsm_agent_register_mask(struct mdt_thread_info *info,
-                                      struct obd_uuid *uuid,
-                                      __u32 archive_mask)
-{
-       return 0;
-}
+#define MDT_HSM_ALLOC(ptr, size)                       \
+       do {                                            \
+               if ((size) <= MDT_HSM_ALLOC_MAX)        \
+                       OBD_ALLOC_LARGE((ptr), (size)); \
+               else                                    \
+                       (ptr) = NULL;                   \
+       } while (0)
 
-static int mdt_hsm_agent_unregister(struct mdt_thread_info *info,
-                                   struct obd_uuid *uuid)
-{
-       return 0;
-}
-
-static int mdt_hsm_coordinator_get_actions(struct mdt_thread_info *mti,
-                                          struct hsm_action_list *hal)
-{
-       return 0;
-}
+#define MDT_HSM_FREE(ptr, size) OBD_FREE_LARGE((ptr), (size))
 
 /**
  * Update on-disk HSM attributes.
  */
 int mdt_hsm_attr_set(struct mdt_thread_info *info, struct mdt_object *obj,
-                    struct md_hsm *mh)
+                    const struct md_hsm *mh)
 {
        struct md_object        *next = mdt_object_child(obj);
        struct lu_buf           *buf = &info->mti_buf;
@@ -93,7 +70,7 @@ int mdt_hsm_attr_set(struct mdt_thread_info *info, struct mdt_object *obj,
        /* pack HSM attributes */
        lustre_hsm2buf(info->mti_xattr_buf, mh);
 
-       /* update SOM attributes */
+       /* update HSM attributes */
        buf->lb_buf = attrs;
        buf->lb_len = sizeof(*attrs);
        rc = mo_xattr_set(info->mti_env, next, buf, XATTR_NAME_HSM, 0);
@@ -101,6 +78,25 @@ int mdt_hsm_attr_set(struct mdt_thread_info *info, struct mdt_object *obj,
        RETURN(rc);
 }
 
+static inline bool mdt_hsm_is_admin(struct mdt_thread_info *info)
+{
+       bool is_admin;
+       int rc;
+
+       if (info->mti_body == NULL)
+               return false;
+
+       rc = mdt_init_ucred(info, (struct mdt_body *)info->mti_body);
+       if (rc < 0)
+               return false;
+
+       is_admin = md_capable(mdt_ucred(info), CFS_CAP_SYS_ADMIN);
+
+       mdt_exit_ucred(info);
+
+       return is_admin;
+}
+
 /**
  * Extract information coming from a copytool and asks coordinator to update
  * a request status depending on the update content.
@@ -109,14 +105,21 @@ int mdt_hsm_attr_set(struct mdt_thread_info *info, struct mdt_object *obj,
  *
  * This is HSM_PROGRESS RPC handler.
  */
-int mdt_hsm_progress(struct mdt_thread_info *info)
+int mdt_hsm_progress(struct tgt_session_info *tsi)
 {
+       struct mdt_thread_info          *info;
        struct hsm_progress_kernel      *hpk;
        int                              rc;
        ENTRY;
 
-       hpk = req_capsule_client_get(info->mti_pill, &RMF_MDS_HSM_PROGRESS);
-       LASSERT(hpk);
+       if (tsi->tsi_mdt_body == NULL)
+               RETURN(-EPROTO);
+
+       hpk = req_capsule_client_get(tsi->tsi_pill, &RMF_MDS_HSM_PROGRESS);
+       if (hpk == NULL)
+               RETURN(err_serious(-EPROTO));
+
+       hpk->hpk_errval = lustre_errno_ntoh(hpk->hpk_errval);
 
        CDEBUG(D_HSM, "Progress on "DFID": len="LPU64" err=%d\n",
               PFID(&hpk->hpk_fid), hpk->hpk_extent.length, hpk->hpk_errval);
@@ -130,41 +133,59 @@ int mdt_hsm_progress(struct mdt_thread_info *info)
                CDEBUG(D_HSM, "Finished "DFID" (%d) cancel cookie="LPX64"\n",
                       PFID(&hpk->hpk_fid), hpk->hpk_errval, hpk->hpk_cookie);
 
-       rc = mdt_hsm_coordinator_update(info, hpk);
+       info = tsi2mdt_info(tsi);
+       if (!mdt_hsm_is_admin(info))
+               GOTO(out, rc = -EPERM);
 
+       rc = mdt_hsm_coordinator_update(info, hpk);
+out:
+       mdt_thread_info_fini(info);
        RETURN(rc);
 }
 
-int mdt_hsm_ct_register(struct mdt_thread_info *info)
+int mdt_hsm_ct_register(struct tgt_session_info *tsi)
 {
-       struct ptlrpc_request *req = mdt_info_req(info);
-       __u32 *archives;
-       int rc;
+       struct mdt_thread_info  *info;
+       __u32                   *archives;
+       int                      rc;
        ENTRY;
 
-       archives = req_capsule_client_get(info->mti_pill, &RMF_MDS_HSM_ARCHIVE);
-       LASSERT(archives);
+       archives = req_capsule_client_get(tsi->tsi_pill, &RMF_MDS_HSM_ARCHIVE);
+       if (archives == NULL)
+               RETURN(err_serious(-EPROTO));
+
+       info = tsi2mdt_info(tsi);
+       if (!mdt_hsm_is_admin(info))
+               GOTO(out, rc = -EPERM);
 
        /* XXX: directly include this function here? */
-       rc = mdt_hsm_agent_register_mask(info, &req->rq_export->exp_client_uuid,
+       rc = mdt_hsm_agent_register_mask(info, &tsi->tsi_exp->exp_client_uuid,
                                         *archives);
-
+out:
+       mdt_thread_info_fini(info);
        RETURN(rc);
 }
 
-int mdt_hsm_ct_unregister(struct mdt_thread_info *info)
+int mdt_hsm_ct_unregister(struct tgt_session_info *tsi)
 {
-       struct ptlrpc_request *req = mdt_info_req(info);
-       int rc;
+       struct mdt_thread_info  *info;
+       int                      rc;
        ENTRY;
 
-       /* XXX: directly include this function here? */
-       rc = mdt_hsm_agent_unregister(info, &req->rq_export->exp_client_uuid);
+       if (tsi->tsi_mdt_body == NULL)
+               RETURN(-EPROTO);
 
+       info = tsi2mdt_info(tsi);
+       if (!mdt_hsm_is_admin(info))
+               GOTO(out, rc = -EPERM);
+
+       /* XXX: directly include this function here? */
+       rc = mdt_hsm_agent_unregister(info, &tsi->tsi_exp->exp_client_uuid);
+out:
+       mdt_thread_info_fini(info);
        RETURN(rc);
 }
 
-
 /**
  * Retrieve the current HSM flags, archive id and undergoing HSM requests for
  * the fid provided in RPC body.
@@ -173,8 +194,9 @@ int mdt_hsm_ct_unregister(struct mdt_thread_info *info)
  *
  * This is MDS_HSM_STATE_GET RPC handler.
  */
-int mdt_hsm_state_get(struct mdt_thread_info *info)
+int mdt_hsm_state_get(struct tgt_session_info *tsi)
 {
+       struct mdt_thread_info  *info = tsi2mdt_info(tsi);
        struct mdt_object       *obj = info->mti_object;
        struct md_attr          *ma  = &info->mti_attr;
        struct hsm_user_state   *hus;
@@ -182,40 +204,41 @@ int mdt_hsm_state_get(struct mdt_thread_info *info)
        int                      rc;
        ENTRY;
 
-       lh = &info->mti_lh[MDT_LH_CHILD];
-       mdt_lock_reg_init(lh, LCK_PR);
-       rc = mdt_object_lock(info, obj, lh, MDS_INODELOCK_LOOKUP,
-                            MDT_LOCAL_LOCK);
-       if (rc)
-               RETURN(rc);
+       if (info->mti_body == NULL || obj == NULL)
+               GOTO(out, rc = -EPROTO);
 
        /* Only valid if client is remote */
        rc = mdt_init_ucred(info, (struct mdt_body *)info->mti_body);
-       if (rc)
-               GOTO(out_unlock, rc = err_serious(rc));
+       if (rc < 0)
+               GOTO(out, rc = err_serious(rc));
+
+       lh = &info->mti_lh[MDT_LH_CHILD];
+       mdt_lock_reg_init(lh, LCK_PR);
+       rc = mdt_object_lock(info, obj, lh, MDS_INODELOCK_LOOKUP);
+       if (rc < 0)
+               GOTO(out_ucred, rc);
 
        ma->ma_valid = 0;
        ma->ma_need = MA_HSM;
        rc = mdt_attr_get_complex(info, obj, ma);
        if (rc)
-               GOTO(out_ucred, rc);
+               GOTO(out_unlock, rc);
 
-       if (req_capsule_get_size(info->mti_pill, &RMF_CAPA1, RCL_CLIENT))
-               mdt_set_capainfo(info, 0, &info->mti_body->fid1,
-                           req_capsule_client_get(info->mti_pill, &RMF_CAPA1));
-
-       hus = req_capsule_server_get(info->mti_pill, &RMF_HSM_USER_STATE);
-       LASSERT(hus);
+       hus = req_capsule_server_get(tsi->tsi_pill, &RMF_HSM_USER_STATE);
+       if (hus == NULL)
+               GOTO(out_unlock, rc = -EPROTO);
 
        /* Current HSM flags */
        hus->hus_states = ma->ma_hsm.mh_flags;
        hus->hus_archive_id = ma->ma_hsm.mh_arch_id;
 
        EXIT;
-out_ucred:
-       mdt_exit_ucred(info);
 out_unlock:
        mdt_object_unlock(info, obj, lh, 1);
+out_ucred:
+       mdt_exit_ucred(info);
+out:
+       mdt_thread_info_fini(info);
        return rc;
 }
 
@@ -224,12 +247,13 @@ out_unlock:
  *
  * Archive number is changed iif the value is not 0.
  * The new flagset that will be computed should result in a coherent state.
- * This function checks that are flags are compatible.
+ * This function checks that flags are compatible.
  *
  * This is MDS_HSM_STATE_SET RPC handler.
  */
-int mdt_hsm_state_set(struct mdt_thread_info *info)
+int mdt_hsm_state_set(struct tgt_session_info *tsi)
 {
+       struct mdt_thread_info  *info = tsi2mdt_info(tsi);
        struct mdt_object       *obj = info->mti_object;
        struct md_attr          *ma = &info->mti_attr;
        struct hsm_state_set    *hss;
@@ -238,31 +262,47 @@ int mdt_hsm_state_set(struct mdt_thread_info *info)
        __u64                    flags;
        ENTRY;
 
-       lh = &info->mti_lh[MDT_LH_CHILD];
-       mdt_lock_reg_init(lh, LCK_PW);
-       rc = mdt_object_lock(info, obj, lh, MDS_INODELOCK_LOOKUP,
-                            MDT_LOCAL_LOCK);
-       if (rc)
-               RETURN(rc);
+       hss = req_capsule_client_get(info->mti_pill, &RMF_HSM_STATE_SET);
+
+       if (info->mti_body == NULL || obj == NULL || hss == NULL)
+               GOTO(out, rc = -EPROTO);
 
        /* Only valid if client is remote */
        rc = mdt_init_ucred(info, (struct mdt_body *)info->mti_body);
-       if (rc)
-               GOTO(out_obj, rc = err_serious(rc));
+       if (rc < 0)
+               GOTO(out, rc = err_serious(rc));
+
+       lh = &info->mti_lh[MDT_LH_CHILD];
+       mdt_lock_reg_init(lh, LCK_PW);
+       rc = mdt_object_lock(info, obj, lh, MDS_INODELOCK_LOOKUP |
+                            MDS_INODELOCK_XATTR);
+       if (rc < 0)
+               GOTO(out_ucred, rc);
+
+       /* Detect out-of range masks */
+       if ((hss->hss_setmask | hss->hss_clearmask) & ~HSM_FLAGS_MASK) {
+               CDEBUG(D_HSM, "Incompatible masks provided (set "LPX64
+                      ", clear "LPX64") vs supported set (%#x).\n",
+                      hss->hss_setmask, hss->hss_clearmask, HSM_FLAGS_MASK);
+               GOTO(out_unlock, rc = -EINVAL);
+       }
+
+       /* Non-root users are forbidden to set or clear flags which are
+        * NOT defined in HSM_USER_MASK. */
+       if (((hss->hss_setmask | hss->hss_clearmask) & ~HSM_USER_MASK) &&
+           !md_capable(mdt_ucred(info), CFS_CAP_SYS_ADMIN)) {
+               CDEBUG(D_HSM, "Incompatible masks provided (set "LPX64
+                      ", clear "LPX64") vs unprivileged set (%#x).\n",
+                      hss->hss_setmask, hss->hss_clearmask, HSM_USER_MASK);
+               GOTO(out_unlock, rc = -EPERM);
+       }
 
        /* Read current HSM info */
        ma->ma_valid = 0;
        ma->ma_need = MA_HSM;
        rc = mdt_attr_get_complex(info, obj, ma);
        if (rc)
-               GOTO(out_ucred, rc);
-
-       hss = req_capsule_client_get(info->mti_pill, &RMF_HSM_STATE_SET);
-       LASSERT(hss);
-
-       if (req_capsule_get_size(info->mti_pill, &RMF_CAPA1, RCL_CLIENT))
-               mdt_set_capainfo(info, 0, &info->mti_body->fid1,
-                           req_capsule_client_get(info->mti_pill, &RMF_CAPA1));
+               GOTO(out_unlock, rc);
 
        /* Change HSM flags depending on provided masks */
        if (hss->hss_valid & HSS_SETMASK)
@@ -275,9 +315,17 @@ int mdt_hsm_state_set(struct mdt_thread_info *info)
                if (!(ma->ma_hsm.mh_flags & HS_EXISTS)) {
                        CDEBUG(D_HSM, "Could not set an archive number for "
                               DFID "if HSM EXISTS flag is not set.\n",
-                              PFID(&info->mti_body->fid1));
-                       GOTO(out_ucred, rc);
+                              PFID(&info->mti_body->mbo_fid1));
+                       GOTO(out_unlock, rc);
+               }
+
+               /* Detect out-of range archive id */
+               if (hss->hss_archive_id > LL_HSM_MAX_ARCHIVE) {
+                       CDEBUG(D_HSM, "archive id %u exceeds maximum %zu.\n",
+                              hss->hss_archive_id, LL_HSM_MAX_ARCHIVE);
+                       GOTO(out_unlock, rc = -EINVAL);
                }
+
                ma->ma_hsm.mh_arch_id = hss->hss_archive_id;
        }
 
@@ -288,27 +336,29 @@ int mdt_hsm_state_set(struct mdt_thread_info *info)
         * LOST without ARCHIVED: cannot lost a non-archived file.
         */
        flags = ma->ma_hsm.mh_flags;
-       if (((flags & HS_DIRTY) && !(flags & HS_EXISTS)) ||
-           ((flags & HS_RELEASED) && (flags & HS_DIRTY)) ||
-           ((flags & HS_RELEASED) && !(flags & HS_ARCHIVED)) ||
-           ((flags & HS_LOST)     && !(flags & HS_ARCHIVED))) {
+       if ((flags & HS_DIRTY    && !(flags & HS_EXISTS)) ||
+           (flags & HS_RELEASED && flags & HS_DIRTY) ||
+           (flags & HS_RELEASED && !(flags & HS_ARCHIVED)) ||
+           (flags & HS_LOST     && !(flags & HS_ARCHIVED))) {
                CDEBUG(D_HSM, "Incompatible flag change on "DFID
                              "flags="LPX64"\n",
-                      PFID(&info->mti_body->fid1), flags);
-               GOTO(out_ucred, rc = -EINVAL);
+                      PFID(&info->mti_body->mbo_fid1), flags);
+               GOTO(out_unlock, rc = -EINVAL);
        }
 
        /* Save the modified flags */
        rc = mdt_hsm_attr_set(info, obj, &ma->ma_hsm);
        if (rc)
-               GOTO(out_ucred, rc);
+               GOTO(out_unlock, rc);
 
        EXIT;
 
+out_unlock:
+       mdt_object_unlock(info, obj, lh, 1);
 out_ucred:
        mdt_exit_ucred(info);
-out_obj:
-       mdt_object_unlock(info, obj, lh, 1);
+out:
+       mdt_thread_info_fini(info);
        return rc;
 }
 
@@ -318,50 +368,53 @@ out_obj:
  *
  * This is MDS_HSM_ACTION RPC handler.
  */
-int mdt_hsm_action(struct mdt_thread_info *info)
+int mdt_hsm_action(struct tgt_session_info *tsi)
 {
+       struct mdt_thread_info          *info;
        struct hsm_current_action       *hca;
        struct hsm_action_list          *hal = NULL;
        struct hsm_action_item          *hai;
-       int                              rc, len;
+       int                              hal_size;
+       int                              rc;
        ENTRY;
 
+       hca = req_capsule_server_get(tsi->tsi_pill,
+                                    &RMF_MDS_HSM_CURRENT_ACTION);
+       if (hca == NULL)
+               RETURN(err_serious(-EPROTO));
+
+       if (tsi->tsi_mdt_body == NULL)
+               RETURN(-EPROTO);
+
+       info = tsi2mdt_info(tsi);
        /* Only valid if client is remote */
        rc = mdt_init_ucred(info, (struct mdt_body *)info->mti_body);
        if (rc)
-               RETURN(rc = err_serious(rc));
-
-       if (req_capsule_get_size(info->mti_pill, &RMF_CAPA1, RCL_CLIENT))
-               mdt_set_capainfo(info, 0, &info->mti_body->fid1,
-                                req_capsule_client_get(info->mti_pill,
-                                                       &RMF_CAPA1));
-
-       hca = req_capsule_server_get(info->mti_pill,
-                                    &RMF_MDS_HSM_CURRENT_ACTION);
-       LASSERT(hca);
+               GOTO(out, rc = err_serious(rc));
 
        /* Coordinator information */
-       len = sizeof(*hal) + MTI_NAME_MAXLEN /* fsname */ +
-               cfs_size_round(sizeof(*hai));
+       hal_size = sizeof(*hal) +
+                  cfs_size_round(MTI_NAME_MAXLEN) /* fsname */ +
+                  cfs_size_round(sizeof(*hai));
 
-       OBD_ALLOC(hal, len);
+       MDT_HSM_ALLOC(hal, hal_size);
        if (hal == NULL)
-               GOTO(out_ucred, -ENOMEM);
+               GOTO(out_ucred, rc = -ENOMEM);
 
        hal->hal_version = HAL_VERSION;
-       hal->hal_archive_num = 0;
+       hal->hal_archive_id = 0;
        hal->hal_flags = 0;
-       obd_uuid2fsname(hal->hal_fsname, mdt2obd_dev(info->mti_mdt)->obd_name,
+       obd_uuid2fsname(hal->hal_fsname, mdt_obd_name(info->mti_mdt),
                        MTI_NAME_MAXLEN);
        hal->hal_count = 1;
-       hai = hai_zero(hal);
+       hai = hai_first(hal);
        hai->hai_action = HSMA_NONE;
        hai->hai_cookie = 0;
        hai->hai_gid = 0;
-       hai->hai_fid = info->mti_body->fid1;
+       hai->hai_fid = info->mti_body->mbo_fid1;
        hai->hai_len = sizeof(*hai);
 
-       rc = mdt_hsm_coordinator_get_actions(info, hal);
+       rc = mdt_hsm_get_actions(info, hal);
        if (rc)
                GOTO(out_free, rc);
 
@@ -390,7 +443,7 @@ int mdt_hsm_action(struct mdt_thread_info *info)
        default:
                hca->hca_action = HUA_NONE;
                CERROR("%s: Unknown hsm action: %d on "DFID"\n",
-                      mdt2obd_dev(info->mti_mdt)->obd_name,
+                      mdt_obd_name(info->mti_mdt),
                       hai->hai_action, PFID(&hai->hai_fid));
                break;
        }
@@ -399,8 +452,146 @@ int mdt_hsm_action(struct mdt_thread_info *info)
 
        EXIT;
 out_free:
-       OBD_FREE(hal, len);
+       MDT_HSM_FREE(hal, hal_size);
+out_ucred:
+       mdt_exit_ucred(info);
+out:
+       mdt_thread_info_fini(info);
+       return rc;
+}
+
+/* Return true if a FID is present in an action list. */
+static bool is_fid_in_hal(struct hsm_action_list *hal, const lustre_fid *fid)
+{
+       struct hsm_action_item *hai;
+       int i;
+
+       for (hai = hai_first(hal), i = 0;
+            i < hal->hal_count;
+            i++, hai = hai_next(hai)) {
+               if (lu_fid_eq(&hai->hai_fid, fid))
+                       return true;
+       }
+
+       return false;
+}
+
+/**
+ * Process the HSM actions described in a struct hsm_user_request.
+ *
+ * The action described in hur will be send to coordinator to be saved and
+ * processed later or either handled directly if hur.hur_action is HUA_RELEASE.
+ *
+ * This is MDS_HSM_REQUEST RPC handler.
+ */
+int mdt_hsm_request(struct tgt_session_info *tsi)
+{
+       struct mdt_thread_info          *info;
+       struct req_capsule              *pill = tsi->tsi_pill;
+       struct hsm_request              *hr;
+       struct hsm_user_item            *hui;
+       struct hsm_action_list          *hal;
+       struct hsm_action_item          *hai;
+       const void                      *data;
+       int                              hui_list_size;
+       int                              data_size;
+       enum hsm_copytool_action         action = HSMA_NONE;
+       __u64                            compound_id;
+       int                              hal_size, i, rc;
+       ENTRY;
+
+       hr = req_capsule_client_get(pill, &RMF_MDS_HSM_REQUEST);
+       hui = req_capsule_client_get(pill, &RMF_MDS_HSM_USER_ITEM);
+       data = req_capsule_client_get(pill, &RMF_GENERIC_DATA);
+
+       if (tsi->tsi_mdt_body == NULL || hr == NULL || hui == NULL || data == NULL)
+               RETURN(-EPROTO);
+
+       /* Sanity check. Nothing to do with an empty list */
+       if (hr->hr_itemcount == 0)
+               RETURN(0);
+
+       hui_list_size = req_capsule_get_size(pill, &RMF_MDS_HSM_USER_ITEM,
+                                            RCL_CLIENT);
+       if (hui_list_size < hr->hr_itemcount * sizeof(*hui))
+               RETURN(-EPROTO);
+
+       data_size = req_capsule_get_size(pill, &RMF_GENERIC_DATA, RCL_CLIENT);
+       if (data_size != hr->hr_data_len)
+               RETURN(-EPROTO);
+
+       info = tsi2mdt_info(tsi);
+       /* Only valid if client is remote */
+       rc = mdt_init_ucred(info, (struct mdt_body *)info->mti_body);
+       if (rc)
+               GOTO(out, rc);
+
+       switch (hr->hr_action) {
+       /* code to be removed in hsm1_merge and final patch */
+       case HUA_RELEASE:
+               CERROR("Release action is not working in hsm1_coord\n");
+               GOTO(out_ucred, rc = -EINVAL);
+               break;
+       /* end of code to be removed */
+       case HUA_ARCHIVE:
+               action = HSMA_ARCHIVE;
+               break;
+       case HUA_RESTORE:
+               action = HSMA_RESTORE;
+               break;
+       case HUA_REMOVE:
+               action = HSMA_REMOVE;
+               break;
+       case HUA_CANCEL:
+               action = HSMA_CANCEL;
+               break;
+       default:
+               CERROR("Unknown hsm action: %d\n", hr->hr_action);
+               GOTO(out_ucred, rc = -EINVAL);
+       }
+
+       hal_size = sizeof(*hal) + cfs_size_round(MTI_NAME_MAXLEN) /* fsname */ +
+                  (sizeof(*hai) + cfs_size_round(hr->hr_data_len)) *
+                  hr->hr_itemcount;
+
+       MDT_HSM_ALLOC(hal, hal_size);
+       if (hal == NULL)
+               GOTO(out_ucred, rc = -ENOMEM);
+
+       hal->hal_version = HAL_VERSION;
+       hal->hal_archive_id = hr->hr_archive_id;
+       hal->hal_flags = hr->hr_flags;
+       obd_uuid2fsname(hal->hal_fsname, mdt_obd_name(info->mti_mdt),
+                       MTI_NAME_MAXLEN);
+
+       hal->hal_count = 0;
+       hai = hai_first(hal);
+       for (i = 0; i < hr->hr_itemcount; i++, hai = hai_next(hai)) {
+               /* Get rid of duplicate entries. Otherwise we get
+                * duplicated work in the llog. */
+               if (is_fid_in_hal(hal, &hui[i].hui_fid))
+                       continue;
+
+               hai->hai_action = action;
+               hai->hai_cookie = 0;
+               hai->hai_gid = 0;
+               hai->hai_fid = hui[i].hui_fid;
+               hai->hai_extent = hui[i].hui_extent;
+               memcpy(hai->hai_data, data, hr->hr_data_len);
+               hai->hai_len = sizeof(*hai) + hr->hr_data_len;
+
+               hal->hal_count++;
+       }
+
+       rc = mdt_hsm_add_actions(info, hal, &compound_id);
+
+       MDT_HSM_FREE(hal, hal_size);
+
+       GOTO(out_ucred, rc);
+
 out_ucred:
        mdt_exit_ucred(info);
+out:
+       mdt_thread_info_fini(info);
        return rc;
 }