* Update on-disk HSM attributes.
*/
int mdt_hsm_attr_set(struct mdt_thread_info *info, struct mdt_object *obj,
- struct md_hsm *mh)
+ const struct md_hsm *mh)
{
struct md_object *next = mdt_object_child(obj);
struct lu_buf *buf = &info->mti_buf;
RETURN(rc);
}
+static inline bool mdt_hsm_is_admin(struct mdt_thread_info *info)
+{
+ bool is_admin;
+ int rc;
+
+ if (info->mti_body == NULL)
+ return false;
+
+ rc = mdt_init_ucred(info, (struct mdt_body *)info->mti_body);
+ if (rc < 0)
+ return false;
+
+ is_admin = md_capable(mdt_ucred(info), CFS_CAP_SYS_ADMIN);
+
+ mdt_exit_ucred(info);
+
+ return is_admin;
+}
+
/**
* Extract information coming from a copytool and asks coordinator to update
* a request status depending on the update content.
*/
int mdt_hsm_progress(struct mdt_thread_info *info)
{
- struct mdt_body *body;
struct hsm_progress_kernel *hpk;
int rc;
ENTRY;
- body = req_capsule_client_get(info->mti_pill, &RMF_MDT_BODY);
- if (body == NULL)
- RETURN(-EPROTO);
-
hpk = req_capsule_client_get(info->mti_pill, &RMF_MDS_HSM_PROGRESS);
- if (hpk == NULL)
+
+ if (info->mti_body == NULL || hpk == NULL)
RETURN(-EPROTO);
+ if (!mdt_hsm_is_admin(info))
+ RETURN(-EPERM);
+
hpk->hpk_errval = lustre_errno_ntoh(hpk->hpk_errval);
CDEBUG(D_HSM, "Progress on "DFID": len="LPU64" err=%d\n",
int mdt_hsm_ct_register(struct mdt_thread_info *info)
{
- struct mdt_body *body;
struct ptlrpc_request *req = mdt_info_req(info);
__u32 *archives;
int rc;
ENTRY;
- body = req_capsule_client_get(info->mti_pill, &RMF_MDT_BODY);
- if (body == NULL)
- RETURN(-EPROTO);
+ if (!mdt_hsm_is_admin(info))
+ RETURN(-EPERM);
archives = req_capsule_client_get(info->mti_pill, &RMF_MDS_HSM_ARCHIVE);
if (archives == NULL)
int mdt_hsm_ct_unregister(struct mdt_thread_info *info)
{
- struct mdt_body *body;
struct ptlrpc_request *req = mdt_info_req(info);
int rc;
ENTRY;
- body = req_capsule_client_get(info->mti_pill, &RMF_MDT_BODY);
- if (body == NULL)
+ if (info->mti_body == NULL)
RETURN(-EPROTO);
+ if (!mdt_hsm_is_admin(info))
+ RETURN(-EPERM);
+
/* XXX: directly include this function here? */
rc = mdt_hsm_agent_unregister(info, &req->rq_export->exp_client_uuid);
int rc;
ENTRY;
+ if (info->mti_body == NULL || obj == NULL)
+ RETURN(-EPROTO);
+
+ /* Only valid if client is remote */
+ rc = mdt_init_ucred(info, (struct mdt_body *)info->mti_body);
+ if (rc < 0)
+ RETURN(err_serious(rc));
+
lh = &info->mti_lh[MDT_LH_CHILD];
mdt_lock_reg_init(lh, LCK_PR);
rc = mdt_object_lock(info, obj, lh, MDS_INODELOCK_LOOKUP,
MDT_LOCAL_LOCK);
- if (rc)
- RETURN(rc);
-
- /* Only valid if client is remote */
- rc = mdt_init_ucred(info, (struct mdt_body *)info->mti_body);
- if (rc)
- GOTO(out_unlock, rc = err_serious(rc));
+ if (rc < 0)
+ GOTO(out_ucred, rc);
ma->ma_valid = 0;
ma->ma_need = MA_HSM;
rc = mdt_attr_get_complex(info, obj, ma);
if (rc)
- GOTO(out_ucred, rc);
+ GOTO(out_unlock, rc);
if (req_capsule_get_size(info->mti_pill, &RMF_CAPA1, RCL_CLIENT))
mdt_set_capainfo(info, 0, &info->mti_body->fid1,
hus = req_capsule_server_get(info->mti_pill, &RMF_HSM_USER_STATE);
if (hus == NULL)
- GOTO(out_ucred, rc = -EPROTO);
+ GOTO(out_unlock, rc = -EPROTO);
/* Current HSM flags */
hus->hus_states = ma->ma_hsm.mh_flags;
hus->hus_archive_id = ma->ma_hsm.mh_arch_id;
EXIT;
-out_ucred:
- mdt_exit_ucred(info);
out_unlock:
mdt_object_unlock(info, obj, lh, 1);
+out_ucred:
+ mdt_exit_ucred(info);
+
return rc;
}
__u64 flags;
ENTRY;
- lh = &info->mti_lh[MDT_LH_CHILD];
- mdt_lock_reg_init(lh, LCK_PW);
- rc = mdt_object_lock(info, obj, lh, MDS_INODELOCK_LOOKUP,
- MDT_LOCAL_LOCK);
- if (rc)
- RETURN(rc);
+ hss = req_capsule_client_get(info->mti_pill, &RMF_HSM_STATE_SET);
+
+ if (info->mti_body == NULL || obj == NULL || hss == NULL)
+ RETURN(-EPROTO);
/* Only valid if client is remote */
rc = mdt_init_ucred(info, (struct mdt_body *)info->mti_body);
- if (rc)
- GOTO(out_obj, rc = err_serious(rc));
+ if (rc < 0)
+ RETURN(err_serious(rc));
- /* Read current HSM info */
- ma->ma_valid = 0;
- ma->ma_need = MA_HSM;
- rc = mdt_attr_get_complex(info, obj, ma);
- if (rc)
+ lh = &info->mti_lh[MDT_LH_CHILD];
+ mdt_lock_reg_init(lh, LCK_PW);
+ rc = mdt_object_lock(info, obj, lh, MDS_INODELOCK_LOOKUP |
+ MDS_INODELOCK_XATTR, MDT_LOCAL_LOCK);
+ if (rc < 0)
GOTO(out_ucred, rc);
- hss = req_capsule_client_get(info->mti_pill, &RMF_HSM_STATE_SET);
- if (hss == NULL)
- GOTO(out_ucred, rc = -EPROTO);
-
if (req_capsule_get_size(info->mti_pill, &RMF_CAPA1, RCL_CLIENT))
mdt_set_capainfo(info, 0, &info->mti_body->fid1,
req_capsule_client_get(info->mti_pill, &RMF_CAPA1));
+ /* Non-root users are forbidden to set or clear flags which are
+ * NOT defined in HSM_USER_MASK. */
+ if (((hss->hss_setmask | hss->hss_clearmask) & ~HSM_USER_MASK) &&
+ !md_capable(mdt_ucred(info), CFS_CAP_SYS_ADMIN))
+ GOTO(out_unlock, rc = -EPERM);
+
+ /* Read current HSM info */
+ ma->ma_valid = 0;
+ ma->ma_need = MA_HSM;
+ rc = mdt_attr_get_complex(info, obj, ma);
+ if (rc)
+ GOTO(out_unlock, rc);
+
/* Change HSM flags depending on provided masks */
if (hss->hss_valid & HSS_SETMASK)
ma->ma_hsm.mh_flags |= hss->hss_setmask;
CDEBUG(D_HSM, "Could not set an archive number for "
DFID "if HSM EXISTS flag is not set.\n",
PFID(&info->mti_body->fid1));
- GOTO(out_ucred, rc);
+ GOTO(out_unlock, rc);
}
ma->ma_hsm.mh_arch_id = hss->hss_archive_id;
}
* LOST without ARCHIVED: cannot lost a non-archived file.
*/
flags = ma->ma_hsm.mh_flags;
- if (((flags & HS_DIRTY) && !(flags & HS_EXISTS)) ||
- ((flags & HS_RELEASED) && (flags & HS_DIRTY)) ||
- ((flags & HS_RELEASED) && !(flags & HS_ARCHIVED)) ||
- ((flags & HS_LOST) && !(flags & HS_ARCHIVED))) {
+ if ((flags & HS_DIRTY && !(flags & HS_EXISTS)) ||
+ (flags & HS_RELEASED && flags & HS_DIRTY) ||
+ (flags & HS_RELEASED && !(flags & HS_ARCHIVED)) ||
+ (flags & HS_LOST && !(flags & HS_ARCHIVED))) {
CDEBUG(D_HSM, "Incompatible flag change on "DFID
"flags="LPX64"\n",
PFID(&info->mti_body->fid1), flags);
/* Save the modified flags */
rc = mdt_hsm_attr_set(info, obj, &ma->ma_hsm);
if (rc)
- GOTO(out_ucred, rc);
+ GOTO(out_unlock, rc);
EXIT;
+out_unlock:
+ mdt_object_unlock(info, obj, lh, 1);
out_ucred:
mdt_exit_ucred(info);
-out_obj:
- mdt_object_unlock(info, obj, lh, 1);
+
return rc;
}
int rc;
ENTRY;
+ hca = req_capsule_server_get(info->mti_pill,
+ &RMF_MDS_HSM_CURRENT_ACTION);
+
+ if (info->mti_body == NULL || hca == NULL)
+ RETURN(-EPROTO);
+
/* Only valid if client is remote */
rc = mdt_init_ucred(info, (struct mdt_body *)info->mti_body);
if (rc)
req_capsule_client_get(info->mti_pill,
&RMF_CAPA1));
- hca = req_capsule_server_get(info->mti_pill,
- &RMF_MDS_HSM_CURRENT_ACTION);
- if (hca == NULL)
- GOTO(out_ucred, rc = -EPROTO);
-
/* Coordinator information */
hal_size = sizeof(*hal) +
cfs_size_round(MTI_NAME_MAXLEN) /* fsname */ +
obd_uuid2fsname(hal->hal_fsname, mdt_obd_name(info->mti_mdt),
MTI_NAME_MAXLEN);
hal->hal_count = 1;
- hai = hai_zero(hal);
+ hai = hai_first(hal);
hai->hai_action = HSMA_NONE;
hai->hai_cookie = 0;
hai->hai_gid = 0;
int mdt_hsm_request(struct mdt_thread_info *info)
{
struct req_capsule *pill = info->mti_pill;
- struct mdt_body *body;
struct hsm_request *hr;
struct hsm_user_item *hui;
struct hsm_action_list *hal;
int hal_size, i, rc;
ENTRY;
- body = req_capsule_client_get(pill, &RMF_MDT_BODY);
hr = req_capsule_client_get(pill, &RMF_MDS_HSM_REQUEST);
hui = req_capsule_client_get(pill, &RMF_MDS_HSM_USER_ITEM);
data = req_capsule_client_get(pill, &RMF_GENERIC_DATA);
- if (body == NULL || hr == NULL || hui == NULL || data == NULL)
+ if (info->mti_body == NULL || hr == NULL || hui == NULL || data == NULL)
RETURN(-EPROTO);
/* Sanity check. Nothing to do with an empty list */
RETURN(-EPROTO);
/* Only valid if client is remote */
- rc = mdt_init_ucred(info, body);
+ rc = mdt_init_ucred(info, (struct mdt_body *)info->mti_body);
if (rc)
RETURN(err_serious(rc));
MTI_NAME_MAXLEN);
hal->hal_count = hr->hr_itemcount;
- hai = hai_zero(hal);
+ hai = hai_first(hal);
for (i = 0; i < hr->hr_itemcount; i++, hai = hai_next(hai)) {
hai->hai_action = action;
hai->hai_cookie = 0;
}
rc = mdt_hsm_add_actions(info, hal, &compound_id);
- /* ENODATA error code is needed only for implicit requests */
- if (rc == -ENODATA)
- rc = 0;
MDT_HSM_FREE(hal, hal_size);
git://git.whamcloud.com / fs / lustre-release.git / blobdiff