Whamcloud - gitweb
LU-7623 Update obd iocontrol methods with __user attribute
[fs/lustre-release.git] / lustre / mdt / mdt_handler.c
index 216cb4d..9ffd9c7 100644 (file)
 #define DEBUG_SUBSYSTEM S_MDS
 
 #include <linux/module.h>
-/*
- * struct OBD_{ALLOC,FREE}*()
- */
-#include <obd_support.h>
+
+#include <dt_object.h>
+#include <lustre_acl.h>
+#include <lustre_export.h>
 #include <lustre_ioctl.h>
-/* struct ptlrpc_request */
+#include <lustre_lfsck.h>
+#include <lustre_log.h>
 #include <lustre_net.h>
-/* struct obd_export */
-#include <lustre_export.h>
-/* struct obd_device */
-#include <obd.h>
-/* lu2dt_dev() */
-#include <dt_object.h>
+#include <lustre_nodemap.h>
 #include <lustre_mds.h>
-#include <lustre_log.h>
-#include "mdt_internal.h"
-#include <lustre_acl.h>
 #include <lustre_param.h>
 #include <lustre_quota.h>
-#include <lustre_lfsck.h>
-#include <lustre_nodemap.h>
+#include <lustre_swab.h>
+#include <obd.h>
+#include <obd_support.h>
+
+#include "mdt_internal.h"
+
 
 static unsigned int max_mod_rpcs_per_client = 8;
 CFS_MODULE_PARM(max_mod_rpcs_per_client, "i", uint, 0644,
@@ -173,6 +170,7 @@ void mdt_lock_pdo_init(struct mdt_lock_handle *lh, enum ldlm_mode lock_mode,
                       const struct lu_name *lname)
 {
        lh->mlh_reg_mode = lock_mode;
+       lh->mlh_pdo_mode = LCK_MINMODE;
        lh->mlh_rreg_mode = lock_mode;
        lh->mlh_type = MDT_PDO_LOCK;
 
@@ -1555,7 +1553,7 @@ static int mdt_getattr_name(struct tgt_session_info *tsi)
        repbody->mbo_eadatasize = 0;
        repbody->mbo_aclsize = 0;
 
-        rc = mdt_init_ucred(info, reqbody);
+        rc = mdt_init_ucred_intent_getattr(info, reqbody);
         if (unlikely(rc))
                 GOTO(out_shrink, rc);
 
@@ -1576,7 +1574,7 @@ out_shrink:
 }
 
 static int mdt_iocontrol(unsigned int cmd, struct obd_export *exp, int len,
-                         void *karg, void *uarg);
+                        void *karg, void __user *uarg);
 
 static int mdt_set_info(struct tgt_session_info *tsi)
 {
@@ -2158,11 +2156,14 @@ static void mdt_device_commit_async(const struct lu_env *env,
 {
        struct dt_device *dt = mdt->mdt_bottom;
        int rc;
+       ENTRY;
 
        rc = dt->dd_ops->dt_commit_async(env, dt);
        if (unlikely(rc != 0))
                CWARN("%s: async commit start failed: rc = %d\n",
                      mdt_obd_name(mdt), rc);
+       atomic_inc(&mdt->mdt_async_commit_count);
+       EXIT;
 }
 
 /**
@@ -2218,17 +2219,22 @@ int mdt_blocking_ast(struct ldlm_lock *lock, struct ldlm_lock_desc *desc,
 
         if (flag == LDLM_CB_CANCELING)
                 RETURN(0);
+
         lock_res_and_lock(lock);
         if (lock->l_blocking_ast != mdt_blocking_ast) {
                 unlock_res_and_lock(lock);
                 RETURN(0);
         }
-        if (mdt_cos_is_enabled(mdt) &&
-            lock->l_req_mode & (LCK_PW | LCK_EX) &&
-            lock->l_blocking_lock != NULL &&
-            lock->l_client_cookie != lock->l_blocking_lock->l_client_cookie) {
-                mdt_set_lock_sync(lock);
-        }
+       if (lock->l_req_mode & (LCK_PW | LCK_EX) &&
+           lock->l_blocking_lock != NULL) {
+               if (mdt_cos_is_enabled(mdt) &&
+                   lock->l_client_cookie !=
+                   lock->l_blocking_lock->l_client_cookie)
+                       mdt_set_lock_sync(lock);
+               else if (mdt_slc_is_enabled(mdt) &&
+                        ldlm_is_cos_incompat(lock->l_blocking_lock))
+                       mdt_set_lock_sync(lock);
+       }
         rc = ldlm_blocking_ast_nocheck(lock);
 
         /* There is no lock conflict if l_blocking_lock == NULL,
@@ -2249,17 +2255,30 @@ int mdt_blocking_ast(struct ldlm_lock *lock, struct ldlm_lock_desc *desc,
         RETURN(rc);
 }
 
-/* Used for cross-MDT lock */
+/*
+ * Blocking AST for cross-MDT lock
+ *
+ * Discard lock from uncommitted_slc_locks and cancel it.
+ *
+ * \param lock the lock which blocks a request or cancelling lock
+ * \param desc unused
+ * \param data unused
+ * \param flag indicates whether this cancelling or blocking callback
+ * \retval     0 on success
+ * \retval     negative number on error
+ */
 int mdt_remote_blocking_ast(struct ldlm_lock *lock, struct ldlm_lock_desc *desc,
                            void *data, int flag)
 {
        struct lustre_handle lockh;
        int               rc;
+       ENTRY;
 
        switch (flag) {
        case LDLM_CB_BLOCKING:
                ldlm_lock2handle(lock, &lockh);
-               rc = ldlm_cli_cancel(&lockh, LCF_ASYNC);
+               rc = ldlm_cli_cancel(&lockh,
+                       ldlm_is_atomic_cb(lock) ? 0 : LCF_ASYNC);
                if (rc < 0) {
                        CDEBUG(D_INODE, "ldlm_cli_cancel: %d\n", rc);
                        RETURN(rc);
@@ -2267,10 +2286,14 @@ int mdt_remote_blocking_ast(struct ldlm_lock *lock, struct ldlm_lock_desc *desc,
                break;
        case LDLM_CB_CANCELING:
                LDLM_DEBUG(lock, "Revoke remote lock\n");
+               /* discard slc lock here so that it can be cleaned anytime,
+                * especially for cleanup_resource() */
+               tgt_discard_slc_lock(lock);
                break;
        default:
                LBUG();
        }
+
        RETURN(0);
 }
 
@@ -2344,12 +2367,12 @@ int mdt_remote_object_lock(struct mdt_thread_info *mti, struct mdt_object *o,
 static int mdt_object_local_lock(struct mdt_thread_info *info,
                                 struct mdt_object *o,
                                 struct mdt_lock_handle *lh, __u64 ibits,
-                                bool nonblock)
+                                bool nonblock, bool cos_incompat)
 {
        struct ldlm_namespace *ns = info->mti_mdt->mdt_namespace;
        union ldlm_policy_data *policy = &info->mti_policy;
        struct ldlm_res_id *res_id = &info->mti_res_id;
-       __u64 dlmflags;
+       __u64 dlmflags = 0;
        int rc;
        ENTRY;
 
@@ -2358,6 +2381,14 @@ static int mdt_object_local_lock(struct mdt_thread_info *info,
         LASSERT(lh->mlh_reg_mode != LCK_MINMODE);
         LASSERT(lh->mlh_type != MDT_NUL_LOCK);
 
+       if (cos_incompat) {
+               LASSERT(lh->mlh_reg_mode == LCK_PW ||
+                       lh->mlh_reg_mode == LCK_EX);
+               dlmflags |= LDLM_FL_COS_INCOMPAT;
+       } else if (mdt_cos_is_enabled(info->mti_mdt)) {
+               dlmflags |= LDLM_FL_COS_ENABLED;
+       }
+
        /* Only enqueue LOOKUP lock for remote object */
        if (mdt_object_remote(o))
                LASSERT(ibits == MDS_INODELOCK_LOOKUP);
@@ -2377,7 +2408,7 @@ static int mdt_object_local_lock(struct mdt_thread_info *info,
         memset(policy, 0, sizeof(*policy));
         fid_build_reg_res_name(mdt_object_fid(o), res_id);
 
-       dlmflags = LDLM_FL_ATOMIC_CB;
+       dlmflags |= LDLM_FL_ATOMIC_CB;
        if (nonblock)
                dlmflags |= LDLM_FL_BLOCK_NOWAIT;
 
@@ -2434,15 +2465,18 @@ out_unlock:
 
 static int
 mdt_object_lock_internal(struct mdt_thread_info *info, struct mdt_object *o,
-                        struct mdt_lock_handle *lh, __u64 ibits,
-                        bool nonblock)
+                        struct mdt_lock_handle *lh, __u64 ibits, bool nonblock,
+                        bool cos_incompat)
 {
        struct mdt_lock_handle *local_lh = NULL;
        int rc;
        ENTRY;
 
-       if (!mdt_object_remote(o))
-               return mdt_object_local_lock(info, o, lh, ibits, nonblock);
+       if (!mdt_object_remote(o)) {
+               rc = mdt_object_local_lock(info, o, lh, ibits, nonblock,
+                                          cos_incompat);
+               RETURN(rc);
+       }
 
        /* XXX do not support PERM/LAYOUT/XATTR lock for remote object yet */
        ibits &= ~(MDS_INODELOCK_PERM | MDS_INODELOCK_LAYOUT |
@@ -2450,9 +2484,8 @@ mdt_object_lock_internal(struct mdt_thread_info *info, struct mdt_object *o,
 
        /* Only enqueue LOOKUP lock for remote object */
        if (ibits & MDS_INODELOCK_LOOKUP) {
-               rc = mdt_object_local_lock(info, o, lh,
-                                          MDS_INODELOCK_LOOKUP,
-                                          nonblock);
+               rc = mdt_object_local_lock(info, o, lh, MDS_INODELOCK_LOOKUP,
+                                          nonblock, cos_incompat);
                if (rc != ELDLM_OK)
                        RETURN(rc);
 
@@ -2490,7 +2523,16 @@ mdt_object_lock_internal(struct mdt_thread_info *info, struct mdt_object *o,
 int mdt_object_lock(struct mdt_thread_info *info, struct mdt_object *o,
                    struct mdt_lock_handle *lh, __u64 ibits)
 {
-       return mdt_object_lock_internal(info, o, lh, ibits, false);
+       return mdt_object_lock_internal(info, o, lh, ibits, false, false);
+}
+
+int mdt_reint_object_lock(struct mdt_thread_info *info, struct mdt_object *o,
+                         struct mdt_lock_handle *lh, __u64 ibits,
+                         bool cos_incompat)
+{
+       LASSERT(lh->mlh_reg_mode == LCK_PW || lh->mlh_reg_mode == LCK_EX);
+       return mdt_object_lock_internal(info, o, lh, ibits, false,
+                                       cos_incompat);
 }
 
 int mdt_object_lock_try(struct mdt_thread_info *info, struct mdt_object *o,
@@ -2499,7 +2541,22 @@ int mdt_object_lock_try(struct mdt_thread_info *info, struct mdt_object *o,
        struct mdt_lock_handle tmp = *lh;
        int rc;
 
-       rc = mdt_object_lock_internal(info, o, &tmp, ibits, true);
+       rc = mdt_object_lock_internal(info, o, &tmp, ibits, true, false);
+       if (rc == 0)
+               *lh = tmp;
+
+       return rc == 0;
+}
+
+int mdt_reint_object_lock_try(struct mdt_thread_info *info,
+                             struct mdt_object *o, struct mdt_lock_handle *lh,
+                             __u64 ibits, bool cos_incompat)
+{
+       struct mdt_lock_handle tmp = *lh;
+       int rc;
+
+       LASSERT(lh->mlh_reg_mode == LCK_PW || lh->mlh_reg_mode == LCK_EX);
+       rc = mdt_object_lock_internal(info, o, &tmp, ibits, true, cos_incompat);
        if (rc == 0)
                *lh = tmp;
 
@@ -2532,24 +2589,27 @@ static void mdt_save_lock(struct mdt_thread_info *info, struct lustre_handle *h,
                        struct mdt_device *mdt = info->mti_mdt;
                        struct ldlm_lock *lock = ldlm_handle2lock(h);
                        struct ptlrpc_request *req = mdt_info_req(info);
-                       int no_ack = 0;
+                       int cos;
+
+                       cos = (mdt_cos_is_enabled(mdt) ||
+                              mdt_slc_is_enabled(mdt));
 
                        LASSERTF(lock != NULL, "no lock for cookie "LPX64"\n",
                                 h->cookie);
+
                        /* there is no request if mdt_object_unlock() is called
                         * from mdt_export_cleanup()->mdt_add_dirty_flag() */
                        if (likely(req != NULL)) {
                                CDEBUG(D_HA, "request = %p reply state = %p"
                                       " transno = "LPD64"\n", req,
                                       req->rq_reply_state, req->rq_transno);
-                               if (mdt_cos_is_enabled(mdt)) {
-                                       no_ack = 1;
+                               if (cos) {
                                        ldlm_lock_downgrade(lock, LCK_COS);
                                        mode = LCK_COS;
                                }
-                               ptlrpc_save_lock(req, h, mode, no_ack);
+                               ptlrpc_save_lock(req, h, mode, cos);
                        } else {
-                               ldlm_lock_decref(h, mode);
+                               mdt_fid_unlock(h, mode);
                        }
                         if (mdt_is_lock_sync(lock)) {
                                 CDEBUG(D_HA, "found sync-lock,"
@@ -2566,6 +2626,41 @@ static void mdt_save_lock(struct mdt_thread_info *info, struct lustre_handle *h,
 }
 
 /**
+ * Save cross-MDT lock in uncommitted_slc_locks
+ *
+ * Keep the lock referenced until transaction commit happens or release the lock
+ * immediately depending on input parameters.
+ *
+ * \param info thead info object
+ * \param h lock handle
+ * \param mode lock mode
+ * \param decref force immediate lock releasing
+ */
+static void mdt_save_remote_lock(struct mdt_thread_info *info,
+                                struct lustre_handle *h, enum ldlm_mode mode,
+                                int decref)
+{
+       ENTRY;
+
+       if (lustre_handle_is_used(h)) {
+               if (decref || !info->mti_has_trans ||
+                   !(mode & (LCK_PW | LCK_EX))) {
+                       ldlm_lock_decref_and_cancel(h, mode);
+               } else {
+                       struct ldlm_lock *lock = ldlm_handle2lock(h);
+                       struct ptlrpc_request *req = mdt_info_req(info);
+
+                       LASSERT(req != NULL);
+                       tgt_save_slc_lock(lock, req->rq_transno);
+                       ldlm_lock_decref(h, mode);
+               }
+               h->cookie = 0ull;
+       }
+
+       EXIT;
+}
+
+/**
  * Unlock mdt object.
  *
  * Immeditely release the regular lock and the PDO lock or save the
@@ -2578,17 +2673,15 @@ static void mdt_save_lock(struct mdt_thread_info *info, struct lustre_handle *h,
  * \param decref force immediate lock releasing
  */
 void mdt_object_unlock(struct mdt_thread_info *info, struct mdt_object *o,
-                       struct mdt_lock_handle *lh, int decref)
+                      struct mdt_lock_handle *lh, int decref)
 {
-        ENTRY;
-
-        mdt_save_lock(info, &lh->mlh_pdo_lh, lh->mlh_pdo_mode, decref);
-        mdt_save_lock(info, &lh->mlh_reg_lh, lh->mlh_reg_mode, decref);
+       ENTRY;
 
-       if (lustre_handle_is_used(&lh->mlh_rreg_lh))
-               ldlm_lock_decref(&lh->mlh_rreg_lh, lh->mlh_rreg_mode);
+       mdt_save_lock(info, &lh->mlh_pdo_lh, lh->mlh_pdo_mode, decref);
+       mdt_save_lock(info, &lh->mlh_reg_lh, lh->mlh_reg_mode, decref);
+       mdt_save_remote_lock(info, &lh->mlh_rreg_lh, lh->mlh_rreg_mode, decref);
 
-        EXIT;
+       EXIT;
 }
 
 struct mdt_object *mdt_object_find_lock(struct mdt_thread_info *info,
@@ -3171,6 +3264,7 @@ static int mdt_intent_layout(enum mdt_it_code opcode,
        struct layout_intent *layout;
        struct lu_fid *fid;
        struct mdt_object *obj = NULL;
+       int layout_size = 0;
        int rc = 0;
        ENTRY;
 
@@ -3180,6 +3274,16 @@ static int mdt_intent_layout(enum mdt_it_code opcode,
                RETURN(-EINVAL);
        }
 
+       layout = req_capsule_client_get(info->mti_pill, &RMF_LAYOUT_INTENT);
+       if (layout == NULL)
+               RETURN(-EPROTO);
+
+       if (layout->li_opc != LAYOUT_INTENT_ACCESS) {
+               CERROR("%s: Unsupported layout intent opc %d\n",
+                      mdt_obd_name(info->mti_mdt), layout->li_opc);
+               RETURN(-EINVAL);
+       }
+
        fid = &info->mti_tmp_fid2;
        fid_extract_from_res_name(fid, &(*lockp)->l_resource->lr_name);
 
@@ -3188,40 +3292,33 @@ static int mdt_intent_layout(enum mdt_it_code opcode,
 
        obj = mdt_object_find(info->mti_env, info->mti_mdt, fid);
        if (IS_ERR(obj))
-               RETURN(PTR_ERR(obj));
+               GOTO(out, rc = PTR_ERR(obj));
 
        if (mdt_object_exists(obj) && !mdt_object_remote(obj)) {
-               /* get the length of lsm */
-               rc = mdt_attr_get_eabuf_size(info, obj);
-               if (rc < 0) {
-                       mdt_object_put(info->mti_env, obj);
-                       RETURN(rc);
-               }
+               layout_size = mdt_attr_get_eabuf_size(info, obj);
+               if (layout_size < 0)
+                       GOTO(out_obj, rc = layout_size);
 
-               if (rc > info->mti_mdt->mdt_max_mdsize)
-                       info->mti_mdt->mdt_max_mdsize = rc;
+               if (layout_size > info->mti_mdt->mdt_max_mdsize)
+                       info->mti_mdt->mdt_max_mdsize = layout_size;
        }
 
-       mdt_object_put(info->mti_env, obj);
-
        (*lockp)->l_lvb_type = LVB_T_LAYOUT;
-       req_capsule_set_size(info->mti_pill, &RMF_DLM_LVB, RCL_SERVER, rc);
+       req_capsule_set_size(info->mti_pill, &RMF_DLM_LVB, RCL_SERVER,
+                            layout_size);
        rc = req_capsule_server_pack(info->mti_pill);
-       if (rc != 0)
-               RETURN(-EINVAL);
+       GOTO(out_obj, rc);
+
+out_obj:
+       mdt_object_put(info->mti_env, obj);
 
-       if (lustre_handle_is_used(&lhc->mlh_reg_lh))
+       if (rc == 0 && lustre_handle_is_used(&lhc->mlh_reg_lh))
                rc = mdt_intent_lock_replace(info, lockp, lhc, flags);
 
-       layout = req_capsule_client_get(info->mti_pill, &RMF_LAYOUT_INTENT);
-       LASSERT(layout != NULL);
-       if (layout->li_opc == LAYOUT_INTENT_ACCESS)
-               /* return to normal/resent ldlm handling */
-               RETURN(rc);
+out:
+       lhc->mlh_reg_lh.cookie = 0;
 
-       CERROR("%s: Unsupported layout intent (%d)\n",
-               mdt_obd_name(info->mti_mdt), layout->li_opc);
-       RETURN(-EINVAL);
+       return rc;
 }
 
 static int mdt_intent_reint(enum mdt_it_code opcode,
@@ -3278,8 +3375,9 @@ static int mdt_intent_reint(enum mdt_it_code opcode,
        rep->lock_policy_res2 = clear_serious(rc);
 
         if (rep->lock_policy_res2 == -ENOENT &&
-            mdt_get_disposition(rep, DISP_LOOKUP_NEG))
-                rep->lock_policy_res2 = 0;
+           mdt_get_disposition(rep, DISP_LOOKUP_NEG) &&
+           !mdt_get_disposition(rep, DISP_OPEN_CREATE))
+               rep->lock_policy_res2 = 0;
 
        lhc->mlh_reg_lh.cookie = 0ull;
         if (rc == -ENOTCONN || rc == -ENODEV ||
@@ -4358,6 +4456,9 @@ static int mdt_init0(const struct lu_env *env, struct mdt_device *m,
                 LASSERT(num);
                 node_id = simple_strtol(num, NULL, 10);
                obd->u.obt.obt_magic = OBT_MAGIC;
+               if (lsi->lsi_lmd != NULL &&
+                   lsi->lsi_lmd->lmd_flags & LMD_FLG_SKIP_LFSCK)
+                       m->mdt_skip_lfsck = 1;
        }
 
        m->mdt_squash.rsi_uid = 0;
@@ -4369,6 +4470,9 @@ static int mdt_init0(const struct lu_env *env, struct mdt_device *m,
        m->mdt_enable_remote_dir = 0;
        m->mdt_enable_remote_dir_gid = 0;
 
+       atomic_set(&m->mdt_mds_mds_conns, 0);
+       atomic_set(&m->mdt_async_commit_count, 0);
+
        m->mdt_lu_dev.ld_ops = &mdt_lu_ops;
        m->mdt_lu_dev.ld_obd = obd;
        /* Set this lu_device to obd for error handling purposes. */
@@ -4998,6 +5102,18 @@ static int mdt_export_cleanup(struct obd_export *exp)
         RETURN(rc);
 }
 
+static inline void mdt_enable_slc(struct mdt_device *mdt)
+{
+       if (mdt->mdt_lut.lut_sync_lock_cancel == NEVER_SYNC_ON_CANCEL)
+               mdt->mdt_lut.lut_sync_lock_cancel = BLOCKING_SYNC_ON_CANCEL;
+}
+
+static inline void mdt_disable_slc(struct mdt_device *mdt)
+{
+       if (mdt->mdt_lut.lut_sync_lock_cancel == BLOCKING_SYNC_ON_CANCEL)
+               mdt->mdt_lut.lut_sync_lock_cancel = NEVER_SYNC_ON_CANCEL;
+}
+
 static int mdt_obd_disconnect(struct obd_export *exp)
 {
         int rc;
@@ -5006,6 +5122,14 @@ static int mdt_obd_disconnect(struct obd_export *exp)
         LASSERT(exp);
         class_export_get(exp);
 
+       if ((exp_connect_flags(exp) & OBD_CONNECT_MDS_MDS) &&
+           !(exp_connect_flags(exp) & OBD_CONNECT_LIGHTWEIGHT)) {
+               struct mdt_device *mdt = mdt_dev(exp->exp_obd->obd_lu_dev);
+
+               if (atomic_dec_and_test(&mdt->mdt_mds_mds_conns))
+                       mdt_disable_slc(mdt);
+       }
+
        rc = server_disconnect_export(exp);
        if (rc != 0)
                CDEBUG(D_IOCTL, "server disconnect error: rc = %d\n", rc);
@@ -5036,6 +5160,12 @@ static int mdt_obd_connect(const struct lu_env *env,
 
        mdt = mdt_dev(obd->obd_lu_dev);
 
+       if ((data->ocd_connect_flags & OBD_CONNECT_MDS_MDS) &&
+           !(data->ocd_connect_flags & OBD_CONNECT_LIGHTWEIGHT)) {
+               atomic_inc(&mdt->mdt_mds_mds_conns);
+               mdt_enable_slc(mdt);
+       }
+
        /*
         * first, check whether the stack is ready to handle requests
         * XXX: probably not very appropriate method is used now
@@ -5580,7 +5710,7 @@ static int mdt_ioc_version_get(struct mdt_thread_info *mti, void *karg)
 
 /* ioctls on obd dev */
 static int mdt_iocontrol(unsigned int cmd, struct obd_export *exp, int len,
-                         void *karg, void *uarg)
+                        void *karg, void __user *uarg)
 {
         struct lu_env      env;
         struct obd_device *obd = exp->exp_obd;
@@ -5603,7 +5733,7 @@ static int mdt_iocontrol(unsigned int cmd, struct obd_export *exp, int len,
                 break;
        case OBD_IOC_ABORT_RECOVERY:
                CERROR("%s: Aborting recovery for device\n", mdt_obd_name(mdt));
-               obd->obd_force_abort_recovery = 1;
+               obd->obd_abort_recovery = 1;
                target_stop_recovery_thread(obd);
                rc = 0;
                break;
@@ -5676,18 +5806,21 @@ static int mdt_iocontrol(unsigned int cmd, struct obd_export *exp, int len,
 static int mdt_postrecov(const struct lu_env *env, struct mdt_device *mdt)
 {
        struct lu_device *ld = md2lu_dev(mdt->mdt_child);
-       struct lfsck_start_param lsp;
        int rc;
        ENTRY;
 
-       lsp.lsp_start = NULL;
-       lsp.lsp_index_valid = 0;
-       rc = mdt->mdt_child->md_ops->mdo_iocontrol(env, mdt->mdt_child,
-                                                  OBD_IOC_START_LFSCK,
-                                                  0, &lsp);
-       if (rc != 0 && rc != -EALREADY)
-               CWARN("%s: auto trigger paused LFSCK failed: rc = %d\n",
-                     mdt_obd_name(mdt), rc);
+       if (!mdt->mdt_skip_lfsck) {
+               struct lfsck_start_param lsp;
+
+               lsp.lsp_start = NULL;
+               lsp.lsp_index_valid = 0;
+               rc = mdt->mdt_child->md_ops->mdo_iocontrol(env, mdt->mdt_child,
+                                                          OBD_IOC_START_LFSCK,
+                                                          0, &lsp);
+               if (rc != 0 && rc != -EALREADY)
+                       CWARN("%s: auto trigger paused LFSCK failed: rc = %d\n",
+                             mdt_obd_name(mdt), rc);
+       }
 
        rc = ld->ld_ops->ldo_recovery_complete(env, ld);
        RETURN(rc);