*/
/*
* This file is part of Lustre, http://www.lustre.org/
- * Lustre is a trademark of Sun Microsystems, Inc.
*
* lustre/mdd/mdd_object.c
*
static const struct lu_object_operations mdd_lu_obj_ops;
+struct mdd_object_user {
+ struct list_head mou_list; /**< linked off mod_users */
+ u64 mou_open_flags; /**< open mode by client */
+ __u64 mou_uidgid; /**< uid_gid on client */
+ int mou_opencount; /**< # opened */
+ ktime_t mou_deniednext; /**< time of next access denied
+ * notfication
+ */
+};
+
static int mdd_xattr_get(const struct lu_env *env,
struct md_object *obj, struct lu_buf *buf,
const char *name);
+static int mdd_changelog_data_store_by_fid(const struct lu_env *env,
+ struct mdd_device *mdd,
+ enum changelog_rec_type type,
+ enum changelog_rec_flags clf_flags,
+ const struct lu_fid *fid,
+ const struct lu_fid *pfid,
+ const char *xattr_name,
+ struct thandle *handle);
+
+static inline bool has_prefix(const char *str, const char *prefix);
+
+
+static u32 flags_helper(u64 open_flags)
+{
+ u32 open_mode = 0;
+
+ if (open_flags & MDS_FMODE_EXEC) {
+ open_mode = MDS_FMODE_EXEC;
+ } else {
+ if (open_flags & MDS_FMODE_READ)
+ open_mode = MDS_FMODE_READ;
+ if (open_flags &
+ (MDS_FMODE_WRITE | MDS_OPEN_TRUNC | MDS_OPEN_APPEND))
+ open_mode |= MDS_FMODE_WRITE;
+ }
+
+ return open_mode;
+}
+
+/** Allocate/init a user and its sub-structures.
+ *
+ * \param flags [IN]
+ * \param uid [IN]
+ * \param gid [IN]
+ * \retval mou [OUT] success valid structure
+ * \retval mou [OUT]
+ */
+static struct mdd_object_user *mdd_obj_user_alloc(u64 open_flags,
+ uid_t uid, gid_t gid)
+{
+ struct mdd_object_user *mou;
+
+ ENTRY;
+
+ OBD_SLAB_ALLOC_PTR(mou, mdd_object_kmem);
+ if (mou == NULL)
+ RETURN(ERR_PTR(-ENOMEM));
+
+ mou->mou_open_flags = open_flags;
+ mou->mou_uidgid = ((__u64)uid << 32) | gid;
+ mou->mou_opencount = 0;
+ mou->mou_deniednext = ktime_set(0, 0);
+
+ RETURN(mou);
+}
+
+/**
+ * Free a user and its sub-structures.
+ *
+ * \param mou [IN] user to be freed.
+ */
+static void mdd_obj_user_free(struct mdd_object_user *mou)
+{
+ OBD_SLAB_FREE_PTR(mou, mdd_object_kmem);
+}
+
+/**
+ * Find if UID/GID already has this file open
+ *
+ * Caller should have write-locked \param mdd_obj.
+ * \param mdd_obj [IN] mdd_obj
+ * \param uid [IN] client uid
+ * \param gid [IN] client gid
+ * \retval user pointer or NULL if not found
+ */
+static
+struct mdd_object_user *mdd_obj_user_find(struct mdd_object *mdd_obj,
+ uid_t uid, gid_t gid,
+ u64 open_flags)
+{
+ struct mdd_object_user *mou;
+ __u64 uidgid;
+
+ ENTRY;
+
+ uidgid = ((__u64)uid << 32) | gid;
+ list_for_each_entry(mou, &mdd_obj->mod_users, mou_list) {
+ if (mou->mou_uidgid == uidgid &&
+ flags_helper(mou->mou_open_flags) ==
+ flags_helper(open_flags))
+ RETURN(mou);
+ }
+ RETURN(NULL);
+}
+
+/**
+ * Add a user to the list of openers for this file
+ *
+ * Caller should have write-locked \param mdd_obj.
+ * \param mdd_obj [IN] mdd_obj
+ * \param mou [IN] user
+ * \retval 0 success
+ * \retval -ve failure
+ */
+static int mdd_obj_user_add(struct mdd_object *mdd_obj,
+ struct mdd_object_user *mou,
+ bool denied)
+{
+ struct mdd_device *mdd = mdd_obj2mdd_dev(mdd_obj);
+ struct mdd_object_user *tmp;
+ __u32 uid = mou->mou_uidgid >> 32;
+ __u32 gid = mou->mou_uidgid & ((1UL << 32) - 1);
+
+ ENTRY;
+ tmp = mdd_obj_user_find(mdd_obj, uid, gid, mou->mou_open_flags);
+ if (tmp != NULL)
+ RETURN(-EEXIST);
+
+ list_add_tail(&mou->mou_list, &mdd_obj->mod_users);
+
+ if (denied)
+ /* next 'access denied' notification cannot happen before
+ * mou_deniednext
+ */
+ mou->mou_deniednext =
+ ktime_add(ktime_get(),
+ ktime_set(mdd->mdd_cl.mc_deniednext, 0));
+ else
+ mou->mou_opencount++;
+
+ RETURN(0);
+}
+/**
+ * Remove UID from the list
+ *
+ * Caller should have write-locked \param mdd_obj.
+ * \param mdd_obj [IN] mdd_obj
+ * \param uid [IN] user
+ * \retval -ve failure
+ */
+static int mdd_obj_user_remove(struct mdd_object *mdd_obj,
+ struct mdd_object_user *mou)
+{
+ ENTRY;
+
+ if (mou == NULL)
+ RETURN(-ENOENT);
+
+ list_del_init(&mou->mou_list);
+
+ mdd_obj_user_free(mou);
+
+ RETURN(0);
+}
int mdd_la_get(const struct lu_env *env, struct mdd_object *obj,
struct lu_attr *la)
{
return rc;
}
- if (la->la_valid & LA_FLAGS &&
- la->la_flags & LUSTRE_ORPHAN_FL)
+ if (la->la_valid & LA_FLAGS && la->la_flags & LUSTRE_ORPHAN_FL)
obj->mod_flags |= ORPHAN_OBJ | DEAD_OBJ;
return 0;
struct mdd_thread_info *mdd_env_info(const struct lu_env *env)
{
- struct mdd_thread_info *info;
-
- lu_env_refill((struct lu_env *)env);
- info = lu_context_key_get(&env->le_ctx, &mdd_thread_key);
- LASSERT(info != NULL);
- return info;
+ return lu_env_info(env, &mdd_thread_key);
}
struct lu_buf *mdd_buf_get(const struct lu_env *env, void *area, ssize_t len)
struct lu_device *d)
{
struct mdd_object *mdd_obj;
+ struct lu_object *o;
OBD_SLAB_ALLOC_PTR_GFP(mdd_obj, mdd_object_kmem, GFP_NOFS);
- if (mdd_obj != NULL) {
- struct lu_object *o;
-
- o = mdd2lu_obj(mdd_obj);
- lu_object_init(o, NULL, d);
- mdd_obj->mod_obj.mo_ops = &mdd_obj_ops;
- mdd_obj->mod_obj.mo_dir_ops = &mdd_dir_ops;
- mdd_obj->mod_count = 0;
- o->lo_ops = &mdd_lu_obj_ops;
- return o;
- } else {
+ if (!mdd_obj)
return NULL;
- }
+
+ o = mdd2lu_obj(mdd_obj);
+ lu_object_init(o, NULL, d);
+ mdd_obj->mod_obj.mo_ops = &mdd_obj_ops;
+ mdd_obj->mod_obj.mo_dir_ops = &mdd_dir_ops;
+ mdd_obj->mod_count = 0;
+ o->lo_ops = &mdd_lu_obj_ops;
+ INIT_LIST_HEAD(&mdd_obj->mod_users);
+
+ return o;
}
static int mdd_object_init(const struct lu_env *env, struct lu_object *o,
static void mdd_object_free(const struct lu_env *env, struct lu_object *o)
{
- struct mdd_object *mdd = lu2mdd_obj(o);
+ struct mdd_object *mdd = lu2mdd_obj(o);
+ struct mdd_object_user *mou, *tmp2;
+
+ /* free user list */
+ list_for_each_entry_safe(mou, tmp2, &mdd->mod_users, mou_list) {
+ list_del(&mou->mou_list);
+ mdd_obj_user_free(mou);
+ }
- lu_object_fini(o);
+ lu_object_fini(o);
+ /* mdd doesn't contain an lu_object_header, so don't need call_rcu */
OBD_SLAB_FREE_PTR(mdd, mdd_object_kmem);
}
struct md_object *obj, struct lu_buf *buf,
const char *name)
{
- struct mdd_object *mdd_obj = md2mdd_obj(obj);
- int rc;
+ struct mdd_object *mdd_obj = md2mdd_obj(obj);
+ struct mdd_device *mdd;
+ int rc;
- ENTRY;
+ ENTRY;
- if (mdd_object_exists(mdd_obj) == 0) {
- CERROR("%s: object "DFID" not found: rc = -2\n",
- mdd_obj_dev_name(mdd_obj),PFID(mdd_object_fid(mdd_obj)));
- return -ENOENT;
- }
+ if (mdd_object_exists(mdd_obj) == 0) {
+ CERROR("%s: object "DFID" not found: rc = -2\n",
+ mdd_obj_dev_name(mdd_obj),
+ PFID(mdd_object_fid(mdd_obj)));
+ return -ENOENT;
+ }
/* If the object has been destroyed, then do not get LMVEA, because
* it needs to load stripes from the iteration of the master object,
strcmp(name, XATTR_NAME_LINK) == 0))
RETURN(-ENOENT);
- mdd_read_lock(env, mdd_obj, MOR_TGT_CHILD);
+ mdd_read_lock(env, mdd_obj, DT_TGT_CHILD);
rc = mdo_xattr_get(env, mdd_obj, buf, name);
- mdd_read_unlock(env, mdd_obj);
+ mdd_read_unlock(env, mdd_obj);
- RETURN(rc);
+ mdd = mdo2mdd(obj);
+
+ /* record only getting user xattrs and acls */
+ if (rc >= 0 && buf->lb_buf &&
+ mdd_changelog_enabled(env, mdd, CL_GETXATTR) &&
+ (has_prefix(name, XATTR_USER_PREFIX) ||
+ has_prefix(name, XATTR_NAME_POSIX_ACL_ACCESS) ||
+ has_prefix(name, XATTR_NAME_POSIX_ACL_DEFAULT))) {
+ struct thandle *handle;
+ int rc2;
+
+ LASSERT(mdd_object_fid(mdd_obj) != NULL);
+
+ handle = mdd_trans_create(env, mdd);
+ if (IS_ERR(handle))
+ RETURN(PTR_ERR(handle));
+
+ rc2 = mdd_declare_changelog_store(env, mdd, CL_GETXATTR, NULL,
+ NULL, handle);
+ if (rc2)
+ GOTO(stop, rc2);
+
+ rc2 = mdd_trans_start(env, mdd, handle);
+ if (rc2)
+ GOTO(stop, rc2);
+
+ rc2 = mdd_changelog_data_store_by_fid(env, mdd, CL_GETXATTR, 0,
+ mdd_object_fid(mdd_obj),
+ NULL, name, handle);
+
+stop:
+ rc2 = mdd_trans_stop(env, mdd, rc2, handle);
+ if (rc2)
+ rc = rc2;
+ }
+
+ RETURN(rc);
}
/*
LASSERT(next != NULL);
LASSERT(next->do_body_ops != NULL);
LASSERT(next->do_body_ops->dbo_read != NULL);
- mdd_read_lock(env, mdd_obj, MOR_TGT_CHILD);
+ mdd_read_lock(env, mdd_obj, DT_TGT_CHILD);
rc = dt_read(env, next, buf, &pos);
mdd_read_unlock(env, mdd_obj);
RETURN(rc);
ENTRY;
- mdd_read_lock(env, mdd_obj, MOR_TGT_CHILD);
+ mdd_read_lock(env, mdd_obj, DT_TGT_CHILD);
rc = mdo_xattr_list(env, mdd_obj, buf);
mdd_read_unlock(env, mdd_obj);
ENTRY;
rc = mdo_attr_set(env, obj, attr, handle);
-#ifdef CONFIG_FS_POSIX_ACL
+#ifdef CONFIG_LUSTRE_FS_POSIX_ACL
if (!rc && (attr->la_valid & LA_MODE) && needacl)
rc = mdd_acl_chmod(env, obj, attr->la_mode, handle);
#endif
RETURN(rc);
}
+
+static bool is_project_state_change(const struct lu_attr *oattr,
+ struct lu_attr *la)
+{
+ if (la->la_valid & LA_PROJID &&
+ oattr->la_projid != la->la_projid)
+ return true;
+
+ if ((la->la_valid & LA_FLAGS) &&
+ (la->la_flags & LUSTRE_PROJINHERIT_FL) !=
+ (oattr->la_flags & LUSTRE_PROJINHERIT_FL))
+ return true;
+
+ return false;
+}
+
/*
* This gives the same functionality as the code between
* sys_chmod and inode_setattr
*/
static int mdd_fix_attr(const struct lu_env *env, struct mdd_object *obj,
const struct lu_attr *oattr, struct lu_attr *la,
- const unsigned long flags)
+ const struct md_attr *ma)
{
struct lu_ucred *uc;
int rc = 0;
+ const unsigned long flags = ma->ma_attr_flags;
+
ENTRY;
if (!la->la_valid)
if (uc == NULL)
RETURN(0);
+ if (is_project_state_change(oattr, la)) {
+ if (!md_capable(uc, CAP_SYS_RESOURCE) &&
+ !lustre_in_group_p(uc, ma->ma_enable_chprojid_gid) &&
+ !(ma->ma_enable_chprojid_gid == -1 &&
+ mdd_permission_internal(env, obj, oattr, MAY_WRITE)))
+ RETURN(-EPERM);
+ }
+
if (la->la_valid == LA_CTIME) {
if (!(flags & MDS_PERM_BYPASS))
/* This is only for set ctime when rename's source is
RETURN(rc);
}
- if (la->la_valid == LA_ATIME) {
- /* This is an atime-only attribute update for close RPCs. */
- if (la->la_atime < (oattr->la_atime +
+ if (flags & MDS_CLOSE_UPDATE_TIMES &&
+ la->la_valid & (LA_ATIME | LA_MTIME | LA_CTIME)) {
+ /* This is an atime/mtime/ctime attribute update for
+ * close RPCs.
+ */
+ if (la->la_valid & LA_ATIME &&
+ la->la_atime <= (oattr->la_atime +
mdd_obj2mdd_dev(obj)->mdd_atime_diff))
la->la_valid &= ~LA_ATIME;
+ if (la->la_valid & LA_CTIME && la->la_ctime <= oattr->la_ctime)
+ la->la_valid &= ~LA_CTIME;
+ if (la->la_valid & LA_MTIME && la->la_mtime <= oattr->la_mtime)
+ la->la_valid &= ~LA_MTIME;
RETURN(0);
}
(LUSTRE_IMMUTABLE_FL | LUSTRE_APPEND_FL);
if ((uc->uc_fsuid != oattr->la_uid) &&
- !md_capable(uc, CFS_CAP_FOWNER))
+ !md_capable(uc, CAP_FOWNER))
RETURN(-EPERM);
/* The IMMUTABLE and APPEND_ONLY flags can
* only be changed by the relevant capability. */
if ((oldflags ^ newflags) &&
- !md_capable(uc, CFS_CAP_LINUX_IMMUTABLE))
+ !md_capable(uc, CAP_LINUX_IMMUTABLE))
RETURN(-EPERM);
- if (!S_ISDIR(oattr->la_mode))
+ if (!S_ISDIR(oattr->la_mode)) {
la->la_flags &= ~(LUSTRE_DIRSYNC_FL | LUSTRE_TOPDIR_FL);
+ } else if (la->la_flags & LUSTRE_ENCRYPT_FL) {
+ /* when trying to add encryption flag on dir,
+ * make sure it is empty
+ */
+ rc = mdd_dir_is_empty(env, obj);
+ if (rc)
+ RETURN(rc);
+ rc = 0;
+ }
}
if (oattr->la_flags & (LUSTRE_IMMUTABLE_FL | LUSTRE_APPEND_FL) &&
if ((la->la_valid & (LA_MTIME | LA_ATIME | LA_CTIME)) &&
!(la->la_valid & ~(LA_MTIME | LA_ATIME | LA_CTIME))) {
if ((uc->uc_fsuid != oattr->la_uid) &&
- !md_capable(uc, CFS_CAP_FOWNER)) {
+ !md_capable(uc, CAP_FOWNER)) {
rc = mdd_permission_internal(env, obj, oattr,
MAY_WRITE);
if (rc)
if (la->la_valid & LA_MODE) {
if (!(flags & MDS_PERM_BYPASS) &&
(uc->uc_fsuid != oattr->la_uid) &&
- !md_capable(uc, CFS_CAP_FOWNER))
+ !md_capable(uc, CAP_FOWNER))
RETURN(-EPERM);
if (la->la_mode == (umode_t) -1)
/* Also check the setgid bit! */
if (!lustre_in_group_p(uc, (la->la_valid & LA_GID) ?
la->la_gid : oattr->la_gid) &&
- !md_capable(uc, CFS_CAP_FSETID))
+ !md_capable(uc, CAP_FSETID))
la->la_mode &= ~S_ISGID;
} else {
la->la_mode = oattr->la_mode;
la->la_uid = oattr->la_uid;
if (((uc->uc_fsuid != oattr->la_uid) ||
(la->la_uid != oattr->la_uid)) &&
- !md_capable(uc, CFS_CAP_CHOWN))
+ !md_capable(uc, CAP_CHOWN))
RETURN(-EPERM);
/* If the user or group of a non-directory has been
if (((uc->uc_fsuid != oattr->la_uid) ||
((la->la_gid != oattr->la_gid) &&
!lustre_in_group_p(uc, la->la_gid))) &&
- !md_capable(uc, CFS_CAP_CHOWN))
+ !md_capable(uc, CAP_CHOWN))
RETURN(-EPERM);
/* Likewise, if the user or group of a non-directory
}
static int mdd_changelog_data_store_by_fid(const struct lu_env *env,
- struct mdd_device *mdd,
- enum changelog_rec_type type, int flags,
- const struct lu_fid *fid,
- struct thandle *handle)
+ struct mdd_device *mdd,
+ enum changelog_rec_type type,
+ enum changelog_rec_flags clf_flags,
+ const struct lu_fid *fid,
+ const struct lu_fid *pfid,
+ const char *xattr_name,
+ struct thandle *handle)
{
const struct lu_ucred *uc = lu_ucred(env);
+ enum changelog_rec_extra_flags xflags = CLFE_INVALID;
struct llog_changelog_rec *rec;
struct lu_buf *buf;
int reclen;
- int xflags = CLFE_INVALID;
int rc;
- flags = (flags & CLF_FLAGMASK) | CLF_VERSION | CLF_EXTRA_FLAGS;
+ clf_flags = (clf_flags & CLF_FLAGMASK) | CLF_VERSION | CLF_EXTRA_FLAGS;
if (uc) {
if (uc->uc_jobid[0] != '\0')
- flags |= CLF_JOBID;
+ clf_flags |= CLF_JOBID;
xflags |= CLFE_UIDGID;
xflags |= CLFE_NID;
}
- if (type == CL_OPEN)
+ if (type == CL_OPEN || type == CL_DN_OPEN)
xflags |= CLFE_OPEN;
+ if (type == CL_SETXATTR || type == CL_GETXATTR)
+ xflags |= CLFE_XATTR;
reclen = llog_data_len(LLOG_CHANGELOG_HDR_SZ +
- changelog_rec_offset(flags & CLF_SUPPORTED,
+ changelog_rec_offset(clf_flags & CLF_SUPPORTED,
xflags & CLFE_SUPPORTED));
- buf = lu_buf_check_and_alloc(&mdd_env_info(env)->mti_big_buf, reclen);
+ buf = lu_buf_check_and_alloc(&mdd_env_info(env)->mti_chlg_buf, reclen);
if (buf->lb_buf == NULL)
RETURN(-ENOMEM);
rec = buf->lb_buf;
rec->cr_hdr.lrh_len = reclen;
- rec->cr.cr_flags = flags;
+ rec->cr.cr_flags = clf_flags;
rec->cr.cr_type = (__u32)type;
rec->cr.cr_tfid = *fid;
+ if (pfid)
+ rec->cr.cr_pfid = *pfid;
rec->cr.cr_namelen = 0;
- if (flags & CLF_JOBID)
+ if (clf_flags & CLF_JOBID)
mdd_changelog_rec_ext_jobid(&rec->cr, uc->uc_jobid);
- if (flags & CLF_EXTRA_FLAGS) {
+ if (clf_flags & CLF_EXTRA_FLAGS) {
mdd_changelog_rec_ext_extra_flags(&rec->cr, xflags);
if (xflags & CLFE_UIDGID)
mdd_changelog_rec_extra_uidgid(&rec->cr,
if (xflags & CLFE_NID)
mdd_changelog_rec_extra_nid(&rec->cr, uc->uc_nid);
if (xflags & CLFE_OPEN)
- mdd_changelog_rec_extra_omode(&rec->cr, flags);
+ mdd_changelog_rec_extra_omode(&rec->cr, clf_flags);
+ if (xflags & CLFE_XATTR) {
+ if (xattr_name == NULL)
+ RETURN(-EINVAL);
+ mdd_changelog_rec_extra_xattr(&rec->cr, xattr_name);
+ }
}
rc = mdd_changelog_store(env, mdd, rec, handle);
* want the change to commit without the log entry.
* \param mdd_obj - mdd_object of change
* \param handle - transaction handle
+ * \param pfid - parent FID for CL_MTIME changelogs
*/
int mdd_changelog_data_store(const struct lu_env *env, struct mdd_device *mdd,
- enum changelog_rec_type type, int flags,
- struct mdd_object *mdd_obj, struct thandle *handle)
+ enum changelog_rec_type type,
+ enum changelog_rec_flags clf_flags,
+ struct mdd_object *mdd_obj, struct thandle *handle,
+ const struct lu_fid *pfid)
{
int rc;
LASSERT(mdd_obj != NULL);
LASSERT(handle != NULL);
- /* Not recording */
- if (!(mdd->mdd_cl.mc_flags & CLM_ON))
- RETURN(0);
- if ((mdd->mdd_cl.mc_mask & (1 << type)) == 0)
+ if (!mdd_changelog_enabled(env, mdd, type))
RETURN(0);
if (mdd_is_volatile_obj(mdd_obj))
RETURN(0);
}
- rc = mdd_changelog_data_store_by_fid(env, mdd, type, flags,
- mdo2fid(mdd_obj), handle);
+ rc = mdd_changelog_data_store_by_fid(env, mdd, type, clf_flags,
+ mdd_object_fid(mdd_obj), pfid,
+ NULL, handle);
if (rc == 0)
mdd_obj->mod_cltime = ktime_get();
RETURN(rc);
}
+int mdd_changelog_data_store_xattr(const struct lu_env *env,
+ struct mdd_device *mdd,
+ enum changelog_rec_type type,
+ enum changelog_rec_flags clf_flags,
+ struct mdd_object *mdd_obj,
+ const char *xattr_name,
+ struct thandle *handle)
+{
+ int rc;
+
+ LASSERT(mdd_obj != NULL);
+ LASSERT(handle != NULL);
+
+ if (!mdd_changelog_enabled(env, mdd, type))
+ RETURN(0);
+
+ if (mdd_is_volatile_obj(mdd_obj))
+ RETURN(0);
+
+ if ((type >= CL_MTIME) && (type <= CL_ATIME) &&
+ ktime_before(mdd->mdd_cl.mc_starttime, mdd_obj->mod_cltime)) {
+ /* Don't need multiple updates in this log */
+ /* Don't check under lock - no big deal if we get an extra
+ * entry
+ */
+ RETURN(0);
+ }
+
+ rc = mdd_changelog_data_store_by_fid(env, mdd, type, clf_flags,
+ mdd_object_fid(mdd_obj), NULL,
+ xattr_name, handle);
+ if (rc == 0)
+ mdd_obj->mod_cltime = ktime_get();
+
+ RETURN(rc);
+}
+
+/* only the bottom CLF_FLAGSHIFT bits of @flags are stored in the record,
+ * except for open flags have a dedicated record to store 32 bits of flags */
static int mdd_changelog(const struct lu_env *env, enum changelog_rec_type type,
- int flags, struct md_device *m, const struct lu_fid *fid)
+ enum changelog_rec_flags clf_flags,
+ struct md_device *m, const struct lu_fid *fid)
{
struct thandle *handle;
struct mdd_device *mdd = lu2mdd_dev(&m->md_lu_dev);
int rc;
ENTRY;
- /* Not recording */
- if (!(mdd->mdd_cl.mc_flags & CLM_ON))
- RETURN(0);
- if (!(mdd->mdd_cl.mc_mask & (1 << type)))
- RETURN(0);
-
LASSERT(fid != NULL);
+ /* We'll check this again below, but we check now before we
+ * start a transaction. */
+ if (!mdd_changelog_enabled(env, mdd, type))
+ RETURN(0);
+
handle = mdd_trans_create(env, mdd);
if (IS_ERR(handle))
RETURN(PTR_ERR(handle));
- rc = mdd_declare_changelog_store(env, mdd, NULL, NULL, handle);
+ rc = mdd_declare_changelog_store(env, mdd, type, NULL, NULL, handle);
if (rc)
GOTO(stop, rc);
if (rc)
GOTO(stop, rc);
- rc = mdd_changelog_data_store_by_fid(env, mdd, type, flags,
- fid, handle);
+ rc = mdd_changelog_data_store_by_fid(env, mdd, type, clf_flags,
+ fid, NULL, NULL, handle);
stop:
rc = mdd_trans_stop(env, mdd, rc, handle);
* atime and ctime are independent.) */
static int mdd_attr_set_changelog(const struct lu_env *env,
struct md_object *obj, struct thandle *handle,
- __u64 valid)
+ const struct lu_fid *pfid, __u64 valid)
{
struct mdd_device *mdd = mdo2mdd(obj);
int bits, type = 0;
- bits = (valid & LA_SIZE) ? 1 << CL_TRUNC : 0;
- bits |= (valid & ~(LA_CTIME|LA_MTIME|LA_ATIME)) ? 1 << CL_SETATTR : 0;
- bits |= (valid & LA_MTIME) ? 1 << CL_MTIME : 0;
- bits |= (valid & LA_CTIME) ? 1 << CL_CTIME : 0;
- bits |= (valid & LA_ATIME) ? 1 << CL_ATIME : 0;
+ bits = (valid & LA_SIZE) ? BIT(CL_TRUNC) : 0;
+ bits |= (valid & ~(LA_CTIME|LA_MTIME|LA_ATIME)) ? BIT(CL_SETATTR) : 0;
+ bits |= (valid & LA_MTIME) ? BIT(CL_MTIME) : 0;
+ bits |= (valid & LA_CTIME) ? BIT(CL_CTIME) : 0;
+ bits |= (valid & LA_ATIME) ? BIT(CL_ATIME) : 0;
bits = bits & mdd->mdd_cl.mc_mask;
/* This is an implementation limit rather than a protocol limit */
- CLASSERT(CL_LAST <= sizeof(int) * 8);
+ BUILD_BUG_ON(CL_LAST > sizeof(int) * 8);
if (bits == 0)
return 0;
/* The record type is the lowest non-masked set bit */
type = __ffs(bits);
- /* FYI we only store the first CLF_FLAGMASK bits of la_valid */
- return mdd_changelog_data_store(env, mdd, type, (int)valid,
- md2mdd_obj(obj), handle);
+ /* XXX: we only store the low CLF_FLAGMASK bits of la_valid */
+ return mdd_changelog_data_store(env, mdd, type, valid, md2mdd_obj(obj),
+ handle, pfid);
}
static int mdd_declare_attr_set(const struct lu_env *env,
if (rc)
return rc;
-#ifdef CONFIG_FS_POSIX_ACL
+#ifdef CONFIG_LUSTRE_FS_POSIX_ACL
if (attr->la_valid & LA_MODE) {
- mdd_read_lock(env, obj, MOR_TGT_CHILD);
+ mdd_read_lock(env, obj, DT_TGT_CHILD);
rc = mdo_xattr_get(env, obj, &LU_BUF_NULL,
XATTR_NAME_ACL_ACCESS);
mdd_read_unlock(env, obj);
}
#endif
- rc = mdd_declare_changelog_store(env, mdd, NULL, NULL, handle);
+ rc = mdd_declare_changelog_store(env, mdd, CL_SETXATTR, NULL, NULL,
+ handle);
return rc;
}
/*
* LU-3671
+ * LU-7239
*
* permission changes may require sync operation, to mitigate performance
* impact, only do this for dir and when permission is reduced.
if (!S_ISDIR(old->la_mode))
return false;
- if (new->la_valid & (LA_UID | LA_GID))
+ if (new->la_valid & LA_UID && old->la_uid != new->la_uid)
return true;
- if (new->la_valid & LA_MODE &&
- new->la_mode & (S_ISUID | S_ISGID | S_ISVTX))
+ if (new->la_valid & LA_GID && old->la_gid != new->la_gid)
return true;
- if ((new->la_valid & LA_MODE) &&
- ((new->la_mode & old->la_mode) & S_IRWXUGO) !=
- (old->la_mode & S_IRWXUGO))
- return true;
+ if (new->la_valid & LA_MODE) {
+ /* turned on sticky bit */
+ if (!(old->la_mode & S_ISVTX) && (new->la_mode & S_ISVTX))
+ return true;
+
+ /* set-GID has no impact on what is allowed, not checked */
+
+ /* turned off setuid bit, or one of rwx for someone */
+ if (((new->la_mode & old->la_mode) & (0777 | S_ISUID)) !=
+ (old->la_mode & (0777 | S_ISUID)))
+ return true;
+ }
return false;
}
+static inline __u64 mdd_lmm_dom_size(void *buf)
+{
+ struct lov_mds_md *lmm = buf;
+ struct lov_comp_md_v1 *comp_v1;
+ struct lov_mds_md *v1;
+ __u32 off;
+
+ if (lmm == NULL)
+ return 0;
+
+ if (le32_to_cpu(lmm->lmm_magic) != LOV_MAGIC_COMP_V1)
+ return 0;
+
+ comp_v1 = (struct lov_comp_md_v1 *)lmm;
+ off = le32_to_cpu(comp_v1->lcm_entries[0].lcme_offset);
+ v1 = (struct lov_mds_md *)((char *)comp_v1 + off);
+
+ /* DoM entry is the first entry always */
+ if (lov_pattern(le32_to_cpu(v1->lmm_pattern)) == LOV_PATTERN_MDT)
+ return le64_to_cpu(comp_v1->lcm_entries[0].lcme_extent.e_end);
+
+ return 0;
+}
+
/* set attr and LOV EA at once, return updated attr */
int mdd_attr_set(const struct lu_env *env, struct md_object *obj,
const struct md_attr *ma)
{
struct mdd_object *mdd_obj = md2mdd_obj(obj);
struct mdd_device *mdd = mdo2mdd(obj);
- struct thandle *handle;
+ struct thandle *handle = NULL;
struct lu_attr *la_copy = &mdd_env_info(env)->mti_la_for_fix;
struct lu_attr *attr = MDD_ENV_VAR(env, cattr);
const struct lu_attr *la = &ma->ma_attr;
+ struct lu_ucred *uc;
+ bool chrgrp_by_unprivileged_user = false;
int rc;
ENTRY;
RETURN(rc);
*la_copy = ma->ma_attr;
- rc = mdd_fix_attr(env, mdd_obj, attr, la_copy, ma->ma_attr_flags);
+ rc = mdd_fix_attr(env, mdd_obj, attr, la_copy, ma);
if (rc)
RETURN(rc);
/* no need to setattr anymore */
if (la_copy->la_valid == 0) {
- CDEBUG(D_INODE, "%s: no valid attribute on "DFID", previous"
- "valid is %#llx\n", mdd2obd_dev(mdd)->obd_name,
- PFID(mdo2fid(mdd_obj)), la->la_valid);
+ CDEBUG(D_INODE,
+ "%s: no valid attribute on "DFID", previous was %#llx\n",
+ mdd_obj_dev_name(mdd_obj),
+ PFID(mdd_object_fid(mdd_obj)), la->la_valid);
RETURN(0);
}
- handle = mdd_trans_create(env, mdd);
- if (IS_ERR(handle))
- RETURN(PTR_ERR(handle));
+ /* If an unprivileged user changes group of some file,
+ * the setattr operation will be processed synchronously to
+ * honor the quota limit of the corresponding group. see LU-5152 */
+ uc = lu_ucred_check(env);
+ if (S_ISREG(attr->la_mode) && la->la_valid & LA_GID &&
+ la->la_gid != attr->la_gid && uc != NULL && uc->uc_fsuid != 0) {
+ /* LU-10048: disable synchronous chgrp operation for it will
+ * cause deadlock between MDT and OST.
+ la_copy->la_valid |= LA_FLAGS;
+ la_copy->la_flags |= LUSTRE_SET_SYNC_FL;
+ */
+ chrgrp_by_unprivileged_user = true;
+
+ /* Flush the possible existing client setattr requests to OSTs
+ * to keep the order with the current setattr operation that
+ * will be sent directly to OSTs. see LU-5152 */
+ /* LU-11303 disable sync as this is too heavyweight.
+ * This should be replaced with a sync only for the object
+ * being modified here, not the whole filesystem.
+ rc = dt_sync(env, mdd->mdd_child);
+ if (rc)
+ GOTO(out, rc);
+ */
+ }
+
+ handle = mdd_trans_create(env, mdd);
+ if (IS_ERR(handle)) {
+ rc = PTR_ERR(handle);
+ handle = NULL;
+
+ GOTO(out, rc);
+ }
rc = mdd_declare_attr_set(env, mdd, mdd_obj, la_copy, handle);
- if (rc)
- GOTO(stop, rc);
+ if (rc)
+ GOTO(out, rc);
- rc = mdd_trans_start(env, mdd, handle);
- if (rc)
- GOTO(stop, rc);
+ rc = mdd_trans_start(env, mdd, handle);
+ if (rc)
+ GOTO(out, rc);
- if (mdd->mdd_sync_permission && permission_needs_sync(attr, la))
+ if (!chrgrp_by_unprivileged_user && mdd->mdd_sync_permission &&
+ permission_needs_sync(attr, la))
handle->th_sync = 1;
if (la->la_valid & (LA_MTIME | LA_CTIME))
CDEBUG(D_INODE, "setting mtime %llu, ctime %llu\n",
la->la_mtime, la->la_ctime);
- mdd_write_lock(env, mdd_obj, MOR_TGT_CHILD);
- if (la_copy->la_valid & LA_FLAGS)
- rc = mdd_attr_set_internal(env, mdd_obj, la_copy, handle, 1);
- else if (la_copy->la_valid) /* setattr */
+ mdd_write_lock(env, mdd_obj, DT_TGT_CHILD);
+
+ /* LU-10509: setattr of LA_SIZE should be skipped case of DOM,
+ * otherwise following truncate will do nothing and truncated
+ * data may be read again. This is a quick fix until LU-11033
+ * will be resolved.
+ */
+ if (la_copy->la_valid & LA_SIZE) {
+ struct lu_buf *lov_buf = mdd_buf_get(env, NULL, 0);
+
+ rc = mdd_stripe_get(env, mdd_obj, lov_buf, XATTR_NAME_LOV);
+ if (rc) {
+ rc = 0;
+ } else {
+ if (mdd_lmm_dom_size(lov_buf->lb_buf) > 0)
+ la_copy->la_valid &= ~LA_SIZE;
+ lu_buf_free(lov_buf);
+ }
+ }
+
+ if (la_copy->la_valid) {
rc = mdd_attr_set_internal(env, mdd_obj, la_copy, handle, 1);
+
+ if (rc == -EDQUOT && la_copy->la_flags & LUSTRE_SET_SYNC_FL) {
+ /* rollback to the original gid */
+ la_copy->la_flags &= ~LUSTRE_SET_SYNC_FL;
+ la_copy->la_gid = attr->la_gid;
+ mdd_attr_set_internal(env, mdd_obj, la_copy, handle, 1);
+ }
+ }
mdd_write_unlock(env, mdd_obj);
+out:
if (rc == 0)
- rc = mdd_attr_set_changelog(env, obj, handle,
+ rc = mdd_attr_set_changelog(env, obj, handle, &ma->ma_pfid,
la_copy->la_valid);
- GOTO(stop, rc);
-
-stop:
- rc = mdd_trans_stop(env, mdd, rc, handle);
+ if (handle != NULL)
+ rc = mdd_trans_stop(env, mdd, rc, handle);
return rc;
}
* can write attributes. */
if (S_ISDIR(attr->la_mode) && (attr->la_mode & S_ISVTX) &&
(uc->uc_fsuid != attr->la_uid) &&
- !md_capable(uc, CFS_CAP_FOWNER))
- RETURN(-EPERM);
- } else {
- if ((uc->uc_fsuid != attr->la_uid) &&
- !md_capable(uc, CFS_CAP_FOWNER))
+ !md_capable(uc, CAP_FOWNER))
RETURN(-EPERM);
+ } else if (strcmp(name, XATTR_NAME_SOM) != 0 &&
+ (uc->uc_fsuid != attr->la_uid) &&
+ !md_capable(uc, CAP_FOWNER)) {
+ RETURN(-EPERM);
}
RETURN(0);
*
* \param[in] xattr_name Full extended attribute name.
*
- * \return The type of changelog to use, or -1 if no changelog is to be emitted.
+ * \return type of changelog to use, or CL_NONE if no changelog is to be emitted
*/
static enum changelog_rec_type
mdd_xattr_changelog_type(const struct lu_env *env, struct mdd_device *mdd,
{
/* Layout changes systematically recorded */
if (strcmp(XATTR_NAME_LOV, xattr_name) == 0 ||
- strncmp(XATTR_LUSTRE_LOV, xattr_name,
- strlen(XATTR_LUSTRE_LOV)) == 0)
+ strcmp(XATTR_LUSTRE_LOV, xattr_name) == 0 ||
+ allowed_lustre_lov(xattr_name))
return CL_LAYOUT;
/* HSM information changes systematically recorded */
if (strcmp(XATTR_NAME_HSM, xattr_name) == 0)
return CL_HSM;
+ /* Avoid logging SOM xattr for every file */
+ if (strcmp(XATTR_NAME_SOM, xattr_name) == 0)
+ return CL_NONE;
+
if (has_prefix(xattr_name, XATTR_USER_PREFIX) ||
has_prefix(xattr_name, XATTR_NAME_POSIX_ACL_ACCESS) ||
- has_prefix(xattr_name, XATTR_NAME_POSIX_ACL_DEFAULT))
- return CL_XATTR;
+ has_prefix(xattr_name, XATTR_NAME_POSIX_ACL_DEFAULT) ||
+ has_prefix(xattr_name, XATTR_TRUSTED_PREFIX) ||
+ has_prefix(xattr_name, XATTR_SECURITY_PREFIX))
+ return CL_SETXATTR;
- return -1;
+ return CL_NONE;
}
static int mdd_declare_xattr_set(const struct lu_env *env,
const char *name,
int fl, struct thandle *handle)
{
- int rc;
+ enum changelog_rec_type type;
+ int rc;
rc = mdo_declare_xattr_set(env, obj, buf, name, fl, handle);
if (rc)
return rc;
- if (mdd_xattr_changelog_type(env, mdd, name) < 0)
+ type = mdd_xattr_changelog_type(env, mdd, name);
+ if (type < 0)
return 0; /* no changelog to store */
- return mdd_declare_changelog_store(env, mdd, NULL, NULL, handle);
+ return mdd_declare_changelog_store(env, mdd, type, NULL, NULL, handle);
}
/*
static int mdd_hsm_update_locked(const struct lu_env *env,
struct md_object *obj,
const struct lu_buf *buf,
- struct thandle *handle, int *cl_flags)
+ struct thandle *handle,
+ enum changelog_rec_flags *clf_flags)
{
struct mdd_thread_info *info = mdd_env_info(env);
- struct mdd_object *mdd_obj = md2mdd_obj(obj);
- struct lu_buf *current_buf;
- struct md_hsm *current_mh;
- struct md_hsm *new_mh;
- int rc;
- ENTRY;
+ struct mdd_object *mdd_obj = md2mdd_obj(obj);
+ struct lu_buf *current_buf;
+ struct md_hsm *current_mh;
+ struct md_hsm *new_mh;
+ int rc;
+ ENTRY;
OBD_ALLOC_PTR(current_mh);
if (current_mh == NULL)
RETURN(-ENOMEM);
/* Read HSM attrs from disk */
current_buf = lu_buf_check_and_alloc(&info->mti_xattr_buf,
- mdo2mdd(obj)->mdd_dt_conf.ddp_max_ea_size);
+ min_t(unsigned int,
+ mdd_obj2mdd_dev(mdd_obj)->mdd_dt_conf.ddp_max_ea_size,
+ XATTR_SIZE_MAX));
rc = mdo_xattr_get(env, mdd_obj, current_buf, XATTR_NAME_HSM);
rc = lustre_buf2hsm(current_buf->lb_buf, rc, current_mh);
if (rc < 0 && rc != -ENODATA)
/* Flags differ, set flags for the changelog that will be added */
if (current_mh->mh_flags != new_mh->mh_flags) {
- hsm_set_cl_event(cl_flags, HE_STATE);
+ hsm_set_cl_event(clf_flags, HE_STATE);
if (new_mh->mh_flags & HS_DIRTY)
- hsm_set_cl_flags(cl_flags, CLF_HSM_DIRTY);
+ hsm_set_cl_flags(clf_flags, CLF_HSM_DIRTY);
}
OBD_FREE_PTR(new_mh);
int rc;
ENTRY;
- rc = lu_fid_cmp(mdo2fid(obj), mdo2fid(vic));
+ rc = lu_fid_cmp(mdd_object_fid(obj), mdd_object_fid(vic));
if (rc == 0) /* same fid */
RETURN(-EPERM);
RETURN(PTR_ERR(handle));
if (rc > 0) {
- mdd_write_lock(env, obj, MOR_TGT_CHILD);
- mdd_write_lock(env, vic, MOR_TGT_CHILD);
+ mdd_write_lock(env, obj, DT_TGT_CHILD);
+ mdd_write_lock(env, vic, DT_TGT_CHILD);
} else {
- mdd_write_lock(env, vic, MOR_TGT_CHILD);
- mdd_write_lock(env, obj, MOR_TGT_CHILD);
+ mdd_write_lock(env, vic, DT_TGT_CHILD);
+ mdd_write_lock(env, obj, DT_TGT_CHILD);
}
/* get EA of victim file */
memset(buf_vic, 0, sizeof(*buf_vic));
- rc = mdd_get_lov_ea(env, vic, buf_vic);
+ rc = mdd_stripe_get(env, vic, buf_vic, XATTR_NAME_LOV);
if (rc < 0) {
if (rc == -ENODATA)
rc = 0;
/* save EA of target file for restore */
memset(buf, 0, sizeof(*buf));
- rc = mdd_get_lov_ea(env, obj, buf);
+ rc = mdd_stripe_get(env, obj, buf, XATTR_NAME_LOV);
if (rc < 0)
GOTO(out, rc);
if (rc) /* wtf? */
GOTO(out_restore, rc);
- (void)mdd_changelog_data_store(env, mdd, CL_LAYOUT, 0, obj, handle);
- (void)mdd_changelog_data_store(env, mdd, CL_LAYOUT, 0, vic, handle);
+ (void)mdd_changelog_data_store(env, mdd, CL_LAYOUT, 0, obj, handle,
+ NULL);
+ (void)mdd_changelog_data_store(env, mdd, CL_LAYOUT, 0, vic, handle,
+ NULL);
EXIT;
out_restore:
int rc2 = mdo_xattr_set(env, obj, buf, XATTR_NAME_LOV,
LU_XATTR_REPLACE, handle);
if (rc2)
- CERROR("%s: failed to rollback of layout of: "DFID
- ": %d, file state unknown\n",
- mdd_obj_dev_name(obj), PFID(mdo2fid(obj)), rc2);
+ CERROR("%s: failed rollback of "DFID" layout: file state unknown: rc = %d\n",
+ mdd_obj_dev_name(obj),
+ PFID(mdd_object_fid(obj)), rc2);
}
out:
return rc;
}
+/**
+ * Extract the mirror with specified mirror id, and store the splitted
+ * mirror layout to @buf.
+ *
+ * \param[in] comp_v1 mirrored layout
+ * \param[in] mirror_id the mirror with mirror_id to be extracted
+ * \param[out] buf store the layout excluding the extracted mirror,
+ * caller free the buffer we allocated in this function
+ * \param[out] buf_vic store the extracted layout, caller free the buffer
+ * we allocated in this function
+ *
+ * \retval 0 on success; < 0 if error happens
+ */
+static int mdd_split_ea(struct lov_comp_md_v1 *comp_v1, __u16 mirror_id,
+ struct lu_buf *buf, struct lu_buf *buf_vic)
+{
+ struct lov_comp_md_v1 *comp_rem;
+ struct lov_comp_md_v1 *comp_vic;
+ struct lov_comp_md_entry_v1 *entry;
+ struct lov_comp_md_entry_v1 *entry_rem;
+ struct lov_comp_md_entry_v1 *entry_vic;
+ __u16 mirror_cnt;
+ __u16 comp_cnt, count = 0;
+ int lmm_size, lmm_size_vic = 0;
+ int i, j, k;
+ int offset, offset_rem, offset_vic;
+
+ mirror_cnt = le16_to_cpu(comp_v1->lcm_mirror_count) + 1;
+ /* comp_v1 should contains more than 1 mirror */
+ if (mirror_cnt <= 1)
+ return -EINVAL;
+ comp_cnt = le16_to_cpu(comp_v1->lcm_entry_count);
+ lmm_size = le32_to_cpu(comp_v1->lcm_size);
+
+ for (i = 0; i < comp_cnt; i++) {
+ entry = &comp_v1->lcm_entries[i];
+ if (mirror_id_of(le32_to_cpu(entry->lcme_id)) == mirror_id) {
+ count++;
+ lmm_size_vic += sizeof(*entry);
+ lmm_size_vic += le32_to_cpu(entry->lcme_size);
+ } else if (count > 0) {
+ /* find the specified mirror */
+ break;
+ }
+ }
+
+ if (count == 0)
+ return -EINVAL;
+
+ lu_buf_alloc(buf, lmm_size - lmm_size_vic);
+ if (!buf->lb_buf)
+ return -ENOMEM;
+
+ lu_buf_alloc(buf_vic, sizeof(*comp_vic) + lmm_size_vic);
+ if (!buf_vic->lb_buf) {
+ lu_buf_free(buf);
+ return -ENOMEM;
+ }
+
+ comp_rem = (struct lov_comp_md_v1 *)buf->lb_buf;
+ comp_vic = (struct lov_comp_md_v1 *)buf_vic->lb_buf;
+
+ memcpy(comp_rem, comp_v1, sizeof(*comp_v1));
+ comp_rem->lcm_mirror_count = cpu_to_le16(mirror_cnt - 2);
+ comp_rem->lcm_entry_count = cpu_to_le32(comp_cnt - count);
+ comp_rem->lcm_size = cpu_to_le32(lmm_size - lmm_size_vic);
+ if (!comp_rem->lcm_mirror_count)
+ comp_rem->lcm_flags = cpu_to_le16(LCM_FL_NONE);
+
+ memset(comp_vic, 0, sizeof(*comp_v1));
+ comp_vic->lcm_magic = cpu_to_le32(LOV_MAGIC_COMP_V1);
+ comp_vic->lcm_mirror_count = 0;
+ comp_vic->lcm_entry_count = cpu_to_le32(count);
+ comp_vic->lcm_size = cpu_to_le32(lmm_size_vic + sizeof(*comp_vic));
+ comp_vic->lcm_flags = cpu_to_le16(LCM_FL_NONE);
+ comp_vic->lcm_layout_gen = 0;
+
+ offset = sizeof(*comp_v1) + sizeof(*entry) * comp_cnt;
+ offset_rem = sizeof(*comp_rem) +
+ sizeof(*entry_rem) * (comp_cnt - count);
+ offset_vic = sizeof(*comp_vic) + sizeof(*entry_vic) * count;
+ for (i = j = k = 0; i < comp_cnt; i++) {
+ struct lov_mds_md *lmm, *lmm_dst;
+ bool vic = false;
+
+ entry = &comp_v1->lcm_entries[i];
+ entry_vic = &comp_vic->lcm_entries[j];
+ entry_rem = &comp_rem->lcm_entries[k];
+
+ if (mirror_id_of(le32_to_cpu(entry->lcme_id)) == mirror_id)
+ vic = true;
+
+ /* copy component entry */
+ if (vic) {
+ memcpy(entry_vic, entry, sizeof(*entry));
+ entry_vic->lcme_flags &= cpu_to_le32(LCME_FL_INIT);
+ entry_vic->lcme_offset = cpu_to_le32(offset_vic);
+ j++;
+ } else {
+ memcpy(entry_rem, entry, sizeof(*entry));
+ entry_rem->lcme_offset = cpu_to_le32(offset_rem);
+ k++;
+ }
+
+ lmm = (struct lov_mds_md *)((char *)comp_v1 + offset);
+ if (vic)
+ lmm_dst = (struct lov_mds_md *)
+ ((char *)comp_vic + offset_vic);
+ else
+ lmm_dst = (struct lov_mds_md *)
+ ((char *)comp_rem + offset_rem);
+
+ /* copy component entry blob */
+ memcpy(lmm_dst, lmm, le32_to_cpu(entry->lcme_size));
+
+ /* blob offset advance */
+ offset += le32_to_cpu(entry->lcme_size);
+ if (vic)
+ offset_vic += le32_to_cpu(entry->lcme_size);
+ else
+ offset_rem += le32_to_cpu(entry->lcme_size);
+ }
+
+ return 0;
+}
+
+static int mdd_dom_data_truncate(const struct lu_env *env,
+ struct mdd_device *mdd, struct mdd_object *mo);
+
+static int mdd_xattr_split(const struct lu_env *env, struct md_object *md_obj,
+ struct md_rejig_data *mrd)
+{
+ struct mdd_device *mdd = mdo2mdd(md_obj);
+ struct mdd_object *obj = md2mdd_obj(md_obj);
+ struct mdd_object *vic = NULL;
+ struct lu_buf *buf = &mdd_env_info(env)->mti_buf[0];
+ struct lu_buf *buf_save = &mdd_env_info(env)->mti_buf[1];
+ struct lu_buf *buf_vic = &mdd_env_info(env)->mti_buf[2];
+ struct lov_comp_md_v1 *lcm;
+ struct thandle *handle;
+ int rc;
+ bool dom_stripe = false;
+
+ ENTRY;
+
+ /**
+ * NULL @mrd_obj means mirror deleting, and use NULL vic to indicate
+ * mirror deleting
+ */
+ if (mrd->mrd_obj)
+ vic = md2mdd_obj(mrd->mrd_obj);
+
+ handle = mdd_trans_create(env, mdd);
+ if (IS_ERR(handle))
+ RETURN(PTR_ERR(handle));
+
+ /* get EA of mirrored file */
+ memset(buf_save, 0, sizeof(*buf));
+ rc = mdd_stripe_get(env, obj, buf_save, XATTR_NAME_LOV);
+ if (rc < 0)
+ GOTO(stop, rc);
+
+ lcm = buf_save->lb_buf;
+ if (le32_to_cpu(lcm->lcm_magic) != LOV_MAGIC_COMP_V1)
+ GOTO(stop, rc = -EINVAL);
+
+ /**
+ * Extract the mirror with specified mirror id, and store the splitted
+ * mirror layout to the victim buffer.
+ */
+ memset(buf, 0, sizeof(*buf));
+ memset(buf_vic, 0, sizeof(*buf_vic));
+ rc = mdd_split_ea(lcm, mrd->mrd_mirror_id, buf, buf_vic);
+ if (rc < 0)
+ GOTO(stop, rc);
+ /**
+ * @buf stores layout w/o the specified mirror, @buf_vic stores the
+ * splitted mirror
+ */
+
+ dom_stripe = mdd_lmm_dom_size(buf_vic->lb_buf) > 0;
+
+ if (vic) {
+ /**
+ * non delete mirror split
+ *
+ * declare obj set remaining layout in @buf, will set obj's
+ * in-memory layout
+ */
+ rc = mdd_declare_xattr_set(env, mdd, obj, buf, XATTR_NAME_LOV,
+ LU_XATTR_SPLIT, handle);
+ if (rc)
+ GOTO(stop, rc);
+
+ /* declare vic set splitted layout in @buf_vic */
+ rc = mdd_declare_xattr_set(env, mdd, vic, buf_vic,
+ XATTR_NAME_LOV, LU_XATTR_SPLIT,
+ handle);
+ if (rc)
+ GOTO(stop, rc);
+ } else {
+ /**
+ * declare delete mirror objects in @buf_vic, will change obj's
+ * in-memory layout
+ */
+ rc = mdd_declare_xattr_set(env, mdd, obj, buf_vic,
+ XATTR_NAME_LOV, LU_XATTR_PURGE,
+ handle);
+ if (rc)
+ GOTO(stop, rc);
+
+ /* declare obj set remaining layout in @buf */
+ rc = mdd_declare_xattr_set(env, mdd, obj, buf,
+ XATTR_NAME_LOV, LU_XATTR_SPLIT,
+ handle);
+ if (rc)
+ GOTO(stop, rc);
+ }
+
+ rc = mdd_trans_start(env, mdd, handle);
+ if (rc)
+ GOTO(stop, rc);
+
+ if (vic) {
+ /* don't use the same file to save the splitted mirror */
+ rc = lu_fid_cmp(mdd_object_fid(obj), mdd_object_fid(vic));
+ if (rc == 0)
+ GOTO(stop, rc = -EPERM);
+
+ if (rc > 0) {
+ mdd_write_lock(env, obj, DT_TGT_CHILD);
+ mdd_write_lock(env, vic, DT_TGT_CHILD);
+ } else {
+ mdd_write_lock(env, vic, DT_TGT_CHILD);
+ mdd_write_lock(env, obj, DT_TGT_CHILD);
+ }
+ } else {
+ mdd_write_lock(env, obj, DT_TGT_CHILD);
+ }
+
+ /* set obj's layout in @buf */
+ rc = mdo_xattr_set(env, obj, buf, XATTR_NAME_LOV, LU_XATTR_REPLACE,
+ handle);
+ if (rc)
+ GOTO(unlock, rc);
+
+ if (vic) {
+ /* set vic's layout in @buf_vic */
+ rc = mdo_xattr_set(env, vic, buf_vic, XATTR_NAME_LOV,
+ LU_XATTR_CREATE, handle);
+ if (rc)
+ GOTO(out_restore, rc);
+ } else {
+ /* delete mirror objects */
+ rc = mdo_xattr_set(env, obj, buf_vic, XATTR_NAME_LOV,
+ LU_XATTR_PURGE, handle);
+ if (rc)
+ GOTO(out_restore, rc);
+ }
+
+ rc = mdd_changelog_data_store(env, mdd, CL_LAYOUT, 0, obj, handle,
+ NULL);
+ if (rc)
+ GOTO(out_restore, rc);
+
+ if (vic) {
+ rc = mdd_changelog_data_store(env, mdd, CL_LAYOUT, 0, vic,
+ handle, NULL);
+ if (rc)
+ GOTO(out_restore, rc);
+ }
+
+out_restore:
+ if (rc) {
+ /* restore obj's in-memory and on-disk layout */
+ int rc2 = mdo_xattr_set(env, obj, buf_save, XATTR_NAME_LOV,
+ LU_XATTR_REPLACE, handle);
+ if (rc2)
+ CERROR("%s: failed rollback "DFID
+ " layout: file state unknown: rc = %d\n",
+ mdd_obj_dev_name(obj),
+ PFID(mdd_object_fid(obj)), rc);
+ }
+
+unlock:
+ mdd_write_unlock(env, obj);
+ if (vic)
+ mdd_write_unlock(env, vic);
+stop:
+ rc = mdd_trans_stop(env, mdd, rc, handle);
+
+ /* Truncate local DOM data if all went well */
+ if (!rc && dom_stripe)
+ mdd_dom_data_truncate(env, mdd, obj);
+
+ lu_buf_free(buf_save);
+ lu_buf_free(buf);
+ lu_buf_free(buf_vic);
+
+ if (!rc)
+ (void) mdd_object_pfid_replace(env, obj);
+
+ return rc;
+}
+
static int mdd_layout_merge_allowed(const struct lu_env *env,
struct md_object *target,
struct md_object *victim)
const struct lu_buf *buf, const char *name,
int fl)
{
- struct mdd_object *mdd_obj = md2mdd_obj(obj);
- struct lu_attr *attr = MDD_ENV_VAR(env, cattr);
- struct mdd_device *mdd = mdo2mdd(obj);
- struct thandle *handle;
+ struct mdd_object *mdd_obj = md2mdd_obj(obj);
+ struct lu_attr *attr = MDD_ENV_VAR(env, cattr);
+ struct mdd_device *mdd = mdo2mdd(obj);
+ struct thandle *handle;
enum changelog_rec_type cl_type;
- int cl_flags = 0;
- int rc;
+ enum changelog_rec_flags clf_flags = 0;
+ int rc;
ENTRY;
rc = mdd_la_get(env, mdd_obj, attr);
if (rc)
RETURN(rc);
- if (strcmp(name, XATTR_LUSTRE_LOV) == 0 && fl == LU_XATTR_MERGE) {
- struct md_object *victim = buf->lb_buf;
+ if (strcmp(name, XATTR_LUSTRE_LOV) == 0 &&
+ (fl == LU_XATTR_MERGE || fl == LU_XATTR_SPLIT)) {
+ struct md_rejig_data *mrd = buf->lb_buf;
+ struct md_object *victim = mrd->mrd_obj;
- if (buf->lb_len != sizeof(victim))
+ if (buf->lb_len != sizeof(*mrd))
RETURN(-EINVAL);
- rc = mdd_layout_merge_allowed(env, obj, victim);
- if (rc)
- RETURN(rc);
- /* merge layout of victim as a mirror of obj's. */
- rc = mdd_xattr_merge(env, obj, victim);
+ if (fl == LU_XATTR_MERGE) {
+ rc = mdd_layout_merge_allowed(env, obj, victim);
+ if (rc)
+ RETURN(rc);
+ /* merge layout of victim as a mirror of obj's. */
+ rc = mdd_xattr_merge(env, obj, victim);
+ } else {
+ rc = mdd_xattr_split(env, obj, mrd);
+ }
RETURN(rc);
}
if (rc)
GOTO(stop, rc);
- mdd_write_lock(env, mdd_obj, MOR_TGT_CHILD);
+ mdd_write_lock(env, mdd_obj, DT_TGT_CHILD);
if (strcmp(XATTR_NAME_HSM, name) == 0) {
- rc = mdd_hsm_update_locked(env, obj, buf, handle, &cl_flags);
+ rc = mdd_hsm_update_locked(env, obj, buf, handle, &clf_flags);
if (rc) {
mdd_write_unlock(env, mdd_obj);
GOTO(stop, rc);
if (cl_type < 0)
GOTO(stop, rc = 0);
- rc = mdd_changelog_data_store(env, mdd, cl_type, cl_flags, mdd_obj,
- handle);
+ rc = mdd_changelog_data_store_xattr(env, mdd, cl_type, clf_flags,
+ mdd_obj, name, handle);
EXIT;
stop:
const char *name,
struct thandle *handle)
{
+ enum changelog_rec_type type;
int rc;
rc = mdo_declare_xattr_del(env, obj, name, handle);
if (rc)
return rc;
- if (mdd_xattr_changelog_type(env, mdd, name) < 0)
+ type = mdd_xattr_changelog_type(env, mdd, name);
+ if (type < 0)
return 0; /* no changelog to store */
- return mdd_declare_changelog_store(env, mdd, NULL, NULL, handle);
+ return mdd_declare_changelog_store(env, mdd, type, NULL, NULL, handle);
}
/**
if (rc)
GOTO(stop, rc);
- mdd_write_lock(env, mdd_obj, MOR_TGT_CHILD);
+ mdd_write_lock(env, mdd_obj, DT_TGT_CHILD);
rc = mdo_xattr_del(env, mdd_obj, name, handle);
mdd_write_unlock(env, mdd_obj);
if (rc)
if (mdd_xattr_changelog_type(env, mdd, name) < 0)
GOTO(stop, rc = 0);
- rc = mdd_changelog_data_store(env, mdd, CL_XATTR, 0, mdd_obj, handle);
+ rc = mdd_changelog_data_store_xattr(env, mdd, CL_SETXATTR, 0, mdd_obj,
+ name, handle);
EXIT;
stop:
}
/*
- * read lov EA of an object
- * return the lov EA in an allocated lu_buf
+ * read lov/lmv EA of an object
+ * return the lov/lmv EA in an allocated lu_buf
*/
-int mdd_get_lov_ea(const struct lu_env *env, struct mdd_object *obj,
- struct lu_buf *lmm_buf)
+int mdd_stripe_get(const struct lu_env *env, struct mdd_object *obj,
+ struct lu_buf *lmm_buf, const char *name)
{
- struct lu_buf *buf = &mdd_env_info(env)->mti_big_buf;
- int rc, bufsize;
+ struct lu_buf *buf = &mdd_env_info(env)->mti_big_buf;
+ int rc;
+
ENTRY;
-repeat:
- rc = mdo_xattr_get(env, obj, buf, XATTR_NAME_LOV);
+ if (buf->lb_buf == NULL) {
+ buf = lu_buf_check_and_alloc(buf, 4096);
+ if (buf->lb_buf == NULL)
+ RETURN(-ENOMEM);
+ }
+repeat:
+ rc = mdo_xattr_get(env, obj, buf, name);
if (rc == -ERANGE) {
/* mti_big_buf is allocated but is too small
* we need to increase it */
buf = lu_buf_check_and_alloc(&mdd_env_info(env)->mti_big_buf,
buf->lb_len * 2);
if (buf->lb_buf == NULL)
- GOTO(out, rc = -ENOMEM);
+ RETURN(-ENOMEM);
goto repeat;
- }
-
- if (rc < 0)
+ } else if (rc < 0) {
RETURN(rc);
-
- if (rc == 0)
+ } else if (rc == 0) {
RETURN(-ENODATA);
-
- bufsize = rc;
- if (memcmp(buf, &LU_BUF_NULL, sizeof(*buf)) == 0) {
- /* mti_big_buf was not allocated, so we have to
- * allocate it based on the ea size */
- buf = lu_buf_check_and_alloc(&mdd_env_info(env)->mti_big_buf,
- bufsize);
- if (buf->lb_buf == NULL)
- GOTO(out, rc = -ENOMEM);
- goto repeat;
}
- lu_buf_alloc(lmm_buf, bufsize);
+ lu_buf_alloc(lmm_buf, rc);
if (lmm_buf->lb_buf == NULL)
- GOTO(out, rc = -ENOMEM);
+ RETURN(-ENOMEM);
- memcpy(lmm_buf->lb_buf, buf->lb_buf, bufsize);
- rc = 0;
- EXIT;
+ /*
+ * we don't use lmm_buf directly, because we don't know xattr size, so
+ * by using mti_big_buf we can avoid calling mdo_xattr_get() twice.
+ */
+ memcpy(lmm_buf->lb_buf, buf->lb_buf, rc);
-out:
- if (rc < 0)
- lu_buf_free(lmm_buf);
- return rc;
+ RETURN(0);
}
static int mdd_xattr_hsm_replace(const struct lu_env *env,
struct thandle *handle)
{
struct hsm_attrs *attrs;
- __u32 hsm_flags;
- int flags = 0;
+ enum hsm_states hsm_flags;
+ enum changelog_rec_flags clf_flags = 0;
int rc;
ENTRY;
RETURN(0);
/* Add a changelog record for release. */
- hsm_set_cl_event(&flags, HE_RELEASE);
+ hsm_set_cl_event(&clf_flags, HE_RELEASE);
rc = mdd_changelog_data_store(env, mdo2mdd(&o->mod_obj), CL_HSM,
- flags, o, handle);
+ clf_flags, o, handle, NULL);
RETURN(rc);
}
const struct lu_attr *attr2,
__u64 flags)
{
- const struct lu_fid *fid1, *fid2;
+ const struct lu_fid *fid1, *fid2;
ENTRY;
- fid1 = mdo2fid(o1);
- fid2 = mdo2fid(o2);
+ fid1 = mdd_object_fid(o1);
+ fid2 = mdd_object_fid(o2);
if (!fid_is_norm(fid1) &&
(!fid_is_igif(fid1) || IS_ERR(mdd_links_get(env, o1))))
return mdd_lmm_gen(lmm, gen, false);
}
+static int mdd_dom_data_truncate(const struct lu_env *env,
+ struct mdd_device *mdd, struct mdd_object *mo)
+{
+ struct thandle *th;
+ struct dt_object *dom;
+ int rc;
+
+ dom = dt_object_locate(mdd_object_child(mo), mdd->mdd_bottom);
+ if (!dom)
+ GOTO(out, rc = -ENODATA);
+
+ th = dt_trans_create(env, mdd->mdd_bottom);
+ if (IS_ERR(th))
+ GOTO(out, rc = PTR_ERR(th));
+
+ rc = dt_declare_punch(env, dom, 0, OBD_OBJECT_EOF, th);
+ if (rc)
+ GOTO(stop, rc);
+
+ rc = dt_trans_start_local(env, mdd->mdd_bottom, th);
+ if (rc != 0)
+ GOTO(stop, rc);
+
+ rc = dt_punch(env, dom, 0, OBD_OBJECT_EOF, th);
+stop:
+ dt_trans_stop(env, mdd->mdd_bottom, th);
+out:
+ /* Ignore failure but report the error */
+ if (rc)
+ CERROR("%s: can't truncate DOM inode "DFID" data: rc = %d\n",
+ mdd_obj_dev_name(mo), PFID(mdd_object_fid(mo)), rc);
+ return rc;
+}
+
/**
* swap layouts between 2 lustre objects
*/
static int mdd_swap_layouts(const struct lu_env *env, struct md_object *obj1,
struct md_object *obj2, __u64 flags)
{
- struct mdd_thread_info *info = mdd_env_info(env);
- struct mdd_object *fst_o = md2mdd_obj(obj1);
- struct mdd_object *snd_o = md2mdd_obj(obj2);
- struct lu_attr *fst_la = MDD_ENV_VAR(env, cattr);
- struct lu_attr *snd_la = MDD_ENV_VAR(env, tattr);
- struct mdd_device *mdd = mdo2mdd(obj1);
- struct lov_mds_md *fst_lmm, *snd_lmm;
- struct lu_buf *fst_buf = &info->mti_buf[0];
- struct lu_buf *snd_buf = &info->mti_buf[1];
- struct lu_buf *fst_hsm_buf = &info->mti_buf[2];
- struct lu_buf *snd_hsm_buf = &info->mti_buf[3];
- struct ost_id *saved_oi = NULL;
- struct thandle *handle;
- __u32 fst_gen, snd_gen, saved_gen;
- int fst_fl;
- int rc;
- int rc2;
+ struct mdd_thread_info *info = mdd_env_info(env);
+ struct mdd_object *fst_o = md2mdd_obj(obj1);
+ struct mdd_object *snd_o = md2mdd_obj(obj2);
+ struct lu_attr *fst_la = MDD_ENV_VAR(env, cattr);
+ struct lu_attr *snd_la = MDD_ENV_VAR(env, tattr);
+ struct mdd_device *mdd = mdo2mdd(obj1);
+ struct lov_mds_md *fst_lmm, *snd_lmm;
+ struct lu_buf *fst_buf = &info->mti_buf[0];
+ struct lu_buf *snd_buf = &info->mti_buf[1];
+ struct lu_buf *fst_hsm_buf = &info->mti_buf[2];
+ struct lu_buf *snd_hsm_buf = &info->mti_buf[3];
+ struct ost_id *saved_oi = NULL;
+ struct thandle *handle;
+ struct mdd_object *dom_o = NULL;
+ __u64 domsize_dom, domsize_vlt;
+ __u32 fst_gen, snd_gen, saved_gen;
+ int fst_fl;
+ int rc, rc2;
+
ENTRY;
- CLASSERT(ARRAY_SIZE(info->mti_buf) >= 4);
+ BUILD_BUG_ON(ARRAY_SIZE(info->mti_buf) < 4);
memset(info->mti_buf, 0, sizeof(info->mti_buf));
/* we have to sort the 2 obj, so locking will always
* be in the same order, even in case of 2 concurrent swaps */
- rc = lu_fid_cmp(mdo2fid(fst_o), mdo2fid(snd_o));
+ rc = lu_fid_cmp(mdd_object_fid(fst_o), mdd_object_fid(snd_o));
if (rc == 0) /* same fid ? */
RETURN(-EPERM);
RETURN(PTR_ERR(handle));
/* objects are already sorted */
- mdd_write_lock(env, fst_o, MOR_TGT_CHILD);
- mdd_write_lock(env, snd_o, MOR_TGT_CHILD);
+ mdd_write_lock(env, fst_o, DT_TGT_CHILD);
+ mdd_write_lock(env, snd_o, DT_TGT_CHILD);
- rc = mdd_get_lov_ea(env, fst_o, fst_buf);
+ rc = mdd_stripe_get(env, fst_o, fst_buf, XATTR_NAME_LOV);
if (rc < 0 && rc != -ENODATA)
GOTO(stop, rc);
- rc = mdd_get_lov_ea(env, snd_o, snd_buf);
+ rc = mdd_stripe_get(env, snd_o, snd_buf, XATTR_NAME_LOV);
if (rc < 0 && rc != -ENODATA)
GOTO(stop, rc);
+ /* check if file has DoM. DoM file can be migrated only to another
+ * DoM layout with the same DoM component size or to an non-DOM
+ * layout. After migration to OSTs layout, local MDT inode data
+ * should be truncated.
+ * Objects are sorted by FIDs, considering that original file's FID
+ * is always smaller the snd_o is always original file we are migrating
+ * from.
+ */
+ domsize_dom = mdd_lmm_dom_size(snd_buf->lb_buf);
+ domsize_vlt = mdd_lmm_dom_size(fst_buf->lb_buf);
+
+ /* Only migration is supported for DoM files, not 'swap_layouts' so
+ * target file must be volatile and orphan.
+ */
+ if (fst_o->mod_flags & (ORPHAN_OBJ | VOLATILE_OBJ)) {
+ dom_o = domsize_dom ? snd_o : NULL;
+ } else if (snd_o->mod_flags & (ORPHAN_OBJ | VOLATILE_OBJ)) {
+ swap(domsize_dom, domsize_vlt);
+ dom_o = domsize_dom ? fst_o : NULL;
+ } else if (domsize_dom > 0 || domsize_vlt > 0) {
+ /* 'lfs swap_layouts' case, neither file should have DoM */
+ rc = -EOPNOTSUPP;
+ CDEBUG(D_LAYOUT, "cannot swap layouts with DOM component, "
+ "use migration instead: rc = %d\n", rc);
+ GOTO(stop, rc);
+ }
+
+ if (domsize_vlt > 0 && domsize_dom == 0) {
+ rc = -EOPNOTSUPP;
+ CDEBUG(D_LAYOUT,
+ "%s: cannot swap "DFID" layout: OST to DOM migration not supported: rc = %d\n",
+ mdd_obj_dev_name(snd_o),
+ PFID(mdd_object_fid(snd_o)), rc);
+ GOTO(stop, rc);
+ } else if (domsize_vlt > 0 && domsize_dom != domsize_vlt) {
+ rc = -EOPNOTSUPP;
+ CDEBUG(D_LAYOUT,
+ "%s: cannot swap "DFID" layout: new layout must have same DoM component size: rc = %d\n",
+ mdd_obj_dev_name(fst_o),
+ PFID(mdd_object_fid(fst_o)), rc);
+ GOTO(stop, rc);
+ } else if (domsize_vlt > 0) {
+ /* Migration with the same DOM component size, no need to
+ * truncate local data, it is still being used */
+ dom_o = NULL;
+ }
+
/* swapping 2 non existant layouts is a success */
if (fst_buf->lb_buf == NULL && snd_buf->lb_buf == NULL)
GOTO(stop, rc = 0);
/* set the file specific informations in lmm */
if (fst_lmm != NULL) {
+ struct ost_id temp_oi;
+
saved_oi = &info->mti_oa.o_oi;
mdd_get_lmm_oi(fst_lmm, saved_oi);
+ mdd_get_lmm_oi(snd_lmm, &temp_oi);
mdd_set_lmm_gen(fst_lmm, &snd_gen);
- mdd_set_lmm_oi(fst_lmm, &snd_lmm->lmm_oi);
+ mdd_set_lmm_oi(fst_lmm, &temp_oi);
mdd_set_lmm_oi(snd_lmm, saved_oi);
} else {
if ((snd_lmm->lmm_magic & cpu_to_le32(LOV_MAGIC_MASK)) ==
rc2 = mdd_xattr_hsm_replace(env, fst_o, fst_hsm_buf,
handle);
if (rc2 < 0)
- CERROR("%s: restore "DFID" HSM error: %d/%d\n",
+ CERROR("%s: HSM error restoring "DFID": rc = %d/%d\n",
mdd_obj_dev_name(fst_o),
- PFID(mdo2fid(fst_o)), rc, rc2);
+ PFID(mdd_object_fid(fst_o)), rc, rc2);
GOTO(stop, rc);
}
}
GOTO(out_restore, rc);
/* Issue one changelog record per file */
- rc = mdd_changelog_data_store(env, mdd, CL_LAYOUT, 0, fst_o, handle);
+ rc = mdd_changelog_data_store(env, mdd, CL_LAYOUT, 0, fst_o, handle,
+ NULL);
if (rc)
GOTO(stop, rc);
- rc = mdd_changelog_data_store(env, mdd, CL_LAYOUT, 0, snd_o, handle);
+ rc = mdd_changelog_data_store(env, mdd, CL_LAYOUT, 0, snd_o, handle,
+ NULL);
if (rc)
GOTO(stop, rc);
EXIT;
do_lbug:
if (rc2 < 0) {
/* very bad day */
- CERROR("%s: unable to roll back layout swap. FIDs: "
- DFID" and "DFID "error: %d/%d, steps: %d\n",
+ CERROR("%s: unable to roll back layout swap of "DFID" and "DFID", steps: %d: rc = %d/%d\n",
mdd_obj_dev_name(fst_o),
- PFID(mdo2fid(snd_o)), PFID(mdo2fid(fst_o)),
+ PFID(mdd_object_fid(snd_o)),
+ PFID(mdd_object_fid(fst_o)),
rc, rc2, steps);
/* a solution to avoid journal commit is to panic,
* but it has strong consequences so we use LBUG to
stop:
rc = mdd_trans_stop(env, mdd, rc, handle);
+ /* Truncate local DOM data if all went well */
+ if (!rc && dom_o)
+ mdd_dom_data_truncate(env, mdd, dom_o);
+
mdd_write_unlock(env, snd_o);
mdd_write_unlock(env, fst_o);
if (rc)
return rc;
- return mdd_declare_changelog_store(env, mdd, NULL, NULL, handle);
+ return mdd_declare_changelog_store(env, mdd, CL_LAYOUT, NULL, NULL,
+ handle);
}
/* For PFL, this is used to instantiate necessary component objects. */
if (rc)
RETURN(rc);
- mdd_write_lock(env, obj, MOR_TGT_CHILD);
+ mdd_write_lock(env, obj, DT_TGT_CHILD);
rc = mdo_layout_change(env, obj, mlc, handle);
mdd_write_unlock(env, obj);
if (rc)
RETURN(rc);
- rc = mdd_changelog_data_store(env, mdd, CL_LAYOUT, 0, obj, handle);
+ rc = mdd_changelog_data_store(env, mdd, CL_LAYOUT, 0, obj, handle,
+ NULL);
RETURN(rc);
}
struct md_layout_change *mlc, struct thandle *handle)
{
struct mdd_device *mdd = mdd_obj2mdd_dev(obj);
+ struct lu_buf *som_buf = &mdd_env_info(env)->mti_buf[1];
+ struct lustre_som_attrs *som = &mlc->mlc_som;
+ int fl = 0;
int rc;
ENTRY;
/* Verify acceptable operations */
switch (mlc->mlc_opc) {
case MD_LAYOUT_WRITE:
- break;
case MD_LAYOUT_RESYNC:
/* these are legal operations - this represents the case that
- * a few mirrors were missed in the last resync.
- * XXX: it will be supported later */
+ * a few mirrors were missed in the last resync. */
+ break;
case MD_LAYOUT_RESYNC_DONE:
default:
RETURN(0);
}
+ som_buf->lb_buf = som;
+ som_buf->lb_len = sizeof(*som);
+ rc = mdo_xattr_get(env, obj, som_buf, XATTR_NAME_SOM);
+ if (rc < 0 && rc != -ENODATA)
+ RETURN(rc);
+
+ if (rc > 0) {
+ lustre_som_swab(som);
+ if (som->lsa_valid & SOM_FL_STRICT)
+ fl = LU_XATTR_REPLACE;
+
+ if (mlc->mlc_opc == MD_LAYOUT_WRITE &&
+ mlc->mlc_intent->li_extent.e_end > som->lsa_size) {
+ som->lsa_size = mlc->mlc_intent->li_extent.e_end + 1;
+ fl = LU_XATTR_REPLACE;
+ }
+ }
+
rc = mdd_declare_layout_change(env, mdd, obj, mlc, handle);
if (rc)
GOTO(out, rc);
- rc = mdd_declare_xattr_del(env, mdd, obj, XATTR_NAME_SOM, handle);
- if (rc)
- GOTO(out, rc);
+ if (fl) {
+ rc = mdd_declare_xattr_set(env, mdd, obj, som_buf,
+ XATTR_NAME_SOM, fl, handle);
+ if (rc)
+ GOTO(out, rc);
+ }
/* record a changelog for data mover to consume */
- rc = mdd_declare_changelog_store(env, mdd, NULL, NULL, handle);
+ rc = mdd_declare_changelog_store(env, mdd, CL_FLRW, NULL, NULL, handle);
if (rc)
GOTO(out, rc);
/* it needs a sync tx to make FLR to work properly */
handle->th_sync = 1;
- mdd_write_lock(env, obj, MOR_TGT_CHILD);
+ mdd_write_lock(env, obj, DT_TGT_CHILD);
rc = mdo_layout_change(env, obj, mlc, handle);
- if (!rc) {
- rc = mdo_xattr_del(env, obj, XATTR_NAME_SOM, handle);
- if (rc == -ENODATA)
- rc = 0;
+ if (!rc && fl) {
+ /* SOM state transition from STRICT to STALE */
+ som->lsa_valid = SOM_FL_STALE;
+ lustre_som_swab(som);
+ rc = mdo_xattr_set(env, obj, som_buf, XATTR_NAME_SOM,
+ fl, handle);
}
mdd_write_unlock(env, obj);
if (rc)
GOTO(out, rc);
- rc = mdd_changelog_data_store(env, mdd, CL_FLRW, 0, obj, handle);
+ rc = mdd_changelog_data_store(env, mdd, CL_FLRW, 0, obj, handle, NULL);
if (rc)
GOTO(out, rc);
struct thandle *handle)
{
struct mdd_device *mdd = mdd_obj2mdd_dev(obj);
+ struct lu_buf *som_buf = &mdd_env_info(env)->mti_buf[1];
+ struct lustre_som_attrs *som = &mlc->mlc_som;
+ int fl = 0;
int rc;
ENTRY;
* resync state. */
break;
case MD_LAYOUT_WRITE:
- /* legal race for concurrent write, the file state has been
- * changed by another client. */
+ /**
+ * legal race for concurrent write, the file state has been
+ * changed by another client. Or a jump over file size and
+ * write.
+ */
+ som_buf->lb_buf = som;
+ som_buf->lb_len = sizeof(*som);
+ rc = mdo_xattr_get(env, obj, som_buf, XATTR_NAME_SOM);
+ if (rc < 0 && rc != -ENODATA)
+ RETURN(rc);
+
+ if (rc > 0) {
+ lustre_som_swab(som);
+ if (mlc->mlc_intent->li_extent.e_end > som->lsa_size) {
+ som->lsa_size =
+ mlc->mlc_intent->li_extent.e_end + 1;
+ fl = LU_XATTR_REPLACE;
+ }
+ }
break;
default:
RETURN(-EBUSY);
if (rc)
GOTO(out, rc);
+ if (fl) {
+ rc = mdd_declare_xattr_set(env, mdd, obj, som_buf,
+ XATTR_NAME_SOM, fl, handle);
+ if (rc)
+ GOTO(out, rc);
+ }
+
rc = mdd_trans_start(env, mdd, handle);
if (rc)
GOTO(out, rc);
/* it needs a sync tx to make FLR to work properly */
handle->th_sync = 1;
- mdd_write_lock(env, obj, MOR_TGT_CHILD);
+ mdd_write_lock(env, obj, DT_TGT_CHILD);
rc = mdo_layout_change(env, obj, mlc, handle);
+ if (!rc && fl) {
+ som->lsa_valid = SOM_FL_STALE;
+ lustre_som_swab(som);
+ rc = mdo_xattr_set(env, obj, som_buf, XATTR_NAME_SOM,
+ fl, handle);
+ }
mdd_write_unlock(env, obj);
if (rc)
GOTO(out, rc);
RETURN(-EBUSY);
}
- if (mlc->mlc_som.lsa_valid & LSOM_FL_VALID) {
+ if (mlc->mlc_som.lsa_valid & SOM_FL_STRICT) {
rc = mdo_xattr_get(env, obj, &LU_BUF_NULL, XATTR_NAME_SOM);
- if (rc && rc != -ENODATA)
+ if (rc < 0 && rc != -ENODATA)
RETURN(rc);
fl = rc == -ENODATA ? LU_XATTR_CREATE : LU_XATTR_REPLACE;
+ lustre_som_swab(&mlc->mlc_som);
som_buf->lb_buf = &mlc->mlc_som;
som_buf->lb_len = sizeof(mlc->mlc_som);
}
GOTO(out, rc);
/* record a changelog for the completion of resync */
- rc = mdd_declare_changelog_store(env, mdd, NULL, NULL, handle);
+ rc = mdd_declare_changelog_store(env, mdd, CL_RESYNC, NULL, NULL,
+ handle);
if (rc)
GOTO(out, rc);
GOTO(out, rc);
}
- rc = mdd_changelog_data_store(env, mdd, CL_RESYNC, 0, obj, handle);
+ rc = mdd_changelog_data_store(env, mdd, CL_RESYNC, 0, obj, handle,
+ NULL);
if (rc)
GOTO(out, rc);
EXIT;
struct thandle *handle;
int flr_state;
int rc;
+
ENTRY;
+ if (S_ISDIR(mdd_object_type(obj))) {
+ switch (mlc->mlc_opc) {
+ case MD_LAYOUT_SHRINK:
+ rc = mdd_dir_layout_shrink(env, o, mlc);
+ break;
+ case MD_LAYOUT_SPLIT:
+ rc = mdd_dir_layout_split(env, o, mlc);
+ break;
+ default:
+ LBUG();
+ }
+
+ RETURN(rc);
+ }
+
/* Verify acceptable operations */
switch (mlc->mlc_opc) {
case MD_LAYOUT_WRITE:
if (IS_ERR(handle))
RETURN(PTR_ERR(handle));
- rc = mdd_get_lov_ea(env, obj, buf);
+ rc = mdd_stripe_get(env, obj, buf, XATTR_NAME_LOV);
if (rc < 0) {
if (rc == -ENODATA)
rc = -EINVAL;
/* please refer to HLD of FLR for state transition */
switch (flr_state) {
- case LCM_FL_NOT_FLR:
+ case LCM_FL_NONE:
rc = mdd_layout_instantiate_component(env, obj, mlc, handle);
break;
case LCM_FL_WRITE_PENDING:
struct dt_allocation_hint *hint)
{
struct dt_object *np = parent ? mdd_object_child(parent) : NULL;
+ struct mdd_device *mdd = mdd_obj2mdd_dev(child);
struct dt_object *nc = mdd_object_child(child);
memset(hint, 0, sizeof(*hint));
} else {
hint->dah_eadata = NULL;
hint->dah_eadata_len = 0;
+ if (spec->sp_cr_flags & MDS_OPEN_APPEND) {
+ if (mdd->mdd_append_stripe_count != 0 ||
+ mdd->mdd_append_pool[0])
+ CDEBUG(D_INFO,
+ "using O_APPEND file striping\n");
+ if (mdd->mdd_append_stripe_count)
+ hint->dah_append_stripes =
+ mdd->mdd_append_stripe_count;
+ if (mdd->mdd_append_pool[0])
+ hint->dah_append_pool = mdd->mdd_append_pool;
+ } else {
+ hint->dah_append_stripes = 0;
+ }
}
CDEBUG(D_INFO, DFID" eadata %p len %d\n", PFID(mdd_object_fid(child)),
nc->do_ops->do_ah_init(env, hint, np, nc, attr->la_mode & S_IFMT);
}
-/*
- * do NOT or the MAY_*'s, you'll get the weakest
- */
-int accmode(const struct lu_env *env, const struct lu_attr *la, int flags)
+static int mdd_accmode(const struct lu_env *env, const struct lu_attr *la,
+ u64 open_flags)
{
- int res = 0;
-
/* Sadly, NFSD reopens a file repeatedly during operation, so the
* "acc_mode = 0" allowance for newly-created files isn't honoured.
* NFSD uses the MDS_OPEN_OWNEROVERRIDE flag to say that a file
* owner can write to a file even if it is marked readonly to hide
* its brokenness. (bug 5781) */
- if (flags & MDS_OPEN_OWNEROVERRIDE) {
+ if (open_flags & MDS_OPEN_OWNEROVERRIDE) {
struct lu_ucred *uc = lu_ucred_check(env);
if ((uc == NULL) || (la->la_uid == uc->uc_fsuid))
return 0;
}
- if (flags & FMODE_READ)
- res |= MAY_READ;
- if (flags & (FMODE_WRITE | MDS_OPEN_TRUNC | MDS_OPEN_APPEND))
- res |= MAY_WRITE;
- if (flags & MDS_FMODE_EXEC)
- res = MAY_EXEC;
- return res;
+ return mds_accmode(open_flags);
}
static int mdd_open_sanity_check(const struct lu_env *env,
- struct mdd_object *obj,
- const struct lu_attr *attr, int flag)
+ struct mdd_object *obj,
+ const struct lu_attr *attr, u64 open_flags,
+ int is_replay)
{
- int mode, rc;
+ unsigned int may_mask;
+ int rc;
ENTRY;
- /* EEXIST check */
- if (mdd_is_dead_obj(obj))
+ /* EEXIST check, also opening of *open* orphans is allowed so we can
+ * open-by-handle unlinked files
+ */
+ if (mdd_is_dead_obj(obj) && !is_replay &&
+ likely(!(mdd_is_orphan_obj(obj) && obj->mod_count > 0)))
RETURN(-ENOENT);
if (S_ISLNK(attr->la_mode))
RETURN(-ELOOP);
- mode = accmode(env, attr, flag);
+ may_mask = mdd_accmode(env, attr, open_flags);
- if (S_ISDIR(attr->la_mode) && (mode & MAY_WRITE))
+ if (S_ISDIR(attr->la_mode) && (may_mask & MAY_WRITE))
RETURN(-EISDIR);
- if (!(flag & MDS_OPEN_CREATED)) {
- rc = mdd_permission_internal(env, obj, attr, mode);
+ if (!(open_flags & MDS_OPEN_CREATED)) {
+ rc = mdd_permission_internal(env, obj, attr, may_mask);
if (rc)
RETURN(rc);
}
if (S_ISFIFO(attr->la_mode) || S_ISSOCK(attr->la_mode) ||
S_ISBLK(attr->la_mode) || S_ISCHR(attr->la_mode))
- flag &= ~MDS_OPEN_TRUNC;
+ open_flags &= ~MDS_OPEN_TRUNC;
/* For writing append-only file must open it with append mode. */
if (attr->la_flags & LUSTRE_APPEND_FL) {
- if ((flag & FMODE_WRITE) && !(flag & MDS_OPEN_APPEND))
+ if ((open_flags & MDS_FMODE_WRITE) &&
+ !(open_flags & MDS_OPEN_APPEND))
RETURN(-EPERM);
- if (flag & MDS_OPEN_TRUNC)
+ if (open_flags & MDS_OPEN_TRUNC)
RETURN(-EPERM);
}
}
static int mdd_open(const struct lu_env *env, struct md_object *obj,
- int flags)
+ u64 open_flags, struct md_op_spec *spec)
{
struct mdd_object *mdd_obj = md2mdd_obj(obj);
struct md_device *md_dev = lu2md_dev(mdd2lu_dev(mdo2mdd(obj)));
struct lu_attr *attr = MDD_ENV_VAR(env, cattr);
+ struct mdd_object_user *mou = NULL;
+ const struct lu_ucred *uc = lu_ucred(env);
+ struct mdd_device *mdd = mdo2mdd(obj);
+ enum changelog_rec_type type = CL_OPEN;
int rc = 0;
+ ENTRY;
- mdd_write_lock(env, mdd_obj, MOR_TGT_CHILD);
+ mdd_write_lock(env, mdd_obj, DT_TGT_CHILD);
rc = mdd_la_get(env, mdd_obj, attr);
if (rc != 0)
GOTO(out, rc);
- rc = mdd_open_sanity_check(env, mdd_obj, attr, flags);
- if (rc != 0)
+ rc = mdd_open_sanity_check(env, mdd_obj, attr, open_flags,
+ spec->no_create);
+ if ((rc == -EACCES) && (mdd->mdd_cl.mc_mask & BIT(CL_DN_OPEN)))
+ type = CL_DN_OPEN;
+ else if (rc != 0)
+ GOTO(out, rc);
+ else
+ mdd_obj->mod_count++;
+
+ if (!mdd_changelog_enabled(env, mdd, type))
GOTO(out, rc);
- mdd_obj->mod_count++;
+find:
+ /* look for existing opener in list under mdd_write_lock */
+ mou = mdd_obj_user_find(mdd_obj, uc->uc_uid, uc->uc_gid, open_flags);
- mdd_changelog(env, CL_OPEN, flags, md_dev, mdo2fid(mdd_obj));
+ if (!mou) {
+ int rc2;
+
+ /* add user to list */
+ mou = mdd_obj_user_alloc(open_flags, uc->uc_uid, uc->uc_gid);
+ if (IS_ERR(mou)) {
+ if (rc == 0)
+ rc = PTR_ERR(mou);
+ GOTO(out, rc);
+ }
+ rc2 = mdd_obj_user_add(mdd_obj, mou, type == CL_DN_OPEN);
+ if (rc2 != 0) {
+ mdd_obj_user_free(mou);
+ if (rc2 == -EEXIST)
+ GOTO(find, rc2);
+ }
+ } else {
+ if (type == CL_DN_OPEN) {
+ if (ktime_before(ktime_get(), mou->mou_deniednext))
+ /* same user denied again same access within
+ * time interval: do not record
+ */
+ GOTO(out, rc);
+
+ /* this user already denied, but some time ago:
+ * update denied time
+ */
+ mou->mou_deniednext =
+ ktime_add(ktime_get(),
+ ktime_set(mdd->mdd_cl.mc_deniednext,
+ 0));
+ } else {
+ mou->mou_opencount++;
+ /* same user opening file again with same flags:
+ * don't record
+ */
+ GOTO(out, rc);
+ }
+ }
+
+ /* FYI, only the bottom 32 bits of open_flags are recorded */
+ mdd_changelog(env, type, open_flags, md_dev, mdd_object_fid(mdd_obj));
EXIT;
out:
return rc;
}
-static int mdd_declare_close(const struct lu_env *env,
- struct mdd_object *obj,
- struct md_attr *ma,
- struct thandle *handle)
+static int mdd_declare_close(const struct lu_env *env, struct mdd_object *obj,
+ struct md_attr *ma, struct thandle *handle)
{
- int rc;
+ int rc;
- rc = orph_declare_index_delete(env, obj, handle);
- if (rc)
- return rc;
+ rc = mdd_orphan_declare_delete(env, obj, handle);
+ if (rc)
+ return rc;
return mdo_declare_destroy(env, obj, handle);
}
* No permission check is needed.
*/
static int mdd_close(const struct lu_env *env, struct md_object *obj,
- struct md_attr *ma, int mode)
+ struct md_attr *ma, u64 open_flags)
{
struct mdd_object *mdd_obj = md2mdd_obj(obj);
struct mdd_device *mdd = mdo2mdd(obj);
int is_orphan = 0;
int rc;
bool blocked = false;
+ bool last_close_by_uid = false;
+ const struct lu_ucred *uc = lu_ucred(env);
ENTRY;
if (ma->ma_valid & MA_FLAGS && ma->ma_attr_flags & MDS_KEEP_ORPHAN) {
- mdd_write_lock(env, mdd_obj, MOR_TGT_CHILD);
+ mdd_write_lock(env, mdd_obj, DT_TGT_CHILD);
mdd_obj->mod_count--;
mdd_write_unlock(env, mdd_obj);
if (rc)
GOTO(stop, rc);
- rc = mdd_declare_changelog_store(env, mdd, NULL, NULL, handle);
+ rc = mdd_declare_changelog_store(env, mdd, CL_CLOSE, NULL, NULL,
+ handle);
if (rc)
GOTO(stop, rc);
}
cont:
- mdd_write_lock(env, mdd_obj, MOR_TGT_CHILD);
+ mdd_write_lock(env, mdd_obj, DT_TGT_CHILD);
rc = mdd_la_get(env, mdd_obj, &ma->ma_attr);
if (rc != 0) {
- CERROR("Failed to get lu_attr of "DFID": %d\n",
+ CERROR("%s: failed to get lu_attr of "DFID": rc = %d\n",
+ lu_dev_name(mdd2lu_dev(mdd)),
PFID(mdd_object_fid(mdd_obj)), rc);
GOTO(out, rc);
}
mdd_obj->mod_count--; /*release open count */
+ /* under mdd write lock */
+ /* If recording, see if we need to remove UID from list. uc is not
+ * initialized if the client has been evicted. */
+ if (mdd_changelog_enabled(env, mdd, CL_OPEN) && uc) {
+ struct mdd_object_user *mou;
+
+ /* look for UID in list */
+ /* If mou is NULL, it probably means logging was enabled after
+ * the user had the file open. So the corresponding close
+ * will not be logged.
+ */
+ mou = mdd_obj_user_find(mdd_obj, uc->uc_uid, uc->uc_gid,
+ open_flags);
+ if (mou) {
+ mou->mou_opencount--;
+ if (mou->mou_opencount == 0) {
+ mdd_obj_user_remove(mdd_obj, mou);
+ last_close_by_uid = true;
+ }
+ }
+ }
+
if (!is_orphan || blocked)
GOTO(out, rc = 0);
if ((mdd_obj->mod_flags & ORPHAN_OBJ) != 0) {
/* remove link to object from orphan index */
LASSERT(handle != NULL);
- rc = __mdd_orphan_del(env, mdd_obj, handle);
+ rc = mdd_orphan_delete(env, mdd_obj, handle);
if (rc != 0) {
CERROR("%s: unable to delete "DFID" from orphan list: "
"rc = %d\n", lu_dev_name(mdd2lu_dev(mdd)),
out:
mdd_write_unlock(env, mdd_obj);
+ if (rc != 0 || blocked ||
+ !mdd_changelog_enabled(env, mdd, CL_CLOSE))
+ GOTO(stop, rc);
+
/* Record CL_CLOSE in changelog only if file was opened in write mode,
- * or if CL_OPEN was recorded.
+ * or if CL_OPEN was recorded and it's last close by user.
* Changelogs mask may change between open and close operations, but
* this is not a big deal if we have a CL_CLOSE entry with no matching
* CL_OPEN. Plus Changelogs mask may not change often.
*/
- if (!rc && !blocked &&
- ((mode & (FMODE_WRITE | MDS_OPEN_APPEND | MDS_OPEN_TRUNC)) ||
- (mdd->mdd_cl.mc_mask & (1 << CL_OPEN))) &&
+ if (((!(mdd->mdd_cl.mc_mask & BIT(CL_OPEN)) &&
+ (open_flags & (MDS_FMODE_WRITE | MDS_OPEN_APPEND |
+ MDS_OPEN_TRUNC))) ||
+ ((mdd->mdd_cl.mc_mask & BIT(CL_OPEN)) && last_close_by_uid)) &&
!(ma->ma_valid & MA_FLAGS && ma->ma_attr_flags & MDS_RECOV_OPEN)) {
if (handle == NULL) {
handle = mdd_trans_create(env, mdo2mdd(obj));
if (IS_ERR(handle))
GOTO(stop, rc = PTR_ERR(handle));
- rc = mdd_declare_changelog_store(env, mdd, NULL, NULL,
- handle);
+ rc = mdd_declare_changelog_store(env, mdd, CL_CLOSE,
+ NULL, NULL, handle);
if (rc)
GOTO(stop, rc);
- rc = mdd_trans_start(env, mdo2mdd(obj), handle);
- if (rc)
- GOTO(stop, rc);
- }
+ rc = mdd_trans_start(env, mdo2mdd(obj), handle);
+ if (rc)
+ GOTO(stop, rc);
+ }
- mdd_changelog_data_store(env, mdd, CL_CLOSE, mode,
- mdd_obj, handle);
- }
+ /* FYI, only the bottom 32 bits of open_flags are recorded */
+ mdd_changelog_data_store(env, mdd, CL_CLOSE, open_flags,
+ mdd_obj, handle, NULL);
+ }
stop:
if (handle != NULL && !IS_ERR(handle))
return -ENOENT;
}
- mdd_read_lock(env, mdd_obj, MOR_TGT_CHILD);
+ mdd_read_lock(env, mdd_obj, DT_TGT_CHILD);
rc = mdd_readpage_sanity_check(env, mdd_obj);
if (rc)
GOTO(out_unlock, rc);
git://git.whamcloud.com / fs / lustre-release.git / blobdiff