sizeof(dotdot) - 1
};
-static int __mdd_lookup(const struct lu_env *, struct md_object *,
- const struct lu_name *, struct lu_fid*, int);
-
+/* Get FID from name and parent */
static int
-__mdd_lookup_locked(const struct lu_env *env, struct md_object *pobj,
- const struct lu_name *lname, struct lu_fid* fid, int mask)
+__mdd_lookup(const struct lu_env *env, struct md_object *pobj,
+ const struct lu_attr *pattr, const struct lu_name *lname,
+ struct lu_fid* fid, int mask)
{
- const char *name = lname->ln_name;
- struct mdd_object *mdd_obj = md2mdd_obj(pobj);
- struct dynlock_handle *dlh;
+ const char *name = lname->ln_name;
+ const struct dt_key *key = (const struct dt_key *)name;
+ struct mdd_object *mdd_obj = md2mdd_obj(pobj);
+ struct mdd_device *m = mdo2mdd(pobj);
+ struct dt_object *dir = mdd_object_child(mdd_obj);
int rc;
+ ENTRY;
- dlh = mdd_pdo_read_lock(env, mdd_obj, name, MOR_TGT_PARENT);
- if (unlikely(dlh == NULL))
- return -ENOMEM;
- rc = __mdd_lookup(env, pobj, lname, fid, mask);
- mdd_pdo_read_unlock(env, mdd_obj, dlh);
+ if (unlikely(mdd_is_dead_obj(mdd_obj)))
+ RETURN(-ESTALE);
- return rc;
+ if (mdd_object_remote(mdd_obj)) {
+ CDEBUG(D_INFO, "%s: Object "DFID" locates on remote server\n",
+ mdd2obd_dev(m)->obd_name, PFID(mdo2fid(mdd_obj)));
+ } else if (!mdd_object_exists(mdd_obj)) {
+ RETURN(-ESTALE);
+ }
+
+ /* The common filename length check. */
+ if (unlikely(lname->ln_namelen > m->mdd_dt_conf.ddp_max_name_len))
+ RETURN(-ENAMETOOLONG);
+
+ rc = mdd_permission_internal_locked(env, mdd_obj, pattr, mask,
+ MOR_TGT_PARENT);
+ if (rc)
+ RETURN(rc);
+
+ if (likely(S_ISDIR(mdd_object_type(mdd_obj)) &&
+ dt_try_as_dir(env, dir))) {
+
+ rc = dir->do_index_ops->dio_lookup(env, dir,
+ (struct dt_rec *)fid, key,
+ mdd_object_capa(env, mdd_obj));
+ if (rc > 0)
+ rc = 0;
+ else if (rc == 0)
+ rc = -ENOENT;
+ } else
+ rc = -ENOTDIR;
+
+ RETURN(rc);
}
int mdd_lookup(const struct lu_env *env,
- struct md_object *pobj, const struct lu_name *lname,
- struct lu_fid* fid, struct md_op_spec *spec)
+ struct md_object *pobj, const struct lu_name *lname,
+ struct lu_fid *fid, struct md_op_spec *spec)
{
+ struct lu_attr *pattr = MDD_ENV_VAR(env, pattr);
int rc;
ENTRY;
- rc = __mdd_lookup_locked(env, pobj, lname, fid, MAY_EXEC);
+
+ rc = mdd_la_get(env, md2mdd_obj(pobj), pattr, BYPASS_CAPA);
+ if (rc != 0)
+ RETURN(rc);
+
+ rc = __mdd_lookup(env, pobj, pattr, lname, fid, MAY_EXEC);
RETURN(rc);
}
-int mdd_parent_fid(const struct lu_env *env, struct mdd_object *obj,
- struct lu_fid *fid)
+static inline int mdd_parent_fid(const struct lu_env *env,
+ struct mdd_object *obj,
+ const struct lu_attr *attr,
+ struct lu_fid *fid)
{
- return __mdd_lookup_locked(env, &obj->mod_obj, &lname_dotdot, fid, 0);
+ return __mdd_lookup(env, &obj->mod_obj, attr, &lname_dotdot, fid, 0);
}
/*
* otherwise: values < 0, errors.
*/
static int mdd_is_parent(const struct lu_env *env,
- struct mdd_device *mdd,
- struct mdd_object *p1,
- const struct lu_fid *lf,
- struct lu_fid *pf)
+ struct mdd_device *mdd,
+ struct mdd_object *p1,
+ const struct lu_attr *attr,
+ const struct lu_fid *lf,
+ struct lu_fid *pf)
{
struct mdd_object *parent = NULL;
struct lu_fid *pfid;
RETURN(0);
for(;;) {
- /* this is done recursively, bypass capa for each obj */
- mdd_set_capainfo(env, 4, p1, BYPASS_CAPA);
- rc = mdd_parent_fid(env, p1, pfid);
- if (rc)
- GOTO(out, rc);
+ /* this is done recursively, bypass capa for each obj */
+ mdd_set_capainfo(env, 4, p1, BYPASS_CAPA);
+ rc = mdd_parent_fid(env, p1, attr, pfid);
+ if (rc)
+ GOTO(out, rc);
if (mdd_is_root(mdd, pfid))
GOTO(out, rc = 0);
+ if (lu_fid_eq(pfid, &mdd->mdd_local_root_fid))
+ GOTO(out, rc = 0);
if (lu_fid_eq(pfid, lf))
GOTO(out, rc = 1);
if (parent)
* returns < 0: if error
*/
int mdd_is_subdir(const struct lu_env *env, struct md_object *mo,
- const struct lu_fid *fid, struct lu_fid *sfid)
+ const struct lu_fid *fid, struct lu_fid *sfid)
{
- struct mdd_device *mdd = mdo2mdd(mo);
- int rc;
- ENTRY;
+ struct mdd_device *mdd = mdo2mdd(mo);
+ struct lu_attr *attr = MDD_ENV_VAR(env, cattr);
+ int rc;
+ ENTRY;
- if (!S_ISDIR(mdd_object_type(md2mdd_obj(mo))))
- RETURN(0);
+ if (!S_ISDIR(mdd_object_type(md2mdd_obj(mo))))
+ RETURN(0);
- rc = mdd_is_parent(env, mdd, md2mdd_obj(mo), fid, sfid);
- if (rc == 0) {
- /* found root */
- fid_zero(sfid);
- } else if (rc == 1) {
- /* found @fid is parent */
- *sfid = *fid;
- rc = 0;
- }
- RETURN(rc);
+ rc = mdd_la_get(env, md2mdd_obj(mo), attr, BYPASS_CAPA);
+ if (rc != 0)
+ RETURN(rc);
+
+ rc = mdd_is_parent(env, mdd, md2mdd_obj(mo), attr, fid, sfid);
+ if (rc == 0) {
+ /* found root */
+ fid_zero(sfid);
+ } else if (rc == 1) {
+ /* found @fid is parent */
+ *sfid = *fid;
+ rc = 0;
+ }
+ RETURN(rc);
}
/*
RETURN(result);
}
-static int __mdd_may_link(const struct lu_env *env, struct mdd_object *obj)
+static int __mdd_may_link(const struct lu_env *env, struct mdd_object *obj,
+ const struct lu_attr *la)
{
- struct mdd_device *m = mdd_obj2mdd_dev(obj);
- struct lu_attr *la = &mdd_env_info(env)->mti_la;
- int rc;
- ENTRY;
+ struct mdd_device *m = mdd_obj2mdd_dev(obj);
+ ENTRY;
- rc = mdd_la_get(env, obj, la, BYPASS_CAPA);
- if (rc)
- RETURN(rc);
+ LASSERT(la != NULL);
- /*
- * Subdir count limitation can be broken through.
- */
- if (la->la_nlink >= m->mdd_dt_conf.ddp_max_nlink &&
- !S_ISDIR(la->la_mode))
- RETURN(-EMLINK);
- else
- RETURN(0);
+ if (!S_ISDIR(la->la_mode))
+ RETURN(0);
+
+ /*
+ * Subdir count limitation can be broken through.
+ */
+ if (la->la_nlink >= m->mdd_dt_conf.ddp_max_nlink)
+ RETURN(-EMLINK);
+ else
+ RETURN(0);
}
/*
* Check whether it may create the cobj under the pobj.
* cobj maybe NULL
*/
-int mdd_may_create(const struct lu_env *env, struct mdd_object *pobj,
- struct mdd_object *cobj, int check_perm, int check_nlink)
+int mdd_may_create(const struct lu_env *env,
+ struct mdd_object *pobj, const struct lu_attr *pattr,
+ struct mdd_object *cobj, int check_perm, int check_nlink)
{
- int rc = 0;
- ENTRY;
+ int rc = 0;
+ ENTRY;
if (cobj && mdd_object_exists(cobj))
- RETURN(-EEXIST);
+ RETURN(-EEXIST);
- if (mdd_is_dead_obj(pobj))
- RETURN(-ENOENT);
+ if (mdd_is_dead_obj(pobj))
+ RETURN(-ENOENT);
- if (check_perm)
- rc = mdd_permission_internal_locked(env, pobj, NULL,
- MAY_WRITE | MAY_EXEC,
- MOR_TGT_PARENT);
- if (!rc && check_nlink)
- rc = __mdd_may_link(env, pobj);
+ if (check_perm)
+ rc = mdd_permission_internal_locked(env, pobj, pattr,
+ MAY_WRITE | MAY_EXEC,
+ MOR_TGT_PARENT);
+ if (!rc && check_nlink)
+ rc = __mdd_may_link(env, pobj, pattr);
- RETURN(rc);
+ RETURN(rc);
}
/*
* Check whether can unlink from the pobj in the case of "cobj == NULL".
*/
int mdd_may_unlink(const struct lu_env *env, struct mdd_object *pobj,
- const struct lu_attr *attr)
+ const struct lu_attr *pattr, const struct lu_attr *attr)
{
- int rc;
- ENTRY;
+ int rc;
+ ENTRY;
- if (mdd_is_dead_obj(pobj))
- RETURN(-ENOENT);
+ if (mdd_is_dead_obj(pobj))
+ RETURN(-ENOENT);
if ((attr->la_valid & LA_FLAGS) &&
(attr->la_flags & (LUSTRE_APPEND_FL | LUSTRE_IMMUTABLE_FL)))
- RETURN(-EPERM);
+ RETURN(-EPERM);
- rc = mdd_permission_internal_locked(env, pobj, NULL,
- MAY_WRITE | MAY_EXEC,
- MOR_TGT_PARENT);
- if (rc)
- RETURN(rc);
+ rc = mdd_permission_internal_locked(env, pobj, pattr,
+ MAY_WRITE | MAY_EXEC,
+ MOR_TGT_PARENT);
+ if (rc)
+ RETURN(rc);
- if (mdd_is_append(pobj))
- RETURN(-EPERM);
+ if (mdd_is_append(pobj))
+ RETURN(-EPERM);
- RETURN(rc);
+ RETURN(rc);
}
/*
*/
static inline int mdd_is_sticky(const struct lu_env *env,
struct mdd_object *pobj,
- struct mdd_object *cobj)
+ const struct lu_attr *pattr,
+ struct mdd_object *cobj,
+ const struct lu_attr *cattr)
{
- struct lu_attr *tmp_la = &mdd_env_info(env)->mti_la;
struct lu_ucred *uc = lu_ucred_assert(env);
- int rc;
- if (pobj) {
- rc = mdd_la_get(env, pobj, tmp_la, BYPASS_CAPA);
- if (rc)
- return rc;
-
- if (!(tmp_la->la_mode & S_ISVTX) ||
- (tmp_la->la_uid == uc->uc_fsuid))
+ if (pobj != NULL) {
+ LASSERT(pattr != NULL);
+ if (!(pattr->la_mode & S_ISVTX) ||
+ (pattr->la_uid == uc->uc_fsuid))
return 0;
}
- rc = mdd_la_get(env, cobj, tmp_la, BYPASS_CAPA);
- if (rc)
- return rc;
-
- if (tmp_la->la_uid == uc->uc_fsuid)
+ LASSERT(cattr != NULL);
+ if (cattr->la_uid == uc->uc_fsuid)
return 0;
return !md_capable(uc, CFS_CAP_FOWNER);
}
static int mdd_may_delete_entry(const struct lu_env *env,
- struct mdd_object *pobj, int check_perm)
+ struct mdd_object *pobj,
+ const struct lu_attr *pattr,
+ int check_perm)
{
ENTRY;
if (check_perm) {
int rc;
- rc = mdd_permission_internal_locked(env, pobj, NULL,
+ rc = mdd_permission_internal_locked(env, pobj, pattr,
MAY_WRITE | MAY_EXEC,
MOR_TGT_PARENT);
if (rc)
* Check whether it may delete the cobj from the pobj.
* pobj maybe NULL
*/
-int mdd_may_delete(const struct lu_env *env, struct mdd_object *pobj,
- struct mdd_object *cobj, struct lu_attr *cattr,
- struct lu_attr *src_attr, int check_perm, int check_empty)
+int mdd_may_delete(const struct lu_env *env, struct mdd_object *tpobj,
+ const struct lu_attr *tpattr, struct mdd_object *tobj,
+ const struct lu_attr *tattr, const struct lu_attr *cattr,
+ int check_perm, int check_empty)
{
- int rc = 0;
- ENTRY;
+ int rc = 0;
+ ENTRY;
- if (pobj) {
- rc = mdd_may_delete_entry(env, pobj, check_perm);
+ if (tpobj) {
+ LASSERT(tpattr != NULL);
+ rc = mdd_may_delete_entry(env, tpobj, tpattr, check_perm);
if (rc != 0)
RETURN(rc);
}
- if (cobj == NULL)
+ if (tobj == NULL)
RETURN(0);
- if (!mdd_object_exists(cobj))
- RETURN(-ENOENT);
-
- if (mdd_is_dead_obj(cobj))
- RETURN(-ESTALE);
+ if (!mdd_object_exists(tobj))
+ RETURN(-ENOENT);
+ if (mdd_is_dead_obj(tobj))
+ RETURN(-ESTALE);
- if (mdd_is_sticky(env, pobj, cobj))
- RETURN(-EPERM);
+ if (mdd_is_sticky(env, tpobj, tpattr, tobj, tattr))
+ RETURN(-EPERM);
- if (mdd_is_immutable(cobj) || mdd_is_append(cobj))
- RETURN(-EPERM);
+ if (mdd_is_immutable(tobj) || mdd_is_append(tobj))
+ RETURN(-EPERM);
- if ((cattr->la_valid & LA_FLAGS) &&
- (cattr->la_flags & (LUSTRE_APPEND_FL | LUSTRE_IMMUTABLE_FL)))
- RETURN(-EPERM);
+ if ((tattr->la_valid & LA_FLAGS) &&
+ (tattr->la_flags & (LUSTRE_APPEND_FL | LUSTRE_IMMUTABLE_FL)))
+ RETURN(-EPERM);
/* additional check the rename case */
- if (src_attr) {
- if (S_ISDIR(src_attr->la_mode)) {
- struct mdd_device *mdd = mdo2mdd(&cobj->mod_obj);
+ if (cattr) {
+ if (S_ISDIR(cattr->la_mode)) {
+ struct mdd_device *mdd = mdo2mdd(&tobj->mod_obj);
- if (!S_ISDIR(cattr->la_mode))
+ if (!S_ISDIR(tattr->la_mode))
RETURN(-ENOTDIR);
- if (lu_fid_eq(mdo2fid(cobj), &mdd->mdd_root_fid))
+ if (lu_fid_eq(mdo2fid(tobj), &mdd->mdd_root_fid))
RETURN(-EBUSY);
- } else if (S_ISDIR(cattr->la_mode))
+ } else if (S_ISDIR(tattr->la_mode))
RETURN(-EISDIR);
}
- if (S_ISDIR(cattr->la_mode) && check_empty)
- rc = mdd_dir_is_empty(env, cobj);
+ if (S_ISDIR(tattr->la_mode) && check_empty)
+ rc = mdd_dir_is_empty(env, tobj);
- RETURN(rc);
+ RETURN(rc);
}
/*
* tgt maybe NULL
* has mdd_write_lock on src already, but not on tgt yet
*/
-int mdd_link_sanity_check(const struct lu_env *env,
- struct mdd_object *tgt_obj,
- const struct lu_name *lname,
- struct mdd_object *src_obj)
+static int mdd_link_sanity_check(const struct lu_env *env,
+ struct mdd_object *tgt_obj,
+ const struct lu_attr *tattr,
+ const struct lu_name *lname,
+ struct mdd_object *src_obj,
+ const struct lu_attr *cattr)
{
struct mdd_device *m = mdd_obj2mdd_dev(src_obj);
int rc = 0;
if (S_ISDIR(mdd_object_type(src_obj)))
RETURN(-EPERM);
- LASSERT(src_obj != tgt_obj);
- if (tgt_obj) {
- rc = mdd_may_create(env, tgt_obj, NULL, 1, 0);
- if (rc)
- RETURN(rc);
- }
+ LASSERT(src_obj != tgt_obj);
+ if (tgt_obj) {
+ rc = mdd_may_create(env, tgt_obj, tattr, NULL, 1, 0);
+ if (rc)
+ RETURN(rc);
+ }
- rc = __mdd_may_link(env, src_obj);
+ rc = __mdd_may_link(env, src_obj, cattr);
- RETURN(rc);
+ RETURN(rc);
}
static int __mdd_index_delete_only(const struct lu_env *env, struct mdd_object *pobj,
linkea_add_buf(ldata, lname, tfid);
}
+ if (OBD_FAIL_CHECK(OBD_FAIL_LFSCK_LINKEA_MORE2))
+ linkea_add_buf(ldata, lname, pfid);
+
return linkea_add_buf(ldata, lname, pfid);
}
LASSERT(oldpfid != NULL || newpfid != NULL);
- if (mdd_obj->mod_flags & DEAD_OBJ)
+ if (mdd_obj->mod_flags & DEAD_OBJ) {
+ /* Prevent linkea to be updated which is NOT necessary. */
+ ldata->ld_reclen = 0;
/* No more links, don't bother */
RETURN(0);
+ }
if (oldpfid != NULL) {
rc = __mdd_links_del(env, mdd_obj, ldata, oldlname, oldpfid);
if (rc) {
- if ((check == 0) ||
+ if ((check == 1) ||
(rc != -ENODATA && rc != -ENOENT))
RETURN(rc);
/* No changes done. */
* old link */
rc2 = __mdd_links_add(env, mdd_obj, ldata, newlname, newpfid,
first, check);
- if (rc2 == -EEXIST)
- rc2 = 0;
}
rc = rc != 0 ? rc : rc2;
GOTO(out, rc);
}
- if (ldata->ld_lee != NULL)
+ if (ldata->ld_reclen != 0)
rc = mdd_links_write(env, mdd_obj, ldata, handle);
EXIT;
out:
rc = rc2;
if (rc) {
int error = 1;
- if (rc == -EOVERFLOW || rc == -ENOENT || rc == -ENOSPC)
+ if (rc == -EOVERFLOW || rc == -ENOSPC)
error = 0;
if (oldpfid == NULL)
CDEBUG(error ? D_ERROR : D_OTHER,
/* First try a small buf */
LASSERT(env != NULL);
ldata->ld_buf = lu_buf_check_and_alloc(&mdd_env_info(env)->mti_link_buf,
- CFS_PAGE_SIZE);
+ PAGE_CACHE_SIZE);
if (ldata->ld_buf->lb_buf == NULL)
return -ENOMEM;
if (rc < 0)
return rc;
- linkea_init(ldata);
- return 0;
+ return linkea_init(ldata);
}
/** Read the link EA into a temp buffer.
struct lu_attr *la = &mdd_env_info(env)->mti_la_for_fix;
struct mdd_object *mdd_tobj = md2mdd_obj(tgt_obj);
struct mdd_object *mdd_sobj = md2mdd_obj(src_obj);
+ struct lu_attr *cattr = MDD_ENV_VAR(env, cattr);
+ struct lu_attr *tattr = MDD_ENV_VAR(env, tattr);
struct mdd_device *mdd = mdo2mdd(src_obj);
- struct dynlock_handle *dlh;
struct thandle *handle;
struct linkea_data *ldata = &mdd_env_info(env)->mti_link_data;
- int rc;
- ENTRY;
+ int rc;
+ ENTRY;
+
+ rc = mdd_la_get(env, mdd_sobj, cattr, BYPASS_CAPA);
+ if (rc != 0)
+ RETURN(rc);
+
+ rc = mdd_la_get(env, mdd_tobj, tattr, BYPASS_CAPA);
+ if (rc != 0)
+ RETURN(rc);
handle = mdd_trans_create(env, mdd);
if (IS_ERR(handle))
if (rc)
GOTO(stop, rc);
- dlh = mdd_pdo_write_lock(env, mdd_tobj, name, MOR_TGT_CHILD);
- if (dlh == NULL)
- GOTO(out_trans, rc = -ENOMEM);
- mdd_write_lock(env, mdd_sobj, MOR_TGT_CHILD);
-
- rc = mdd_link_sanity_check(env, mdd_tobj, lname, mdd_sobj);
- if (rc)
- GOTO(out_unlock, rc);
+ mdd_write_lock(env, mdd_sobj, MOR_TGT_CHILD);
+ rc = mdd_link_sanity_check(env, mdd_tobj, tattr, lname, mdd_sobj,
+ cattr);
+ if (rc)
+ GOTO(out_unlock, rc);
rc = mdo_ref_add(env, mdd_sobj, handle);
if (rc)
GOTO(out_unlock, rc);
}
- la->la_valid = LA_CTIME | LA_MTIME;
- rc = mdd_attr_check_set_internal(env, mdd_tobj, la, handle, 0);
- if (rc)
- GOTO(out_unlock, rc);
+ la->la_valid = LA_CTIME | LA_MTIME;
+ rc = mdd_update_time(env, mdd_tobj, tattr, la, handle);
+ if (rc)
+ GOTO(out_unlock, rc);
- la->la_valid = LA_CTIME;
- rc = mdd_attr_check_set_internal(env, mdd_sobj, la, handle, 0);
+ la->la_valid = LA_CTIME;
+ rc = mdd_update_time(env, mdd_sobj, cattr, la, handle);
if (rc == 0) {
rc = mdd_linkea_prepare(env, mdd_sobj, NULL, NULL,
mdo2fid(mdd_tobj), lname, 0, 0,
EXIT;
out_unlock:
mdd_write_unlock(env, mdd_sobj);
- mdd_pdo_write_unlock(env, mdd_tobj, dlh);
-out_trans:
if (rc == 0)
rc = mdd_changelog_ns_store(env, mdd, CL_HARDLINK, 0, mdd_sobj,
mdd_tobj, lname, handle);
* has mdd_write_lock on cobj already, but not on pobj yet
*/
int mdd_unlink_sanity_check(const struct lu_env *env, struct mdd_object *pobj,
- struct mdd_object *cobj, struct lu_attr *cattr)
+ const struct lu_attr *pattr,
+ struct mdd_object *cobj,
+ const struct lu_attr *cattr)
{
- int rc;
- ENTRY;
+ int rc;
+ ENTRY;
- rc = mdd_may_delete(env, pobj, cobj, cattr, NULL, 1, 1);
+ rc = mdd_may_delete(env, pobj, pattr, cobj, cattr, NULL, 1, 1);
- RETURN(rc);
+ RETURN(rc);
}
static int mdd_declare_unlink(const struct lu_env *env, struct mdd_device *mdd,
return rc;
}
+/*
+ * test if a file has an HSM archive
+ * if HSM attributes are not found in ma update them from
+ * HSM xattr
+ */
+static bool mdd_hsm_archive_exists(const struct lu_env *env,
+ struct mdd_object *obj,
+ struct md_attr *ma)
+{
+ ENTRY;
+
+ if (!(ma->ma_valid & MA_HSM)) {
+ /* no HSM MD provided, read xattr */
+ struct lu_buf *hsm_buf;
+ const size_t buflen = sizeof(struct hsm_attrs);
+ int rc;
+
+ hsm_buf = mdd_buf_get(env, NULL, 0);
+ lu_buf_alloc(hsm_buf, buflen);
+ rc = mdo_xattr_get(env, obj, hsm_buf, XATTR_NAME_HSM,
+ mdd_object_capa(env, obj));
+ rc = lustre_buf2hsm(hsm_buf->lb_buf, rc, &ma->ma_hsm);
+ lu_buf_free(hsm_buf);
+ if (rc < 0)
+ RETURN(false);
+
+ ma->ma_valid = MA_HSM;
+ }
+ if (ma->ma_hsm.mh_flags & HS_EXISTS)
+ RETURN(true);
+ RETURN(false);
+}
+
/**
* Delete name entry and the object.
* Note: no_name == 1 means it only destory the object, i.e. name_entry
struct md_object *cobj, const struct lu_name *lname,
struct md_attr *ma, int no_name)
{
- const char *name = lname->ln_name;
- struct lu_attr *cattr = &mdd_env_info(env)->mti_cattr;
- struct lu_attr *la = &mdd_env_info(env)->mti_la_for_fix;
- struct mdd_object *mdd_pobj = md2mdd_obj(pobj);
+ const char *name = lname->ln_name;
+ struct lu_attr *pattr = MDD_ENV_VAR(env, pattr);
+ struct lu_attr *cattr = MDD_ENV_VAR(env, cattr);
+ struct lu_attr *la = &mdd_env_info(env)->mti_la_for_fix;
+ struct mdd_object *mdd_pobj = md2mdd_obj(pobj);
struct mdd_object *mdd_cobj = NULL;
- struct mdd_device *mdd = mdo2mdd(pobj);
- struct dynlock_handle *dlh;
- struct thandle *handle;
+ struct mdd_device *mdd = mdo2mdd(pobj);
+ struct thandle *handle;
int rc, is_dir = 0;
- ENTRY;
+ ENTRY;
/* cobj == NULL means only delete name entry */
if (likely(cobj != NULL)) {
mdd_cobj = md2mdd_obj(cobj);
if (mdd_object_exists(mdd_cobj) == 0)
RETURN(-ENOENT);
- /* currently it is assume, it could only delete
- * name entry of remote directory */
- is_dir = 1;
}
+ rc = mdd_la_get(env, mdd_pobj, pattr, BYPASS_CAPA);
+ if (rc)
+ RETURN(rc);
+
+ if (likely(mdd_cobj != NULL)) {
+ /* fetch cattr */
+ rc = mdd_la_get(env, mdd_cobj, cattr, BYPASS_CAPA);
+ if (rc)
+ RETURN(rc);
+
+ is_dir = S_ISDIR(cattr->la_mode);
+ }
+
+ rc = mdd_unlink_sanity_check(env, mdd_pobj, pattr, mdd_cobj, cattr);
+ if (rc)
+ RETURN(rc);
+
handle = mdd_trans_create(env, mdd);
- if (IS_ERR(handle))
- RETURN(PTR_ERR(handle));
+ if (IS_ERR(handle))
+ RETURN(PTR_ERR(handle));
rc = mdd_declare_unlink(env, mdd, mdd_pobj, mdd_cobj,
lname, ma, handle, no_name);
if (rc)
GOTO(stop, rc);
- dlh = mdd_pdo_write_lock(env, mdd_pobj, name, MOR_TGT_PARENT);
- if (dlh == NULL)
- GOTO(stop, rc = -ENOMEM);
-
- if (likely(mdd_cobj != NULL)) {
+ if (likely(mdd_cobj != NULL))
mdd_write_lock(env, mdd_cobj, MOR_TGT_CHILD);
- /* fetch cattr */
- rc = mdd_la_get(env, mdd_cobj, cattr,
- mdd_object_capa(env, mdd_cobj));
- if (rc)
- GOTO(cleanup, rc);
-
- is_dir = S_ISDIR(cattr->la_mode);
-
- }
-
- rc = mdd_unlink_sanity_check(env, mdd_pobj, mdd_cobj, cattr);
- if (rc)
- GOTO(cleanup, rc);
-
if (likely(no_name == 0)) {
rc = __mdd_index_delete(env, mdd_pobj, name, is_dir, handle,
mdd_object_capa(env, mdd_pobj));
mdo_ref_del(env, mdd_cobj, handle);
/* fetch updated nlink */
- rc = mdd_la_get(env, mdd_cobj, cattr,
- mdd_object_capa(env, mdd_cobj));
+ rc = mdd_la_get(env, mdd_cobj, cattr, BYPASS_CAPA);
if (rc)
GOTO(cleanup, rc);
}
la->la_ctime = la->la_mtime = ma->ma_attr.la_ctime;
la->la_valid = LA_CTIME | LA_MTIME;
- rc = mdd_attr_check_set_internal(env, mdd_pobj, la, handle, 0);
+ rc = mdd_update_time(env, mdd_pobj, pattr, la, handle);
if (rc)
GOTO(cleanup, rc);
/* Enough for only unlink the entry */
- if (unlikely(mdd_cobj == NULL)) {
- mdd_pdo_write_unlock(env, mdd_pobj, dlh);
+ if (unlikely(mdd_cobj == NULL))
GOTO(stop, rc);
- }
if (cattr->la_nlink > 0 || mdd_cobj->mod_count > 0) {
- /* update ctime of an unlinked file only if it is still
- * opened or a link still exists */
- la->la_valid = LA_CTIME;
- rc = mdd_attr_check_set_internal(env, mdd_cobj, la, handle, 0);
- if (rc)
- GOTO(cleanup, rc);
- }
+ /* update ctime of an unlinked file only if it is still
+ * opened or a link still exists */
+ la->la_valid = LA_CTIME;
+ rc = mdd_update_time(env, mdd_cobj, cattr, la, handle);
+ if (rc)
+ GOTO(cleanup, rc);
+ }
/* XXX: this transfer to ma will be removed with LOD/OSP */
ma->ma_attr = *cattr;
ma->ma_valid |= MA_INODE;
- rc = mdd_finish_unlink(env, mdd_cobj, ma, handle);
+ rc = mdd_finish_unlink(env, mdd_cobj, ma, handle);
/* fetch updated nlink */
if (rc == 0)
- rc = mdd_la_get(env, mdd_cobj, cattr,
- mdd_object_capa(env, mdd_cobj));
+ rc = mdd_la_get(env, mdd_cobj, cattr, BYPASS_CAPA);
- if (!is_dir)
+ if (!is_dir)
/* old files may not have link ea; ignore errors */
mdd_links_del(env, mdd_cobj, mdo2fid(mdd_pobj), lname, handle);
ma->ma_attr = *cattr;
ma->ma_valid |= MA_INODE;
}
- EXIT;
+ EXIT;
cleanup:
- mdd_write_unlock(env, mdd_cobj);
- mdd_pdo_write_unlock(env, mdd_pobj, dlh);
- if (rc == 0) {
- int cl_flags;
+ mdd_write_unlock(env, mdd_cobj);
+ if (rc == 0) {
+ int cl_flags = 0;
- cl_flags = (cattr->la_nlink == 0) ? CLF_UNLINK_LAST : 0;
- if ((ma->ma_valid & MA_HSM) &&
- (ma->ma_hsm.mh_flags & HS_EXISTS))
- cl_flags |= CLF_UNLINK_HSM_EXISTS;
+ if (cattr->la_nlink == 0) {
+ cl_flags |= CLF_UNLINK_LAST;
+ /* search for an existing archive */
+ if (mdd_hsm_archive_exists(env, mdd_cobj, ma))
+ cl_flags |= CLF_UNLINK_HSM_EXISTS;
+ }
rc = mdd_changelog_ns_store(env, mdd,
is_dir ? CL_RMDIR : CL_UNLINK, cl_flags,
mdd_cobj, mdd_pobj, lname, handle);
- }
+ }
stop:
- mdd_trans_stop(env, mdd, rc, handle);
+ mdd_trans_stop(env, mdd, rc, handle);
- return rc;
+ return rc;
}
/*
RETURN(-ENOENT);
RETURN(0);
-
}
static int mdd_create_data(const struct lu_env *env, struct md_object *pobj,
struct md_object *cobj, const struct md_op_spec *spec,
struct md_attr *ma)
{
- struct mdd_device *mdd = mdo2mdd(cobj);
- struct mdd_object *mdd_pobj = md2mdd_obj(pobj);
- struct mdd_object *son = md2mdd_obj(cobj);
- struct thandle *handle;
+ struct mdd_device *mdd = mdo2mdd(cobj);
+ struct mdd_object *mdd_pobj = md2mdd_obj(pobj);
+ struct mdd_object *son = md2mdd_obj(cobj);
+ struct thandle *handle;
const struct lu_buf *buf;
- struct lu_attr *attr = &mdd_env_info(env)->mti_cattr;
- int rc;
- ENTRY;
+ struct lu_attr *attr = MDD_ENV_VAR(env, cattr);
+ int rc;
+ ENTRY;
- rc = mdd_cd_sanity_check(env, son);
- if (rc)
- RETURN(rc);
+ rc = mdd_cd_sanity_check(env, son);
+ if (rc)
+ RETURN(rc);
- if (!md_should_create(spec->sp_cr_flags))
- RETURN(0);
+ if (!md_should_create(spec->sp_cr_flags))
+ RETURN(0);
/*
* there are following use cases for this function:
* striping can be specified or not
* 2) CMD?
*/
- rc = mdd_la_get(env, son, attr, mdd_object_capa(env, son));
+ rc = mdd_la_get(env, son, attr, BYPASS_CAPA);
if (rc)
RETURN(rc);
/* calling ->ah_make_hint() is used to transfer information from parent */
- mdd_object_make_hint(env, mdd_pobj, son, attr);
+ mdd_object_make_hint(env, mdd_pobj, son, attr, spec);
handle = mdd_trans_create(env, mdd);
if (IS_ERR(handle))
* XXX: Setting the lov ea is not locked but setting the attr is locked?
* Should this be fixed?
*/
- CDEBUG(D_OTHER, "ea %p/%u, cr_flags %Lo, no_create %u\n",
+ CDEBUG(D_OTHER, "ea %p/%u, cr_flags "LPO64", no_create %u\n",
spec->u.sp_ea.eadata, spec->u.sp_ea.eadatalen,
spec->sp_cr_flags, spec->no_create);
- if (spec->no_create || spec->sp_cr_flags & MDS_OPEN_HAS_EA) {
- /* replay case or lfs setstripe */
+ if (spec->no_create || (spec->sp_cr_flags & MDS_OPEN_HAS_EA)) {
buf = mdd_buf_get_const(env, spec->u.sp_ea.eadata,
spec->u.sp_ea.eadatalen);
} else {
RETURN(rc);
}
-/* Get fid from name and parent */
-static int
-__mdd_lookup(const struct lu_env *env, struct md_object *pobj,
- const struct lu_name *lname, struct lu_fid* fid, int mask)
-{
- const char *name = lname->ln_name;
- const struct dt_key *key = (const struct dt_key *)name;
- struct mdd_object *mdd_obj = md2mdd_obj(pobj);
- struct mdd_device *m = mdo2mdd(pobj);
- struct dt_object *dir = mdd_object_child(mdd_obj);
- int rc;
- ENTRY;
-
- if (unlikely(mdd_is_dead_obj(mdd_obj)))
- RETURN(-ESTALE);
-
- if (mdd_object_remote(mdd_obj)) {
- CDEBUG(D_INFO, "%s: Object "DFID" locates on remote server\n",
- mdd2obd_dev(m)->obd_name, PFID(mdo2fid(mdd_obj)));
- } else if (!mdd_object_exists(mdd_obj)) {
- RETURN(-ESTALE);
- }
-
- /* The common filename length check. */
- if (unlikely(lname->ln_namelen > m->mdd_dt_conf.ddp_max_name_len))
- RETURN(-ENAMETOOLONG);
-
- rc = mdd_permission_internal_locked(env, mdd_obj, NULL, mask,
- MOR_TGT_PARENT);
- if (rc)
- RETURN(rc);
-
- if (likely(S_ISDIR(mdd_object_type(mdd_obj)) &&
- dt_try_as_dir(env, dir))) {
-
- rc = dir->do_index_ops->dio_lookup(env, dir,
- (struct dt_rec *)fid, key,
- mdd_object_capa(env, mdd_obj));
- if (rc > 0)
- rc = 0;
- else if (rc == 0)
- rc = -ENOENT;
- } else
- rc = -ENOTDIR;
-
- RETURN(rc);
-}
-
static int mdd_declare_object_initialize(const struct lu_env *env,
struct mdd_object *parent,
struct mdd_object *child,
/* has not lock on pobj yet */
static int mdd_create_sanity_check(const struct lu_env *env,
struct md_object *pobj,
- struct lu_attr *pattr,
+ const struct lu_attr *pattr,
const struct lu_name *lname,
struct lu_attr *cattr,
struct md_op_spec *spec)
* _index_insert also, for avoiding rolling back if exists
* _index_insert.
*/
- rc = __mdd_lookup_locked(env, pobj, lname, fid,
- MAY_WRITE | MAY_EXEC);
+ rc = __mdd_lookup(env, pobj, pattr, lname, fid,
+ MAY_WRITE | MAY_EXEC);
if (rc != -ENOENT)
RETURN(rc ? : -EEXIST);
} else {
- /*
- * Check WRITE permission for the parent.
- * EXEC permission have been checked
- * when lookup before create already.
- */
+ /*
+ * Check WRITE permission for the parent.
+ * EXEC permission have been checked
+ * when lookup before create already.
+ */
rc = mdd_permission_internal_locked(env, obj, pattr, MAY_WRITE,
MOR_TGT_PARENT);
- if (rc)
- RETURN(rc);
- }
+ if (rc)
+ RETURN(rc);
+ }
/* sgid check */
if (pattr->la_mode & S_ISGID) {
struct mdd_object *p, struct mdd_object *c,
const struct lu_name *name,
struct lu_attr *attr,
- int got_def_acl,
struct thandle *handle,
const struct md_op_spec *spec,
- struct linkea_data *ldata)
+ struct linkea_data *ldata,
+ struct lu_buf *def_acl_buf,
+ struct lu_buf *acl_buf)
{
int rc;
GOTO(out, rc);
#ifdef CONFIG_FS_POSIX_ACL
- if (got_def_acl > 0) {
- struct lu_buf *acl_buf;
-
- acl_buf = mdd_buf_get(env, NULL, got_def_acl);
+ if (def_acl_buf->lb_len > 0 && S_ISDIR(attr->la_mode)) {
/* if dir, then can inherit default ACl */
- if (S_ISDIR(attr->la_mode)) {
- rc = mdo_declare_xattr_set(env, c, acl_buf,
- XATTR_NAME_ACL_DEFAULT,
- 0, handle);
- if (rc)
- GOTO(out, rc);
- }
+ rc = mdo_declare_xattr_set(env, c, def_acl_buf,
+ XATTR_NAME_ACL_DEFAULT,
+ 0, handle);
+ if (rc)
+ GOTO(out, rc);
+ }
+ if (acl_buf->lb_len > 0) {
rc = mdo_declare_attr_set(env, c, attr, handle);
if (rc)
GOTO(out, rc);
GOTO(out, rc);
/* replay case, create LOV EA from client data */
- if (spec->no_create || (spec->sp_cr_flags & MDS_OPEN_HAS_EA)) {
+ if (spec->no_create ||
+ (spec->sp_cr_flags & MDS_OPEN_HAS_EA && S_ISREG(attr->la_mode))) {
const struct lu_buf *buf;
buf = mdd_buf_get_const(env, spec->u.sp_ea.eadata,
spec->u.sp_ea.eadatalen);
- rc = mdo_declare_xattr_set(env, c, buf, XATTR_NAME_LOV,
- 0, handle);
+ rc = mdo_declare_xattr_set(env, c, buf, XATTR_NAME_LOV, 0,
+ handle);
if (rc)
GOTO(out, rc);
}
}
if (!(spec->sp_cr_flags & MDS_OPEN_VOLATILE)) {
- rc = mdo_declare_attr_set(env, p, attr, handle);
+ struct lu_attr *la = &mdd_env_info(env)->mti_la_for_fix;
+
+ *la = *attr;
+ la->la_valid = LA_CTIME | LA_MTIME;
+ rc = mdo_declare_attr_set(env, p, la, handle);
if (rc)
return rc;
}
if (rc)
return rc;
+ /* XXX: For remote create, it should indicate the remote RPC
+ * will be sent after local transaction is finished, which
+ * is not very nice, but it will be removed once we fully support
+ * async update */
+ if (mdd_object_remote(p) && handle->th_update != NULL)
+ handle->th_update->tu_sent_after_local_trans = 1;
out:
- return rc;
+ return rc;
}
static int mdd_acl_init(const struct lu_env *env, struct mdd_object *pobj,
- struct lu_attr *la, struct lu_buf *acl_buf,
- int *got_def_acl, int *reset_acl)
+ struct lu_attr *la, struct lu_buf *def_acl_buf,
+ struct lu_buf *acl_buf)
{
int rc;
ENTRY;
- if (S_ISLNK(la->la_mode))
+ if (S_ISLNK(la->la_mode)) {
+ acl_buf->lb_len = 0;
+ def_acl_buf->lb_len = 0;
RETURN(0);
+ }
mdd_read_lock(env, pobj, MOR_TGT_PARENT);
- rc = mdo_xattr_get(env, pobj, acl_buf,
+ rc = mdo_xattr_get(env, pobj, def_acl_buf,
XATTR_NAME_ACL_DEFAULT, BYPASS_CAPA);
mdd_read_unlock(env, pobj);
if (rc > 0) {
- /* If there are default ACL, fix mode by default ACL */
- *got_def_acl = rc;
+ /* If there are default ACL, fix mode/ACL by default ACL */
+ def_acl_buf->lb_len = rc;
+ LASSERT(def_acl_buf->lb_len <= acl_buf->lb_len);
+ memcpy(acl_buf->lb_buf, def_acl_buf->lb_buf, rc);
acl_buf->lb_len = rc;
rc = __mdd_fix_mode_acl(env, acl_buf, &la->la_mode);
if (rc < 0)
RETURN(rc);
- *reset_acl = rc;
} else if (rc == -ENODATA || rc == -EOPNOTSUPP) {
/* If there are no default ACL, fix mode by mask */
struct lu_ucred *uc = lu_ucred(env);
if (unlikely(uc != NULL))
la->la_mode &= ~uc->uc_umask;
rc = 0;
+ acl_buf->lb_len = 0;
+ def_acl_buf->lb_len = 0;
}
RETURN(rc);
struct thandle *handle;
struct lu_attr *pattr = &info->mti_pattr;
struct lu_buf acl_buf;
+ struct lu_buf def_acl_buf;
struct linkea_data *ldata = &info->mti_link_data;
- struct dynlock_handle *dlh;
const char *name = lname->ln_name;
int rc, created = 0, initialized = 0, inserted = 0;
- int got_def_acl = 0;
- int reset_acl = 0;
ENTRY;
/*
if (rc != 0)
RETURN(rc);
- /* Sanity checks before big job. */
+ /* Sanity checks before big job. */
rc = mdd_create_sanity_check(env, pobj, pattr, lname, attr, spec);
- if (rc)
- RETURN(rc);
+ if (rc)
+ RETURN(rc);
if (OBD_FAIL_CHECK(OBD_FAIL_MDS_DQACQ_NET))
GOTO(out_free, rc = -EINPROGRESS);
acl_buf.lb_buf = info->mti_xattr_buf;
acl_buf.lb_len = sizeof(info->mti_xattr_buf);
- rc = mdd_acl_init(env, mdd_pobj, attr, &acl_buf, &got_def_acl,
- &reset_acl);
+ def_acl_buf.lb_buf = info->mti_key;
+ def_acl_buf.lb_len = sizeof(info->mti_key);
+ rc = mdd_acl_init(env, mdd_pobj, attr, &def_acl_buf, &acl_buf);
if (rc < 0)
GOTO(out_free, rc);
- mdd_object_make_hint(env, mdd_pobj, son, attr);
+ mdd_object_make_hint(env, mdd_pobj, son, attr, spec);
handle = mdd_trans_create(env, mdd);
if (IS_ERR(handle))
memset(ldata, 0, sizeof(*ldata));
mdd_linkea_prepare(env, son, NULL, NULL, mdd_object_fid(mdd_pobj),
lname, 1, 0, ldata);
+
rc = mdd_declare_create(env, mdd, mdd_pobj, son, lname, attr,
- got_def_acl, handle, spec, ldata);
+ handle, spec, ldata, &def_acl_buf, &acl_buf);
if (rc)
GOTO(out_stop, rc);
if (rc)
GOTO(out_stop, rc);
- dlh = mdd_pdo_write_lock(env, mdd_pobj, name, MOR_TGT_PARENT);
- if (dlh == NULL)
- GOTO(out_trans, rc = -ENOMEM);
-
mdd_write_lock(env, son, MOR_TGT_CHILD);
rc = mdd_object_create_internal(env, NULL, son, attr, handle, spec);
if (rc) {
created = 1;
#ifdef CONFIG_FS_POSIX_ACL
- if (got_def_acl) {
+ if (def_acl_buf.lb_len > 0 && S_ISDIR(attr->la_mode)) {
/* set default acl */
- if (S_ISDIR(attr->la_mode)) {
- LASSERTF(acl_buf.lb_len == got_def_acl,
- "invalid acl_buf: %p:%d got_def %d\n",
- acl_buf.lb_buf, (int)acl_buf.lb_len,
- got_def_acl);
- rc = mdo_xattr_set(env, son, &acl_buf,
- XATTR_NAME_ACL_DEFAULT, 0,
- handle, BYPASS_CAPA);
- if (rc) {
- mdd_write_unlock(env, son);
- GOTO(cleanup, rc);
- }
+ rc = mdo_xattr_set(env, son, &def_acl_buf,
+ XATTR_NAME_ACL_DEFAULT, 0,
+ handle, BYPASS_CAPA);
+ if (rc) {
+ mdd_write_unlock(env, son);
+ GOTO(cleanup, rc);
}
-
- /* set its own acl */
- if (reset_acl) {
- LASSERTF(acl_buf.lb_buf != NULL && acl_buf.lb_len != 0,
- "invalid acl_buf %p:%d\n", acl_buf.lb_buf,
- (int)acl_buf.lb_len);
- rc = mdo_xattr_set(env, son, &acl_buf,
- XATTR_NAME_ACL_ACCESS,
- 0, handle, BYPASS_CAPA);
- if (rc) {
- mdd_write_unlock(env, son);
- GOTO(cleanup, rc);
- }
+ }
+ /* set its own acl */
+ if (acl_buf.lb_len > 0) {
+ rc = mdo_xattr_set(env, son, &acl_buf,
+ XATTR_NAME_ACL_ACCESS,
+ 0, handle, BYPASS_CAPA);
+ if (rc) {
+ mdd_write_unlock(env, son);
+ GOTO(cleanup, rc);
}
}
#endif
* probably this way we code can be made better.
*/
if (rc == 0 && (spec->no_create ||
- (spec->sp_cr_flags & MDS_OPEN_HAS_EA))) {
+ (spec->sp_cr_flags & MDS_OPEN_HAS_EA &&
+ S_ISREG(attr->la_mode)))) {
const struct lu_buf *buf;
buf = mdd_buf_get_const(env, spec->u.sp_ea.eadata,
spec->u.sp_ea.eadatalen);
rc = mdo_xattr_set(env, son, buf, XATTR_NAME_LOV, 0, handle,
- BYPASS_CAPA);
+ BYPASS_CAPA);
}
if (rc == 0 && spec->sp_cr_flags & MDS_OPEN_VOLATILE)
/* update parent directory mtime/ctime */
*la = *attr;
la->la_valid = LA_CTIME | LA_MTIME;
- rc = mdd_attr_check_set_internal(env, mdd_pobj, la, handle, 0);
+ rc = mdd_update_time(env, mdd_pobj, pattr, la, handle);
if (rc)
GOTO(cleanup, rc);
mdd_write_unlock(env, son);
}
- mdd_pdo_write_unlock(env, mdd_pobj, dlh);
-out_trans:
if (rc == 0 && fid_is_namespace_visible(mdo2fid(son)))
rc = mdd_changelog_ns_store(env, mdd,
S_ISDIR(attr->la_mode) ? CL_MKDIR :
static int mdd_rename_order(const struct lu_env *env,
struct mdd_device *mdd,
struct mdd_object *src_pobj,
+ const struct lu_attr *pattr,
struct mdd_object *tgt_pobj)
{
/* order of locking, 1 - tgt-src, 0 - src-tgt*/
} else if (lu_fid_eq(&mdd->mdd_root_fid, mdo2fid(tgt_pobj))) {
rc = MDD_RN_TGTSRC;
} else {
- rc = mdd_is_parent(env, mdd, src_pobj, mdo2fid(tgt_pobj), NULL);
+ rc = mdd_is_parent(env, mdd, src_pobj, pattr, mdo2fid(tgt_pobj),
+ NULL);
if (rc == -EREMOTE)
rc = 0;
/* has not mdd_write{read}_lock on any obj yet. */
static int mdd_rename_sanity_check(const struct lu_env *env,
struct mdd_object *src_pobj,
+ const struct lu_attr *pattr,
struct mdd_object *tgt_pobj,
+ const struct lu_attr *tpattr,
struct mdd_object *sobj,
+ const struct lu_attr *cattr,
struct mdd_object *tobj,
- struct lu_attr *so_attr,
- struct lu_attr *tg_attr)
+ const struct lu_attr *tattr)
{
int rc = 0;
ENTRY;
* before mdd_rename and enable MDS_PERM_BYPASS. */
LASSERT(sobj);
- rc = mdd_may_delete(env, src_pobj, sobj, so_attr, NULL, 1, 0);
+ rc = mdd_may_delete(env, src_pobj, pattr, sobj, cattr, NULL, 1, 0);
if (rc)
RETURN(rc);
* MDS_PERM_BYPASS).
* So check may_create, but not check may_unlink. */
if (!tobj)
- rc = mdd_may_create(env, tgt_pobj, NULL,
+ rc = mdd_may_create(env, tgt_pobj, tpattr, NULL,
(src_pobj != tgt_pobj), 0);
else
- rc = mdd_may_delete(env, tgt_pobj, tobj, tg_attr, so_attr,
+ rc = mdd_may_delete(env, tgt_pobj, tpattr, tobj, tattr, cattr,
(src_pobj != tgt_pobj), 1);
- if (!rc && !tobj && (src_pobj != tgt_pobj) &&
- S_ISDIR(so_attr->la_mode))
- rc = __mdd_may_link(env, tgt_pobj);
+ if (!rc && !tobj && (src_pobj != tgt_pobj) && S_ISDIR(cattr->la_mode))
+ rc = __mdd_may_link(env, tgt_pobj, tpattr);
RETURN(rc);
}
rc = mdo_declare_ref_add(env, mdd_tpobj, handle);
if (rc)
return rc;
-
}
la->la_valid = LA_CTIME | LA_MTIME;
la->la_valid = LA_CTIME;
rc = mdo_declare_attr_set(env, mdd_tobj, la, handle);
- if (rc)
- return rc;
+ if (rc)
+ return rc;
- mdd_declare_links_del(env, mdd_tobj, handle);
- if (rc)
- return rc;
+ rc = mdd_declare_links_del(env, mdd_tobj, handle);
+ if (rc)
+ return rc;
- rc = mdd_declare_finish_unlink(env, mdd_tobj, ma, handle);
- if (rc)
- return rc;
+ rc = mdd_declare_finish_unlink(env, mdd_tobj, ma, handle);
+ if (rc)
+ return rc;
}
rc = mdd_declare_changelog_ext_store(env, mdd, tname, sname, handle);
const char *sname = lsname->ln_name;
const char *tname = ltname->ln_name;
struct lu_attr *la = &mdd_env_info(env)->mti_la_for_fix;
- struct lu_attr *so_attr = &mdd_env_info(env)->mti_cattr;
- struct lu_attr *tg_attr = &mdd_env_info(env)->mti_pattr;
struct mdd_object *mdd_spobj = md2mdd_obj(src_pobj); /* source parent */
struct mdd_object *mdd_tpobj = md2mdd_obj(tgt_pobj);
struct mdd_device *mdd = mdo2mdd(src_pobj);
struct mdd_object *mdd_sobj = NULL; /* source object */
struct mdd_object *mdd_tobj = NULL;
- struct dynlock_handle *sdlh = NULL, *tdlh = NULL;
+ struct lu_attr *cattr = MDD_ENV_VAR(env, cattr);
+ struct lu_attr *pattr = MDD_ENV_VAR(env, pattr);
+ struct lu_attr *tattr = MDD_ENV_VAR(env, tattr);
+ struct lu_attr *tpattr = MDD_ENV_VAR(env, tpattr);
struct thandle *handle;
struct linkea_data *ldata = &mdd_env_info(env)->mti_link_data;
const struct lu_fid *tpobj_fid = mdo2fid(mdd_tpobj);
int rc, rc2;
ENTRY;
- if (tobj)
- mdd_tobj = md2mdd_obj(tobj);
+ if (tobj)
+ mdd_tobj = md2mdd_obj(tobj);
+
+ mdd_sobj = mdd_object_find(env, mdd, lf);
- mdd_sobj = mdd_object_find(env, mdd, lf);
+ rc = mdd_la_get(env, mdd_sobj, cattr, BYPASS_CAPA);
+ if (rc)
+ GOTO(out_pending, rc);
- rc = mdd_la_get(env, mdd_sobj, so_attr,
- mdd_object_capa(env, mdd_sobj));
+ rc = mdd_la_get(env, mdd_spobj, pattr, BYPASS_CAPA);
if (rc)
GOTO(out_pending, rc);
if (mdd_tobj) {
- rc = mdd_la_get(env, mdd_tobj, tg_attr,
- mdd_object_capa(env, mdd_tobj));
+ rc = mdd_la_get(env, mdd_tobj, tattr, BYPASS_CAPA);
if (rc)
GOTO(out_pending, rc);
}
- rc = mdd_rename_sanity_check(env, mdd_spobj, mdd_tpobj, mdd_sobj,
- mdd_tobj, so_attr, tg_attr);
+ rc = mdd_la_get(env, mdd_tpobj, tpattr, BYPASS_CAPA);
+ if (rc)
+ GOTO(out_pending, rc);
+
+ rc = mdd_rename_sanity_check(env, mdd_spobj, pattr, mdd_tpobj, tpattr,
+ mdd_sobj, cattr, mdd_tobj, tattr);
if (rc)
GOTO(out_pending, rc);
GOTO(stop, rc);
/* FIXME: Should consider tobj and sobj too in rename_lock. */
- rc = mdd_rename_order(env, mdd, mdd_spobj, mdd_tpobj);
- if (rc < 0)
- GOTO(cleanup_unlocked, rc);
-
- /* Get locks in determined order */
- if (rc == MDD_RN_SAME) {
- sdlh = mdd_pdo_write_lock(env, mdd_spobj,
- sname, MOR_SRC_PARENT);
- /* check hashes to determine do we need one lock or two */
- if (mdd_name2hash(sname) != mdd_name2hash(tname))
- tdlh = mdd_pdo_write_lock(env, mdd_tpobj, tname,
- MOR_TGT_PARENT);
- else
- tdlh = sdlh;
- } else if (rc == MDD_RN_SRCTGT) {
- sdlh = mdd_pdo_write_lock(env, mdd_spobj, sname,MOR_SRC_PARENT);
- tdlh = mdd_pdo_write_lock(env, mdd_tpobj, tname,MOR_TGT_PARENT);
- } else {
- tdlh = mdd_pdo_write_lock(env, mdd_tpobj, tname,MOR_SRC_PARENT);
- sdlh = mdd_pdo_write_lock(env, mdd_spobj, sname,MOR_TGT_PARENT);
- }
- if (sdlh == NULL || tdlh == NULL)
- GOTO(cleanup, rc = -ENOMEM);
+ rc = mdd_rename_order(env, mdd, mdd_spobj, pattr, mdd_tpobj);
+ if (rc < 0)
+ GOTO(cleanup_unlocked, rc);
- is_dir = S_ISDIR(so_attr->la_mode);
+ is_dir = S_ISDIR(cattr->la_mode);
/* Remove source name from source directory */
rc = __mdd_index_delete(env, mdd_spobj, sname, is_dir, handle,
la->la_ctime = la->la_mtime = ma->ma_attr.la_ctime;
/* XXX: mdd_sobj must be local one if it is NOT NULL. */
- if (mdd_sobj) {
- la->la_valid = LA_CTIME;
- rc = mdd_attr_check_set_internal(env, mdd_sobj, la, handle, 0);
- if (rc)
- GOTO(fixup_tpobj, rc);
- }
+ if (mdd_sobj) {
+ la->la_valid = LA_CTIME;
+ rc = mdd_update_time(env, mdd_sobj, cattr, la, handle);
+ if (rc)
+ GOTO(fixup_tpobj, rc);
+ }
/* Remove old target object
* For tobj is remote case cmm layer has processed
mdo_ref_del(env, mdd_tobj, handle);
/* Remove dot reference. */
- if (S_ISDIR(tg_attr->la_mode))
+ if (S_ISDIR(tattr->la_mode))
mdo_ref_del(env, mdd_tobj, handle);
tobj_ref = 1;
/* fetch updated nlink */
- rc = mdd_la_get(env, mdd_tobj, tg_attr,
- mdd_object_capa(env, mdd_tobj));
+ rc = mdd_la_get(env, mdd_tobj, tattr, BYPASS_CAPA);
if (rc != 0) {
CERROR("%s: Failed to get nlink for tobj "
DFID": rc = %d\n",
}
la->la_valid = LA_CTIME;
- rc = mdd_attr_check_set_internal(env, mdd_tobj, la, handle, 0);
+ rc = mdd_update_time(env, mdd_tobj, tattr, la, handle);
if (rc != 0) {
CERROR("%s: Failed to set ctime for tobj "
DFID": rc = %d\n",
}
/* XXX: this transfer to ma will be removed with LOD/OSP */
- ma->ma_attr = *tg_attr;
+ ma->ma_attr = *tattr;
ma->ma_valid |= MA_INODE;
rc = mdd_finish_unlink(env, mdd_tobj, ma, handle);
if (rc != 0) {
}
/* fetch updated nlink */
- rc = mdd_la_get(env, mdd_tobj, tg_attr,
- mdd_object_capa(env, mdd_tobj));
+ rc = mdd_la_get(env, mdd_tobj, tattr, BYPASS_CAPA);
if (rc != 0) {
CERROR("%s: Failed to get nlink for tobj "
DFID": rc = %d\n",
GOTO(fixup_tpobj, rc);
}
/* XXX: this transfer to ma will be removed with LOD/OSP */
- ma->ma_attr = *tg_attr;
+ ma->ma_attr = *tattr;
ma->ma_valid |= MA_INODE;
- if (so_attr->la_nlink == 0)
+ if (tattr->la_nlink == 0) {
cl_flags |= CLF_RENAME_LAST;
+ if (mdd_hsm_archive_exists(env, mdd_tobj, ma))
+ cl_flags |= CLF_RENAME_LAST_EXISTS;
+ }
}
- la->la_valid = LA_CTIME | LA_MTIME;
- rc = mdd_attr_check_set_internal(env, mdd_spobj, la, handle, 0);
- if (rc)
- GOTO(fixup_tpobj, rc);
+ la->la_valid = LA_CTIME | LA_MTIME;
+ rc = mdd_update_time(env, mdd_spobj, pattr, la, handle);
+ if (rc)
+ GOTO(fixup_tpobj, rc);
- if (mdd_spobj != mdd_tpobj) {
- la->la_valid = LA_CTIME | LA_MTIME;
- rc = mdd_attr_check_set_internal(env, mdd_tpobj, la,
- handle, 0);
- }
+ if (mdd_spobj != mdd_tpobj) {
+ la->la_valid = LA_CTIME | LA_MTIME;
+ rc = mdd_update_time(env, mdd_tpobj, tpattr, la, handle);
+ }
if (rc == 0 && mdd_sobj) {
mdd_write_lock(env, mdd_sobj, MOR_SRC_CHILD);
cleanup:
if (tobj_locked)
mdd_write_unlock(env, mdd_tobj);
- if (likely(tdlh) && sdlh != tdlh)
- mdd_pdo_write_unlock(env, mdd_tpobj, tdlh);
- if (likely(sdlh))
- mdd_pdo_write_unlock(env, mdd_spobj, sdlh);
cleanup_unlocked:
if (rc == 0)
rc = mdd_changelog_ext_ns_store(env, mdd, CL_RENAME, cl_flags,