*/
/*
* This file is part of Lustre, http://www.lustre.org/
- * Lustre is a trademark of Sun Microsystems, Inc.
*
* lustre/mdd/mdd_device.c
*
struct llog_rec_hdr *hdr, void *data)
{
struct llog_changelog_rec *rec = (struct llog_changelog_rec *)hdr;
- struct llog_cookie cookie;
struct changelog_cancel_cookie *cl_cookie =
(struct changelog_cancel_cookie *)data;
- int rc;
ENTRY;
/* records are in order, so we're done */
RETURN(LLOG_PROC_BREAK);
- cookie.lgc_lgl = llh->lgh_id;
- cookie.lgc_index = hdr->lrh_index;
+ if (unlikely(OBD_FAIL_PRECHECK(OBD_FAIL_MDS_CHANGELOG_RACE))) {
+ if (cfs_fail_val == 0)
+ cfs_fail_val = hdr->lrh_index;
+ if (cfs_fail_val == hdr->lrh_index)
+ OBD_RACE(OBD_FAIL_MDS_CHANGELOG_RACE);
+ }
+
+ /* Records folow one by one, cr_index++. We could calculate the
+ * last cr_index at this plain llog. And if it less then cookie endrec
+ * cancel the whole file.
+ */
+ if ((LLOG_HDR_BITMAP_SIZE(llh->lgh_hdr) - hdr->lrh_index +
+ rec->cr.cr_index) < cl_cookie->endrec) {
+ int rc;
+
+ if (unlikely(OBD_FAIL_PRECHECK(OBD_FAIL_MDS_CHANGELOG_DEL))) {
+ if (cfs_fail_val == 0) {
+ cfs_fail_val = (unsigned long)llh & 0xFFFFFFFF;
+ OBD_RACE(OBD_FAIL_MDS_CHANGELOG_DEL);
+ }
+ }
+ rc = llog_destroy(env, llh);
+ if (!rc) {
+ CDEBUG(D_HA, "Changelog destroyed plain "DFID"\n",
+ PFID(&llh->lgh_id.lgl_oi.oi_fid));
+ RETURN(LLOG_DEL_PLAIN);
+ }
+ }
/* cancel them one at a time. I suppose we could store up the cookies
* and cancel them all at once; probably more efficient, but this is
* done as a user call, so who cares... */
- rc = llog_cat_cancel_records(env, llh->u.phd.phd_cat_handle, 1,
- &cookie);
- RETURN(rc < 0 ? rc : 0);
+
+ RETURN(LLOG_DEL_RECORD);
}
static int llog_changelog_cancel(const struct lu_env *env,
struct obd_device *obd = mdd2obd_dev(mdd);
struct llog_ctxt *ctxt;
- mdd->mdd_cl.mc_flags = 0;
+ if (mdd->mdd_cl.mc_flags & CLM_CLEANUP_DONE)
+ return;
+ mdd->mdd_cl.mc_flags = CLM_CLEANUP_DONE;
again:
/* stop GC-thread if running */
ENTRY;
- if (mdd->mdd_cl.mc_mask & (1 << CL_MARK)) {
+ if (mdd->mdd_cl.mc_mask & BIT(CL_MARK)) {
mdd->mdd_cl.mc_starttime = ktime_get();
RETURN(0);
}
reclen = llog_data_len(sizeof(*rec) + len);
- buf = lu_buf_check_and_alloc(&mdd_env_info(env)->mti_big_buf, reclen);
+ buf = lu_buf_check_and_alloc(&mdd_env_info(env)->mti_chlg_buf, reclen);
if (buf->lb_buf == NULL)
RETURN(-ENOMEM);
rec = buf->lb_buf;
name++;
sscanf(name, SFID, RFID(f));
- if (!fid_is_sane(f)) {
- CWARN("%s: Trying to lookup invalid FID [%s] in %s/%s, FID "
- "format should be "DFID"\n", mdd2obd_dev(mdd)->obd_name,
- lname->ln_name, dot_lustre_name, mdd_obf_dir_name,
- (__u64)FID_SEQ_NORMAL, 1, 0);
- GOTO(out, rc = -EINVAL);
- }
+ if (!fid_is_sane(f))
+ GOTO(out, rc = -ENOENT);
if (!fid_is_norm(f) && !fid_is_igif(f) && !fid_is_root(f) &&
- !fid_seq_is_dot(f->f_seq)) {
- CWARN("%s: Trying to lookup invalid FID "DFID" in %s/%s, sequence should be >= %#llx or within [%#llx, %#llx].\n",
- mdd2obd_dev(mdd)->obd_name, PFID(f),
- dot_lustre_name, mdd_obf_dir_name, (__u64)FID_SEQ_NORMAL,
- (__u64)FID_SEQ_IGIF, (__u64)FID_SEQ_IGIF_MAX);
- GOTO(out, rc = -EINVAL);
- }
+ !fid_seq_is_dot(f->f_seq))
+ GOTO(out, rc = -ENOENT);
/* Check if object with this fid exists */
child = mdd_object_find(env, mdd, f);
RETURN(-EPERM);
}
-static struct md_dir_operations mdd_obf_dir_ops = {
+static const struct md_dir_operations mdd_obf_dir_ops = {
.mdo_lookup = obf_lookup,
.mdo_create = mdd_obf_create,
.mdo_rename = mdd_dummy_rename,
.mdo_unlink = mdd_dummy_unlink
};
-static struct md_dir_operations mdd_lpf_dir_ops = {
+static const struct md_dir_operations mdd_lpf_dir_ops = {
.mdo_lookup = mdd_lookup,
.mdo_create = mdd_dummy_create,
.mdo_rename = mdd_dummy_rename,
LASSERT(obj != NULL);
mdo = lu2md(obj);
} else {
- mdo = ERR_PTR(PTR_ERR(obj));
+ mdo = ERR_CAST(obj);
}
return mdo;
}
mdd_changelog_clear_cb, (void *)&mcuc,
0, 0);
- if (rc < 0) {
+ if (rc == -EINVAL) {
+ CDEBUG(D_IOCTL, "%s: No changelog recnum <= %llu to clear\n",
+ mdd2obd_dev(mdd)->obd_name, (unsigned long long) endrec);
+ RETURN(-EINVAL);
+ } else if (rc < 0) {
CWARN("%s: Failure to clear the changelog for user %d: %d\n",
mdd2obd_dev(mdd)->obd_name, id, rc);
} else if (mcuc.mcuc_flush) {
mcuc.mcuc_minrec);
}
} else {
- CWARN("%s: No entry for user %d\n",
+ CDEBUG(D_IOCTL, "%s: No entry for user %d\n",
mdd2obd_dev(mdd)->obd_name, id);
rc = -ENOENT;
}
.mdo_dtconf_get = mdd_dtconf_get,
};
-static struct lu_device_type_operations mdd_device_type_ops = {
- .ldto_init = mdd_type_init,
- .ldto_fini = mdd_type_fini,
+static const struct lu_device_type_operations mdd_device_type_ops = {
+ .ldto_init = mdd_type_init,
+ .ldto_fini = mdd_type_fini,
- .ldto_start = mdd_type_start,
- .ldto_stop = mdd_type_stop,
+ .ldto_start = mdd_type_start,
+ .ldto_stop = mdd_type_stop,
- .ldto_device_alloc = mdd_device_alloc,
- .ldto_device_free = mdd_device_free,
+ .ldto_device_alloc = mdd_device_alloc,
+ .ldto_device_free = mdd_device_free,
- .ldto_device_fini = mdd_device_fini
+ .ldto_device_fini = mdd_device_fini
};
static struct lu_device_type mdd_device_type = {
lu_buf_free(&info->mti_big_buf);
lu_buf_free(&info->mti_link_buf);
lu_buf_free(&info->mti_xattr_buf);
+ lu_buf_free(&info->mti_chlg_buf);
OBD_FREE_PTR(info);
}
changelog_orig_logops = llog_common_cat_ops;
changelog_orig_logops.lop_write_rec = mdd_changelog_write_rec;
- rc = class_register_type(&mdd_obd_device_ops, NULL, false, NULL,
+ rc = class_register_type(&mdd_obd_device_ops, NULL, false,
LUSTRE_MDD_NAME, &mdd_device_type);
if (rc)
lu_kmem_fini(mdd_caches);