LU-5577 mdc: fix comparison between signed and unsigned

[fs/lustre-release.git] / lustre / mdc / mdc_lib.c

diff --git a/lustre/mdc/mdc_lib.c b/lustre/mdc/mdc_lib.c
index 092ba2b..279152d 100644 (file)
--- a/lustre/mdc/mdc_lib.c
+++ b/lustre/mdc/mdc_lib.c
@@ -90,7 +90,7 @@ void mdc_swap_layouts_pack(struct ptlrpc_request *req,
 
 void mdc_pack_body(struct ptlrpc_request *req,
                   const struct lu_fid *fid, struct obd_capa *oc,
-                  __u64 valid, int ea_size, __u32 suppgid, int flags)
+                  __u64 valid, size_t ea_size, __u32 suppgid, __u32 flags)
 {
        struct mdt_body *b = req_capsule_client_get(&req->rq_pill,
                                                    &RMF_MDT_BODY);
@@ -138,8 +138,8 @@ static void mdc_pack_name(struct ptlrpc_request *req,
        LASSERT(cpy_len == name_len && lu_name_is_valid_2(buf, cpy_len));
 }
 
-void mdc_readdir_pack(struct ptlrpc_request *req, __u64 pgoff,
-                      __u32 size, const struct lu_fid *fid, struct obd_capa *oc)
+void mdc_readdir_pack(struct ptlrpc_request *req, __u64 pgoff, size_t size,
+                     const struct lu_fid *fid, struct obd_capa *oc)
 {
         struct mdt_body *b = req_capsule_client_get(&req->rq_pill,
                                                     &RMF_MDT_BODY);
@@ -155,8 +155,8 @@ void mdc_readdir_pack(struct ptlrpc_request *req, __u64 pgoff,
 
 /* packing of MDS records */
 void mdc_create_pack(struct ptlrpc_request *req, struct md_op_data *op_data,
-                     const void *data, int datalen, __u32 mode,
-                     __u32 uid, __u32 gid, cfs_cap_t cap_effective, __u64 rdev)
+                    const void *data, size_t datalen, umode_t mode,
+                    uid_t uid, gid_t gid, cfs_cap_t cap_effective, __u64 rdev)
 {
        struct mdt_rec_create   *rec;
        char                    *tmp;
@@ -193,7 +193,7 @@ void mdc_create_pack(struct ptlrpc_request *req, struct md_op_data *op_data,
        }
 }
 
-static __u64 mds_pack_open_flags(__u64 flags, __u32 mode)
+static inline __u64 mds_pack_open_flags(__u64 flags)
 {
        __u64 cr_flags = (flags & (FMODE_READ | FMODE_WRITE |
                                   MDS_OPEN_FL_INTERNAL));
@@ -225,8 +225,8 @@ static __u64 mds_pack_open_flags(__u64 flags, __u32 mode)
 
 /* packing of MDS records */
 void mdc_open_pack(struct ptlrpc_request *req, struct md_op_data *op_data,
-                  __u32 mode, __u64 rdev, __u64 flags, const void *lmm,
-                  int lmmlen)
+                  umode_t mode, __u64 rdev, __u64 flags, const void *lmm,
+                  size_t lmmlen)
 {
        struct mdt_rec_create *rec;
        char *tmp;
@@ -241,7 +241,7 @@ void mdc_open_pack(struct ptlrpc_request *req, struct md_op_data *op_data,
        rec->cr_fsgid   = from_kgid(&init_user_ns, current_fsgid());
        rec->cr_cap    = cfs_curproc_cap_pack();
        rec->cr_mode   = mode;
-       cr_flags = mds_pack_open_flags(flags, mode);
+       cr_flags        = mds_pack_open_flags(flags);
        rec->cr_rdev   = rdev;
        rec->cr_umask  = current_umask();
        if (op_data != NULL) {
@@ -355,7 +355,7 @@ static void mdc_ioepoch_pack(struct mdt_ioepoch *epoch,
 }
 
 void mdc_setattr_pack(struct ptlrpc_request *req, struct md_op_data *op_data,
-                      void *ea, int ealen, void *ea2, int ea2len)
+                     void *ea, size_t ealen, void *ea2, size_t ea2len)
 {
         struct mdt_rec_setattr *rec;
         struct mdt_ioepoch *epoch;
@@ -444,7 +444,8 @@ void mdc_link_pack(struct ptlrpc_request *req, struct md_op_data *op_data)
 }
 
 void mdc_rename_pack(struct ptlrpc_request *req, struct md_op_data *op_data,
-                     const char *old, int oldlen, const char *new, int newlen)
+                    const char *old, size_t oldlen,
+                    const char *new, size_t newlen)
 {
         struct mdt_rec_rename *rec;
 
@@ -474,8 +475,8 @@ void mdc_rename_pack(struct ptlrpc_request *req, struct md_op_data *op_data,
                mdc_pack_name(req, &RMF_SYMTGT, new, newlen);
 }
 
-void mdc_getattr_pack(struct ptlrpc_request *req, __u64 valid, int flags,
-                      struct md_op_data *op_data, int ea_size)
+void mdc_getattr_pack(struct ptlrpc_request *req, __u64 valid, __u32 flags,
+                     struct md_op_data *op_data, size_t ea_size)
 {
         struct mdt_body *b = req_capsule_client_get(&req->rq_pill,
                                                     &RMF_MDT_BODY);