Whamcloud - gitweb
LU-9679 lustre: avoid cast of file->private_data
[fs/lustre-release.git] / lustre / lov / lproc_lov.c
index 386ee62..234eeb3 100644 (file)
  *
  * You should have received a copy of the GNU General Public License
  * version 2 along with this program; If not, see
- * http://www.sun.com/software/products/lustre/docs/GPLv2.pdf
- *
- * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
- * CA 95054 USA or visit www.sun.com if you need additional information or
- * have any questions.
+ * http://www.gnu.org/licenses/gpl-2.0.html
  *
  * GPL HEADER END
  */
@@ -27,7 +23,7 @@
  * Copyright (c) 2002, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
  *
- * Copyright (c) 2012, 2015, Intel Corporation.
+ * Copyright (c) 2012, 2017, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
 #include <asm/statfs.h>
 #include <lprocfs_status.h>
 #include <obd_class.h>
-#include <lustre_param.h>
+#include <uapi/linux/lustre/lustre_param.h>
 #include "lov_internal.h"
 
-#ifdef CONFIG_PROC_FS
 static int lov_stripesize_seq_show(struct seq_file *m, void *v)
 {
        struct obd_device *dev = (struct obd_device *)m->private;
@@ -51,154 +46,171 @@ static int lov_stripesize_seq_show(struct seq_file *m, void *v)
        LASSERT(dev != NULL);
        desc = &dev->u.lov.desc;
 
-       return seq_printf(m, LPU64"\n", desc->ld_default_stripe_size);
+       seq_printf(m, "%llu\n", desc->ld_default_stripe_size);
+       return 0;
 }
 
 static ssize_t lov_stripesize_seq_write(struct file *file,
                                        const char __user *buffer,
                                        size_t count, loff_t *off)
 {
-       struct obd_device *dev = ((struct seq_file *)file->private_data)->private;
-        struct lov_desc *desc;
-        __u64 val;
-        int rc;
-
-        LASSERT(dev != NULL);
-        desc = &dev->u.lov.desc;
-        rc = lprocfs_write_u64_helper(buffer, count, &val);
-        if (rc)
-                return rc;
-
-        lov_fix_desc_stripe_size(&val);
-        desc->ld_default_stripe_size = val;
-        return count;
+       struct seq_file *m = file->private_data;
+       struct obd_device *dev = m->private;
+       struct lov_desc *desc;
+       char kernbuf[22] = "";
+       u64 val;
+       int rc;
+
+       LASSERT(dev != NULL);
+       desc = &dev->u.lov.desc;
+
+       if (count >= sizeof(kernbuf))
+               return -EINVAL;
+
+       if (copy_from_user(kernbuf, buffer, count))
+               return -EFAULT;
+       kernbuf[count] = 0;
+
+       rc = sysfs_memparse(kernbuf, count, &val, "B");
+       if (rc < 0)
+               return rc;
+
+       lov_fix_desc_stripe_size(&val);
+       desc->ld_default_stripe_size = val;
+
+       return count;
 }
 LPROC_SEQ_FOPS(lov_stripesize);
 
-static int lov_stripeoffset_seq_show(struct seq_file *m, void *v)
+static ssize_t stripeoffset_show(struct kobject *kobj, struct attribute *attr,
+                                char *buf)
 {
-       struct obd_device *dev = (struct obd_device *)m->private;
-       struct lov_desc *desc;
+       struct obd_device *dev = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+       struct lov_desc *desc = &dev->u.lov.desc;
 
-       LASSERT(dev != NULL);
-       desc = &dev->u.lov.desc;
-       return seq_printf(m, LPU64"\n", desc->ld_default_stripe_offset);
+       return sprintf(buf, "%lld\n", desc->ld_default_stripe_offset);
 }
 
-static ssize_t lov_stripeoffset_seq_write(struct file *file,
-                                         const char __user *buffer,
-                                         size_t count, loff_t *off)
+static ssize_t stripeoffset_store(struct kobject *kobj, struct attribute *attr,
+                                 const char *buf, size_t count)
 {
-       struct obd_device *dev = ((struct seq_file *)file->private_data)->private;
-        struct lov_desc *desc;
-        __u64 val;
-        int rc;
-
-        LASSERT(dev != NULL);
-        desc = &dev->u.lov.desc;
-        rc = lprocfs_write_u64_helper(buffer, count, &val);
-        if (rc)
-                return rc;
-
-        desc->ld_default_stripe_offset = val;
-        return count;
+       struct obd_device *dev = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+       struct lov_desc *desc = &dev->u.lov.desc;
+       long val;
+       int rc;
+
+       rc = kstrtol(buf, 0, &val);
+       if (rc)
+               return rc;
+       if (val < -1 || val > LOV_MAX_STRIPE_COUNT)
+               return -ERANGE;
+
+       desc->ld_default_stripe_offset = val;
+
+       return count;
 }
-LPROC_SEQ_FOPS(lov_stripeoffset);
+LUSTRE_RW_ATTR(stripeoffset);
 
-static int lov_stripetype_seq_show(struct seq_file *m, void *v)
+static ssize_t stripetype_show(struct kobject *kobj, struct attribute *attr,
+                              char *buf)
 {
-       struct obd_device* dev = (struct obd_device*)m->private;
-       struct lov_desc *desc;
+       struct obd_device *dev = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+       struct lov_desc *desc = &dev->u.lov.desc;
 
-       LASSERT(dev != NULL);
-       desc = &dev->u.lov.desc;
-       return seq_printf(m, "%u\n", desc->ld_pattern);
+       return sprintf(buf, "%u\n", desc->ld_pattern);
 }
 
-static ssize_t lov_stripetype_seq_write(struct file *file,
-                                       const char __user *buffer,
-                                       size_t count, loff_t *off)
+static ssize_t stripetype_store(struct kobject *kobj, struct attribute *attr,
+                               const char *buffer, size_t count)
 {
-       struct obd_device *dev = ((struct seq_file *)file->private_data)->private;
-        struct lov_desc *desc;
-        int val, rc;
-
-        LASSERT(dev != NULL);
-        desc = &dev->u.lov.desc;
-        rc = lprocfs_write_helper(buffer, count, &val);
-        if (rc)
-                return rc;
-
-        lov_fix_desc_pattern(&val);
-        desc->ld_pattern = val;
-        return count;
+       struct obd_device *dev = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+       struct lov_desc *desc = &dev->u.lov.desc;
+       u32 pattern;
+       int rc;
+
+       rc = kstrtouint(buffer, 0, &pattern);
+       if (rc)
+               return rc;
+
+       lov_fix_desc_pattern(&pattern);
+       desc->ld_pattern = pattern;
+
+       return count;
 }
-LPROC_SEQ_FOPS(lov_stripetype);
+LUSTRE_RW_ATTR(stripetype);
 
-static int lov_stripecount_seq_show(struct seq_file *m, void *v)
+static ssize_t stripecount_show(struct kobject *kobj, struct attribute *attr,
+                               char *buf)
 {
-       struct obd_device *dev = (struct obd_device *)m->private;
-       struct lov_desc *desc;
+       struct obd_device *dev = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+       struct lov_desc *desc = &dev->u.lov.desc;
 
-       LASSERT(dev != NULL);
-       desc = &dev->u.lov.desc;
-       return seq_printf(m, "%d\n",
-                         (__s16)(desc->ld_default_stripe_count + 1) - 1);
+       return sprintf(buf, "%d\n",
+                      (__s16)(desc->ld_default_stripe_count + 1) - 1);
 }
 
-static ssize_t lov_stripecount_seq_write(struct file *file,
-                                        const char __user *buffer,
-                                        size_t count, loff_t *off)
+static ssize_t stripecount_store(struct kobject *kobj, struct attribute *attr,
+                                const char *buffer, size_t count)
 {
-       struct obd_device *dev = ((struct seq_file *)file->private_data)->private;
-        struct lov_desc *desc;
-        int val, rc;
-
-        LASSERT(dev != NULL);
-        desc = &dev->u.lov.desc;
-        rc = lprocfs_write_helper(buffer, count, &val);
-        if (rc)
-                return rc;
-
-        lov_fix_desc_stripe_count(&val);
-        desc->ld_default_stripe_count = val;
-        return count;
+       struct obd_device *dev = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+       struct lov_desc *desc = &dev->u.lov.desc;
+       int stripe_count;
+       int rc;
+
+       rc = kstrtoint(buffer, 0, &stripe_count);
+       if (rc)
+               return rc;
+
+       if (stripe_count < -1)
+               return -ERANGE;
+
+       lov_fix_desc_stripe_count(&stripe_count);
+       desc->ld_default_stripe_count = stripe_count;
+
+       return count;
 }
-LPROC_SEQ_FOPS(lov_stripecount);
+LUSTRE_RW_ATTR(stripecount);
 
-static int lov_numobd_seq_show(struct seq_file *m, void *v)
+static ssize_t numobd_show(struct kobject *kobj, struct attribute *attr,
+                          char *buf)
 {
-       struct obd_device *dev = (struct obd_device*)m->private;
-       struct lov_desc *desc;
+       struct obd_device *dev = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+       struct lov_desc *desc = &dev->u.lov.desc;
 
-       LASSERT(dev != NULL);
-       desc = &dev->u.lov.desc;
-       return seq_printf(m, "%u\n", desc->ld_tgt_count);
+       return sprintf(buf, "%u\n", desc->ld_tgt_count);
 }
-LPROC_SEQ_FOPS_RO(lov_numobd);
+LUSTRE_RO_ATTR(numobd);
 
-static int lov_activeobd_seq_show(struct seq_file *m, void *v)
+static ssize_t activeobd_show(struct kobject *kobj, struct attribute *attr,
+                             char *buf)
 {
-       struct obd_device* dev = (struct obd_device*)m->private;
-       struct lov_desc *desc;
+       struct obd_device *dev = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+       struct lov_desc *desc = &dev->u.lov.desc;
 
-       LASSERT(dev != NULL);
-       desc = &dev->u.lov.desc;
-       return seq_printf(m, "%u\n", desc->ld_active_tgt_count);
+       return sprintf(buf, "%u\n", desc->ld_active_tgt_count);
 }
-LPROC_SEQ_FOPS_RO(lov_activeobd);
+LUSTRE_RO_ATTR(activeobd);
 
-static int lov_desc_uuid_seq_show(struct seq_file *m, void *v)
+static ssize_t desc_uuid_show(struct kobject *kobj, struct attribute *attr,
+                             char *buf)
 {
-       struct obd_device *dev = m->private;
-       struct lov_obd *lov;
+       struct obd_device *dev = container_of(kobj, struct obd_device,
+                                             obd_kset.kobj);
+       struct lov_desc *desc = &dev->u.lov.desc;
 
-       LASSERT(dev != NULL);
-       lov = &dev->u.lov;
-       return seq_printf(m, "%s\n", lov->desc.ld_uuid.uuid);
+       return sprintf(buf, "%s\n", desc->ld_uuid.uuid);
 }
-LPROC_SEQ_FOPS_RO(lov_desc_uuid);
+LUSTRE_RO_ATTR(desc_uuid);
 
+#ifdef CONFIG_PROC_FS
 static void *lov_tgt_seq_start(struct seq_file *p, loff_t *pos)
 {
         struct obd_device *dev = p->private;
@@ -231,9 +243,11 @@ static void *lov_tgt_seq_next(struct seq_file *p, void *v, loff_t *pos)
 static int lov_tgt_seq_show(struct seq_file *p, void *v)
 {
         struct lov_tgt_desc *tgt = v;
-       return seq_printf(p, "%d: %s %sACTIVE\n", tgt->ltd_index,
-                         obd_uuid2str(&tgt->ltd_uuid),
-                         tgt->ltd_active ? "" : "IN");
+
+       seq_printf(p, "%d: %s %sACTIVE\n", tgt->ltd_index,
+                  obd_uuid2str(&tgt->ltd_uuid),
+                  tgt->ltd_active ? "" : "IN");
+       return 0;
 }
 
 static const struct seq_operations lov_tgt_sops = {
@@ -248,10 +262,6 @@ static int lov_target_seq_open(struct inode *inode, struct file *file)
        struct seq_file *seq;
        int rc;
 
-       rc = LPROCFS_ENTRY_CHECK(inode);
-       if (rc < 0)
-               return rc;
-
        rc = seq_open(file, &lov_tgt_sops);
        if (rc)
                return rc;
@@ -261,47 +271,13 @@ static int lov_target_seq_open(struct inode *inode, struct file *file)
        return 0;
 }
 
-LPROC_SEQ_FOPS_RO_TYPE(lov, uuid);
-LPROC_SEQ_FOPS_RO_TYPE(lov, filestotal);
-LPROC_SEQ_FOPS_RO_TYPE(lov, filesfree);
-LPROC_SEQ_FOPS_RO_TYPE(lov, blksize);
-LPROC_SEQ_FOPS_RO_TYPE(lov, kbytestotal);
-LPROC_SEQ_FOPS_RO_TYPE(lov, kbytesfree);
-LPROC_SEQ_FOPS_RO_TYPE(lov, kbytesavail);
-
 struct lprocfs_vars lprocfs_lov_obd_vars[] = {
-       { .name =       "uuid",
-         .fops =       &lov_uuid_fops          },
-       { .name =       "stripesize",
-         .fops =       &lov_stripesize_fops    },
-       { .name =       "stripeoffset",
-         .fops =       &lov_stripeoffset_fops  },
-       { .name =       "stripecount",
-         .fops =       &lov_stripecount_fops   },
-       { .name =       "stripetype",
-         .fops =       &lov_stripetype_fops    },
-       { .name =       "numobd",
-         .fops =       &lov_numobd_fops        },
-       { .name =       "activeobd",
-         .fops =       &lov_activeobd_fops     },
-       { .name =       "filestotal",
-         .fops =       &lov_filestotal_fops    },
-       { .name =       "filesfree",
-         .fops =       &lov_filesfree_fops     },
-       { .name =       "blocksize",
-         .fops =       &lov_blksize_fops       },
-       { .name =       "kbytestotal",
-         .fops =       &lov_kbytestotal_fops   },
-       { .name =       "kbytesfree",
-         .fops =       &lov_kbytesfree_fops    },
-       { .name =       "kbytesavail",
-         .fops =       &lov_kbytesavail_fops   },
-       { .name =       "desc_uuid",
-         .fops =       &lov_desc_uuid_fops     },
+       { .name =       "stripesize",
+         .fops =       &lov_stripesize_fops    },
        { NULL }
 };
 
-struct file_operations lov_proc_target_fops = {
+const struct file_operations lov_proc_target_fops = {
         .owner   = THIS_MODULE,
         .open    = lov_target_seq_open,
         .read    = seq_read,
@@ -309,3 +285,45 @@ struct file_operations lov_proc_target_fops = {
         .release = lprocfs_seq_release,
 };
 #endif /* CONFIG_PROC_FS */
+
+static struct attribute *lov_attrs[] = {
+       &lustre_attr_activeobd.attr,
+       &lustre_attr_numobd.attr,
+       &lustre_attr_desc_uuid.attr,
+       &lustre_attr_stripeoffset.attr,
+       &lustre_attr_stripetype.attr,
+       &lustre_attr_stripecount.attr,
+       NULL,
+};
+
+int lov_tunables_init(struct obd_device *obd)
+{
+       struct lov_obd *lov = &obd->u.lov;
+       int rc;
+
+       obd->obd_vars = lprocfs_lov_obd_vars;
+       obd->obd_ktype.default_attrs = lov_attrs;
+       rc = lprocfs_obd_setup(obd, false);
+       if (rc)
+               GOTO(out, rc);
+
+#ifdef CONFIG_PROC_FS
+       rc = lprocfs_seq_create(obd->obd_proc_entry, "target_obd", 0444,
+                               &lov_proc_target_fops, obd);
+       if (rc)
+               CWARN("%s: Error adding the target_obd file : rc %d\n",
+                     obd->obd_name, rc);
+
+       lov->lov_pool_proc_entry = lprocfs_register("pools",
+                                                   obd->obd_proc_entry,
+                                                   NULL, NULL);
+       if (IS_ERR(lov->lov_pool_proc_entry)) {
+               rc = PTR_ERR(lov->lov_pool_proc_entry);
+               CERROR("%s: error setting up debugfs for pools : rc %d\n",
+                      obd->obd_name, rc);
+               lov->lov_pool_proc_entry = NULL;
+       }
+#endif /* CONFIG_FS_PROC */
+out:
+       return rc;
+}