/**
* Verify LVM EA.
*
- * Checks that the magic and the number of the stripes are sane.
+ * Checks that the magic of the stripe is sane.
*
* \param[in] lod lod device
* \param[in] lum a buffer storing LMV EA to verify
static int lod_verify_md_striping(struct lod_device *lod,
const struct lmv_user_md_v1 *lum)
{
- int rc = 0;
- ENTRY;
-
- if (unlikely(le32_to_cpu(lum->lum_magic) != LMV_USER_MAGIC))
- GOTO(out, rc = -EINVAL);
-
- if (unlikely(le32_to_cpu(lum->lum_stripe_count) == 0))
- GOTO(out, rc = -EINVAL);
-out:
- if (rc != 0)
+ if (unlikely(le32_to_cpu(lum->lum_magic) != LMV_USER_MAGIC)) {
CERROR("%s: invalid lmv_user_md: magic = %x, "
"stripe_offset = %d, stripe_count = %u: rc = %d\n",
lod2obd(lod)->obd_name, le32_to_cpu(lum->lum_magic),
(int)le32_to_cpu(lum->lum_stripe_offset),
- le32_to_cpu(lum->lum_stripe_count), rc);
- return rc;
+ le32_to_cpu(lum->lum_stripe_count), -EINVAL);
+ return -EINVAL;
+ }
+
+ return 0;
}
/**
lmm1->lmv_master_mdt_index = cpu_to_le32(mdtidx);
lmv_buf->lb_buf = info->lti_ea_store;
lmv_buf->lb_len = sizeof(*lmm1);
- lo->ldo_dir_striping_cached = 1;
RETURN(rc);
}
if (!dt_try_as_dir(env, dto))
GOTO(out_put, rc = -EINVAL);
+ rc = dt_declare_ref_add(env, dto, th);
+ if (rc != 0)
+ GOTO(out_put, rc);
+
rec->rec_fid = lu_object_fid(&dto->do_lu);
rc = dt_declare_insert(env, dto, (const struct dt_rec *)rec,
(const struct dt_key *)dot, th);
GOTO(out_put, rc);
/* probably nothing to inherite */
- if (lo->ldo_striping_cached &&
+ if (lo->ldo_def_striping_set &&
!LOVEA_DELETE_VALUES(lo->ldo_def_stripe_size,
lo->ldo_def_stripenr,
lo->ldo_def_stripe_offset,
*/
static void lod_lov_stripe_cache_clear(struct lod_object *lo)
{
- lo->ldo_striping_cached = 0;
lo->ldo_def_striping_set = 0;
+ lo->ldo_def_striping_cached = 0;
lod_object_set_pool(lo, NULL);
lo->ldo_def_stripe_size = 0;
lo->ldo_def_stripenr = 0;
if (lo->ldo_dir_stripe != NULL)
- lo->ldo_dir_striping_cached = 0;
+ lo->ldo_dir_def_striping_cached = 0;
}
/**
RETURN(-ENOMEM);
}
- l->ldo_dir_striping_cached = 0;
- l->ldo_dir_def_striping_set = 1;
- l->ldo_dir_def_stripenr = le32_to_cpu(lum->lum_stripe_count);
-
+ l->ldo_dir_def_striping_cached = 0;
RETURN(rc);
}
dto = lo->ldo_stripe[i];
dt_write_lock(env, dto, MOR_TGT_CHILD);
rc = dt_create(env, dto, attr, NULL, dof, th);
+ if (rc != 0) {
+ dt_write_unlock(env, dto);
+ RETURN(rc);
+ }
+
+ rc = dt_ref_add(env, dto, th);
dt_write_unlock(env, dto);
if (rc != 0)
RETURN(rc);
if (rc != 0)
RETURN(rc);
- if (lo->ldo_striping_cached &&
+ if (lo->ldo_def_striping_set &&
!LOVEA_DELETE_VALUES(lo->ldo_def_stripe_size,
lo->ldo_def_stripenr,
lo->ldo_def_stripe_offset,
}
/* Transfer default LMV striping from the parent */
- if (lo->ldo_dir_striping_cached &&
+ if (lo->ldo_dir_def_striping_set &&
!LMVEA_DELETE_VALUES(lo->ldo_dir_def_stripenr,
lo->ldo_dir_def_stripe_offset)) {
struct lmv_user_md_v1 *v1 = info->lti_ea_store;
}
/* Transfer default LOV striping from the parent */
- if (lo->ldo_striping_cached &&
+ if (lo->ldo_def_striping_set &&
!LOVEA_DELETE_VALUES(lo->ldo_def_stripe_size,
lo->ldo_def_stripenr,
lo->ldo_def_stripe_offset,
struct dt_object_format *dof,
struct thandle *th)
{
- return lod_dir_striping_create_internal(env, dt, attr, dof, th, false);
+ struct lod_object *lo = lod_dt_obj(dt);
+ int rc;
+
+ rc = lod_dir_striping_create_internal(env, dt, attr, dof, th, false);
+ if (rc == 0)
+ lo->ldo_striping_cached = 1;
+
+ return rc;
}
/**
struct dt_object *dt, const char *name,
struct thandle *th)
{
- return dt_declare_xattr_del(env, dt_object_child(dt), name, th);
+ struct lod_object *lo = lod_dt_obj(dt);
+ int rc;
+ int i;
+ ENTRY;
+
+ rc = dt_declare_xattr_del(env, dt_object_child(dt), name, th);
+ if (rc != 0)
+ RETURN(rc);
+
+ if (!S_ISDIR(dt->do_lu.lo_header->loh_attr))
+ RETURN(0);
+
+ /* set xattr to each stripes, if needed */
+ rc = lod_load_striping(env, lo);
+ if (rc != 0)
+ RETURN(rc);
+
+ if (lo->ldo_stripenr == 0)
+ RETURN(0);
+
+ for (i = 0; i < lo->ldo_stripenr; i++) {
+ LASSERT(lo->ldo_stripe[i]);
+ rc = dt_declare_xattr_del(env, lo->ldo_stripe[i], name, th);
+ if (rc != 0)
+ break;
+ }
+
+ RETURN(rc);
}
/**
const char *name, struct thandle *th,
struct lustre_capa *capa)
{
+ struct dt_object *next = dt_object_child(dt);
+ struct lod_object *lo = lod_dt_obj(dt);
+ int rc;
+ int i;
+ ENTRY;
+
if (!strcmp(name, XATTR_NAME_LOV))
lod_object_free_striping(env, lod_dt_obj(dt));
- return dt_xattr_del(env, dt_object_child(dt), name, th, capa);
+
+ rc = dt_xattr_del(env, next, name, th, capa);
+ if (rc != 0 || !S_ISDIR(dt->do_lu.lo_header->loh_attr))
+ RETURN(rc);
+
+ if (lo->ldo_stripenr == 0)
+ RETURN(0);
+
+ for (i = 0; i < lo->ldo_stripenr; i++) {
+ LASSERT(lo->ldo_stripe[i]);
+ rc = dt_xattr_del(env, lo->ldo_stripe[i], name, th, capa);
+ if (rc != 0)
+ break;
+ }
+
+ RETURN(rc);
}
/**
if (rc < (typeof(rc))sizeof(struct lov_user_md)) {
/* don't lookup for non-existing or invalid striping */
lp->ldo_def_striping_set = 0;
- lp->ldo_striping_cached = 1;
+ lp->ldo_def_striping_cached = 1;
lp->ldo_def_stripe_size = 0;
lp->ldo_def_stripenr = 0;
lp->ldo_def_stripe_offset = (typeof(v1->lmm_stripe_offset))(-1);
lp->ldo_def_stripenr = v1->lmm_stripe_count;
lp->ldo_def_stripe_size = v1->lmm_stripe_size;
lp->ldo_def_stripe_offset = v1->lmm_stripe_offset;
- lp->ldo_striping_cached = 1;
+ lp->ldo_def_striping_cached = 1;
lp->ldo_def_striping_set = 1;
if (v1->lmm_magic == LOV_USER_MAGIC_V3) {
/* XXX: sanity check here */
if (rc < (typeof(rc))sizeof(struct lmv_user_md)) {
/* don't lookup for non-existing or invalid striping */
lp->ldo_dir_def_striping_set = 0;
- lp->ldo_dir_striping_cached = 1;
+ lp->ldo_dir_def_striping_cached = 1;
lp->ldo_dir_def_stripenr = 0;
lp->ldo_dir_def_stripe_offset =
(typeof(v1->lum_stripe_offset))(-1);
lp->ldo_dir_def_stripe_offset = le32_to_cpu(v1->lum_stripe_offset);
lp->ldo_dir_def_hash_type = le32_to_cpu(v1->lum_hash_type);
lp->ldo_dir_def_striping_set = 1;
- lp->ldo_dir_striping_cached = 1;
+ lp->ldo_dir_def_striping_cached = 1;
EXIT;
unlock:
int rc = 0;
ENTRY;
- rc = lod_load_striping(env, lp);
- if (rc != 0)
- RETURN(rc);
-
- if (!lp->ldo_striping_cached) {
+ if (!lp->ldo_def_striping_cached) {
/* we haven't tried to get default striping for
* the directory yet, let's cache it in the object */
rc = lod_cache_parent_lov_striping(env, lp);
RETURN(rc);
}
- if (S_ISDIR(child_mode) && !lp->ldo_dir_striping_cached)
+ /* If the parent is on the remote MDT, we should always
+ * try to refresh the default stripeEA cache, because we
+ * do not cache default striping information for remote
+ * object. */
+ if (S_ISDIR(child_mode) && (!lp->ldo_dir_def_striping_cached ||
+ dt_object_remote(&lp->ldo_obj)))
rc = lod_cache_parent_lmv_striping(env, lp);
RETURN(rc);
return;
}
+ LASSERT(lp != NULL);
if (lp->ldo_dir_stripe == NULL) {
OBD_ALLOC_PTR(lp->ldo_dir_stripe);
if (lp->ldo_dir_stripe == NULL)
return;
/* transfer defaults to new directory */
- if (lp->ldo_striping_cached) {
+ if (lp->ldo_def_striping_set) {
if (lp->ldo_pool)
lod_object_set_pool(lc, lp->ldo_pool);
lc->ldo_def_stripenr = lp->ldo_def_stripenr;
lc->ldo_def_stripe_size = lp->ldo_def_stripe_size;
lc->ldo_def_stripe_offset = lp->ldo_def_stripe_offset;
- lc->ldo_striping_cached = 1;
lc->ldo_def_striping_set = 1;
+ lc->ldo_def_striping_cached = 1;
CDEBUG(D_OTHER, "inherite EA sz:%d off:%d nr:%d\n",
(int)lc->ldo_def_stripe_size,
(int)lc->ldo_def_stripe_offset,
}
/* transfer dir defaults to new directory */
- if (lp->ldo_dir_striping_cached) {
+ if (lp->ldo_dir_def_striping_set) {
lc->ldo_dir_def_stripenr = lp->ldo_dir_def_stripenr;
lc->ldo_dir_def_stripe_offset =
lp->ldo_dir_def_stripe_offset;
lc->ldo_dir_def_hash_type =
lp->ldo_dir_def_hash_type;
- lc->ldo_dir_striping_cached = 1;
lc->ldo_dir_def_striping_set = 1;
+ lc->ldo_dir_def_striping_cached = 1;
CDEBUG(D_INFO, "inherit default EA nr:%d off:%d t%u\n",
(int)lc->ldo_dir_def_stripenr,
(int)lc->ldo_dir_def_stripe_offset,
rc = lod_declare_striped_object(env, dt, attr,
NULL, th);
} else if (dof->dof_type == DFT_DIR) {
+ struct seq_server_site *ss;
+
+ ss = lu_site2seq(dt->do_lu.lo_dev->ld_site);
+
+ /* If the parent has default stripeEA, and client
+ * did not find it before sending create request,
+ * then MDT will return -EREMOTE, and client will
+ * retrieve the default stripeEA and re-create the
+ * sub directory.
+ *
+ * Note: if dah_eadata != NULL, it means creating the
+ * striped directory with specified stripeEA, then it
+ * should ignore the default stripeEA */
+ if ((hint == NULL || hint->dah_eadata == NULL) &&
+ lo->ldo_dir_stripe_offset != -1 &&
+ lo->ldo_dir_stripe_offset != ss->ss_node_id)
+ GOTO(out, rc = -EREMOTE);
+
/* Orphan object (like migrating object) does not have
* lod_dir_stripe, see lod_ah_init */
if (lo->ldo_dir_stripe != NULL)
if (rc)
break;
}
- if (rc == 0)
+
+ if (rc == 0) {
rc = lod_generate_and_set_lovea(env, lo, th);
+ if (rc == 0)
+ lo->ldo_striping_cached = 1;
+ }
RETURN(rc);
}
/* declare destroy all striped objects */
for (i = 0; i < lo->ldo_stripenr; i++) {
if (likely(lo->ldo_stripe[i] != NULL)) {
+ if (S_ISDIR(dt->do_lu.lo_header->loh_attr)) {
+ rc = dt_declare_ref_del(env, lo->ldo_stripe[i],
+ th);
+ if (rc != 0)
+ RETURN(rc);
+ }
+
rc = dt_declare_destroy(env, lo->ldo_stripe[i], th);
if (rc != 0)
break;
if (likely(lo->ldo_stripe[i] != NULL) &&
(!OBD_FAIL_CHECK(OBD_FAIL_LFSCK_LOST_SPEOBJ) ||
i == cfs_fail_val)) {
+ if (S_ISDIR(dt->do_lu.lo_header->loh_attr)) {
+ dt_write_lock(env, lo->ldo_stripe[i],
+ MOR_TGT_CHILD);
+ rc = dt_ref_del(env, lo->ldo_stripe[i], th);
+ dt_write_unlock(env, lo->ldo_stripe[i]);
+ if (rc != 0)
+ break;
+ }
+
rc = dt_destroy(env, lo->ldo_stripe[i], th);
if (rc != 0)
break;
lo->ldo_stripe = NULL;
lo->ldo_stripes_allocated = 0;
}
+ lo->ldo_striping_cached = 0;
lo->ldo_stripenr = 0;
lo->ldo_pattern = 0;
}
git://git.whamcloud.com / fs / lustre-release.git / blobdiff