Whamcloud - gitweb
LU-4629 lmv: fix issue found by Klocwork Insight tool
[fs/lustre-release.git] / lustre / lmv / lmv_intent.c
index 387dd9d..57a6f94 100644 (file)
@@ -27,7 +27,7 @@
  * Copyright (c) 2004, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
  *
- * Copyright (c) 2011, 2012, Intel Corporation.
+ * Copyright (c) 2011, 2013, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
@@ -54,6 +54,7 @@
 #include <lustre_lib.h>
 #include <lustre_net.h>
 #include <lustre_dlm.h>
+#include <lustre_mdc.h>
 #include <obd_class.h>
 #include <lprocfs_status.h>
 #include "lmv_internal.h"
@@ -111,14 +112,21 @@ static int lmv_intent_remote(struct obd_export *exp, void *lmm,
 
        op_data->op_fid1 = body->fid1;
        /* Sent the parent FID to the remote MDT */
-       if (parent_fid != NULL)
+       if (parent_fid != NULL) {
+               /* The parent fid is only for remote open to
+                * check whether the open is from OBF,
+                * see mdt_cross_open */
+               LASSERT(it->it_op & IT_OPEN);
                op_data->op_fid2 = *parent_fid;
+               /* Add object FID to op_fid3, in case it needs to check stale
+                * (M_CHECK_STALE), see mdc_finish_intent_lock */
+               op_data->op_fid3 = body->fid1;
+       }
 
        op_data->op_bias = MDS_CROSS_REF;
        CDEBUG(D_INODE, "REMOTE_INTENT with fid="DFID" -> mds #%d\n",
               PFID(&body->fid1), tgt->ltd_idx);
 
-        it->d.lustre.it_disposition &= ~DISP_ENQ_COMPLETE;
         rc = md_intent_lock(tgt->ltd_exp, op_data, lmm, lmmsize, it,
                             flags, &req, cb_blocking, extra_lock_flags);
         if (rc)
@@ -135,8 +143,10 @@ static int lmv_intent_remote(struct obd_export *exp, void *lmm,
                it->d.lustre.it_remote_lock_mode = it->d.lustre.it_lock_mode;
        }
 
-       it->d.lustre.it_lock_handle = plock.cookie;
-       it->d.lustre.it_lock_mode = pmode;
+       if (pmode) {
+               it->d.lustre.it_lock_handle = plock.cookie;
+               it->d.lustre.it_lock_mode = pmode;
+       }
 
        EXIT;
 out_free_op_data:
@@ -150,6 +160,180 @@ out:
        return rc;
 }
 
+#ifdef __KERNEL__
+int lmv_revalidate_slaves(struct obd_export *exp, struct mdt_body *mbody,
+                         struct lmv_stripe_md *lsm,
+                         ldlm_blocking_callback cb_blocking,
+                         int extra_lock_flags)
+{
+       struct obd_device      *obd = exp->exp_obd;
+       struct lmv_obd         *lmv = &obd->u.lmv;
+       struct mdt_body         *body;
+       struct md_op_data      *op_data;
+       unsigned long           size = 0;
+       unsigned long           nlink = 0;
+       obd_time                atime = 0;
+       obd_time                ctime = 0;
+       obd_time                mtime = 0;
+       int                     i;
+       int                     rc = 0;
+
+       ENTRY;
+
+       /**
+        * revalidate slaves has some problems, temporarily return,
+        * we may not need that
+        */
+       if (lsm->lsm_md_stripe_count <= 1)
+               RETURN(0);
+
+       OBD_ALLOC_PTR(op_data);
+       if (op_data == NULL)
+               RETURN(-ENOMEM);
+
+       /**
+        * Loop over the stripe information, check validity and update them
+        * from MDS if needed.
+        */
+       for (i = 0; i < lsm->lsm_md_stripe_count; i++) {
+               struct lu_fid           fid;
+               struct lookup_intent    it = { .it_op = IT_GETATTR };
+               struct ptlrpc_request   *req = NULL;
+               struct lustre_handle    *lockh = NULL;
+               struct lmv_tgt_desc     *tgt = NULL;
+               struct inode            *inode;
+
+               fid = lsm->lsm_md_oinfo[i].lmo_fid;
+               inode = lsm->lsm_md_oinfo[i].lmo_root;
+               if (i == 0) {
+                       if (mbody != NULL) {
+                               body = mbody;
+                               goto update;
+                       } else {
+                               goto release_lock;
+                       }
+               }
+
+               /*
+                * Prepare op_data for revalidating. Note that @fid2 shluld be
+                * defined otherwise it will go to server and take new lock
+                * which is not needed here.
+                */
+               memset(op_data, 0, sizeof(*op_data));
+               op_data->op_fid1 = fid;
+               op_data->op_fid2 = fid;
+
+               tgt = lmv_locate_mds(lmv, op_data, &fid);
+               if (IS_ERR(tgt))
+                       GOTO(cleanup, rc = PTR_ERR(tgt));
+
+               CDEBUG(D_INODE, "Revalidate slave "DFID" -> mds #%d\n",
+                      PFID(&fid), tgt->ltd_idx);
+
+               rc = md_intent_lock(tgt->ltd_exp, op_data, NULL, 0, &it, 0,
+                                   &req, cb_blocking, extra_lock_flags);
+               if (rc < 0)
+                       GOTO(cleanup, rc);
+
+               lockh = (struct lustre_handle *)&it.d.lustre.it_lock_handle;
+               if (rc > 0 && req == NULL) {
+                       /* slave inode is still valid */
+                       CDEBUG(D_INODE, "slave "DFID" is still valid.\n",
+                              PFID(&fid));
+                       rc = 0;
+               } else {
+                       /* refresh slave from server */
+                       body = req_capsule_server_get(&req->rq_pill,
+                                                     &RMF_MDT_BODY);
+                       LASSERT(body != NULL);
+update:
+                       if (unlikely(body->nlink < 2)) {
+                               CERROR("%s: nlink %d < 2 corrupt stripe %d "DFID
+                                      ":" DFID"\n", obd->obd_name, body->nlink,
+                                      i, PFID(&lsm->lsm_md_oinfo[i].lmo_fid),
+                                      PFID(&lsm->lsm_md_oinfo[0].lmo_fid));
+
+                               if (req != NULL)
+                                       ptlrpc_req_finished(req);
+
+                               if (it.d.lustre.it_lock_mode && lockh) {
+                                       ldlm_lock_decref(lockh,
+                                                it.d.lustre.it_lock_mode);
+                                       it.d.lustre.it_lock_mode = 0;
+                               }
+
+                               GOTO(cleanup, rc = -EIO);
+                       }
+
+                       if (i != 0)
+                               md_set_lock_data(tgt->ltd_exp, &lockh->cookie,
+                                                inode, NULL);
+
+                       i_size_write(inode, body->size);
+                       set_nlink(inode, body->nlink);
+                       LTIME_S(inode->i_atime) = body->atime;
+                       LTIME_S(inode->i_ctime) = body->ctime;
+                       LTIME_S(inode->i_mtime) = body->mtime;
+
+                       if (req != NULL)
+                               ptlrpc_req_finished(req);
+               }
+release_lock:
+               size += i_size_read(inode);
+
+               if (i != 0)
+                       nlink += inode->i_nlink - 2;
+               else
+                       nlink += inode->i_nlink;
+
+               atime = LTIME_S(inode->i_atime) > atime ?
+                               LTIME_S(inode->i_atime) : atime;
+               ctime = LTIME_S(inode->i_ctime) > ctime ?
+                               LTIME_S(inode->i_ctime) : ctime;
+               mtime = LTIME_S(inode->i_mtime) > mtime ?
+                               LTIME_S(inode->i_mtime) : mtime;
+
+               if (it.d.lustre.it_lock_mode != 0 && lockh != NULL) {
+                       ldlm_lock_decref(lockh, it.d.lustre.it_lock_mode);
+                       it.d.lustre.it_lock_mode = 0;
+               }
+
+               CDEBUG(D_INODE, "i %d "DFID" size %llu, nlink %u, atime "
+                      "%lu, mtime %lu, ctime %lu.\n", i, PFID(&fid),
+                      i_size_read(inode), inode->i_nlink,
+                      LTIME_S(inode->i_atime), LTIME_S(inode->i_mtime),
+                      LTIME_S(inode->i_ctime));
+       }
+
+       /*
+        * update attr of master request.
+        */
+       CDEBUG(D_INODE, "Return refreshed attrs: size = %lu nlink %lu atime "
+              LPU64 "ctime "LPU64" mtime "LPU64" for " DFID"\n", size, nlink,
+              atime, ctime, mtime, PFID(&lsm->lsm_md_oinfo[0].lmo_fid));
+
+       if (mbody != NULL) {
+               mbody->atime = atime;
+               mbody->ctime = ctime;
+               mbody->mtime = mtime;
+       }
+cleanup:
+       OBD_FREE_PTR(op_data);
+       RETURN(rc);
+}
+
+#else
+
+int lmv_revalidate_slaves(struct obd_export *exp, struct mdt_body *mbody,
+                         struct lmv_stripe_md *lsm,
+                         ldlm_blocking_callback cb_blocking,
+                         int extra_lock_flags)
+{
+       return 0;
+}
+
+#endif
+
 /*
  * IT_OPEN is intended to open (and create, possible) an object. Parent (pid)
  * may be split dir.
@@ -167,11 +351,35 @@ int lmv_intent_open(struct obd_export *exp, struct md_op_data *op_data,
        int                     rc;
        ENTRY;
 
-       tgt = lmv_locate_mds(lmv, op_data, &op_data->op_fid1);
-       if (IS_ERR(tgt))
-               RETURN(PTR_ERR(tgt));
+       /* Note: client might open with some random flags(sanity 33b), so we can
+        * not make sure op_fid2 is being initialized with BY_FID flag */
+       if (it->it_flags & MDS_OPEN_BY_FID && fid_is_sane(&op_data->op_fid2)) {
+               if (op_data->op_mea1 != NULL) {
+                       struct lmv_stripe_md    *lsm = op_data->op_mea1;
+                       const struct lmv_oinfo  *oinfo;
+
+                       oinfo = lsm_name_to_stripe_info(lsm, op_data->op_name,
+                                                       op_data->op_namelen);
+                       if (IS_ERR(oinfo))
+                               RETURN(PTR_ERR(oinfo));
+                       op_data->op_fid1 = oinfo->lmo_fid;
+               }
+
+               tgt = lmv_find_target(lmv, &op_data->op_fid2);
+               if (IS_ERR(tgt))
+                       RETURN(PTR_ERR(tgt));
+
+               op_data->op_mds = tgt->ltd_idx;
+       } else {
+               tgt = lmv_locate_mds(lmv, op_data, &op_data->op_fid1);
+               if (IS_ERR(tgt))
+                       RETURN(PTR_ERR(tgt));
+       }
 
-       if (it->it_op & IT_CREAT) {
+       /* If it is ready to open the file by FID, do not need
+        * allocate FID at all, otherwise it will confuse MDT */
+       if ((it->it_op & IT_CREAT) &&
+           !(it->it_flags & MDS_OPEN_BY_FID)) {
                /*
                 * For open with IT_CREATE and for IT_CREATE cases allocate new
                 * fid and setup FLD for it.
@@ -202,31 +410,18 @@ int lmv_intent_open(struct obd_export *exp, struct md_op_data *op_data,
        body = req_capsule_server_get(&(*reqp)->rq_pill, &RMF_MDT_BODY);
        if (body == NULL)
                RETURN(-EPROTO);
-       /*
-        * Not cross-ref case, just get out of here.
-        */
-       if (likely(!(body->valid & OBD_MD_MDS)))
-               RETURN(0);
 
-       /*
-        * Okay, MDS has returned success. Probably name has been resolved in
-        * remote inode.
-        */
-       rc = lmv_intent_remote(exp, lmm, lmmsize, it, &op_data->op_fid1, flags,
-                              reqp, cb_blocking, extra_lock_flags);
-       if (rc != 0) {
-               LASSERT(rc < 0);
-               /*
-                * This is possible, that some userspace application will try to
-                * open file as directory and we will have -ENOTDIR here. As
-                * this is normal situation, we should not print error here,
-                * only debug info.
-                */
-               CDEBUG(D_INODE, "Can't handle remote %s: dir "DFID"("DFID"):"
-                      "%*s: %d\n", LL_IT2STR(it), PFID(&op_data->op_fid2),
-                      PFID(&op_data->op_fid1), op_data->op_namelen,
-                      op_data->op_name, rc);
-               RETURN(rc);
+       /* Not cross-ref case, just get out of here. */
+       if (unlikely((body->valid & OBD_MD_MDS))) {
+               rc = lmv_intent_remote(exp, lmm, lmmsize, it, &op_data->op_fid1,
+                                      flags, reqp, cb_blocking,
+                                      extra_lock_flags);
+               if (rc != 0)
+                       RETURN(rc);
+
+               body = req_capsule_server_get(&(*reqp)->rq_pill, &RMF_MDT_BODY);
+               if (body == NULL)
+                       RETURN(-EPROTO);
        }
 
        RETURN(rc);
@@ -241,11 +436,12 @@ int lmv_intent_lookup(struct obd_export *exp, struct md_op_data *op_data,
                       ldlm_blocking_callback cb_blocking,
                      __u64 extra_lock_flags)
 {
-       struct obd_device      *obd = exp->exp_obd;
-       struct lmv_obd         *lmv = &obd->u.lmv;
-       struct lmv_tgt_desc    *tgt = NULL;
-       struct mdt_body        *body;
-       int                     rc = 0;
+       struct obd_device       *obd = exp->exp_obd;
+       struct lmv_obd          *lmv = &obd->u.lmv;
+       struct lmv_tgt_desc     *tgt = NULL;
+       struct mdt_body         *body;
+       struct lmv_stripe_md    *lsm = op_data->op_mea1;
+       int                     rc = 0;
        ENTRY;
 
        tgt = lmv_locate_mds(lmv, op_data, &op_data->op_fid1);
@@ -256,19 +452,48 @@ int lmv_intent_lookup(struct obd_export *exp, struct md_op_data *op_data,
                fid_zero(&op_data->op_fid2);
 
        CDEBUG(D_INODE, "LOOKUP_INTENT with fid1="DFID", fid2="DFID
-              ", name='%s' -> mds #%d\n", PFID(&op_data->op_fid1),
-              PFID(&op_data->op_fid2),
+              ", name='%s' -> mds #%d lsm=%p lsm_magic=%x\n",
+              PFID(&op_data->op_fid1), PFID(&op_data->op_fid2),
               op_data->op_name ? op_data->op_name : "<NULL>",
-              tgt->ltd_idx);
+              tgt->ltd_idx, lsm, lsm == NULL ? -1 : lsm->lsm_md_magic);
 
        op_data->op_bias &= ~MDS_CROSS_REF;
 
        rc = md_intent_lock(tgt->ltd_exp, op_data, lmm, lmmsize, it,
                             flags, reqp, cb_blocking, extra_lock_flags);
-
-       if (rc < 0 || *reqp == NULL)
+       if (rc < 0)
                RETURN(rc);
 
+       if (*reqp == NULL) {
+               /* If RPC happens, lsm information will be revalidated
+                * during update_inode process (see ll_update_lsm_md) */
+               if (op_data->op_mea2 != NULL) {
+                       rc = lmv_revalidate_slaves(exp, NULL, op_data->op_mea2,
+                                                  cb_blocking,
+                                                  extra_lock_flags);
+                       if (rc != 0)
+                               RETURN(rc);
+               }
+               RETURN(rc);
+       } else if (it_disposition(it, DISP_LOOKUP_NEG) &&
+                  lsm != NULL && lsm->lsm_md_magic == LMV_MAGIC_MIGRATE) {
+               /* For migrating directory, if it can not find the child in
+                * the source directory(master stripe), try the targeting
+                * directory(stripe 1) */
+               tgt = lmv_find_target(lmv, &lsm->lsm_md_oinfo[1].lmo_fid);
+               if (IS_ERR(tgt))
+                       RETURN(PTR_ERR(tgt));
+
+               ptlrpc_req_finished(*reqp);
+               CDEBUG(D_INODE, "For migrating dir, try target dir "DFID"\n",
+                      PFID(&lsm->lsm_md_oinfo[1].lmo_fid));
+
+               op_data->op_fid1 = lsm->lsm_md_oinfo[1].lmo_fid;
+               it->d.lustre.it_disposition &= ~DISP_ENQ_COMPLETE;
+               rc = md_intent_lock(tgt->ltd_exp, op_data, lmm, lmmsize, it,
+                                   flags, reqp, cb_blocking, extra_lock_flags);
+               RETURN(rc);
+       }
        /*
         * MDS has returned success. Probably name has been resolved in
         * remote inode. Let's check this.
@@ -276,12 +501,17 @@ int lmv_intent_lookup(struct obd_export *exp, struct md_op_data *op_data,
        body = req_capsule_server_get(&(*reqp)->rq_pill, &RMF_MDT_BODY);
        if (body == NULL)
                RETURN(-EPROTO);
-       /* Not cross-ref case, just get out of here. */
-       if (likely(!(body->valid & OBD_MD_MDS)))
-               RETURN(0);
 
-       rc = lmv_intent_remote(exp, lmm, lmmsize, it, NULL, flags, reqp,
-                              cb_blocking, extra_lock_flags);
+       /* Not cross-ref case, just get out of here. */
+       if (unlikely((body->valid & OBD_MD_MDS))) {
+               rc = lmv_intent_remote(exp, lmm, lmmsize, it, NULL, flags,
+                                      reqp, cb_blocking, extra_lock_flags);
+               if (rc != 0)
+                       RETURN(rc);
+               body = req_capsule_server_get(&(*reqp)->rq_pill, &RMF_MDT_BODY);
+               if (body == NULL)
+                       RETURN(-EPROTO);
+       }
 
        RETURN(rc);
 }