/*
* Copyright 2012 Xyratex Technology Limited
*
- * Copyright (c) 2013, 2015, Intel Corporation.
+ * Copyright (c) 2013, 2017, Intel Corporation.
*
* Author: Andrew Perepechko <Andrew_Perepechko@xyratex.com>
*
#include <linux/mm.h>
#include <obd_support.h>
#include <lustre_dlm.h>
-#include <lustre_ver.h>
#include "llite_internal.h"
/* If we ever have hundreds of extended attributes, we might want to consider
LASSERT(lli != NULL);
INIT_LIST_HEAD(&lli->lli_xattrs);
- ll_file_set_flag(lli, LLIF_XATTR_CACHE);
+ set_bit(LLIF_XATTR_CACHE, &lli->lli_flags);
}
/**
ENTRY;
if (ll_xattr_cache_find(cache, xattr_name, &xattr) == 0) {
+ if (!strcmp(xattr_name, LL_XATTR_NAME_ENCRYPTION_CONTEXT))
+ /* it means enc ctx was already in cache,
+ * ignore error as it cannot be modified
+ */
+ RETURN(0);
+
CDEBUG(D_CACHE, "duplicate xattr: [%s]\n", xattr_name);
RETURN(-EPROTO);
}
}
/**
- * Check if the xattr cache is initialized (filled).
+ * Check if the xattr cache is initialized.
*
* \retval 0 @cache is not initialized
* \retval 1 @cache is initialized
*/
static int ll_xattr_cache_valid(struct ll_inode_info *lli)
{
- return ll_file_test_flag(lli, LLIF_XATTR_CACHE);
+ return test_bit(LLIF_XATTR_CACHE, &lli->lli_flags);
+}
+
+/**
+ * Check if the xattr cache is filled.
+ *
+ * \retval 0 @cache is not filled
+ * \retval 1 @cache is filled
+ */
+static int ll_xattr_cache_filled(struct ll_inode_info *lli)
+{
+ return test_bit(LLIF_XATTR_CACHE_FILLED, &lli->lli_flags);
}
/**
while (ll_xattr_cache_del(&lli->lli_xattrs, NULL) == 0)
/* empty loop */ ;
- ll_file_clear_flag(lli, LLIF_XATTR_CACHE);
+ clear_bit(LLIF_XATTR_CACHE_FILLED, &lli->lli_flags);
+ clear_bit(LLIF_XATTR_CACHE, &lli->lli_flags);
RETURN(0);
}
}
/**
+ * ll_xattr_cache_empty - empty xattr cache for @ino
+ *
+ * Similar to ll_xattr_cache_destroy(), but preserves encryption context.
+ * So only LLIF_XATTR_CACHE_FILLED flag is cleared, but not LLIF_XATTR_CACHE.
+ */
+int ll_xattr_cache_empty(struct inode *inode)
+{
+ struct ll_inode_info *lli = ll_i2info(inode);
+ struct ll_xattr_entry *entry, *n;
+
+ ENTRY;
+
+ down_write(&lli->lli_xattrs_list_rwsem);
+ if (!ll_xattr_cache_valid(lli) ||
+ !ll_xattr_cache_filled(lli))
+ GOTO(out_empty, 0);
+
+ list_for_each_entry_safe(entry, n, &lli->lli_xattrs, xe_list) {
+ if (strcmp(entry->xe_name,
+ LL_XATTR_NAME_ENCRYPTION_CONTEXT) == 0)
+ continue;
+
+ CDEBUG(D_CACHE, "delete: %s\n", entry->xe_name);
+ list_del(&entry->xe_list);
+ OBD_FREE(entry->xe_name, entry->xe_namelen);
+ OBD_FREE(entry->xe_value, entry->xe_vallen);
+ OBD_SLAB_FREE_PTR(entry, xattr_kmem);
+ }
+ clear_bit(LLIF_XATTR_CACHE_FILLED, &lli->lli_flags);
+
+out_empty:
+ up_write(&lli->lli_xattrs_list_rwsem);
+ RETURN(0);
+}
+
+/**
* Match or enqueue a PR lock.
*
* Find or request an LDLM lock with xattr data.
* Since LDLM does not provide API for atomic match_or_enqueue,
* the function handles it with a separate enq lock.
- * If successful, the function exits with the list lock held.
+ * If successful, the function exits with a write lock held
+ * on lli_xattrs_list_rwsem.
*
* \retval 0 no error occured
* \retval -ENOMEM not enough memory
mutex_lock(&lli->lli_xattrs_enq_lock);
/* inode may have been shrunk and recreated, so data is gone, match lock
* only when data exists. */
- if (ll_xattr_cache_valid(lli)) {
+ if (ll_xattr_cache_filled(lli)) {
/* Try matching first. */
mode = ll_take_md_lock(inode, MDS_INODELOCK_XATTR, &lockh, 0,
LCK_PR);
/**
* Refill the xattr cache.
*
- * Fetch and cache the whole of xattrs for @inode, acquiring a read lock.
+ * Fetch and cache the whole of xattrs for @inode, thanks to the write lock
+ * on lli_xattrs_list_rwsem obtained from ll_xattr_find_get_lock().
+ * If successful, this write lock is kept.
*
* \retval 0 no error occured
* \retval -EPROTO network protocol error
GOTO(err_req, rc);
/* Do we have the data at this point? */
- if (ll_xattr_cache_valid(lli)) {
+ if (ll_xattr_cache_filled(lli)) {
ll_stats_ops_tally(sbi, LPROC_LL_GETXATTR_HITS, 1);
ll_intent_drop_lock(&oit);
GOTO(err_req, rc = 0);
if (unlikely(req == NULL)) {
CDEBUG(D_CACHE, "cancelled by a parallel getxattr\n");
ll_intent_drop_lock(&oit);
- GOTO(err_unlock, rc = -EIO);
+ GOTO(err_unlock, rc = -EAGAIN);
}
body = req_capsule_server_get(&req->rq_pill, &RMF_MDT_BODY);
CDEBUG(D_CACHE, "caching: xdata=%p xtail=%p\n", xdata, xtail);
- ll_xattr_cache_init(lli);
+ if (!ll_xattr_cache_valid(lli))
+ ll_xattr_cache_init(lli);
for (i = 0; i < body->mbo_max_mdsize; i++) {
CDEBUG(D_CACHE, "caching [%s]=%.*s\n", xdata, *xsizes, xval);
if (xdata != xtail || xval != xvtail)
CERROR("a hole in xattr data\n");
+ else
+ set_bit(LLIF_XATTR_CACHE_FILLED, &lli->lli_flags);
ll_set_lock_data(sbi->ll_md_exp, inode, &oit, NULL);
ll_intent_drop_lock(&oit);
rc = -EAGAIN;
ptlrpc_req_finished(req);
- return rc;
+ RETURN(rc);
}
/**
LASSERT(!!(valid & OBD_MD_FLXATTR) ^ !!(valid & OBD_MD_FLXATTRLS));
down_read(&lli->lli_xattrs_list_rwsem);
- if (!ll_xattr_cache_valid(lli)) {
+ /* For performance reasons, we do not want to refill complete xattr
+ * cache if we are just interested in encryption context.
+ */
+ if ((valid & OBD_MD_FLXATTRLS ||
+ strcmp(name, LL_XATTR_NAME_ENCRYPTION_CONTEXT) != 0) &&
+ !ll_xattr_cache_filled(lli)) {
up_read(&lli->lli_xattrs_list_rwsem);
rc = ll_xattr_cache_refill(inode);
if (rc)
RETURN(rc);
+ /* Turn the write lock obtained in ll_xattr_cache_refill()
+ * into a read lock.
+ */
downgrade_write(&lli->lli_xattrs_list_rwsem);
} else {
ll_stats_ops_tally(ll_i2sbi(inode), LPROC_LL_GETXATTR_HITS, 1);
}
+ if (!ll_xattr_cache_valid(lli))
+ GOTO(out, rc = -ENODATA);
+
if (valid & OBD_MD_FLXATTR) {
struct ll_xattr_entry *xattr;
out:
up_read(&lli->lli_xattrs_list_rwsem);
- return rc;
+ RETURN(rc);
}
+/**
+ * Insert an xattr value into the cache.
+ *
+ * Add @name xattr with @buffer value and @size length for @inode.
+ * Init cache for @inode if necessary.
+ *
+ * \retval 0 success
+ * \retval < 0 from ll_xattr_cache_add(), except -EPROTO is ignored for
+ * LL_XATTR_NAME_ENCRYPTION_CONTEXT xattr
+ */
+int ll_xattr_cache_insert(struct inode *inode,
+ const char *name,
+ char *buffer,
+ size_t size)
+{
+ struct ll_inode_info *lli = ll_i2info(inode);
+ int rc;
+
+ ENTRY;
+
+ down_write(&lli->lli_xattrs_list_rwsem);
+ if (!ll_xattr_cache_valid(lli))
+ ll_xattr_cache_init(lli);
+ rc = ll_xattr_cache_add(&lli->lli_xattrs, name, buffer, size);
+ up_write(&lli->lli_xattrs_list_rwsem);
+ RETURN(rc);
+}