Whamcloud - gitweb
LU-8056 llite: POSIX_ACL_XATTR_{ACCESS,DEFAULT} removed in 4.5
[fs/lustre-release.git] / lustre / llite / xattr.c
index 37d439f..461a0ba 100644 (file)
@@ -27,7 +27,7 @@
  * Copyright (c) 2007, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
  *
- * Copyright (c) 2011, 2013, Intel Corporation.
+ * Copyright (c) 2011, 2015, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
 #include <linux/fs.h>
 #include <linux/sched.h>
 #include <linux/mm.h>
+#include <linux/xattr.h>
 #include <linux/selinux.h>
 
 #define DEBUG_SUBSYSTEM S_LLITE
 
 #include <obd_support.h>
-#include <lustre_lite.h>
 #include <lustre_dlm.h>
 #include <lustre_ver.h>
 #include <lustre_eacl.h>
 
 #include "llite_internal.h"
 
+/* xattr related to IMA(Integrity Measurement Architecture) */
+#ifndef XATTR_NAME_IMA
+#define XATTR_NAME_IMA         "security.ima"
+#endif
+#ifndef XATTR_NAME_EVM
+#define XATTR_NAME_EVM         "security.evm"
+#endif
+
+#ifndef XATTR_NAME_POSIX_ACL_ACCESS
+# define XATTR_NAME_POSIX_ACL_ACCESS POSIX_ACL_XATTR_ACCESS
+#endif
+
+#ifndef XATTR_NAME_POSIX_ACL_DEFAULT
+# define XATTR_NAME_POSIX_ACL_DEFAULT POSIX_ACL_XATTR_DEFAULT
+#endif
+
 #define XATTR_USER_T            (1)
 #define XATTR_TRUSTED_T         (2)
 #define XATTR_SECURITY_T        (3)
 static
 int get_xattr_type(const char *name)
 {
-        if (!strcmp(name, POSIX_ACL_XATTR_ACCESS))
+       if (!strcmp(name, XATTR_NAME_POSIX_ACL_ACCESS))
                 return XATTR_ACL_ACCESS_T;
 
-        if (!strcmp(name, POSIX_ACL_XATTR_DEFAULT))
+       if (!strcmp(name, XATTR_NAME_POSIX_ACL_DEFAULT))
                 return XATTR_ACL_DEFAULT_T;
 
         if (!strncmp(name, XATTR_USER_PREFIX,
@@ -111,13 +127,16 @@ int ll_setxattr_common(struct inode *inode, const char *name,
        struct ll_sb_info *sbi = ll_i2sbi(inode);
        struct ptlrpc_request *req = NULL;
         int xattr_type, rc;
-        struct obd_capa *oc;
-        posix_acl_xattr_header *new_value = NULL;
-        struct rmtacl_ctl_entry *rce = NULL;
-        ext_acl_xattr_header *acl = NULL;
         const char *pv = value;
         ENTRY;
 
+       /*FIXME: enable IMA when the conditions are ready */
+       if (strncmp(name, XATTR_NAME_IMA,
+                   sizeof(XATTR_NAME_IMA)) == 0 ||
+           strncmp(name, XATTR_NAME_EVM,
+                   sizeof(XATTR_NAME_EVM)) == 0)
+               return -EOPNOTSUPP;
+
         xattr_type = get_xattr_type(name);
         rc = xattr_type_filter(sbi, xattr_type);
         if (rc)
@@ -132,10 +151,13 @@ int ll_setxattr_common(struct inode *inode, const char *name,
 #endif
                return -EPERM;
 
-        /* b10667: ignore lustre special xattr for now */
-        if ((xattr_type == XATTR_TRUSTED_T && strcmp(name, "trusted.lov") == 0) ||
-            (xattr_type == XATTR_LUSTRE_T && strcmp(name, "lustre.lov") == 0))
-                RETURN(0);
+       /* b10667: ignore lustre special xattr for now */
+       if (strcmp(name, XATTR_NAME_HSM) == 0 ||
+               (xattr_type == XATTR_TRUSTED_T &&
+               strcmp(name, XATTR_NAME_LOV) == 0) ||
+               (xattr_type == XATTR_LUSTRE_T &&
+                strcmp(name, "lustre.lov") == 0))
+               RETURN(0);
 
         /* b15587: ignore security.capability xattr for now */
         if ((xattr_type == XATTR_SECURITY_T &&
@@ -147,62 +169,8 @@ int ll_setxattr_common(struct inode *inode, const char *name,
             strcmp(name, "security.selinux") == 0)
                 RETURN(-EOPNOTSUPP);
 
-#ifdef CONFIG_FS_POSIX_ACL
-       if (sbi->ll_flags & LL_SBI_RMT_CLIENT &&
-           (xattr_type == XATTR_ACL_ACCESS_T ||
-           xattr_type == XATTR_ACL_DEFAULT_T)) {
-               rce = rct_search(&sbi->ll_rct, current_pid());
-               if (rce == NULL ||
-                   (rce->rce_ops != RMT_LSETFACL &&
-                   rce->rce_ops != RMT_RSETFACL))
-                       RETURN(-EOPNOTSUPP);
-
-               if (rce->rce_ops == RMT_LSETFACL) {
-                       struct eacl_entry *ee;
-
-                       ee = et_search_del(&sbi->ll_et, current_pid(),
-                                          ll_inode2fid(inode), xattr_type);
-                       LASSERT(ee != NULL);
-                        if (valid & OBD_MD_FLXATTR) {
-                                acl = lustre_acl_xattr_merge2ext(
-                                                (posix_acl_xattr_header *)value,
-                                                size, ee->ee_acl);
-                                if (IS_ERR(acl)) {
-                                        ee_free(ee);
-                                        RETURN(PTR_ERR(acl));
-                                }
-                                size =  CFS_ACL_XATTR_SIZE(\
-                                                le32_to_cpu(acl->a_count), \
-                                                ext_acl_xattr);
-                                pv = (const char *)acl;
-                        }
-                        ee_free(ee);
-                } else if (rce->rce_ops == RMT_RSETFACL) {
-                       int acl_size = lustre_posix_acl_xattr_filter(
-                                               (posix_acl_xattr_header *)value,
-                                               size, &new_value);
-                       if (unlikely(acl_size < 0))
-                               RETURN(acl_size);
-                       size = acl_size;
-
-                        pv = (const char *)new_value;
-                } else
-                        RETURN(-EOPNOTSUPP);
-
-                valid |= rce_ops2valid(rce->rce_ops);
-        }
-#endif
-       oc = ll_mdscapa_get(inode);
-       rc = md_setxattr(sbi->ll_md_exp, ll_inode2fid(inode), oc,
-                       valid, name, pv, size, 0, flags,
-                       ll_i2suppgid(inode), &req);
-       capa_put(oc);
-#ifdef CONFIG_FS_POSIX_ACL
-        if (new_value != NULL)
-                lustre_posix_acl_xattr_free(new_value, size);
-        if (acl != NULL)
-                lustre_ext_acl_xattr_free(acl);
-#endif
+       rc = md_setxattr(sbi->ll_md_exp, ll_inode2fid(inode), valid, name, pv,
+                        size, 0, flags, ll_i2suppgid(inode), &req);
         if (rc) {
                 if (rc == -EOPNOTSUPP && xattr_type == XATTR_USER_T) {
                         LCONSOLE_INFO("Disabling user_xattr feature because "
@@ -216,6 +184,37 @@ int ll_setxattr_common(struct inode *inode, const char *name,
         RETURN(0);
 }
 
+static int get_hsm_state(struct inode *inode, __u32 *hus_states)
+{
+       struct md_op_data *op_data;
+       struct hsm_user_state *hus;
+       int rc;
+
+       OBD_ALLOC_PTR(hus);
+       if (hus == NULL)
+               return -ENOMEM;
+
+       op_data = ll_prep_md_op_data(NULL, inode, NULL, NULL, 0, 0,
+                                    LUSTRE_OPC_ANY, hus);
+       if (!IS_ERR(op_data)) {
+               rc = obd_iocontrol(LL_IOC_HSM_STATE_GET, ll_i2mdexp(inode),
+                                  sizeof(*op_data), op_data, NULL);
+               if (rc == 0)
+                       *hus_states = hus->hus_states;
+               else
+                       CDEBUG(D_VFSTRACE, "obd_iocontrol failed. rc = %d\n",
+                              rc);
+
+               ll_finish_md_op_data(op_data);
+       } else {
+               rc = PTR_ERR(op_data);
+               CDEBUG(D_VFSTRACE, "Could not prepare the opdata. rc = %d\n",
+                      rc);
+       }
+       OBD_FREE_PTR(hus);
+       return rc;
+}
+
 int ll_setxattr(struct dentry *dentry, const char *name,
                 const void *value, size_t size, int flags)
 {
@@ -229,32 +228,55 @@ int ll_setxattr(struct dentry *dentry, const char *name,
 
         ll_stats_ops_tally(ll_i2sbi(inode), LPROC_LL_SETXATTR, 1);
 
-        if ((strncmp(name, XATTR_TRUSTED_PREFIX,
-                     sizeof(XATTR_TRUSTED_PREFIX) - 1) == 0 &&
-             strcmp(name + sizeof(XATTR_TRUSTED_PREFIX) - 1, "lov") == 0) ||
-            (strncmp(name, XATTR_LUSTRE_PREFIX,
-                     sizeof(XATTR_LUSTRE_PREFIX) - 1) == 0 &&
-             strcmp(name + sizeof(XATTR_LUSTRE_PREFIX) - 1, "lov") == 0)) {
-                struct lov_user_md *lump = (struct lov_user_md *)value;
-                int rc = 0;
-
-                /* Attributes that are saved via getxattr will always have
-                 * the stripe_offset as 0.  Instead, the MDS should be
-                 * allowed to pick the starting OST index.   b=17846 */
-                if (lump != NULL && lump->lmm_stripe_offset == 0)
-                        lump->lmm_stripe_offset = -1;
+       if ((strncmp(name, XATTR_TRUSTED_PREFIX,
+                    sizeof(XATTR_TRUSTED_PREFIX) - 1) == 0 &&
+            strcmp(name + sizeof(XATTR_TRUSTED_PREFIX) - 1, "lov") == 0) ||
+           (strncmp(name, XATTR_LUSTRE_PREFIX,
+                    sizeof(XATTR_LUSTRE_PREFIX) - 1) == 0 &&
+            strcmp(name + sizeof(XATTR_LUSTRE_PREFIX) - 1, "lov") == 0)) {
+               struct lov_user_md *lump = (struct lov_user_md *)value;
+               int rc = 0;
+
+               /* Attributes that are saved via getxattr will always have
+                * the stripe_offset as 0.  Instead, the MDS should be
+                * allowed to pick the starting OST index.   b=17846 */
+               if (lump != NULL && lump->lmm_stripe_offset == 0)
+                       lump->lmm_stripe_offset = -1;
+               /* Avoid anyone directly setting the RELEASED flag. */
+               if (lump != NULL &&
+                       (lump->lmm_pattern & LOV_PATTERN_F_RELEASED)) {
+                       /* Only if we have a released flag check if the file
+                       * was indeed archived. */
+                       __u32 state = HS_NONE;
+                       rc = get_hsm_state(inode, &state);
+                       if (rc != 0)
+                               RETURN(rc);
+                       if (!(state & HS_ARCHIVED)) {
+                               CDEBUG(D_VFSTRACE,
+                                       "hus_states state = %x, pattern = %x\n",
+                                       state, lump->lmm_pattern);
+                               /* Here the state is: real file is not
+                                * archived but user is requesting to set
+                                * the RELEASED flag so we mask off the
+                                * released flag from the request */
+                               lump->lmm_pattern ^= LOV_PATTERN_F_RELEASED;
+                       }
+               }
 
                if (lump != NULL && S_ISREG(inode->i_mode)) {
                        struct file     f;
                        __u64           it_flags = FMODE_WRITE;
-                       int lum_size = (lump->lmm_magic == LOV_USER_MAGIC_V1) ?
-                               sizeof(*lump) : sizeof(struct lov_user_md_v3);
+                       int             lum_size;
+
+                       lum_size = ll_lov_user_md_size(lump);
+                       if (lum_size < 0 || size < lum_size)
+                               return 0; /* b=10667: ignore error */
 
                        memset(&f, 0, sizeof(f)); /* f.f_flags is used below */
-                       f.f_dentry = dentry;
+                       f.f_path.dentry = dentry;
                        rc = ll_lov_setstripe_ea_info(inode, &f, it_flags, lump,
                                                      lum_size);
-                       /* b10667: rc always be 0 here for now */
+                       /* b=10667: rc always be 0 here for now */
                        rc = 0;
                 } else if (S_ISDIR(inode->i_mode)) {
                         rc = ll_dir_setstripe(inode, lump, 0);
@@ -285,7 +307,6 @@ int ll_removexattr(struct dentry *dentry, const char *name)
                                   OBD_MD_FLXATTRRM);
 }
 
-static
 int ll_getxattr_common(struct inode *inode, const char *name,
                        void *buffer, size_t size, __u64 valid)
 {
@@ -294,8 +315,6 @@ int ll_getxattr_common(struct inode *inode, const char *name,
         struct mdt_body *body;
         int xattr_type, rc;
         void *xdata;
-        struct obd_capa *oc;
-        struct rmtacl_ctl_entry *rce = NULL;
        struct ll_inode_info *lli = ll_i2info(inode);
         ENTRY;
 
@@ -327,26 +346,12 @@ int ll_getxattr_common(struct inode *inode, const char *name,
                 RETURN(-EOPNOTSUPP);
 
 #ifdef CONFIG_FS_POSIX_ACL
-       if (sbi->ll_flags & LL_SBI_RMT_CLIENT &&
-           (xattr_type == XATTR_ACL_ACCESS_T ||
-           xattr_type == XATTR_ACL_DEFAULT_T)) {
-               rce = rct_search(&sbi->ll_rct, current_pid());
-               if (rce == NULL ||
-                   (rce->rce_ops != RMT_LSETFACL &&
-                   rce->rce_ops != RMT_LGETFACL &&
-                   rce->rce_ops != RMT_RSETFACL &&
-                   rce->rce_ops != RMT_RGETFACL))
-                       RETURN(-EOPNOTSUPP);
-       }
-
         /* posix acl is under protection of LOOKUP lock. when calling to this,
          * we just have path resolution to the target inode, so we have great
          * chance that cached ACL is uptodate.
          */
-        if (xattr_type == XATTR_ACL_ACCESS_T &&
-            !(sbi->ll_flags & LL_SBI_RMT_CLIENT)) {
-
-                struct posix_acl *acl;
+       if (xattr_type == XATTR_ACL_ACCESS_T) {
+               struct posix_acl *acl;
 
                spin_lock(&lli->lli_lock);
                acl = posix_acl_dup(lli->lli_posix_acl);
@@ -364,7 +369,10 @@ int ll_getxattr_common(struct inode *inode, const char *name,
 #endif
 
 do_getxattr:
-       if (sbi->ll_xattr_cache_enabled && xattr_type != XATTR_ACL_ACCESS_T) {
+       if (sbi->ll_xattr_cache_enabled &&
+           xattr_type != XATTR_ACL_ACCESS_T &&
+           (xattr_type != XATTR_SECURITY_T ||
+               strcmp(name, "security.selinux") != 0)) {
                rc = ll_xattr_cache_get(inode, name, buffer, size, valid);
                if (rc == -EAGAIN)
                        goto getxattr_nocache;
@@ -385,11 +393,8 @@ do_getxattr:
                }
        } else {
 getxattr_nocache:
-               oc = ll_mdscapa_get(inode);
-               rc = md_getxattr(sbi->ll_md_exp, ll_inode2fid(inode), oc,
-                               valid | (rce ? rce_ops2valid(rce->rce_ops) : 0),
-                               name, NULL, 0, size, 0, &req);
-               capa_put(oc);
+               rc = md_getxattr(sbi->ll_md_exp, ll_inode2fid(inode),
+                               valid, name, NULL, 0, size, 0, &req);
 
                if (rc < 0)
                        GOTO(out_xattr, rc);
@@ -420,22 +425,6 @@ getxattr_nocache:
                rc = body->mbo_eadatasize;
        }
 
-#ifdef CONFIG_FS_POSIX_ACL
-       if (rce != NULL && rce->rce_ops == RMT_LSETFACL) {
-               ext_acl_xattr_header *acl;
-
-               acl = lustre_posix_acl_xattr_2ext(buffer, rc);
-               if (IS_ERR(acl))
-                       GOTO(out, rc = PTR_ERR(acl));
-
-               rc = ee_add(&sbi->ll_et, current_pid(), ll_inode2fid(inode),
-                           xattr_type, acl);
-               if (unlikely(rc < 0)) {
-                       lustre_ext_acl_xattr_free(acl);
-                       GOTO(out, rc);
-               }
-       }
-#endif
        EXIT;
 
 out_xattr:
@@ -450,160 +439,150 @@ out:
         return rc;
 }
 
-ssize_t ll_getxattr(struct dentry *dentry, const char *name,
-                    void *buffer, size_t size)
+static ssize_t ll_getxattr_lov(struct inode *inode, void *buf, size_t buf_size)
 {
-        struct inode *inode = dentry->d_inode;
+       ssize_t rc;
 
-        LASSERT(inode);
-        LASSERT(name);
+       if (S_ISREG(inode->i_mode)) {
+               struct cl_object *obj = ll_i2info(inode)->lli_clob;
+               struct lu_env *env;
+               struct cl_layout cl = {
+                       .cl_buf.lb_buf = buf,
+                       .cl_buf.lb_len = buf_size,
+               };
+               __u16 refcheck;
+
+               if (obj == NULL)
+                       RETURN(-ENODATA);
+
+               env = cl_env_get(&refcheck);
+               if (IS_ERR(env))
+                       RETURN(PTR_ERR(env));
+
+               rc = cl_object_layout_get(env, obj, &cl);
+               if (rc < 0)
+                       GOTO(out_env, rc);
 
-       CDEBUG(D_VFSTRACE, "VFS Op:inode="DFID"(%p), xattr %s\n",
-              PFID(ll_inode2fid(inode)), inode, name);
+               if (cl.cl_size == 0)
+                       GOTO(out_env, rc = -ENODATA);
 
-        ll_stats_ops_tally(ll_i2sbi(inode), LPROC_LL_GETXATTR, 1);
-
-        if ((strncmp(name, XATTR_TRUSTED_PREFIX,
-                     sizeof(XATTR_TRUSTED_PREFIX) - 1) == 0 &&
-             strcmp(name + sizeof(XATTR_TRUSTED_PREFIX) - 1, "lov") == 0) ||
-            (strncmp(name, XATTR_LUSTRE_PREFIX,
-                     sizeof(XATTR_LUSTRE_PREFIX) - 1) == 0 &&
-             strcmp(name + sizeof(XATTR_LUSTRE_PREFIX) - 1, "lov") == 0)) {
-               struct lov_stripe_md *lsm;
-                struct lov_user_md *lump;
-                struct lov_mds_md *lmm = NULL;
-                struct ptlrpc_request *request = NULL;
-                int rc = 0, lmmsize = 0;
-
-                if (!S_ISREG(inode->i_mode) && !S_ISDIR(inode->i_mode))
-                        return -ENODATA;
-
-               lsm = ccc_inode_lsm_get(inode);
-               if (lsm == NULL) {
-                       if (S_ISDIR(inode->i_mode)) {
-                               rc = ll_dir_getstripe(inode, (void **)&lmm,
-                                                     &lmmsize, &request, 0);
-                       } else {
-                               rc = -ENODATA;
-                       }
-               } else {
-                       /* LSM is present already after lookup/getattr call.
-                        * we need to grab layout lock once it is implemented */
-                       rc = obd_packmd(ll_i2dtexp(inode), &lmm, lsm);
-                       lmmsize = rc;
-               }
-               ccc_inode_lsm_put(inode, lsm);
-
-                if (rc < 0)
-                       GOTO(out, rc);
-
-                if (size == 0) {
-                        /* used to call ll_get_max_mdsize() forward to get
-                         * the maximum buffer size, while some apps (such as
-                         * rsync 3.0.x) care much about the exact xattr value
-                         * size */
-                        rc = lmmsize;
-                        GOTO(out, rc);
-                }
+               rc = cl.cl_size;
 
-                if (size < lmmsize) {
-                        CERROR("server bug: replied size %d > %d for %s (%s)\n",
-                               lmmsize, (int)size, dentry->d_name.name, name);
-                        GOTO(out, rc = -ERANGE);
-                }
+               if (buf_size == 0)
+                       GOTO(out_env, rc);
 
-                lump = (struct lov_user_md *)buffer;
-                memcpy(lump, lmm, lmmsize);
-               /* do not return layout gen for getxattr otherwise it would
-                * confuse tar --xattr by recognizing layout gen as stripe
-                * offset when the file is restored. See LU-2809. */
-               lump->lmm_layout_gen = 0;
+               LASSERT(buf != NULL && rc <= buf_size);
 
-                rc = lmmsize;
-out:
-                if (request)
-                        ptlrpc_req_finished(request);
-                else if (lmm)
-                        obd_free_diskmd(ll_i2dtexp(inode), &lmm);
-                return(rc);
-        }
+               /* Do not return layout gen for getxattr() since
+                * otherwise it would confuse tar --xattr by
+                * recognizing layout gen as stripe offset when the
+                * file is restored. See LU-2809. */
+               ((struct lov_mds_md *)buf)->lmm_layout_gen = 0;
+out_env:
+               cl_env_put(env, &refcheck);
+
+               RETURN(rc);
+       } else if (S_ISDIR(inode->i_mode)) {
+               struct lov_mds_md *lmm = NULL;
+               int lmm_size = 0;
+               struct ptlrpc_request *req = NULL;
+
+               rc = ll_dir_getstripe(inode, (void **)&lmm, &lmm_size,
+                                     &req, 0);
+               if (rc < 0)
+                       GOTO(out_req, rc);
+
+               if (buf_size == 0)
+                       GOTO(out_req, rc = lmm_size);
+
+               if (buf_size < lmm_size)
+                       GOTO(out_req, rc = -ERANGE);
 
-        return ll_getxattr_common(inode, name, buffer, size, OBD_MD_FLXATTR);
+               memcpy(buf, lmm, lmm_size);
+               GOTO(out_req, rc = lmm_size);
+out_req:
+               if (req != NULL)
+                       ptlrpc_req_finished(req);
+
+               return rc;
+       } else {
+               RETURN(-ENODATA);
+       }
 }
 
-ssize_t ll_listxattr(struct dentry *dentry, char *buffer, size_t size)
+ssize_t ll_getxattr(struct dentry *dentry, const char *name, void *buf,
+                   size_t buf_size)
 {
-        struct inode *inode = dentry->d_inode;
-        int rc = 0, rc2 = 0;
-        struct lov_mds_md *lmm = NULL;
-        struct ptlrpc_request *request = NULL;
-        int lmmsize;
+       struct inode *inode = dentry->d_inode;
 
-        LASSERT(inode);
+       LASSERT(inode);
+       LASSERT(name);
+
+       CDEBUG(D_VFSTRACE, "VFS Op:inode="DFID"(%p), xattr %s\n",
+              PFID(ll_inode2fid(inode)), inode, name);
+
+       ll_stats_ops_tally(ll_i2sbi(inode), LPROC_LL_GETXATTR, 1);
+
+       if (strcmp(name, XATTR_LUSTRE_LOV) == 0 ||
+           strcmp(name, XATTR_NAME_LOV) == 0)
+               return ll_getxattr_lov(inode, buf, buf_size);
+       else
+               return ll_getxattr_common(inode, name, buf, buf_size,
+                                         OBD_MD_FLXATTR);
+}
+
+ssize_t ll_listxattr(struct dentry *dentry, char *buf, size_t buf_size)
+{
+       struct inode *inode = dentry->d_inode;
+       struct ll_sb_info *sbi = ll_i2sbi(inode);
+       char *xattr_name;
+       ssize_t rc, rc2;
+       size_t len, rem;
 
        CDEBUG(D_VFSTRACE, "VFS Op:inode="DFID"(%p)\n",
               PFID(ll_inode2fid(inode)), inode);
 
-        ll_stats_ops_tally(ll_i2sbi(inode), LPROC_LL_LISTXATTR, 1);
-
-        rc = ll_getxattr_common(inode, NULL, buffer, size, OBD_MD_FLXATTRLS);
-        if (rc < 0)
-                GOTO(out, rc);
-
-       if (buffer != NULL) {
-               struct ll_sb_info *sbi = ll_i2sbi(inode);
-               char *xattr_name = buffer;
-               int xlen, rem = rc;
-
-               while (rem > 0) {
-                       xlen = strnlen(xattr_name, rem - 1) + 1;
-                       rem -= xlen;
-                       if (xattr_type_filter(sbi,
-                                       get_xattr_type(xattr_name)) == 0) {
-                               /* skip OK xattr type
-                                * leave it in buffer
-                                */
-                               xattr_name += xlen;
-                               continue;
-                       }
-                       /* move up remaining xattrs in buffer
-                        * removing the xattr that is not OK
-                        */
-                       memmove(xattr_name, xattr_name + xlen, rem);
-                       rc -= xlen;
-               }
-       }
-       if (S_ISREG(inode->i_mode)) {
-               if (!ll_i2info(inode)->lli_has_smd)
-                       rc2 = -1;
-       } else if (S_ISDIR(inode->i_mode)) {
-               rc2 = ll_dir_getstripe(inode, (void **)&lmm, &lmmsize, &request,
-                                      0);
-       }
+       ll_stats_ops_tally(ll_i2sbi(inode), LPROC_LL_LISTXATTR, 1);
 
-        if (rc2 < 0) {
-                GOTO(out, rc2 = 0);
-        } else if (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode)) {
-                const int prefix_len = sizeof(XATTR_LUSTRE_PREFIX) - 1;
-                const size_t name_len   = sizeof("lov") - 1;
-                const size_t total_len  = prefix_len + name_len + 1;
+       rc = ll_getxattr_common(inode, NULL, buf, buf_size, OBD_MD_FLXATTRLS);
+       if (rc < 0)
+               RETURN(rc);
 
-               if (((rc + total_len) > size) && (buffer != NULL)) {
-                       ptlrpc_req_finished(request);
-                       return -ERANGE;
-               }
+       /* If we're being called to get the size of the xattr list
+        * (buf_size == 0) then just assume that a lustre.lov xattr
+        * exists. */
+       if (buf_size == 0)
+               RETURN(rc + sizeof(XATTR_LUSTRE_LOV));
+
+       xattr_name = buf;
+       rem = rc;
 
-               if (buffer != NULL) {
-                       buffer += rc;
-                       memcpy(buffer, XATTR_LUSTRE_PREFIX, prefix_len);
-                       memcpy(buffer + prefix_len, "lov", name_len);
-                       buffer[prefix_len + name_len] = '\0';
+       while (rem > 0) {
+               len = strnlen(xattr_name, rem - 1) + 1;
+               rem -= len;
+               if (xattr_type_filter(sbi, get_xattr_type(xattr_name)) == 0) {
+                       /* Skip OK xattr type, leave it in buffer. */
+                       xattr_name += len;
+                       continue;
                }
-               rc2 = total_len;
+
+               /* Move up remaining xattrs in buffer removing the
+                * xattr that is not OK. */
+               memmove(xattr_name, xattr_name + len, rem);
+               rc -= len;
        }
-out:
-        ptlrpc_req_finished(request);
-        rc = rc + rc2;
 
-        return rc;
+       rc2 = ll_getxattr_lov(inode, NULL, 0);
+       if (rc2 == -ENODATA)
+               RETURN(rc);
+
+       if (rc2 < 0)
+               RETURN(rc2);
+
+       if (buf_size < rc + sizeof(XATTR_LUSTRE_LOV))
+               RETURN(-ERANGE);
+
+       memcpy(buf + rc, XATTR_LUSTRE_LOV, sizeof(XATTR_LUSTRE_LOV));
+
+       RETURN(rc + sizeof(XATTR_LUSTRE_LOV));
 }