*/
/*
* This file is part of Lustre, http://www.lustre.org/
- * Lustre is a trademark of Sun Microsystems, Inc.
*
* Implementation of cl_page for VVP layer.
*
struct vvp_page *vpg = cl2vvp_page(slice);
struct page *vmpage = vpg->vpg_page;
+ ENTRY;
+
LASSERT(vmpage != NULL);
if (nonblock) {
if (!trylock_page(vmpage))
lock_page(vmpage);
wait_on_page_writeback(vmpage);
- return 0;
+ RETURN(0);
}
static void vvp_page_assume(const struct lu_env *env,
{
struct page *vmpage = cl2vm_page(slice);
+ ENTRY;
+
LASSERT(vmpage != NULL);
LASSERT(PageLocked(vmpage));
unlock_page(cl2vm_page(slice));
+
+ EXIT;
}
static void vvp_page_discard(const struct lu_env *env,
LASSERT(vmpage != NULL);
LASSERT(PageLocked(vmpage));
- if (vpg->vpg_defer_uptodate && !vpg->vpg_ra_used)
+ if (vpg->vpg_defer_uptodate && !vpg->vpg_ra_used && vmpage->mapping)
ll_ra_stats_inc(vmpage->mapping->host, RA_STAT_DISCARDED);
generic_error_remove_page(vmpage->mapping, vmpage);
const struct cl_page_slice *slice)
{
struct page *vmpage = cl2vm_page(slice);
- struct inode *inode = vmpage->mapping->host;
- struct cl_object *obj = slice->cpl_obj;
struct cl_page *page = slice->cpl_page;
int refc;
LASSERT(PageLocked(vmpage));
LASSERT((struct cl_page *)vmpage->private == page);
- LASSERT(inode == vvp_object_inode(obj));
+
/* Drop the reference count held in vvp_page_init */
refc = atomic_dec_return(&page->cp_ref);
}
static int vvp_page_is_vmlocked(const struct lu_env *env,
- const struct cl_page_slice *slice)
+ const struct cl_page_slice *slice)
{
- return PageLocked(cl2vm_page(slice)) ? -EBUSY : -ENODATA;
+ return PageLocked(cl2vm_page(slice)) ? -EBUSY : -ENODATA;
}
static int vvp_page_prep_read(const struct lu_env *env,
- const struct cl_page_slice *slice,
- struct cl_io *unused)
+ const struct cl_page_slice *slice,
+ struct cl_io *unused)
{
- ENTRY;
- /* Skip the page already marked as PG_uptodate. */
- RETURN(PageUptodate(cl2vm_page(slice)) ? -EALREADY : 0);
+ ENTRY;
+ /* Skip the page already marked as PG_uptodate. */
+ RETURN(PageUptodate(cl2vm_page(slice)) ? -EALREADY : 0);
}
static int vvp_page_prep_write(const struct lu_env *env,
- const struct cl_page_slice *slice,
- struct cl_io *unused)
+ const struct cl_page_slice *slice,
+ struct cl_io *unused)
{
struct page *vmpage = cl2vm_page(slice);
struct cl_page *pg = slice->cpl_page;
LASSERT(!PageDirty(vmpage));
/* ll_writepage path is not a sync write, so need to set page writeback
- * flag */
+ * flag
+ */
if (pg->cp_sync_io == NULL)
set_page_writeback(vmpage);
* This takes inode as a separate argument, because inode on which error is to
* be set can be different from \a vmpage inode in case of direct-io.
*/
-static void vvp_vmpage_error(struct inode *inode, struct page *vmpage, int ioret)
+static void vvp_vmpage_error(struct inode *inode, struct page *vmpage,
+ int ioret)
{
struct vvp_object *obj = cl_inode2vvp(inode);
struct page *vmpage = vpg->vpg_page;
struct cl_page *page = slice->cpl_page;
struct inode *inode = vvp_object_inode(page->cp_obj);
- ENTRY;
+ ENTRY;
LASSERT(PageLocked(vmpage));
CL_PAGE_HEADER(D_PAGE, env, page, "completing READ with %d\n", ioret);
cl_page_export(env, page, 1);
} else if (vpg->vpg_defer_uptodate) {
vpg->vpg_defer_uptodate = 0;
- if (ioret == -EWOULDBLOCK) {
+ if (ioret == -EAGAIN) {
/* mirror read failed, it needs to destroy the page
* because subpage would be from wrong osc when trying
- * to read from a new mirror */
+ * to read from a new mirror
+ */
generic_error_remove_page(vmpage->mapping, vmpage);
}
}
struct vvp_page *vpg = cl2vvp_page(slice);
struct cl_page *pg = slice->cpl_page;
struct page *vmpage = vpg->vpg_page;
- ENTRY;
+ ENTRY;
CL_PAGE_HEADER(D_PAGE, env, pg, "completing WRITE with %d\n", ioret);
if (pg->cp_sync_io != NULL) {
if (clear_page_dirty_for_io(vmpage)) {
LASSERT(pg->cp_state == CPS_CACHED);
/* This actually clears the dirty bit in the radix
- * tree. */
+ * tree.
+ */
set_page_writeback(vmpage);
CL_PAGE_HEADER(D_PAGE, env, pg, "readied\n");
} else if (pg->cp_state == CPS_PAGEOUT) {
/* is it possible for osc_flush_async_page() to already
- * make it ready? */
+ * make it ready?
+ */
result = -EALREADY;
} else {
CL_PAGE_DEBUG(D_ERROR, env, pg, "Unexpecting page state %d.\n",
struct vvp_page *vpg = cl2vvp_page(slice);
struct page *vmpage = vpg->vpg_page;
- (*printer)(env, cookie, LUSTRE_VVP_NAME"-page@%p(%d:%d) "
- "vm@%p ",
+ (*printer)(env, cookie,
+ LUSTRE_VVP_NAME"-page@%p(%d:%d) vm@%p ",
vpg, vpg->vpg_defer_uptodate, vpg->vpg_ra_used, vmpage);
if (vmpage != NULL) {
};
static void vvp_transient_page_discard(const struct lu_env *env,
- const struct cl_page_slice *slice,
- struct cl_io *unused)
+ const struct cl_page_slice *slice,
+ struct cl_io *unused)
{
- struct cl_page *page = slice->cpl_page;
+ struct cl_page *page = slice->cpl_page;
- /*
- * For transient pages, remove it from the radix tree.
- */
- cl_page_delete(env, page);
+ /*
+ * For transient pages, remove it from the radix tree.
+ */
+ cl_page_delete(env, page);
}
static int vvp_transient_page_is_vmlocked(const struct lu_env *env,
atomic_inc(&page->cp_ref);
SetPagePrivate(vmpage);
vmpage->private = (unsigned long)page;
- cl_page_slice_add(page, &vpg->vpg_cl, obj, index,
+ cl_page_slice_add(page, &vpg->vpg_cl, obj,
&vvp_page_ops);
} else {
struct vvp_object *clobj = cl2vvp(obj);
- cl_page_slice_add(page, &vpg->vpg_cl, obj, index,
+ cl_page_slice_add(page, &vpg->vpg_cl, obj,
&vvp_transient_page_ops);
atomic_inc(&clobj->vob_transient_pages);
}