Whamcloud - gitweb
LU-4429 llite: fix open lock matching in ll_md_blocking_ast()
[fs/lustre-release.git] / lustre / llite / namei.c
index aaf864b..b3780e2 100644 (file)
@@ -166,8 +166,8 @@ struct inode *ll_iget(struct super_block *sb, ino_t hash,
                                 unlock_new_inode(inode);
                 } else if (!(inode->i_state & (I_FREEING | I_CLEAR)))
                         ll_update_inode(inode, md);
-                CDEBUG(D_VFSTRACE, "got inode: %p for "DFID"\n",
-                       inode, PFID(&md->body->fid1));
+                       CDEBUG(D_VFSTRACE, "got inode: "DFID"(%p)\n",
+                              PFID(&md->body->fid1), inode);
         }
         RETURN(inode);
 }
@@ -196,112 +196,120 @@ static void ll_invalidate_negative_children(struct inode *dir)
 }
 
 int ll_md_blocking_ast(struct ldlm_lock *lock, struct ldlm_lock_desc *desc,
-                       void *data, int flag)
+                      void *data, int flag)
 {
-        int rc;
-        struct lustre_handle lockh;
-        ENTRY;
+       struct lustre_handle lockh;
+       int rc;
+       ENTRY;
 
-        switch (flag) {
-        case LDLM_CB_BLOCKING:
-                ldlm_lock2handle(lock, &lockh);
+       switch (flag) {
+       case LDLM_CB_BLOCKING:
+               ldlm_lock2handle(lock, &lockh);
                rc = ldlm_cli_cancel(&lockh, LCF_ASYNC);
-                if (rc < 0) {
-                        CDEBUG(D_INODE, "ldlm_cli_cancel: %d\n", rc);
-                        RETURN(rc);
-                }
-                break;
-        case LDLM_CB_CANCELING: {
+               if (rc < 0) {
+                       CDEBUG(D_INODE, "ldlm_cli_cancel: rc = %d\n", rc);
+                       RETURN(rc);
+               }
+               break;
+       case LDLM_CB_CANCELING: {
                struct inode *inode = ll_inode_from_resource_lock(lock);
-                struct ll_inode_info *lli;
-                __u64 bits = lock->l_policy_data.l_inodebits.bits;
-                struct lu_fid *fid;
-                ldlm_mode_t mode = lock->l_req_mode;
+               __u64 bits = lock->l_policy_data.l_inodebits.bits;
 
                /* Inode is set to lock->l_resource->lr_lvb_inode
                 * for mdc - bug 24555 */
                LASSERT(lock->l_ast_data == NULL);
 
-               /* Invalidate all dentries associated with this inode */
                if (inode == NULL)
                        break;
 
-               LASSERT(lock->l_flags & LDLM_FL_CANCELING);
+               /* Invalidate all dentries associated with this inode */
+               LASSERT(ldlm_is_canceling(lock));
+
+               if (!fid_res_name_eq(ll_inode2fid(inode),
+                                    &lock->l_resource->lr_name)) {
+                       LDLM_ERROR(lock, "data mismatch with object "DFID"(%p)",
+                                  PFID(ll_inode2fid(inode)), inode);
+                       LBUG();
+               }
 
-               if (bits & MDS_INODELOCK_XATTR)
+               if (bits & MDS_INODELOCK_XATTR) {
                        ll_xattr_cache_destroy(inode);
+                       bits &= ~MDS_INODELOCK_XATTR;
+               }
 
                /* For OPEN locks we differentiate between lock modes
                 * LCK_CR, LCK_CW, LCK_PR - bug 22891 */
+               if (bits & MDS_INODELOCK_OPEN)
+                       ll_have_md_lock(inode, &bits, lock->l_req_mode);
+
+               if (bits & MDS_INODELOCK_OPEN) {
+                       fmode_t fmode;
+
+                       switch (lock->l_req_mode) {
+                       case LCK_CW:
+                               fmode = FMODE_WRITE;
+                               break;
+                       case LCK_PR:
+                               fmode = FMODE_EXEC;
+                               break;
+                       case LCK_CR:
+                               fmode = FMODE_READ;
+                               break;
+                       default:
+                               LDLM_ERROR(lock, "bad lock mode for OPEN lock");
+                               LBUG();
+                       }
+
+                       ll_md_real_close(inode, fmode);
+
+                       bits &= ~MDS_INODELOCK_OPEN;
+               }
+
                if (bits & (MDS_INODELOCK_LOOKUP | MDS_INODELOCK_UPDATE |
                            MDS_INODELOCK_LAYOUT | MDS_INODELOCK_PERM))
-                        ll_have_md_lock(inode, &bits, LCK_MINMODE);
-
-                if (bits & MDS_INODELOCK_OPEN)
-                        ll_have_md_lock(inode, &bits, mode);
-
-               fid = ll_inode2fid(inode);
-               if (!fid_res_name_eq(fid, &lock->l_resource->lr_name))
-                       LDLM_ERROR(lock, "data mismatch with object "
-                                  DFID" (%p)", PFID(fid), inode);
-
-                if (bits & MDS_INODELOCK_OPEN) {
-                        int flags = 0;
-                        switch (lock->l_req_mode) {
-                        case LCK_CW:
-                                flags = FMODE_WRITE;
-                                break;
-                        case LCK_PR:
-                                flags = FMODE_EXEC;
-                                break;
-                        case LCK_CR:
-                                flags = FMODE_READ;
-                                break;
-                        default:
-                                CERROR("Unexpected lock mode for OPEN lock "
-                                       "%d, inode %ld\n", lock->l_req_mode,
-                                       inode->i_ino);
-                        }
-                        ll_md_real_close(inode, flags);
-                }
+                       ll_have_md_lock(inode, &bits, LCK_MINMODE);
 
-               lli = ll_i2info(inode);
                if (bits & MDS_INODELOCK_LAYOUT) {
-                       struct cl_object_conf conf = { { 0 } };
+                       struct cl_object_conf conf = {
+                               .coc_opc = OBJECT_CONF_INVALIDATE,
+                               .coc_inode = inode,
+                       };
 
-                       conf.coc_opc = OBJECT_CONF_INVALIDATE;
-                       conf.coc_inode = inode;
                        rc = ll_layout_conf(inode, &conf);
-                       if (rc)
-                               CDEBUG(D_INODE, "invaliding layout %d.\n", rc);
+                       if (rc < 0)
+                               CDEBUG(D_INODE, "cannot invalidate layout of "
+                                      DFID": rc = %d\n",
+                                      PFID(ll_inode2fid(inode)), rc);
                }
 
                if (bits & MDS_INODELOCK_UPDATE) {
+                       struct ll_inode_info *lli = ll_i2info(inode);
+
                        spin_lock(&lli->lli_lock);
-                        lli->lli_flags &= ~LLIF_MDS_SIZE_LOCK;
+                       lli->lli_flags &= ~LLIF_MDS_SIZE_LOCK;
                        spin_unlock(&lli->lli_lock);
                }
 
-                if (S_ISDIR(inode->i_mode) &&
-                     (bits & MDS_INODELOCK_UPDATE)) {
-                        CDEBUG(D_INODE, "invalidating inode %lu\n",
-                               inode->i_ino);
-                        truncate_inode_pages(inode->i_mapping, 0);
+               if ((bits & MDS_INODELOCK_UPDATE) && S_ISDIR(inode->i_mode)) {
+                       CDEBUG(D_INODE, "invalidating inode "DFID"\n",
+                              PFID(ll_inode2fid(inode)));
+                       truncate_inode_pages(inode->i_mapping, 0);
                        ll_invalidate_negative_children(inode);
                }
 
-               if (inode->i_sb->s_root &&
-                   inode != inode->i_sb->s_root->d_inode &&
-                   (bits & (MDS_INODELOCK_LOOKUP | MDS_INODELOCK_PERM)))
+               if ((bits & (MDS_INODELOCK_LOOKUP | MDS_INODELOCK_PERM)) &&
+                   inode->i_sb->s_root != NULL &&
+                   inode != inode->i_sb->s_root->d_inode)
                        ll_invalidate_aliases(inode);
-                iput(inode);
-                break;
-        }
-        default:
-                LBUG();
-        }
 
-        RETURN(0);
+               iput(inode);
+               break;
+       }
+       default:
+               LBUG();
+       }
+
+       RETURN(0);
 }
 
 __u32 ll_i2suppgid(struct inode *i)
@@ -418,7 +426,7 @@ struct dentry *ll_splice_alias(struct inode *inode, struct dentry *de)
                        iput(inode);
                        CDEBUG(D_DENTRY,
                               "Reuse dentry %p inode %p refc %d flags %#x\n",
-                             new, new->d_inode, d_refcount(new), new->d_flags);
+                             new, new->d_inode, d_count(new), new->d_flags);
                        return new;
                }
        }
@@ -427,7 +435,7 @@ struct dentry *ll_splice_alias(struct inode *inode, struct dentry *de)
                return ERR_PTR(rc);
        d_add(de, inode);
        CDEBUG(D_DENTRY, "Add dentry %p inode %p refc %d flags %#x\n",
-              de, de->d_inode, d_refcount(de), de->d_flags);
+              de, de->d_inode, d_count(de), de->d_flags);
         return de;
 }
 
@@ -473,6 +481,12 @@ int ll_lookup_it_finish(struct ptlrpc_request *request,
                if (IS_ERR(alias))
                        RETURN(PTR_ERR(alias));
                *de = alias;
+       } else if (!it_disposition(it, DISP_LOOKUP_NEG)  &&
+                  !it_disposition(it, DISP_OPEN_CREATE)) {
+               /* With DISP_OPEN_CREATE dentry will
+                  instantiated in ll_create_it. */
+               LASSERT((*de)->d_inode == NULL);
+               d_instantiate(*de, inode);
        }
 
        if (!it_disposition(it, DISP_LOOKUP_NEG)) {
@@ -514,9 +528,9 @@ static struct dentry *ll_lookup_it(struct inode *parent, struct dentry *dentry,
         if (dentry->d_name.len > ll_i2sbi(parent)->ll_namelen)
                 RETURN(ERR_PTR(-ENAMETOOLONG));
 
-        CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s,dir=%lu/%u(%p),intent=%s\n",
-               dentry->d_name.len, dentry->d_name.name, parent->i_ino,
-               parent->i_generation, parent, LL_IT2STR(it));
+       CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s, dir="DFID"(%p), intent=%s\n",
+              dentry->d_name.len, dentry->d_name.name,
+              PFID(ll_inode2fid(parent)), parent, LL_IT2STR(it));
 
         if (d_mountpoint(dentry))
                 CERROR("Tell Peter, lookup on mtpt, it %s\n", LL_IT2STR(it));
@@ -588,9 +602,9 @@ static struct dentry *ll_lookup_nd(struct inode *parent, struct dentry *dentry,
        struct lookup_intent *itp, it = { .it_op = IT_GETATTR };
        struct dentry *de;
 
-       CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s,dir=%lu/%u(%p),flags=%u\n",
-              dentry->d_name.len, dentry->d_name.name, parent->i_ino,
-              parent->i_generation, parent, flags);
+       CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s, dir="DFID"(%p), flags=%u\n",
+              dentry->d_name.len, dentry->d_name.name,
+              PFID(ll_inode2fid(parent)), parent, flags);
 
        /* Optimize away (CREATE && !OPEN). Let .create handle the race. */
        if ((flags & LOOKUP_CREATE) && !(flags & LOOKUP_OPEN))
@@ -622,10 +636,10 @@ static int ll_atomic_open(struct inode *dir, struct dentry *dentry,
        int rc = 0;
        ENTRY;
 
-       CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s,dir=%lu/%u(%p),file %p,"
-                          "open_flags %x,mode %x opened %d\n",
-              dentry->d_name.len, dentry->d_name.name, dir->i_ino,
-              dir->i_generation, dir, file, open_flags, mode, *opened);
+       CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s, dir="DFID"(%p), file %p,"
+                          "open_flags %x, mode %x opened %d\n",
+              dentry->d_name.len, dentry->d_name.name,
+              PFID(ll_inode2fid(dir)), dir, file, open_flags, mode, *opened);
 
        OBD_ALLOC(it, sizeof(*it));
        if (!it)
@@ -810,8 +824,8 @@ static struct inode *ll_create_node(struct inode *dir, const char *name,
         /* We asked for a lock on the directory, but were granted a
          * lock on the inode.  Since we finally have an inode pointer,
          * stuff it in the lock. */
-        CDEBUG(D_DLMTRACE, "setting l_ast_data to inode %p (%lu/%u)\n",
-               inode, inode->i_ino, inode->i_generation);
+       CDEBUG(D_DLMTRACE, "setting l_ast_data to inode "DFID"(%p)\n",
+              PFID(ll_inode2fid(inode)), inode);
         ll_set_lock_data(sbi->ll_md_exp, inode, it, NULL);
         EXIT;
  out:
@@ -840,9 +854,9 @@ static int ll_create_it(struct inode *dir, struct dentry *dentry, int mode,
        int rc = 0;
        ENTRY;
 
-       CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s,dir=%lu/%u(%p),intent=%s\n",
-              dentry->d_name.len, dentry->d_name.name, dir->i_ino,
-              dir->i_generation, dir, LL_IT2STR(it));
+       CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s, dir="DFID"(%p), intent=%s\n",
+              dentry->d_name.len, dentry->d_name.name,
+              PFID(ll_inode2fid(dir)), dir, LL_IT2STR(it));
 
        rc = it_open_error(DISP_OPEN_CREATE, it);
        if (rc)
@@ -869,8 +883,9 @@ static void ll_update_times(struct ptlrpc_request *request,
         LASSERT(body);
         if (body->valid & OBD_MD_FLMTIME &&
             body->mtime > LTIME_S(inode->i_mtime)) {
-                CDEBUG(D_INODE, "setting ino %lu mtime from %lu to "LPU64"\n",
-                       inode->i_ino, LTIME_S(inode->i_mtime), body->mtime);
+               CDEBUG(D_INODE, "setting fid "DFID" mtime from %lu to "LPU64
+                               "\n", PFID(ll_inode2fid(inode)),
+                               LTIME_S(inode->i_mtime), body->mtime);
                 LTIME_S(inode->i_mtime) = body->mtime;
         }
         if (body->valid & OBD_MD_FLCTIME &&
@@ -927,8 +942,8 @@ static int ll_mknod_generic(struct inode *dir, struct qstr *name, int mode,
         int err;
         ENTRY;
 
-        CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s,dir=%lu/%u(%p) mode %o dev %x\n",
-               name->len, name->name, dir->i_ino, dir->i_generation, dir,
+       CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s, dir="DFID"(%p) mode %o dev %x\n",
+              name->len, name->name, PFID(ll_inode2fid(dir)), dir,
                mode, rdev);
 
        if (!IS_POSIXACL(dir) || !exp_connect_umask(ll_i2mdexp(dir)))
@@ -967,10 +982,10 @@ static int ll_create_nd(struct inode *dir, struct dentry *dentry,
 {
        int rc;
 
-       CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s,dir=%lu/%u(%p),"
-                          "flags=%u, excl=%d\n",
-              dentry->d_name.len, dentry->d_name.name, dir->i_ino,
-              dir->i_generation, dir, mode, want_excl);
+       CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s, dir="DFID"(%p), "
+                          "flags=%u, excl=%d\n", dentry->d_name.len,
+              dentry->d_name.name, PFID(ll_inode2fid(dir)),
+              dir, mode, want_excl);
 
        rc = ll_mknod_generic(dir, &dentry->d_name, mode, 0, dentry);
 
@@ -1030,9 +1045,9 @@ static int ll_symlink_generic(struct inode *dir, struct qstr *name,
         int err;
         ENTRY;
 
-        CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s,dir=%lu/%u(%p),target=%.*s\n",
-               name->len, name->name, dir->i_ino, dir->i_generation,
-               dir, 3000, tgt);
+       CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s, dir="DFID"(%p), target=%.*s\n",
+              name->len, name->name, PFID(ll_inode2fid(dir)),
+              dir, 3000, tgt);
 
         err = ll_new_node(dir, name, (char *)tgt, S_IFLNK | S_IRWXUGO,
                           0, dchild, LUSTRE_OPC_SYMLINK);
@@ -1052,10 +1067,9 @@ static int ll_link_generic(struct inode *src,  struct inode *dir,
         int err;
 
         ENTRY;
-        CDEBUG(D_VFSTRACE,
-               "VFS Op: inode=%lu/%u(%p), dir=%lu/%u(%p), target=%.*s\n",
-               src->i_ino, src->i_generation, src, dir->i_ino,
-               dir->i_generation, dir, name->len, name->name);
+       CDEBUG(D_VFSTRACE, "VFS Op: inode="DFID"(%p), dir="DFID
+              "(%p), target=%.*s\n", PFID(ll_inode2fid(src)), src,
+              PFID(ll_inode2fid(dir)), dir, name->len, name->name);
 
         op_data = ll_prep_md_op_data(NULL, src, dir, name->name, name->len,
                                      0, LUSTRE_OPC_ANY, NULL);
@@ -1082,8 +1096,8 @@ static int ll_mkdir_generic(struct inode *dir, struct qstr *name,
         int err;
         ENTRY;
 
-        CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s,dir=%lu/%u(%p)\n",
-               name->len, name->name, dir->i_ino, dir->i_generation, dir);
+       CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s, dir="DFID"(%p)\n",
+              name->len, name->name, PFID(ll_inode2fid(dir)), dir);
 
        if (!IS_POSIXACL(dir) || !exp_connect_umask(ll_i2mdexp(dir)))
                mode &= ~current_umask();
@@ -1104,8 +1118,8 @@ static int ll_rmdir_generic(struct inode *dir, struct dentry *dparent,
         int rc;
         ENTRY;
 
-        CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s,dir=%lu/%u(%p)\n",
-               name->len, name->name, dir->i_ino, dir->i_generation, dir);
+       CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s, dir="DFID"(%p)\n",
+              name->len, name->name, PFID(ll_inode2fid(dir)), dir);
 
         if (unlikely(ll_d_mountpoint(dparent, dchild, name)))
                 RETURN(-EBUSY);
@@ -1139,8 +1153,8 @@ int ll_rmdir_entry(struct inode *dir, char *name, int namelen)
        int rc;
        ENTRY;
 
-       CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s,dir=%lu/%u(%p)\n",
-              namelen, name, dir->i_ino, dir->i_generation, dir);
+       CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s, dir="DFID"(%p)\n",
+              namelen, name, PFID(ll_inode2fid(dir)), dir);
 
        op_data = ll_prep_md_op_data(NULL, dir, NULL, name, strlen(name),
                                     S_IFDIR, LUSTRE_OPC_ANY, NULL);
@@ -1245,8 +1259,8 @@ static int ll_unlink_generic(struct inode *dir, struct dentry *dparent,
         struct md_op_data *op_data;
         int rc;
         ENTRY;
-        CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s,dir=%lu/%u(%p)\n",
-               name->len, name->name, dir->i_ino, dir->i_generation, dir);
+       CDEBUG(D_VFSTRACE, "VFS Op:name=%.*s, dir="DFID"(%p)\n",
+              name->len, name->name, PFID(ll_inode2fid(dir)), dir);
 
         /*
          * XXX: unlink bind mountpoint maybe call to here,
@@ -1288,10 +1302,11 @@ static int ll_rename_generic(struct inode *src, struct dentry *src_dparent,
         struct md_op_data *op_data;
         int err;
         ENTRY;
-        CDEBUG(D_VFSTRACE,"VFS Op:oldname=%.*s,src_dir=%lu/%u(%p),newname=%.*s,"
-               "tgt_dir=%lu/%u(%p)\n", src_name->len, src_name->name,
-               src->i_ino, src->i_generation, src, tgt_name->len,
-               tgt_name->name, tgt->i_ino, tgt->i_generation, tgt);
+       CDEBUG(D_VFSTRACE, "VFS Op:oldname=%.*s, src_dir="DFID
+              "(%p), newname=%.*s, tgt_dir="DFID"(%p)\n",
+              src_name->len, src_name->name,
+              PFID(ll_inode2fid(src)), src, tgt_name->len,
+              tgt_name->name, PFID(ll_inode2fid(tgt)), tgt);
 
         if (unlikely(ll_d_mountpoint(src_dparent, src_dchild, src_name) ||
             ll_d_mountpoint(tgt_dparent, tgt_dchild, tgt_name)))