Whamcloud - gitweb
LU-3384 llite: use READ, WRITE around ll_rw_stats_tally()
[fs/lustre-release.git] / lustre / llite / lproc_llite.c
index 4a96147..d63745d 100644 (file)
@@ -27,7 +27,7 @@
  * Copyright (c) 2002, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
  *
- * Copyright (c) 2012, Whamcloud, Inc.
+ * Copyright (c) 2012, 2013, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
@@ -234,17 +234,17 @@ static int ll_rd_site_stats(char *page, char **start, off_t off,
 static int ll_rd_max_readahead_mb(char *page, char **start, off_t off,
                                    int count, int *eof, void *data)
 {
-        struct super_block *sb = data;
-        struct ll_sb_info *sbi = ll_s2sbi(sb);
-        long pages_number;
-        int mult;
+       struct super_block *sb = data;
+       struct ll_sb_info *sbi = ll_s2sbi(sb);
+       long pages_number;
+       int mult;
 
-        cfs_spin_lock(&sbi->ll_lock);
-        pages_number = sbi->ll_ra_info.ra_max_pages;
-        cfs_spin_unlock(&sbi->ll_lock);
+       spin_lock(&sbi->ll_lock);
+       pages_number = sbi->ll_ra_info.ra_max_pages;
+       spin_unlock(&sbi->ll_lock);
 
-        mult = 1 << (20 - PAGE_CACHE_SHIFT);
-        return lprocfs_read_frac_helper(page, count, pages_number, mult);
+       mult = 1 << (20 - PAGE_CACHE_SHIFT);
+       return lprocfs_read_frac_helper(page, count, pages_number, mult);
 }
 
 static int ll_wr_max_readahead_mb(struct file *file, const char *buffer,
@@ -265,27 +265,27 @@ static int ll_wr_max_readahead_mb(struct file *file, const char *buffer,
                 return -ERANGE;
         }
 
-        cfs_spin_lock(&sbi->ll_lock);
-        sbi->ll_ra_info.ra_max_pages = pages_number;
-        cfs_spin_unlock(&sbi->ll_lock);
+       spin_lock(&sbi->ll_lock);
+       sbi->ll_ra_info.ra_max_pages = pages_number;
+       spin_unlock(&sbi->ll_lock);
 
-        return count;
+       return count;
 }
 
 static int ll_rd_max_readahead_per_file_mb(char *page, char **start, off_t off,
                                            int count, int *eof, void *data)
 {
-        struct super_block *sb = data;
-        struct ll_sb_info *sbi = ll_s2sbi(sb);
-        long pages_number;
-        int mult;
+       struct super_block *sb = data;
+       struct ll_sb_info *sbi = ll_s2sbi(sb);
+       long pages_number;
+       int mult;
 
-        cfs_spin_lock(&sbi->ll_lock);
-        pages_number = sbi->ll_ra_info.ra_max_pages_per_file;
-        cfs_spin_unlock(&sbi->ll_lock);
+       spin_lock(&sbi->ll_lock);
+       pages_number = sbi->ll_ra_info.ra_max_pages_per_file;
+       spin_unlock(&sbi->ll_lock);
 
-        mult = 1 << (20 - CFS_PAGE_SHIFT);
-        return lprocfs_read_frac_helper(page, count, pages_number, mult);
+       mult = 1 << (20 - CFS_PAGE_SHIFT);
+       return lprocfs_read_frac_helper(page, count, pages_number, mult);
 }
 
 static int ll_wr_max_readahead_per_file_mb(struct file *file, const char *buffer,
@@ -308,27 +308,27 @@ static int ll_wr_max_readahead_per_file_mb(struct file *file, const char *buffer
                 return -ERANGE;
         }
 
-        cfs_spin_lock(&sbi->ll_lock);
-        sbi->ll_ra_info.ra_max_pages_per_file = pages_number;
-        cfs_spin_unlock(&sbi->ll_lock);
+       spin_lock(&sbi->ll_lock);
+       sbi->ll_ra_info.ra_max_pages_per_file = pages_number;
+       spin_unlock(&sbi->ll_lock);
 
-        return count;
+       return count;
 }
 
 static int ll_rd_max_read_ahead_whole_mb(char *page, char **start, off_t off,
                                          int count, int *eof, void *data)
 {
-        struct super_block *sb = data;
-        struct ll_sb_info *sbi = ll_s2sbi(sb);
-        long pages_number;
-        int mult;
+       struct super_block *sb = data;
+       struct ll_sb_info *sbi = ll_s2sbi(sb);
+       long pages_number;
+       int mult;
 
-        cfs_spin_lock(&sbi->ll_lock);
-        pages_number = sbi->ll_ra_info.ra_max_read_ahead_whole_pages;
-        cfs_spin_unlock(&sbi->ll_lock);
+       spin_lock(&sbi->ll_lock);
+       pages_number = sbi->ll_ra_info.ra_max_read_ahead_whole_pages;
+       spin_unlock(&sbi->ll_lock);
 
-        mult = 1 << (20 - CFS_PAGE_SHIFT);
-        return lprocfs_read_frac_helper(page, count, pages_number, mult);
+       mult = 1 << (20 - CFS_PAGE_SHIFT);
+       return lprocfs_read_frac_helper(page, count, pages_number, mult);
 }
 
 static int ll_wr_max_read_ahead_whole_mb(struct file *file, const char *buffer,
@@ -353,11 +353,11 @@ static int ll_wr_max_read_ahead_whole_mb(struct file *file, const char *buffer,
                 return -ERANGE;
         }
 
-        cfs_spin_lock(&sbi->ll_lock);
-        sbi->ll_ra_info.ra_max_read_ahead_whole_pages = pages_number;
-        cfs_spin_unlock(&sbi->ll_lock);
+       spin_lock(&sbi->ll_lock);
+       sbi->ll_ra_info.ra_max_read_ahead_whole_pages = pages_number;
+       spin_unlock(&sbi->ll_lock);
 
-        return count;
+       return count;
 }
 
 static int ll_rd_max_cached_mb(char *page, char **start, off_t off,
@@ -413,9 +413,9 @@ static int ll_wr_max_cached_mb(struct file *file, const char *buffer,
        if (sbi->ll_dt_exp == NULL)
                RETURN(-ENODEV);
 
-       cfs_spin_lock(&sbi->ll_lock);
+       spin_lock(&sbi->ll_lock);
        diff = pages_number - cache->ccc_lru_max;
-       cfs_spin_unlock(&sbi->ll_lock);
+       spin_unlock(&sbi->ll_lock);
 
        /* easy - add more LRU slots. */
        if (diff >= 0) {
@@ -459,9 +459,9 @@ static int ll_wr_max_cached_mb(struct file *file, const char *buffer,
 
 out:
        if (rc >= 0) {
-               cfs_spin_lock(&sbi->ll_lock);
+               spin_lock(&sbi->ll_lock);
                cache->ccc_lru_max = pages_number;
-               cfs_spin_unlock(&sbi->ll_lock);
+               spin_unlock(&sbi->ll_lock);
                rc = count;
        } else {
                cfs_atomic_add(nrpages, &cache->ccc_lru_left);
@@ -714,6 +714,32 @@ static int ll_rd_maxea_size(char *page, char **start, off_t off,
         return snprintf(page, count, "%u\n", ealen);
 }
 
+static int ll_rd_sbi_flags(char *page, char **start, off_t off,
+                               int count, int *eof, void *data)
+{
+       const char *str[] = LL_SBI_FLAGS;
+       struct super_block *sb = data;
+       int flags = ll_s2sbi(sb)->ll_flags;
+       int i = 0;
+       int rc = 0;
+
+       while (flags != 0) {
+               if (ARRAY_SIZE(str) <= i) {
+                       CERROR("%s: Revise array LL_SBI_FLAGS to match sbi "
+                               "flags please.\n", ll_get_fsname(sb, NULL, 0));
+                       return -EINVAL;
+               }
+
+               if (flags & 0x1)
+                       rc += snprintf(page + rc, count - rc, "%s ", str[i]);
+               flags >>= 1;
+               ++i;
+       }
+       if (rc > 0)
+               rc += snprintf(page + rc, count - rc, "\b\n");
+       return rc;
+}
+
 static struct lprocfs_vars lprocfs_llite_obd_vars[] = {
         { "uuid",         ll_rd_sb_uuid,          0, 0 },
         //{ "mntpt_path",   ll_rd_path,             0, 0 },
@@ -744,6 +770,7 @@ static struct lprocfs_vars lprocfs_llite_obd_vars[] = {
         { "statahead_stats",  ll_rd_statahead_stats, 0, 0 },
         { "lazystatfs",       ll_rd_lazystatfs, ll_wr_lazystatfs, 0 },
         { "max_easize",       ll_rd_maxea_size, 0, 0 },
+       { "sbi_flags",        ll_rd_sbi_flags, 0, 0 },
         { 0 }
 };
 
@@ -1052,16 +1079,16 @@ static int ll_rw_extents_stats_pp_seq_show(struct seq_file *seq, void *v)
         seq_printf(seq, "%13s   %14s %4s %4s  | %14s %4s %4s\n",
                    "extents", "calls", "%", "cum%",
                    "calls", "%", "cum%");
-        cfs_spin_lock(&sbi->ll_pp_extent_lock);
-        for(k = 0; k < LL_PROCESS_HIST_MAX; k++) {
-                if(io_extents->pp_extents[k].pid != 0) {
-                        seq_printf(seq, "\nPID: %d\n",
-                                   io_extents->pp_extents[k].pid);
-                        ll_display_extents_info(io_extents, seq, k);
-                }
-        }
-        cfs_spin_unlock(&sbi->ll_pp_extent_lock);
-        return 0;
+       spin_lock(&sbi->ll_pp_extent_lock);
+       for (k = 0; k < LL_PROCESS_HIST_MAX; k++) {
+               if (io_extents->pp_extents[k].pid != 0) {
+                       seq_printf(seq, "\nPID: %d\n",
+                                  io_extents->pp_extents[k].pid);
+                       ll_display_extents_info(io_extents, seq, k);
+               }
+       }
+       spin_unlock(&sbi->ll_pp_extent_lock);
+       return 0;
 }
 
 static ssize_t ll_rw_extents_stats_pp_seq_write(struct file *file,
@@ -1084,14 +1111,14 @@ static ssize_t ll_rw_extents_stats_pp_seq_write(struct file *file,
         else
                 sbi->ll_rw_stats_on = 1;
 
-        cfs_spin_lock(&sbi->ll_pp_extent_lock);
-        for(i = 0; i < LL_PROCESS_HIST_MAX; i++) {
-                io_extents->pp_extents[i].pid = 0;
-                lprocfs_oh_clear(&io_extents->pp_extents[i].pp_r_hist);
-                lprocfs_oh_clear(&io_extents->pp_extents[i].pp_w_hist);
-        }
-        cfs_spin_unlock(&sbi->ll_pp_extent_lock);
-        return len;
+       spin_lock(&sbi->ll_pp_extent_lock);
+       for (i = 0; i < LL_PROCESS_HIST_MAX; i++) {
+               io_extents->pp_extents[i].pid = 0;
+               lprocfs_oh_clear(&io_extents->pp_extents[i].pp_r_hist);
+               lprocfs_oh_clear(&io_extents->pp_extents[i].pp_w_hist);
+       }
+       spin_unlock(&sbi->ll_pp_extent_lock);
+       return len;
 }
 
 LPROC_SEQ_FOPS(ll_rw_extents_stats_pp);
@@ -1117,11 +1144,11 @@ static int ll_rw_extents_stats_seq_show(struct seq_file *seq, void *v)
         seq_printf(seq, "%13s   %14s %4s %4s  | %14s %4s %4s\n",
                    "extents", "calls", "%", "cum%",
                    "calls", "%", "cum%");
-        cfs_spin_lock(&sbi->ll_lock);
-        ll_display_extents_info(io_extents, seq, LL_PROCESS_HIST_MAX);
-        cfs_spin_unlock(&sbi->ll_lock);
+       spin_lock(&sbi->ll_lock);
+       ll_display_extents_info(io_extents, seq, LL_PROCESS_HIST_MAX);
+       spin_unlock(&sbi->ll_lock);
 
-        return 0;
+       return 0;
 }
 
 static ssize_t ll_rw_extents_stats_seq_write(struct file *file, const char *buf,
@@ -1142,16 +1169,15 @@ static ssize_t ll_rw_extents_stats_seq_write(struct file *file, const char *buf,
                 sbi->ll_rw_stats_on = 0;
         else
                 sbi->ll_rw_stats_on = 1;
-        cfs_spin_lock(&sbi->ll_pp_extent_lock);
-        for(i = 0; i <= LL_PROCESS_HIST_MAX; i++)
-        {
-                io_extents->pp_extents[i].pid = 0;
-                lprocfs_oh_clear(&io_extents->pp_extents[i].pp_r_hist);
-                lprocfs_oh_clear(&io_extents->pp_extents[i].pp_w_hist);
-        }
-        cfs_spin_unlock(&sbi->ll_pp_extent_lock);
+       spin_lock(&sbi->ll_pp_extent_lock);
+       for (i = 0; i <= LL_PROCESS_HIST_MAX; i++) {
+               io_extents->pp_extents[i].pid = 0;
+               lprocfs_oh_clear(&io_extents->pp_extents[i].pp_r_hist);
+               lprocfs_oh_clear(&io_extents->pp_extents[i].pp_w_hist);
+       }
+       spin_unlock(&sbi->ll_pp_extent_lock);
 
-        return len;
+       return len;
 }
 
 LPROC_SEQ_FOPS(ll_rw_extents_stats);
@@ -1172,7 +1198,7 @@ void ll_rw_stats_tally(struct ll_sb_info *sbi, pid_t pid,
         process = sbi->ll_rw_process_info;
         offset = sbi->ll_rw_offset_info;
 
-        cfs_spin_lock(&sbi->ll_pp_extent_lock);
+       spin_lock(&sbi->ll_pp_extent_lock);
         /* Extent statistics */
         for(i = 0; i < LL_PROCESS_HIST_MAX; i++) {
                 if(io_extents->pp_extents[i].pid == pid) {
@@ -1200,9 +1226,9 @@ void ll_rw_stats_tally(struct ll_sb_info *sbi, pid_t pid,
                 io_extents->pp_extents[cur].pp_w_hist.oh_buckets[i]++;
                 io_extents->pp_extents[LL_PROCESS_HIST_MAX].pp_w_hist.oh_buckets[i]++;
         }
-        cfs_spin_unlock(&sbi->ll_pp_extent_lock);
+       spin_unlock(&sbi->ll_pp_extent_lock);
 
-        cfs_spin_lock(&sbi->ll_process_lock);
+       spin_lock(&sbi->ll_process_lock);
         /* Offset statistics */
         for (i = 0; i < LL_PROCESS_HIST_MAX; i++) {
                 if (process[i].rw_pid == pid) {
@@ -1213,7 +1239,7 @@ void ll_rw_stats_tally(struct ll_sb_info *sbi, pid_t pid,
                                 process[i].rw_largest_extent = count;
                                 process[i].rw_offset = 0;
                                 process[i].rw_last_file = file;
-                                cfs_spin_unlock(&sbi->ll_process_lock);
+                               spin_unlock(&sbi->ll_process_lock);
                                 return;
                         }
                         if (process[i].rw_last_file_pos != pos) {
@@ -1243,7 +1269,7 @@ void ll_rw_stats_tally(struct ll_sb_info *sbi, pid_t pid,
                         if(process[i].rw_largest_extent < count)
                                 process[i].rw_largest_extent = count;
                         process[i].rw_last_file_pos = pos + count;
-                        cfs_spin_unlock(&sbi->ll_process_lock);
+                       spin_unlock(&sbi->ll_process_lock);
                         return;
                 }
         }
@@ -1256,7 +1282,7 @@ void ll_rw_stats_tally(struct ll_sb_info *sbi, pid_t pid,
         process[*process_count].rw_largest_extent = count;
         process[*process_count].rw_offset = 0;
         process[*process_count].rw_last_file = file;
-        cfs_spin_unlock(&sbi->ll_process_lock);
+       spin_unlock(&sbi->ll_process_lock);
 }
 
 static int ll_rw_offset_stats_seq_show(struct seq_file *seq, void *v)
@@ -1275,40 +1301,44 @@ static int ll_rw_offset_stats_seq_show(struct seq_file *seq, void *v)
                                 "then 0 or \"[D/d]isabled\" to deactivate\n");
                 return 0;
         }
-        cfs_spin_lock(&sbi->ll_process_lock);
+       spin_lock(&sbi->ll_process_lock);
 
         seq_printf(seq, "snapshot_time:         %lu.%lu (secs.usecs)\n",
                    now.tv_sec, now.tv_usec);
         seq_printf(seq, "%3s %10s %14s %14s %17s %17s %14s\n",
                    "R/W", "PID", "RANGE START", "RANGE END",
                    "SMALLEST EXTENT", "LARGEST EXTENT", "OFFSET");
-        /* We stored the discontiguous offsets here; print them first */
-        for(i = 0; i < LL_OFFSET_HIST_MAX; i++) {
-                if (offset[i].rw_pid != 0)
-                        seq_printf(seq,"%3c %10d %14Lu %14Lu %17lu %17lu %14Lu",
-                                   offset[i].rw_op ? 'W' : 'R',
-                                   offset[i].rw_pid,
-                                   offset[i].rw_range_start,
-                                   offset[i].rw_range_end,
-                                   (unsigned long)offset[i].rw_smallest_extent,
-                                   (unsigned long)offset[i].rw_largest_extent,
-                                   offset[i].rw_offset);
-        }
-        /* Then print the current offsets for each process */
-        for(i = 0; i < LL_PROCESS_HIST_MAX; i++) {
-                if (process[i].rw_pid != 0)
-                        seq_printf(seq,"%3c %10d %14Lu %14Lu %17lu %17lu %14Lu",
-                                   process[i].rw_op ? 'W' : 'R',
-                                   process[i].rw_pid,
-                                   process[i].rw_range_start,
-                                   process[i].rw_last_file_pos,
-                                   (unsigned long)process[i].rw_smallest_extent,
-                                   (unsigned long)process[i].rw_largest_extent,
-                                   process[i].rw_offset);
-        }
-        cfs_spin_unlock(&sbi->ll_process_lock);
 
-        return 0;
+       /* We stored the discontiguous offsets here; print them first */
+       for (i = 0; i < LL_OFFSET_HIST_MAX; i++) {
+               if (offset[i].rw_pid != 0)
+                       seq_printf(seq,
+                                  "%3c %10d %14Lu %14Lu %17lu %17lu %14Lu",
+                                  offset[i].rw_op == READ ? 'R' : 'W',
+                                  offset[i].rw_pid,
+                                  offset[i].rw_range_start,
+                                  offset[i].rw_range_end,
+                                  (unsigned long)offset[i].rw_smallest_extent,
+                                  (unsigned long)offset[i].rw_largest_extent,
+                                  offset[i].rw_offset);
+       }
+
+       /* Then print the current offsets for each process */
+       for (i = 0; i < LL_PROCESS_HIST_MAX; i++) {
+               if (process[i].rw_pid != 0)
+                       seq_printf(seq,
+                                  "%3c %10d %14Lu %14Lu %17lu %17lu %14Lu",
+                                  process[i].rw_op == READ ? 'R' : 'W',
+                                  process[i].rw_pid,
+                                  process[i].rw_range_start,
+                                  process[i].rw_last_file_pos,
+                                  (unsigned long)process[i].rw_smallest_extent,
+                                  (unsigned long)process[i].rw_largest_extent,
+                                  process[i].rw_offset);
+       }
+       spin_unlock(&sbi->ll_process_lock);
+
+       return 0;
 }
 
 static ssize_t ll_rw_offset_stats_seq_write(struct file *file, const char *buf,
@@ -1331,16 +1361,16 @@ static ssize_t ll_rw_offset_stats_seq_write(struct file *file, const char *buf,
         else
                 sbi->ll_rw_stats_on = 1;
 
-        cfs_spin_lock(&sbi->ll_process_lock);
-        sbi->ll_offset_process_count = 0;
-        sbi->ll_rw_offset_entry_count = 0;
-        memset(process_info, 0, sizeof(struct ll_rw_process_info) *
-               LL_PROCESS_HIST_MAX);
-        memset(offset_info, 0, sizeof(struct ll_rw_process_info) *
-               LL_OFFSET_HIST_MAX);
-        cfs_spin_unlock(&sbi->ll_process_lock);
+       spin_lock(&sbi->ll_process_lock);
+       sbi->ll_offset_process_count = 0;
+       sbi->ll_rw_offset_entry_count = 0;
+       memset(process_info, 0, sizeof(struct ll_rw_process_info) *
+              LL_PROCESS_HIST_MAX);
+       memset(offset_info, 0, sizeof(struct ll_rw_process_info) *
+              LL_OFFSET_HIST_MAX);
+       spin_unlock(&sbi->ll_process_lock);
 
-        return len;
+       return len;
 }
 
 LPROC_SEQ_FOPS(ll_rw_offset_stats);