lli->lli_open_fd_exec_count = 0;
cfs_mutex_init(&lli->lli_och_mutex);
cfs_spin_lock_init(&lli->lli_agl_lock);
- lli->lli_smd = NULL;
+ lli->lli_has_smd = false;
lli->lli_clob = NULL;
LASSERT(lli->lli_vfs_inode.i_mode != 0);
* cl_object still uses inode lsm.
*/
cl_inode_fini(inode);
+ lli->lli_has_smd = false;
- if (lli->lli_smd) {
- obd_free_memmd(sbi->ll_dt_exp, &lli->lli_smd);
- lli->lli_smd = NULL;
- }
-
-
- EXIT;
+ EXIT;
}
int ll_md_setattr(struct dentry *dentry, struct md_op_data *op_data,
*/
int ll_setattr_raw(struct dentry *dentry, struct iattr *attr)
{
+ struct lov_stripe_md *lsm;
struct inode *inode = dentry->d_inode;
struct ll_inode_info *lli = ll_i2info(inode);
- struct lov_stripe_md *lsm = lli->lli_smd;
struct md_op_data *op_data = NULL;
struct md_open_data *mod = NULL;
int ia_valid = attr->ia_valid;
LTIME_S(attr->ia_mtime), LTIME_S(attr->ia_ctime),
cfs_time_current_sec());
- /* NB: ATTR_SIZE will only be set after this point if the size
- * resides on the MDS, ie, this file has no objects. */
- if (lsm)
- attr->ia_valid &= ~ATTR_SIZE;
-
/* We always do an MDS RPC, even if we're only changing the size;
* only the MDS knows whether truncate() should fail with -ETXTBUSY */
DOWN_WRITE_I_ALLOC_SEM(inode);
}
+ /* We need a steady stripe configuration for setattr to avoid
+ * confusion. */
+ lsm = ccc_inode_lsm_get(inode);
+
+ /* NB: ATTR_SIZE will only be set after this point if the size
+ * resides on the MDS, ie, this file has no objects. */
+ if (lsm != NULL)
+ attr->ia_valid &= ~ATTR_SIZE;
+
memcpy(&op_data->op_attr, attr, sizeof(*attr));
/* Open epoch for truncate. */
GOTO(out, rc);
ll_ioepoch_open(lli, op_data->op_ioepoch);
- if (!lsm || !S_ISREG(inode->i_mode)) {
+ if (lsm == NULL || !S_ISREG(inode->i_mode)) {
CDEBUG(D_INODE, "no lsm: not setting attrs on OST\n");
GOTO(out, rc = 0);
}
rc = ll_setattr_ost(inode, attr);
EXIT;
out:
+ ccc_inode_lsm_put(inode, lsm);
if (op_data) {
if (op_data->op_ioepoch) {
rc1 = ll_setattr_done_writing(inode, op_data, mod);
return 0;
}
-void ll_inode_size_lock(struct inode *inode, int lock_lsm)
+void ll_inode_size_lock(struct inode *inode)
{
struct ll_inode_info *lli;
- struct lov_stripe_md *lsm;
LASSERT(!S_ISDIR(inode->i_mode));
cfs_down(&lli->lli_size_sem);
LASSERT(lli->lli_size_sem_owner == NULL);
lli->lli_size_sem_owner = current;
- lsm = lli->lli_smd;
- LASSERTF(lsm != NULL || lock_lsm == 0, "lsm %p, lock_lsm %d\n",
- lsm, lock_lsm);
- if (lock_lsm)
- lov_stripe_lock(lsm);
}
-void ll_inode_size_unlock(struct inode *inode, int unlock_lsm)
+void ll_inode_size_unlock(struct inode *inode)
{
struct ll_inode_info *lli;
- struct lov_stripe_md *lsm;
lli = ll_i2info(inode);
- lsm = lli->lli_smd;
- LASSERTF(lsm != NULL || unlock_lsm == 0, "lsm %p, lock_lsm %d\n",
- lsm, unlock_lsm);
- if (unlock_lsm)
- lov_stripe_unlock(lsm);
LASSERT(lli->lli_size_sem_owner == current);
lli->lli_size_sem_owner = NULL;
cfs_up(&lli->lli_size_sem);
LASSERT(S_ISREG(inode->i_mode));
cfs_mutex_lock(&lli->lli_och_mutex);
- if (lli->lli_smd == NULL) {
- if (lsm->lsm_magic != LOV_MAGIC_V1 &&
- lsm->lsm_magic != LOV_MAGIC_V3) {
- dump_lsm(D_ERROR, lsm);
- LBUG();
- }
- CDEBUG(D_INODE, "adding lsm %p to inode %lu/%u(%p)\n",
- lsm, inode->i_ino, inode->i_generation, inode);
- /* cl_file_inode_init must go before lli_smd or a race
- * is possible where client thinks the file has stripes,
- * but lov raid0 is not setup yet and parallel e.g.
- * glimpse would try to use uninitialized lov */
- cl_file_inode_init(inode, md);
- cfs_spin_lock(&lli->lli_lock);
- lli->lli_smd = lsm;
- cfs_spin_unlock(&lli->lli_lock);
- cfs_mutex_unlock(&lli->lli_och_mutex);
- lli->lli_maxbytes = lsm->lsm_maxbytes;
- if (lli->lli_maxbytes > MAX_LFS_FILESIZE)
- lli->lli_maxbytes = MAX_LFS_FILESIZE;
- } else {
- cfs_mutex_unlock(&lli->lli_och_mutex);
- LASSERT(lli->lli_smd->lsm_magic == lsm->lsm_magic &&
- lli->lli_smd->lsm_stripe_count ==
- lsm->lsm_stripe_count);
- if (lov_stripe_md_cmp(lli->lli_smd, lsm)) {
- CERROR("lsm mismatch for inode %ld\n",
- inode->i_ino);
- CERROR("lli_smd:\n");
- dump_lsm(D_ERROR, lli->lli_smd);
- CERROR("lsm:\n");
- dump_lsm(D_ERROR, lsm);
- LBUG();
- }
- }
- if (lli->lli_smd != lsm)
- obd_free_memmd(ll_i2dtexp(inode), &lsm);
+ CDEBUG(D_INODE, "adding lsm %p to inode %lu/%u(%p)\n",
+ lsm, inode->i_ino, inode->i_generation, inode);
+ /* cl_file_inode_init must go before lli_has_smd or a race
+ * is possible where client thinks the file has stripes,
+ * but lov raid0 is not setup yet and parallel e.g.
+ * glimpse would try to use uninitialized lov */
+ if (cl_file_inode_init(inode, md) == 0)
+ lli->lli_has_smd = true;
+ cfs_mutex_unlock(&lli->lli_och_mutex);
+ lli->lli_maxbytes = lsm->lsm_maxbytes;
+ if (lli->lli_maxbytes > MAX_LFS_FILESIZE)
+ lli->lli_maxbytes = MAX_LFS_FILESIZE;
+ if (md->lsm != NULL)
+ obd_free_memmd(ll_i2dtexp(inode), &md->lsm);
}
if (sbi->ll_flags & LL_SBI_RMT_CLIENT) {
if (body->valid & OBD_MD_FLSIZE) {
if (exp_connect_som(ll_i2mdexp(inode)) &&
- S_ISREG(inode->i_mode) && lli->lli_smd) {
+ S_ISREG(inode->i_mode) && lli->lli_has_smd) {
struct lustre_handle lockh;
ldlm_mode_t mode;
CDEBUG(D_VFSTRACE, "VFS Op:inode="DFID"(%p)\n",
PFID(&lli->lli_fid), inode);
- LASSERT(!lli->lli_smd);
+ LASSERT(!lli->lli_has_smd);
/* Core attributes from the MDS first. This is a new inode, and
* the VFS doesn't zero times in the core inode so we have to do
RETURN(put_user(flags, (int *)arg));
}
case FSFILT_IOC_SETFLAGS: {
- struct lov_stripe_md *lsm = ll_i2info(inode)->lli_smd;
+ struct lov_stripe_md *lsm;
struct obd_info oinfo = { { { 0 } } };
struct md_op_data *op_data;
if (get_user(flags, (int *)arg))
RETURN(-EFAULT);
- oinfo.oi_md = lsm;
- OBDO_ALLOC(oinfo.oi_oa);
- if (!oinfo.oi_oa)
- RETURN(-ENOMEM);
-
op_data = ll_prep_md_op_data(NULL, inode, NULL, NULL, 0, 0,
LUSTRE_OPC_ANY, NULL);
if (IS_ERR(op_data))
NULL, 0, NULL, 0, &req, NULL);
ll_finish_md_op_data(op_data);
ptlrpc_req_finished(req);
- if (rc) {
- OBDO_FREE(oinfo.oi_oa);
- RETURN(rc);
- }
+ if (rc)
+ RETURN(rc);
- if (lsm == NULL) {
- OBDO_FREE(oinfo.oi_oa);
- GOTO(update_cache, rc);
- }
+ OBDO_ALLOC(oinfo.oi_oa);
+ if (!oinfo.oi_oa)
+ RETURN(-ENOMEM);
+
+ lsm = ccc_inode_lsm_get(inode);
+ if (lsm == NULL) {
+ inode->i_flags = ll_ext_to_inode_flags(flags);
+ OBDO_FREE(oinfo.oi_oa);
+ RETURN(0);
+ }
+ oinfo.oi_md = lsm;
oinfo.oi_oa->o_id = lsm->lsm_object_id;
oinfo.oi_oa->o_seq = lsm->lsm_object_seq;
oinfo.oi_oa->o_flags = flags;
rc = obd_setattr_rqset(sbi->ll_dt_exp, &oinfo, NULL);
capa_put(oinfo.oi_capa);
OBDO_FREE(oinfo.oi_oa);
- if (rc) {
- if (rc != -EPERM && rc != -EACCES)
- CERROR("osc_setattr_async fails: rc = %d\n",rc);
- RETURN(rc);
- }
+ ccc_inode_lsm_put(inode, lsm);
- EXIT;
-update_cache:
- inode->i_flags = ll_ext_to_inode_flags(flags);
- return 0;
+ if (rc && rc != -EPERM && rc != -EACCES)
+ CERROR("osc_setattr_async fails: rc = %d\n", rc);
+
+ RETURN(rc);
}
default:
RETURN(-ENOSYS);
* try to use the default stripe data from parent directory for
* allocating OST objects. Try to pass the parent FID to MDS. */
if (opc == LUSTRE_OPC_CREATE && i1 == i2 && S_ISREG(i2->i_mode) &&
- ll_i2info(i2)->lli_smd == NULL) {
- struct ll_inode_info *lli = ll_i2info(i2);
+ !ll_i2info(i2)->lli_has_smd) {
+ struct ll_inode_info *lli = ll_i2info(i2);
- cfs_spin_lock(&lli->lli_lock);
- if (likely(lli->lli_smd == NULL &&
- !fid_is_zero(&lli->lli_pfid)))
+ cfs_spin_lock(&lli->lli_lock);
+ if (likely(!lli->lli_has_smd && !fid_is_zero(&lli->lli_pfid)))
op_data->op_fid1 = lli->lli_pfid;
cfs_spin_unlock(&lli->lli_lock);
/** We ignore parent's capability temporary. */
git://git.whamcloud.com / fs / lustre-release.git / blobdiff