Whamcloud - gitweb
LU-14651 llite: extend inode methods with user namespace arg
[fs/lustre-release.git] / lustre / llite / llite_lib.c
index 2df83df..ccdcc8c 100644 (file)
@@ -40,6 +40,7 @@
 #include <linux/random.h>
 #include <linux/statfs.h>
 #include <linux/time.h>
+#include <linux/file.h>
 #include <linux/types.h>
 #include <libcfs/linux/linux-uuid.h>
 #include <linux/version.h>
@@ -52,6 +53,7 @@
 #ifndef HAVE_CPUS_READ_LOCK
 #include <libcfs/linux/linux-cpu.h>
 #endif
+#include <libcfs/linux/linux-misc.h>
 #include <uapi/linux/lustre/lustre_ioctl.h>
 #ifdef HAVE_UAPI_LINUX_MOUNT_H
 #include <uapi/linux/mount.h>
@@ -91,7 +93,6 @@ static struct ll_sb_info *ll_init_sbi(void)
        unsigned long lru_page_max;
        struct sysinfo si;
        int rc;
-       int i;
 
        ENTRY;
 
@@ -157,25 +158,18 @@ static struct ll_sb_info *ll_init_sbi(void)
        sbi->ll_ra_info.ra_max_read_ahead_whole_pages = -1;
        atomic_set(&sbi->ll_ra_info.ra_async_inflight, 0);
 
-        sbi->ll_flags |= LL_SBI_VERBOSE;
+       set_bit(LL_SBI_VERBOSE, sbi->ll_flags);
 #ifdef ENABLE_CHECKSUM
-        sbi->ll_flags |= LL_SBI_CHECKSUM;
+       set_bit(LL_SBI_CHECKSUM, sbi->ll_flags);
 #endif
 #ifdef ENABLE_FLOCK
-       sbi->ll_flags |= LL_SBI_FLOCK;
+       set_bit(LL_SBI_FLOCK, sbi->ll_flags);
 #endif
 
 #ifdef HAVE_LRU_RESIZE_SUPPORT
-        sbi->ll_flags |= LL_SBI_LRU_RESIZE;
+       set_bit(LL_SBI_LRU_RESIZE, sbi->ll_flags);
 #endif
-       sbi->ll_flags |= LL_SBI_LAZYSTATFS;
-
-        for (i = 0; i <= LL_PROCESS_HIST_MAX; i++) {
-               spin_lock_init(&sbi->ll_rw_extents_info.pp_extents[i].
-                              pp_r_hist.oh_lock);
-               spin_lock_init(&sbi->ll_rw_extents_info.pp_extents[i].
-                              pp_w_hist.oh_lock);
-        }
+       set_bit(LL_SBI_LAZYSTATFS, sbi->ll_flags);
 
        /* metadata statahead is enabled by default */
        sbi->ll_sa_running_max = LL_SA_RUNNING_DEF;
@@ -184,10 +178,10 @@ static struct ll_sb_info *ll_init_sbi(void)
        atomic_set(&sbi->ll_sa_wrong, 0);
        atomic_set(&sbi->ll_sa_running, 0);
        atomic_set(&sbi->ll_agl_total, 0);
-       sbi->ll_flags |= LL_SBI_AGL_ENABLED;
-       sbi->ll_flags |= LL_SBI_FAST_READ;
-       sbi->ll_flags |= LL_SBI_TINY_WRITE;
-       sbi->ll_flags |= LL_SBI_PARALLEL_DIO;
+       set_bit(LL_SBI_AGL_ENABLED, sbi->ll_flags);
+       set_bit(LL_SBI_FAST_READ, sbi->ll_flags);
+       set_bit(LL_SBI_TINY_WRITE, sbi->ll_flags);
+       set_bit(LL_SBI_PARALLEL_DIO, sbi->ll_flags);
        ll_sbi_set_encrypt(sbi, true);
 
        /* root squash */
@@ -260,6 +254,7 @@ static void ll_free_sbi(struct super_block *sb)
                                sizeof(struct ll_foreign_symlink_upcall_item));
                        sbi->ll_foreign_symlink_upcall_items = NULL;
                }
+               ll_free_rw_stats_info(sbi);
                pcc_super_fini(&sbi->ll_pcc_super);
                OBD_FREE(sbi, sizeof(*sbi));
        }
@@ -278,6 +273,9 @@ static int client_common_fill_super(struct super_block *sb, char *md, char *dt)
        struct lustre_md lmd;
        u64 valid;
        int size, err, checksum;
+       bool api32;
+       void *encctx;
+       int encctxlen;
 
        ENTRY;
        sbi->ll_md_obd = class_name2obd(md);
@@ -322,6 +320,7 @@ static int client_common_fill_super(struct super_block *sb, char *md, char *dt)
                                  OBD_CONNECT_SUBTREE |
                                  OBD_CONNECT_MULTIMODRPCS |
                                  OBD_CONNECT_GRANT_PARAM |
+                                 OBD_CONNECT_GRANT_SHRINK |
                                  OBD_CONNECT_SHORTIO | OBD_CONNECT_FLAGS2;
 
        data->ocd_connect_flags2 = OBD_CONNECT2_DIR_MIGRATE |
@@ -341,7 +340,7 @@ static int client_common_fill_super(struct super_block *sb, char *md, char *dt)
                                   OBD_CONNECT2_ATOMIC_OPEN_LOCK;
 
 #ifdef HAVE_LRU_RESIZE_SUPPORT
-        if (sbi->ll_flags & LL_SBI_LRU_RESIZE)
+       if (test_bit(LL_SBI_LRU_RESIZE, sbi->ll_flags))
                 data->ocd_connect_flags |= OBD_CONNECT_LRU_RESIZE;
 #endif
        data->ocd_connect_flags |= OBD_CONNECT_ACL_FLAGS;
@@ -358,7 +357,7 @@ static int client_common_fill_super(struct super_block *sb, char *md, char *dt)
 
        if (sb->s_flags & SB_RDONLY)
                data->ocd_connect_flags |= OBD_CONNECT_RDONLY;
-       if (sbi->ll_flags & LL_SBI_USER_XATTR)
+       if (test_bit(LL_SBI_USER_XATTR, sbi->ll_flags))
                data->ocd_connect_flags |= OBD_CONNECT_XATTR;
 
 #ifdef SB_NOSEC
@@ -370,7 +369,7 @@ static int client_common_fill_super(struct super_block *sb, char *md, char *dt)
        sbi->ll_fop = ll_select_file_operations(sbi);
 
        /* always ping even if server suppress_pings */
-       if (sbi->ll_flags & LL_SBI_ALWAYS_PING)
+       if (test_bit(LL_SBI_ALWAYS_PING, sbi->ll_flags))
                data->ocd_connect_flags &= ~OBD_CONNECT_PINGLESS;
 
        obd_connect_set_secctx(data);
@@ -455,35 +454,36 @@ static int client_common_fill_super(struct super_block *sb, char *md, char *dt)
        sb->s_maxbytes = MAX_LFS_FILESIZE;
        sbi->ll_namelen = osfs->os_namelen;
        sbi->ll_mnt.mnt = current->fs->root.mnt;
+       sbi->ll_mnt_ns = current->nsproxy->mnt_ns;
 
-       if ((sbi->ll_flags & LL_SBI_USER_XATTR) &&
+       if (test_bit(LL_SBI_USER_XATTR, sbi->ll_flags) &&
            !(data->ocd_connect_flags & OBD_CONNECT_XATTR)) {
                LCONSOLE_INFO("Disabling user_xattr feature because "
                              "it is not supported on the server\n");
-               sbi->ll_flags &= ~LL_SBI_USER_XATTR;
+               clear_bit(LL_SBI_USER_XATTR, sbi->ll_flags);
        }
 
        if (data->ocd_connect_flags & OBD_CONNECT_ACL) {
 #ifdef SB_POSIXACL
                sb->s_flags |= SB_POSIXACL;
 #endif
-               sbi->ll_flags |= LL_SBI_ACL;
+               set_bit(LL_SBI_ACL, sbi->ll_flags);
        } else {
                LCONSOLE_INFO("client wants to enable acl, but mdt not!\n");
 #ifdef SB_POSIXACL
                sb->s_flags &= ~SB_POSIXACL;
 #endif
-               sbi->ll_flags &= ~LL_SBI_ACL;
+               clear_bit(LL_SBI_ACL, sbi->ll_flags);
        }
 
        if (data->ocd_connect_flags & OBD_CONNECT_64BITHASH)
-               sbi->ll_flags |= LL_SBI_64BIT_HASH;
+               set_bit(LL_SBI_64BIT_HASH, sbi->ll_flags);
 
        if (data->ocd_connect_flags & OBD_CONNECT_LAYOUTLOCK)
-               sbi->ll_flags |= LL_SBI_LAYOUT_LOCK;
+               set_bit(LL_SBI_LAYOUT_LOCK, sbi->ll_flags);
 
        if (obd_connect_has_secctx(data))
-               sbi->ll_flags |= LL_SBI_FILE_SECCTX;
+               set_bit(LL_SBI_FILE_SECCTX, sbi->ll_flags);
 
        if (ll_sbi_has_encrypt(sbi) && !obd_connect_has_enc(data)) {
                if (ll_sbi_has_test_dummy_encryption(sbi))
@@ -500,7 +500,7 @@ static int client_common_fill_super(struct super_block *sb, char *md, char *dt)
                } else if (!sbi->ll_xattr_cache_set) {
                        /* If xattr_cache is already set (no matter 0 or 1)
                         * during processing llog, it won't be enabled here. */
-                       sbi->ll_flags |= LL_SBI_XATTR_CACHE;
+                       set_bit(LL_SBI_XATTR_CACHE, sbi->ll_flags);
                        sbi->ll_xattr_cache_enabled = 1;
                }
        }
@@ -552,7 +552,7 @@ static int client_common_fill_super(struct super_block *sb, char *md, char *dt)
        data->ocd_connect_flags |= OBD_CONNECT_LRU_RESIZE;
 #endif
        /* always ping even if server suppress_pings */
-       if (sbi->ll_flags & LL_SBI_ALWAYS_PING)
+       if (test_bit(LL_SBI_ALWAYS_PING, sbi->ll_flags))
                data->ocd_connect_flags &= ~OBD_CONNECT_PINGLESS;
 
        if (ll_sbi_has_encrypt(sbi))
@@ -644,8 +644,9 @@ static int client_common_fill_super(struct super_block *sb, char *md, char *dt)
 
        /* make root inode
         * XXX: move this to after cbd setup? */
-       valid = OBD_MD_FLGETATTR | OBD_MD_FLBLOCKS | OBD_MD_FLMODEASIZE;
-       if (sbi->ll_flags & LL_SBI_ACL)
+       valid = OBD_MD_FLGETATTR | OBD_MD_FLBLOCKS | OBD_MD_FLMODEASIZE |
+               OBD_MD_ENCCTX;
+       if (test_bit(LL_SBI_ACL, sbi->ll_flags))
                valid |= OBD_MD_FLACL;
 
        OBD_ALLOC_PTR(op_data);
@@ -658,6 +659,13 @@ static int client_common_fill_super(struct super_block *sb, char *md, char *dt)
 
        err = md_getattr(sbi->ll_md_exp, op_data, &request);
 
+       /* We need enc ctx info, so reset it in op_data to
+        * prevent it from being freed.
+        */
+       encctx = op_data->op_file_encctx;
+       encctxlen = op_data->op_file_encctx_size;
+       op_data->op_file_encctx = NULL;
+       op_data->op_file_encctx_size = 0;
        OBD_FREE_PTR(op_data);
        if (err) {
                CERROR("%s: md_getattr failed for root: rc = %d\n",
@@ -674,11 +682,9 @@ static int client_common_fill_super(struct super_block *sb, char *md, char *dt)
        }
 
        LASSERT(fid_is_sane(&sbi->ll_root_fid));
-       root = ll_iget(sb, cl_fid_build_ino(&sbi->ll_root_fid,
-                                           sbi->ll_flags & LL_SBI_32BIT_API),
-                      &lmd);
+       api32 = test_bit(LL_SBI_32BIT_API, sbi->ll_flags);
+       root = ll_iget(sb, cl_fid_build_ino(&sbi->ll_root_fid, api32), &lmd);
        md_free_lustre_md(sbi->ll_md_exp, &lmd);
-       ptlrpc_req_finished(request);
 
        if (IS_ERR(root)) {
                lmd_clear_acl(&lmd);
@@ -686,10 +692,23 @@ static int client_common_fill_super(struct super_block *sb, char *md, char *dt)
                root = NULL;
                CERROR("%s: bad ll_iget() for root: rc = %d\n",
                       sbi->ll_fsname, err);
+               ptlrpc_req_finished(request);
                GOTO(out_root, err);
        }
 
-       checksum = sbi->ll_flags & LL_SBI_CHECKSUM;
+       if (encctxlen) {
+               CDEBUG(D_SEC,
+                      "server returned encryption ctx for root inode "DFID"\n",
+                      PFID(&sbi->ll_root_fid));
+               err = ll_set_encflags(root, encctx, encctxlen, true);
+               if (err)
+                       CWARN("%s: cannot set enc ctx for "DFID": rc = %d\n",
+                             sbi->ll_fsname,
+                             PFID(&sbi->ll_root_fid), err);
+       }
+       ptlrpc_req_finished(request);
+
+       checksum = test_bit(LL_SBI_CHECKSUM, sbi->ll_flags);
        if (sbi->ll_checksum_set) {
                err = obd_set_info_async(NULL, sbi->ll_dt_exp,
                                         sizeof(KEY_CHECKSUM), KEY_CHECKSUM,
@@ -892,183 +911,196 @@ void ll_kill_super(struct super_block *sb)
        EXIT;
 }
 
-static inline int ll_set_opt(const char *opt, char *data, int fl)
+/* Since we use this table for ll_sbi_flags_seq_show make
+ * sure what you want displayed for a specific token that
+ * is listed more than once below be listed first. For
+ * example we want "checksum" displayed, not "nochecksum"
+ * for the sbi_flags.
+ */
+static const match_table_t ll_sbi_flags_name = {
+       {LL_SBI_NOLCK,                  "nolock"},
+       {LL_SBI_CHECKSUM,               "checksum"},
+       {LL_SBI_CHECKSUM,               "nochecksum"},
+       {LL_SBI_LOCALFLOCK,             "localflock"},
+       {LL_SBI_FLOCK,                  "flock"},
+       {LL_SBI_FLOCK,                  "noflock"},
+       {LL_SBI_USER_XATTR,             "user_xattr"},
+       {LL_SBI_USER_XATTR,             "nouser_xattr"},
+       {LL_SBI_LRU_RESIZE,             "lruresize"},
+       {LL_SBI_LRU_RESIZE,             "nolruresize"},
+       {LL_SBI_LAZYSTATFS,             "lazystatfs"},
+       {LL_SBI_LAZYSTATFS,             "nolazystatfs"},
+       {LL_SBI_32BIT_API,              "32bitapi"},
+       {LL_SBI_USER_FID2PATH,          "user_fid2path"},
+       {LL_SBI_USER_FID2PATH,          "nouser_fid2path"},
+       {LL_SBI_VERBOSE,                "verbose"},
+       {LL_SBI_VERBOSE,                "noverbose"},
+       {LL_SBI_ALWAYS_PING,            "always_ping"},
+       {LL_SBI_TEST_DUMMY_ENCRYPTION,  "test_dummy_encryption"},
+       {LL_SBI_ENCRYPT,                "encrypt"},
+       {LL_SBI_ENCRYPT,                "noencrypt"},
+       {LL_SBI_FOREIGN_SYMLINK,        "foreign_symlink=%s"},
+       {LL_SBI_NUM_MOUNT_OPT,          NULL},
+
+       {LL_SBI_ACL,                    "acl"},
+       {LL_SBI_AGL_ENABLED,            "agl"},
+       {LL_SBI_64BIT_HASH,             "64bit_hash"},
+       {LL_SBI_LAYOUT_LOCK,            "layout"},
+       {LL_SBI_XATTR_CACHE,            "xattr_cache"},
+       {LL_SBI_NOROOTSQUASH,           "norootsquash"},
+       {LL_SBI_FAST_READ,              "fast_read"},
+       {LL_SBI_FILE_SECCTX,            "file_secctx"},
+       {LL_SBI_TINY_WRITE,             "tiny_write"},
+       {LL_SBI_FILE_HEAT,              "file_heat"},
+       {LL_SBI_PARALLEL_DIO,           "parallel_dio"},
+};
+
+int ll_sbi_flags_seq_show(struct seq_file *m, void *v)
 {
-       if (strncmp(opt, data, strlen(opt)) != 0)
-               return 0;
-       else
-               return fl;
+       struct super_block *sb = m->private;
+       int i;
+
+       for (i = 0; i < LL_SBI_NUM_FLAGS; i++) {
+               int j;
+
+               if (!test_bit(i, ll_s2sbi(sb)->ll_flags))
+                       continue;
+
+               for (j = 0; j < ARRAY_SIZE(ll_sbi_flags_name); j++) {
+                       if (ll_sbi_flags_name[j].token == i &&
+                           ll_sbi_flags_name[j].pattern) {
+                               seq_printf(m, "%s ",
+                                          ll_sbi_flags_name[j].pattern);
+                               break;
+                       }
+               }
+       }
+       seq_puts(m, "\b\n");
+       return 0;
 }
 
 /* non-client-specific mount options are parsed in lmd_parse */
-static int ll_options(char *options, struct ll_sb_info *sbi)
+static int ll_options(char *options, struct super_block *sb)
 {
-       int tmp;
-       char *s1 = options, *s2;
-       int *flags = &sbi->ll_flags;
-       ENTRY;
+       struct ll_sb_info *sbi = ll_s2sbi(sb);
+       char *s2, *s1, *opts;
 
+       ENTRY;
        if (!options)
                RETURN(0);
 
+       /* Don't stomp on lmd_opts */
+       opts = kstrdup(options, GFP_KERNEL);
+       if (!opts)
+               RETURN(-ENOMEM);
+       s1 = opts;
+       s2 = opts;
+
        CDEBUG(D_CONFIG, "Parsing opts %s\n", options);
 
-       while (*s1) {
+       while ((s1 = strsep(&opts, ",")) != NULL) {
+               substring_t args[MAX_OPT_ARGS];
+               bool turn_off = false;
+               int token;
+
+               if (!*s1)
+                       continue;
+
                CDEBUG(D_SUPER, "next opt=%s\n", s1);
-               tmp = ll_set_opt("nolock", s1, LL_SBI_NOLCK);
-               if (tmp) {
-                       *flags |= tmp;
-                       goto next;
-               }
-               tmp = ll_set_opt("flock", s1, LL_SBI_FLOCK);
-               if (tmp) {
-                       *flags = (*flags & ~LL_SBI_LOCALFLOCK) | tmp;
-                       goto next;
-               }
-               tmp = ll_set_opt("localflock", s1, LL_SBI_LOCALFLOCK);
-               if (tmp) {
-                       *flags = (*flags & ~LL_SBI_FLOCK) | tmp;
-                       goto next;
-               }
-               tmp = ll_set_opt("noflock", s1, LL_SBI_FLOCK|LL_SBI_LOCALFLOCK);
-               if (tmp) {
-                       *flags &= ~tmp;
-                       goto next;
-               }
-               tmp = ll_set_opt("user_xattr", s1, LL_SBI_USER_XATTR);
-               if (tmp) {
-                       *flags |= tmp;
-                       goto next;
-               }
-               tmp = ll_set_opt("nouser_xattr", s1, LL_SBI_USER_XATTR);
-               if (tmp) {
-                       *flags &= ~tmp;
-                       goto next;
-               }
-               tmp = ll_set_opt("context", s1, 1);
-               if (tmp)
-                       goto next;
-               tmp = ll_set_opt("fscontext", s1, 1);
-               if (tmp)
-                       goto next;
-               tmp = ll_set_opt("defcontext", s1, 1);
-               if (tmp)
-                       goto next;
-               tmp = ll_set_opt("rootcontext", s1, 1);
-               if (tmp)
-                       goto next;
-               tmp = ll_set_opt("user_fid2path", s1, LL_SBI_USER_FID2PATH);
-               if (tmp) {
-                       *flags |= tmp;
-                       goto next;
-               }
-               tmp = ll_set_opt("nouser_fid2path", s1, LL_SBI_USER_FID2PATH);
-               if (tmp) {
-                       *flags &= ~tmp;
-                       goto next;
-               }
 
-               tmp = ll_set_opt("checksum", s1, LL_SBI_CHECKSUM);
-               if (tmp) {
-                       *flags |= tmp;
-                       sbi->ll_checksum_set = 1;
-                       goto next;
+               if (strncmp(s1, "no", 2) == 0)
+                       turn_off = true;
+
+               /*
+                * Initialize args struct so we know whether arg was
+                * found; some options take optional arguments.
+                */
+               args[0].to = NULL;
+               args[0].from = NULL;
+               token = match_token(s1, ll_sbi_flags_name, args);
+               if (token == LL_SBI_NUM_MOUNT_OPT) {
+                       if (match_wildcard("context", s1) ||
+                           match_wildcard("fscontext", s1) ||
+                           match_wildcard("defcontext", s1) ||
+                           match_wildcard("rootcontext",s1))
+                               continue;
+
+                       LCONSOLE_ERROR_MSG(0x152,
+                                          "Unknown option '%s', won't mount.\n",
+                                          s1);
+                       RETURN(-EINVAL);
                }
-               tmp = ll_set_opt("nochecksum", s1, LL_SBI_CHECKSUM);
-               if (tmp) {
-                       *flags &= ~tmp;
+
+               switch (token) {
+               case LL_SBI_NOLCK:
+               case LL_SBI_32BIT_API:
+               case LL_SBI_64BIT_HASH:
+               case LL_SBI_ALWAYS_PING:
+                       set_bit(token, sbi->ll_flags);
+                       break;
+
+               case LL_SBI_FLOCK:
+                       clear_bit(LL_SBI_LOCALFLOCK, sbi->ll_flags);
+                       if (turn_off)
+                               clear_bit(LL_SBI_FLOCK, sbi->ll_flags);
+                       else
+                               set_bit(token, sbi->ll_flags);
+                       break;
+
+               case LL_SBI_LOCALFLOCK:
+                       clear_bit(LL_SBI_FLOCK, sbi->ll_flags);
+                       set_bit(token, sbi->ll_flags);
+                       break;
+
+               case LL_SBI_CHECKSUM:
                        sbi->ll_checksum_set = 1;
-                       goto next;
-               }
-                tmp = ll_set_opt("lruresize", s1, LL_SBI_LRU_RESIZE);
-                if (tmp) {
-                        *flags |= tmp;
-                        goto next;
-                }
-                tmp = ll_set_opt("nolruresize", s1, LL_SBI_LRU_RESIZE);
-                if (tmp) {
-                        *flags &= ~tmp;
-                        goto next;
-                }
-                tmp = ll_set_opt("lazystatfs", s1, LL_SBI_LAZYSTATFS);
-                if (tmp) {
-                        *flags |= tmp;
-                        goto next;
-                }
-                tmp = ll_set_opt("nolazystatfs", s1, LL_SBI_LAZYSTATFS);
-                if (tmp) {
-                        *flags &= ~tmp;
-                        goto next;
-                }
-                tmp = ll_set_opt("32bitapi", s1, LL_SBI_32BIT_API);
-                if (tmp) {
-                        *flags |= tmp;
-                        goto next;
-                }
-                tmp = ll_set_opt("verbose", s1, LL_SBI_VERBOSE);
-                if (tmp) {
-                        *flags |= tmp;
-                        goto next;
-                }
-                tmp = ll_set_opt("noverbose", s1, LL_SBI_VERBOSE);
-                if (tmp) {
-                        *flags &= ~tmp;
-                        goto next;
-                }
-               tmp = ll_set_opt("always_ping", s1, LL_SBI_ALWAYS_PING);
-               if (tmp) {
-                       *flags |= tmp;
-                       goto next;
-               }
-               tmp = ll_set_opt("test_dummy_encryption", s1,
-                                LL_SBI_TEST_DUMMY_ENCRYPTION);
-               if (tmp) {
+                       /* fall through */
+               case LL_SBI_USER_XATTR:
+               case LL_SBI_USER_FID2PATH:
+               case LL_SBI_LRU_RESIZE:
+               case LL_SBI_LAZYSTATFS:
+               case LL_SBI_VERBOSE:
+                       if (turn_off)
+                               clear_bit(token, sbi->ll_flags);
+                       else
+                               set_bit(token, sbi->ll_flags);
+                       break;
+               case LL_SBI_TEST_DUMMY_ENCRYPTION: {
 #ifdef HAVE_LUSTRE_CRYPTO
-                       *flags |= tmp;
+                       set_bit(token, sbi->ll_flags);
 #else
                        LCONSOLE_WARN("Test dummy encryption mount option ignored: encryption not supported\n");
 #endif
-                       goto next;
+                       break;
                }
-               tmp = ll_set_opt("noencrypt", s1, LL_SBI_ENCRYPT);
-               if (tmp) {
+               case LL_SBI_ENCRYPT:
 #ifdef HAVE_LUSTRE_CRYPTO
-                       *flags &= ~tmp;
+                       if (turn_off)
+                               clear_bit(token, sbi->ll_flags);
+                       else
+                               set_bit(token, sbi->ll_flags);
 #else
-                       LCONSOLE_WARN("noencrypt mount option ignored: encryption not supported\n");
+                       LCONSOLE_WARN("noencrypt or encrypt mount option ignored: encryption not supported\n");
 #endif
-                       goto next;
-               }
-               tmp = ll_set_opt("foreign_symlink", s1, LL_SBI_FOREIGN_SYMLINK);
-               if (tmp) {
-                       int prefix_pos = sizeof("foreign_symlink=") - 1;
-                       int equal_pos = sizeof("foreign_symlink=") - 2;
-
+                       break;
+               case LL_SBI_FOREIGN_SYMLINK:
                        /* non-default prefix provided ? */
-                       if (strlen(s1) >= sizeof("foreign_symlink=") &&
-                           *(s1 + equal_pos) == '=') {
-                               char *old = sbi->ll_foreign_symlink_prefix;
-                               size_t old_len =
-                                       sbi->ll_foreign_symlink_prefix_size;
+                       if (args->from) {
+                               size_t old_len;
+                               char *old;
 
                                /* path must be absolute */
-                               if (*(s1 + sizeof("foreign_symlink=")
-                                     - 1) != '/') {
+                               if (args->from[0] != '/') {
                                        LCONSOLE_ERROR_MSG(0x152,
-                                               "foreign prefix '%s' must be an absolute path\n",
-                                               s1 + prefix_pos);
+                                                          "foreign prefix '%s' must be an absolute path\n",
+                                                          args->from);
                                        RETURN(-EINVAL);
                                }
-                               /* last option ? */
-                               s2 = strchrnul(s1 + prefix_pos, ',');
 
-                               if (sbi->ll_foreign_symlink_prefix) {
-                                       sbi->ll_foreign_symlink_prefix = NULL;
-                                       sbi->ll_foreign_symlink_prefix_size = 0;
-                               }
+                               old_len = sbi->ll_foreign_symlink_prefix_size;
+                               old = sbi->ll_foreign_symlink_prefix;
                                /* alloc for path length and '\0' */
-                               OBD_ALLOC(sbi->ll_foreign_symlink_prefix,
-                                               s2 - (s1 + prefix_pos) + 1);
+                               sbi->ll_foreign_symlink_prefix = match_strdup(args);
                                if (!sbi->ll_foreign_symlink_prefix) {
                                        /* restore previous */
                                        sbi->ll_foreign_symlink_prefix = old;
@@ -1076,32 +1108,26 @@ static int ll_options(char *options, struct ll_sb_info *sbi)
                                                old_len;
                                        RETURN(-ENOMEM);
                                }
+                               sbi->ll_foreign_symlink_prefix_size =
+                                       args->to - args->from + 1;
+                               OBD_ALLOC_POST(sbi->ll_foreign_symlink_prefix,
+                                              sbi->ll_foreign_symlink_prefix_size,
+                                              "kmalloced");
                                if (old)
                                        OBD_FREE(old, old_len);
-                               strncpy(sbi->ll_foreign_symlink_prefix,
-                                       s1 + prefix_pos,
-                                       s2 - (s1 + prefix_pos));
-                               sbi->ll_foreign_symlink_prefix_size =
-                                       s2 - (s1 + prefix_pos) + 1;
+
+                               /* enable foreign symlink support */
+                               set_bit(token, sbi->ll_flags);
                        } else {
                                LCONSOLE_ERROR_MSG(0x152,
                                                   "invalid %s option\n", s1);
                        }
-                       /* enable foreign symlink support */
-                       *flags |= tmp;
-                       goto next;
+               /* fall through */
+               default:
+                       break;
                }
-                LCONSOLE_ERROR_MSG(0x152, "Unknown option '%s', won't mount.\n",
-                                   s1);
-                RETURN(-EINVAL);
-
-next:
-                /* Find next opt */
-                s2 = strchr(s1, ',');
-                if (s2 == NULL)
-                        break;
-                s1 = s2 + 1;
         }
+       kfree(opts);
         RETURN(0);
 }
 
@@ -1236,7 +1262,7 @@ int ll_fill_super(struct super_block *sb)
        if (IS_ERR(sbi))
                GOTO(out_free_cfg, err = PTR_ERR(sbi));
 
-       err = ll_options(lsi->lsi_lmd->lmd_opts, sbi);
+       err = ll_options(lsi->lsi_lmd->lmd_opts, sb);
        if (err)
                GOTO(out_free_cfg, err);
 
@@ -1276,6 +1302,9 @@ int ll_fill_super(struct super_block *sb)
        if (err)
                GOTO(out_free_cfg, err);
 
+       /* disable kernel readahead */
+       sb->s_bdi->ra_pages = 0;
+
        /* Call ll_debugfs_register_super() before lustre_process_log()
         * so that "llite.*.*" params can be processed correctly.
         */
@@ -1346,7 +1375,7 @@ out_free_cfg:
 
        if (err)
                ll_put_super(sb);
-       else if (sbi->ll_flags & LL_SBI_VERBOSE)
+       else if (test_bit(LL_SBI_VERBOSE, sbi->ll_flags))
                LCONSOLE_WARN("Mounted %s\n", profilenm);
        RETURN(err);
 } /* ll_fill_super */
@@ -1413,7 +1442,7 @@ void ll_put_super(struct super_block *sb)
        while ((obd = class_devices_in_group(&sbi->ll_sb_uuid, &next)))
                class_manual_cleanup(obd);
 
-       if (sbi->ll_flags & LL_SBI_VERBOSE)
+       if (test_bit(LL_SBI_VERBOSE, sbi->ll_flags))
                LCONSOLE_WARN("Unmounted %s\n", profilenm ? profilenm : "");
 
        if (profilenm)
@@ -1491,7 +1520,7 @@ static struct inode *ll_iget_anon_dir(struct super_block *sb,
        ENTRY;
 
        LASSERT(md->lmv);
-       ino = cl_fid_build_ino(fid, sbi->ll_flags & LL_SBI_32BIT_API);
+       ino = cl_fid_build_ino(fid, test_bit(LL_SBI_32BIT_API, sbi->ll_flags));
        inode = iget_locked(sb, ino);
        if (inode == NULL) {
                CERROR("%s: failed get simple inode "DFID": rc = -ENOENT\n",
@@ -1590,6 +1619,8 @@ static void ll_update_default_lsm_md(struct inode *inode, struct lustre_md *md)
 {
        struct ll_inode_info *lli = ll_i2info(inode);
 
+       ENTRY;
+
        if (!md->default_lmv) {
                /* clear default lsm */
                if (lli->lli_default_lsm_md) {
@@ -1600,7 +1631,7 @@ static void ll_update_default_lsm_md(struct inode *inode, struct lustre_md *md)
                        }
                        up_write(&lli->lli_lsm_sem);
                }
-               return;
+               RETURN_EXIT;
        }
 
        if (lli->lli_default_lsm_md) {
@@ -1609,7 +1640,7 @@ static void ll_update_default_lsm_md(struct inode *inode, struct lustre_md *md)
                if (lli->lli_default_lsm_md &&
                    lsm_md_eq(lli->lli_default_lsm_md, md->default_lmv)) {
                        up_read(&lli->lli_lsm_sem);
-                       return;
+                       RETURN_EXIT;
                }
                up_read(&lli->lli_lsm_sem);
        }
@@ -1621,6 +1652,7 @@ static void ll_update_default_lsm_md(struct inode *inode, struct lustre_md *md)
        lsm_md_dump(D_INODE, md->default_lmv);
        md->default_lmv = NULL;
        up_write(&lli->lli_lsm_sem);
+       RETURN_EXIT;
 }
 
 static int ll_update_lsm_md(struct inode *inode, struct lustre_md *md)
@@ -1831,7 +1863,8 @@ static int ll_md_setattr(struct dentry *dentry, struct md_op_data *op_data)
                            !S_ISDIR(inode->i_mode)) {
                                ia_valid = op_data->op_attr.ia_valid;
                                op_data->op_attr.ia_valid &= ~TIMES_SET_FLAGS;
-                               rc = simple_setattr(dentry, &op_data->op_attr);
+                               rc = simple_setattr(&init_user_ns, dentry,
+                                                   &op_data->op_attr);
                                op_data->op_attr.ia_valid = ia_valid;
                        }
                } else if (rc != -EPERM && rc != -EACCES && rc != -ETXTBSY) {
@@ -1853,7 +1886,7 @@ static int ll_md_setattr(struct dentry *dentry, struct md_op_data *op_data)
        op_data->op_attr.ia_valid &= ~(TIMES_SET_FLAGS | ATTR_SIZE);
        if (S_ISREG(inode->i_mode))
                inode_lock(inode);
-       rc = simple_setattr(dentry, &op_data->op_attr);
+       rc = simple_setattr(&init_user_ns, dentry, &op_data->op_attr);
        if (S_ISREG(inode->i_mode))
                inode_unlock(inode);
        op_data->op_attr.ia_valid = ia_valid;
@@ -2020,6 +2053,44 @@ putenv:
        RETURN(rc);
 }
 
+/**
+ * Get reference file from volatile file name.
+ * Volatile file name may look like:
+ * <parent>/LUSTRE_VOLATILE_HDR:<mdt_index>:<random>:fd=<fd>
+ * where fd is opened descriptor of reference file.
+ *
+ * \param[in] volatile_name    volatile file name
+ * \param[in] volatile_len     volatile file name length
+ * \param[out] ref_file                pointer to struct file of reference file
+ *
+ * \retval 0           on success
+ * \retval negative    errno on failure
+ */
+int volatile_ref_file(const char *volatile_name, int volatile_len,
+                     struct file **ref_file)
+{
+       char *p, *q, *fd_str;
+       int fd, rc;
+
+       p = strnstr(volatile_name, ":fd=", volatile_len);
+       if (!p || strlen(p + 4) == 0)
+               return -EINVAL;
+
+       q = strchrnul(p + 4, ':');
+       fd_str = kstrndup(p + 4, q - p - 4, GFP_NOFS);
+       if (!fd_str)
+               return -ENOMEM;
+       rc = kstrtouint(fd_str, 10, &fd);
+       kfree(fd_str);
+       if (rc)
+               return -EINVAL;
+
+       *ref_file = fget(fd);
+       if (!(*ref_file))
+               return -EINVAL;
+       return 0;
+}
+
 /* If this inode has objects allocated to it (lsm != NULL), then the OST
  * object(s) determine the file size and mtime.  Otherwise, the MDS will
  * keep these values until such a time that objects are allocated for it.
@@ -2183,6 +2254,55 @@ int ll_setattr_raw(struct dentry *dentry, struct iattr *attr,
                                        if (rc)
                                                GOTO(out, rc);
                                }
+                               /* If encrypted volatile file without the key,
+                                * we need to fetch size from reference file,
+                                * and set it on OST objects. This happens when
+                                * migrating or extending an encrypted file
+                                * without the key.
+                                */
+                               if (filename_is_volatile(dentry->d_name.name,
+                                                        dentry->d_name.len,
+                                                        NULL) &&
+                                   llcrypt_require_key(inode) == -ENOKEY) {
+                                       struct file *ref_file;
+                                       struct inode *ref_inode;
+                                       struct ll_inode_info *ref_lli;
+                                       struct cl_object *ref_obj;
+                                       struct cl_attr ref_attr = { 0 };
+                                       struct lu_env *env;
+                                       __u16 refcheck;
+
+                                       rc = volatile_ref_file(
+                                               dentry->d_name.name,
+                                               dentry->d_name.len,
+                                               &ref_file);
+                                       if (rc)
+                                               GOTO(out, rc);
+
+                                       ref_inode = file_inode(ref_file);
+                                       if (!ref_inode) {
+                                               fput(ref_file);
+                                               GOTO(out, rc = -EINVAL);
+                                       }
+
+                                       env = cl_env_get(&refcheck);
+                                       if (IS_ERR(env))
+                                               GOTO(out, rc = PTR_ERR(env));
+
+                                       ref_lli = ll_i2info(ref_inode);
+                                       ref_obj = ref_lli->lli_clob;
+                                       cl_object_attr_lock(ref_obj);
+                                       rc = cl_object_attr_get(env, ref_obj,
+                                                               &ref_attr);
+                                       cl_object_attr_unlock(ref_obj);
+                                       cl_env_put(env, &refcheck);
+                                       fput(ref_file);
+                                       if (rc)
+                                               GOTO(out, rc);
+
+                                       attr->ia_valid |= ATTR_SIZE;
+                                       attr->ia_size = ref_attr.cat_size;
+                               }
                        }
                        rc = cl_setattr_ost(lli->lli_clob, attr, xvalid, flags);
                }
@@ -2241,10 +2361,11 @@ out:
                                        LPROC_LL_TRUNC : LPROC_LL_SETATTR,
                                   ktime_us_delta(ktime_get(), kstart));
 
-       return rc;
+       RETURN(rc);
 }
 
-int ll_setattr(struct dentry *de, struct iattr *attr)
+int ll_setattr(struct user_namespace *mnt_userns, struct dentry *de,
+              struct iattr *attr)
 {
        int mode = de->d_inode->i_mode;
        enum op_xvalid xvalid = 0;
@@ -2290,7 +2411,7 @@ int ll_statfs_internal(struct ll_sb_info *sbi, struct obd_statfs *osfs,
        ENTRY;
        max_age = ktime_get_seconds() - sbi->ll_statfs_max_age;
 
-       if (sbi->ll_flags & LL_SBI_LAZYSTATFS)
+       if (test_bit(LL_SBI_LAZYSTATFS, sbi->ll_flags))
                flags |= OBD_STATFS_NODELAY;
 
        rc = obd_statfs(NULL, sbi->ll_md_exp, osfs, max_age, flags);
@@ -2458,6 +2579,7 @@ int ll_update_inode(struct inode *inode, struct lustre_md *md)
        struct ll_inode_info *lli = ll_i2info(inode);
        struct mdt_body *body = md->body;
        struct ll_sb_info *sbi = ll_i2sbi(inode);
+       bool api32;
        int rc = 0;
 
        if (body->mbo_valid & OBD_MD_FLEASIZE) {
@@ -2475,8 +2597,8 @@ int ll_update_inode(struct inode *inode, struct lustre_md *md)
        if (body->mbo_valid & OBD_MD_FLACL)
                lli_replace_acl(lli, md);
 
-       inode->i_ino = cl_fid_build_ino(&body->mbo_fid1,
-                                       sbi->ll_flags & LL_SBI_32BIT_API);
+       api32 = test_bit(LL_SBI_32BIT_API, sbi->ll_flags);
+       inode->i_ino = cl_fid_build_ino(&body->mbo_fid1, api32);
        inode->i_generation = cl_fid_build_gen(&body->mbo_fid1);
 
        if (body->mbo_valid & OBD_MD_FLATIME) {
@@ -2523,8 +2645,11 @@ int ll_update_inode(struct inode *inode, struct lustre_md *md)
                inode->i_gid = make_kgid(&init_user_ns, body->mbo_gid);
        if (body->mbo_valid & OBD_MD_FLPROJID)
                lli->lli_projid = body->mbo_projid;
-       if (body->mbo_valid & OBD_MD_FLNLINK)
+       if (body->mbo_valid & OBD_MD_FLNLINK) {
+               spin_lock(&inode->i_lock);
                set_nlink(inode, body->mbo_nlink);
+               spin_unlock(&inode->i_lock);
+       }
        if (body->mbo_valid & OBD_MD_FLRDEV)
                inode->i_rdev = old_decode_dev(body->mbo_rdev);
 
@@ -2543,7 +2668,15 @@ int ll_update_inode(struct inode *inode, struct lustre_md *md)
 
        LASSERT(fid_seq(&lli->lli_fid) != 0);
 
-       lli->lli_attr_valid = body->mbo_valid;
+       /* In case of encrypted file without the key, please do not lose
+        * clear text size stored into lli_lazysize in ll_merge_attr(),
+        * we will need it in ll_prepare_close().
+        */
+       if (lli->lli_attr_valid & OBD_MD_FLLAZYSIZE && lli->lli_lazysize &&
+           llcrypt_require_key(inode) == -ENOKEY)
+               lli->lli_attr_valid = body->mbo_valid | OBD_MD_FLLAZYSIZE;
+       else
+               lli->lli_attr_valid = body->mbo_valid;
        if (body->mbo_valid & OBD_MD_FLSIZE) {
                i_size_write(inode, body->mbo_size);
 
@@ -2586,8 +2719,9 @@ void ll_update_dir_depth(struct inode *dir, struct inode *inode)
                return;
 
        lli = ll_i2info(inode);
-       lli->lli_depth = ll_i2info(dir)->lli_depth + 1;
-       CDEBUG(D_INODE, DFID" depth %hu\n", PFID(&lli->lli_fid), lli->lli_depth);
+       lli->lli_dir_depth = ll_i2info(dir)->lli_dir_depth + 1;
+       CDEBUG(D_INODE, DFID" depth %hu\n",
+              PFID(&lli->lli_fid), lli->lli_dir_depth);
 }
 
 void ll_truncate_inode_pages_final(struct inode *inode)
@@ -2882,7 +3016,7 @@ int ll_remount_fs(struct super_block *sb, int *flags, char *data)
                else
                        sb->s_flags &= ~SB_RDONLY;
 
-               if (sbi->ll_flags & LL_SBI_VERBOSE)
+               if (test_bit(LL_SBI_VERBOSE, sbi->ll_flags))
                        LCONSOLE_WARN("Remounted %s %s\n", profilenm,
                                      read_only ?  "read-only" : "read-write");
        }
@@ -2962,22 +3096,22 @@ int ll_prep_inode(struct inode **inode, struct req_capsule *pill,
                if (rc != 0)
                        GOTO(out, rc);
        } else {
+               bool api32 = test_bit(LL_SBI_32BIT_API, sbi->ll_flags);
+               struct lu_fid *fid1 = &md.body->mbo_fid1;
+
                LASSERT(sb != NULL);
 
                /*
                 * At this point server returns to client's same fid as client
                 * generated for creating. So using ->fid1 is okay here.
                 */
-               if (!fid_is_sane(&md.body->mbo_fid1)) {
+               if (!fid_is_sane(fid1)) {
                        CERROR("%s: Fid is insane "DFID"\n",
-                               sbi->ll_fsname,
-                               PFID(&md.body->mbo_fid1));
+                               sbi->ll_fsname, PFID(fid1));
                        GOTO(out, rc = -EINVAL);
                }
 
-               *inode = ll_iget(sb, cl_fid_build_ino(&md.body->mbo_fid1,
-                                            sbi->ll_flags & LL_SBI_32BIT_API),
-                                &md);
+               *inode = ll_iget(sb, cl_fid_build_ino(fid1, api32), &md);
                if (IS_ERR(*inode)) {
                         lmd_clear_acl(&md);
                         rc = IS_ERR(*inode) ? PTR_ERR(*inode) : -ENOMEM;
@@ -3116,7 +3250,9 @@ struct md_op_data *ll_prep_md_op_data(struct md_op_data *op_data,
                if (namelen != 0)
                        return ERR_PTR(-EINVAL);
        } else {
-               if (namelen > ll_i2sbi(i1)->ll_namelen)
+               if ((!IS_ENCRYPTED(i1) ||
+                    (opc != LUSTRE_OPC_LOOKUP && opc != LUSTRE_OPC_CREATE)) &&
+                   namelen > ll_i2sbi(i1)->ll_namelen)
                        return ERR_PTR(-ENAMETOOLONG);
 
                /* "/" is not valid name, but it's allowed */
@@ -3158,15 +3294,17 @@ struct md_op_data *ll_prep_md_op_data(struct md_op_data *op_data,
                fid_zero(&op_data->op_fid2);
        }
 
-       if (ll_i2sbi(i1)->ll_flags & LL_SBI_64BIT_HASH)
+       if (test_bit(LL_SBI_64BIT_HASH, ll_i2sbi(i1)->ll_flags))
                op_data->op_cli_flags |= CLI_HASH64;
 
        if (ll_need_32bit_api(ll_i2sbi(i1)))
                op_data->op_cli_flags |= CLI_API32;
 
-       if (opc == LUSTRE_OPC_LOOKUP || opc == LUSTRE_OPC_CREATE) {
+       if ((i2 && is_root_inode(i2)) ||
+           opc == LUSTRE_OPC_LOOKUP || opc == LUSTRE_OPC_CREATE) {
                /* In case of lookup, ll_setup_filename() has already been
                 * called in ll_lookup_it(), so just take provided name.
+                * Also take provided name if we are dealing with root inode.
                 */
                fname.disk_name.name = (unsigned char *)name;
                fname.disk_name.len = namelen;
@@ -3203,11 +3341,10 @@ struct md_op_data *ll_prep_md_op_data(struct md_op_data *op_data,
                        op_data->op_flags |= MF_OPNAME_KMALLOCED;
        }
 
-       /* In fact LUSTRE_OPC_LOOKUP, LUSTRE_OPC_OPEN, LUSTRE_OPC_MIGR
+       /* In fact LUSTRE_OPC_LOOKUP, LUSTRE_OPC_OPEN
         * are LUSTRE_OPC_ANY
         */
-       if (opc == LUSTRE_OPC_LOOKUP || opc == LUSTRE_OPC_OPEN ||
-           opc == LUSTRE_OPC_MIGR)
+       if (opc == LUSTRE_OPC_LOOKUP || opc == LUSTRE_OPC_OPEN)
                op_data->op_code = LUSTRE_OPC_ANY;
        else
                op_data->op_code = opc;
@@ -3245,47 +3382,40 @@ void ll_finish_md_op_data(struct md_op_data *op_data)
 int ll_show_options(struct seq_file *seq, struct dentry *dentry)
 {
        struct ll_sb_info *sbi;
+       int i;
 
        LASSERT(seq && dentry);
        sbi = ll_s2sbi(dentry->d_sb);
 
-       if (sbi->ll_flags & LL_SBI_NOLCK)
-               seq_puts(seq, ",nolock");
+       if (test_bit(LL_SBI_NOLCK, sbi->ll_flags))
+               seq_puts(seq, "nolock");
 
-       /* "flock" is the default since 2.13, but it wasn't for many years,
-        * so it is still useful to print this to show it is enabled.
-        * Start to print "noflock" so it is now clear when flock is disabled.
-        */
-       if (sbi->ll_flags & LL_SBI_FLOCK)
-               seq_puts(seq, ",flock");
-       else if (sbi->ll_flags & LL_SBI_LOCALFLOCK)
-               seq_puts(seq, ",localflock");
-       else
-               seq_puts(seq, ",noflock");
-
-       if (sbi->ll_flags & LL_SBI_USER_XATTR)
-               seq_puts(seq, ",user_xattr");
-
-       if (sbi->ll_flags & LL_SBI_LAZYSTATFS)
-               seq_puts(seq, ",lazystatfs");
-
-       if (sbi->ll_flags & LL_SBI_USER_FID2PATH)
-               seq_puts(seq, ",user_fid2path");
-
-       if (sbi->ll_flags & LL_SBI_ALWAYS_PING)
-               seq_puts(seq, ",always_ping");
-
-       if (ll_sbi_has_test_dummy_encryption(sbi))
-               seq_puts(seq, ",test_dummy_encryption");
-
-       if (ll_sbi_has_encrypt(sbi))
-               seq_puts(seq, ",encrypt");
-       else
-               seq_puts(seq, ",noencrypt");
+       for (i = 1; ll_sbi_flags_name[i].token != LL_SBI_NUM_MOUNT_OPT; i++) {
+               /* match_table in some cases has patterns for both enabled and
+                * disabled cases. Ignore 'no'xxx versions if bit is set.
+                */
+               if (test_bit(ll_sbi_flags_name[i].token, sbi->ll_flags) &&
+                   strncmp(ll_sbi_flags_name[i].pattern, "no", 2)) {
+                       if (ll_sbi_flags_name[i].token ==
+                           LL_SBI_FOREIGN_SYMLINK) {
+                               seq_show_option(seq, "foreign_symlink",
+                                               sbi->ll_foreign_symlink_prefix);
+                       } else {
+                               seq_printf(seq, ",%s",
+                                          ll_sbi_flags_name[i].pattern);
+                       }
 
-       if (sbi->ll_flags & LL_SBI_FOREIGN_SYMLINK) {
-               seq_puts(seq, ",foreign_symlink=");
-               seq_puts(seq, sbi->ll_foreign_symlink_prefix);
+                       /* You can have either localflock or flock but not
+                        * both. If localflock is set don't print flock or
+                        * noflock.
+                        */
+                       if (ll_sbi_flags_name[i].token == LL_SBI_LOCALFLOCK)
+                               i += 2;
+               } else if (!test_bit(ll_sbi_flags_name[i].token, sbi->ll_flags) &&
+                          !strncmp(ll_sbi_flags_name[i].pattern, "no", 2)) {
+                       seq_printf(seq, ",%s",
+                                  ll_sbi_flags_name[i].pattern);
+               }
        }
 
        RETURN(0);
@@ -3400,7 +3530,7 @@ void ll_compute_rootsquash_state(struct ll_sb_info *sbi)
        /* Update norootsquash flag */
        spin_lock(&squash->rsi_lock);
        if (list_empty(&squash->rsi_nosquash_nids))
-               sbi->ll_flags &= ~LL_SBI_NOROOTSQUASH;
+               clear_bit(LL_SBI_NOROOTSQUASH, sbi->ll_flags);
        else {
                /* Do not apply root squash as soon as one of our NIDs is
                 * in the nosquash_nids list */
@@ -3415,9 +3545,9 @@ void ll_compute_rootsquash_state(struct ll_sb_info *sbi)
                        }
                }
                if (matched)
-                       sbi->ll_flags |= LL_SBI_NOROOTSQUASH;
+                       set_bit(LL_SBI_NOROOTSQUASH, sbi->ll_flags);
                else
-                       sbi->ll_flags &= ~LL_SBI_NOROOTSQUASH;
+                       clear_bit(LL_SBI_NOROOTSQUASH, sbi->ll_flags);
        }
        spin_unlock(&squash->rsi_lock);
 }
@@ -3491,7 +3621,7 @@ int ll_getparent(struct file *file, struct getparent __user *arg)
        ENTRY;
 
        if (!capable(CAP_DAC_READ_SEARCH) &&
-           !(ll_i2sbi(inode)->ll_flags & LL_SBI_USER_FID2PATH))
+           !test_bit(LL_SBI_USER_FID2PATH, ll_i2sbi(inode)->ll_flags))
                RETURN(-EPERM);
 
        if (get_user(name_size, &arg->gp_name_size))