#include "lfsck_internal.h"
-#define LFSCK_NAMESPACE_MAGIC 0xA0629D03
+#define LFSCK_NAMESPACE_MAGIC_V1 0xA0629D03
+#define LFSCK_NAMESPACE_MAGIC_V2 0xA0621A0B
+
+/* For Lustre-2.x (x <= 6), the namespace LFSCK used LFSCK_NAMESPACE_MAGIC_V1
+ * as the trace file magic. When downgrade to such old release, the old LFSCK
+ * will not recognize the new LFSCK_NAMESPACE_MAGIC_V2 in the new trace file,
+ * then it will reset the whole LFSCK, and will not cause start failure. The
+ * similar case will happen when upgrade from such old release. */
+#define LFSCK_NAMESPACE_MAGIC LFSCK_NAMESPACE_MAGIC_V2
enum lfsck_nameentry_check {
LFSCK_NAMEENTRY_DEAD = 1, /* The object has been unlinked. */
LFSCK_NAMEENTRY_RECREATED = 3, /* The entry has been recreated. */
};
-static const char lfsck_namespace_name[] = "lfsck_namespace";
-
static struct lfsck_namespace_req *
lfsck_namespace_assistant_req_init(struct lfsck_instance *lfsck,
struct lu_dirent *ent, __u16 type)
return rc;
}
+static struct dt_object *
+lfsck_namespace_load_one_trace_file(const struct lu_env *env,
+ struct lfsck_component *com,
+ struct dt_object *parent,
+ const char *name,
+ const struct dt_index_features *ft,
+ bool reset)
+{
+ struct lfsck_instance *lfsck = com->lc_lfsck;
+ struct dt_object *obj;
+ int rc;
+
+ if (reset) {
+ rc = local_object_unlink(env, lfsck->li_bottom, parent, name);
+ if (rc != 0 && rc != -ENOENT)
+ return ERR_PTR(rc);
+ }
+
+ if (ft != NULL)
+ obj = local_index_find_or_create(env, lfsck->li_los, parent,
+ name, S_IFREG | S_IRUGO | S_IWUSR, ft);
+ else
+ obj = local_file_find_or_create(env, lfsck->li_los, parent,
+ name, S_IFREG | S_IRUGO | S_IWUSR);
+
+ return obj;
+}
+
+static int lfsck_namespace_load_sub_trace_files(const struct lu_env *env,
+ struct lfsck_component *com,
+ bool reset)
+{
+ char *name = lfsck_env_info(env)->lti_key;
+ struct lfsck_sub_trace_obj *lsto;
+ struct dt_object *obj;
+ int rc;
+ int i;
+
+ for (i = 0, lsto = &com->lc_sub_trace_objs[0];
+ i < LFSCK_STF_COUNT; i++, lsto++) {
+ snprintf(name, NAME_MAX, "%s_%02d", LFSCK_NAMESPACE, i);
+ if (lsto->lsto_obj != NULL) {
+ if (!reset)
+ continue;
+
+ lu_object_put(env, &lsto->lsto_obj->do_lu);
+ lsto->lsto_obj = NULL;
+ }
+
+ obj = lfsck_namespace_load_one_trace_file(env, com,
+ com->lc_lfsck->li_lfsck_dir,
+ name, &dt_lfsck_features, reset);
+ if (IS_ERR(obj))
+ return PTR_ERR(obj);
+
+ lsto->lsto_obj = obj;
+ rc = obj->do_ops->do_index_try(env, obj, &dt_lfsck_features);
+ if (rc != 0)
+ return rc;
+ }
+
+ return 0;
+}
+
static int lfsck_namespace_init(const struct lu_env *env,
struct lfsck_component *com)
{
down_write(&com->lc_sem);
rc = lfsck_namespace_store(env, com, true);
up_write(&com->lc_sem);
+ if (rc == 0)
+ rc = lfsck_namespace_load_sub_trace_files(env, com, true);
+
return rc;
}
const __u8 flags, bool add)
{
struct lfsck_instance *lfsck = com->lc_lfsck;
- struct dt_object *obj = com->lc_obj;
+ struct dt_object *obj;
struct lu_fid *key = &lfsck_env_info(env)->lti_fid3;
struct dt_device *dev = lfsck->li_bottom;
struct thandle *th = NULL;
+ int idx;
int rc = 0;
__u8 old = 0;
__u8 new = 0;
LASSERT(flags != 0);
- down_write(&com->lc_sem);
+ if (unlikely(!fid_is_sane(fid)))
+ RETURN(0);
+
+ idx = lfsck_sub_trace_file_fid2idx(fid);
+ obj = com->lc_sub_trace_objs[idx].lsto_obj;
+ mutex_lock(&com->lc_sub_trace_objs[idx].lsto_mutex);
fid_cpu_to_be(key, fid);
rc = dt_lookup(env, obj, (struct dt_rec *)&old,
(const struct dt_key *)key, BYPASS_CAPA);
(__u32)flags, (__u32)old, (__u32)new, rc);
unlock:
- up_write(&com->lc_sem);
+ mutex_unlock(&com->lc_sub_trace_objs[idx].lsto_mutex);
return rc;
}
struct lfsck_thread_info *info = lfsck_env_info(env);
struct lu_name *cname = &info->lti_name;
struct dt_insert_rec *rec = &info->lti_dt_rec;
- struct lu_fid *tfid = &info->lti_fid5;
struct lu_attr *la = &info->lti_la3;
const struct lu_fid *cfid = lfsck_dto2fid(orphan);
const struct lu_fid *pfid;
+ struct lu_fid tfid;
struct lfsck_instance *lfsck = com->lc_lfsck;
struct dt_device *dev = lfsck->li_bottom;
struct dt_object *parent;
ENTRY;
cname->ln_name = NULL;
- /* Create .lustre/lost+found/MDTxxxx when needed. */
- if (unlikely(lfsck->li_lpf_obj == NULL)) {
- rc = lfsck_create_lpf(env, lfsck);
- if (rc != 0)
- GOTO(log, rc);
- }
+ if (unlikely(lfsck->li_lpf_obj == NULL))
+ GOTO(log, rc = -ENXIO);
parent = lfsck->li_lpf_obj;
pfid = lfsck_dto2fid(parent);
do {
namelen = snprintf(info->lti_key, NAME_MAX, DFID"%s-%s-%d",
PFID(cfid), infix, type, idx++);
- rc = dt_lookup(env, parent, (struct dt_rec *)tfid,
+ rc = dt_lookup(env, parent, (struct dt_rec *)&tfid,
(const struct dt_key *)info->lti_key,
BYPASS_CAPA);
if (rc != 0 && rc != -ENOENT)
GOTO(log, rc);
- if (unlikely(rc == 0 && lu_fid_eq(cfid, tfid)))
+ if (unlikely(rc == 0 && lu_fid_eq(cfid, &tfid)))
exist = true;
} while (rc == 0 && !exist);
}
/**
- * Create the specified orphan MDT-object on remote MDT.
- *
- * The LFSCK instance on this MDT will send LFSCK RPC to remote MDT to
- * ask the remote LFSCK instance to create the specified orphan object
- * under .lustre/lost+found/MDTxxxx/ directory with the name:
- * ${FID}-P-${conflict_version}.
- *
- * \param[in] env pointer to the thread context
- * \param[in] com pointer to the lfsck component
- * \param[in] orphan pointer to the orphan MDT-object
- * \param[in] type the orphan's type to be created
- *
- * type "P": The orphan object to be created was a parent directory
- * of some MDT-object which linkEA shows that the @orphan
- * object is missing.
- *
- * \see lfsck_layout_recreate_parent() for more types.
- *
- * \param[in] lmv pointer to master LMV EA that will be set to the orphan
- *
- * \retval positive number for repaired cases
- * \retval 0 if needs to repair nothing
- * \retval negative error number on failure
- */
-static int lfsck_namespace_create_orphan_remote(const struct lu_env *env,
- struct lfsck_component *com,
- struct dt_object *orphan,
- __u32 type,
- struct lmv_mds_md_v1 *lmv)
-{
- struct lfsck_thread_info *info = lfsck_env_info(env);
- struct lfsck_request *lr = &info->lti_lr;
- struct lu_seq_range *range = &info->lti_range;
- const struct lu_fid *fid = lfsck_dto2fid(orphan);
- struct lfsck_namespace *ns = com->lc_file_ram;
- struct lfsck_instance *lfsck = com->lc_lfsck;
- struct seq_server_site *ss =
- lu_site2seq(lfsck->li_bottom->dd_lu_dev.ld_site);
- struct lfsck_tgt_desc *ltd = NULL;
- struct ptlrpc_request *req = NULL;
- int rc;
- ENTRY;
-
- if (lfsck->li_bookmark_ram.lb_param & LPF_DRYRUN)
- GOTO(out, rc = 1);
-
- fld_range_set_mdt(range);
- rc = fld_server_lookup(env, ss->ss_server_fld, fid_seq(fid), range);
- if (rc != 0)
- GOTO(out, rc);
-
- ltd = lfsck_tgt_get(&lfsck->li_mdt_descs, range->lsr_index);
- if (ltd == NULL) {
- ns->ln_flags |= LF_INCOMPLETE;
-
- GOTO(out, rc = -ENODEV);
- }
-
- req = ptlrpc_request_alloc(class_exp2cliimp(ltd->ltd_exp),
- &RQF_LFSCK_NOTIFY);
- if (req == NULL)
- GOTO(out, rc = -ENOMEM);
-
- rc = ptlrpc_request_pack(req, LUSTRE_OBD_VERSION, LFSCK_NOTIFY);
- if (rc != 0) {
- ptlrpc_request_free(req);
-
- GOTO(out, rc);
- }
-
- lr = req_capsule_client_get(&req->rq_pill, &RMF_LFSCK_REQUEST);
- memset(lr, 0, sizeof(*lr));
- lr->lr_event = LE_CREATE_ORPHAN;
- lr->lr_index = lfsck_dev_idx(lfsck->li_bottom);
- lr->lr_active = LFSCK_TYPE_NAMESPACE;
- lr->lr_fid = *fid;
- lr->lr_type = type;
- if (lmv != NULL) {
- lr->lr_hash_type = lmv->lmv_hash_type;
- lr->lr_stripe_count = lmv->lmv_stripe_count;
- lr->lr_layout_version = lmv->lmv_layout_version;
- memcpy(lr->lr_pool_name, lmv->lmv_pool_name,
- sizeof(lr->lr_pool_name));
- }
-
- ptlrpc_request_set_replen(req);
- rc = ptlrpc_queue_wait(req);
- ptlrpc_req_finished(req);
-
- if (rc == 0) {
- orphan->do_lu.lo_header->loh_attr |= LOHA_EXISTS;
- rc = 1;
- } else if (rc == -EEXIST) {
- orphan->do_lu.lo_header->loh_attr |= LOHA_EXISTS;
- rc = 0;
- }
-
- GOTO(out, rc);
-
-out:
- CDEBUG(D_LFSCK, "%s: namespace LFSCK create object "
- DFID" on the MDT %x remotely: rc = %d\n",
- lfsck_lfsck2name(lfsck), PFID(fid),
- ltd != NULL ? ltd->ltd_index : -1, rc);
-
- if (ltd != NULL)
- lfsck_tgt_put(ltd);
-
- return rc;
-}
-
-/**
- * Create the specified orphan MDT-object locally.
+ * Create the specified orphan directory.
*
* For the case that the parent MDT-object stored in some MDT-object's
* linkEA entry is lost, the LFSCK will re-create the parent object as
* \param[in] env pointer to the thread context
* \param[in] com pointer to the lfsck component
* \param[in] orphan pointer to the orphan MDT-object to be created
- * \param[in] type the orphan's type to be created
- *
- * type "P": The orphan object to be created was a parent directory
- * of some MDT-object which linkEA shows that the @orphan
- * object is missing.
- *
- * \see lfsck_layout_recreate_parent() for more types.
- *
* \param[in] lmv pointer to master LMV EA that will be set to the orphan
*
* \retval positive number for repaired cases
* \retval negative error number on failure
*/
-static int lfsck_namespace_create_orphan_local(const struct lu_env *env,
- struct lfsck_component *com,
- struct dt_object *orphan,
- __u32 type,
- struct lmv_mds_md_v1 *lmv)
+static int lfsck_namespace_create_orphan_dir(const struct lu_env *env,
+ struct lfsck_component *com,
+ struct dt_object *orphan,
+ struct lmv_mds_md_v1 *lmv)
{
struct lfsck_thread_info *info = lfsck_env_info(env);
struct lu_attr *la = &info->lti_la;
struct dt_object_format *dof = &info->lti_dof;
struct lu_name *cname = &info->lti_name2;
struct dt_insert_rec *rec = &info->lti_dt_rec;
- struct lu_fid *tfid = &info->lti_fid;
struct lmv_mds_md_v1 *lmv2 = &info->lti_lmv2;
const struct lu_fid *cfid = lfsck_dto2fid(orphan);
- const struct lu_fid *pfid;
+ struct lu_fid tfid;
struct lfsck_instance *lfsck = com->lc_lfsck;
- struct dt_device *dev = lfsck->li_bottom;
+ struct lfsck_namespace *ns = com->lc_file_ram;
+ struct dt_device *dev;
struct dt_object *parent = NULL;
struct dt_object *child = NULL;
struct thandle *th = NULL;
ENTRY;
LASSERT(!dt_object_exists(orphan));
- LASSERT(!dt_object_remote(orphan));
-
- /* @orphan maybe not attached to lfsck->li_bottom */
- child = lfsck_object_find_by_dev(env, dev, cfid);
- if (IS_ERR(child))
- GOTO(log, rc = PTR_ERR(child));
cname->ln_name = NULL;
if (lfsck->li_bookmark_ram.lb_param & LPF_DRYRUN)
GOTO(log, rc = 1);
- /* Create .lustre/lost+found/MDTxxxx when needed. */
- if (unlikely(lfsck->li_lpf_obj == NULL)) {
- rc = lfsck_create_lpf(env, lfsck);
+ if (dt_object_remote(orphan)) {
+ LASSERT(lfsck->li_lpf_root_obj != NULL);
+
+ idx = lfsck_find_mdt_idx_by_fid(env, lfsck, cfid);
+ if (idx < 0)
+ GOTO(log, rc = idx);
+
+ snprintf(name, 8, "MDT%04x", idx);
+ rc = dt_lookup(env, lfsck->li_lpf_root_obj,
+ (struct dt_rec *)&tfid,
+ (const struct dt_key *)name, BYPASS_CAPA);
if (rc != 0)
- GOTO(log, rc);
+ GOTO(log, rc = (rc == -ENOENT ? -ENXIO : rc));
+
+ parent = lfsck_object_find_bottom(env, lfsck, &tfid);
+ if (IS_ERR(parent))
+ GOTO(log, rc = PTR_ERR(parent));
+
+ if (unlikely(!dt_try_as_dir(env, parent)))
+ GOTO(log, rc = -ENOTDIR);
+ } else {
+ if (unlikely(lfsck->li_lpf_obj == NULL))
+ GOTO(log, rc = -ENXIO);
+
+ parent = lfsck->li_lpf_obj;
}
- parent = lfsck->li_lpf_obj;
- pfid = lfsck_dto2fid(parent);
+ dev = lfsck_find_dev_by_fid(env, lfsck, cfid);
+ if (IS_ERR(dev))
+ GOTO(log, rc = PTR_ERR(dev));
+
+ child = lfsck_object_find_by_dev(env, dev, cfid);
+ if (IS_ERR(child))
+ GOTO(log, rc = PTR_ERR(child));
/* Hold update lock on the parent to prevent others to access. */
rc = lfsck_ibits_lock(env, lfsck, parent, &lh,
if (rc != 0)
GOTO(log, rc);
+ idx = 0;
do {
namelen = snprintf(name, 31, DFID"-P-%d",
PFID(cfid), idx++);
- rc = dt_lookup(env, parent, (struct dt_rec *)tfid,
+ rc = dt_lookup(env, parent, (struct dt_rec *)&tfid,
(const struct dt_key *)name, BYPASS_CAPA);
if (rc != 0 && rc != -ENOENT)
GOTO(unlock1, rc);
cname->ln_namelen = namelen;
memset(la, 0, sizeof(*la));
- la->la_mode = type | (S_ISDIR(type) ? 0700 : 0600);
+ la->la_mode = S_IFDIR | 0700;
la->la_valid = LA_TYPE | LA_MODE | LA_UID | LA_GID |
LA_ATIME | LA_MTIME | LA_CTIME;
la->la_mode & S_IFMT);
memset(dof, 0, sizeof(*dof));
- dof->dof_type = dt_mode_to_dft(type);
+ dof->dof_type = dt_mode_to_dft(S_IFDIR);
rc = linkea_data_new(&ldata, &info->lti_linkea_buf2);
if (rc != 0)
GOTO(unlock1, rc);
- rc = linkea_add_buf(&ldata, cname, pfid);
+ rc = linkea_add_buf(&ldata, cname, lfsck_dto2fid(parent));
if (rc != 0)
GOTO(unlock1, rc);
if (IS_ERR(th))
GOTO(unlock1, rc = PTR_ERR(th));
+ /* Sync the remote transaction to guarantee that the subsequent
+ * lock against the @orphan can find the @orphan in time. */
+ if (dt_object_remote(orphan))
+ th->th_sync = 1;
+
rc = dt_declare_create(env, child, la, hint, dof, th);
- if (rc == 0 && S_ISDIR(type))
+ if (rc != 0)
+ GOTO(stop, rc);
+
+ if (unlikely(!dt_try_as_dir(env, child)))
+ GOTO(stop, rc = -ENOTDIR);
+
+ rec->rec_type = S_IFDIR;
+ rec->rec_fid = cfid;
+ rc = dt_declare_insert(env, child, (const struct dt_rec *)rec,
+ (const struct dt_key *)dot, th);
+ if (rc != 0)
+ GOTO(stop, rc);
+
+ rec->rec_fid = lfsck_dto2fid(parent);
+ rc = dt_declare_insert(env, child, (const struct dt_rec *)rec,
+ (const struct dt_key *)dotdot, th);
+ if (rc == 0)
rc = dt_declare_ref_add(env, child, th);
if (rc != 0)
GOTO(stop, rc);
+ rc = dt_declare_ref_add(env, child, th);
+ if (rc != 0)
+ GOTO(stop, rc);
+
if (lmv != NULL) {
lmv->lmv_magic = LMV_MAGIC;
lmv->lmv_master_mdt_index = lfsck_dev_idx(dev);
if (rc != 0)
GOTO(stop, rc);
- rec->rec_type = type;
rec->rec_fid = cfid;
rc = dt_declare_insert(env, parent, (const struct dt_rec *)rec,
(const struct dt_key *)name, th);
- if (rc == 0 && S_ISDIR(type))
+ if (rc == 0)
rc = dt_declare_ref_add(env, parent, th);
if (rc != 0)
if (rc != 0)
GOTO(unlock2, rc);
- if (S_ISDIR(type)) {
- if (unlikely(!dt_try_as_dir(env, child)))
- GOTO(unlock2, rc = -ENOTDIR);
-
- rec->rec_type = S_IFDIR;
- rec->rec_fid = cfid;
- rc = dt_insert(env, child, (const struct dt_rec *)rec,
- (const struct dt_key *)dot, th, BYPASS_CAPA, 1);
- if (rc != 0)
- GOTO(unlock2, rc);
+ rec->rec_fid = cfid;
+ rc = dt_insert(env, child, (const struct dt_rec *)rec,
+ (const struct dt_key *)dot, th, BYPASS_CAPA, 1);
+ if (rc != 0)
+ GOTO(unlock2, rc);
- rec->rec_fid = pfid;
- rc = dt_insert(env, child, (const struct dt_rec *)rec,
- (const struct dt_key *)dotdot, th,
- BYPASS_CAPA, 1);
- if (rc != 0)
- GOTO(unlock2, rc);
+ rec->rec_fid = lfsck_dto2fid(parent);
+ rc = dt_insert(env, child, (const struct dt_rec *)rec,
+ (const struct dt_key *)dotdot, th,
+ BYPASS_CAPA, 1);
+ if (rc != 0)
+ GOTO(unlock2, rc);
- rc = dt_ref_add(env, child, th);
- if (rc != 0)
- GOTO(unlock2, rc);
- }
+ rc = dt_ref_add(env, child, th);
+ if (rc != 0)
+ GOTO(unlock2, rc);
if (lmv != NULL) {
rc = dt_xattr_set(env, child, &lmv_buf, XATTR_NAME_LMV, 0,
if (rc != 0)
GOTO(stop, rc);
- rec->rec_type = type;
rec->rec_fid = cfid;
rc = dt_insert(env, parent, (const struct dt_rec *)rec,
(const struct dt_key *)name, th, BYPASS_CAPA, 1);
- if (rc == 0 && S_ISDIR(type)) {
+ if (rc == 0) {
dt_write_lock(env, parent, 0);
rc = dt_ref_add(env, parent, th);
dt_write_unlock(env, parent);
lfsck_ibits_unlock(&lh, LCK_EX);
log:
- CDEBUG(D_LFSCK, "%s: namespace LFSCK create orphan locally for "
- "the object "DFID", name = %s, type %o: rc = %d\n",
+ CDEBUG(D_LFSCK, "%s: namespace LFSCK create orphan dir for "
+ "the object "DFID", name = %s: rc = %d\n",
lfsck_lfsck2name(lfsck), PFID(cfid),
- cname->ln_name != NULL ? cname->ln_name : "<NULL>", type, rc);
+ cname->ln_name != NULL ? cname->ln_name : "<NULL>", rc);
if (child != NULL && !IS_ERR(child))
lfsck_object_put(env, child);
- return rc;
-}
-
-/**
- * Create the specified orphan MDT-object.
- *
- * For the case that the parent MDT-object stored in some MDT-object's
- * linkEA entry is lost, the LFSCK will re-create the parent object as
- * an orphan and insert it into .lustre/lost+found/MDTxxxx/ directory
- * with the name: ${FID}-P-${conflict_version}.
- *
- * \param[in] env pointer to the thread context
- * \param[in] com pointer to the lfsck component
- * \param[in] orphan pointer to the orphan MDT-object
- *
- * type "P": The orphan object to be created was a parent directory
- * of some MDT-object which linkEA shows that the @orphan
- * object is missing.
- *
- * \see lfsck_layout_recreate_parent() for more types.
- *
- * \param[in] lmv pointer to master LMV EA that will be set to the orphan
- *
- * \retval positive number for repaired cases
- * \retval 0 if needs to repair nothing
- * \retval negative error number on failure
- */
-static int lfsck_namespace_create_orphan(const struct lu_env *env,
- struct lfsck_component *com,
- struct dt_object *orphan,
- struct lmv_mds_md_v1 *lmv)
-{
- struct lfsck_namespace *ns = com->lc_file_ram;
- int rc;
-
- if (dt_object_remote(orphan))
- rc = lfsck_namespace_create_orphan_remote(env, com, orphan,
- S_IFDIR, lmv);
- else
- rc = lfsck_namespace_create_orphan_local(env, com, orphan,
- S_IFDIR, lmv);
+ if (parent != NULL && !IS_ERR(parent) && parent != lfsck->li_lpf_obj)
+ lfsck_object_put(env, parent);
if (rc != 0)
ns->ln_flags |= LF_INCONSISTENT;
const struct lu_name *cname)
{
struct lfsck_thread_info *info = lfsck_env_info(env);
- struct lu_fid *tfid = &info->lti_fid5;
struct lu_attr *la = &info->lti_la;
struct dt_insert_rec *rec = &info->lti_dt_rec;
+ struct lu_fid tfid;
struct lfsck_instance *lfsck = com->lc_lfsck;
struct dt_device *dev = lfsck->li_next;
const char *name = cname->ln_name;
goto replace;
}
- rc = dt_lookup(env, parent, (struct dt_rec *)tfid,
+ rc = dt_lookup(env, parent, (struct dt_rec *)&tfid,
(const struct dt_key *)name, BYPASS_CAPA);
if (rc == -ENOENT) {
exist = false;
GOTO(log, rc);
/* Someone changed the name entry, cannot replace it. */
- if (!lu_fid_eq(cfid, tfid))
+ if (!lu_fid_eq(cfid, &tfid))
GOTO(log, rc = 0);
/* lock the object to be destroyed. */
const char *name, const char *name2,
__u16 type, bool update, bool dec)
{
- struct lfsck_thread_info *info = lfsck_env_info(env);
- struct dt_insert_rec *rec = &info->lti_dt_rec;
- const struct lu_fid *cfid = lfsck_dto2fid(child);
- struct lu_fid *tfid = &info->lti_fid5;
- struct lfsck_instance *lfsck = com->lc_lfsck;
- struct dt_device *dev = lfsck->li_next;
- struct thandle *th = NULL;
- struct lustre_handle lh = { 0 };
- int rc = 0;
+ struct dt_insert_rec *rec = &lfsck_env_info(env)->lti_dt_rec;
+ const struct lu_fid *cfid = lfsck_dto2fid(child);
+ struct lu_fid tfid;
+ struct lfsck_instance *lfsck = com->lc_lfsck;
+ struct dt_device *dev = lfsck->li_next;
+ struct thandle *th = NULL;
+ struct lustre_handle lh = { 0 };
+ int rc = 0;
ENTRY;
if (unlikely(!dt_try_as_dir(env, parent)))
GOTO(stop, rc);
dt_write_lock(env, parent, 0);
- rc = dt_lookup(env, parent, (struct dt_rec *)tfid,
+ rc = dt_lookup(env, parent, (struct dt_rec *)&tfid,
(const struct dt_key *)name, BYPASS_CAPA);
/* Someone has removed the bad name entry by race. */
if (rc == -ENOENT)
/* Someone has removed the bad name entry and reused it for other
* object by race. */
- if (!lu_fid_eq(tfid, cfid))
+ if (!lu_fid_eq(&tfid, cfid))
GOTO(unlock2, rc = 0);
if (lfsck->li_bookmark_ram.lb_param & LPF_DRYRUN)
struct lfsck_thread_info *info = lfsck_env_info(env);
struct lu_name *cname = &info->lti_name;
const struct lu_fid *cfid = lfsck_dto2fid(child);
- struct lu_fid *tfid = &info->lti_fid3;
+ struct lu_fid tfid;
struct lfsck_namespace *ns = com->lc_file_ram;
struct lfsck_instance *lfsck = com->lc_lfsck;
struct dt_object *parent = NULL;
int rc = 0;
ENTRY;
- lfsck_namespace_unpack_linkea_entry(ldata, cname, tfid, info->lti_key);
+ lfsck_namespace_unpack_linkea_entry(ldata, cname, &tfid, info->lti_key);
/* The unique linkEA entry with bad parent will be handled as orphan. */
- if (!fid_is_sane(tfid)) {
+ if (!fid_is_sane(&tfid)) {
if (!lustre_handle_is_used(lh) && retry != NULL)
*retry = true;
else
GOTO(out, rc);
}
- parent = lfsck_object_find_bottom(env, lfsck, tfid);
+ parent = lfsck_object_find_bottom(env, lfsck, &tfid);
if (IS_ERR(parent))
GOTO(out, rc = PTR_ERR(parent));
/* It is an invalid name entry, we
* cannot trust the parent also. */
rc = lfsck_namespace_shrink_linkea(env, com, child,
- ldata, cname, tfid, true);
+ ldata, cname, &tfid, true);
if (rc < 0)
GOTO(out, rc);
}
/* Create the lost parent as an orphan. */
- rc = lfsck_namespace_create_orphan(env, com, parent, lmv);
+ rc = lfsck_namespace_create_orphan_dir(env, com, parent, lmv);
if (rc >= 0) {
/* Add the missing name entry to the parent. */
rc = lfsck_namespace_insert_normal(env, com, parent,
* current system to be consistent. */
rc = lfsck_namespace_shrink_linkea(env,
com, child, ldata,
- cname, tfid, true);
+ cname, &tfid, true);
if (rc >= 0) {
snprintf(info->lti_tmpbuf,
sizeof(info->lti_tmpbuf),
GOTO(out, rc);
}
- rc = dt_lookup(env, parent, (struct dt_rec *)tfid,
+ rc = dt_lookup(env, parent, (struct dt_rec *)&tfid,
(const struct dt_key *)cname->ln_name, BYPASS_CAPA);
if (rc == -ENOENT) {
/* If the LFSCK is marked as LF_INCOMPLETE, then means some MDT
/* It is an invalid name entry, drop it. */
if (unlikely(rc > 0)) {
rc = lfsck_namespace_shrink_linkea(env, com, child,
- ldata, cname, tfid, true);
+ ldata, cname, &tfid, true);
if (rc >= 0) {
snprintf(info->lti_tmpbuf,
sizeof(info->lti_tmpbuf),
* internal status of create operation. Under such
* case, nothing to be done. */
rc = lfsck_namespace_shrink_linkea_cond(env, com,
- parent, child, ldata, cname, tfid);
+ parent, child, ldata, cname, &tfid);
if (rc >= 0) {
snprintf(info->lti_tmpbuf,
sizeof(info->lti_tmpbuf),
if (rc != 0)
GOTO(out, rc);
- if (!lu_fid_eq(tfid, cfid)) {
+ if (!lu_fid_eq(&tfid, cfid)) {
if (!lustre_handle_is_used(lh) && retry != NULL) {
*retry = true;
* may be created by the LFSCK for repairing dangling
* name entry. Try to replace it. */
rc = lfsck_namespace_replace_cond(env, com, parent, child,
- tfid, cname);
+ &tfid, cname);
if (rc == 0)
rc = lfsck_namespace_dsd_orphan(env, com, child,
pfid, lh, type);
struct lfsck_thread_info *info = lfsck_env_info(env);
struct lu_name *cname = &info->lti_name;
const struct lu_fid *cfid = lfsck_dto2fid(child);
- struct lu_fid *tfid = &info->lti_fid3;
- struct lu_fid *pfid2 = &info->lti_fid4;
+ struct lu_fid *pfid2 = &info->lti_fid3;
+ struct lu_fid tfid;
struct lfsck_namespace *ns = com->lc_file_ram;
struct lfsck_instance *lfsck = com->lc_lfsck;
struct lfsck_bookmark *bk = &lfsck->li_bookmark_ram;
again:
while (ldata->ld_lee != NULL) {
- lfsck_namespace_unpack_linkea_entry(ldata, cname, tfid,
+ lfsck_namespace_unpack_linkea_entry(ldata, cname, &tfid,
info->lti_key);
/* Drop repeated linkEA entries. */
- lfsck_namespace_filter_linkea_entry(ldata, cname, tfid, true);
+ lfsck_namespace_filter_linkea_entry(ldata, cname, &tfid, true);
/* Drop invalid linkEA entry. */
- if (!fid_is_sane(tfid)) {
+ if (!fid_is_sane(&tfid)) {
linkea_del_buf(ldata, cname);
linkea_count++;
continue;
* When the LFSCK runs again, if the dangling name is still
* there, the LFSCK should move the orphan directory object
* back to the normal namespace. */
- if (!lpf && !lu_fid_eq(pfid, tfid) && once) {
+ if (!lpf && !lu_fid_eq(pfid, &tfid) && once) {
linkea_next_entry(ldata);
continue;
}
- parent = lfsck_object_find_bottom(env, lfsck, tfid);
+ parent = lfsck_object_find_bottom(env, lfsck, &tfid);
if (IS_ERR(parent))
RETURN(PTR_ERR(parent));
continue;
}
- rc = dt_lookup(env, parent, (struct dt_rec *)tfid,
+ rc = dt_lookup(env, parent, (struct dt_rec *)&tfid,
(const struct dt_key *)cname->ln_name,
BYPASS_CAPA);
*pfid2 = *lfsck_dto2fid(parent);
RETURN(rc);
}
- if (lu_fid_eq(tfid, cfid)) {
+ if (lu_fid_eq(&tfid, cfid)) {
lfsck_object_put(env, parent);
if (!lu_fid_eq(pfid, pfid2)) {
*type = LNIT_UNMATCHED_PAIRS;
* other parent directories, remove all of them. */
while (ldata->ld_lee != NULL) {
lfsck_namespace_unpack_linkea_entry(ldata,
- cname, tfid, info->lti_key);
- if (!fid_is_sane(tfid))
+ cname, &tfid, info->lti_key);
+ if (!fid_is_sane(&tfid))
goto next;
parent = lfsck_object_find_bottom(env, lfsck,
- tfid);
+ &tfid);
if (IS_ERR(parent)) {
rc = PTR_ERR(parent);
if (rc != -ENOENT &&
* created by the LFSCK for repairing dangling name entry.
* Try to replace it. */
rc = lfsck_namespace_replace_cond(env, com, parent, child,
- tfid, cname);
+ &tfid, cname);
lfsck_object_put(env, parent);
if (rc < 0)
RETURN(rc);
struct linkea_data ldata = { NULL };
struct lustre_handle lh = { 0 };
__u32 old = la->la_nlink;
+ int idx;
int rc = 0;
__u8 flags;
ENTRY;
GOTO(unlock, rc = 0);
fid_cpu_to_be(tfid, cfid);
- rc = dt_lookup(env, com->lc_obj, (struct dt_rec *)&flags,
- (const struct dt_key *)tfid, BYPASS_CAPA);
+ idx = lfsck_sub_trace_file_fid2idx(cfid);
+ rc = dt_lookup(env, com->lc_sub_trace_objs[idx].lsto_obj,
+ (struct dt_rec *)&flags, (const struct dt_key *)tfid,
+ BYPASS_CAPA);
if (rc != 0)
GOTO(unlock, rc);
}
/* Create the lost parent as an orphan. */
- rc = lfsck_namespace_create_orphan(env, com,
+ rc = lfsck_namespace_create_orphan_dir(env, com,
parent, NULL);
if (rc < 0) {
lfsck_object_put(env, parent);
}
}
+static int lfsck_namespace_check_for_double_scan(const struct lu_env *env,
+ struct lfsck_component *com,
+ struct dt_object *obj)
+{
+ struct lu_attr *la = &lfsck_env_info(env)->lti_la;
+ int rc;
+
+ rc = dt_attr_get(env, obj, la, BYPASS_CAPA);
+ if (rc != 0)
+ return rc;
+
+ /* zero-linkEA object may be orphan, but it also maybe because
+ * of upgrading. Currently, we cannot record it for double scan.
+ * Because it may cause the LFSCK trace file to be too large. */
+
+ /* "la_ctime" == 1 means that it has ever been removed from
+ * backend /lost+found directory but not been added back to
+ * the normal namespace yet. */
+
+ if ((S_ISREG(lfsck_object_type(obj)) && la->la_nlink > 1) ||
+ unlikely(la->la_ctime == 1))
+ rc = lfsck_namespace_trace_update(env, com, lfsck_dto2fid(obj),
+ LNTF_CHECK_LINKEA, true);
+
+ return rc;
+}
+
/* namespace APIs */
static int lfsck_namespace_reset(const struct lu_env *env,
ns->ln_magic = LFSCK_NAMESPACE_MAGIC;
ns->ln_status = LS_INIT;
- rc = local_object_unlink(env, lfsck->li_bottom, root,
- lfsck_namespace_name);
- if (rc != 0)
- GOTO(out, rc);
-
lfsck_object_put(env, com->lc_obj);
com->lc_obj = NULL;
- dto = local_index_find_or_create(env, lfsck->li_los, root,
- lfsck_namespace_name,
- S_IFREG | S_IRUGO | S_IWUSR,
- &dt_lfsck_features);
+ dto = lfsck_namespace_load_one_trace_file(env, com, root,
+ LFSCK_NAMESPACE, NULL, true);
if (IS_ERR(dto))
GOTO(out, rc = PTR_ERR(dto));
com->lc_obj = dto;
- rc = dto->do_ops->do_index_try(env, dto, &dt_lfsck_features);
+ rc = lfsck_namespace_load_sub_trace_files(env, com, true);
if (rc != 0)
GOTO(out, rc);
struct lfsck_namespace *ns = com->lc_file_ram;
struct lfsck_instance *lfsck = com->lc_lfsck;
const struct lu_fid *fid = lfsck_dto2fid(obj);
- struct lu_attr *la = &info->lti_la;
struct lu_fid *pfid = &info->lti_fid2;
struct lu_name *cname = &info->lti_name;
struct lu_seq_range *range = &info->lti_range;
GOTO(out, rc = (rc == -ENOENT ? 0 : rc));
}
- /* zero-linkEA object may be orphan, but it also maybe because
- * of upgrading. Currently, we cannot record it for double scan.
- * Because it may cause the LFSCK trace file to be too large. */
if (rc == -ENODATA) {
- if (S_ISDIR(lfsck_object_type(obj)))
- GOTO(out, rc = 0);
-
- rc = dt_attr_get(env, obj, la, BYPASS_CAPA);
- if (rc != 0)
- GOTO(out, rc);
-
- /* "la_ctime" == 1 means that it has ever been removed from
- * backend /lost+found directory but not been added back to
- * the normal namespace yet. */
- if (la->la_nlink > 1 || unlikely(la->la_ctime == 1))
- rc = lfsck_namespace_trace_update(env, com, fid,
- LNTF_CHECK_LINKEA, true);
+ rc = lfsck_namespace_check_for_double_scan(env, com, obj);
GOTO(out, rc);
}
rc = fld_local_lookup(env, ss->ss_server_fld,
fid_seq(pfid), range);
if ((rc == -ENOENT) ||
- (rc == 0 && range->lsr_index != idx)) {
+ (rc == 0 && range->lsr_index != idx))
rc = lfsck_namespace_trace_update(env, com, fid,
LNTF_CHECK_LINKEA, true);
- } else {
- if (S_ISDIR(lfsck_object_type(obj)))
- GOTO(out, rc = 0);
-
- rc = dt_attr_get(env, obj, la, BYPASS_CAPA);
- if (rc != 0)
- GOTO(out, rc);
-
- /* "la_ctime" == 1 means that it has ever been
- * removed from backend /lost+found directory but
- * not been added back to the normal namespace yet. */
- if (la->la_nlink > 1 || unlikely(la->la_ctime == 1))
- rc = lfsck_namespace_trace_update(env, com,
- fid, LNTF_CHECK_LINKEA, true);
- }
+ else
+ rc = lfsck_namespace_check_for_double_scan(env, com,
+ obj);
}
GOTO(out, rc);
ENTRY;
switch (lr->lr_event) {
- case LE_CREATE_ORPHAN: {
- struct dt_object *orphan = NULL;
- struct lmv_mds_md_v1 *lmv;
-
- CDEBUG(D_LFSCK, "%s: namespace LFSCK handling notify from "
- "MDT %x to create orphan"DFID" with type %o\n",
- lfsck_lfsck2name(lfsck), lr->lr_index,
- PFID(&lr->lr_fid), lr->lr_type);
-
- orphan = lfsck_object_find(env, lfsck, &lr->lr_fid);
- if (IS_ERR(orphan))
- GOTO(out_create, rc = PTR_ERR(orphan));
-
- if (dt_object_exists(orphan))
- GOTO(out_create, rc = -EEXIST);
-
- if (lr->lr_stripe_count > 0) {
- lmv = &lfsck_env_info(env)->lti_lmv;
- memset(lmv, 0, sizeof(*lmv));
- lmv->lmv_hash_type = lr->lr_hash_type;
- lmv->lmv_stripe_count = lr->lr_stripe_count;
- lmv->lmv_layout_version = lr->lr_layout_version;
- memcpy(lmv->lmv_pool_name, lr->lr_pool_name,
- sizeof(lmv->lmv_pool_name));
- } else {
- lmv = NULL;
- }
-
- rc = lfsck_namespace_create_orphan_local(env, com, orphan,
- lr->lr_type, lmv);
-
- GOTO(out_create, rc = (rc == 1) ? 0 : rc);
-
-out_create:
- CDEBUG(D_LFSCK, "%s: namespace LFSCK handled notify from "
- "MDT %x to create orphan"DFID" with type %o: rc = %d\n",
- lfsck_lfsck2name(lfsck), lr->lr_index,
- PFID(&lr->lr_fid), lr->lr_type, rc);
-
- if (orphan != NULL && !IS_ERR(orphan))
- lfsck_object_put(env, orphan);
-
- return rc;
- }
case LE_SKIP_NLINK_DECLARE: {
- struct dt_object *obj = com->lc_obj;
+ struct dt_object *obj;
struct lu_fid *key = &lfsck_env_info(env)->lti_fid3;
+ int idx;
__u8 flags = 0;
LASSERT(th != NULL);
+ idx = lfsck_sub_trace_file_fid2idx(&lr->lr_fid);
+ obj = com->lc_sub_trace_objs[idx].lsto_obj;
+ fid_cpu_to_be(key, &lr->lr_fid);
+ mutex_lock(&com->lc_sub_trace_objs[idx].lsto_mutex);
rc = dt_declare_delete(env, obj,
(const struct dt_key *)key, th);
if (rc == 0)
rc = dt_declare_insert(env, obj,
(const struct dt_rec *)&flags,
(const struct dt_key *)key, th);
+ mutex_unlock(&com->lc_sub_trace_objs[idx].lsto_mutex);
RETURN(rc);
}
case LE_SKIP_NLINK: {
- struct dt_object *obj = com->lc_obj;
+ struct dt_object *obj;
struct lu_fid *key = &lfsck_env_info(env)->lti_fid3;
+ int idx;
__u8 flags = 0;
bool exist = false;
ENTRY;
LASSERT(th != NULL);
+ idx = lfsck_sub_trace_file_fid2idx(&lr->lr_fid);
+ obj = com->lc_sub_trace_objs[idx].lsto_obj;
fid_cpu_to_be(key, &lr->lr_fid);
+ mutex_lock(&com->lc_sub_trace_objs[idx].lsto_mutex);
rc = dt_lookup(env, obj, (struct dt_rec *)&flags,
(const struct dt_key *)key, BYPASS_CAPA);
if (rc == 0) {
- if (flags & LNTF_SKIP_NLINK)
+ if (flags & LNTF_SKIP_NLINK) {
+ mutex_unlock(
+ &com->lc_sub_trace_objs[idx].lsto_mutex);
+
RETURN(0);
+ }
exist = true;
} else if (rc != -ENOENT) {
GOTO(log, rc);
log:
+ mutex_unlock(&com->lc_sub_trace_objs[idx].lsto_mutex);
CDEBUG(D_LFSCK, "%s: RPC service thread mark the "DFID
" to be skipped for namespace double scan: rc = %d\n",
lfsck_lfsck2name(com->lc_lfsck), PFID(&lr->lr_fid), rc);
bool bad_hash = false;
int idx = 0;
int count = 0;
- int rc;
+ int rc = 0;
enum lfsck_namespace_inconsistency_type type = LNIT_NONE;
ENTRY;
+ la->la_nlink = 0;
if (lnr->lnr_attr & LUDA_UPGRADE) {
ns->ln_flags |= LF_UPGRADE;
ns->ln_dirent_repaired++;
GOTO(out, rc);
}
+ if (unlikely(!fid_is_sane(&lnr->lnr_fid))) {
+ CDEBUG(D_LFSCK, "%s: dir scan find invalid FID "DFID
+ " for the name entry %.*s under "DFID"\n",
+ lfsck_lfsck2name(lfsck), PFID(&lnr->lnr_fid),
+ lnr->lnr_namelen, lnr->lnr_name, PFID(pfid));
+
+ if (strcmp(lnr->lnr_name, dotdot) != 0)
+ /* invalid FID means bad name entry, remove it. */
+ type = LNIT_BAD_DIRENT;
+ else
+ /* If the parent FID is invalid, we cannot remove
+ * the ".." entry directly. */
+ rc = lfsck_namespace_trace_update(env, com, pfid,
+ LNTF_CHECK_PARENT, true);
+
+ GOTO(out, rc);
+ }
+
if (unlikely(lnr->lnr_dir_cookie == MDS_DIR_END_OFF)) {
rc = lfsck_namespace_striped_dir_rescan(env, com, lnr);
type = LNIT_BAD_TYPE;
}
- goto record;
+ goto stop;
}
ns->ln_flags |= LF_INCONSISTENT;
ns->ln_linkea_repaired++;
repaired = true;
log = true;
- goto record;
+ goto stop;
}
if (!lustre_handle_is_used(&lh))
GOTO(stop, rc);
}
-record:
- LASSERT(count > 0);
-
- rc = dt_attr_get(env, obj, la, BYPASS_CAPA);
- if (rc != 0)
- GOTO(stop, rc);
-
- if ((count == 1 && la->la_nlink == 1) ||
- S_ISDIR(lfsck_object_type(obj)))
- /* Usually, it is for single linked object or dir, do nothing.*/
- GOTO(stop, rc);
-
- /* Following modification will be in another transaction. */
- if (handle != NULL) {
- dt_write_unlock(env, obj);
- dtlocked = false;
-
- dt_trans_stop(env, dev, handle);
- handle = NULL;
-
- lfsck_ibits_unlock(&lh, LCK_EX);
- }
-
- ns->ln_mul_linked_checked++;
- rc = lfsck_namespace_trace_update(env, com, &lnr->lnr_fid,
- LNTF_CHECK_LINKEA, true);
-
- GOTO(out, rc);
-
stop:
if (dtlocked)
dt_write_unlock(env, obj);
default:
break;
}
+
+ if (count == 1 && S_ISREG(lfsck_object_type(obj)))
+ dt_attr_get(env, obj, la, BYPASS_CAPA);
}
down_write(&com->lc_sem);
false);
}
-
rc = 0;
}
+
+ if (count > 1 || la->la_nlink > 1)
+ ns->ln_mul_linked_checked++;
+
up_write(&com->lc_sem);
if (obj != NULL && !IS_ERR(obj))
struct lu_fid *key = &info->lti_fid;
struct lu_attr *la = &info->lti_la;
struct lfsck_instance *lfsck = com->lc_lfsck;
- struct dt_object *obj = com->lc_obj;
+ struct dt_object *obj;
struct dt_device *dev = lfsck->li_bottom;
struct dt_object *child = NULL;
struct thandle *th = NULL;
+ int idx;
int rc = 0;
__u8 flags = 0;
bool exist = false;
LASSERT(dt_object_exists(child));
LASSERT(!dt_object_remote(child));
+ idx = lfsck_sub_trace_file_fid2idx(&ent->lde_fid);
+ obj = com->lc_sub_trace_objs[idx].lsto_obj;
fid_cpu_to_be(key, &ent->lde_fid);
rc = dt_lookup(env, obj, (struct dt_rec *)&flags,
(const struct dt_key *)key, BYPASS_CAPA);
rc = 0;
while (rc == 0) {
- if (OBD_FAIL_CHECK(OBD_FAIL_LFSCK_DELAY3) &&
- cfs_fail_val > 0) {
- struct l_wait_info lwi;
-
- lwi = LWI_TIMEOUT(cfs_time_seconds(cfs_fail_val),
- NULL, NULL);
- l_wait_event(thread->t_ctl_waitq,
- !thread_is_running(thread),
- &lwi);
-
- if (unlikely(!thread_is_running(thread)))
- break;
- }
+ if (CFS_FAIL_TIMEOUT(OBD_FAIL_LFSCK_DELAY3, cfs_fail_val) &&
+ unlikely(!thread_is_running(thread)))
+ break;
rc = iops->rec(env, di, (struct dt_rec *)ent,
LUDA_64BITHASH | LUDA_TYPE);
RETURN(rc == 0 ? 1 : rc);
}
-static int lfsck_namespace_assistant_handler_p2(const struct lu_env *env,
- struct lfsck_component *com)
+static int
+lfsck_namespace_double_scan_one_trace_file(const struct lu_env *env,
+ struct lfsck_component *com,
+ struct dt_object *obj, bool first)
{
struct lfsck_instance *lfsck = com->lc_lfsck;
struct ptlrpc_thread *thread = &lfsck->li_thread;
struct lfsck_bookmark *bk = &lfsck->li_bookmark_ram;
struct lfsck_namespace *ns = com->lc_file_ram;
- struct dt_object *obj = com->lc_obj;
const struct dt_it_ops *iops = &obj->do_index_ops->dio_it;
struct dt_object *target;
struct dt_it *di;
__u8 flags = 0;
ENTRY;
- while (!list_empty(&lfsck->li_list_lmv)) {
- struct lfsck_lmv_unit *llu;
-
- spin_lock(&lfsck->li_lock);
- llu = list_entry(lfsck->li_list_lmv.next,
- struct lfsck_lmv_unit, llu_link);
- list_del_init(&llu->llu_link);
- spin_unlock(&lfsck->li_lock);
-
- rc = lfsck_namespace_rescan_striped_dir(env, com, llu);
- if (rc <= 0)
- RETURN(rc);
- }
-
- CDEBUG(D_LFSCK, "%s: namespace LFSCK phase2 scan start\n",
- lfsck_lfsck2name(lfsck));
-
- lfsck_namespace_scan_local_lpf(env, com);
-
- com->lc_new_checked = 0;
- com->lc_new_scanned = 0;
- com->lc_time_last_checkpoint = cfs_time_current();
- com->lc_time_next_checkpoint = com->lc_time_last_checkpoint +
- cfs_time_seconds(LFSCK_CHECKPOINT_INTERVAL);
-
di = iops->init(env, obj, 0, BYPASS_CAPA);
if (IS_ERR(di))
RETURN(PTR_ERR(di));
- fid_cpu_to_be(&fid, &ns->ln_fid_latest_scanned_phase2);
+ if (first)
+ fid_cpu_to_be(&fid, &ns->ln_fid_latest_scanned_phase2);
+ else
+ fid_zero(&fid);
rc = iops->get(env, di, (const struct dt_key *)&fid);
if (rc < 0)
GOTO(fini, rc);
- /* Skip the start one, which either has been processed or non-exist. */
- rc = iops->next(env, di);
- if (rc != 0)
- GOTO(put, rc);
+ if (first) {
+ /* The start one either has been processed or does not exist,
+ * skip it. */
+ rc = iops->next(env, di);
+ if (rc != 0)
+ GOTO(put, rc);
+ }
do {
- if (OBD_FAIL_CHECK(OBD_FAIL_LFSCK_DELAY3) &&
- cfs_fail_val > 0) {
- struct l_wait_info lwi;
-
- lwi = LWI_TIMEOUT(cfs_time_seconds(cfs_fail_val),
- NULL, NULL);
- l_wait_event(thread->t_ctl_waitq,
- !thread_is_running(thread),
- &lwi);
-
- if (unlikely(!thread_is_running(thread)))
- GOTO(put, rc = 0);
- }
+ if (CFS_FAIL_TIMEOUT(OBD_FAIL_LFSCK_DELAY3, cfs_fail_val) &&
+ unlikely(!thread_is_running(thread)))
+ GOTO(put, rc = 0);
key = iops->key(env, di);
+ if (IS_ERR(key)) {
+ rc = PTR_ERR(key);
+ if (rc == -ENOENT)
+ GOTO(put, rc = 1);
+
+ goto checkpoint;
+ }
+
fid_be_to_cpu(&fid, (const struct lu_fid *)key);
if (!fid_is_sane(&fid)) {
rc = 0;
down_write(&com->lc_sem);
com->lc_new_checked++;
com->lc_new_scanned++;
- ns->ln_fid_latest_scanned_phase2 = fid;
+ if (rc >= 0 && fid_is_sane(&fid))
+ ns->ln_fid_latest_scanned_phase2 = fid;
if (rc > 0)
ns->ln_objs_repaired_phase2++;
else if (rc < 0)
fini:
iops->fini(env, di);
- CDEBUG(D_LFSCK, "%s: namespace LFSCK phase2 scan stop: rc = %d\n",
- lfsck_lfsck2name(lfsck), rc);
-
return rc;
}
+static int lfsck_namespace_assistant_handler_p2(const struct lu_env *env,
+ struct lfsck_component *com)
+{
+ struct lfsck_instance *lfsck = com->lc_lfsck;
+ struct lfsck_namespace *ns = com->lc_file_ram;
+ int rc;
+ int i;
+ ENTRY;
+
+ while (!list_empty(&lfsck->li_list_lmv)) {
+ struct lfsck_lmv_unit *llu;
+
+ spin_lock(&lfsck->li_lock);
+ llu = list_entry(lfsck->li_list_lmv.next,
+ struct lfsck_lmv_unit, llu_link);
+ list_del_init(&llu->llu_link);
+ spin_unlock(&lfsck->li_lock);
+
+ rc = lfsck_namespace_rescan_striped_dir(env, com, llu);
+ if (rc <= 0)
+ RETURN(rc);
+ }
+
+ CDEBUG(D_LFSCK, "%s: namespace LFSCK phase2 scan start\n",
+ lfsck_lfsck2name(lfsck));
+
+ lfsck_namespace_scan_local_lpf(env, com);
+
+ com->lc_new_checked = 0;
+ com->lc_new_scanned = 0;
+ com->lc_time_last_checkpoint = cfs_time_current();
+ com->lc_time_next_checkpoint = com->lc_time_last_checkpoint +
+ cfs_time_seconds(LFSCK_CHECKPOINT_INTERVAL);
+
+ i = lfsck_sub_trace_file_fid2idx(&ns->ln_fid_latest_scanned_phase2);
+ rc = lfsck_namespace_double_scan_one_trace_file(env, com,
+ com->lc_sub_trace_objs[i].lsto_obj, true);
+ while (rc > 0 && ++i < LFSCK_STF_COUNT)
+ rc = lfsck_namespace_double_scan_one_trace_file(env, com,
+ com->lc_sub_trace_objs[i].lsto_obj, false);
+
+ CDEBUG(D_LFSCK, "%s: namespace LFSCK phase2 scan stop at the No. %d "
+ "trace file: rc = %d\n", lfsck_lfsck2name(lfsck), i, rc);
+
+ RETURN(rc);
+}
+
static void lfsck_namespace_assistant_fill_pos(const struct lu_env *env,
struct lfsck_component *com,
struct lfsck_position *pos)
struct ptlrpc_request *req,
void *args, int rc)
{
+ if (rc == 0) {
+ struct lfsck_async_interpret_args *laia = args;
+ struct lfsck_tgt_desc *ltd = laia->laia_ltd;
+
+ ltd->ltd_synced_failures = 1;
+ }
+
return 0;
}
struct lfsck_tgt_descs *ltds = &lfsck->li_mdt_descs;
struct lfsck_tgt_desc *ltd;
struct ptlrpc_request_set *set;
+ __u32 idx;
int rc = 0;
ENTRY;
+ if (!lad->lad_incomplete)
+ RETURN_EXIT;
+
set = ptlrpc_prep_set();
if (set == NULL)
GOTO(out, rc = -ENOMEM);
memset(laia, 0, sizeof(*laia));
lad->lad_touch_gen++;
- spin_lock(<ds->ltd_lock);
- while (!list_empty(&lad->lad_mdt_list)) {
- ltd = list_entry(lad->lad_mdt_list.next,
- struct lfsck_tgt_desc,
- ltd_namespace_list);
- if (ltd->ltd_namespace_gen == lad->lad_touch_gen)
- break;
-
- ltd->ltd_namespace_gen = lad->lad_touch_gen;
- list_move_tail(<d->ltd_namespace_list,
- &lad->lad_mdt_list);
- if (!lad->lad_incomplete ||
- !cfs_bitmap_check(lad->lad_bitmap, ltd->ltd_index)) {
- ltd->ltd_namespace_failed = 0;
- continue;
- }
+ down_read(<ds->ltd_rw_sem);
+ cfs_foreach_bit(lad->lad_bitmap, idx) {
+ ltd = LTD_TGT(ltds, idx);
+ LASSERT(ltd != NULL);
- ltd->ltd_namespace_failed = 1;
- spin_unlock(<ds->ltd_lock);
+ laia->laia_ltd = ltd;
rc = lfsck_async_request(env, ltd->ltd_exp, lr, set,
lfsck_namespace_assistant_sync_failures_interpret,
laia, LFSCK_NOTIFY);
CDEBUG(D_LFSCK, "%s: namespace LFSCK assistant fail "
"to sync failure with MDT %x: rc = %d\n",
lfsck_lfsck2name(lfsck), ltd->ltd_index, rc);
-
- spin_lock(<ds->ltd_lock);
}
- spin_unlock(<ds->ltd_lock);
+ up_read(<ds->ltd_rw_sem);
rc = ptlrpc_set_wait(set);
ptlrpc_set_destroy(set);
}
/**
- * Remove the name entry from the parent directory.
- *
- * No need to care about the object referenced by the name entry,
- * either the name entry is invalid or redundant, or the referenced
- * object has been processed has been or will be handled by others.
- *
- * \param[in] env pointer to the thread context
- * \param[in] lfsck pointer to the lfsck instance
- * \param[in] parent pointer to the lost+found object
- * \param[in] name the name for the name entry to be removed
- * \param[in] type the type for the name entry to be removed
- *
- * \retval 0 for success
- * \retval negative error number on failure
- */
-int lfsck_remove_name_entry(const struct lu_env *env,
- struct lfsck_instance *lfsck,
- struct dt_object *parent,
- const char *name, __u32 type)
-{
- struct dt_device *dev = lfsck->li_next;
- struct thandle *th;
- struct lustre_handle lh = { 0 };
- int rc;
- ENTRY;
-
- rc = lfsck_ibits_lock(env, lfsck, parent, &lh,
- MDS_INODELOCK_UPDATE, LCK_EX);
- if (rc != 0)
- RETURN(rc);
-
- th = dt_trans_create(env, dev);
- if (IS_ERR(th))
- GOTO(unlock, rc = PTR_ERR(th));
-
- rc = dt_declare_delete(env, parent, (const struct dt_key *)name, th);
- if (rc != 0)
- GOTO(stop, rc);
-
- if (S_ISDIR(type)) {
- rc = dt_declare_ref_del(env, parent, th);
- if (rc != 0)
- GOTO(stop, rc);
- }
-
- rc = dt_trans_start(env, dev, th);
- if (rc != 0)
- GOTO(stop, rc);
-
- rc = dt_delete(env, parent, (const struct dt_key *)name, th,
- BYPASS_CAPA);
- if (rc != 0)
- GOTO(stop, rc);
-
- if (S_ISDIR(type)) {
- dt_write_lock(env, parent, 0);
- rc = dt_ref_del(env, parent, th);
- dt_write_unlock(env, parent);
- }
-
- GOTO(stop, rc);
-
-stop:
- dt_trans_stop(env, dev, th);
-
-unlock:
- lfsck_ibits_unlock(&lh, LCK_EX);
-
- CDEBUG(D_LFSCK, "%s: remove name entry "DFID"/%s "
- "with type %o: rc = %d\n", lfsck_lfsck2name(lfsck),
- PFID(lfsck_dto2fid(parent)), name, type, rc);
-
- return rc;
-}
-
-/**
* Update the object's name entry with the given FID.
*
* \param[in] env pointer to the thread context
struct lfsck_namespace *ns;
struct dt_object *root = NULL;
struct dt_object *obj;
+ int i;
int rc;
ENTRY;
com->lc_ops = &lfsck_namespace_ops;
com->lc_data = lfsck_assistant_data_init(
&lfsck_namespace_assistant_ops,
- "lfsck_namespace");
+ LFSCK_NAMESPACE);
if (com->lc_data == NULL)
GOTO(out, rc = -ENOMEM);
if (com->lc_file_disk == NULL)
GOTO(out, rc = -ENOMEM);
+ for (i = 0; i < LFSCK_STF_COUNT; i++)
+ mutex_init(&com->lc_sub_trace_objs[i].lsto_mutex);
+
root = dt_locate(env, lfsck->li_bottom, &lfsck->li_local_root_fid);
if (IS_ERR(root))
GOTO(out, rc = PTR_ERR(root));
if (unlikely(!dt_try_as_dir(env, root)))
GOTO(out, rc = -ENOTDIR);
- obj = local_index_find_or_create(env, lfsck->li_los, root,
- lfsck_namespace_name,
- S_IFREG | S_IRUGO | S_IWUSR,
- &dt_lfsck_features);
+ obj = local_file_find_or_create(env, lfsck->li_los, root,
+ LFSCK_NAMESPACE,
+ S_IFREG | S_IRUGO | S_IWUSR);
if (IS_ERR(obj))
GOTO(out, rc = PTR_ERR(obj));
com->lc_obj = obj;
- rc = obj->do_ops->do_index_try(env, obj, &dt_lfsck_features);
- if (rc != 0)
- GOTO(out, rc);
-
rc = lfsck_namespace_load(env, com);
if (rc == -ENODATA)
rc = lfsck_namespace_init(env, com);
else if (rc < 0)
rc = lfsck_namespace_reset(env, com, true);
+ else
+ rc = lfsck_namespace_load_sub_trace_files(env, com, false);
if (rc != 0)
GOTO(out, rc);