}
/**
- * \retval +1: repaired
- * \retval 0: did nothing
- * \retval -ve: on error
+ * This function will create the MDT-object will the given (partial) LOV EA.
+ *
+ * Under some data corruption cases, the MDT-object of the file may be lost,
+ * but its OST-objects, or some of them are there. The layout LFSCK needs to
+ * re-create the MDT-object with the orphan OST-object(s) information.
+ *
+ * On the other hand, the LFSCK may has created some OST-object for repairing
+ * dangling LOV EA reference, but as the LFSCK processing, it may find that
+ * the old OST-object is there and should replace the former new created OST
+ * object. Unfortunately, some others have modified such newly created object.
+ * To keep the data (both new and old), the LFSCK will create MDT-object with
+ * new FID to reference the original OST-object.
+ *
+ * \param[in] env pointer to the thread context
+ * \param[in] com pointer to the lfsck component
+ * \param[in] ltd pointer to target device descriptor
+ * \param[in] rec pointer to the record for the orphan OST-object
+ * \param[in] cfid pointer to FID for the orphan OST-object
+ * \param[in] infix additional information, such as the FID for original
+ * MDT-object and the stripe offset in the LOV EA
+ * \param[in] type the type for describing why the orphan MDT-object is
+ * created. The rules are as following:
+ *
+ * type "C": Multiple OST-objects claim the same MDT-object and the
+ * same slot in the layout EA. Then the LFSCK will create
+ * new MDT-object(s) to hold the conflict OST-object(s).
+ *
+ * type "N": The orphan OST-object does not know which one was the
+ * real parent MDT-object, so the LFSCK uses new FID for
+ * its parent MDT-object.
+ *
+ * type "R": The orphan OST-object knows its parent MDT-object FID,
+ * but does not know the position (the file name) in the
+ * namespace.
+ *
+ * The orphan name will be like:
+ * ${FID}-${infix}-${type}-${conflict_version}
+ *
+ * \param[in] ea_off the stripe offset in the LOV EA
+ *
+ * \retval positive on repaired something
+ * \retval if needs to repair nothing
+ * \retval negative error number on failure
*/
static int lfsck_layout_recreate_parent(const struct lu_env *env,
struct lfsck_component *com,
struct lfsck_tgt_desc *ltd,
struct lu_orphan_rec *rec,
struct lu_fid *cfid,
- const char *prefix,
- const char *postfix,
+ const char *infix,
+ const char *type,
__u32 ea_off)
{
struct lfsck_thread_info *info = lfsck_env_info(env);
RETURN(PTR_ERR(cobj));
}
- CDEBUG(D_LFSCK, "Re-create the lost MDT-object: parent "
- DFID", child "DFID", OST-index %u, stripe-index %u, "
- "prefix %s, postfix %s\n",
- PFID(pfid), PFID(cfid), ltd->ltd_index, ea_off, prefix, postfix);
+ CDEBUG(D_LFSCK, "Re-create the lost MDT-object: parent "DFID", child "
+ DFID", OST-index %u, stripe-index %u, infix %s, type %s\n",
+ PFID(pfid), PFID(cfid), ltd->ltd_index, ea_off, infix, type);
pobj = lfsck_object_find_by_dev(env, lfsck->li_bottom, pfid);
if (IS_ERR(pobj))
GOTO(put, rc = PTR_ERR(pobj));
- LASSERT(prefix != NULL);
- LASSERT(postfix != NULL);
+ LASSERT(infix != NULL);
+ LASSERT(type != NULL);
- /** name rules:
- *
- * 1. Use the MDT-object's FID as the name with prefix and postfix.
- *
- * 1.1 prefix "C-": More than one OST-objects claim the same
- * MDT-object and the same slot in the layout EA.
- * It may be created for dangling referenced MDT
- * object or may be not.
- * 1.2 prefix "N-": The orphan OST-object does not know which one
- * is the real parent, so the LFSCK assign a new
- * FID as its parent.
- * 1.3 prefix "R-": The orphan OST-object know its parent FID but
- * does not know the position in the namespace.
- *
- * 2. If there is name conflict, append more index for new name. */
- sprintf(name, "%s"DFID"%s", prefix, PFID(pfid), postfix);
do {
+ snprintf(name, NAME_MAX, DFID"%s-%s-%d", PFID(pfid), infix,
+ type, idx++);
rc = dt_lookup(env, lfsck->li_lpf_obj, (struct dt_rec *)tfid,
(const struct dt_key *)name, BYPASS_CAPA);
if (rc != 0 && rc != -ENOENT)
GOTO(put, rc);
-
- if (unlikely(rc == 0)) {
- CWARN("%s: The name %s under lost+found has been used "
- "by the "DFID". Try to increase the FID version "
- "for the new file name.\n",
- lfsck_lfsck2name(lfsck), name, PFID(tfid));
- sprintf(name, "%s"DFID"%s-%d", prefix, PFID(pfid),
- postfix, ++idx);
- }
} while (rc == 0);
memset(la, 0, sizeof(*la));
struct lfsck_thread_info *info = lfsck_env_info(env);
struct lu_fid *cfid2 = &info->lti_fid2;
struct ost_id *oi = &info->lti_oi;
- char *postfix = info->lti_tmpbuf;
+ char *infix = info->lti_tmpbuf;
struct lov_mds_md_v1 *lmm = ea_buf->lb_buf;
struct dt_device *dev = com->lc_lfsck->li_bottom;
struct thandle *th = NULL;
ea_buf->lb_len = ori_len;
fid_zero(&rec->lor_fid);
- snprintf(postfix, LFSCK_TMPBUF_LEN, "-"DFID"-%x",
+ snprintf(infix, LFSCK_TMPBUF_LEN, "-"DFID"-%x",
PFID(lu_object_fid(&parent->do_lu)), ea_off);
rc = lfsck_layout_recreate_parent(env, com, ltd, rec, cfid,
- "C-", postfix, ea_off);
+ infix, "C", ea_off);
RETURN(rc);
}
if (fid_is_zero(pfid)) {
rc = lfsck_layout_recreate_parent(env, com, ltd, rec, cfid,
- "N-", "", ea_off);
+ "", "N", ea_off);
GOTO(out, rc);
}
if (dt_object_exists(parent) == 0) {
lu_object_put(env, &parent->do_lu);
rc = lfsck_layout_recreate_parent(env, com, ltd, rec, cfid,
- "R-", "", ea_off);
+ "", "R", ea_off);
GOTO(out, rc);
}
git://git.whamcloud.com / fs / lustre-release.git / blobdiff