Whamcloud - gitweb
LU-4788 lfsck: replace cfs_list_t with list_head
[fs/lustre-release.git] / lustre / lfsck / lfsck_engine.c
index 592c27e..5faba39 100644 (file)
@@ -28,9 +28,6 @@
  * Author: Fan, Yong <fan.yong@intel.com>
  */
 
-#ifndef EXPORT_SYMTAB
-# define EXPORT_SYMTAB
-#endif
 #define DEBUG_SUBSYSTEM S_LFSCK
 
 #include <lu_object.h>
@@ -96,14 +93,73 @@ static void lfsck_close_dir(const struct lu_env *env,
        lfsck_object_put(env, dir_obj);
 }
 
+static int lfsck_update_lma(const struct lu_env *env,
+                           struct lfsck_instance *lfsck, struct dt_object *obj)
+{
+       struct lfsck_thread_info        *info   = lfsck_env_info(env);
+       struct lfsck_bookmark           *bk     = &lfsck->li_bookmark_ram;
+       struct dt_device                *dt     = lfsck->li_bottom;
+       struct lustre_mdt_attrs         *lma    = &info->lti_lma;
+       struct lu_buf                   *buf;
+       struct thandle                  *th;
+       int                              fl;
+       int                              rc;
+       ENTRY;
+
+       if (bk->lb_param & LPF_DRYRUN)
+               RETURN(0);
+
+       buf = lfsck_buf_get(env, info->lti_lma_old, LMA_OLD_SIZE);
+       rc = dt_xattr_get(env, obj, buf, XATTR_NAME_LMA, BYPASS_CAPA);
+       if (rc < 0) {
+               if (rc != -ENODATA)
+                       RETURN(rc);
+
+               fl = LU_XATTR_CREATE;
+               lustre_lma_init(lma, lfsck_dto2fid(obj), LMAC_FID_ON_OST, 0);
+       } else {
+               if (rc != LMA_OLD_SIZE && rc != sizeof(struct lustre_mdt_attrs))
+                       RETURN(-EINVAL);
+
+               fl = LU_XATTR_REPLACE;
+               lustre_lma_swab(lma);
+               lustre_lma_init(lma, lfsck_dto2fid(obj),
+                               lma->lma_compat | LMAC_FID_ON_OST,
+                               lma->lma_incompat);
+       }
+       lustre_lma_swab(lma);
+
+       th = dt_trans_create(env, dt);
+       if (IS_ERR(th))
+               RETURN(PTR_ERR(th));
+
+       buf = lfsck_buf_get(env, lma, sizeof(*lma));
+       rc = dt_declare_xattr_set(env, obj, buf, XATTR_NAME_LMA, fl, th);
+       if (rc != 0)
+               GOTO(stop, rc);
+
+       rc = dt_trans_start(env, dt, th);
+       if (rc != 0)
+               GOTO(stop, rc);
+
+       rc = dt_xattr_set(env, obj, buf, XATTR_NAME_LMA, fl, th, BYPASS_CAPA);
+
+       GOTO(stop, rc);
+
+stop:
+       dt_trans_stop(env, dt, th);
+       return rc;
+}
+
 static int lfsck_master_dir_engine(const struct lu_env *env,
                                   struct lfsck_instance *lfsck)
 {
        struct lfsck_thread_info        *info   = lfsck_env_info(env);
-       const struct dt_it_ops          *iops   =
-                       &lfsck->li_obj_dir->do_index_ops->dio_it;
+       struct dt_object                *dir    = lfsck->li_obj_dir;
+       const struct dt_it_ops          *iops   = &dir->do_index_ops->dio_it;
        struct dt_it                    *di     = lfsck->li_di_dir;
-       struct lu_dirent                *ent    = &info->lti_ent;
+       struct lu_dirent                *ent    =
+                       (struct lu_dirent *)info->lti_key;
        struct lu_fid                   *fid    = &info->lti_fid;
        struct lfsck_bookmark           *bk     = &lfsck->li_bookmark_ram;
        struct ptlrpc_thread            *thread = &lfsck->li_thread;
@@ -129,6 +185,11 @@ static int lfsck_master_dir_engine(const struct lu_env *env,
                               lfsck->li_args_dir);
                lfsck_unpack_ent(ent, &lfsck->li_cookie_dir);
                if (rc != 0) {
+                       CDEBUG(D_LFSCK, "%s: scan dir failed at rec(), "
+                              "parent "DFID", cookie "LPX64": rc = %d\n",
+                              lfsck_lfsck2name(lfsck),
+                              PFID(lfsck_dto2fid(dir)),
+                              lfsck->li_cookie_dir, rc);
                        lfsck_fail(env, lfsck, true);
                        if (bk->lb_param & LPF_FAILOUT)
                                RETURN(rc);
@@ -144,6 +205,12 @@ static int lfsck_master_dir_engine(const struct lu_env *env,
                if (child == NULL) {
                        goto checkpoint;
                } else if (IS_ERR(child)) {
+                       CDEBUG(D_LFSCK, "%s: scan dir failed at find target, "
+                              "parent "DFID", child %.*s "DFID": rc = %d\n",
+                              lfsck_lfsck2name(lfsck),
+                              PFID(lfsck_dto2fid(dir)),
+                              ent->lde_namelen, ent->lde_name,
+                              PFID(&ent->lde_fid), rc);
                        lfsck_fail(env, lfsck, true);
                        if (bk->lb_param & LPF_FAILOUT)
                                RETURN(PTR_ERR(child));
@@ -166,8 +233,14 @@ checkpoint:
 
                /* Rate control. */
                lfsck_control_speed(lfsck);
-               if (unlikely(!thread_is_running(thread)))
+               if (unlikely(!thread_is_running(thread))) {
+                       CDEBUG(D_LFSCK, "%s: scan dir exit for engine stop, "
+                              "parent "DFID", cookie "LPX64"\n",
+                              lfsck_lfsck2name(lfsck),
+                              PFID(lfsck_dto2fid(dir)),
+                              lfsck->li_cookie_dir);
                        RETURN(0);
+               }
 
                if (OBD_FAIL_CHECK(OBD_FAIL_LFSCK_FATAL2)) {
                        spin_lock(&lfsck->li_lock);
@@ -195,11 +268,14 @@ static int lfsck_master_oit_engine(const struct lu_env *env,
        struct lu_fid                   *fid    = &info->lti_fid;
        struct lfsck_bookmark           *bk     = &lfsck->li_bookmark_ram;
        struct ptlrpc_thread            *thread = &lfsck->li_thread;
+       __u32                            idx    =
+                               lfsck_dev_idx(lfsck->li_bottom);
        int                              rc;
        ENTRY;
 
        do {
                struct dt_object *target;
+               bool              update_lma = false;
 
                if (lfsck->li_di_dir != NULL) {
                        rc = lfsck_master_dir_engine(env, lfsck);
@@ -228,17 +304,44 @@ static int lfsck_master_oit_engine(const struct lu_env *env,
                lfsck->li_new_scanned++;
                rc = iops->rec(env, di, (struct dt_rec *)fid, 0);
                if (rc != 0) {
+                       CDEBUG(D_LFSCK, "%s: OIT scan failed at rec(): "
+                              "rc = %d\n", lfsck_lfsck2name(lfsck), rc);
                        lfsck_fail(env, lfsck, true);
-                       if (bk->lb_param & LPF_FAILOUT)
+                       if (rc < 0 && bk->lb_param & LPF_FAILOUT)
                                RETURN(rc);
                        else
                                goto checkpoint;
                }
 
+               if (fid_is_idif(fid)) {
+                       __u32 idx1 = fid_idif_ost_idx(fid);
+
+                       LASSERT(!lfsck->li_master);
+
+                       /* It is an old format device, update the LMA. */
+                       if (idx != idx1) {
+                               struct ost_id *oi = &info->lti_oi;
+
+                               fid_to_ostid(fid, oi);
+                               ostid_to_fid(fid, oi, idx);
+                               update_lma = true;
+                       }
+               } else if (!fid_is_norm(fid) && !fid_is_igif(fid) &&
+                          !fid_is_last_id(fid) && !fid_is_root(fid) &&
+                          !fid_seq_is_dot(fid_seq(fid))) {
+                       /* If the FID/object is only used locally and invisible
+                        * to external nodes, then LFSCK will not handle it. */
+                       goto checkpoint;
+               }
+
                target = lfsck_object_find(env, lfsck, fid);
                if (target == NULL) {
                        goto checkpoint;
                } else if (IS_ERR(target)) {
+                       CDEBUG(D_LFSCK, "%s: OIT scan failed at find target "
+                              DFID", cookie "LPU64": rc = %d\n",
+                              lfsck_lfsck2name(lfsck), PFID(fid),
+                              iops->store(env, di), rc);
                        lfsck_fail(env, lfsck, true);
                        if (bk->lb_param & LPF_FAILOUT)
                                RETURN(PTR_ERR(target));
@@ -248,8 +351,18 @@ static int lfsck_master_oit_engine(const struct lu_env *env,
 
                /* XXX: Currently, skip remote object, the consistency for
                 *      remote object will be processed in LFSCK phase III. */
-               if (dt_object_exists(target) && !dt_object_remote(target))
-                       rc = lfsck_exec_oit(env, lfsck, target);
+               if (dt_object_exists(target) && !dt_object_remote(target)) {
+                       if (update_lma) {
+                               rc = lfsck_update_lma(env, lfsck, target);
+                               if (rc != 0)
+                                       CDEBUG(D_LFSCK, "%s: fail to update "
+                                              "LMA for "DFID": rc = %d\n",
+                                              lfsck_lfsck2name(lfsck),
+                                              PFID(lfsck_dto2fid(target)), rc);
+                       }
+                       if (rc == 0)
+                               rc = lfsck_exec_oit(env, lfsck, target);
+               }
                lfsck_object_put(env, target);
                if (rc != 0 && bk->lb_param & LPF_FAILOUT)
                        RETURN(rc);
@@ -275,8 +388,12 @@ checkpoint:
                else if (likely(rc == 0))
                        lfsck->li_current_oit_processed = 0;
 
-               if (unlikely(!thread_is_running(thread)))
+               if (unlikely(!thread_is_running(thread))) {
+                       CDEBUG(D_LFSCK, "%s: OIT scan exit for engine stop, "
+                              "cookie "LPU64"\n", lfsck_lfsck2name(lfsck),
+                              iops->store(env, di));
                        RETURN(0);
+               }
        } while (rc == 0 || lfsck->li_di_dir != NULL);
 
        RETURN(rc);
@@ -284,88 +401,92 @@ checkpoint:
 
 int lfsck_master_engine(void *args)
 {
-       struct lu_env            env;
-       struct lfsck_instance   *lfsck    = (struct lfsck_instance *)args;
-       struct ptlrpc_thread    *thread   = &lfsck->li_thread;
-       struct dt_object        *oit_obj  = lfsck->li_obj_oit;
-       const struct dt_it_ops  *oit_iops = &oit_obj->do_index_ops->dio_it;
-       struct dt_it            *oit_di;
-       int                      rc;
+       struct lfsck_thread_args *lta      = args;
+       struct lu_env            *env      = &lta->lta_env;
+       struct lfsck_instance    *lfsck    = lta->lta_lfsck;
+       struct ptlrpc_thread     *thread   = &lfsck->li_thread;
+       struct dt_object         *oit_obj  = lfsck->li_obj_oit;
+       const struct dt_it_ops   *oit_iops = &oit_obj->do_index_ops->dio_it;
+       struct dt_it             *oit_di;
+       struct l_wait_info        lwi      = { 0 };
+       int                       rc;
        ENTRY;
 
-       rc = lu_env_init(&env, LCT_MD_THREAD | LCT_DT_THREAD);
-       if (rc != 0) {
-               CERROR("%s: LFSCK, fail to init env, rc = %d\n",
-                      lfsck_lfsck2name(lfsck), rc);
-               GOTO(noenv, rc);
-       }
-
-       oit_di = oit_iops->init(&env, oit_obj, lfsck->li_args_oit, BYPASS_CAPA);
+       oit_di = oit_iops->init(env, oit_obj, lfsck->li_args_oit, BYPASS_CAPA);
        if (IS_ERR(oit_di)) {
                rc = PTR_ERR(oit_di);
-               CERROR("%s: LFSCK, fail to init iteration, rc = %d\n",
-                      lfsck_lfsck2name(lfsck), rc);
-               GOTO(fini_env, rc);
+               CDEBUG(D_LFSCK, "%s: master engine fail to init iteration: "
+                      "rc = %d\n", lfsck_lfsck2name(lfsck), rc);
+
+               GOTO(fini_args, rc);
        }
 
        spin_lock(&lfsck->li_lock);
        lfsck->li_di_oit = oit_di;
        spin_unlock(&lfsck->li_lock);
-       rc = lfsck_prep(&env, lfsck);
+       rc = lfsck_prep(env, lfsck, lta->lta_lsp);
        if (rc != 0)
                GOTO(fini_oit, rc);
 
-       CDEBUG(D_LFSCK, "LFSCK entry: oit_flags = 0x%x, dir_flags = 0x%x, "
-              "oit_cookie = "LPU64", dir_cookie = "LPU64", parent = "DFID
+       CDEBUG(D_LFSCK, "LFSCK entry: oit_flags = %#x, dir_flags = %#x, "
+              "oit_cookie = "LPU64", dir_cookie = "LPX64", parent = "DFID
               ", pid = %d\n", lfsck->li_args_oit, lfsck->li_args_dir,
               lfsck->li_pos_current.lp_oit_cookie,
               lfsck->li_pos_current.lp_dir_cookie,
               PFID(&lfsck->li_pos_current.lp_dir_parent),
-              cfs_curproc_pid());
+              current_pid());
 
        spin_lock(&lfsck->li_lock);
        thread_set_flags(thread, SVC_RUNNING);
        spin_unlock(&lfsck->li_lock);
-       cfs_waitq_broadcast(&thread->t_ctl_waitq);
-
-       if (!cfs_list_empty(&lfsck->li_list_scan) ||
-           cfs_list_empty(&lfsck->li_list_double_scan))
-               rc = lfsck_master_oit_engine(&env, lfsck);
+       wake_up_all(&thread->t_ctl_waitq);
+
+       l_wait_event(thread->t_ctl_waitq,
+                    lfsck->li_start_unplug ||
+                    !thread_is_running(thread),
+                    &lwi);
+       if (!thread_is_running(thread))
+               GOTO(fini_oit, rc = 0);
+
+       if (!list_empty(&lfsck->li_list_scan) ||
+           list_empty(&lfsck->li_list_double_scan))
+               rc = lfsck_master_oit_engine(env, lfsck);
        else
                rc = 1;
 
-       CDEBUG(D_LFSCK, "LFSCK exit: oit_flags = 0x%x, dir_flags = 0x%x, "
-              "oit_cookie = "LPU64", dir_cookie = "LPU64", parent = "DFID
+       CDEBUG(D_LFSCK, "LFSCK exit: oit_flags = %#x, dir_flags = %#x, "
+              "oit_cookie = "LPU64", dir_cookie = "LPX64", parent = "DFID
               ", pid = %d, rc = %d\n", lfsck->li_args_oit, lfsck->li_args_dir,
               lfsck->li_pos_current.lp_oit_cookie,
               lfsck->li_pos_current.lp_dir_cookie,
               PFID(&lfsck->li_pos_current.lp_dir_parent),
-              cfs_curproc_pid(), rc);
+              current_pid(), rc);
 
        if (!OBD_FAIL_CHECK(OBD_FAIL_LFSCK_CRASH))
-               rc = lfsck_post(&env, lfsck, rc);
+               rc = lfsck_post(env, lfsck, rc);
+
        if (lfsck->li_di_dir != NULL)
-               lfsck_close_dir(&env, lfsck);
+               lfsck_close_dir(env, lfsck);
 
 fini_oit:
-       lfsck_di_oit_put(&env, lfsck);
-       oit_iops->fini(&env, oit_di);
+       lfsck_di_oit_put(env, lfsck);
+       oit_iops->fini(env, oit_di);
        if (rc == 1) {
-               if (!cfs_list_empty(&lfsck->li_list_double_scan))
-                       rc = lfsck_double_scan(&env, lfsck);
+               if (!list_empty(&lfsck->li_list_double_scan))
+                       rc = lfsck_double_scan(env, lfsck);
                else
                        rc = 0;
+       } else {
+               lfsck_quit(env, lfsck);
        }
 
        /* XXX: Purge the pinned objects in the future. */
 
-fini_env:
-       lu_env_fini(&env);
-
-noenv:
+fini_args:
        spin_lock(&lfsck->li_lock);
        thread_set_flags(thread, SVC_STOPPED);
-       cfs_waitq_broadcast(&thread->t_ctl_waitq);
        spin_unlock(&lfsck->li_lock);
+       wake_up_all(&thread->t_ctl_waitq);
+       lfsck_thread_args_fini(lta);
        return rc;
 }