Whamcloud - gitweb
LU-5305 ldlm: fix a use after free in ldlm_resource_get()
[fs/lustre-release.git] / lustre / ldlm / ldlm_resource.c
index 47b2901..5f6a645 100644 (file)
@@ -27,7 +27,7 @@
  * Copyright (c) 2002, 2010, Oracle and/or its affiliates. All rights reserved.
  * Use is subject to license terms.
  *
- * Copyright (c) 2010, 2012, Intel Corporation.
+ * Copyright (c) 2010, 2013, Intel Corporation.
  */
 /*
  * This file is part of Lustre, http://www.lustre.org/
 #include <obd_class.h>
 #include "ldlm_internal.h"
 
-cfs_mem_cache_t *ldlm_resource_slab, *ldlm_lock_slab;
+struct kmem_cache *ldlm_resource_slab, *ldlm_lock_slab;
 
-cfs_atomic_t ldlm_srv_namespace_nr = CFS_ATOMIC_INIT(0);
-cfs_atomic_t ldlm_cli_namespace_nr = CFS_ATOMIC_INIT(0);
+int ldlm_srv_namespace_nr = 0;
+int ldlm_cli_namespace_nr = 0;
 
 struct mutex ldlm_srv_namespace_lock;
 CFS_LIST_HEAD(ldlm_srv_namespace_list);
 
 struct mutex ldlm_cli_namespace_lock;
-CFS_LIST_HEAD(ldlm_cli_namespace_list);
+/* Client Namespaces that have active resources in them.
+ * Once all resources go away, ldlm_poold moves such namespaces to the
+ * inactive list */
+CFS_LIST_HEAD(ldlm_cli_active_namespace_list);
+/* Client namespaces that don't have any locks in them */
+CFS_LIST_HEAD(ldlm_cli_inactive_namespace_list);
 
-cfs_proc_dir_entry_t *ldlm_type_proc_dir = NULL;
-cfs_proc_dir_entry_t *ldlm_ns_proc_dir = NULL;
-cfs_proc_dir_entry_t *ldlm_svc_proc_dir = NULL;
+struct proc_dir_entry *ldlm_type_proc_dir = NULL;
+struct proc_dir_entry *ldlm_ns_proc_dir = NULL;
+struct proc_dir_entry *ldlm_svc_proc_dir = NULL;
 
 extern unsigned int ldlm_cancel_unused_locks_before_replay;
 
@@ -72,60 +77,73 @@ extern unsigned int ldlm_cancel_unused_locks_before_replay;
 unsigned int ldlm_dump_granted_max = 256;
 
 #ifdef LPROCFS
-static int ldlm_proc_dump_ns(struct file *file, const char *buffer,
-                             unsigned long count, void *data)
+static ssize_t
+lprocfs_dump_ns_seq_write(struct file *file, const char *buffer,
+                         size_t count, loff_t *off)
 {
-        ldlm_dump_all_namespaces(LDLM_NAMESPACE_SERVER, D_DLMTRACE);
-        ldlm_dump_all_namespaces(LDLM_NAMESPACE_CLIENT, D_DLMTRACE);
-        RETURN(count);
+       ldlm_dump_all_namespaces(LDLM_NAMESPACE_SERVER, D_DLMTRACE);
+       ldlm_dump_all_namespaces(LDLM_NAMESPACE_CLIENT, D_DLMTRACE);
+       RETURN(count);
 }
+LPROC_SEQ_FOPS_WO_TYPE(ldlm, dump_ns);
+
+LPROC_SEQ_FOPS_RW_TYPE(ldlm_rw, uint);
+LPROC_SEQ_FOPS_RO_TYPE(ldlm, uint);
 
 int ldlm_proc_setup(void)
 {
-        int rc;
-        struct lprocfs_vars list[] = {
-                { "dump_namespaces", NULL, ldlm_proc_dump_ns, NULL },
-                { "dump_granted_max",
-                  lprocfs_rd_uint, lprocfs_wr_uint,
-                  &ldlm_dump_granted_max, NULL },
-                { "cancel_unused_locks_before_replay",
-                  lprocfs_rd_uint, lprocfs_wr_uint,
-                  &ldlm_cancel_unused_locks_before_replay, NULL },
-                { NULL }};
-        ENTRY;
-        LASSERT(ldlm_ns_proc_dir == NULL);
-
-        ldlm_type_proc_dir = lprocfs_register(OBD_LDLM_DEVICENAME,
-                                              proc_lustre_root,
-                                              NULL, NULL);
-        if (IS_ERR(ldlm_type_proc_dir)) {
-                CERROR("LProcFS failed in ldlm-init\n");
-                rc = PTR_ERR(ldlm_type_proc_dir);
-                GOTO(err, rc);
-        }
+       int rc;
+       struct lprocfs_seq_vars list[] = {
+               { .name =       "dump_namespaces",
+                 .fops =       &ldlm_dump_ns_fops,
+                 .proc_mode =  0222 },
+               { .name =       "dump_granted_max",
+                 .fops =       &ldlm_rw_uint_fops,
+                 .data =       &ldlm_dump_granted_max },
+               { .name =       "cancel_unused_locks_before_replay",
+                 .fops =       &ldlm_rw_uint_fops,
+                 .data =       &ldlm_cancel_unused_locks_before_replay },
+               { NULL }};
+       ENTRY;
+       LASSERT(ldlm_ns_proc_dir == NULL);
+
+       ldlm_type_proc_dir = lprocfs_seq_register(OBD_LDLM_DEVICENAME,
+                                                       proc_lustre_root,
+                                                       NULL, NULL);
+       if (IS_ERR(ldlm_type_proc_dir)) {
+               CERROR("LProcFS failed in ldlm-init\n");
+               rc = PTR_ERR(ldlm_type_proc_dir);
+               GOTO(err, rc);
+       }
 
-        ldlm_ns_proc_dir = lprocfs_register("namespaces",
-                                            ldlm_type_proc_dir,
-                                            NULL, NULL);
-        if (IS_ERR(ldlm_ns_proc_dir)) {
-                CERROR("LProcFS failed in ldlm-init\n");
-                rc = PTR_ERR(ldlm_ns_proc_dir);
-                GOTO(err_type, rc);
-        }
+       ldlm_ns_proc_dir = lprocfs_seq_register("namespaces",
+                                               ldlm_type_proc_dir,
+                                               NULL, NULL);
+       if (IS_ERR(ldlm_ns_proc_dir)) {
+               CERROR("LProcFS failed in ldlm-init\n");
+               rc = PTR_ERR(ldlm_ns_proc_dir);
+               GOTO(err_type, rc);
+       }
 
-        ldlm_svc_proc_dir = lprocfs_register("services",
-                                            ldlm_type_proc_dir,
-                                            NULL, NULL);
-        if (IS_ERR(ldlm_svc_proc_dir)) {
-                CERROR("LProcFS failed in ldlm-init\n");
-                rc = PTR_ERR(ldlm_svc_proc_dir);
-                GOTO(err_ns, rc);
-        }
+       ldlm_svc_proc_dir = lprocfs_seq_register("services",
+                                               ldlm_type_proc_dir,
+                                               NULL, NULL);
+       if (IS_ERR(ldlm_svc_proc_dir)) {
+               CERROR("LProcFS failed in ldlm-init\n");
+               rc = PTR_ERR(ldlm_svc_proc_dir);
+               GOTO(err_ns, rc);
+       }
 
-        rc = lprocfs_add_vars(ldlm_type_proc_dir, list, NULL);
+       rc = lprocfs_seq_add_vars(ldlm_type_proc_dir, list, NULL);
+       if (rc != 0) {
+               CERROR("LProcFS failed in ldlm-init\n");
+               GOTO(err_svc, rc);
+       }
 
-        RETURN(0);
+       RETURN(0);
 
+err_svc:
+       lprocfs_remove(&ldlm_svc_proc_dir);
 err_ns:
         lprocfs_remove(&ldlm_ns_proc_dir);
 err_type:
@@ -147,52 +165,51 @@ void ldlm_proc_cleanup(void)
                 lprocfs_remove(&ldlm_type_proc_dir);
 }
 
-static int lprocfs_rd_ns_resources(char *page, char **start, off_t off,
-                                   int count, int *eof, void *data)
+static int lprocfs_ns_resources_seq_show(struct seq_file *m, void *v)
 {
-        struct ldlm_namespace *ns  = data;
-        __u64                  res = 0;
-        cfs_hash_bd_t          bd;
-        int                    i;
-
-        /* result is not strictly consistant */
-        cfs_hash_for_each_bucket(ns->ns_rs_hash, &bd, i)
-                res += cfs_hash_bd_count_get(&bd);
-        return lprocfs_rd_u64(page, start, off, count, eof, &res);
+       struct ldlm_namespace   *ns  = m->private;
+       __u64                   res = 0;
+       cfs_hash_bd_t           bd;
+       int                     i;
+
+       /* result is not strictly consistant */
+       cfs_hash_for_each_bucket(ns->ns_rs_hash, &bd, i)
+               res += cfs_hash_bd_count_get(&bd);
+       return lprocfs_u64_seq_show(m, &res);
 }
+LPROC_SEQ_FOPS_RO(lprocfs_ns_resources);
 
-static int lprocfs_rd_ns_locks(char *page, char **start, off_t off,
-                               int count, int *eof, void *data)
+static int lprocfs_ns_locks_seq_show(struct seq_file *m, void *v)
 {
-        struct ldlm_namespace *ns = data;
-        __u64                  locks;
+       struct ldlm_namespace   *ns = m->private;
+       __u64                   locks;
 
-        locks = lprocfs_stats_collector(ns->ns_stats, LDLM_NSS_LOCKS,
-                                        LPROCFS_FIELDS_FLAGS_SUM);
-        return lprocfs_rd_u64(page, start, off, count, eof, &locks);
+       locks = lprocfs_stats_collector(ns->ns_stats, LDLM_NSS_LOCKS,
+                                       LPROCFS_FIELDS_FLAGS_SUM);
+       return lprocfs_u64_seq_show(m, &locks);
 }
+LPROC_SEQ_FOPS_RO(lprocfs_ns_locks);
 
-static int lprocfs_rd_lru_size(char *page, char **start, off_t off,
-                               int count, int *eof, void *data)
+static int lprocfs_lru_size_seq_show(struct seq_file *m, void *v)
 {
-        struct ldlm_namespace *ns = data;
-        __u32 *nr = &ns->ns_max_unused;
+       struct ldlm_namespace *ns = m->private;
+       __u32 *nr = &ns->ns_max_unused;
 
-        if (ns_connect_lru_resize(ns))
-                nr = &ns->ns_nr_unused;
-        return lprocfs_rd_uint(page, start, off, count, eof, nr);
+       if (ns_connect_lru_resize(ns))
+               nr = &ns->ns_nr_unused;
+       return lprocfs_uint_seq_show(m, nr);
 }
 
-static int lprocfs_wr_lru_size(struct file *file, const char *buffer,
-                               unsigned long count, void *data)
+static ssize_t lprocfs_lru_size_seq_write(struct file *file, const char *buffer,
+                                         size_t count, loff_t *off)
 {
-        struct ldlm_namespace *ns = data;
+       struct ldlm_namespace *ns = ((struct seq_file *)file->private_data)->private;
         char dummy[MAX_STRING_SIZE + 1], *end;
         unsigned long tmp;
         int lru_resize;
 
         dummy[MAX_STRING_SIZE] = '\0';
-        if (cfs_copy_from_user(dummy, buffer, MAX_STRING_SIZE))
+       if (copy_from_user(dummy, buffer, MAX_STRING_SIZE))
                 return -EFAULT;
 
         if (strncmp(dummy, "clear", 5) == 0) {
@@ -269,20 +286,20 @@ static int lprocfs_wr_lru_size(struct file *file, const char *buffer,
 
         return count;
 }
+LPROC_SEQ_FOPS(lprocfs_lru_size);
 
-static int lprocfs_rd_elc(char *page, char **start, off_t off,
-                         int count, int *eof, void *data)
+static int lprocfs_elc_seq_show(struct seq_file *m, void *v)
 {
-       struct ldlm_namespace *ns = data;
+       struct ldlm_namespace *ns = m->private;
        unsigned int supp = ns_connect_cancelset(ns);
 
-       return lprocfs_rd_uint(page, start, off, count, eof, &supp);
+       return lprocfs_uint_seq_show(m, &supp);
 }
 
-static int lprocfs_wr_elc(struct file *file, const char *buffer,
-                              unsigned long count, void *data)
+static ssize_t lprocfs_elc_seq_write(struct file *file, const char *buffer,
+                                    size_t count, loff_t *off)
 {
-       struct ldlm_namespace *ns = data;
+       struct ldlm_namespace *ns = ((struct seq_file *)file->private_data)->private;
        unsigned int supp = -1;
        int rc;
 
@@ -296,31 +313,38 @@ static int lprocfs_wr_elc(struct file *file, const char *buffer,
                ns->ns_connect_flags |= OBD_CONNECT_CANCELSET;
        return count;
 }
+LPROC_SEQ_FOPS(lprocfs_elc);
 
 void ldlm_namespace_proc_unregister(struct ldlm_namespace *ns)
 {
-        struct proc_dir_entry *dir;
-
-        dir = lprocfs_srch(ldlm_ns_proc_dir, ldlm_ns_name(ns));
-        if (dir == NULL) {
+       if (ns->ns_proc_dir_entry == NULL)
                 CERROR("dlm namespace %s has no procfs dir?\n",
                        ldlm_ns_name(ns));
-        } else {
-                lprocfs_remove(&dir);
-        }
+       else
+               lprocfs_remove(&ns->ns_proc_dir_entry);
 
-        if (ns->ns_stats != NULL)
-                lprocfs_free_stats(&ns->ns_stats);
+       if (ns->ns_stats != NULL)
+               lprocfs_free_stats(&ns->ns_stats);
 }
 
 int ldlm_namespace_proc_register(struct ldlm_namespace *ns)
 {
-        struct lprocfs_vars lock_vars[2];
+       struct lprocfs_seq_vars lock_vars[2];
         char lock_name[MAX_STRING_SIZE + 1];
+       struct proc_dir_entry *ns_pde;
 
         LASSERT(ns != NULL);
         LASSERT(ns->ns_rs_hash != NULL);
 
+       if (ns->ns_proc_dir_entry != NULL) {
+               ns_pde = ns->ns_proc_dir_entry;
+       } else {
+               ns_pde = proc_mkdir(ldlm_ns_name(ns), ldlm_ns_proc_dir);
+               if (ns_pde == NULL)
+                       return -ENOMEM;
+               ns->ns_proc_dir_entry = ns_pde;
+       }
+
         ns->ns_stats = lprocfs_alloc_stats(LDLM_NSS_LAST, 0);
         if (ns->ns_stats == NULL)
                 return -ENOMEM;
@@ -333,88 +357,35 @@ int ldlm_namespace_proc_register(struct ldlm_namespace *ns)
         memset(lock_vars, 0, sizeof(lock_vars));
         lock_vars[0].name = lock_name;
 
-        snprintf(lock_name, MAX_STRING_SIZE, "%s/resource_count",
-                 ldlm_ns_name(ns));
-        lock_vars[0].data = ns;
-        lock_vars[0].read_fptr = lprocfs_rd_ns_resources;
-        lprocfs_add_vars(ldlm_ns_proc_dir, lock_vars, 0);
-
-        snprintf(lock_name, MAX_STRING_SIZE, "%s/lock_count",
-                 ldlm_ns_name(ns));
-        lock_vars[0].data = ns;
-        lock_vars[0].read_fptr = lprocfs_rd_ns_locks;
-        lprocfs_add_vars(ldlm_ns_proc_dir, lock_vars, 0);
-
-        if (ns_is_client(ns)) {
-                snprintf(lock_name, MAX_STRING_SIZE, "%s/lock_unused_count",
-                         ldlm_ns_name(ns));
-                lock_vars[0].data = &ns->ns_nr_unused;
-                lock_vars[0].read_fptr = lprocfs_rd_uint;
-                lprocfs_add_vars(ldlm_ns_proc_dir, lock_vars, 0);
-
-                snprintf(lock_name, MAX_STRING_SIZE, "%s/lru_size",
-                         ldlm_ns_name(ns));
-                lock_vars[0].data = ns;
-                lock_vars[0].read_fptr = lprocfs_rd_lru_size;
-                lock_vars[0].write_fptr = lprocfs_wr_lru_size;
-                lprocfs_add_vars(ldlm_ns_proc_dir, lock_vars, 0);
-
-                snprintf(lock_name, MAX_STRING_SIZE, "%s/lru_max_age",
-                         ldlm_ns_name(ns));
-                lock_vars[0].data = &ns->ns_max_age;
-                lock_vars[0].read_fptr = lprocfs_rd_uint;
-                lock_vars[0].write_fptr = lprocfs_wr_uint;
-                lprocfs_add_vars(ldlm_ns_proc_dir, lock_vars, 0);
-
-               snprintf(lock_name, MAX_STRING_SIZE, "%s/early_lock_cancel",
-                        ldlm_ns_name(ns));
-               lock_vars[0].data = ns;
-               lock_vars[0].read_fptr = lprocfs_rd_elc;
-               lock_vars[0].write_fptr = lprocfs_wr_elc;
-               lprocfs_add_vars(ldlm_ns_proc_dir, lock_vars, 0);
-        } else {
-                snprintf(lock_name, MAX_STRING_SIZE, "%s/ctime_age_limit",
-                         ldlm_ns_name(ns));
-                lock_vars[0].data = &ns->ns_ctime_age_limit;
-                lock_vars[0].read_fptr = lprocfs_rd_uint;
-                lock_vars[0].write_fptr = lprocfs_wr_uint;
-                lprocfs_add_vars(ldlm_ns_proc_dir, lock_vars, 0);
-
-                snprintf(lock_name, MAX_STRING_SIZE, "%s/lock_timeouts",
-                         ldlm_ns_name(ns));
-                lock_vars[0].data = &ns->ns_timeouts;
-                lock_vars[0].read_fptr = lprocfs_rd_uint;
-                lprocfs_add_vars(ldlm_ns_proc_dir, lock_vars, 0);
-
-                snprintf(lock_name, MAX_STRING_SIZE, "%s/max_nolock_bytes",
-                         ldlm_ns_name(ns));
-                lock_vars[0].data = &ns->ns_max_nolock_size;
-                lock_vars[0].read_fptr = lprocfs_rd_uint;
-                lock_vars[0].write_fptr = lprocfs_wr_uint;
-                lprocfs_add_vars(ldlm_ns_proc_dir, lock_vars, 0);
-
-                snprintf(lock_name, MAX_STRING_SIZE, "%s/contention_seconds",
-                         ldlm_ns_name(ns));
-                lock_vars[0].data = &ns->ns_contention_time;
-                lock_vars[0].read_fptr = lprocfs_rd_uint;
-                lock_vars[0].write_fptr = lprocfs_wr_uint;
-                lprocfs_add_vars(ldlm_ns_proc_dir, lock_vars, 0);
-
-                snprintf(lock_name, MAX_STRING_SIZE, "%s/contended_locks",
-                         ldlm_ns_name(ns));
-                lock_vars[0].data = &ns->ns_contended_locks;
-                lock_vars[0].read_fptr = lprocfs_rd_uint;
-                lock_vars[0].write_fptr = lprocfs_wr_uint;
-                lprocfs_add_vars(ldlm_ns_proc_dir, lock_vars, 0);
-
-                snprintf(lock_name, MAX_STRING_SIZE, "%s/max_parallel_ast",
-                         ldlm_ns_name(ns));
-                lock_vars[0].data = &ns->ns_max_parallel_ast;
-                lock_vars[0].read_fptr = lprocfs_rd_uint;
-                lock_vars[0].write_fptr = lprocfs_wr_uint;
-                lprocfs_add_vars(ldlm_ns_proc_dir, lock_vars, 0);
-        }
-        return 0;
+       ldlm_add_var(&lock_vars[0], ns_pde, "resource_count", ns,
+                    &lprocfs_ns_resources_fops);
+       ldlm_add_var(&lock_vars[0], ns_pde, "lock_count", ns,
+                    &lprocfs_ns_locks_fops);
+
+       if (ns_is_client(ns)) {
+               ldlm_add_var(&lock_vars[0], ns_pde, "lock_unused_count",
+                            &ns->ns_nr_unused, &ldlm_uint_fops);
+               ldlm_add_var(&lock_vars[0], ns_pde, "lru_size", ns,
+                            &lprocfs_lru_size_fops);
+               ldlm_add_var(&lock_vars[0], ns_pde, "lru_max_age",
+                            &ns->ns_max_age, &ldlm_rw_uint_fops);
+               ldlm_add_var(&lock_vars[0], ns_pde, "early_lock_cancel",
+                            ns, &lprocfs_elc_fops);
+       } else {
+               ldlm_add_var(&lock_vars[0], ns_pde, "ctime_age_limit",
+                            &ns->ns_ctime_age_limit, &ldlm_rw_uint_fops);
+               ldlm_add_var(&lock_vars[0], ns_pde, "lock_timeouts",
+                            &ns->ns_timeouts, &ldlm_uint_fops);
+               ldlm_add_var(&lock_vars[0], ns_pde, "max_nolock_bytes",
+                            &ns->ns_max_nolock_size, &ldlm_rw_uint_fops);
+               ldlm_add_var(&lock_vars[0], ns_pde, "contention_seconds",
+                            &ns->ns_contention_time, &ldlm_rw_uint_fops);
+               ldlm_add_var(&lock_vars[0], ns_pde, "contended_locks",
+                            &ns->ns_contended_locks, &ldlm_rw_uint_fops);
+               ldlm_add_var(&lock_vars[0], ns_pde, "max_parallel_ast",
+                            &ns->ns_max_parallel_ast, &ldlm_rw_uint_fops);
+       }
+       return 0;
 }
 #undef MAX_STRING_SIZE
 #else /* LPROCFS */
@@ -448,22 +419,22 @@ static unsigned ldlm_res_hop_fid_hash(cfs_hash_t *hs,
         fid.f_oid = (__u32)id->name[LUSTRE_RES_ID_VER_OID_OFF];
         fid.f_ver = (__u32)(id->name[LUSTRE_RES_ID_VER_OID_OFF] >> 32);
 
-        hash = fid_flatten32(&fid);
-        hash += (hash >> 4) + (hash << 12); /* mixing oid and seq */
-        if (id->name[LUSTRE_RES_ID_HSH_OFF] != 0) {
-                val = id->name[LUSTRE_RES_ID_HSH_OFF];
-                hash += (val >> 5) + (val << 11);
-        } else {
-                val = fid_oid(&fid);
-        }
-        hash = cfs_hash_long(hash, hs->hs_bkt_bits);
-        /* give me another random factor */
-        hash -= cfs_hash_long((unsigned long)hs, val % 11 + 3);
+       hash = fid_flatten32(&fid);
+       hash += (hash >> 4) + (hash << 12); /* mixing oid and seq */
+       if (id->name[LUSTRE_RES_ID_HSH_OFF] != 0) {
+               val = id->name[LUSTRE_RES_ID_HSH_OFF];
+               hash += (val >> 5) + (val << 11);
+       } else {
+               val = fid_oid(&fid);
+       }
+       hash = hash_long(hash, hs->hs_bkt_bits);
+       /* give me another random factor */
+       hash -= hash_long((unsigned long)hs, val % 11 + 3);
 
-        hash <<= hs->hs_cur_bits - hs->hs_bkt_bits;
-        hash |= ldlm_res_hop_hash(hs, key, CFS_HASH_NBKT(hs) - 1);
+       hash <<= hs->hs_cur_bits - hs->hs_bkt_bits;
+       hash |= ldlm_res_hop_hash(hs, key, CFS_HASH_NBKT(hs) - 1);
 
-        return hash & mask;
+       return hash & mask;
 }
 
 static void *ldlm_res_hop_key(cfs_hlist_node_t *hnode)
@@ -650,15 +621,15 @@ struct ldlm_namespace *ldlm_namespace_new(struct obd_device *obd, char *name,
         ns->ns_appetite = apt;
         ns->ns_client   = client;
 
-        CFS_INIT_LIST_HEAD(&ns->ns_list_chain);
-        CFS_INIT_LIST_HEAD(&ns->ns_unused_list);
+       CFS_INIT_LIST_HEAD(&ns->ns_list_chain);
+       CFS_INIT_LIST_HEAD(&ns->ns_unused_list);
        spin_lock_init(&ns->ns_lock);
-        cfs_atomic_set(&ns->ns_bref, 0);
-        cfs_waitq_init(&ns->ns_waitq);
+       atomic_set(&ns->ns_bref, 0);
+       init_waitqueue_head(&ns->ns_waitq);
 
-        ns->ns_max_nolock_size    = NS_DEFAULT_MAX_NOLOCK_BYTES;
-        ns->ns_contention_time    = NS_DEFAULT_CONTENTION_SECONDS;
-        ns->ns_contended_locks    = NS_DEFAULT_CONTENDED_LOCKS;
+       ns->ns_max_nolock_size    = NS_DEFAULT_MAX_NOLOCK_BYTES;
+       ns->ns_contention_time    = NS_DEFAULT_CONTENTION_SECONDS;
+       ns->ns_contended_locks    = NS_DEFAULT_CONTENDED_LOCKS;
 
         ns->ns_max_parallel_ast   = LDLM_DEFAULT_PARALLEL_AST_LIMIT;
         ns->ns_nr_unused          = 0;
@@ -675,7 +646,7 @@ struct ldlm_namespace *ldlm_namespace_new(struct obd_device *obd, char *name,
                 GOTO(out_hash, rc);
         }
 
-        idx = cfs_atomic_read(ldlm_namespace_nr(client));
+        idx = ldlm_namespace_nr_read(client);
         rc = ldlm_pool_init(&ns->ns_pool, ns, idx, client);
         if (rc) {
                 CERROR("Can't initialize lock pool, rc %d\n", rc);
@@ -723,12 +694,12 @@ static void cleanup_resource(struct ldlm_resource *res, cfs_list_t *q,
                 cfs_list_for_each(tmp, q) {
                         lock = cfs_list_entry(tmp, struct ldlm_lock,
                                               l_res_link);
-                        if (lock->l_flags & LDLM_FL_CLEANED) {
+                       if (ldlm_is_cleaned(lock)) {
                                 lock = NULL;
                                 continue;
                         }
                         LDLM_LOCK_GET(lock);
-                        lock->l_flags |= LDLM_FL_CLEANED;
+                       ldlm_set_cleaned(lock);
                         break;
                 }
 
@@ -739,13 +710,13 @@ static void cleanup_resource(struct ldlm_resource *res, cfs_list_t *q,
 
                 /* Set CBPENDING so nothing in the cancellation path
                 * can match this lock. */
-                lock->l_flags |= LDLM_FL_CBPENDING;
-                lock->l_flags |= LDLM_FL_FAILED;
+               ldlm_set_cbpending(lock);
+               ldlm_set_failed(lock);
                 lock->l_flags |= flags;
 
                 /* ... without sending a CANCEL message for local_only. */
                 if (local_only)
-                        lock->l_flags |= LDLM_FL_LOCAL_ONLY;
+                       ldlm_set_local_only(lock);
 
                 if (local_only && (lock->l_readers || lock->l_writers)) {
                         /* This is a little bit gross, but much better than the
@@ -754,8 +725,15 @@ static void cleanup_resource(struct ldlm_resource *res, cfs_list_t *q,
                          * will go away ... */
                         unlock_res(res);
                         LDLM_DEBUG(lock, "setting FL_LOCAL_ONLY");
+                       if (lock->l_flags & LDLM_FL_FAIL_LOC) {
+                               schedule_timeout_and_set_state(
+                                       TASK_UNINTERRUPTIBLE,
+                                       cfs_time_seconds(4));
+                               set_current_state(TASK_RUNNING);
+                       }
                         if (lock->l_completion_ast)
-                                lock->l_completion_ast(lock, 0, NULL);
+                               lock->l_completion_ast(lock,
+                                                      LDLM_FL_FAILED, NULL);
                         LDLM_LOCK_RELEASE(lock);
                         continue;
                 }
@@ -793,26 +771,19 @@ static int ldlm_resource_clean(cfs_hash_t *hs, cfs_hash_bd_t *bd,
 }
 
 static int ldlm_resource_complain(cfs_hash_t *hs, cfs_hash_bd_t *bd,
-                                  cfs_hlist_node_t *hnode, void *arg)
+                                 cfs_hlist_node_t *hnode, void *arg)
 {
-        struct ldlm_resource  *res = cfs_hash_object(hs, hnode);
+       struct ldlm_resource  *res = cfs_hash_object(hs, hnode);
 
        lock_res(res);
-        CERROR("Namespace %s resource refcount nonzero "
-               "(%d) after lock cleanup; forcing "
-               "cleanup.\n",
-               ldlm_ns_name(ldlm_res_to_ns(res)),
-               cfs_atomic_read(&res->lr_refcount) - 1);
-
-        CERROR("Resource: %p ("LPU64"/"LPU64"/"LPU64"/"
-               LPU64") (rc: %d)\n", res,
-               res->lr_name.name[0], res->lr_name.name[1],
-               res->lr_name.name[2], res->lr_name.name[3],
-               cfs_atomic_read(&res->lr_refcount) - 1);
+       CERROR("%s: namespace resource "DLDLMRES" (%p) refcount nonzero "
+              "(%d) after lock cleanup; forcing cleanup.\n",
+              ldlm_ns_name(ldlm_res_to_ns(res)), PLDLMRES(res), res,
+              atomic_read(&res->lr_refcount) - 1);
 
        ldlm_resource_dump(D_ERROR, res);
        unlock_res(res);
-        return 0;
+       return 0;
 }
 
 /**
@@ -842,46 +813,46 @@ EXPORT_SYMBOL(ldlm_namespace_cleanup);
  */
 static int __ldlm_namespace_free(struct ldlm_namespace *ns, int force)
 {
-        ENTRY;
+       ENTRY;
 
-        /* At shutdown time, don't call the cancellation callback */
-        ldlm_namespace_cleanup(ns, force ? LDLM_FL_LOCAL_ONLY : 0);
+       /* At shutdown time, don't call the cancellation callback */
+       ldlm_namespace_cleanup(ns, force ? LDLM_FL_LOCAL_ONLY : 0);
 
-        if (cfs_atomic_read(&ns->ns_bref) > 0) {
-                struct l_wait_info lwi = LWI_INTR(LWI_ON_SIGNAL_NOOP, NULL);
-                int rc;
-                CDEBUG(D_DLMTRACE,
-                       "dlm namespace %s free waiting on refcount %d\n",
-                       ldlm_ns_name(ns), cfs_atomic_read(&ns->ns_bref));
+       if (atomic_read(&ns->ns_bref) > 0) {
+               struct l_wait_info lwi = LWI_INTR(LWI_ON_SIGNAL_NOOP, NULL);
+               int rc;
+               CDEBUG(D_DLMTRACE,
+                      "dlm namespace %s free waiting on refcount %d\n",
+                      ldlm_ns_name(ns), atomic_read(&ns->ns_bref));
 force_wait:
-                if (force)
-                        lwi = LWI_TIMEOUT(obd_timeout * CFS_HZ / 4, NULL, NULL);
-
-                rc = l_wait_event(ns->ns_waitq,
-                                  cfs_atomic_read(&ns->ns_bref) == 0, &lwi);
-
-                /* Forced cleanups should be able to reclaim all references,
-                 * so it's safe to wait forever... we can't leak locks... */
-                if (force && rc == -ETIMEDOUT) {
-                        LCONSOLE_ERROR("Forced cleanup waiting for %s "
-                                       "namespace with %d resources in use, "
-                                       "(rc=%d)\n", ldlm_ns_name(ns),
-                                       cfs_atomic_read(&ns->ns_bref), rc);
-                        GOTO(force_wait, rc);
-                }
+               if (force)
+                       lwi = LWI_TIMEOUT(obd_timeout * HZ / 4, NULL, NULL);
+
+               rc = l_wait_event(ns->ns_waitq,
+                                 atomic_read(&ns->ns_bref) == 0, &lwi);
+
+               /* Forced cleanups should be able to reclaim all references,
+                * so it's safe to wait forever... we can't leak locks... */
+               if (force && rc == -ETIMEDOUT) {
+                       LCONSOLE_ERROR("Forced cleanup waiting for %s "
+                                      "namespace with %d resources in use, "
+                                      "(rc=%d)\n", ldlm_ns_name(ns),
+                                      atomic_read(&ns->ns_bref), rc);
+                       GOTO(force_wait, rc);
+               }
 
-                if (cfs_atomic_read(&ns->ns_bref)) {
-                        LCONSOLE_ERROR("Cleanup waiting for %s namespace "
-                                       "with %d resources in use, (rc=%d)\n",
-                                       ldlm_ns_name(ns),
-                                       cfs_atomic_read(&ns->ns_bref), rc);
-                        RETURN(ELDLM_NAMESPACE_EXISTS);
-                }
-                CDEBUG(D_DLMTRACE, "dlm namespace %s free done waiting\n",
-                       ldlm_ns_name(ns));
-        }
+               if (atomic_read(&ns->ns_bref)) {
+                       LCONSOLE_ERROR("Cleanup waiting for %s namespace "
+                                      "with %d resources in use, (rc=%d)\n",
+                                      ldlm_ns_name(ns),
+                                      atomic_read(&ns->ns_bref), rc);
+                       RETURN(ELDLM_NAMESPACE_EXISTS);
+               }
+               CDEBUG(D_DLMTRACE, "dlm namespace %s free done waiting\n",
+                      ldlm_ns_name(ns));
+       }
 
-        RETURN(ELDLM_OK);
+       RETURN(ELDLM_OK);
 }
 
 /**
@@ -988,14 +959,20 @@ EXPORT_SYMBOL(ldlm_namespace_free);
 
 void ldlm_namespace_get(struct ldlm_namespace *ns)
 {
-        cfs_atomic_inc(&ns->ns_bref);
+       atomic_inc(&ns->ns_bref);
 }
 EXPORT_SYMBOL(ldlm_namespace_get);
 
+/* This is only for callers that care about refcount */
+int ldlm_namespace_get_return(struct ldlm_namespace *ns)
+{
+       return atomic_inc_return(&ns->ns_bref);
+}
+
 void ldlm_namespace_put(struct ldlm_namespace *ns)
 {
-       if (cfs_atomic_dec_and_lock(&ns->ns_bref, &ns->ns_lock)) {
-               cfs_waitq_signal(&ns->ns_waitq);
+       if (atomic_dec_and_lock(&ns->ns_bref, &ns->ns_lock)) {
+               wake_up(&ns->ns_waitq);
                spin_unlock(&ns->ns_lock);
        }
 }
@@ -1006,8 +983,8 @@ void ldlm_namespace_register(struct ldlm_namespace *ns, ldlm_side_t client)
 {
        mutex_lock(ldlm_namespace_lock(client));
        LASSERT(cfs_list_empty(&ns->ns_list_chain));
-       cfs_list_add(&ns->ns_list_chain, ldlm_namespace_list(client));
-       cfs_atomic_inc(ldlm_namespace_nr(client));
+       cfs_list_add(&ns->ns_list_chain, ldlm_namespace_inactive_list(client));
+       ldlm_namespace_nr_inc(client);
        mutex_unlock(ldlm_namespace_lock(client));
 }
 
@@ -1020,49 +997,60 @@ void ldlm_namespace_unregister(struct ldlm_namespace *ns, ldlm_side_t client)
         * using list_empty(&ns->ns_list_chain). This is why it is
         * important to use list_del_init() here. */
        cfs_list_del_init(&ns->ns_list_chain);
-       cfs_atomic_dec(ldlm_namespace_nr(client));
+       ldlm_namespace_nr_dec(client);
        mutex_unlock(ldlm_namespace_lock(client));
 }
 
 /** Should be called with ldlm_namespace_lock(client) taken. */
-void ldlm_namespace_move_locked(struct ldlm_namespace *ns, ldlm_side_t client)
+void ldlm_namespace_move_to_active_locked(struct ldlm_namespace *ns,
+                                      ldlm_side_t client)
 {
-        LASSERT(!cfs_list_empty(&ns->ns_list_chain));
-        LASSERT_MUTEX_LOCKED(ldlm_namespace_lock(client));
-        cfs_list_move_tail(&ns->ns_list_chain, ldlm_namespace_list(client));
+       LASSERT(!cfs_list_empty(&ns->ns_list_chain));
+       LASSERT(mutex_is_locked(ldlm_namespace_lock(client)));
+       cfs_list_move_tail(&ns->ns_list_chain, ldlm_namespace_list(client));
+}
+
+/** Should be called with ldlm_namespace_lock(client) taken. */
+void ldlm_namespace_move_to_inactive_locked(struct ldlm_namespace *ns,
+                                        ldlm_side_t client)
+{
+       LASSERT(!cfs_list_empty(&ns->ns_list_chain));
+       LASSERT(mutex_is_locked(ldlm_namespace_lock(client)));
+       cfs_list_move_tail(&ns->ns_list_chain,
+                          ldlm_namespace_inactive_list(client));
 }
 
 /** Should be called with ldlm_namespace_lock(client) taken. */
 struct ldlm_namespace *ldlm_namespace_first_locked(ldlm_side_t client)
 {
-        LASSERT_MUTEX_LOCKED(ldlm_namespace_lock(client));
-        LASSERT(!cfs_list_empty(ldlm_namespace_list(client)));
-        return container_of(ldlm_namespace_list(client)->next,
-                struct ldlm_namespace, ns_list_chain);
+       LASSERT(mutex_is_locked(ldlm_namespace_lock(client)));
+       LASSERT(!cfs_list_empty(ldlm_namespace_list(client)));
+       return container_of(ldlm_namespace_list(client)->next,
+                           struct ldlm_namespace, ns_list_chain);
 }
 
 /** Create and initialize new resource. */
 static struct ldlm_resource *ldlm_resource_new(void)
 {
-        struct ldlm_resource *res;
-        int idx;
+       struct ldlm_resource *res;
+       int idx;
 
-        OBD_SLAB_ALLOC_PTR_GFP(res, ldlm_resource_slab, CFS_ALLOC_IO);
-        if (res == NULL)
-                return NULL;
+       OBD_SLAB_ALLOC_PTR_GFP(res, ldlm_resource_slab, GFP_NOFS);
+       if (res == NULL)
+               return NULL;
 
-        CFS_INIT_LIST_HEAD(&res->lr_granted);
-        CFS_INIT_LIST_HEAD(&res->lr_converting);
-        CFS_INIT_LIST_HEAD(&res->lr_waiting);
+       CFS_INIT_LIST_HEAD(&res->lr_granted);
+       CFS_INIT_LIST_HEAD(&res->lr_converting);
+       CFS_INIT_LIST_HEAD(&res->lr_waiting);
 
        /* Initialize interval trees for each lock mode. */
-        for (idx = 0; idx < LCK_MODE_NUM; idx++) {
-                res->lr_itree[idx].lit_size = 0;
-                res->lr_itree[idx].lit_mode = 1 << idx;
-                res->lr_itree[idx].lit_root = NULL;
-        }
+       for (idx = 0; idx < LCK_MODE_NUM; idx++) {
+               res->lr_itree[idx].lit_size = 0;
+               res->lr_itree[idx].lit_mode = 1 << idx;
+               res->lr_itree[idx].lit_root = NULL;
+       }
 
-        cfs_atomic_set(&res->lr_refcount, 1);
+       atomic_set(&res->lr_refcount, 1);
        spin_lock_init(&res->lr_lock);
        lu_ref_init(&res->lr_reference);
 
@@ -1084,10 +1072,12 @@ struct ldlm_resource *
 ldlm_resource_get(struct ldlm_namespace *ns, struct ldlm_resource *parent,
                   const struct ldlm_res_id *name, ldlm_type_t type, int create)
 {
-        cfs_hlist_node_t     *hnode;
-        struct ldlm_resource *res;
-        cfs_hash_bd_t         bd;
-        __u64                 version;
+       struct hlist_node       *hnode;
+       struct ldlm_resource    *res = NULL;
+       cfs_hash_bd_t           bd;
+       __u64                   version;
+       int                     ns_refcount = 0;
+       int                     rc;
 
         LASSERT(ns != NULL);
         LASSERT(parent == NULL);
@@ -1098,42 +1088,31 @@ ldlm_resource_get(struct ldlm_namespace *ns, struct ldlm_resource *parent,
         hnode = cfs_hash_bd_lookup_locked(ns->ns_rs_hash, &bd, (void *)name);
         if (hnode != NULL) {
                 cfs_hash_bd_unlock(ns->ns_rs_hash, &bd, 0);
-                res = cfs_hlist_entry(hnode, struct ldlm_resource, lr_hash);
-               /* Synchronize with regard to resource creation. */
-                if (ns->ns_lvbo && ns->ns_lvbo->lvbo_init) {
-                       mutex_lock(&res->lr_lvb_mutex);
-                       mutex_unlock(&res->lr_lvb_mutex);
-                }
-
-               if (unlikely(res->lr_lvb_len < 0)) {
-                       ldlm_resource_putref(res);
-                       res = NULL;
-               }
-                return res;
-        }
+               GOTO(lvbo_init, res);
+       }
 
-        version = cfs_hash_bd_version_get(&bd);
-        cfs_hash_bd_unlock(ns->ns_rs_hash, &bd, 0);
+       version = cfs_hash_bd_version_get(&bd);
+       cfs_hash_bd_unlock(ns->ns_rs_hash, &bd, 0);
 
-        if (create == 0)
-                return NULL;
+       if (create == 0)
+               return ERR_PTR(-ENOENT);
 
-        LASSERTF(type >= LDLM_MIN_TYPE && type < LDLM_MAX_TYPE,
-                 "type: %d\n", type);
-        res = ldlm_resource_new();
-        if (!res)
-                return NULL;
+       LASSERTF(type >= LDLM_MIN_TYPE && type < LDLM_MAX_TYPE,
+                "type: %d\n", type);
+       res = ldlm_resource_new();
+       if (res == NULL)
+               return ERR_PTR(-ENOMEM);
 
-        res->lr_ns_bucket  = cfs_hash_bd_extra_get(ns->ns_rs_hash, &bd);
-        res->lr_name       = *name;
-        res->lr_type       = type;
-        res->lr_most_restr = LCK_NL;
+       res->lr_ns_bucket  = cfs_hash_bd_extra_get(ns->ns_rs_hash, &bd);
+       res->lr_name       = *name;
+       res->lr_type       = type;
+       res->lr_most_restr = LCK_NL;
 
-        cfs_hash_bd_lock(ns->ns_rs_hash, &bd, 1);
-        hnode = (version == cfs_hash_bd_version_get(&bd)) ?  NULL :
-                cfs_hash_bd_lookup_locked(ns->ns_rs_hash, &bd, (void *)name);
+       cfs_hash_bd_lock(ns->ns_rs_hash, &bd, 1);
+       hnode = (version == cfs_hash_bd_version_get(&bd)) ? NULL :
+               cfs_hash_bd_lookup_locked(ns->ns_rs_hash, &bd, (void *)name);
 
-        if (hnode != NULL) {
+       if (hnode != NULL) {
                /* Someone won the race and already added the resource. */
                cfs_hash_bd_unlock(ns->ns_rs_hash, &bd, 1);
                /* Clean lu_ref for failed resource. */
@@ -1141,8 +1120,8 @@ ldlm_resource_get(struct ldlm_namespace *ns, struct ldlm_resource *parent,
                /* We have taken lr_lvb_mutex. Drop it. */
                mutex_unlock(&res->lr_lvb_mutex);
                OBD_SLAB_FREE(res, ldlm_resource_slab, sizeof *res);
-
-               res = cfs_hlist_entry(hnode, struct ldlm_resource, lr_hash);
+lvbo_init:
+               res = hlist_entry(hnode, struct ldlm_resource, lr_hash);
                /* Synchronize with regard to resource creation. */
                if (ns->ns_lvbo && ns->ns_lvbo->lvbo_init) {
                        mutex_lock(&res->lr_lvb_mutex);
@@ -1150,25 +1129,25 @@ ldlm_resource_get(struct ldlm_namespace *ns, struct ldlm_resource *parent,
                }
 
                if (unlikely(res->lr_lvb_len < 0)) {
+                       rc = res->lr_lvb_len;
                        ldlm_resource_putref(res);
-                       res = NULL;
+                       res = ERR_PTR(rc);
                }
                return res;
        }
        /* We won! Let's add the resource. */
         cfs_hash_bd_add_locked(ns->ns_rs_hash, &bd, &res->lr_hash);
-        if (cfs_hash_bd_count_get(&bd) == 1)
-                ldlm_namespace_get(ns);
+       if (cfs_hash_bd_count_get(&bd) == 1)
+               ns_refcount = ldlm_namespace_get_return(ns);
 
         cfs_hash_bd_unlock(ns->ns_rs_hash, &bd, 1);
         if (ns->ns_lvbo && ns->ns_lvbo->lvbo_init) {
-                int rc;
-
                 OBD_FAIL_TIMEOUT(OBD_FAIL_LDLM_CREATE_RESOURCE, 2);
                 rc = ns->ns_lvbo->lvbo_init(res);
                if (rc < 0) {
-                       CERROR("lvbo_init failed for resource "
-                              LPU64": rc %d\n", name->name[0], rc);
+                       CERROR("%s: lvbo_init failed for resource "LPX64":"
+                              LPX64": rc = %d\n", ns->ns_obd->obd_name,
+                              name->name[0], name->name[1], rc);
                        if (res->lr_lvb_data) {
                                OBD_FREE(res->lr_lvb_data, res->lr_lvb_len);
                                res->lr_lvb_data = NULL;
@@ -1176,25 +1155,35 @@ ldlm_resource_get(struct ldlm_namespace *ns, struct ldlm_resource *parent,
                        res->lr_lvb_len = rc;
                        mutex_unlock(&res->lr_lvb_mutex);
                        ldlm_resource_putref(res);
-                       return NULL;
+                       return ERR_PTR(rc);
                }
        }
 
        /* We create resource with locked lr_lvb_mutex. */
        mutex_unlock(&res->lr_lvb_mutex);
 
+       /* Let's see if we happened to be the very first resource in this
+        * namespace. If so, and this is a client namespace, we need to move
+        * the namespace into the active namespaces list to be patrolled by
+        * the ldlm_poold. */
+       if (ns_is_client(ns) && ns_refcount == 1) {
+               mutex_lock(ldlm_namespace_lock(LDLM_NAMESPACE_CLIENT));
+               ldlm_namespace_move_to_active_locked(ns, LDLM_NAMESPACE_CLIENT);
+               mutex_unlock(ldlm_namespace_lock(LDLM_NAMESPACE_CLIENT));
+       }
+
        return res;
 }
 EXPORT_SYMBOL(ldlm_resource_get);
 
 struct ldlm_resource *ldlm_resource_getref(struct ldlm_resource *res)
 {
-        LASSERT(res != NULL);
-        LASSERT(res != LP_POISON);
-        cfs_atomic_inc(&res->lr_refcount);
-        CDEBUG(D_INFO, "getref res: %p count: %d\n", res,
-               cfs_atomic_read(&res->lr_refcount));
-        return res;
+       LASSERT(res != NULL);
+       LASSERT(res != LP_POISON);
+       atomic_inc(&res->lr_refcount);
+       CDEBUG(D_INFO, "getref res: %p count: %d\n", res,
+              atomic_read(&res->lr_refcount));
+       return res;
 }
 
 static void __ldlm_resource_putref_final(cfs_hash_bd_t *bd,
@@ -1227,55 +1216,55 @@ static void __ldlm_resource_putref_final(cfs_hash_bd_t *bd,
 /* Returns 1 if the resource was freed, 0 if it remains. */
 int ldlm_resource_putref(struct ldlm_resource *res)
 {
-        struct ldlm_namespace *ns = ldlm_res_to_ns(res);
-        cfs_hash_bd_t   bd;
-
-        LASSERT_ATOMIC_GT_LT(&res->lr_refcount, 0, LI_POISON);
-        CDEBUG(D_INFO, "putref res: %p count: %d\n",
-               res, cfs_atomic_read(&res->lr_refcount) - 1);
-
-        cfs_hash_bd_get(ns->ns_rs_hash, &res->lr_name, &bd);
-        if (cfs_hash_bd_dec_and_lock(ns->ns_rs_hash, &bd, &res->lr_refcount)) {
-                __ldlm_resource_putref_final(&bd, res);
-                cfs_hash_bd_unlock(ns->ns_rs_hash, &bd, 1);
-                if (ns->ns_lvbo && ns->ns_lvbo->lvbo_free)
-                        ns->ns_lvbo->lvbo_free(res);
-                OBD_SLAB_FREE(res, ldlm_resource_slab, sizeof *res);
-                return 1;
-        }
-        return 0;
+       struct ldlm_namespace *ns = ldlm_res_to_ns(res);
+       cfs_hash_bd_t   bd;
+
+       LASSERT_ATOMIC_GT_LT(&res->lr_refcount, 0, LI_POISON);
+       CDEBUG(D_INFO, "putref res: %p count: %d\n",
+              res, atomic_read(&res->lr_refcount) - 1);
+
+       cfs_hash_bd_get(ns->ns_rs_hash, &res->lr_name, &bd);
+       if (cfs_hash_bd_dec_and_lock(ns->ns_rs_hash, &bd, &res->lr_refcount)) {
+               __ldlm_resource_putref_final(&bd, res);
+               cfs_hash_bd_unlock(ns->ns_rs_hash, &bd, 1);
+               if (ns->ns_lvbo && ns->ns_lvbo->lvbo_free)
+                       ns->ns_lvbo->lvbo_free(res);
+               OBD_SLAB_FREE(res, ldlm_resource_slab, sizeof *res);
+               return 1;
+       }
+       return 0;
 }
 EXPORT_SYMBOL(ldlm_resource_putref);
 
 /* Returns 1 if the resource was freed, 0 if it remains. */
 int ldlm_resource_putref_locked(struct ldlm_resource *res)
 {
-        struct ldlm_namespace *ns = ldlm_res_to_ns(res);
-
-        LASSERT_ATOMIC_GT_LT(&res->lr_refcount, 0, LI_POISON);
-        CDEBUG(D_INFO, "putref res: %p count: %d\n",
-               res, cfs_atomic_read(&res->lr_refcount) - 1);
-
-        if (cfs_atomic_dec_and_test(&res->lr_refcount)) {
-                cfs_hash_bd_t bd;
-
-                cfs_hash_bd_get(ldlm_res_to_ns(res)->ns_rs_hash,
-                                &res->lr_name, &bd);
-                __ldlm_resource_putref_final(&bd, res);
-                cfs_hash_bd_unlock(ns->ns_rs_hash, &bd, 1);
-                /* NB: ns_rs_hash is created with CFS_HASH_NO_ITEMREF,
-                 * so we should never be here while calling cfs_hash_del,
-                 * cfs_hash_for_each_nolock is the only case we can get
-                 * here, which is safe to release cfs_hash_bd_lock.
-                 */
-                if (ns->ns_lvbo && ns->ns_lvbo->lvbo_free)
-                        ns->ns_lvbo->lvbo_free(res);
-                OBD_SLAB_FREE(res, ldlm_resource_slab, sizeof *res);
+       struct ldlm_namespace *ns = ldlm_res_to_ns(res);
 
-                cfs_hash_bd_lock(ns->ns_rs_hash, &bd, 1);
-                return 1;
-        }
-        return 0;
+       LASSERT_ATOMIC_GT_LT(&res->lr_refcount, 0, LI_POISON);
+       CDEBUG(D_INFO, "putref res: %p count: %d\n",
+              res, atomic_read(&res->lr_refcount) - 1);
+
+       if (atomic_dec_and_test(&res->lr_refcount)) {
+               cfs_hash_bd_t bd;
+
+               cfs_hash_bd_get(ldlm_res_to_ns(res)->ns_rs_hash,
+                               &res->lr_name, &bd);
+               __ldlm_resource_putref_final(&bd, res);
+               cfs_hash_bd_unlock(ns->ns_rs_hash, &bd, 1);
+               /* NB: ns_rs_hash is created with CFS_HASH_NO_ITEMREF,
+                * so we should never be here while calling cfs_hash_del,
+                * cfs_hash_for_each_nolock is the only case we can get
+                * here, which is safe to release cfs_hash_bd_lock.
+                */
+               if (ns->ns_lvbo && ns->ns_lvbo->lvbo_free)
+                       ns->ns_lvbo->lvbo_free(res);
+               OBD_SLAB_FREE(res, ldlm_resource_slab, sizeof *res);
+
+               cfs_hash_bd_lock(ns->ns_rs_hash, &bd, 1);
+               return 1;
+       }
+       return 0;
 }
 
 /**
@@ -1284,18 +1273,18 @@ int ldlm_resource_putref_locked(struct ldlm_resource *res)
 void ldlm_resource_add_lock(struct ldlm_resource *res, cfs_list_t *head,
                             struct ldlm_lock *lock)
 {
-        check_res_locked(res);
+       check_res_locked(res);
 
-        LDLM_DEBUG(lock, "About to add this lock:\n");
+       LDLM_DEBUG(lock, "About to add this lock:\n");
 
-        if (lock->l_destroyed) {
-                CDEBUG(D_OTHER, "Lock destroyed, not adding to resource\n");
-                return;
-        }
+       if (ldlm_is_destroyed(lock)) {
+               CDEBUG(D_OTHER, "Lock destroyed, not adding to resource\n");
+               return;
+       }
 
-        LASSERT(cfs_list_empty(&lock->l_res_link));
+       LASSERT(cfs_list_empty(&lock->l_res_link));
 
-        cfs_list_add_tail(&lock->l_res_link, head);
+       cfs_list_add_tail(&lock->l_res_link, head);
 }
 
 /**
@@ -1313,10 +1302,10 @@ void ldlm_resource_insert_lock_after(struct ldlm_lock *original,
         ldlm_resource_dump(D_INFO, res);
         LDLM_DEBUG(new, "About to insert this lock after %p:\n", original);
 
-        if (new->l_destroyed) {
-                CDEBUG(D_OTHER, "Lock destroyed, not adding to resource\n");
-                goto out;
-        }
+       if (ldlm_is_destroyed(new)) {
+               CDEBUG(D_OTHER, "Lock destroyed, not adding to resource\n");
+               goto out;
+       }
 
         LASSERT(cfs_list_empty(&new->l_res_link));
 
@@ -1385,19 +1374,19 @@ static int ldlm_res_hash_dump(cfs_hash_t *hs, cfs_hash_bd_t *bd,
  */
 void ldlm_namespace_dump(int level, struct ldlm_namespace *ns)
 {
-        if (!((libcfs_debug | D_ERROR) & level))
-                return;
+       if (!((libcfs_debug | D_ERROR) & level))
+               return;
 
-        CDEBUG(level, "--- Namespace: %s (rc: %d, side: %s)\n",
-               ldlm_ns_name(ns), cfs_atomic_read(&ns->ns_bref),
-               ns_is_client(ns) ? "client" : "server");
+       CDEBUG(level, "--- Namespace: %s (rc: %d, side: %s)\n",
+              ldlm_ns_name(ns), atomic_read(&ns->ns_bref),
+              ns_is_client(ns) ? "client" : "server");
 
-        if (cfs_time_before(cfs_time_current(), ns->ns_next_dump))
-                return;
+       if (cfs_time_before(cfs_time_current(), ns->ns_next_dump))
+               return;
 
-        cfs_hash_for_each_nolock(ns->ns_rs_hash,
-                                 ldlm_res_hash_dump,
-                                 (void *)(unsigned long)level);
+       cfs_hash_for_each_nolock(ns->ns_rs_hash,
+                                ldlm_res_hash_dump,
+                                (void *)(unsigned long)level);
        spin_lock(&ns->ns_lock);
        ns->ns_next_dump = cfs_time_shift(10);
        spin_unlock(&ns->ns_lock);
@@ -1409,23 +1398,21 @@ EXPORT_SYMBOL(ldlm_namespace_dump);
  */
 void ldlm_resource_dump(int level, struct ldlm_resource *res)
 {
-        struct ldlm_lock *lock;
-        unsigned int granted = 0;
+       struct ldlm_lock *lock;
+       unsigned int granted = 0;
 
-        CLASSERT(RES_NAME_SIZE == 4);
+       CLASSERT(RES_NAME_SIZE == 4);
 
-        if (!((libcfs_debug | D_ERROR) & level))
-                return;
+       if (!((libcfs_debug | D_ERROR) & level))
+               return;
 
-        CDEBUG(level, "--- Resource: %p ("LPU64"/"LPU64"/"LPU64"/"LPU64
-               ") (rc: %d)\n", res, res->lr_name.name[0], res->lr_name.name[1],
-               res->lr_name.name[2], res->lr_name.name[3],
-               cfs_atomic_read(&res->lr_refcount));
+       CDEBUG(level, "--- Resource: "DLDLMRES" (%p) refcount = %d\n",
+              PLDLMRES(res), res, atomic_read(&res->lr_refcount));
 
-        if (!cfs_list_empty(&res->lr_granted)) {
-                CDEBUG(level, "Granted locks (in reverse order):\n");
-                cfs_list_for_each_entry_reverse(lock, &res->lr_granted,
-                                                l_res_link) {
+       if (!cfs_list_empty(&res->lr_granted)) {
+               CDEBUG(level, "Granted locks (in reverse order):\n");
+               cfs_list_for_each_entry_reverse(lock, &res->lr_granted,
+                                               l_res_link) {
                         LDLM_DEBUG_LIMIT(level, lock, "###");
                         if (!(level & D_CANTMASK) &&
                             ++granted > ldlm_dump_granted_max) {