imp->imp_connect_flags_orig = data->ocd_connect_flags;
}
- rc = ptlrpc_connect_import(imp, NULL);
+ rc = ptlrpc_connect_import(imp);
if (rc != 0) {
LASSERT (imp->imp_state == LUSTRE_IMP_DISCON);
GOTO(out_ldlm, rc);
}
EXPORT_SYMBOL(target_client_add_cb);
+#ifdef __KERNEL__
static void
-target_start_and_reset_recovery_timer(struct obd_device *obd,
- struct ptlrpc_request *req,
- int new_client);
+check_and_start_recovery_timer(struct obd_device *obd,
+ struct ptlrpc_request *req, int new_client);
+#else
+static inline void
+check_and_start_recovery_timer(struct obd_device *obd,
+ struct ptlrpc_request *req, int new_client)
+{
+}
+#endif
int target_handle_connect(struct ptlrpc_request *req)
{
export, (long)cfs_time_current_sec(),
export ? (long)export->exp_last_request_time : 0);
- /* If this is the first time a client connects,
- * reset the recovery timer */
+ /* If this is the first time a client connects, reset the recovery
+ * timer */
if (rc == 0 && target->obd_recovering)
- target_start_and_reset_recovery_timer(target, req, !export);
+ check_and_start_recovery_timer(target, req, export == NULL);
/* We want to handle EALREADY but *not* -EALREADY from
* target_handle_reconnect(), return reconnection state in a flag */
&export->exp_nid_hash);
}
- cfs_spin_lock(&target->obd_recovery_task_lock);
if (target->obd_recovering && !export->exp_in_recovery) {
+ int has_transno;
+ __u64 transno = data->ocd_transno;
+
cfs_spin_lock(&export->exp_lock);
export->exp_in_recovery = 1;
export->exp_req_replay_needed = 1;
export->exp_lock_replay_needed = 1;
cfs_spin_unlock(&export->exp_lock);
- if ((lustre_msg_get_op_flags(req->rq_reqmsg) & MSG_CONNECT_TRANSNO)
- && (data->ocd_transno == 0))
+
+ has_transno = !!(lustre_msg_get_op_flags(req->rq_reqmsg) &
+ MSG_CONNECT_TRANSNO);
+ if (has_transno && transno == 0)
CWARN("Connect with zero transno!\n");
- if ((lustre_msg_get_op_flags(req->rq_reqmsg) & MSG_CONNECT_TRANSNO)
- && data->ocd_transno < target->obd_next_recovery_transno &&
- data->ocd_transno > target->obd_last_committed)
- target->obd_next_recovery_transno = data->ocd_transno;
- target->obd_connected_clients++;
+ if (has_transno && transno > 0 &&
+ transno < target->obd_next_recovery_transno &&
+ transno > target->obd_last_committed) {
+ /* another way is to use cmpxchg() so it will be
+ * lock free */
+ cfs_spin_lock(&target->obd_recovery_task_lock);
+ if (transno < target->obd_next_recovery_transno)
+ target->obd_next_recovery_transno = transno;
+ cfs_spin_unlock(&target->obd_recovery_task_lock);
+ }
+
cfs_atomic_inc(&target->obd_req_replay_clients);
cfs_atomic_inc(&target->obd_lock_replay_clients);
- if (target->obd_connected_clients ==
+ if (cfs_atomic_inc_return(&target->obd_connected_clients) ==
target->obd_max_recoverable_clients)
cfs_waitq_signal(&target->obd_next_transno_waitq);
}
- cfs_spin_unlock(&target->obd_recovery_task_lock);
/* Tell the client we're in recovery, when client is involved in it. */
if (target->obd_recovering)
"%d recovered and %d %s evicted.\n", obd->obd_name,
(int)elapsed_time / 60, (int)elapsed_time % 60,
obd->obd_max_recoverable_clients,
- obd->obd_connected_clients, obd->obd_stale_clients,
+ cfs_atomic_read(&obd->obd_connected_clients),
+ obd->obd_stale_clients,
obd->obd_stale_clients == 1 ? "was" : "were");
ldlm_reprocess_all_ns(obd->obd_namespace);
target_request_copy_put(req);
}
}
-#endif
/* Called from a cleanup function if the device is being cleaned up
forcefully. The exports should all have been disconnected already,
cfs_timer_disarm(&obd->obd_recovery_timer);
}
-/* extend = 1 means require at least "duration" seconds left in the timer,
- extend = 0 means set the total duration (start_recovery_timer) */
-static void reset_recovery_timer(struct obd_device *obd, int duration,
- int extend)
+static void target_start_recovery_timer(struct obd_device *obd)
{
- cfs_time_t now = cfs_time_current_sec();
- cfs_duration_t left;
+ if (obd->obd_recovery_start != 0)
+ return;
- cfs_spin_lock(&obd->obd_recovery_task_lock);
+ cfs_spin_lock(&obd->obd_dev_lock);
if (!obd->obd_recovering || obd->obd_abort_recovery) {
- cfs_spin_unlock(&obd->obd_recovery_task_lock);
+ cfs_spin_unlock(&obd->obd_dev_lock);
return;
}
- left = cfs_time_sub(obd->obd_recovery_end, now);
+ LASSERT(obd->obd_recovery_timeout != 0);
- if (extend && (duration > left))
- obd->obd_recovery_timeout += duration - left;
- else if (!extend && (duration > obd->obd_recovery_timeout))
- /* Track the client's largest expected replay time */
- obd->obd_recovery_timeout = duration;
+ if (obd->obd_recovery_start != 0) {
+ cfs_spin_unlock(&obd->obd_dev_lock);
+ return;
+ }
- /* Hard limit of obd_recovery_time_hard which should not happen */
- if (obd->obd_recovery_timeout > obd->obd_recovery_time_hard)
- obd->obd_recovery_timeout = obd->obd_recovery_time_hard;
+ cfs_timer_arm(&obd->obd_recovery_timer,
+ cfs_time_shift(obd->obd_recovery_timeout));
+ obd->obd_recovery_start = cfs_time_current_sec();
+ cfs_spin_unlock(&obd->obd_dev_lock);
- obd->obd_recovery_end = obd->obd_recovery_start +
- obd->obd_recovery_timeout;
- if (!cfs_timer_is_armed(&obd->obd_recovery_timer) ||
- cfs_time_before(now, obd->obd_recovery_end)) {
- left = cfs_time_sub(obd->obd_recovery_end, now);
- cfs_timer_arm(&obd->obd_recovery_timer, cfs_time_shift(left));
- }
- cfs_spin_unlock(&obd->obd_recovery_task_lock);
- CDEBUG(D_HA, "%s: recovery timer will expire in %u seconds\n",
- obd->obd_name, (unsigned)left);
+ LCONSOLE_WARN("%s: Will be in recovery for at least %d:%.02d, "
+ "or until %d client%s reconnect%s\n",
+ obd->obd_name,
+ obd->obd_recovery_timeout / 60,
+ obd->obd_recovery_timeout % 60,
+ obd->obd_max_recoverable_clients,
+ (obd->obd_max_recoverable_clients == 1) ? "" : "s",
+ (obd->obd_max_recoverable_clients == 1) ? "s": "");
}
-static void check_and_start_recovery_timer(struct obd_device *obd)
+/* extend recovery window to have extra @duration seconds at least. */
+static void extend_recovery_timer(struct obd_device *obd, int drt)
{
- cfs_spin_lock(&obd->obd_recovery_task_lock);
- if (cfs_timer_is_armed(&obd->obd_recovery_timer)) {
- cfs_spin_unlock(&obd->obd_recovery_task_lock);
+ cfs_time_t now;
+ cfs_time_t end;
+ cfs_duration_t left;
+
+ cfs_spin_lock(&obd->obd_dev_lock);
+ if (!obd->obd_recovering || obd->obd_abort_recovery) {
+ cfs_spin_unlock(&obd->obd_dev_lock);
return;
}
- CDEBUG(D_HA, "%s: starting recovery timer\n", obd->obd_name);
- obd->obd_recovery_start = cfs_time_current_sec();
- cfs_spin_unlock(&obd->obd_recovery_task_lock);
- reset_recovery_timer(obd, obd->obd_recovery_timeout, 0);
+ LASSERT(obd->obd_recovery_start != 0);
+
+ now = cfs_time_current_sec();
+ end = obd->obd_recovery_start + obd->obd_recovery_timeout;
+ left = cfs_time_sub(end, now);
+ if (left < 0) {
+ obd->obd_recovery_timeout += drt - left;
+ } else if (left < drt) {
+ drt -= left;
+ obd->obd_recovery_timeout += drt;
+ } else {
+ drt = left;
+ }
+
+ cfs_timer_arm(&obd->obd_recovery_timer, cfs_time_shift(drt));
+ cfs_spin_unlock(&obd->obd_dev_lock);
+
+ CDEBUG(D_HA, "%s: recovery timer will expire in %u seconds\n",
+ obd->obd_name, (unsigned)drt);
}
/* Reset the timer with each new client connection */
*/
static void
-target_start_and_reset_recovery_timer(struct obd_device *obd,
- struct ptlrpc_request *req,
- int new_client)
+check_and_start_recovery_timer(struct obd_device *obd,
+ struct ptlrpc_request *req,
+ int new_client)
{
int service_time = lustre_msg_get_service_time(req->rq_reqmsg);
+ struct obd_device_target *obt = &obd->u.obt;
+ struct lustre_sb_info *lsi;
if (!new_client && service_time)
/* Teach server about old server's estimates, as first guess
at_measured(&req->rq_rqbd->rqbd_service->srv_at_estimate,
service_time);
- check_and_start_recovery_timer(obd);
+ target_start_recovery_timer(obd);
/* convert the service time to rpc timeout,
* reuse service_time to limit stack usage */
/* We expect other clients to timeout within service_time, then try
* to reconnect, then try the failover server. The max delay between
* connect attempts is SWITCH_MAX + SWITCH_INC + INITIAL */
- service_time += 2 * (CONNECTION_SWITCH_MAX + CONNECTION_SWITCH_INC +
- INITIAL_CONNECT_TIMEOUT);
- if (service_time > obd->obd_recovery_timeout && !new_client)
- reset_recovery_timer(obd, service_time, 0);
+ service_time += 2 * INITIAL_CONNECT_TIMEOUT;
+
+ LASSERT(obt->obt_magic == OBT_MAGIC);
+ lsi = s2lsi(obt->obt_sb);
+ if (!(lsi->lsi_flags | LSI_IR_CAPABLE))
+ service_time += 2 * (CONNECTION_SWITCH_MAX +
+ CONNECTION_SWITCH_INC);
+ service_time -= obd->obd_recovery_timeout;
+ if (service_time > 0)
+ extend_recovery_timer(obd, service_time);
}
-#ifdef __KERNEL__
-
/** Health checking routines */
static inline int exp_connect_healthy(struct obd_export *exp)
{
/** Checking routines for recovery */
static int check_for_clients(struct obd_device *obd)
{
+ unsigned int clnts = cfs_atomic_read(&obd->obd_connected_clients);
+
if (obd->obd_abort_recovery || obd->obd_recovery_expired)
return 1;
- LASSERT(obd->obd_connected_clients <= obd->obd_max_recoverable_clients);
+ LASSERT(clnts <= obd->obd_max_recoverable_clients);
if (obd->obd_no_conn == 0 &&
- obd->obd_connected_clients + obd->obd_stale_clients ==
- obd->obd_max_recoverable_clients)
+ clnts + obd->obd_stale_clients == obd->obd_max_recoverable_clients)
return 1;
return 0;
}
req_transno = 0;
}
- connected = obd->obd_connected_clients;
+ connected = cfs_atomic_read(&obd->obd_connected_clients);
completed = connected - cfs_atomic_read(&obd->obd_req_replay_clients);
queue_len = obd->obd_requests_queued_for_recovery;
next_transno = obd->obd_next_recovery_transno;
* reset timer, recovery will proceed with versions now,
* timeout is set just to handle reconnection delays
*/
- reset_recovery_timer(obd, RECONNECT_DELAY_MAX, 1);
+ extend_recovery_timer(obd, RECONNECT_DELAY_MAX);
/** Wait for recovery events again, after evicting bad clients */
goto repeat;
}
lu_context_fini(&req->rq_recov_session);
/* don't reset timer for final stage */
if (!exp_finished(req->rq_export)) {
+ int to = obd_timeout;
+
/**
* Add request timeout to the recovery time so next request from
* this client may come in recovery time
*/
- reset_recovery_timer(class_exp2obd(req->rq_export),
- AT_OFF ? obd_timeout :
- lustre_msg_get_timeout(req->rq_reqmsg), 1);
+ if (!AT_OFF)
+ to = lustre_msg_get_timeout(req->rq_reqmsg);
+ extend_recovery_timer(class_exp2obd(req->rq_export), to);
}
reqcopy_put:
RETURN(rc);
" after %lds (%d clients connected)\n",
obd->obd_name, cfs_atomic_read(&obd->obd_lock_replay_clients),
cfs_time_current_sec()- obd->obd_recovery_start,
- obd->obd_connected_clients);
+ cfs_atomic_read(&obd->obd_connected_clients));
obd->obd_recovery_expired = 1;
cfs_waitq_signal(&obd->obd_next_transno_waitq);
obd->obd_recovery_start = 0;
obd->obd_recovery_end = 0;
- /* both values can be get from mount data already */
- if (obd->obd_recovery_timeout == 0)
- obd->obd_recovery_timeout = OBD_RECOVERY_TIME_SOFT;
- if (obd->obd_recovery_time_hard == 0)
- obd->obd_recovery_time_hard = OBD_RECOVERY_TIME_HARD;
cfs_timer_init(&obd->obd_recovery_timer, target_recovery_expired, obd);
target_start_recovery_thread(lut, handler);
}